[00:02:46] (03CR) 10Catrope: [C: 04-1] "Minor documentation glitch, otherwise good to merge" (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/112148 (owner: 10Krinkle) [00:08:18] (03CR) 10Catrope: [C: 032] Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [00:09:27] (03Merged) 10jenkins-bot: Mark disambiguation and redirect pages in the link inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110654 (owner: 10Alex Monk) [00:15:45] TrevorParscal: http://imgur.com/XBZa0up,z52JB3C,nlxqscI [00:17:18] (03CR) 10Krinkle: [C: 032] Fixes for 239bae7512 (mobile toolbar) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112127 (owner: 10Catrope) [00:17:36] James_F, I think you mentioned that there were other tools which should become aware of disambig/redirect pages? [00:17:52] Krenair: So the reward for a job well done is two more jobs ;) [00:18:06] I take it you've got them in your inbox already? [00:18:11] RoanKattouw, I agree that they should be pluralised. I kept them disambig and redirect ones consistent with matching (which already existed) [00:18:13] yeah [00:18:27] Yeah that's how I defended it to James to, as continuing an existing thing [00:18:27] (03Merged) 10jenkins-bot: Fixes for 239bae7512 (mobile toolbar) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112127 (owner: 10Catrope) [00:18:29] RoanKattouw: __DISAMBIG__ is already recognised in Parsoid, so… yes. [00:18:34] k [00:18:43] I'll file a bug [00:18:55] Want that assigned to you (as the author of most of the other __MAGICWORDS__ code) or Krenair? [00:20:48] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=61073. [00:24:32] (03CR) 10Krinkle: [C: 032] Make this.loading abortable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 (owner: 10Catrope) [00:25:22] From sunday: [01:21:22] Krenair: Also, does your patch only apply to the link suggestion box, or also for transclusion and category suggestion? [00:25:31] [01:21:39] James_F, only for link suggestion... [00:25:31] [01:21:44] Ah. Boo. [00:25:41] (03Merged) 10jenkins-bot: Make this.loading abortable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111666 (owner: 10Catrope) [00:25:44] Should I do it for those as well? [00:28:03] mooeypoo: Is https://gerrit.wikimedia.org/r/#/c/105247 ready to go? [00:28:22] Krenair: Yeah, please do. [00:29:48] Krenair: James has just explained what you're up to (redirects for templates and categories etc.). You might want to consider putting some of your code in MWTitleInputWidget (which I believe is the parent class of MWLinkTargetInputWidget, or should be, or mixed in, or whatever) instead [00:30:09] Yeah. [00:30:15] * James_F is just making trouble. [00:30:17] Ugh, there's no relation between MWLinkTargetInputWidget and MWTitleInputWidget [00:30:18] * James_F slinks off. [00:30:21] That's pretty terrible [00:30:23] Oh goody. [00:30:28] I blame TrevorParscal. [00:30:40] Krenair and TrevorParscal: Could you guys work together to rectify that atrocity? [00:31:02] Well I could certainly try [00:31:05] (03PS25) 10Jforrester: Let users set #REDIRECT and __STATICREDIRECT__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95213 [00:31:32] Krenair: TrevorParscal is engaged in conversation with Krinkle and jdlrobson right now, but you guys should talk before either of you goes off and restructures things [00:31:40] Deffo. [00:34:05] RoanKattouw: gerrit 95213 was blocked on https://bugzilla.wikimedia.org/show_bug.cgi?id=59673 which is "FIXED" and was deployed on Monday. [00:34:11] RoanKattouw: https://www.mediawiki.org/wiki/Parsoid/Deployments#Monday.2C_Feb_3.2C_2014_.40_11:30_am_PST_Y_Deployed_2d663eb [00:34:13] !g 95213 [00:34:13] https://gerrit.wikimedia.org/r/#q,95213,n,z [00:34:20] Right [00:34:27] So, good to go, apparently. [00:34:40] Though actual testing is probably needed. :-) [00:34:47] I'm now testing 105247 [00:34:53] Kk. [00:35:46] (03PS1) 10Alex Monk: Pluralise visualeditor-linkinspector-suggest-(matching|redirect|disambig)-page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112164 [00:41:14] (03CR) 10Catrope: "It seems to work OK, but I don't think this UI is very clear." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [00:41:36] (03CR) 10Catrope: [C: 04-1] Add image type change to media edit dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 (owner: 10Mooeypoo) [00:42:07] (03PS9) 10Catrope: Add image type change to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 (owner: 10Mooeypoo) [00:43:20] James_F, what are these classes/styles Roan mentioned? [00:43:23] Krenair: BTW, if you're going to close bugs, please remember to tag them with the milestone they'll go out with. :-) [00:43:49] Ugh, yeah, sorry. I forgot VE does that. [00:43:56] (03CR) 10Catrope: [C: 032] Add image type change to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 (owner: 10Mooeypoo) [00:44:07] (03PS2) 10Mooeypoo: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 [00:45:00] (03CR) 10jenkins-bot: [V: 04-1] Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [00:45:40] Krenair: No worries. [00:45:50] (03Merged) 10jenkins-bot: Add image type change to media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/105247 (owner: 10Mooeypoo) [00:46:08] James_F, I wasn't aware there were special classes/styles for disambig/redirect pages? [00:46:22] Krenair: Also: Classes. Kaldari says that the classes haven't been implemented in MW core yet because they're expensive with MW's PHP parser, so don't worry about it. [00:46:33] Krenair: The plan was to have them, but they're not implemented yet. [00:46:38] heh, okay. [00:46:44] Redirects? [00:46:49] For both. [00:47:34] Krenair: When we switch to Parsoid-generated HTML with CSS hinting, we might be able to have them for read-side HTML too. [00:47:44] So, in summary: Ignore me. [00:48:03] James_F, what to do with https://bugzilla.wikimedia.org/show_bug.cgi?id=61072 ? [00:49:40] Krenair: I'm marking it blocked by bugs 166 and 7936. [00:49:54] Krenair: I can un-assign it from you if you want. [00:50:11] {{done}} [00:50:21] yes please [00:50:25] thanks [00:50:49] In VE we generally use default assignment for components. [00:51:13] Maybe we should default-assign to "VE team" . :-) [01:01:00] (03PS3) 10Catrope: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [01:08:35] (03CR) 10Catrope: [C: 04-1] "Code looks fine. Functionality feedback from James:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [01:10:59] (03CR) 10Jforrester: Revamp media edit dialog's position widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [01:18:47] (03CR) 10Catrope: [C: 032] Pluralise visualeditor-linkinspector-suggest-(matching|redirect|disambig)-page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112164 (owner: 10Alex Monk) [01:19:55] (03Merged) 10jenkins-bot: Pluralise visualeditor-linkinspector-suggest-(matching|redirect|disambig)-page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112164 (owner: 10Alex Monk) [01:20:19] /quit [01:21:01] TrevorParscal / Krinkle: ^^^ Does that make sense to you? [01:21:30] James_F: quit QUIT sends a message to the IRC server letting it know you would like to disconnect. [01:21:39] The quit message will be displayed to the users in the channels you were in when you are disconnected. [01:21:44] Krinkle: Wrong line. [01:21:46] It makes sense :P [07:24:26] Hi all. Would it be allowed to make the 'insert a template' dialog query a website, such as to fill in a {{cite journal}} (whatever its name is) template by DOI? [23:57:27] gry: We're building that, so… yes. [23:57:43] Aah, perfect. Thanks.