[00:02:07] James_F, aha? [05:43:42] (03PS4) 10Mooeypoo: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 [05:44:18] (03CR) 10jenkins-bot: [V: 04-1] Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [05:50:35] (03PS5) 10Mooeypoo: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 [05:52:38] (03CR) 10jenkins-bot: [V: 04-1] Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [10:41:59] (03Abandoned) 10Hashar: [browser test] Cucumber default profile for CI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/100797 (owner: 10Hashar) [13:44:14] (03PS5) 10Jhall: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [13:44:26] (03CR) 10Hashar: "gem mediawiki_ruby_api_client has been is renamed to mediawiki_api" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [13:45:38] (03CR) 10jenkins-bot: [V: 04-1] [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [13:48:38] (03PS6) 10Hashar: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [13:49:31] (03CR) 10Hashar: [C: 031] "mediawiki_selenium 0.2.0 -> 0.2.1 (which brings screenshot system)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [13:49:50] (03CR) 10jenkins-bot: [V: 04-1] [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [14:09:01] (03PS7) 10Hashar: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [14:09:23] (03CR) 10Hashar: "and renamed the import from MediawikiRubyApiClient to MediawikiApi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [14:10:14] (03CR) 10jenkins-bot: [V: 04-1] [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [16:12:57] Hi poo [16:13:10] mooeypoo* woops. that was an accident. [16:13:18] sorry [16:14:11] Mooey the pooh, mooey the pooh [16:14:15] -.- [16:14:30] I typed the wrong part first and didn't check before tab-autocomplete and enter, ok [16:14:35] Heh [16:14:49] I'm enjoying your mistake, don't worry about it [16:15:24] mooeypoo, anyway I was wondering if you knew anything about the surface stuff? I was looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=42139 [16:26:12] hah mooey the pooh. [16:26:16] Close enough :p [16:28:02] Krenair, I can probably at least try to answer, and worse case I can refer you to the surface experts. ;) What did you have in mind for this? [16:30:05] You should take a look at the way dialogs are done [16:30:53] I am not sure what you mean by mini surface, though...? [16:32:35] Whatever James meant by "to be resolved by the dialog being a mini-VE surface." [16:48:45] I'm not entirely sure what he meant; maybe the fact that dialogs use their own embedded surface, so they act as a "mini" editor, which means you can open dialog in dialog. [16:50:05] Krenair, I suggest you start by going over dialogs in general, see how they work. See ve.ui.MWSaveDialog specifically, I'm going over it now to see if I can give you some pointers on how to start with this, (though Trevor will probably be more help) [16:50:10] and here's James_F :D [16:50:18] Hey mooeypoo, Krenair. [16:50:25] heya [16:50:27] Ah hi James_F [16:50:35] Did you manage to get into the office last night? [16:51:18] Yes, eventually. [16:52:03] James_F, so I was looking through another one of the bugs you assigned me - https://bugzilla.wikimedia.org/show_bug.cgi?id=42139 [16:52:29] You said it needed to be done as a mini-VE surface [16:52:58] Krenair, check out ve.ui.MWSaveDialog, I am looking at line #281 specifically where the savePanel is in (and then gets a TextInputWidget for 'editSummaryInput'. [16:53:03] Do you know where I would start in creating a mini surface? [16:54:10] mooeypoo, yeah I know about how the edit summary stuff is put together, but I think he means that instead of you putting wikitext into that box, the summary should all be visualeditor-able. I'm not sure how to do that [16:54:43] oh oh [16:55:24] okay, so for that you can check the other instances where you have that, like MWMediaEiditDialog's 'caption' [16:56:05] Krenair, check out "this.captionSurface" in ve.ui.MWMediaEditDialog [16:56:35] it uses a 've.ui.SurfaceWidget' [16:57:38] (03PS3) 10Hashar: Fix some more places broken by wgDebugToolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112407 (owner: 10Alex Monk) [16:57:38] which, I guess, is a sort of a mini surface (James_F can pitch in here if I am misunderstanding the question or his reply in the bug) [16:58:27] That sounds like it does what I want. Will look into it, thanks mooeypoo [16:58:28] btw, James_F while working on the position fixups and your comments I also noticed that I didn't have "default" position (didn't even realize it existed) for images, which is different than an explicit 'none'. I added that in, but I'm not sure if that's exactly the right place (it's part of the toggle widget now) [16:58:44] Krenair, notice that there are surface settings you have to also work with that are defined at the top of that dialog [16:58:50] (03CR) 10Hashar: "yup GlusterFS was readonly on the labs project "integration". npm could not delete some directories, I have moved the jenkins-deploy user " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112407 (owner: 10Alex Monk) [16:59:06] Krenair, specifically "ve.ui.MWMediaEditDialog.static.toolbarGroups" [16:59:10] (03CR) 10Alex Monk: "Thanks Hashar!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112407 (owner: 10Alex Monk) [16:59:21] (03CR) 10Hashar: "GlusterFS was readonly on the labs project "integration". npm could not delete some directories, I have moved the jenkins-deploy user home" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [16:59:26] Krenair, and "ve.ui.MWMediaEditDialog.static.surfaceCommands" [17:00:58] James_F, anyways, I think that the fix might be okay for now, but at some point, it might look better if maybe there were two select widgets there? "left | center | right" ___ " Wiki's default | none " ? for the moment, 'wiki's default' is in with left/center/right. It got a bit confusing UI-wise, though. [17:07:31] Sorry, back now. [17:07:45] Krenair: A mini-surface for edit summaries is possibly a bit premature; I was thinking about just having a preview of the rendered wikitext in the diff viewer. [17:08:03] Krenair: Sorry, I should have been clearer. [17:08:24] mooeypoo: Umm. I'm not sure that "default" for position is necessary for the user, is it? [17:09:09] mooeypoo: Instead, show as right (or whatever) and it's up to Parsoid to simplify the wikitext if needed? [17:09:47] James_F, why not? when I saw 'none' I actually thought it was default. [17:10:38] James_F, so just: on update of the input box, action=parse the text and show it as a preview? [17:10:44] And you might get editors who don't know what to use. Also, how do I indicate images with 'default' in the buttons if it isn't there? If I leave it as unchecked (which is 'none') do I assume the use didn't want to change anthing, or do I assume the user knowingly wanted to change from 'default' to 'none' ? [17:11:36] mooeypoo: It's an artefact of wikitext, not an actual setting. [17:12:08] mooeypoo: Unlike default size, default position isn't something I think we need a button for. [17:12:16] mooeypoo: But I could be argued around. :-) [17:12:19] James_F, sure, but then the user needs to see what the image is aligned to. So either I check what 'default' means to indicate it to the user (left/right/whatever) or we have 'default' button [17:12:27] What I'm worried most about is changes to the image. [17:12:50] mooeypoo: Checking what the site default is is going to be needed for size anyway, so we might as well check for that. [17:13:04] mooeypoo: Though I /think/ that site default == RTL or LTR status. [17:13:24] Krenair: In the diff window, yeah. [17:13:47] James_F, if I start with an image that is position=default, and I go into the edit dialog -- (a) I won't see the position in the indicator, and assume it is 'none'. (b) OR, I am experienced and know it's not none, but don't want to change it, so I just close off the window -- but then now what? did I mean 'set default to none' because 'none' is now the option, or did I mean 'don't touch this' [17:13:51] see what I mean? [17:13:53] Krenair: Remember there are different parse rules for log entries compared to content. [17:13:58] mooeypoo: No. [17:14:01] yeah, maybe another API call would be needed. [17:14:49] mooeypoo: When you edit an image that is position default, it shows as "right" (or whatever). You can change it to "left" and it works. You can change it back to "right" and it works. Ideally, Parsoid notices that you've made it default position rather than just explicit right, but that's not VE's concern (and certainly not the user's). [17:15:19] James_F, yep... I think action=parse handles that? [17:15:30] Krenair: With a flag, I think, yeah. [17:15:39] default != right in rtl languages [17:15:53] https://www.mediawiki.org/w/api.php?action=parse&summary=[[Hello_world]] [17:15:53] we should be looking at the css classes [17:16:08] James_F, I don't think parsoid knows that for the moment, when I changed 'default' to "left" (which is supposedly my local wiki's default) it added |left to wikitext, which is why I htought of removing the attribute alltogether, but I see what you mean. [17:16:51] mooeypoo: Sure. [17:16:52] gwicke, yes, that's why I assume I would need to get the actual default setting [17:16:55] gwicke: Indeed. [17:17:08] O [17:19:18] Krenair: And https://www.mediawiki.org/w/api.php?action=parse&summary={{[[Template:Hello_world|Hello_world]]}} indeed. [17:19:55] yes, I checked template expansion etc. didn't work. [17:20:18] So happiness. [17:21:07] James_F, I don't think I even need to make another API call. The wiki settings vars are accessible through mw.config.get, no? [17:22:12] James_F, so when the diff is shown ('Review your changes' dialog) we want to parse the summary and display it [17:22:14] mooeypoo, you should set the default class if nothing was user-specified [17:23:04] Krenair: Yeah. [17:23:17] mooeypoo: Yes, think so. [17:23:24] gwicke, aye. I'm looking for the system setting's variable that declares what the default position is [17:24:44] hm. James_F do you know if there's an actual configuration option for this, or if this is strictly a language byproduct? like, ltr = default right, rtl = default left ? [17:24:59] I can't find a variable in the settings http://www.mediawiki.org/wiki/Manual:Configuration_settings [17:25:08] mooeypoo: It might be just automatic. [17:26:03] Hm. I guess we can make an assumption based on wiki direction (which is even easier, it's just ce's surface .getDir() but I might verify that there's no way to override this per wiki [17:26:17] * James_F nods. [17:46:54] (03PS5) 10Jhall: [Browser test] VisualEditor availability on prod wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 [18:15:00] Hey fellow VE users. A friend of I have got VE working on a windows install with the exception of media browsing in the VE editor. CommonsRepo works but LocalRepo doesn't. [18:17:29] I noticed some differences in the JSON parameters returned by the commons vs local and wondered if I should be defining more than just $wgUploadDirectory and $wgEnableUploads.... [18:20:02] Win-MW, do you get any errors? [18:20:36] localrepo SHOULD (theoretically) have the API params set, except for two that we're accounting for (hopefully properly) in the media insert dialog. [18:21:19] Can you see if a request goes to the local API at all, and if so, what it returns? [18:21:21] http://pastebin.com/rGH9LLkn - Here is the paste bin of what "api.php?format=json&action=query&meta=filerepoinfo" returns. [18:21:28] oh perfect [18:21:30] hang on [18:21:48] thats with commons on just for comparison [18:23:15] ha, interesting [18:23:26] no apiurl and scriptDirUrl is empty [18:25:07] hmm. There *seems* to be an inconsistency in API response. I'm not sure if it's something you need to explicitly set or if it's something we should account for in VE. James_F who can I ask about API responses regarding 'filrerepoinfo' ? [18:27:49] mooeypoo: RoanKattouw_away is probably best. [18:28:21] Win-MW, let me try something. Do you have $wgScriptPath set in LocalSettings ? [18:28:43] James_F, hm, ok, we might have to ask him if my attempt fails. [18:29:04] * James_F nods. [18:30:08] (03PS8) 10Jhall: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [18:30:28] Win-MW: What version of MediaWiki are you using? [18:30:44] oh hi RoanKattouw ! I thought you left [18:30:51] My midterm is in the afternoon [18:30:58] ah okay. [18:31:34] This is weird. If I understand the api doc correctly, "scriptDirUrl" is equivalent to $wgScriptPath [18:31:40] thanks for taking a look.. its MW1.23 [18:31:42] which should be set in LocalSettings by default [18:32:06] It was 1.19 and was upgraded in place to 1.23 [18:32:16] * Robert_L works with Win-MW  [18:32:32] $wgScriptPath is empty... the references work for that path though for other things [18:34:12] oh, it's empty? should it be empty? [18:34:20] * mooeypoo refers to RoanKattouw's expertise on this [18:34:44] Ahm [18:35:00] Win-MW: What is the URL to index.php ? [18:35:10] Is it http://example.com/index.php ? [18:35:49] RoanKattouw, yes, it's example.com/index.php?title=Main_Page [18:35:55] OK [18:35:56] or whatever else [18:36:03] Then $wgScriptPath being empty sounds right [18:36:08] maybe set the script path to '/' ? [18:36:48] (03PS1) 10Alex Monk: Show preview of edit summary in review screen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112490 [18:37:15] RoanKattouw, oh, no, wait, the url in the media search widget is set to source.scriptDirUrl + '/api.php' [18:37:27] but I think I see the problem [18:37:50] making it / broke all kinds of stuff, like trying to resolve skins and domains [18:37:53] RoanKattouw, can you confirm? line #110 in ve.ui.MWMediaSearchDialog. This would skip the entire operation if scriptDirUrl is empty. [18:38:01] (03CR) 10jenkins-bot: [V: 04-1] Show preview of edit summary in review screen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112490 (owner: 10Alex Monk) [18:38:13] The condition should change to if ( ... || source.scriptDirUrl !== undefined ) [18:38:33] mooeypoo: Yes exactly [18:38:37] * mooeypoo nods [18:38:41] I was about to say that [18:38:55] yay for troubleshooting [18:39:01] * mooeypoo will whip up a commit in a sec [18:39:02] Robert_L , Win-MW: It looks like your unusual $wgScriptPath setting has exposed a bug in our code :) [18:39:24] (03CR) 10Alex Monk: [C: 04-1] "This isn't very nice at the moment because it does things twice: Once in #setDiffAndReview for the first time the review dialog opens, and" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112490 (owner: 10Alex Monk) [18:40:10] RoanKattouw, is there something we can hack quickly to make it work until a bug is submitted, tested and merged into master? [18:42:37] Robert_L: That whole process should be very quick [18:43:04] mooeypoo should have a fix in any minute and I'll merge it right away [18:43:12] RoanKattouw, (please see above change) - is there some way I can run code each time someone opens the review dialog? (not just the first time it opens) [18:43:14] The fix is pretty simple anyways [18:43:31] In MWMediaSearchWidget.js on line 110, change source.scriptDirUrl to source.scriptDirUrl !== undefined [18:43:36] (03PS1) 10Mooeypoo: Make MWMediaSearchDialog not ignore empty scriptDirUrl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112491 [18:43:39] Krenair: So there's initialize and setup [18:43:48] initialize runs once, setup runs every time it's opened [18:43:49] RoanKattouw, I couldn't test on the same scenario though [18:44:05] (03CR) 10Catrope: [C: 032] Make MWMediaSearchDialog not ignore empty scriptDirUrl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112491 (owner: 10Mooeypoo) [18:44:05] RoanKattouw, mooeypoo cool, thanks for working on this. We're not live yet, so we can wait for the fix [18:44:05] I checked that it ran on my local wiki (but its script path is /wiki and not empty) [18:45:18] Robert_L, Win-MW thanks for finding the bug! [18:45:36] RoanKattouw, I just shoved a console.log in there - only seems to be run when the save dialog comes up. I'm trying to pick up when someone opens the review part of it [18:45:48] (03Merged) 10jenkins-bot: Make MWMediaSearchDialog not ignore empty scriptDirUrl [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112491 (owner: 10Mooeypoo) [18:46:44] so FWIW our MW was installed using the web platform installed, which is a way to one-click deploy MW on windows platforms [18:47:22] there's a one-click deploy for windows? [18:47:53] yeah, search for web platform installer, you can one-click tons of stuff [18:48:05] its technically more like 3 or 4 clicks, but there is zero conf editing required [18:48:08] well, to be fair, my main issues was to set up a development environment... but that would definitely help [18:48:16] Robert_L, woot, thanks! [18:48:20] Krenair: Oh, that [18:48:29] Ahm, what do you need it for? [18:48:46] mooeypoo, FYI though at present the MySQL installer in the WPI is broken ... I'm contacting someone there to try and get it fixed [18:49:07] so you have to do your own MySQL install, then the WPI does the rest [18:49:20] oh, I'm using EasyPHP on windows for LAMP , but I am not sure it's right for actual live stuff [18:51:11] mooeypoo, the WPI sill set it up for IIS. It auto-installs PHP 5.4 for you as well. Personally I'm not a fan of Apache on Windows server [18:52:12] Robert_L, yeah, IIS is probably best for a live site. My system is for development, so I was going for the easier-but-works sort of solution. Also, I.. have... windows 8. That tends to make things a bit more difficult :\ [18:54:00] mooeypoo, I think IIS in Windows 8 is the whole thing. I think Vagrant works on Windows now if you want a dev environment quickly [18:55:40] Robert_L, I had a lot of problems with Vagrant on Windows 8. I eventually managed to have SOMETHING going, but then revived my old PC and now I have ubuntu on it, which is much better as a dev environment [18:56:14] but I should re-try Vagrant at some point. Had issues with git for windows, but I think those should be set now, if I remember according to the support forums [18:56:41] mooeypoo, vagrant with windows should work fine with VirtualBox. VMWare might be a hassle [18:56:50] I have both [18:57:16] Git for windows works great. I use the windows command line version though so that I'm not fighting with some hackish BASH prompt on my Win7 box [18:57:31] Robert_L, in Windows 8? [18:58:06] mooeypoo, I've not tried Windows 8, but the MediaWiki we're discussing is running on Windows 2012 R2 which is basically the same thing, and I upgraded it with git [18:58:12] It works for me now, but that's relatively new.. it didn't work properly for a while in cooperation with vagrant, I got weird errors trying to run 'vagrant up' and such. [18:59:22] Yeah it may have also been something local to my machine. Not sure. I was in a bit of a hurry to find a solution so I can stop mucking about and actually do work. I ended up working with a VM, and now with a separate ubuntu box [19:01:17] ubuntu == debian testing :) [19:01:28] * Robert_L prefers debian stable [19:01:53] I am a relative linux newbie, so I went for the one that seemed to be the most noob-friendly [19:02:19] where's marktraceur to beat me over the head about GNU/linux.... [19:05:00] (03CR) 10Hashar: [Browser test] Headless browser test(s) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [19:07:25] RoanKattouw_away, ah, solved it with a much better way. didn't need such a function after all [19:08:41] mooeypoo, they're basically the same thing. Pay no attention to my Linux distro zealotry, and thanks very much for checking into our bug [19:09:05] (03PS2) 10Alex Monk: Show preview of edit summary in review screen [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112490 [19:09:41] Robert_L, thanks for finding it! :) [19:10:40] Robert_L, hopefully one day I'll be as hard-core linux'er as to passionately advocate one distro over the other, as well as one cli editor over the other...... :p [19:10:58] I see it's merged, I'll upate our side and see what happens [19:11:04] I hear that's a big deal too. [19:11:25] Robert_L, yes! if you can, that'll be great. I tested on my local wiki, but it isn't set up to be on the root of the domain. [19:14:50] mooeypoo, looks like it worked, I got some images, main page screen shots, I didn't know were in our wiki [19:16:28] mooeypoo, it looks like its serching commons instead of my local repo [19:17:15] mooeypoo, yep, it's searching commons [19:19:00] and FYI what I did was go to extensions\VisualEditor and do a git pull [19:23:57] yay [19:24:07] wait [19:24:09] not yay [19:24:43] Robert_L, it's searching commons without your local repo? [19:24:46] yea it went from searching nothing to searching commons, but that might not be related to your change [19:25:03] it should search commons, but it should also search your local wiki [19:25:04] mooeypoo, correct. If I enter the name of an image which is in my local repo, nothing comes up [19:25:26] .... meh. Can you again do a pastebin of what the api response was? [19:25:34] sure, 1 sec [19:27:02] mooeypoo, it used the commons API [19:27:09] no local? [19:27:27] nope, only one get, to commons [19:27:31] hm. [19:28:15] Robert_L, can you submit this to bugzilla? I'm going to take a closer look, but it seems to be something a bit more than "just" a simple fix. [19:28:40] firebug doesn't let you copy the whole thing? You have to choose headers, response, etc. Bah, a pox on Firebug [19:28:43] mooeypoo, sure, URL? [19:29:13] https://bugzilla.wikimedia.org/enter_bug.cgi?product=VisualEditor [19:29:30] when you have a URL paste it here, I'll take it on [19:30:04] I have to finish a couple of things here in the middle of this commit i'm in, so I want ot make sure all the details are in front of me when I deal with this. [19:30:46] (03PS9) 10Jhall: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [19:31:44] mooeypoo, will do. What do you need in the ticket? LocalSettings? Output from request/response? [19:32:46] if you can put in the api request/response that'll be great [19:33:13] I'll go over it, and if I have any other questions I'll post in the bug, we'll go from there. I have a feeling this is something deeper with the way the search widget goes over the sources. [19:34:11] (03CR) 10Cmcmahon: [C: 04-1] "I waver between a -1 and 0-no-score. I think I would prefer doing this with the create-user API, if for no other reason than to guarantee" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [19:36:24] mooeypoo, URL is https://bugzilla.wikimedia.org/show_bug.cgi?id=61151 [19:37:06] (03PS6) 10Jhall: [Browser test] VisualEditor availability on prod wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 [19:38:08] (03CR) 10Cmcmahon: [C: 031] "If the VE team wants to pull the trigger on this, I think it will do what it says it will." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 (owner: 10Jhall) [19:39:42] (03CR) 10Jforrester: [C: 032] [Browser test] VisualEditor availability on prod wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 (owner: 10Jhall) [19:39:47] mooeypoo: so, could we spend a couple of hours, starting in 1:20 from now? [19:40:11] TrevorParscal, 1:20 your time? [19:40:22] no, that's 1 hour and 20 minutes from now [19:40:32] so, 1pm my time [19:40:52] James_F: Hey, so I have comments on https://bugzilla.wikimedia.org/show_bug.cgi?id=51947 https://bugzilla.wikimedia.org/show_bug.cgi?id=52982 and https://bugzilla.wikimedia.org/show_bug.cgi?id=50763 waiting for replies [19:40:54] (03Merged) 10jenkins-bot: [Browser test] VisualEditor availability on prod wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111142 (owner: 10Jhall) [19:41:05] oh hah, I'm free all day today 'till about 6:30-7pm my time (~3:30pm yours) where I need to leave for class. [19:41:26] mooeypoo: I'm right here [19:41:31] (this is marktraceur!)( [19:41:42] rdwrer, ... you're hiding! [19:41:46] mooeypoo: sounds like that will work well then [19:41:49] TrevorParscal, so that would be a yes :D [19:42:10] I'm not hiding, you're just not paying attention [19:42:14] will also give me time to figure out the position fixes in media edit dialog [19:42:23] ok, cool [19:42:43] rdwrer, You missed my severe abuse of linux vs gnu/linux. Very unlike you. [19:43:16] *shrug* I don't particularly mind [19:43:31] I count most of this channel as a lost cause [19:46:17] rofl [19:54:30] (03PS2) 10Trevor Parscal: Add tooltips to the drop-down menus explaining what they do [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108855 (owner: 10Jforrester) [19:56:17] mooeypoo, I cleared my cache, set $wgUseInstantCommons = false;, and tried again [19:56:31] oh! and? works? [19:56:54] no :( I'll do a pastebin of the filerepo query [19:57:59] Krenair: Followed-up; sorry! [19:58:01] mooeypoo, http://pastebin.com/nKgRS0x6 [20:00:38] Robert_L, can you add that to the bug? [20:01:05] hm. This shows the code *gets* the local source. I wonder why it's not using it, though. Is there any other requests? [20:05:25] James_F, thanks. Any idea what that 'thermometer' they're talking about on 52982 is? [20:05:41] Krenair: Not sure - I think maybe the loading animated GIF? [20:06:06] The loading animation thing? [20:06:21] Yeah. [20:06:41] (03PS6) 10Mooeypoo: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 [20:06:50] That doesn't come up when I open the save dialog.. [20:06:56] mooeypoo, updated. thanks [20:07:36] James_F, ^^ I added a check for 'default' changes at the end, it's not perfect (wont' work if the dialog is applied and the re-edited) but it will prevent most of the unnecessary dirty diffing, I think [20:07:46] * James_F nods. [20:07:55] Robert_L, awesome, I'll take a closer look. [20:08:28] Krenair: I think I'm just going to close as WORKSFORME. [20:09:01] ok [20:10:11] Krenair: Want to tackle https://bugzilla.wikimedia.org/show_bug.cgi?id=52004 or https://bugzilla.wikimedia.org/show_bug.cgi?id=58057 instead? ;-) [20:10:28] sure [20:26:26] ryasmeen, I can't manage to reproduce your latest bug in master, and I just checked wmflabs one in Chrome under windows, adding new image and changing it from the default 'thumb' to 'frameless' and it works there as well... am I missing something? [20:27:41] okay mooeypoo, let me re-test it again [20:28:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=61153 This one right? [20:29:49] hm, James_F I'm not sure if it's something I"m doing wrong or if this is a bug -- I'm testing stuff on a roughly edited copy of the advanced media wikitext, which, granted, includes some sections -- but when I add images, I occasionally get the "wikitext markup detected" even though the image was added OUTSIDE the block. Is this known? [20:29:52] ryasmeen, yep [20:31:51] James_F, ohhh I have an idea why this happens.... let me see if my knowledge of how the transactions work is improved: When a new images is added into a paragraph, it rebuilds itself around it, right? As a block. Could that mean that if the next paragraph (the one I originally tried to insert the image to) is rebuilt as well, and VE "thinks" it's a new one with wikitext? (does this even makes any sense) ? [20:39:58] mooeypoo, added my comment in the bug.There is an additional step in the step to reproduce, which I missed [20:42:02] ooh [20:43:13] mw.msg( 'blockedtext' ) -> blockedtext: Unknown operation "mediawiki" [20:43:30] Because that message includes "{{MediaWiki:Grouppage-sysop}}" [20:46:25] that's annoying.. [20:47:13] Krenair: mw.message(…).plain() [20:48:40] Krenair: alternatively, cc yourself on one of the numerous jquerymsg bugs, this is probably filed [20:48:48] (.plain() just make the library stop trying to parse things, it supports {{plural and {{gender and something) [20:48:49] makes* [20:52:12] MatmaRex, that's great but it must be parsed fully [20:52:34] MatmaRex, because of this: http://bug-attachment.wikimedia.org/attachment.cgi?id=12954 [20:53:45] Krenair: it could probably be implemented (if you dare) [20:54:08] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=43513 [20:54:30] hmmm [20:54:48] Krenair: the problem is that this, unlike {{int:}}, transcludes the message in wiki content language instead of user language [20:55:26] Krenair: so you're looking at some resourceloader changes, probably, or implementing asynchronous mw.message with API calls to get the actual messages [20:56:12] MatmaRex, yes I think I'm just going to have to send back to the server to parse it (action=parse) :/ [20:57:10] ryasmeen, this is weird. The frameless image comes out ok in wikitext, but then VE treats it as inline... O.o [20:59:14] Yup [20:59:19] TrevorP|Away, I'm going to get myself a cup of tea and then I'm all yours. [21:06:15] ryasmeen, I'm going to need to talk to RoanKattouw_away about this. I think I know what's going on, but I will need some assistance with it. [21:06:54] Sure mooeypoo [21:07:54] TrevorParscal, I'm here for whenever you want to start. [21:10:22] ryasmeen, I added to the bug report, will ask RoanKattouw_away about it tomorrow [21:18:00] mooeypoo: hi [21:18:30] heya [21:19:27] ok should I pull a patchset? [21:19:41] mooeypoo: so, all the image data is given to us in a json blob, no wikitext of any sort, right? [21:20:23] the wikitext is translated to json, yeah [21:20:37] (03PS4) 10JGonera: Make MobileViewTarget scroll to desired section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110655 [21:20:57] is there any additional information we will need to get from the server, or is it all there (so far)? [21:21:37] TrevorParscal, we need to get size information from the API, and some settings, like default thumbnail size [21:21:47] excellent, thank you [21:21:51] those are for the size widget, mostly [21:25:32] Hey jgonera. :-) [21:25:58] hey [21:26:01] eh anyone knows how to bring 'grunt' into VisualEditor repo? I ran npm install and when I try 'grunt test' it doesn't recognize grunt [21:26:39] mooeypoo: Path issue? [21:27:02] James_F, not sure. I get "No command 'grunt' found, did you mean: ..." [21:27:16] npm install didn't have any issues [21:28:06] mooeypoo: sudo npm install -g grunt-cli [21:28:11] iirc [21:28:14] ooo [21:28:22] -g = global [21:28:29] yikes, tons of errors [21:28:45] npm ERR! Error: EACCES, mkdir '/usr/lib/node_modules/grunt-cli' [21:29:05] damnit, I have been having permission errors on this box since installation. So annoying. [21:29:35] Permission errors with sudo?! [21:29:37] but in this case 'sudo' sealed it. [21:29:47] James_F, I've been having problems with mw installation and permissions [21:30:19] my default user wasn't visible to the apache server, and then when I saved the LocalSettings.php file it apparently also didn't have permissions [21:30:26] same with creating upload folder [21:30:35] messed around with a lot of permission issues :\ [21:30:54] but yah, RoanKattouw_away thanks! grunt works. [21:43:35] TrevorP|Away, do you need me to look at code or .. anything? I feel a bit useless, not sure if I should do anything right now, or move on to fix some bugs that await my attention? [21:46:38] mooeypoo: sorry, my internet connection was borked [21:46:48] I'm just working on this, I need you to answer questions mostly [21:47:18] so, the getOriginalDimensions() and getDimensions() stuff is the only async API we need to deal with, or... is there anything else? [21:47:35] I don't like how this is on the view node either... [21:48:12] For the moment these are the only API requests [21:48:25] there might be config stuff, but these should be available through the mw.config.get() [21:48:40] ok [21:48:49] I'm just sorting this out bit by bit [21:50:31] TrevorParscal: edsanders|away moved it from the UI to the node [21:50:31] He presumably had an excuse [21:50:33] yes, well why is it in the ce node? [21:51:33] (03CR) 10Jhall: "Hashar, in response to your comment on patch set 8, the mediawiki_selenium gem is a fast-moving target, and we do indeed have a version 0." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [21:52:21] TrevorParscal & RoanKattouw_away I believe it was so it communicates with scallable [21:52:23] oh, aparently it's actually in the model under getImageInfo, the fetchDimensions is a local wrapper [21:52:35] yeah, with some of that in it too [21:53:39] (03PS10) 10Jhall: [Browser test] WIP Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [21:54:32] RoanKattouw_away, do you have a second or are you preparing? I got a weird wikitext/ve issue with images, I could use your input with-- but it can wait for tomorrow ,midterm is more important [21:55:37] RoanKattouw_away, https://bugzilla.wikimedia.org/show_bug.cgi?id=61153 whenever you get a moment [21:57:28] I'm preparing and need to leave in ~15 [21:57:35] I'll be back at 6:30pm PST [21:58:58] I'll be in class, but I will come back ~11pm my time which is probably too late for you.. we can go over this tomorrow? It's a weird issue, I think it's something in the datamodel. [21:59:14] OK [21:59:21] GOOD LUCK in your midterm! :) [21:59:21] I'll be around tonight [21:59:25] Thanks :) [22:17:09] Actually going now [22:24:36] good luck! [22:50:35] TrevorParscal: Hey, do you have a link handy to the big page with all of the oojs-ui elements on it? [22:50:44] (cc RoanKattouw_away) [22:54:48] not sure about a public URL, but it's in the demos folder [22:54:54] if you have a checkout of oojs-ui [22:55:53] Ah, 'kay, thanks [22:55:59] And it's still not in core, right? [23:18:22] For the record I would really like to get oojs-ui working. [23:18:45] It seems like ButtonSelectWidget is perfect for what I need to do, with some skinning [23:21:09] rdwrer: do you need any help getting it working? [23:21:26] I am the person to ask questions to [23:21:42] By "working" I mean "in core so I don't have to hack it into my extension and break VE again later when it gets merged into core" [23:22:12] right on - well, let me know if you need any help [23:22:44] rdwrer: We'll get oojs-ui merged this week. Promise. [23:23:11] Woohoo [23:30:11] TrevorParscal, is the ButtonSelectWidget meant to be multiselect? [23:32:53] TrevorParscal, not sure if I may have found a little bug with this. It doesn't allow me to multi select visually, but it seems to not "forget" the selections if you call .selectItem() --> that means that in the media edit dialog's setup I have to run .intializeSelection otherwise it seems to have multiple selected items. [23:35:16] TrevorParscal, it seems that 'selectItem' should have 'initializeSelection' instead of 'setSelected' (that seems to set multiple items as selected?) [23:36:32] (03PS1) 10Trevor Parscal: Create new "settings" icon, move "settings" icon to "advanced" [oojs/ui] - 10https://gerrit.wikimedia.org/r/112603