[00:54:02] (03CR) 10Jforrester: "An update on Roan's comment, bugs 59673 and 59674 are fixed in Parsoid in production; bug 59671 is fixed in Parsoid master and is planned " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95213 (owner: 10Jforrester) [01:03:26] Am I right in thinking that the category data comes from Parsoid? If so then it might be useful to include whether the category is hidden or not? For https://bugzilla.wikimedia.org/show_bug.cgi?id=50763 ... [01:09:01] (03PS1) 10Jforrester: Pass 'pst' as true in parse request for fragments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112829 [01:09:19] * gwicke sighs at 'Users can choose to see hidden categories in a separate "Hidden categories" list, by checking "Show hidden categories" in the "Appearance" section of Special:Preferences.' [01:09:42] gwicke: Yeah… Yay for confusing interface options. [01:09:44] another thing to implement in CSS [01:09:53] gwicke: *Yet another thing. [02:03:47] (03CR) 10Krinkle: [C: 04-1] "When I check this out locally, the change doesn't apply. I tried purging everything a user can reasonably do, and it just won't." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112814 (owner: 10Trevor Parscal) [03:09:07] (03CR) 10Jforrester: [C: 04-1] "Needs rebase, Roan to review Timo's feedback." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107540 (owner: 10Catrope) [03:20:01] RoanKattouw: Hey, BTW. Clearly you didn't swing by the office so the PostIt I left on your screen will await your arrival tomorrow. :-) [03:20:59] What's on it? [03:21:10] (03CR) 10Catrope: [C: 032] Pass 'pst' as true in parse request for fragments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112829 (owner: 10Jforrester) [03:21:25] RoanKattouw: Not ^^^ actually. :-) [03:21:48] Good, cause I've already done that one ;) [03:22:01] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/112790/ and https://gerrit.wikimedia.org/r/#/c/111672/ should be OK to merge. [03:22:24] (03Merged) 10jenkins-bot: Pass 'pst' as true in parse request for fragments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112829 (owner: 10Jforrester) [03:22:31] RoanKattouw: Can you +1 https://gerrit.wikimedia.org/r/#/c/98887/ (confirm my changes are sane) so that I can bully TrevorParscal to merge it? [03:22:47] Right [03:22:49] I'll do that tomorrow [10:09:57] bonjour guillom :) [10:11:12] Ciao Elitre :) [10:21:41] (03CR) 10Esanders: [C: 032] Refactor labels and titles to be consistent [oojs/ui] - 10https://gerrit.wikimedia.org/r/111672 (owner: 10Trevor Parscal) [10:22:12] (03Merged) 10jenkins-bot: Refactor labels and titles to be consistent [oojs/ui] - 10https://gerrit.wikimedia.org/r/111672 (owner: 10Trevor Parscal) [11:47:10] (03PS1) 10Phuedx: Include edit status in the ve.deactivationComplete event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112879 [13:01:47] (03CR) 10Hashar: "PS15 fix the failure of" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [13:01:54] (03CR) 10Hashar: [C: 031] [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [14:15:25] (03PS1) 10Esanders: Give the document focus on save dialog open to resolve inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112893 [15:27:54] (03PS1) 10Esanders: Include fragments in normalizedTitle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112898 [17:01:55] (03CR) 10Jhall: [C: 031] "Looking all good as of build #64:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112659 (owner: 10Hashar) [17:06:14] (03PS4) 10Jhall: [Browser test] WIP New test for VE Page Settings menu. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110659 [17:13:04] (03CR) 10Hashar: "Ah Jenkins jobs order does not necessarily reflect the change order :-D When looking at the job parameter you can get the change/ patchset" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112659 (owner: 10Hashar) [18:17:59] James_F|Away, oh, what about documentation and samples? There are documentation projects for gsoc in mw, but mediawiki's documentation pool is huge -- VE's is much smaller, yet we could use more explanations and examples for extensions, etc. [18:21:30] mooeypoo: Sure – is that a fun GSoC project, though? [18:25:28] Well, hm, I guess that depends. It can really benefit someone, that's a good way to learn, and making random samples can be rewarding by itself, but nothing is as fun as to develop a language widget. I mean, c'mon. [18:25:29] RoanKattouw: If you're bored: https://translatewiki.net/w/i.php?title=Special:Translate&language=nl&group=ext-visualeditor-0-all&filter=%21translated&action=translate [18:25:35] mooeypoo: :-) [18:25:45] :D [18:25:49] mooeypoo: I'd be hugely happy if that were something a GSoCer wanted to do. [18:26:11] We can always offer it, see if there are takers. [18:26:23] RoanKattouw: (Also, yay for TWN to have created a Translation group for all 4 VE repos, so users can use just one link.) [18:26:24] ohhhh I have a non 800x600 screen [18:27:29] (03CR) 10Catrope: [C: 032] Give the document focus on save dialog open to resolve inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112893 (owner: 10Esanders) [18:28:40] (03Merged) 10jenkins-bot: Give the document focus on save dialog open to resolve inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112893 (owner: 10Esanders) [18:29:53] (03PS2) 10Catrope: Include fragments in normalizedTitle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112898 (owner: 10Esanders) [18:30:07] (03CR) 10Catrope: [C: 032] Include fragments in normalizedTitle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112898 (owner: 10Esanders) [18:32:09] (03Merged) 10jenkins-bot: Include fragments in normalizedTitle [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112898 (owner: 10Esanders) [18:38:41] oh my god, I have to squint to read stuff off my monitor \o/ [18:48:44] mooeypoo: Yay. [18:48:48] mooeypoo: (I think.) [18:50:39] trust me, that's an improvement. Fonts are no longer 1 inch high! [18:53:03] * James_F grins. [18:53:25] (03PS1) 10Catrope: Fix indicator vs icon typo in IconedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/112926 [18:56:11] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (3b61a8d77c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112927 [18:59:02] (03CR) 10Catrope: [C: 04-1] "MenuWidget is broken :(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112927 (owner: 10Catrope) [19:12:58] (03CR) 10Catrope: "Specifically, one of the LookupWidget changes seems to be broken. I'm bisecting." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112927 (owner: 10Catrope) [19:13:23] (03PS3) 10Catrope: Update OOjs UI to v0.1.0-pre (204556a2b4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [19:14:11] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (204556a2b4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [19:14:40] (03CR) 10Catrope: [C: 04-1] "The definitions are separate. Surely there's a way to fix the Gruntfile such that it doesn't include both the default and the specific set" [oojs/ui] - 10https://gerrit.wikimedia.org/r/112790 (owner: 10Trevor Parscal) [19:17:11] (03PS4) 10Catrope: Update OOjs UI to v0.1.0-pre (204556a2b4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [19:19:41] Krinkle: Heya. [19:20:57] Hi [19:21:00] Venue is sweet. [19:22:20] hmmm. Updating size works in CE but results in weirdly empty null value in wikitext (redundant pipe) ... is this parsoid or VE? How can I tell? The size seems to change in the data model and reflects fine in CE [19:22:32] Krinkle: You promised photos. [19:22:55] mooeypoo: Look at the HTML being sent back to Parsoid and confirm that it isn't weird [19:22:58] mooeypoo: Take the HTML being sent by VE and pipe it manually into Parsoid and see what it outputs? [19:23:07] If it is weird, there's a VE-side bug; if it isn't weird, then it's a Parsoid bug [19:23:23] RoanKattouw, how do I get the html just before it's sent to parsoid? [19:23:58] oh [19:24:03] I found it in your debug page [19:25:04] :-) [19:27:16] RoanKattouw, 'getDomFromData' returns an error tht it's not a function. I tried 'getDomFromModel' but then I get "securityError: The operation is insecure" .. I imagine this is firefox-specific, though. [19:28:14] Oh yeah Ed changed some of the names and prototypes of those functions around [19:28:18] So those docs are out of date [19:28:38] If you look at those functions in ve.dm.Converter (or grep their callers) you can hopefully discover the new way [19:28:49] Sorry, I'd do this for you but I have a meeting in 1 minute [19:29:57] nono it's ok, I'm trying to figure out the new method. Mm. [19:49:09] ok. There's size in the dom. This is apparently a parsoid problem. [19:49:21] hmm. [19:53:22] mooeypoo, with size being width/height attributes? [19:53:37] aye, I'm just about to get a screenshot for you [19:53:49] was the size explicitly set before changing it? [19:53:59] if an image had no size preset in the wikitext, and we change the size in VE, the result is an empty value, redundant pipe [19:54:09] ah, did you remove the default size class? [19:54:25] so [[File:whatever.png|thumb]] --> change size --> [[File:whatever.png|thumb|]] [19:54:34] ... hmm not sure let me see [19:54:58] there is a bug on our end in any case, we should not produce the empty pipe [19:55:12] apparently it's still there 'mw-default-size' [19:55:25] if the class is still there then nothing should change in wikitext [19:56:08] gotcha. I'll make sure we take it off on size change. [20:04:09] the reasoning behind giving precedence to the class is that the default size will likely be implemented by js changing the height/width attribute, but that should not trigger a resize in wikitext [20:04:29] yeah, no, that makes sense. I just didn't realize it was there. [20:05:03] mooeypoo, can you open a bug against parsoid about the pipe with the input HTML that generates it? [20:05:38] yup, will do [20:05:49] I took a screenshot of the console and the output [20:07:44] woot! [20:08:01] gwicke, that did it. Size is now updated. I'll report the pipe bug in a second [20:08:09] mooeypoo, you can also just paste it [20:08:49] paste what? I had trouble copying the html dom output [20:09:00] Chrome console didn't let me copy it for some reason [20:09:05] or do you mean just the wikitext? [20:09:05] ah, you can use copy() around it [20:09:10] that copies to the clipboard IIRC [20:09:17] oh, let me try [20:09:45] I was wondering the same thing about copying as well.. [20:09:59] it copied "undefined" :p [20:10:16] copy(data) [20:10:23] not copy(console.log(data)) [20:10:25] yup [20:10:29] no no I got it [20:10:38] still, I got 'undefined' as response. Weird. [20:10:56] copy( ve.dm.converter.getDomFromModel( doc ) ) [20:11:01] undefined. [20:11:02] weird. [20:11:20] RoanKattouw_away, ^^ [20:12:44] also, RoanKattouw_away, the method names and params changed in the debug page, it just needs "getDomFromModel( doc )" now.. but I don't want to touch anything before you review this, I am not really familiar with the converter. [20:17:30] gwicke, http://s867.photobucket.com/user/mooeypoo/media/size_parsoid_problem.png.html [20:17:36] is this helpful at all? [20:18:03] you can see there that it's mw-default-size... not sure if you see the extra | ? [20:18:06] if so, I'll post it in the bug [20:26:16] mooeypoo, for us the input HTML is the most interesting bit to be able to reproduce it [20:26:42] we can try to re-type it from the screenshot, but then that is really reformatted which would introduce other issues [20:26:54] so pasting the actual HTML would be better [20:28:05] ok i'll give it a try [20:28:08] chrome is being annoying [20:28:24] gwicke, i'm sorting out this bug on our end, and then i'll post the bug regarding the pipe [20:34:50] mooeypoo: cool, thanks! [20:40:20] oooh gwicke I also found that even when the size changes, there's an extra pipe [20:41:24] mooeypoo, interesting.. probably the same bug [20:41:30] yeah [20:41:39] could also be related to a caption [20:41:51] serializer thinking there is an empty caption or the tlike [20:41:53] *like [20:42:11] ok something's wrong with my commit :\ i went the usual 'git checkout -b [whatever]' / 'git commit --all' / 'git review' and now I have a list of outstanding commits [20:42:11] is there an empty
in the output? [20:42:26] gwicke, yep, there is [20:42:26] mooeypoo, git fetch gerrit usually fixes that [20:42:42] (03PS1) 10Mooeypoo: Update image size properly when size is default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112942 [20:42:50] gwicke yay! that fixed it :) thanks [20:43:04] also, you are making a good point. No caption.. [20:43:43] afaik we omit the figcaption tags if there is no caption, but could be wrong on that [20:43:51] you do [20:43:59] oh, ok [20:44:29] I will need to see how to do it properly for us. I hid them to avoid having to rebuild each time, but apparently that came with the price of screwing up the output to parsoid [20:44:51] This will be fixed in TrevorP|Away's change for sure [20:45:27] mooeypoo, I'm guessing that a change on figcaption could trigger the empty caption in the serializer [20:46:08] there's no more redundany pipe if I add a caption [20:47:18] hm, why wasn't the bug report updated ... I linked the bug # [20:49:04] (03PS2) 10Jforrester: Update image size properly when size is default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112942 (owner: 10Mooeypoo) [20:49:09] mooeypoo: Blank line at end -> no update. [20:49:14] oh [20:49:23] ha. Thanks James_F [20:49:34] mooeypoo: Also, any ideas for https://bugzilla.wikimedia.org/show_bug.cgi?id=61052 ? It'd be really great to get that fixed and pushed out in an hour if possible… [20:50:21] RoanKattouw_away: Next I'll ask you to put oojs-ui into the jsduck config file, I think :) [20:50:27] But this looks good to me [20:50:53] rdwrer: So, merging? Yay. :-) [20:51:04] Yeah, just one more look [20:51:09] Sure. [20:52:37] Actually, I'll add it to the jsduck [20:52:42] Because that's what I'm doing today anyway [20:52:43] Wheeee [20:52:47] Anyway, +2'd [20:54:02] Whee. [20:54:23] Jenkins is thinking REALLY HARD about it [20:54:32] I can imagine. [20:56:36] 'kay, merged [20:56:45] (03CR) 10Jforrester: [C: 031] "Now works. Thanks, Trevor!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108855 (owner: 10Jforrester) [20:56:45] Someone want to send an email about it to wikitech et al.? [20:56:47] Whee. [20:56:51] rdwrer: RoanKattouw_away will. [20:57:00] rdwrer: Thank you. :-) [20:58:16] James_F, I'm trying to track exactly how to change the way scalable intercepts the current dimensions, which seems to be the issue. [20:59:06] mooeypoo: Aha. Does edsanders have any suggestions? [20:59:08] edsanders, you hve a second? What's the difference between "original dimensions" and "current dimensions" in scalable? i go 'getCurrentDimensions' and get the original dimensions that the image was loaded with ? [21:00:08] mooeypoo: Is "original" full size? [21:00:16] mooeypoo: I.e., size of the "original" file? [21:00:52] James_F, as far as I see, yes [21:01:06] That sort-of makes sense. [21:01:15] But confusing methods !== good code.. [21:01:59] the code comment has the same note, too :p [21:02:31] but yeah, I'm trying to follow the code.. there's a bit of override in MediaSizeWidget that then calls the scalable method [21:02:45] so i'm trying to see where it fails to get the *actual* size rather than the original one [21:04:12] mooeypoo, gwicke: copy() returns undefined (it's kind of like a void function) but it does also copy its argument to the clipboard [21:05:23] right [21:05:52] maybe mooeypoo meant the return value and not the clipboard? [21:06:10] yeah the return value was undefined, but that was also what i had in the clipboard [21:06:14] Yeah the return value is undefined [21:06:16] Hah, OK that's odd [21:06:22] Oh, also [21:06:39] If you're dealing with a DOM node, you can't just copy it to the clipboard, you have to call .outerHTML [21:06:43] Or, on a document .body.outerHTML [21:07:46] oh that explains it.... [21:07:49] ha [21:08:09] I thought it had a native 'toString()' .. just.. flattens it out on copy or print [21:08:55] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/112814/ is the main back-port. [21:09:42] James_F, I can hack a solution to this bug, but for a more permanent one, i need edsanders eyes. I don't wnt to mess with scalable without knowing how the non-image scalable nodes are ready through it. Right now, it seems 'currentDimensions' is not really current. [21:09:53] mooeypoo: Helpful. [21:10:03] (03CR) 10Catrope: [C: 032] Fix margins after they were broken in 9d988924 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112814 (owner: 10Trevor Parscal) [21:10:05] mooeypoo: A quick hack and a longer fix makes sense as a strategy. [21:10:10] * mooeypoo nods [21:10:12] mooeypoo: Though it's RoanKattouw who'll have to merge. :-) [21:10:38] (03PS1) 10Jforrester: Fix margins after they were broken in 9d988924 [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112946 [21:11:02] (03PS1) 10Jforrester: Fix margins after they were broken in 9d988924 [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112947 [21:12:04] (03Merged) 10jenkins-bot: Fix margins after they were broken in 9d988924 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112814 (owner: 10Trevor Parscal) [21:12:14] (03Abandoned) 10Jforrester: Fix margins after they were broken in 9d988924 [extensions/VisualEditor] (wmf/1.23wmf12) - 10https://gerrit.wikimedia.org/r/112946 (owner: 10Jforrester) [21:13:36] ! [21:13:36] Hello, I'm wm-bot. The database for this channel is published at http://bots.wmflabs.org/~wm-bot/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [21:14:50] Oh, hm, oojs-ui is already in jsduck [21:14:51] We good [21:15:03] (03PS1) 10Mooeypoo: Fix image size property update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112950 [21:15:08] James_F, ^^ [21:15:26] Or at least...it should be [21:15:30] it's a workaround, really. IT works, and I don't think it's entirely too ugly, but I don't think that's what edsanders meant to be done with scalable stuff. [21:15:37] rdwrer: I was going to say… [21:16:18] RoanKattouw: There's https://bugzilla.wikimedia.org/show_bug.cgi?id=61001 for you to investigate and patch BTW. [21:16:28] RoanKattouw: As well as https://gerrit.wikimedia.org/r/112950 now. [21:18:08] Oh, but! [21:18:09] https://integration.wikimedia.org/ci/view/MediaWiki/job/mediawiki-core-jsduck-publish/664/console [21:18:12] Failed [21:18:19] I can fix them. [21:20:03] rdwrer: I blame Krinkle|detached. [21:20:52] Of course [21:20:56] I'm fixing it, don't worry [21:21:49] Why it merged when there were jsduck warnings, I do not know [21:22:20] Krinkle|detached: https://integration.wikimedia.org/ci/view/MediaWiki/job/mediawiki-core-jsduck/3512/console herp derp [21:24:23] hi TrevorParscal [21:25:51] hey, TrevorParscal I got a quick unrelated question.. i'm tentatively planning/thinking about my grad project for the end of the degree, and I plan to do something web-devvy, and i'd like to use OOJS.. it's supposed to be standalone, right? [21:26:23] it is [21:26:49] totally standalone, and you can use it by running "npm install oojs" in a folder [21:27:10] can you remind me of the standalone repo? I lost it now in my new dev pc [21:27:17] oh [21:27:24] I don't even need the repo, then? [21:27:25] (03PS1) 10Catrope: Fix positioning in TextInputMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/112954 [21:27:26] or just downloading it, and running "grunt build" and copying the files from the dst directory [21:27:41] it's also mirrored on github [21:28:01] (03CR) 10Trevor Parscal: [C: 032] Fix positioning in TextInputMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/112954 (owner: 10Catrope) [21:28:27] (03Merged) 10jenkins-bot: Fix positioning in TextInputMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/112954 (owner: 10Catrope) [21:28:39] oooh shweeeeeeet. npm install oojs worked [21:29:19] speaking of which -- how do I update when it's through npm ? [21:29:27] if the repo was updated or something [21:30:38] mooeypoo: npm install [21:30:44] not npm update? [21:30:46] I believe [21:30:49] I .. don't know [21:30:56] there are conflicting opinions on the internets. [21:30:57] npm update oojs [21:31:01] I only know the use case where you specify all of your dependencies in package.json [21:31:08] Then running 'npm install' works for both install and update [21:31:13] that's the best way [21:31:14] for sure [21:31:14] ooh [21:31:35] awesomesauce [21:31:38] thanks TrevorParscal [21:32:23] and RoanKattouw. Also, RoanKattouw the debug docs changes-- see my comment above. Not only did the method name changed to 'Model' from 'Data' but also there are no longer 3 parameters needed, only 'doc' [21:32:28] which seems to make things easier [21:34:22] (03PS5) 10Catrope: Update OOjs UI to v0.1.0-pre (dc93c9189e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [21:34:30] Yeah, that's right [21:34:35] It was made easier but the docs weren't updated [21:35:20] (03Abandoned) 10Catrope: Update OOjs UI to v0.1.0-pre (3b61a8d77c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/112927 (owner: 10Catrope) [21:35:41] (03PS6) 10Catrope: Update OOjs UI to v0.1.0-pre (dc93c9189e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [21:37:10] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/112926/ [21:38:08] (03CR) 10Trevor Parscal: [C: 032] Fix indicator vs icon typo in IconedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/112926 (owner: 10Catrope) [21:38:48] (03Merged) 10jenkins-bot: Fix indicator vs icon typo in IconedElement [oojs/ui] - 10https://gerrit.wikimedia.org/r/112926 (owner: 10Catrope) [21:39:06] mooeypoo: https://gerrit.wikimedia.org/r/#/c/112950/1/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js is a temporary hack, is that right? [21:39:26] If so, could that please be noted in the commit summary and with a // HACK: explanation of what's going on comment in the code? [21:41:06] (03PS7) 10Catrope: Update OOjs UI to v0.1.0-pre (a290673bbd) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [21:44:12] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (a290673bbd) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [21:44:13] RoanKattouw, well, I think it's a hack. edsanders would have to say more. I wasn't sure if scalable was supposed to handle images specifically or be generalized (and assumed the latter) -- but yes, I'll add in a note [21:45:14] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (a290673bbd) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/111675 (owner: 10Trevor Parscal) [21:45:35] (03CR) 10Trevor Parscal: [C: 04-1] Fix image size property update (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112950 (owner: 10Mooeypoo) [21:46:04] (03PS1) 10Catrope: Update VE core submodule to master (84ced37) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113010 [21:46:26] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (84ced37) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113010 (owner: 10Catrope) [21:47:19] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (84ced37) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113010 (owner: 10Catrope) [21:52:30] (03PS2) 10Catrope: Include edit status in the ve.deactivationComplete event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112879 (owner: 10Phuedx) [21:55:26] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/113012/ [21:55:45] (03PS2) 10Mooeypoo: Quick fix: image size property update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112950 [21:56:11] James_F, RoanKattouw, TrevorParscal, the hack/workaround was updated. PArt of the reason I tried this as a hack rather than a more formal long-term fix is because of the urgency. [21:59:04] (03CR) 10Trevor Parscal: [C: 032] Quick fix: image size property update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112950 (owner: 10Mooeypoo) [21:59:10] (03PS3) 10Catrope: Include edit status in the ve.deactivationComplete event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112879 (owner: 10Phuedx) [21:59:25] (03CR) 10Catrope: [C: 032] Include edit status in the ve.deactivationComplete event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112879 (owner: 10Phuedx) [21:59:53] (03PS1) 10Catrope: Quick fix: image size property update [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113014 [22:00:30] (03Merged) 10jenkins-bot: Quick fix: image size property update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112950 (owner: 10Mooeypoo) [22:01:21] (03CR) 10Jforrester: [C: 032] "Go go gerrit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113010 (owner: 10Catrope) [22:01:25] James_F, woot, it made the cut. [22:01:45] (03CR) 10jenkins-bot: [V: 04-1] Include edit status in the ve.deactivationComplete event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112879 (owner: 10Phuedx) [22:02:21] (03Merged) 10jenkins-bot: Include edit status in the ve.deactivationComplete event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112879 (owner: 10Phuedx) [22:03:38] (03CR) 10jenkins-bot: [V: 04-1] Quick fix: image size property update [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113014 (owner: 10Catrope) [22:03:46] mooeypoo: :-) [22:05:30] (03PS3) 10Catrope: (Stand back again) Even moar label manias! (label refactoring) + VE core update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111682 (owner: 10Trevor Parscal) [22:07:12] (03Abandoned) 10Jforrester: Update VE core submodule to master (84ced37) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113010 (owner: 10Catrope) [22:07:18] (03CR) 10Catrope: [C: 032] (Stand back again) Even moar label manias! (label refactoring) + VE core update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111682 (owner: 10Trevor Parscal) [22:07:26] (03PS4) 10Jforrester: Add tooltips to the drop-down menus explaining what they do [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108855 [22:07:53] (03CR) 10Catrope: [C: 032] Add tooltips to the drop-down menus explaining what they do [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108855 (owner: 10Jforrester) [22:08:28] (03Merged) 10jenkins-bot: (Stand back again) Even moar label manias! (label refactoring) + VE core update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111682 (owner: 10Trevor Parscal) [22:08:46] (03CR) 10Catrope: [C: 032] Quick fix: image size property update [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113014 (owner: 10Catrope) [22:10:33] (03Merged) 10jenkins-bot: Add tooltips to the drop-down menus explaining what they do [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108855 (owner: 10Jforrester) [22:11:48] (03CR) 10jenkins-bot: [V: 04-1] Quick fix: image size property update [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113014 (owner: 10Catrope) [22:12:37] Hallo. Is there any link in VE from a template used in the currently edited page to the the template page? [22:12:46] There is not [22:13:01] should I report a bug? :) [22:13:35] Can't hurt :) [22:13:42] If James_F has time you can also talk to him real quick [22:13:50] aharoni: Bugzilla is down, so… [22:13:51] cool [22:14:03] zomfgs [22:14:04] ok [22:14:21] oh noes [22:14:26] (03CR) 10Catrope: [C: 032] Quick fix: image size property update [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113014 (owner: 10Catrope) [22:14:33] hi mooeypoo [22:14:37] heya aharoni :) [22:14:45] (03CR) 10Catrope: [C: 032] Fix margins after they were broken in 9d988924 [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112947 (owner: 10Jforrester) [22:15:19] I was wondering about something... I edit https://www.mediawiki.org/wiki/Extension:VisualEditor in VisualEditor, and I try to edit the infobox, which is https://www.mediawiki.org/wiki/Template:Extension , [22:15:48] I don't see "translate" in the parameter list in the transclusion dialog.. [22:15:51] (03CR) 10jenkins-bot: [V: 04-1] Quick fix: image size property update [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113014 (owner: 10Catrope) [22:16:11] is it because "translate" is not used in that template on https://www.mediawiki.org/wiki/Extension:VisualEditor ? [22:16:18] (03CR) 10Catrope: [V: 032] Quick fix: image size property update [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/113014 (owner: 10Catrope) [22:16:23] and https://www.mediawiki.org/wiki/Template:Extension doesn't have templatedata? [22:16:32] edsanders / TrevorParscal as a more permanent/long-term solution for the currentDimensions, I was thinking of adding a this.currentDimensions = dimensions to the "updateSize()" method in ve.ce.MWBlockImageNode. However, this will only work for images, and I am a little unsure about the interoperable methods of scalable-vs-TheNodes. So.. I am leaving it as-is for now, and assume the new super-awesome refactor will fix it. [22:16:38] (03CR) 10Catrope: [V: 032] Fix margins after they were broken in 9d988924 [extensions/VisualEditor] (wmf/1.23wmf13) - 10https://gerrit.wikimedia.org/r/112947 (owner: 10Jforrester) [22:16:50] (03CR) 10Esanders: Update image size properly when size is default (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112942 (owner: 10Mooeypoo) [22:16:58] and VE doesn't somehow magically guess the params by reading the template? [22:17:26] aharoni: Only by reading the current template invocation [22:17:37] OK [22:17:49] Determining which params a template has by reading the code is not a solvable problem in the general case [22:18:13] adding templatedata to that template is... not-entirely-trivial. [22:18:29] 4 Warning: Invalid parameter for message "parentheses": a:1:{s:3:"raw";N;} in /usr/local/apache/common-local/php-1.23wmf12/includes/Message.php on line [22:18:30] 822 [22:18:36] Someone's doing something wrong there :) [22:21:16] (03PS3) 10Mooeypoo: Update image size properly when size is default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112942 [22:24:40] (03PS4) 10Mooeypoo: Update image size properly when size is default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112942 [22:25:46] aharoni: I can do it for you. [22:26:03] James_F: do what? create templatedata? [22:26:07] aharoni: Yeah. [22:26:12] I started, actually. [22:26:19] aharoni: OK! [22:26:19] There's always a first time. [22:26:22] * James_F grins. [22:29:37] RoanKattouw: Your review queue: https://gerrit.wikimedia.org/r/#/c/112618/ https://gerrit.wikimedia.org/r/#/c/112407/ https://gerrit.wikimedia.org/r/#/c/112490/ https://gerrit.wikimedia.org/r/#/c/112318/ https://gerrit.wikimedia.org/r/#/c/110434/ [22:30:53] TrevorParscal: Your review queue: https://gerrit.wikimedia.org/r/#/c/112041/ https://gerrit.wikimedia.org/r/#/c/112942/ https://gerrit.wikimedia.org/r/#/c/110907/ [22:31:39] aharoni: We're about a day away from enabling the magic TemplateData editor that mooeypoo wrote on MediaWiki.org, actually. Oh well. :-( [22:31:58] Ehhh... it looks like it's there. I'm using it right now. [22:32:06] It is? [22:32:09] Looks like it. [22:32:14] Hmm. [22:32:16] That's odd. [22:32:17] Unless I am using a hopelessly old version. [22:32:28] Maybe it's there as a gadget?.. [22:32:32] mooeypoo: ^ [22:32:36] 'Cos RoanKattouw didn't merge https://gerrit.wikimedia.org/r/#/c/112156/ [22:32:47] aharoni: Oh, that gadget? That's a fork of the effort… [22:32:55] Heh. [22:33:00] RoanKattouw: (Correctly. Don't worry.) [22:33:29] Well, it seems to work. [22:33:50] Nothing crashed yet and I didn't lose seven or so minutes of work. [22:33:55] * James_F grins. [22:35:54] (03CR) 10Trevor Parscal: [C: 032] Update image size properly when size is default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112942 (owner: 10Mooeypoo) [22:37:23] (03Merged) 10jenkins-bot: Update image size properly when size is default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112942 (owner: 10Mooeypoo) [22:38:11] aharoni, are you sure you're not still under review of the patch? [22:38:31] which patch? [22:38:36] 'cause ithis isn't merged: https://gerrit.wikimedia.org/r/#/c/110907/ [22:39:05] well, you can use the editor as long as you don't make mistakes in param names. If you do, you're screwed, until Krinkle merges that patch ^^ [22:39:38] It awaits being Krinkled. [22:44:11] RoanKattouw: {{echo|Some [[Fool]]}}s :-D [22:44:48] (03CR) 10Kaldari: [C: 031] "Looks good, but I'll leave the VE team to +2" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110655 (owner: 10JGonera) [22:46:54] {{{n}}} [[Foo]]{{#ifexpr: {{{n}}} > 1|s||}} [22:47:02] James_F: brbrbrbrbrbr. Did I do anything egregious in https://www.mediawiki.org/w/index.php?title=Template%3AExtension&diff=904163&oldid=901522 ? [22:47:45] I had to revert it. It transcluded the templatedata on the page. Does it have to be in or something? [22:48:28] aharoni: Yes. [22:48:35] OK [22:48:37] aharoni: It normally gets put in the /doc. [22:48:53] aharoni: Also, wow, that template is insane. [22:48:58] Yes :) [22:49:09] (03CR) 10Trevor Parscal: [C: 032] Prevent the dialog from applying changes on bad input [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/110907 (owner: 10Mooeypoo) [22:49:25] ooooh, hand-rolled infoboxes. [22:49:37] haven't seen these in the wild for years. [22:49:38] (03Merged) 10jenkins-bot: Prevent the dialog from applying changes on bad input [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/110907 (owner: 10Mooeypoo) [22:49:44] mooeypoo: oh, that. [22:50:49] MatmaRex: "Eww" comes to mind. [22:51:46] \o/ [22:51:58] mooeypoo: Yay. :-) [22:52:16] thanks TrevorParscal ! [22:56:19] ok, now I go do homework before the study group [22:56:22] cya guys later! [22:57:32] James_F: I think I made it... [22:58:04] Curious: After I reverted my own bad edit to the template, trying to edit the extension page still showed the broken template. [22:58:28] I had to do a non-null edit to make the brokenness disappear. [22:58:30] aharoni: Yay for MW's caching. [23:07:22] Krinkle: Ping if you've got a couple of minutes. [23:08:15] Krinkle: (Your thoughts very much appreciated on https://gerrit.wikimedia.org/r/#/c/112790/ by TrevorParscal to change your OOjs UI build script.) [23:13:02] (03CR) 10Krinkle: "Indeed, this was not intentionally designed that way. default should be the fallback." [oojs/ui] - 10https://gerrit.wikimedia.org/r/112790 (owner: 10Trevor Parscal) [23:17:15] (03PS1) 10Catrope: A couple more OO.ui.deferMsg() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113040 [23:18:48] (03PS11) 10Jforrester: Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 [23:18:58] (03CR) 10jenkins-bot: [V: 04-1] Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester) [23:19:22] (03CR) 10Jforrester: "Icon issue now resolved, thanks to Trevor." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester) [23:19:30] James_F: https://gerrit.wikimedia.org/r/113040 [23:19:51] (03CR) 10Jforrester: [C: 032] A couple more OO.ui.deferMsg() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113040 (owner: 10Catrope) [23:20:58] (03Merged) 10jenkins-bot: A couple more OO.ui.deferMsg() calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113040 (owner: 10Catrope) [23:24:25] (03PS27) 10Jforrester: Let users set #REDIRECT and __STATICREDIRECT__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95213 [23:25:37] (03CR) 10Jforrester: [C: 031] "All dependencies in Parsoid are now merged and in production, so this is good to go — but please do not merge until AFTER the wmf14 cut to" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95213 (owner: 10Jforrester) [23:27:58] TrevorParscal: Review queue += https://gerrit.wikimedia.org/r/#/c/112618/ [23:28:20] TrevorParscal: It looks fine but I think he should keep some common styles, like at the very least the fact that -halign-right has float:right; for instnace [23:30:55] (03CR) 10Catrope: Fix more code that misreads API data with $wgDebugToolbar enabled (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112407 (owner: 10Alex Monk) [23:31:21] (03CR) 10Catrope: [C: 032] Fix more code that misreads API data with $wgDebugToolbar enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112407 (owner: 10Alex Monk) [23:32:38] (03Merged) 10jenkins-bot: Fix more code that misreads API data with $wgDebugToolbar enabled [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112407 (owner: 10Alex Monk) [23:33:26] TrevorParscal: Your review queue: https://gerrit.wikimedia.org/r/#/c/112041/ https://gerrit.wikimedia.org/r/#/c/112618/ [23:33:45] Your review queue: https://gerrit.wikimedia.org/r/#/c/112490/ https://gerrit.wikimedia.org/r/#/c/112318/ https://gerrit.wikimedia.org/r/#/c/110434/ [23:37:56] (03PS1) 10Jforrester: Add ve.Scalable to documentation listing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113044 [23:43:25] (03CR) 10Catrope: [C: 04-1] "The preview is only displayed in the review pane, but we send an AJAX request to generate the preview on every single keypress, and update" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112490 (owner: 10Alex Monk) [23:43:52] (03CR) 10Catrope: [C: 032] Add ve.Scalable to documentation listing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113044 (owner: 10Jforrester) [23:44:56] (03Merged) 10jenkins-bot: Add ve.Scalable to documentation listing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113044 (owner: 10Jforrester) [23:45:23] (03CR) 10Catrope: Explain what the number on the edit summary screen means (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112318 (owner: 10Alex Monk) [23:45:56] RoanKattouw, how would I make it run every time you switch to the review pane? [23:46:08] Ahm, great question [23:47:28] I know there was a function which ran the first time you switched to the review pane after changing the page content [23:48:20] Ugh, this code is awful [23:48:31] It goes from MWSaveDialog via ViewPageTarget back into MWSaveDialog [23:48:45] Well I suppose that makes sense though [23:48:51] Given that VPT is what fetches the actual data [23:49:26] So, the save dialog is a bit spaghetti-like because it's driven by VPT which provides its data [23:49:37] The way you switch to the review pane is as follows: [23:49:43] * User clicks review button [23:49:48] * MWSaveDialog emits 'review' event [23:50:03] *ViewPageTarget receives 'review' event, kicks off AJAX request for diff [23:50:23] * AJAX request finishes, VPT gets result, calls setDiffAndReview on MWSaveDialog [23:50:38] * setDiffAndReview puts the diff HTML in the DOM and calls swapPanel( 'review' ) [23:51:04] Krenair: BTW, why is the summary preview in the review panel? Is that where James asked for it to be? [23:52:28] Yep. [23:52:43] It was bug 42139 comment 8 - "To clarify, when the diff is shown ('Review your changes' dialog pane) we want to parse the entered summary and display it, probably above the diff." [23:52:48] Right, OK [23:52:57] (Right now you've put it below, right?) [23:53:26] So, I think you'll want to piggyback on the existing code path for displaying the diff [23:53:41] Yes, I need to put it above instead. [23:53:41] Modify setDiffAndReview to also take the summary preview [23:54:02] Then in VPT in response to the 'review' event, have two parallel requests happen, the existing one plus one for the summary [23:54:11] And call setDiffAndReview once both are done [23:54:14] Does that seem sane? [23:54:48] (Note that the existing request for the diff is a bit weird because of the infrastructure for optimistic serialization; I'd be happy to explain how that works if you like)