[00:35:35] <kaldari>	 Trevor: Do you have any opinion on what to name the ViewPageTarget styles that are going to be shared between the vector, monobook, and apex skins, but not the minerva skin? ViewPageTarget-shared? ViewPageTarget-common?
[00:41:57] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Fix for clearing items in a group element [oojs/ui] - 10https://gerrit.wikimedia.org/r/113309 
[00:43:20] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Fix for clearing items in a group element [oojs/ui] - 10https://gerrit.wikimedia.org/r/113309 
[00:43:31] <TrevorParscal>	 James_F|Away: you alive?
[00:43:45] <TrevorParscal>	 I need some VE +2 from someone
[00:43:46] <TrevorParscal>	 https://gerrit.wikimedia.org/r/#/c/113309/
[00:44:10] <TrevorParscal>	 this is a fix that needs merging and pushing to beta labs to prevent an error it's causing
[00:44:34] * TrevorParscal  starts looking around

[00:45:08] * rdwrer  batters the VE team

[00:45:12] <rdwrer>	 I should have -1'd but didn't
[00:45:19] <rdwrer>	 You need to put oojs-ui in the release notes
[00:45:46] <TrevorParscal>	 true
[00:45:49] <MatmaRex>	 TrevorParscal: where is `item` set?
[00:46:17] <rdwrer>	 I would do it but I'm allergic to the actual capitalisation of the tool
[00:46:23] <TrevorParscal>	 indeed
[00:47:22] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Fix for clearing items in a group element [oojs/ui] - 10https://gerrit.wikimedia.org/r/113309 
[00:47:30] <TrevorParscal>	 i'm having a really off day...
[00:47:54] <TrevorParscal>	 as opposed to yesterday, when I made this mistake the first time... that was a much better day :(
[00:47:55] <Krenair>	 I was about to ask the same thing, MatmaRex :p
[00:48:54] <TrevorParscal>	 well, at least there are living people in this channel
[01:38:32] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 031] "logic looks better here :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/113309 (owner: 10Trevor Parscal)
[01:48:00] <grrrit-wm>	 (03PS1) 10Alex Monk: Add save shortcut to dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113319 
[01:48:44] <grrrit-wm>	 (03PS4) 10Alex Monk: Use accesskey=s on the save buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 
[01:48:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use accesskey=s on the save buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk)
[01:50:04] <grrrit-wm>	 (03CR) 10Alex Monk: "So... I guess that issue will go away when the dependency is merged?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk)
[02:23:35] <grrrit-wm>	 (03PS2) 10Kaldari: Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 
[02:25:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 (owner: 10Kaldari)
[02:34:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix for clearing items in a group element [oojs/ui] - 10https://gerrit.wikimedia.org/r/113309 (owner: 10Trevor Parscal)
[02:34:11] <James_F>	 TrevorP|Away: You suck.
[02:34:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix for clearing items in a group element [oojs/ui] - 10https://gerrit.wikimedia.org/r/113309 (owner: 10Trevor Parscal)
[02:34:45] <grrrit-wm>	 (03PS3) 10Kaldari: Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 
[02:36:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 (owner: 10Kaldari)
[02:38:27] <akp>	 hello is there any way to use the visual editor in a standlone mode or in an existing wiki deployment/
[02:43:21] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs to v1.0.7-pre (9c04f3e917) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113323 
[02:43:23] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (7d3223b8f4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113324 
[02:44:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs to v1.0.7-pre (9c04f3e917) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113323 (owner: 10Jforrester)
[02:58:00] <grrrit-wm>	 (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (7d3223b8f4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113282 (owner: 10Jforrester)
[02:58:03] <grrrit-wm>	 (03PS2) 10Catrope: Update OOjs to v1.0.7-pre (9c04f3e917) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113323 (owner: 10Jforrester)
[02:59:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (7d3223b8f4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113282 (owner: 10Jforrester)
[02:59:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs to v1.0.7-pre (9c04f3e917) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113323 (owner: 10Jforrester)
[03:00:03] <grrrit-wm>	 (03Abandoned) 10Catrope: Update OOjs UI to v0.1.0-pre (7d3223b8f4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113324 (owner: 10Jforrester)
[03:01:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7d3223b8f4) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113282 (owner: 10Jforrester)
[03:01:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs to v1.0.7-pre (9c04f3e917) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113323 (owner: 10Jforrester)
[03:34:41] <mooeypoo>	 James_F, I updated my beginner's-manual to also include grunt tests
[03:34:44] <grrrit-wm>	 (03PS2) 10Robmoen: Create mixin for node that responds to node click events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 
[03:35:04] <mooeypoo>	 James_F, but I hope I didn't miss anything.. it's 'npm install' right? In both the main folder and then in lib/ve ?
[03:35:20] <mooeypoo>	 I forgot to write notes about that when I did that step
[03:35:30] <James_F>	 mooeypoo: Yeah, or npm install -g <somethingorother>
[03:36:43] <mooeypoo>	 James_F, well, I assume we want to install all of the configured modules. I think. I left it as the general 'npm install'... the first newbie can be our guinea pig to fix if needed :p
[03:37:17] <James_F>	 -g does it globally so you don't need to download the same code twice.
[03:37:36] <James_F>	 ryasmeen: We just un-broke Beta Labs, BTW; you might have had some odd issues.
[03:37:46] <mooeypoo>	 oh
[03:38:58] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Per Roan's comments (sorry, rebase was just to check jenkins tests passing)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[03:40:00] <grrrit-wm>	 (03PS4) 10Kaldari: Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 
[03:44:59] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Let's give jenkins the chance to complain again." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95213 (owner: 10Jforrester)
[03:45:03] <ryasmeen>	 James_F: Oh. Well,Didn't check betalabs in last few hours..
[03:45:32] <James_F>	 ryasmeen: Excellent. :-)
[03:45:39] <akp>	 umm what version of mediawiki is visualeditor supposed to work it?
[03:45:40] <akp>	 *with
[03:45:47] <James_F>	 akp: 1.22.
[03:46:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Let users set #REDIRECT and __STATICREDIRECT__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95213 (owner: 10Jforrester)
[03:47:30] <akp>	 is there a "safe" way to update mediawiki?  i am running 1.15...
[03:48:05] <James_F>	 akp: Ouch. The upgrade path from 1.15 is tricky (dependent on what extensions you have), and I'm not an exprt.
[03:48:08] <James_F>	 +e
[03:48:39] <akp>	 that might be what is biting me with my entry that i am trying to create.
[03:48:58] <akp>	 i cant get it to do the <pre> the way i expect.  this is an old install i inherited.
[03:49:58] * James_F  nods.

[03:50:49] <mooeypoo>	 akp what's the problem with <pre> ? I also ran into a couple of small issues with it... is it the linebreaks?
[03:51:13] <akp>	 mooeypoo: ya pretty much.  its doing all sorts of crazy shit
[03:51:30] <akp>	 i have a numbered list
[03:51:36] <akp>	 and in that i have an indented list
[03:51:44] <mooeypoo>	 And you want that in <pre> ?!
[03:51:48] <akp>	 no
[03:52:02] <akp>	 i have some other stuff under the indented list that i need to put in a pre
[03:52:11] <mooeypoo>	 hmmm so multiline list?
[03:52:16] <akp>	 yeah
[03:52:22] <akp>	 item 1)
[03:52:48] <mooeypoo>	 updating your installation is a good idea, but this might be something with wikitext itself. I also ran into problems making multiline bullet/numbered list
[03:52:55] <akp>	 is there a place to pastebin the mediawiki stuff for temp
[03:53:03] <akp>	 that way you can see what i am talking about
[03:53:29] <mooeypoo>	 pastebin.com is good
[03:53:47] <grrrit-wm>	 (03PS12) 10Jforrester: Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 
[03:56:08] <grrrit-wm>	 (03PS13) 10Jforrester: Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 
[03:56:26] <grrrit-wm>	 (03PS14) 10Jforrester: Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 
[03:56:51] <grrrit-wm>	 (03PS15) 10Jforrester: Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 
[03:57:01] <grrrit-wm>	 (03PS13) 10Jforrester: [WIP] Create remaining meta items in DM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 
[04:00:44] <akp>	 mooeypoo: hmm i had gist.github.com rendering my busted mediawiki stuff, but i cant seem to get it to do it anymore
[04:00:49] <akp>	 anyways here is the link https://gist.github.com/anishp55/8995539
[04:03:05] <mooeypoo>	 akp, https://www.mediawiki.org/wiki/User:Mooeypoo/VE_Tests
[04:03:19] <akp>	 yeap
[04:03:34] <akp>	 so the pre that has the subsystem text
[04:03:47] <mooeypoo>	 I copied your wikitext in there to see how it renders. I would recommend updating your system anyways, *but* I have a feeling that we might have a VE bug as well. I've been having problems creating multiline bullet lists as well.
[04:03:58] <akp>	 is supposed to be 2 lines. and the empty pre box under 2
[04:04:12] <akp>	 should have all that text underneth the pre box in it
[04:04:31] <mooeypoo>	 Look at the way mediawiki renders it (not VE) - is that how you intended it?
[04:04:48] <akp>	 well my mediawiki version is old
[04:05:02] <akp>	 so i need to find a new mediawiki place to test it on
[04:05:04] <akp>	 ....
[04:05:13] <mooeypoo>	 no I mean the link I just shared
[04:05:27] <mooeypoo>	 that runs the latest mediawiki. Look at the page, and how it renders.
[04:05:41] <akp>	 thats the same way my old mediawiki install is rendering it
[04:05:45] <akp>	 not correct at all.
[04:06:02] <mooeypoo>	 Ok, that's not a VE problem, then. That's a wikitext issue. I am not sure I understand how you want it to be rendered?
[04:06:15] <mooeypoo>	 You can try and edit that page in VE btw, it's a test page, feel free
[04:06:23] <akp>	 ok, i will try
[04:06:24] <mooeypoo>	 see if you can get your result visually? experiment away
[04:06:38] <akp>	 but the prebox that is under the major 3 number. minor 1
[04:06:45] <akp>	 that text should be 2 lines.
[04:07:02] <akp>	 then you see the empty prebox under major 3. minor 2?
[04:07:17] <akp>	 the text that is below that prebox should be *in* the prebox
[04:07:23] <mooeypoo>	 I am sorry, I don't understand.
[04:07:35] <mooeypoo>	 how did you create this wikitext? by hand? or with VE ?
[04:07:37] <akp>	 yeah, i'm pretty crappy at explaning
[04:07:39] <akp>	 by had
[04:07:44] <akp>	 *hand
[04:07:45] <mooeypoo>	 look at "Edit source" then
[04:08:05] <mooeypoo>	 oh! I see what you mean here.
[04:08:09] <mooeypoo>	 interesting.
[04:08:12] <akp>	 yeah
[04:08:14] <mooeypoo>	 This seems to be a general <pre> bug
[04:08:26] <mooeypoo>	 Ironically, VE treats it *perfect*
[04:08:28] <akp>	 the rendering doesn't seem to match what the tags are
[04:08:31] <mooeypoo>	 click on "Edit" (not edit source)
[04:08:37] <mooeypoo>	 see? It looks correct in VE
[04:08:40] <akp>	 yep.  the visual editor give me what i would like to see
[04:08:50] <akp>	 the mediawiki rendering, not so much
[04:09:00] <mooeypoo>	 ha, hear that James_F ? VE inadvertently fixes a MW bug.
[04:09:38] <mooeypoo>	 akp, the weird rendering is indeed weird, but I am not familiar with MW's php parser to know exactly why this happens. Can you open a bug about this?
[04:09:52] <mooeypoo>	 I suspect it might have to do with the < > you have in there, but that's still not right
[04:10:06] <akp>	 mooeypoo: actually it thought that was the case too
[04:10:16] <akp>	 i removed them, but it still did the same thing
[04:10:31] <mooeypoo>	 wait
[04:10:37] <mooeypoo>	 what are those insane amounts of spaces in there
[04:10:48] <akp>	 where?
[04:10:50] <mooeypoo>	 is that because of github gist? or is that in there originally?
[04:10:56] <mooeypoo>	 look between the <pre> to the next line
[04:11:00] <mooeypoo>	 there's a whole huge line of spaces
[04:11:02] <akp>	 github
[04:11:23] <akp>	 on my local i have everything as a runon
[04:11:26] <akp>	 and it still does it
[04:11:42] <mooeypoo>	 ok so this seems to be a <pre> issue 
[04:11:45] <mooeypoo>	 I have a solution for you though
[04:11:48] <mooeypoo>	 at least temporarily
[04:12:06] <mooeypoo>	 give me one sec to verify
[04:12:14] <akp>	 all ears, i've been trying to figure this out for like 3 hours now =/
[04:13:11] <akp>	 check the page out now moneypoo, i made some minor adjustments
[04:13:13] <mooeypoo>	 hm, ok, that doesn't work either
[04:13:28] <akp>	 and the pre boxes broke altogether
[04:13:35] <mooeypoo>	 I thought perhaps the problem was multiline <pre> and maybe you should use <syntaxhighlight lang="bash"> but that doesn't work either
[04:13:37] <akp>	 wow
[04:13:52] <akp>	 actually it broke more
[04:14:11] <akp>	 but the VE does what is is supposed to 
[04:14:25] <mooeypoo>	 yeah, well.. it seems this is a php parser issue.
[04:14:31] <mooeypoo>	 You should post a bug about it
[04:14:49] <mooeypoo>	 You can also ask around in #mediawiki
[04:14:50] <akp>	 can i point to this VE page as the test case?
[04:15:04] <mooeypoo>	 see if there are folks there who are more famliar with the php parser. I'm not too familiar with how it works.
[04:15:08] <mooeypoo>	 Sure
[04:15:20] <akp>	 thanks mooeypoo 
[04:15:36] <mooeypoo>	 Wait, let me make one with a more indicative name, so I don't erase it with other tests 
[04:16:27] <mooeypoo>	 akp, use this: https://www.mediawiki.org/wiki/User:Mooeypoo/multiline_list_pre_problem
[04:16:46] <akp>	 ok
[04:17:27] <mooeypoo>	 in any case I'd update the system, but it seems this bug is also in the new mediawiki php parser so a bug report is probably best
[04:18:24] <mooeypoo>	 You can also edit that page, add/change what you need in there. I think I copied over the edited version without the <> 
[04:22:15] <akp>	 yeah no big deal
[04:22:25] <akp>	 this one is actually better as its "more broken"
[04:22:59] <mooeypoo>	 seems so, yeah
[04:23:12] <mooeypoo>	 I'm slightly amused that VE presents it correctly while the php parser doesn't.
[04:23:38] <mooeypoo>	 I wonder, though.. hm
[04:23:40] <akp>	 it actually made me feel better that VE showed what i expected.  means that i did my tags properly
[04:23:43] <mooeypoo>	 this seems to fail with <p> as well
[04:24:12] <mooeypoo>	 Can I add to that page? Worse case revert it. I want to show you
[04:24:16] <akp>	 sure
[04:24:26] <akp>	 its your account its under =)
[04:28:20] <mooeypoo>	 yeah the end of that line cuts all off. So, even if I put wikitext in there, it breaks
[04:28:32] <mooeypoo>	 the only way to not break it, is to separate <pre> tags. Look at the page again
[04:28:43] <mooeypoo>	 now they're indented, but each line is its own <pre> tag
[04:28:49] <mooeypoo>	 That's not quite what you need
[04:29:10] <akp>	 yeah,i thought about doing it that way
[04:29:21] <akp>	 but it messes up the flow
[04:30:06] <akp>	 maybe i should try {{pre2}} ?
[04:30:11] <mooeypoo>	 akp, check out this page:
[04:30:15] <mooeypoo>	 https://en.wikipedia.org/wiki/Help:List
[04:30:57] <mooeypoo>	 it seems like lists break on endlines, so whatever they're doing there only works when you don't cut off the line (or, a trick, is to add <!-- [break line --> but that won't work inside <pre>
[04:31:28] <mooeypoo>	 Your next best bet is to use the full html markup
[04:31:35] <mooeypoo>	 <ul><li> ... etc
[04:31:46] <akp>	 yeap. guess so
[04:32:07] <akp>	 i wonder if they already have an open bug about this issue
[04:33:43] <mooeypoo>	 let's look 
[04:34:42] <mooeypoo>	 ah!
[04:34:45] <mooeypoo>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=1581
[04:36:07] <mooeypoo>	 Pretty old
[04:36:13] <akp>	 yeah
[04:36:22] <akp>	 looks like i have to live with it =/
[04:36:24] <mooeypoo>	 They seem to have several suggestions for fixes
[04:36:27] <mooeypoo>	 see if any of those work
[04:36:35] <mooeypoo>	 if not, use <ul> markup
[04:36:39] <mooeypoo>	 that might be your best chance
[04:36:45] <akp>	 ok
[04:37:04] <akp>	 i'll give it a whirl in the morning.  i am going to play some GTA to make myself stupid again
[04:37:13] <mooeypoo>	 haha
[04:37:14] <mooeypoo>	 enjoy :)
[04:37:31] <akp>	 thanks for the help mooeypoo i'll probably be back here tomorrow floating around
[04:38:03] <mooeypoo>	 no problems
[04:38:10] <mooeypoo>	 good luck and have fun playing GTA :)
[04:38:51] <akp>	 =) thanks man.  have a good day/night whatever timezone you happen to be in
[04:45:57] <mooeypoo>	 you too :)
[04:57:17] <James_F>	 mooeypoo: BTW, did you want to add an entry to https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects for VE documentation improvement, mentored by you?
[04:57:23] <James_F>	 mooeypoo: (Or anything else. :-))
[05:00:02] <mooeypoo>	 James_F, ooh. Mentor... 
[05:00:12] * James_F  grins.

[05:01:25] <mooeypoo>	 I do beginner-style docs. Did you have time to take a look at this? https://www.mediawiki.org/wiki/User:Mooeypoo/VisualEditor_Development
[05:02:00] <mooeypoo>	 Not exactly what VE's doc should be, but if I get a plan more or less, I think I might be able to do that with a student
[05:04:45] <James_F>	 I haven't yet, sorry.
[05:05:29] <mooeypoo>	 No rush, just curious to see what you think.
[06:25:23] <grrrit-wm>	 (03CR) 10Krinkle: "I concur :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/113309 (owner: 10Trevor Parscal)
[09:52:17] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Actually hide the size label when not in use [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113280 (owner: 10Trevor Parscal)
[09:53:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Actually hide the size label when not in use [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113280 (owner: 10Trevor Parscal)
[10:45:18] <grrrit-wm>	 (03PS1) 10Esanders: Fix shadow position in standalone toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113345 
[12:47:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester)
[12:51:58] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113319 (owner: 10Alex Monk)
[16:19:12] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 04-1] "The idea looks good in general, but the way it is implemented right now will create dirty diffs every time that correction is applied even" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (owner: 10Ltrlg)
[16:37:19] <grrrit-wm>	 (03CR) 10Ltrlg: "Always add optional "required" (current implementation) already causes dirty diffs imho… that’s why I thought there’s no problem doing thi" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (owner: 10Ltrlg)
[16:43:55] <grrrit-wm>	 (03CR) 10Mooeypoo: "In the 'apply' method there's a test to check if a parameter value changed the original value before applying it to the new json, that inc" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (owner: 10Ltrlg)
[16:45:13] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 04-1] "Sorry, this is still -1 on my end, for some reason it dropped in my previous comment." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (owner: 10Ltrlg)
[16:48:14] <mooeypoo>	 edsanders, the bug I reported happened to me multiple times in my huge tutorial article, I have a feeling it might have to do with "pre" tags. I just tried to replicate the copy/paste in an empty article and couldn't, but it *still* happens in my big tutorial page on mediawiki.
[16:49:01] <edsanders>	 Can you work out what the target is to reproduce it
[16:50:29] <mooeypoo>	 edsanders, this is the article it fails on: https://www.mediawiki.org/wiki/User:Mooeypoo/VisualEditor_Development
[16:50:58] <mooeypoo>	 I'm getting "Uncaught TypeError: Cannot call method 'getComparableObjectForSerialization' of undefined" in the console when I try to paste in 
[16:51:39] <grrrit-wm>	 (03Abandoned) 10Esanders: Add save shortcut to dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113319 (owner: 10Alex Monk)
[16:54:20] <RobertLabrie>	 mooeypoo, re bug 61151 I've not forgotten about it, I just got super busy at work. Hopefully tuesday I can give it some more attention
[16:55:34] <mooeypoo>	 RobertLabrie, no problems, I am not entirely sure we can fix it if it is something in MW core search, but at least we'll know about it, and perhaps could file a bug for the search itself or API if that's the case.
[16:57:30] <RobertLabrie>	 mooeypoo, just now I added File namespace in my search options and I can search partial filenames, but I still get no results in Visual Editor.
[16:57:40] <mooeypoo>	 :\
[16:57:59] <RobertLabrie>	 mooeypoo, if I wireshark the whole experience from clicking edit to clicking the media link, etc, would that .pcap be helpful?
[16:58:10] <mooeypoo>	 Can you add to the bug exactly what you did to the bug?
[16:58:16] <RobertLabrie>	 then you can see everything my browser sent and what it got back?
[16:58:25] <RobertLabrie>	 I will
[16:59:11] <mooeypoo>	 Sure, that can help too. I want to also see what you added in terms of MW config stuff, so I can test it in my local wiki and see if I can replicate.
[16:59:33] <RobertLabrie>	 mooeypoo, ok, I'll maybe just add my LocalSettings.php file. 
[17:04:31] <grrrit-wm>	 (03PS5) 10Esanders: Use accesskey=s on the save buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk)
[17:04:33] <grrrit-wm>	 (03PS2) 10Esanders: Add MW-specific keyboard shortcut help. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113118 
[17:35:42] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/113256/ https://gerrit.wikimedia.org/r/#/c/113116/ https://gerrit.wikimedia.org/r/#/c/109483/ then there's code-update for you.
[17:37:30] <James_F>	 RoanKattouw: Specifically https://gerrit.wikimedia.org/r/#/c/107540/ (separation of concerns) which has been going for four months now.
[17:37:42] <Krenair>	 James_F, hey, I saw you shared the worklists with me. Shall I keep my stuff updated with the status?
[17:37:51] <James_F>	 Krenair: Yeah, that'd help.
[17:38:00] <Krenair>	 might make it easier for you guys to see where I'm blocked waiting for others
[17:38:12] <James_F>	 Absolutely. :-)
[17:40:18] <Krenair>	 ok, done
[17:42:35] <grrrit-wm>	 (03PS2) 10Catrope: Fix shadow position in standalone toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113345 (owner: 10Esanders)
[17:43:22] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Fix shadow position in standalone toolbar (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113345 (owner: 10Esanders)
[17:43:36] <grrrit-wm>	 (03CR) 10Catrope: Fix shadow position in standalone toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113345 (owner: 10Esanders)
[17:47:25] <Krenair>	 James_F, for https://bugzilla.wikimedia.org/show_bug.cgi?id=50763 I'm wondering whether category hidden status should come from Parsoid or if we should find that information when loading the category dialog...
[17:47:46] <Krenair>	 (by querying the api)
[17:48:09] <gwicke>	 Krenair, ideally that would be CSS like red links
[17:48:44] <James_F>	 gwicke: Sure, whenever that's built.
[17:48:59] <James_F>	 RoanKattouw: Then, less critical, https://gerrit.wikimedia.org/r/#/c/95724/ and https://gerrit.wikimedia.org/r/#/c/95725/ and maybe https://gerrit.wikimedia.org/r/#/c/99655/ ?
[17:49:11] <Krenair>	 gwicke, ummm... Sorry, you mean to say that we should present hidden categories with some CSS to distinguish them?
[17:49:28] <James_F>	 Krenair: No.
[17:49:53] <James_F>	 Krenair: gwicke means that we should wait to fix it until a magic CSS-hinting service is built.
[17:50:11] <gwicke>	 or build that service
[17:50:20] <gwicke>	 could be JS-based too
[17:50:27] <Krenair>	 Oh. Okay, I don't think I've heard about that.
[17:50:37] <Krenair>	 Which is why I was so confused about what he meant.
[17:51:17] <James_F>	 Krenair: Bug 37901.
[17:51:39] <gwicke>	 we are trying to minimize cache invalidations and eliminate user preferences from the content HTML
[17:51:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Only allow pointer events on shields inside generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113256 (owner: 10Trevor Parscal)
[17:52:01] <James_F>	 Krenair: I think a client-side VE query asking the MW API for it, later replaced by a more general CSS cache API query, probably makes sense.
[17:52:13] <gwicke>	 so that we can use the same cached/stored HTML for logged-in users for much better performance
[17:52:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only allow pointer events on shields inside generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113256 (owner: 10Trevor Parscal)
[17:56:29] <James_F>	 gwicke: Indeed. You and RoanKattouw should probably sit down and agree how you think it should be built (by us? Parsoid?).
[17:56:58] <Krenair>	 James_F, gwicke: New comment seem about right?
[17:57:31] <gwicke>	 James_F, a good chunk of that is https://www.mediawiki.org/wiki/Requests_for_comment/Content_API
[17:58:32] <gwicke>	 we need to add endpoints for batch requests like redlinks and hidden categories
[17:58:37] <gwicke>	 could even be a single request
[17:58:52] <RoanKattouw>	 Yeah obviously it should allow that
[17:58:52] <James_F>	 gwicke: Yeah, that's what I was asking for.
[17:59:06] <RoanKattouw>	 Batching multiple different query types is a good point
[17:59:15] <RoanKattouw>	 But we should obviously allow batching multiple pages
[17:59:18] <James_F>	 Requesting 10000 API queries about link hinting is not a good mode.
[17:59:44] <gwicke>	 we kind of have it on our roadmap, but more as part of the 'use parsoid HTML for page views' stretch goal
[18:00:00] <James_F>	 Krenair: Looks good to me.
[18:00:16] <James_F>	 gwicke: I think we're going to want it much sooner than that for the red link hinting. Users are very not happy about it.
[18:00:31] <James_F>	 gwicke: So does that mean Roan/whoever needs to build it?
[18:00:38] <James_F>	 gwicke: (That's fine if so.)
[18:00:53] <gwicke>	 we should not do an half-assed job on that ideally
[18:01:08] <gwicke>	 lets sit together and think about what we need in the longer term
[18:01:10] <James_F>	 We've been discussing it for over a year.
[18:01:15] <James_F>	 Anyway, stand-up.
[18:01:26] <gwicke>	 and how we can start building the first bits of it now without having to re-do it later
[18:08:40] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] Use accesskey=s on the save buttons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk)
[18:33:16] <mooeypoo>	 TrevorP|Away the steps are here, if you want to go over them. It's a draft for the moment, I need to go over it for typos and such, but it covers all the steps that I've gone through. https://www.mediawiki.org/wiki/User:Mooeypoo/VisualEditor_Development
[18:47:28] <rdwrer>	 Can someone explain why some oojs-ui elements have display: none set on the element style?
[18:47:40] <rdwrer>	 I have a label, for example, with text " ", that has it.
[18:48:04] <rdwrer>	 The menu sort of made sense, I guess, but didn't need to be set on the element IMO
[18:48:10] <rdwrer>	 Harder to override
[18:48:14] <TrevorParscal>	 if the text is empty, it's triggering the lablel to not exist
[18:48:23] <rdwrer>	 It's not empty, it's " "
[18:48:33] <rdwrer>	 Bug maybe?
[18:48:35] <TrevorParscal>	 let me look at the code
[18:49:06] <TrevorParscal>	 yeah, so we check if it's a string and that it's not empty when trimmed
[18:49:30] <TrevorParscal>	 the reason for this is that the browser won't do what you think when you put " " between two tags anyway
[18:49:35] <TrevorParscal>	 what you want is &nbsp;
[18:50:14] <rdwrer>	 I put that in, and it gave me the literal text &nbsp; in the DOM.
[18:50:16] <TrevorParscal>	 but, perhaps LabeledElement could inteligently convert leading/trailing spaces to &nbsp; instead of trimming them
[18:50:21] <TrevorParscal>	 yeah, it's escaped
[18:51:02] <TrevorParscal>	 you could do this.$('<span>&nbsp</span>'); but admittedly that's not very nice
[19:00:10] <Krenair>	 RoanKattouw, around?
[19:00:25] <grrrit-wm>	 (03PS1) 10Trevor Parscal: Allow whitespace labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/113386 
[19:00:33] <TrevorParscal>	 rdwrer: check that out
[19:01:53] <rdwrer>	 Agh 80col
[19:02:24] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Allow whitespace labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/113386 
[19:02:40] <rdwrer>	 Excellent.
[19:03:38] <rdwrer>	 I wonder if it matters that it's a * and not a +
[19:03:46] <grrrit-wm>	 (03PS3) 10Ltrlg: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 
[19:03:47] <rdwrer>	 I doubt it does, you cover the zero case already
[19:04:05] <rdwrer>	 Idle ramblings of a Wikimedia developer
[19:04:07] * rdwrer  merges

[19:04:17] <rdwrer>	 Wait.
[19:04:25] <rdwrer>	 TrevorParscal: Maybe .trim() it if it's not just whitespace?
[19:04:34] <rdwrer>	 In case someone is relying on that
[19:04:39] <TrevorParscal>	 dude, test it furst
[19:05:05] <rdwrer>	 I'm not sure I have a super easy way to do so, but 'kay
[19:05:06] <TrevorParscal>	 yeah, maybe retain the trim in the non only-whitespace case
[19:05:12] <TrevorParscal>	 i'm testing as well
[19:06:34] <TrevorParscal>	 looks like it's working fine, i think the trim wasn't documented anyway
[19:06:42] <TrevorParscal>	 so it wasn't really behavior that SHOULD be depended on
[19:06:45] <TrevorParscal>	 and it's sort of odd
[19:06:54] <rdwrer>	 Yeah
[19:06:55] <TrevorParscal>	 the only thing we should do is document the behavior of passing in whitespace only
[19:06:58] <TrevorParscal>	 one sec
[19:08:16] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Allow whitespace labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/113386 
[19:08:25] <TrevorParscal>	 ok, docs added
[19:08:29] <TrevorParscal>	 gotta go to a meeting
[19:08:48] <rdwrer>	 'kay, tested, works
[19:09:10] <grrrit-wm>	 (03PS4) 10MarkTraceur: Allow whitespace labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/113386 (owner: 10Trevor Parscal)
[19:09:54] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Thankee Trevor" [oojs/ui] - 10https://gerrit.wikimedia.org/r/113386 (owner: 10Trevor Parscal)
[19:10:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow whitespace labels [oojs/ui] - 10https://gerrit.wikimedia.org/r/113386 (owner: 10Trevor Parscal)
[19:10:19] <James_F>	 rdwrer: Do you need that in wmf15 or is it less a priority?
[19:10:36] <James_F>	 rdwrer: We could do an out-of-process update of OOjs UI if it's urgent.
[19:10:55] <rdwrer>	 It's not, the patch I'm working on will be a while
[19:11:04] <James_F>	 Kk. Expect it in wmf16 then.
[19:11:31] <James_F>	 Also, can I extoll just how much I loathe Common.js files?
[19:12:06] <Krenair>	 Does anyone here know about caching on the WMF cluster? Might a GET request from a logged in user to the API ever return a cached result?
[19:12:30] <James_F>	 Krenair: Don't /think/ so, but it might depend on the query.
[19:12:40] <rdwrer>	 James_F: Extoll away
[19:12:42] <James_F>	 Krenair: Search result queries, for example, are cached, I think.
[19:12:47] <James_F>	 rdwrer: GNARHJDSGSHDJGADJBHFASJBFASVBJHASDVKBJA~!
[19:12:51] <James_F>	 rdwrer: There, better.
[19:13:07] <rdwrer>	 Heheh
[19:13:22] <James_F>	 rdwrer: Any ideas on fixing https://bpy.wikipedia.org/wiki/%E0%A6%AE%E0%A6%BF%E0%A6%A1%E0%A6%BF%E0%A6%AF%E0%A6%BC%E0%A6%BE%E0%A6%89%E0%A6%87%E0%A6%95%E0%A6%BF:Common.js ?
[19:13:35] <rdwrer>	 Make it shorter
[19:13:40] <rdwrer>	 ...
[19:13:55] <rdwrer>	 Something useful, right
[19:13:57] <James_F>	 Blanking it is tempting, but I think the community might be upset.
[19:17:13] <rdwrer>	 Probably
[19:17:18] <rdwrer>	 Bloody hell they're hard to please
[19:17:19] <rdwrer>	 :P
[19:18:11] <James_F>	 rdwrer: "JavaScript parse error: Parse error: Missing operand", except AFAICT it isn't.
[19:18:15] * James_F  grumbles.

[19:18:31] <rdwrer>	 Huh.
[19:18:33] <rdwrer>	 What line?
[19:18:39] <James_F>	 122.
[19:18:48] <James_F>	 "    for ( var i = 0; (NavFrame = divs[i]); i++ ) { "
[19:18:54] <rdwrer>	 And what does it matter because there are no line numbers grmblgrmbl
[19:19:15] <James_F>	 rdwrer: Code editor has them, as does Sublime.
[19:19:26] * rdwrer  squints at James_F

[19:21:51] <James_F>	 rdwrer: No cocoa for you, then. Also, you're WFH?
[19:22:07] <rdwrer>	 No, I...what? I talked to you this morning.
[19:22:14] <rdwrer>	 I'm on the couches because FUCKING FOURTH FLOOR
[19:22:54] <BladeBronson>	 trevor/roan: Do you see any issue with adding a throttle method alongside ve.debounce?
[19:23:09] <rdwrer>	 BladeBronson: There's a throttle/debounce method in core now.
[19:23:13] <BladeBronson>	 yeah?
[19:23:22] <rdwrer>	 https://gerrit.wikimedia.org/r/112956
[19:23:24] <James_F>	 rdwrer: Fourth?
[19:23:36] <rdwrer>	 James_F: See Loomio
[19:24:09] <BladeBronson>	 ah, in core mw.
[19:24:57] <BladeBronson>	 Wikia also has $.throttle and $.debounce jQuery plugins, but they're not available in a widget via this.$
[19:31:04] <BladeBronson>	 It looks like it's because of the wrapper in getJQuery in oojs-ui
[19:31:12] <BladeBronson>	 it causes plugins to not work
[19:32:20] <Krenair>	 rdwrer, 4th floor? is the office upstairs causing issues or something?
[19:32:58] <rdwrer>	 Krenair: They're loud sometimes
[19:33:33] <rdwrer>	 ...lots of times
[19:33:50] <James_F>	 rdwrer: There are times that they're not loud?
[19:33:59] <rdwrer>	 ...no
[19:34:02] * rdwrer  sobs

[19:34:14] <rdwrer>	 Any wonder I have headphones on a lot, or am on a couch?
[19:37:50] <James_F>	 rdwrer: Restlessness?
[19:38:03] <rdwrer>	 Lil bit.
[19:49:18] <grrrit-wm>	 (03PS3) 10Esanders: Fix shadow position in standalone toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113345 
[19:49:33] <grrrit-wm>	 (03PS4) 10Esanders: Fix shadow position in standalone toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/113345 
[19:59:33] <grrrit-wm>	 (03CR) 10Esanders: [WIP] Centralize image handling into a stand-alone model (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal)
[20:21:41] <edsanders>	 RoanKattouw, <code>foo<br>bar</code>
[20:22:27] <edsanders>	 gives [..., {'type':'break','annotations':[0]}, {'type':'/break','annotations':[0]}, ...] in some cases
[20:22:42] <edsanders>	 (annotations on close tag)
[20:23:15] <Krenair>	 Is there some easy way to get the instance of MWCategoriesPage from MWCategoryPopupWidget that I'm completely missing?
[20:23:22] <edsanders>	 and they're reference equal so when we re-map store indices, it tries to do it twice
[20:32:00] <grrrit-wm>	 (03PS1) 10Jforrester: Update list of production wikis that should be tested as working [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113454 
[20:34:20] <edsanders>	 ugh, looks like that's getting added by sanitize()
[20:56:39] <grrrit-wm>	 (03CR) 10Jhall: [C: 032] Update list of production wikis that should be tested as working [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113454 (owner: 10Jforrester)
[20:57:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update list of production wikis that should be tested as working [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113454 (owner: 10Jforrester)
[21:40:19] <grrrit-wm>	 (03PS1) 10Alex Monk: VisualEditor: Mark hidden categories as different in the meta-data dialog so users understand they won't display [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 
[21:41:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] VisualEditor: Mark hidden categories as different in the meta-data dialog so users understand they won't display [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk)
[21:43:05] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] VisualEditor: Mark hidden categories as different in the meta-data dialog so users understand they won't display (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk)
[21:43:45] <grrrit-wm>	 (03CR) 10Alex Monk: VisualEditor: Mark hidden categories as different in the meta-data dialog so users understand they won't display (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk)
[21:44:02] <James_F>	 JeffHall: Thanks for the merge!
[21:45:31] <JeffHall>	 James_F: No prob - great to hear that you got VE working on some of those additional wikis!
[21:46:06] <James_F>	 JeffHall: Took some time; a lot of our wikis have unbelievably-terrible code sitting in common.js. :-(
[21:46:38] <grrrit-wm>	 (03PS2) 10Catrope: Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 (owner: 10Trevor Parscal)
[21:46:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 (owner: 10Trevor Parscal)
[21:50:38] <Krenair>	 RoanKattouw, hm... Thinking about my comment on https://gerrit.wikimedia.org/r/#/c/113464/ - maybe I should be storing category hidden status as a bool under each MWCategoryMetaItem...
[21:50:46] <Krenair>	 what do you think?
[21:52:20] <grrrit-wm>	 (03PS3) 10Catrope: Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 (owner: 10Trevor Parscal)
[21:56:40] <RoanKattouw>	 Ahm, wait a second
[21:56:53] <RoanKattouw>	 Is this modifying the category *suggestions* or the  display of *already added* categories?
[21:58:00] <James_F>	 Both?
[21:58:12] <RoanKattouw>	 Well the techniques will be very different
[21:58:20] <RoanKattouw>	 Which one(s) is the patchset trying to accomplish?
[21:59:38] <James_F>	 RoanKattouw: Given that both is the objective, I'd imagine it'd shape the technique, however.
[22:05:06] <RoanKattouw>	 Well sure
[22:05:25] <RoanKattouw>	 So for the existing categories, I think we should query their hidden status before even displaying any categories
[22:05:39] <RoanKattouw>	 That way we know the status when we construct the widget for that category, so we have no information passing nightmares
[22:06:08] <RoanKattouw>	 Then do something similar for the suggestions, don't display them until you know everything you need to know including hiddenness
[22:06:43] <RoanKattouw>	 Then for adding a category (which you can do before the suggestions come in, by pressing enter quickly), do something similar, wait until you know its status before adding it
[22:07:13] <RoanKattouw>	 It will probably be useful to have a cache of promises for this stuff
[22:07:50] <grrrit-wm>	 (03PS3) 10Trevor Parscal: FieldLayout, styling improvements and standardization [oojs/ui] - 10https://gerrit.wikimedia.org/r/108955 
[22:07:59] <RoanKattouw>	 So that you can reuse cached results (promises once resolved retain their resolved-ness and the parameters they were resolved with forever) and so that if you have multiple things trying to get the same piece of data that won't cause multiple AJAX requests
[22:09:26] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Minor comments inline" (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 (owner: 10Trevor Parscal)
[22:15:36] <grrrit-wm>	 (03PS4) 10Trevor Parscal: Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 
[22:17:44] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Looks OK except for one bug, see inline comment" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112145 (owner: 10Trevor Parscal)
[22:23:16] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Update use of OO.ui.PageLayout to work with changes in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112145 
[22:23:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update use of OO.ui.PageLayout to work with changes in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112145 (owner: 10Trevor Parscal)
[22:23:48] <grrrit-wm>	 (03PS3) 10Trevor Parscal: Update use of OO.ui.PageLayout to work with changes in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112145 
[22:23:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update use of OO.ui.PageLayout to work with changes in OOUI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112145 (owner: 10Trevor Parscal)
[22:25:06] <TrevorParscal>	 edsanders: aren't you supposed to be in the thralls of an extravagant romantic experience
[22:25:39] <James_F>	 TrevorParscal: He was. Then he started working. :-)
[22:31:42] <grrrit-wm>	 (03PS1) 10Catrope: Clean up onResourceLoaderRegisterModules() to make it more data-driven [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113473 
[22:32:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Clean up onResourceLoaderRegisterModules() to make it more data-driven [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113473 (owner: 10Catrope)
[22:34:46] <grrrit-wm>	 (03PS2) 10Catrope: Clean up onResourceLoaderRegisterModules() to make it more data-driven [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113473 
[22:35:03] <grrrit-wm>	 (03CR) 10Catrope: [C: 031] Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 (owner: 10Trevor Parscal)
[22:35:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Clean up onResourceLoaderRegisterModules() to make it more data-driven [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113473 (owner: 10Catrope)
[22:50:04] <mooeypoo>	 ryasmeen, are you around? I managed to replicate your bug in betalabs but not on master :\
[22:50:21] <ryasmeen>	 mooeypoo, which one?
[22:50:38] <mooeypoo>	 The one with the search term "April"
[22:50:55] <mooeypoo>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=61392
[22:52:26] <mooeypoo>	 ryasmeen, I may have found the source, but it's really weird.
[22:55:59] <ryasmeen>	 okay, I just asked James.The reason you are not being able to reproduce it on Master is probably it has a different search system
[22:56:38] <mooeypoo>	 yeah, the problem is that I have an idea on how to fix it, but since I can't replicate in master, I can't verify it works :\
[22:56:50] <mooeypoo>	 ryasmeen, James_F any ideas ? :\
[23:07:54] <Sveta>	 what is the reason parsoid exists? can't parsing functions be exposed in the api? eg. "for this snippet, return names and params of all templates used in a hierarchical JSON tree" or something
[23:08:33] <gwicke>	 Sveta, that's what parsoid is doing
[23:08:42] <Sveta>	 no, it's a daemon, it's not doing that
[23:08:53] <gwicke>	 apache is a daemon too
[23:08:54] <Sveta>	 it parses as its name implies :)
[23:09:18] <Sveta>	 I mean, why run a daemon when I think an api query would just work?
[23:09:34] <gwicke>	 it is an api query too
[23:09:35] <Sveta>	 does parsoid just work like a proxy, by passing on an api query to a wiki instance?
[23:09:38] <gwicke>	 just against another daemon
[23:10:08] <gwicke>	 we interact with MW through the API, yes
[23:10:30] <gwicke>	 basically fetch wikitext, image and config info
[23:10:35] <Sveta>	 why not merge parsoid into mediawiki? and what extra functionality does it provide on top of what a MW API query would already do?
[23:10:58] <gwicke>	 Sveta, the main functionality is that it runs on a platform that finishes requests in a reasonable time
[23:11:04] <Sveta>	 you mean that parsoid is a wiki instance hooked onto same config, with interface bits removed?
[23:11:13] <Sveta>	 (roughly)
[23:11:24] <gwicke>	 the same thing in PHP would be about one magnitude slower
[23:11:28] <gwicke>	 at least
[23:11:42] <Sveta>	 ahh! why not use something non-php-ish in MW itself, then, if it's slow?
[23:12:10] <gwicke>	 Sveta, we are slowly moving to a service-based architecture
[23:12:17] <Sveta>	 (is it just a thing you wrote by taking the MW's parsing functions and rewriting them — identicaly — in another language?)
[23:12:31] <gwicke>	 we can improve one service at a time, but can't rewrite everything from scratch at once
[23:12:43] <gwicke>	 Sveta, no
[23:13:01] <gwicke>	 check out https://www.mediawiki.org/wiki/Parsoid and http://blog.wikimedia.org/2013/03/04/parsoid-how-wikipedia-catches-up-with-the-web/
[23:14:26] <Sveta>	 it appears to do parsing, which means you looked at how MW does it, and wrote the same in node.js -- at least thats how it looks to me after reading the first page
[23:15:21] <mooeypoo>	 ryasmeen, James_F  https://gerrit.wikimedia.org/r/#/c/113478/ This *should* work. However, I couldn't test it in my local wiki because I can't replicate the bug from beta labs :\ 
[23:15:37] <RoanKattouw>	 Sveta: The rest of the blog post talks about how Parsoid is bidirectional (can convert HTML back to wikitext) while the PHP parser is unidirectional
[23:15:46] <Sveta>	 yes I noticed
[23:15:50] <RoanKattouw>	 That second direction is vital for VE
[23:15:56] <Sveta>	 yup
[23:16:04] <RoanKattouw>	 And the MW parser does parsing in a way that is not at all suited to bidirectionality
[23:16:12] <RoanKattouw>	 Or even reasonable at all :)
[23:16:13] <Sveta>	 so one of parsoid things is how mw does it and another one is backwards :)
[23:16:16] <gwicke>	 we also balance tags, preserve all kinds of info that the PHP parser throws away etc pp
[23:16:26] <Sveta>	 mmmm
[23:16:59] <Sveta>	 thanks
[23:18:12] <Sveta>	 i dont see how to 'store in html5' -- eg i have an infobox on an article, markup stores it as a transclusion
[23:28:50] <InezK>	 Where is origin repository for ooui.js?
[23:29:13] <InezK>	 oojs-ui
[23:31:40] <RoanKattouw>	 InezK: oojs/ui.git
[23:31:56] <RoanKattouw>	 ssh://gerrit.wikimedia.org:29418/oojs/ui.git to be precise
[23:35:29] <InezK>	 oh, wow, it's in resources now
[23:35:31] <InezK>	 interesting
[23:35:32] <InezK>	 thanks
[23:36:38] <RoanKattouw>	 And yeah it's in MW core since yesterday
[23:36:46] <RoanKattouw>	 But that's not the master copy
[23:36:55] <InezK>	 I see
[23:37:05] <RoanKattouw>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/113477/
[23:37:26] <InezK>	 RoanKattouw: Vagrant has old version of node installed, how do I fix that issue at the source?
[23:37:36] <RoanKattouw>	 I don't know
[23:37:57] <InezK>	 Do you know who maintain vagrant?
[23:38:08] <InezK>	 Or I guess I can just bugzilla it... 
[23:38:19] <RoanKattouw>	 I don't know offhand, so yeah just BZ it
[23:41:21] <Krenair>	 RoanKattouw, just been reading your response earlier, it doesn't really answer my question
[23:41:35] <Krenair>	 This is not dealing with suggestions, only categories which are existing or added
[23:41:44] <RoanKattouw>	 OK
[23:41:47] <Krenair>	 James_F, ^
[23:41:53] <Krenair>	 [22:05:25] <RoanKattouw>	 So for the existing categories, I think we should query their hidden status before even displaying any categories
[23:41:56] <Krenair>	 yes that's what it's doing
[23:41:58] <RoanKattouw>	 So as I said, I think you should gather all the information about a category before you add it or built the existing list
[23:42:10] <RoanKattouw>	 Then you shouldn't have information relay problems
[23:42:19] <RoanKattouw>	 Because it's all constructor parameters or whatever
[23:44:11] <Krenair>	 I started to change my patch set earlier but that was on my desktop, and I'm not sure it's a good idea to keep having it turn on and off due to the power cuts
[23:44:35] <RoanKattouw>	 Oh are you in a flooding-affected area?
[23:51:24] <Krenair>	 No flooding really, but there's a big storm at the moment.
[23:53:18] <edsanders>	 TrevorParscal, why, is today a special day or something?
[23:54:52] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 (owner: 10Trevor Parscal)
[23:54:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Invert dependencies for OutlineItemWidget and PageLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/112142 (owner: 10Trevor Parscal)