[02:15:34] rdwrer tags are broken in multiline lists. According to bugzilla, it is known. [02:15:47] Every time I say that, I feel the urge to add "Khalissi" at the end. [02:16:19] Heh [02:16:20] anyways, akp I'm glad it at least solved it :\ i know it's a pain, but it seems that for the moment, that's the only way you can get away with having any other html content inside a multiline list. [02:17:25] rdwrer, he wants to have 
 tags inside multiline lists. Nothing worked except for full html tags. According to bugzilla it seems no tags could be displayed in multiline lists at the moment, except for "
" all else seems to break the list.
[02:17:39] 	 The irony is that VE displays it properly :P
[02:20:48] 	 but rdwrer you have a point, akp did you consider using a template for the list instead of working with html? now that you know it works, maybe make a 
  •  ...
    • ...
 template to make your life easier?
[02:22:44] 	 Hm weird
[02:52:48] 	 rdwrer, i think we talked about this when I was in SF last august, didn't we? I was explaining about how block language inside lists would be an annoyance, and might have to require changing wikitext-to-html, which would be dirty-diff hell.
[02:54:44] 	 Hahaha
[02:55:36] 	 Does that mean you remember?
[02:55:37] 	 :D
[16:21:46] 	 (03PS18) 10Jforrester: Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 
[16:23:42] 	 (03CR) 10jenkins-bot: [V: 04-1] Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester)
[16:38:17] 	 (03PS1) 10Zfilipin: [browser test] Updating to mediawiki_selenium 0.2.6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113979 
[16:40:01] 	 (03CR) 10jenkins-bot: [V: 04-1] [browser test] Updating to mediawiki_selenium 0.2.6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113979 (owner: 10Zfilipin)
[17:14:57] 	 edsanders: rmoen: good morning
[17:16:26] 	 hey
[17:17:05] 	 (03PS3) 10Trevor Parscal: Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 
[17:17:12] 	 (03PS4) 10Trevor Parscal: Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 
[17:17:14] 	 (03CR) 10jenkins-bot: [V: 04-1] Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal)
[17:17:26] 	 (03CR) 10jenkins-bot: [V: 04-1] Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal)
[17:27:09] 	 TrevorParscal, on the page settings dialog, do the checkboxes vertically align with the text correctly, or is that just variation between OSes?
[17:27:40] 	 you looking at localhost or a deployment
[17:27:41] 	 ?
[17:27:51] 	 local
[17:28:50] 	 IME, the only way to ensure alignment is to draw the checkboxes yourself
[17:29:12] 	 looks the same on betalabs
[17:29:38] 	 TrevorParscal, http://i.imgur.com/I2FS2E7.png
[17:30:12] 	 the margins are different (0.5em vs 0.75em) but that may work if the checkbox renders bigger
[17:30:36] 	 Is that using FieldLayout or CheckboxWidget (the former was merged recently, but might not be deployed)
[17:31:02] 	 they should probably be inline-block vertical-align middle or something
[18:04:26] 	 TrevorParscal, FieldLayout
[18:21:31] 	 Is James not around today?
[18:22:37] 	 Krenair: He's at his desk, want I should poke him?
[18:23:47] 	 Assuming he's not too busy, yes please. It's not that important
[18:30:05] 	 (03PS5) 10Jforrester: Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal)
[18:30:13] 	 (03CR) 10jenkins-bot: [V: 04-1] Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal)
[18:30:19] 	 Hi James_F
[18:31:12] 	 Hey Krenair.
[18:31:54] 	 I don't know if you saw but I looked into the remaining bugs on my list
[18:32:00] 	 Sorry I failed to poke him, I switched windows and then failed to come back
[18:33:14] 	 (03PS1) 10Esanders: Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 
[18:33:20] 	 Krenair: Haven't looked yet, sorry.
[18:34:35] 	 (03CR) 10jenkins-bot: [V: 04-1] Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 (owner: 10Esanders)
[18:34:57] 	 Ok. Anyway one which I'm not too sure about is https://bugzilla.wikimedia.org/show_bug.cgi?id=51260 (Cite: Support multi-column and alternative list-style for  tag) - there was some disagreement about what we should do exactly
[18:37:18] 	 Additionally on the worklist there's a note that it "needs CE local rendering to change, and for Parsoid to change their reference list rendering" - are those dependencies or things that will need to be done before VE can use the new attributes?
[18:37:57] 	 They're more issues in lock-step.
[18:38:27] 	 James_F, is there a bug for the parsoid part?
[18:38:46] 	 So they need to be in the same deployment?
[18:39:03] 	 gwicke: No; I was thinking that we should have the changes to Cite made first (but not merged) before Parsoid is asked to duplicate the code.
[18:39:17] 	 Krenair: Ideally Parsoid would go out with support slightly beforehand.
[18:39:18] 	 maybe we should discuss it first
[18:39:24] 	 Krenair: But that's just a matter of timing.
[18:39:27] 	 gwicke: Yeah.
[18:39:48] 	 so please open a bug and make sure to CC me
[18:40:00] 	 or bring it up some other way
[18:40:10] 	 gwicke: Primary objective is to render {{reflist}}s pointless, instead pushing the functionality into the extension (and deprecating the templates).
[18:40:19] 	 gwicke: The discussion is on https://bugzilla.wikimedia.org/show_bug.cgi?id=51260
[18:40:38] 	 gwicke: Have added you as a CC.
[18:41:55] 	 James_F, okay, so what exactly is the change we're going to make to Cite? You proposed adding multi-column support directly to it but others disagreed and said we shouldn't support that - but we still want to push enwiki {{reflist}} functionality into Cite, what should I do?
[18:41:57] 	 thanks
[18:42:40] 	 Krenair: Was about to suggest on the bug; perhaps change to *column-width* support (which scales) rather than column number?
[18:43:00] 	 James_F, can you summarize your envisioned changes somewhere?
[18:43:13] 	 gwicke: https://bugzilla.wikimedia.org/show_bug.cgi?id=51260
[18:43:32] 	 gwicke: We talked about this about nine months ago. :-)
[18:44:16] 	 I'm having a hard time finding a summary of the actual changes in there
[18:44:33] 	 are you proposing to support a class attribute?
[18:45:20] 	 I was proposing adding list-style and column-width, but a class works well (and is easier for Parsoid to support).
[18:45:29] 	 Though that would mean munging on VE's end, I guess.
[18:45:31] 	 Krinkle: so, I want to try and land a bunch of oo-ui changes before I try and split things up
[18:45:40] 	 and, you have your dialog stuff still out right?
[18:45:41] 	 inline CSS is a no-go IMO
[18:45:59] 	 would need to be a class so that mobile etc can style it differently
[18:46:15] 	 Krinkle: https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/ui+owner:Krinkle,n,z
[18:46:24] 	 these are still WIP, what do they need?
[18:46:26] 	 (This was basically my issue with it too)
[18:48:09] 	 gwicke: VE would need to provide an editing interface to it, though; could be a little messy. Maybe a drop-down of local styles? Hmm.
[18:48:52] 	 cite can define standard styles, and local wikis can override them
[18:49:01] 	 James_F, I could update https://gerrit.wikimedia.org/r/#/c/32700/10 - but then I couldn't merge it
[18:49:35] 	 Krenair: Merging is easier than writing code. :-)
[19:11:49] 	 Krenair: Have dumped a bunch more on you, sorry. :-)
[19:11:57] 	 James_F and TrevorParscal -- this bug exposes a bit of a deeper issue with alt vs caption. In some cases alt *is* caption and in some alt is the 'title=' of the image.. I'm going to just do a 'quickfix' so to use the same text input widget just stretched across the full width of the screen, but maybe we should consider what to do with the mix between alt and caption, if at all possible to separate between them? :\
[19:11:58] 	  https://bugzilla.wikimedia.org/show_bug.cgi?id=61329
[19:13:07] 	 According to the report, if I understood it correctly, the reporter might actually expect an edit surface similar to caption...?
[19:13:48] 	 mooeypoo: Umm. What? No.
[19:14:03] 	 mooeypoo: Alt text is exclusively plain text, but it should be bigger.
[19:14:09] 	 mooeypoo: This is a CSS change only. :-)
[19:14:52] 	 mooeypoo: The fact that magically a caption (down-cast to plain text) gets used as the alt text if you don't specify one and it's an image that doesn't take a caption is totally different.
[19:17:11] 	 (03PS1) 10Kaldari: Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 
[19:17:18] 	 (03CR) 10jenkins-bot: [V: 04-1] Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 (owner: 10Kaldari)
[19:18:31] 	 (03PS2) 10Kaldari: Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 
[19:18:33] 	 (03PS5) 10Kaldari: Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 
[19:20:13] 	 (03CR) 10jenkins-bot: [V: 04-1] Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 (owner: 10Kaldari)
[19:20:46] 	 (03CR) 10jenkins-bot: [V: 04-1] Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 (owner: 10Kaldari)
[19:20:53] 	 (03CR) 10Krinkle: [C: 032] Fix occurrences of @mixin to be @mixins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113486 (owner: 10Catrope)
[19:21:26] 	 James_F, hm, okay, I got completely confused. I saw the snippets on this page and my brain fell out of my head, sorry, I didn't notice there's a pip between the alt=text.. and the wikitext that is the caption.
[19:21:29] 	 That makes more sense now.
[19:21:43] 	 pipe*
[19:21:49] 	 mooeypoo: No worries. Sorry you got confused.
[19:21:58] 	 TrevorParscal: James_F: FYI regarding adopting LESS in OOjs UI and VE, we won't have any linting capability that way.
[19:22:07] 	 (03PS2) 10Esanders: Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 
[19:22:12] 	 Which is a regression for us, unlike core.
[19:22:27] 	 Krinkle: Core has LESS linting?
[19:22:30] 	 (03CR) 10jenkins-bot: [V: 04-1] Fix occurrences of @mixin to be @mixins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113486 (owner: 10Catrope)
[19:22:41] 	 he's just saying we don't have a way to lint less code
[19:22:43] 	 James_F, I remembered that the alt and caption could be "miraculously" exchanged at some point so when I saw that request with the snippet I got confused about it. ok, seems like a fairly straight forward fix then, woot.
[19:22:49] 	 James_F: Core doesn't lint css.
[19:22:51] 	 Never did
[19:22:53] 	 but, I'm fine with that
[19:23:24] 	 Krinkle: Should we lint the CSS output of LESS maybe (the dist?).
[19:23:36] 	 (03CR) 10jenkins-bot: [V: 04-1] Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 (owner: 10Esanders)
[19:23:40] 	 What is up with Jenkins?
[19:23:52] * Krinkle  throws trout 
[19:24:54] 	 Krinkle: Down, boy. Let hashar fix it, not you. We need you for VE things. :_)
[19:25:00] 	 Looks like hashar broke it again
[19:25:04] 	 WE can't merge
[19:25:16] 	 Hashar is gone for the day
[19:25:19] 	 Your call
[19:25:25] * James_F  sighs.
[19:26:33] 	 Krinkle: The issue is a CERT_UNTRUSTED on fetching grunt-jscs-checker; did we change the certs, or did theirs expire?
[19:26:48] 	 No, not related to that grunt package
[19:27:02] 	 He set up 2 new instances with a newer version of npm, and no SSL certs
[19:27:03] 	 and then deleted the old instance that was working
[19:27:11] 	 Krinkle: Oh. Helpful.
[19:27:14] 	 without testing any npm jobs first apparently
[19:28:11] 	 Krinkle: I don't think there's any huge crisis if we can't merge, but if it's a quick fix…
[19:29:31] 	 James_F: I'll file a bug and see if there's a quick fix.
[19:30:05] 	 (03PS1) 10Esanders: InputLabelWidget -> LabelWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114005 
[19:31:14] 	 Krinkle: Thanks.
[19:31:25] 	 (03CR) 10jenkins-bot: [V: 04-1] InputLabelWidget -> LabelWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114005 (owner: 10Esanders)
[19:31:42] 	 edsanders: Can you answer Krenair on https://bugzilla.wikimedia.org/show_bug.cgi?id=55985 about how to replicate the underlying issue (bug 59002 was the quick-fix a couple of weeks ago).
[19:31:50] 	 ok
[19:33:18] 	 James_F: Do you have any idea what this CERT UNTRUSTED error from Jenkins is about: https://gerrit.wikimedia.org/r/#/c/112618/
[19:33:50] 	 greg-g: ^
[19:33:58] 	 kaldari: hashar broke CI. :-(
[19:34:07] 	 boo
[19:34:12] 	 Indeed.
[19:34:53] 	 James_F, that bug is almost certainly resolved, as we don't generate template HTML for Parsoid anymore
[19:35:08] 	 edsanders: OK, that helps.
[19:35:29] 	 James_F, https://gerrit.wikimedia.org/r/#/c/111517/
[19:36:13] 	 edsanders: Aha.
[19:37:13] 	 edsanders: Thanks! Krenair: Sorry for wasting your time.
[19:44:14] 	 James_F: Ugh, it also implicitly downgraded node from v0.10 to v0.8
[19:45:59] 	 Krinkle: Yay.
[19:47:56] 	 (03PS1) 10Mooeypoo: Make alternate text input stretch to full width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114022 
[19:49:21] 	 (03CR) 10jenkins-bot: [V: 04-1] Make alternate text input stretch to full width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114022 (owner: 10Mooeypoo)
[19:49:30] 	 ... meh
[19:51:51] 	 mooeypoo: Jenkins is down for everyone, not just you.
[19:52:03] 	 yeah I just realized from the fact I had no idea what it says I did wrong :P
[19:52:29] 	 it's also like.. a 3-line change. Not much could go wrong... anyways. On to a new one!
[19:58:59] 	 TrevorParscal, Krinkle: Ping reminder re. your meeting with kaldari. :-)
[20:03:32] 	 (03CR) 10Jforrester: Show "General references" as placeholder text in group input box on reference list insert dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113684 (owner: 10Alex Monk)
[20:03:36] 	 (03CR) 10Esanders: [C: 032] Make alternate text input stretch to full width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114022 (owner: 10Mooeypoo)
[20:04:44] 	 (03CR) 10jenkins-bot: [V: 04-1] Make alternate text input stretch to full width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114022 (owner: 10Mooeypoo)
[20:08:18] 	 hrm, anyone knows and can help with with mw.config.get ? does it only work with the variables that are defined in the wiki page, or does it supposed to grab all $wgParameters from the wiki config?
[20:09:22] 	 and I mean the ones in this wiki page: https://www.mediawiki.org/wiki/Manual:Interface/JavaScript#mw.config
[20:11:44] 	 mooeypoo, it certainly doesn't work with all wg* variables defined in config, that would be a major security issue :)
[20:11:52] 	 specifically, I need wgDefaultUserOptions so I can get the default "thumbsize"
[20:12:12] 	 (03PS2) 10Alex Monk: Show "General references" as placeholder text in group input box on reference list insert dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113684 
[20:12:24] 	 Krenair, is that accessible through mw.config.get() or do I need to call for this in the API, do you have any idea?
[20:12:30] 	 and.. good point.
[20:14:15] 	 I think you need to expose it as a global in a hook, mooeypoo. Although depending on what you're trying to achieve, there might be a better way of doing things
[20:14:40] 	 (See VisualEditorHooks::onResourceLoaderGetConfigVars anyway)
[20:14:52] 	 hmm.
[20:15:34] 	 Well, I want to deal with the bug report about inserting images .. right now, the images get a fixed size, and it seems a bit backwards. I want to make sure the size they get is wiki-default or no size defined at all (which should fall back to wiki default
[20:21:46] 	 mooeypoo: IIRC you want wgThumbLimits and wgDefaultUserOptions just tells you the index of that array to use?
[20:22:00] 	 aye
[20:22:22] 	 but i'm trying to get wgDefaultUserOptions .. can't seem to manage to with mw.config.get( 'wgDefaultUserOptions' )
[20:23:22] 	 it keeps coming back null
[20:23:29] 	 Hmm. Sounds like it's not passed through.
[20:23:38] 	 James_F, is that in the hooks?
[20:23:41] 	 Maybe we need to create a new mw.config option?
[20:23:47] 	 (Yay. Sigh.)
[20:24:44] 	 seems to be no other choice. I can't even set the size to nothing, it comes back as wikitext |NaNxNaN 
[20:24:45] 	 :p
[20:24:56] 	 Helpful.
[20:25:05] 	 Is that a known Parsoid bug/
[20:25:19] 	 I don't know if that's parsoid or us setting NaN values in width/height
[20:25:22] 	 I'm checking into that
[20:26:03] 	 'Cos ideally we should just have figures automatically have a size unless explicitly set (because [[File:foo|thumb|220px]] and [[File:foo|thumb]] may render identically, but we want to produce the latter not the former).
[20:26:12] * mooeypoo  nods
[20:26:18] 	 the problem is that we also have to set explicit size in CE
[20:26:30] 	 Yeah.
[20:26:41] 	 so in MWMediaInsertDialog we have a line "this.surface.getModel().getFragment().collapseRangeToEnd().insertContent( [ { ... ] ] )
[20:26:48] 	 I thought at first I can just take off width/height
[20:28:44] 	 ok I take it back. It seems to be a parsoid bug.
[20:29:22] 	 when I take those values off, the image renders perfectly in CE with style="height: auto" in the 
 and no height/width values at all.
[20:29:30] 	 But then it turns NaNxNaN on wikitext.
[20:29:43] 	 gwicke, is there any special class I should add to an image that is default thumb size?
[20:32:20] 	 mooeypoo, yes: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Images
[20:32:49] 	 we have a spec for a reason ;)
[20:33:52] 	 sorry, I lost that page on reinstallation. It's now securely bookmarked.
[20:33:53] 	 thanks :)
[20:41:21] 	 (03CR) 10Jhall: [C: 032] [browser test] Updating to mediawiki_selenium 0.2.6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113979 (owner: 10Zfilipin)
[20:42:30] 	 (03Merged) 10jenkins-bot: [browser test] Updating to mediawiki_selenium 0.2.6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113979 (owner: 10Zfilipin)
[20:56:47] 	 (03PS3) 10Jforrester: Show placeholder text in group input box on reference list dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113684 (owner: 10Alex Monk)
[20:56:59] 	 (03CR) 10Jforrester: [C: 031] Show placeholder text in group input box on reference list dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113684 (owner: 10Alex Monk)
[21:12:33] 	 Krinkle|detached: BTW, thanks for fixing jenkins. You're awesome. Etc. :-)
[21:12:48] 	 (03PS3) 10Catrope: Fix occurrences of @mixin to be @mixins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113486 
[21:12:59] 	 (03CR) 10Jforrester: [C: 032] "Per Timo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113486 (owner: 10Catrope)
[21:13:14] 	 (03PS2) 10Mooeypoo: Make alternate text input stretch to full width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114022 
[21:13:20] 	 (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114022 (owner: 10Mooeypoo)
[21:15:27] 	 (03Merged) 10jenkins-bot: Fix occurrences of @mixin to be @mixins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113486 (owner: 10Catrope)
[21:17:33] 	 (03Merged) 10jenkins-bot: Make alternate text input stretch to full width [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114022 (owner: 10Mooeypoo)
[21:17:58] 	 Is there a comment to re-run jenkins?
[21:18:46] 	 edsanders: "recheck" re-runs the V+1 checks, but not the V+2 checks.
[21:19:00] 	 edsanders: And it won't re-run the merge process unless there's a new CR+2.
[21:19:07] 	 edsanders: Hence why I just did it.
[21:22:21] 	 hm, okay, this is apparently not as quickfix'y as I thought. Time for a new strategy.
[21:25:12] 	 (03CR) 10Esanders: Add MW-specific keyboard shortcut help. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113118 (owner: 10Esanders)
[21:39:55] 	 (03PS19) 10Jforrester: Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 
[21:40:27] 	 (03PS6) 10Kaldari: Move some skin styling from ve.ce.Node.css to a shared skin css file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112618 
[21:40:33] 	 (03PS3) 10Kaldari: Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 
[21:40:41] 	 Arrg, its been raining so much up here and now my house is leaking.
[21:41:12] 	 rmoen: Fun!
[21:42:53] 	 James_F: Yeah i'm thinking i need to rent a carpet cleaner and get the water out the carpets
[21:43:15] 	 TrevorParscal, seems to be a couple of missing renames from https://gerrit.wikimedia.org/r/#/c/108957/
[21:43:27] 	 MediaSizeWidget has a couple, too. I'll add them in
[21:43:43] 	 rmoen: Might wait for the rainy period to stop first?
[21:43:55] 	 yeah, I thought Roan caught those in his review, I know he caught some
[21:45:36] 	 hm. wait, no, these are fixed. Why is firefox insisting they're not... 
[21:45:56] 	 eh, cache cleared... still a problem. What the hell
[21:46:56] 	 (03CR) 10Jforrester: "Followed-up in If7a332af15b1e8612." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/108957 (owner: 10Trevor Parscal)
[21:47:10] 	 (03CR) 10Jforrester: [C: 032] InputLabelWidget -> LabelWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114005 (owner: 10Esanders)
[21:50:27] 	 Ugh, it's that time of day again, marktraceur has oojs-ui questions
[21:50:36] 	 (03Merged) 10jenkins-bot: InputLabelWidget -> LabelWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114005 (owner: 10Esanders)
[21:51:07] 	 I have a bit of code that creates a menu
[21:51:08] 	 https://dpaste.de/7NyM
[21:51:23] 	 And a later bit of code that updates the number values
[21:51:27] 	 James_F, question: If I go ahead and make images not have size when inserted, it also means that when you edit a newly inserted image, the size widget will show both values as empty, and marked as red. Practically speaking it doesn't matter, because the values ae considered invalid so nothing will be changed unless you actively change it, but it does look a bit odd. Is it agreeable as a temporary fix, until we have Trev
[21:51:28] 	 orParscal's complete refactor of the media/resizable node and can find a better way of doing default sizes?
[21:51:53] 	 But only the "small" option shows up in the interface, the rest of the options are in the DOM but have no labels
[21:52:18] 	 mooeypoo: We should do the "make default size" button in the same change, and have that over-ride the error state.
[21:52:27] 	 mooeypoo: If that means we have to wait for the re-write, so be it.
[21:52:30] * mooeypoo  nods
[21:53:03] 	 I'll see if I can whips osmething up without the change, but if it means starting to change a bunch of stuff in the media node and scalable and UI, it might be a better idea to wait.
[21:56:03] * James_F  nods.
[21:58:09] * rdwrer  looks around for TrevorParscal, wizard of oojs-ui
[21:58:38] 	 ??
[21:58:51] 	 good thing I'm stalking the word "wizard"
[21:58:59] * James_F  laughs.
[21:59:03] 	 rdwrer: what's crackin?
[21:59:38] 	 TrevorParscal: Backscroll, but generally, https://dpaste.de/7NyM produces a menu with only "small" in it, at the top, and the rest of the options blank
[21:59:41] 	 Not sure why
[21:59:47] 	 and, how might one pronounce "rdwrer"?
[21:59:57] 	 Road Warrior, or MarkTraceur, either way. :)
[22:01:41] 	 assert( rdwrer, Road Warior )
[22:01:42] 	 nice
[22:01:47] 	 so, looking at code
[22:02:40] 	 could you try concatenating the labels with '!!" or something?
[22:02:48] 	 to make sure it's not just a message key mistake
[22:02:53] 	 or something to do with mw.message
[22:03:24] 	 Sure
[22:03:38] 	 if you get a bunch of !! labels and the last one is small!! then it's probably not oo-ui messing with you
[22:05:57] 	 TrevorParscal: No, just get the small one still, but it's of course the message key in brackets
[22:06:23] 	 But maybe I misunderstood your point - I put !! in just before the message key string, inside the quotes
[22:06:35] 	 label: mw.message( '!!multimediaviewer-small-embed-size', 0, 0 ).text()
[22:08:11] 	 It seems weird that the last one is the one that shows up
[22:08:22] 	 And that it shows up at the top
[22:11:57] 	 I assume I'm not totally cocking up the menu/factory thing by using barebones instantiations
[22:12:19] 	 (03CR) 10Esanders: "Ignore jenkins, this is ready for review." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 (owner: 10Esanders)
[22:13:09] 	 (03PS3) 10Esanders: Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 
[22:13:25] 	 edsanders: Rebase button is quicker to press and will actually get RoanKattouw_away to look at it. :-)
[22:13:34] * mooeypoo  runs off to class
[22:13:36] 	 cya guys later
[22:13:48] 	 James_F, but then it gets out of sync with my local branches
[22:18:11] 	 edsanders: So rebase locally and push?
[22:18:25] 	 edsanders: Also, you should always expect to pull from gerrit before doing changes anyway.
[22:18:33] 	 TrevorParscal: If you'd prefer, I can hack on something else and come back to this patch, we can talk about it later
[22:19:23] 	 you are on master for sure?
[22:19:36] 	 I'm on...let me pull MW
[22:19:37] 	 i will be in tomorrow, will be happy to help you debug in person
[22:19:43] 	 but, check it's the latest
[22:19:49] 	 because we made changes to labels recently
[22:20:05] 	 Trying
[22:20:19] 	 Ooh, errors, cool beans
[22:20:26] 	 InputLabelWidget is not a constructor fuuuun
[22:21:15] 	 I assume it moved to LabelWidget
[22:21:55] 	 Fixed the error, still have only "Small - $1x$2px
[22:21:57] 	 "
[22:22:28] 	 Also apparently that is an issue with mw.message, but not sure what sort of issue, and it doesn't appear to be the cause of the grander problem
[22:45:41] 	 rdwrer: why not just use mw.msg( 'key', arg, arg ) ?
[22:45:51] 	 you have a very simple case here
[22:45:58] 	 My brain is still under the impression that that's deprecated
[22:46:04] 	 mw.message() is a more complex (and probably buggy) appraoch
[22:46:06] 	 There was some backtracking about that some time agoe
[22:46:07] 	 ago*
[22:46:11] 	 hmm
[22:46:14] 	 So I should probably "just" do that
[22:53:26] 	 (03PS1) 10Trevor Parscal: [WIP] Convert styles to LESS format [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 
[22:53:28] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert styles to LESS format [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal)
[23:20:53] 	 (03PS2) 10Trevor Parscal: [WIP] Refactor dialog and window sets [oojs/ui] - 10https://gerrit.wikimedia.org/r/112132 (owner: 10Krinkle)
[23:21:01] 	 (03PS10) 10Trevor Parscal: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 (owner: 10Krinkle)
[23:25:16] 	 (03PS2) 10Trevor Parscal: [WIP] Convert styles to LESS format [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 
[23:25:34] 	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert styles to LESS format [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal)
[23:27:38] 	 (03CR) 10Trevor Parscal: [WIP] Centralize image handling into a stand-alone model (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal)