[00:00:19] Which ... [00:00:21] *sigh* [00:00:31] It's not clear to me how this will always produce correct results [00:00:36] This whole function is horrible [00:01:02] For now I think it's fine if we have correct behavior for places where the cursor can reasonably be [00:01:12] Until such time as we burn this thing to the ground and start over [00:03:14] (03CR) 10Catrope: [C: 032] Make the #REDIRECT field an MWTitleInputWidget rather than just plain [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114245 (owner: 10Jforrester) [00:04:29] (03Merged) 10jenkins-bot: Make the #REDIRECT field an MWTitleInputWidget rather than just plain [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114245 (owner: 10Jforrester) [00:05:17] (03PS7) 10Catrope: Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal) [00:06:31] RoanKattouw, so that has problems if you place the cursor after the final

[00:06:44] (03CR) 10Catrope: Prevent clicks on top-most shield for centered image nodes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal) [00:06:53] (03PS8) 10Catrope: Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal) [00:07:04] in that it detects p as a model node, and gives you it's start offset [00:07:27] Well when we descend into the last node, surely the direction should flip to -1? [00:07:47] there is no descending, it just sees a model node and stops [00:07:55] Hah [00:07:57] But [00:08:07] If domOffset===last, then surely we should be returning offset+length [00:08:18] (03CR) 10Catrope: [C: 032] Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal) [00:08:33] yes [00:08:51] need to move setting of direction higher up [00:09:32] (03Merged) 10jenkins-bot: Prevent clicks on top-most shield for centered image nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113258 (owner: 10Trevor Parscal) [00:12:39] (03PS1) 10Catrope: Move some non-skin-specific styles back into ve.ce.Node.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114371 [00:12:48] (03CR) 10jenkins-bot: [V: 04-1] Move some non-skin-specific styles back into ve.ce.Node.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114371 (owner: 10Catrope) [00:12:50] (03PS2) 10Catrope: Move some non-skin-specific styles back into ve.ce.Node.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114371 [00:13:37] I think we need: [00:13:37] if ( domOffset === 0 ) { [00:13:38] return nodeModel.getOffset() + ( nodeModel.isWrapped() ? 1 : 0 ); [00:13:38] } else { [00:13:38] return nodeModel.getOffset() + nodeModel.getOuterLength() - ( nodeModel.isWrapped() ? 1 : 0 ); [00:13:38] } [00:13:42] kaldari: Could you look at https://gerrit.wikimedia.org/r/#/c/114371/2 ? When I merged your image CSS separation change I wasn't paying enough attention, so I didn't notice you were moving very elementary things like "right-aligned images get float:right;" into skin-specific CSS [00:14:06] (subtract isWrapped?1:0 ) [00:14:48] That seems reasonable [00:14:58] so the only minor problem with this is
,1 returns the offset after the internalList [00:15:23] Well that's not entirely wrong I suppose [00:15:35] Although it's not necessarily exactly what we want [00:16:51] (03CR) 10Kaldari: [C: 032] Move some non-skin-specific styles back into ve.ce.Node.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114371 (owner: 10Catrope) [00:16:57] can the cursor even get there? [00:17:25] Hopefully not [00:17:31] So, what I want to do at some point [00:17:37] Maybe when you guys are all here next month [00:17:57] Is do a comprehensive rewrite of both the offset computation code that we're poking at now, AND the cursor position management code [00:18:04] (03Merged) 10jenkins-bot: Move some non-skin-specific styles back into ve.ce.Node.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114371 (owner: 10Catrope) [00:18:09] (i.e. the code that corrects illegal cursor positions as they happen) [00:18:37] They're intrinsically related but we've never really connected them very well [00:26:50] (03PS5) 10Esanders: Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 [00:27:40] RoanKattouw, so I'm not quite happy with 242/243 [00:28:49] What's on lines 242/243? [00:29:02] ^^^ [00:29:07] Oh, new patchset [00:29:09] Sweet [00:29:15] I think it's okay actually [00:29:22] Yeah it seems fine [00:29:28] domOffset -1 and go backwards [00:29:29] it just sets the default direction to move left [00:29:38] if you are in the middle of two siblings, right? [00:29:47] Yeah [00:30:04] In theory that should also have caught the case where you're at the very end, but I suppose it didn't [00:30:05] so Foo|Bar goes too Foo|, instead of |Bar [00:30:18] Now that that case is excluded we might be able to drop the -1 and go forwards? [00:30:34] does it matter which way you go? [00:30:44] If they're both annotations then no [00:30:53] Because in the linmod there's no difference between Foo| and |Bar [00:31:10] sure [00:31:28] but even for

|

[00:31:35] it's just a matter of preference? [00:32:14] Krinkle: Do you have a list of unfinished jsduck files? [00:32:15] I guess this affects whether

|

gets normalized to |

or

| ? [00:32:52] I think so [00:33:34] Right [00:33:46] Well, I don't care too much about that [00:34:08] edsanders: You've still got "searching" misspelled in the doc comment [00:34:13] ("serching") [00:36:02] (03PS6) 10Esanders: Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 [00:36:18] It seems like mostly they're done, except for ones that are like "run once and be inaccessible to other scripts" [00:36:28] Which isn't super useful to document anyway [00:36:56] RoanKattouw, I was thinking the problem with writing test cases here is that they take ages [00:37:22] we could do a smoke test by asserting that the offsets are always-increasing [00:37:41] then throw in a massive test document [00:38:08] (03CR) 10Catrope: [C: 032] "Meh, this function is horrible, and we should rewrite it (bug 61567) but this seems to work well enough." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 (owner: 10Esanders) [00:38:17] all the test failures so far have resulted in the cursor jumping backwards [00:38:24] Sounds good [00:39:08] (03Merged) 10jenkins-bot: Fix ce#getOffset when cursor is to the left of an annotation. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114000 (owner: 10Esanders) [00:40:52] (03CR) 10Catrope: [C: 04-1] "Clever way of tagging these edits :) . I think you picked the wrong target though, see inline comments." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113665 (owner: 10Alex Monk) [00:41:36] (03CR) 10Catrope: Track edits where user switched into wikitext editor from VE (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113665 (owner: 10Alex Monk) [00:42:05] (03CR) 10Catrope: [C: 032] Show placeholder text in group input box on reference list dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113684 (owner: 10Alex Monk) [00:43:58] (03Merged) 10jenkins-bot: Show placeholder text in group input box on reference list dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113684 (owner: 10Alex Monk) [00:50:05] (03PS5) 10Krinkle: [WIP] Convert styles to LESS and implement grunt task [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [00:50:41] (03CR) 10Krinkle: "* Moved module resource expansion to a utility method shared between recess config and js-concat build task." [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [00:51:16] (03CR) 10Krinkle: "OK. Grunt build stuff is done and working. Not ideal but might be pretty enough. Review :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [00:53:44] RoanKattouw, James_F|Away What are we doing for Zurich? [00:54:06] No idea [00:56:32] edsanders: RoanKattouw: For presentation? [00:56:55] I mean the hotel/hostel survey [00:57:19] I filled in mine a few minutes ago. [00:58:32] Arriving 8th and departing 12th (the first one about registration gives a choice for dates, the day itself or day before/after), the second for wmf doesn't have that choice. And since it starts early on friday and ends at 5-6pm on the third day, checking in the night beofre until the morning after makes sense. [01:00:42] Yeah I did 8th-12th too [01:00:58] More of a no-brainer for me given how far away I am :) [01:02:07] Accommodation itself, I went with hotel myself. And for motivation/expertise I re-used our hong kong/amsterdam snippet mostly with changes and extra little about platform stuff. [01:03:23] I actually got that snippet via edsanders from the VE (WMF) hangout backscroll. [01:06:24] (03CR) 10Catrope: [C: 04-1] Mark hidden categories as different in the meta-data dialog (0315 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk) [01:25:18] (03CR) 10Jforrester: "Later filed as bug 61571." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113477 (owner: 10Catrope) [01:34:58] (03PS1) 10Catrope: Deal with ./ prefixes etc. in MWRedirectMetaItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114381 [01:35:01] (03PS1) 10Jforrester: Add placeholder to 'group' field in reference dialog too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114382 [01:36:03] (03CR) 10Jforrester: [C: 032] Deal with ./ prefixes etc. in MWRedirectMetaItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114381 (owner: 10Catrope) [01:37:10] (03CR) 10Catrope: "Tech debt bug https://bugzilla.wikimedia.org/show_bug.cgi?id=61572" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114381 (owner: 10Catrope) [01:37:32] (03CR) 10Catrope: [C: 032] Add placeholder to 'group' field in reference dialog too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114382 (owner: 10Jforrester) [01:38:25] (03Merged) 10jenkins-bot: Deal with ./ prefixes etc. in MWRedirectMetaItem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114381 (owner: 10Catrope) [01:39:34] (03Merged) 10jenkins-bot: Add placeholder to 'group' field in reference dialog too [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114382 (owner: 10Jforrester) [01:47:43] (03CR) 10Catrope: [C: 032] Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester) [01:48:10] (03PS20) 10Catrope: Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester) [01:48:22] (03CR) 10Catrope: [C: 032] Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester) [01:50:31] (03Merged) 10jenkins-bot: Let users set __NOINDEX__ & __INDEX__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95724 (owner: 10Jforrester) [01:50:39] (03PS16) 10Catrope: Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 (owner: 10Jforrester) [02:25:08] (03CR) 10Jforrester: [WIP] Convert styles to LESS and implement grunt task (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [02:25:48] Krinkle: Is https://gerrit.wikimedia.org/r/#/c/109006/11 only a WIP because of "(FIXME: Actually create demo/layouts.html)"? [02:26:07] James_F: https://gerrit.wikimedia.org/r/#/c/112132/3 is ready for merge [02:26:17] The demos WIP is far from ready. [02:26:33] Krinkle: Yeah, Trevor will look at it tomorrow morning I think. [02:26:53] Krinkle: https://gerrit.wikimedia.org/r/#/c/114093/ depends on the demos WIP, though. :-( [02:27:10] Krinkle: (I assume it's a fake dependency?) [02:27:20] the demos WIP right now (since I split the dialog refactor out of it) is only a small wrapper for what will be a demo. That took the most work, but it's not useful to merge with nothing in it. [02:27:34] James_F: I dont know why Trevor made it dependent on that, shouldn't be. [02:27:53] We can untangle that in the next patch set [02:28:23] Krinkle: Sure. [02:28:29] Krinkle: Understood. [02:28:53] Krinkle: I can rebase it if needed. Can you confirm if my query on "which bit of this is WIP?" is right? [02:29:58] (03CR) 10Jforrester: [C: 031] "LGTM." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 (owner: 10Jforrester) [02:31:50] (03PS1) 10Jforrester: Update VE core submodule to master (767f6b2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114393 [02:33:02] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (767f6b2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114393 (owner: 10Jforrester) [02:33:30] (03CR) 10Krinkle: [WIP] Convert styles to LESS and implement grunt task (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [02:35:49] (03CR) 10Krinkle: "fixme: comment syntax" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [02:36:30] Krinkle: Want me to do that? [02:36:44] already on it [02:36:50] OK. :-) [02:37:01] this is slightly ugly though, as css has no nice way of doing multu-line inline comments [02:38:24] (03PS1) 10Krinkle: Dialog: Fix inline comment to use /* instead of /**. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114394 [02:38:40] (03CR) 10Jforrester: [C: 032] Dialog: Fix inline comment to use /* instead of /**. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114394 (owner: 10Krinkle) [02:39:03] (03CR) 10Krinkle: "Fixed in If40dbbaa02a30cbf." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [02:39:44] (03Merged) 10jenkins-bot: Dialog: Fix inline comment to use /* instead of /**. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114394 (owner: 10Krinkle) [02:39:53] (03CR) 10Krinkle: "(See build failure in patch set 1 of I78a3d992660040281)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109483 (owner: 10Esanders) [02:40:07] James_F: Wanna update the update? [02:40:19] Krinkle: Sure, one moment, fixing other things. [02:43:25] (03CR) 10jenkins-bot: [V: 04-1] Simplify new INDEX/NOINDEX language, order and panel order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114395 (owner: 10Jforrester) [02:43:40] (03PS2) 10Jforrester: Update VE core submodule to master (b6b80c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114393 [02:44:02] Krinkle: +2 https://gerrit.wikimedia.org/r/#/c/114393/ for me? [02:44:10] (03PS2) 10Jforrester: Simplify new INDEX/NOINDEX language, order and panel order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114395 [02:44:16] Krinkle: And https://gerrit.wikimedia.org/r/#/c/114395/ ? :-) [02:46:30] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (b6b80c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114393 (owner: 10Jforrester) [02:47:33] (03CR) 10Catrope: [C: 032] Simplify new INDEX/NOINDEX language, order and panel order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114395 (owner: 10Jforrester) [02:47:44] (03Merged) 10jenkins-bot: Update VE core submodule to master (b6b80c2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114393 (owner: 10Jforrester) [02:48:44] RoanKattouw_away: James_F|Away: Hm.. the { ? ] and { = } buttons are weird [02:48:52] (03Merged) 10jenkins-bot: Simplify new INDEX/NOINDEX language, order and panel order [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114395 (owner: 10Jforrester) [02:48:56] one ends in a straight edge as for in a group with at least one other button [02:49:04] and then the hamburger menu is its own rounded group [02:49:08] with margin in between [02:52:24] https://bugzilla.wikimedia.org/show_bug.cgi?id=61575 http://bug-attachment.wikimedia.org/attachment.cgi?id=14633 [02:57:55] RoanKattouw_away: Hm.. I was reviewing that page options change. That thing seems fatally broken https://bugzilla.wikimedia.org/show_bug.cgi?id=61576 - it worked for you (with or without that change, merging a change to something broken seems odd as it can't be verified) [02:58:04] ? [03:04:51] Krinkle: Looking [03:05:06] Ahm, wat? [03:05:10] How is OO.ui.FieldLayout undefined? [03:05:12] Did you update core? [03:05:47] Trying to reproduce now [03:06:02] I did [03:06:03] Ooooh I see [03:06:13] That's brand new (2 days ago) oojs-ui wasn't updated yet in ve [03:06:14] FieldLayout isn't in core, it seems [03:06:23] Whether it's updated in VE doesn't matter [03:06:25] someone started using it already, somehow? [03:06:26] Whether it's updated in core matters [03:06:33] define core [03:06:36] MW core [03:06:37] oh, right [03:06:38] Sorry [03:06:58] OK yeah so the TOC option stuff uses it, that's annoying [03:06:59] OOjs UI doesn't belong in core imho [03:07:18] I do have to admit that with how much it's still changing, it's annoying to have it in core [03:07:24] it changes way too often still. We can't expect anyone to use it like this. We rename a class or refactor things once a week. [03:07:24] But other people want to use it too [03:07:49] Well, maybe we shouldn't break b/c so much any more [03:08:14] It's not hugely difficult to do multi-stage changes that end up removing things while keeping b/c in every individual step [03:08:29] Indeed [03:08:50] having tests / demos would make that a lot easier [03:09:16] Well, there's lots of FieldLayout stuff everywhere in ve-mw right now [03:09:21] if not, enable it. I mean, there is no way to know whether something is broken realistically. Too many calls from one class to another. [03:09:27] Right [03:09:37] So I suppose we'll just have to update OOUI in core then [03:10:18] Hmm, wait [03:10:29] !g [03:10:33] !g 2b28b46a9ca3db60b70240cb7817e8fc8e4426c9 [03:10:42] Come on bot [03:10:44] !gerrit 2b28b46a9ca3db60b70240cb7817e8fc8e4426c9 [03:10:46] !change 2b28b46a9ca3db60b70240cb7817e8fc8e4426c9 [03:10:55] https://gerrit.wikimedia.org/r/#/c/113508/ [03:11:04] We have FieldLayout in core apparently [03:11:08] Since last week [03:12:11] Krinkle: OK so I officially cannot reproduce this [03:12:20] Updated MW core works fine [03:12:21] Yeah, I just updated mw-core again and it works now [03:12:49] was using latest master as detached origin/master, and switched to master before I tested this [03:12:58] which odly enough moved me away from latest master, not to it :) [03:20:22] (03PS17) 10Catrope: Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 (owner: 10Jforrester) [03:21:58] (03PS18) 10Catrope: Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 (owner: 10Jforrester) [03:22:19] (03CR) 10Catrope: [C: 032] Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 (owner: 10Jforrester) [03:23:34] (03Merged) 10jenkins-bot: Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95725 (owner: 10Jforrester) [03:33:12] (03PS1) 10Catrope: Convert the Advanced Settings pane to FieldLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114405 [03:33:25] Krinkle: ---^^ makes Advanced Settings look less horrible both visually and in terms of code [03:37:06] Would be nice to get that in before the cut [03:37:48] (03PS6) 10Esanders: Allow editing of attributes of MW extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/99655 [03:42:43] RoanKattouw: Hm.. where did "Show a tab on this page to add a new section" come from? [03:42:48] Oh, it has the dependency [03:42:54] or rather, merged [03:43:32] holy fucking mess. It's all inline before that [03:43:54] (03PS1) 10Catrope: Remove .static.title from ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114406 [03:43:59] http://i.imgur.com/dllooe5.png [03:44:36] That can't just be a layout problem. That second one shouldn've been added like that in the first place. Oh well in-master fluctuation no-one will see (layout should've gone in first..) [03:45:13] (03PS1) 10Catrope: Give MWAlienExtensionInspector its title back [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114407 [03:45:26] Krinkle: Yeah, sorry about that [03:45:40] We could put in some
s to remedy that, or add CSS to make the labels display:block; [03:45:42] Or just convert it to FieldLayout :) [03:45:53] (03CR) 10Catrope: [C: 032] Allow editing of attributes of MW extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/99655 (owner: 10Esanders) [03:46:13] Also, those last two commits I pushed are trivial, and https://gerrit.wikimedia.org/r/114407 in particular would be nice to merge before tomorrow [03:46:22] isn't a nice title [03:48:31] (03Merged) 10jenkins-bot: Allow editing of attributes of MW extensions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/99655 (owner: 10Esanders) [03:50:02] (03CR) 10Krinkle: [C: 032] Convert the Advanced Settings pane to FieldLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114405 (owner: 10Catrope) [03:50:06] (03PS2) 10Krinkle: ve.ui.MWAdvancedSettingsPage: Convert page to use FieldLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114405 (owner: 10Catrope) [03:50:10] (03CR) 10Krinkle: [C: 032] ve.ui.MWAdvancedSettingsPage: Convert page to use FieldLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114405 (owner: 10Catrope) [03:51:14] I find it somewhat arbitrary that each label/control group has to be its own FieldLayout. I'm assuming that is required, and just another reason for why we need visual rendering examples of what each layout is and how it can be used. [03:51:33] I've lost track of all base oo ui dialog and layout classes, the names mean nothing to me anymore. [03:51:38] I coulnd't use a single one of them. [03:51:57] not one [03:52:04] There's a FieldsetLayout that groups the FieldLayouts if that's what you're concerned with [03:52:29] A FieldLayout is centered around a field, which is a widget, usually an InputWidget [03:52:42] Does that make sense? [03:52:46] The names and descriptions do a minimal job of communicating what it can do function wise, but that's it. I wouldn't know what methods to call, and how flexible it is, or what it'll look like. [03:52:47] (03Merged) 10jenkins-bot: ve.ui.MWAdvancedSettingsPage: Convert page to use FieldLayout [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114405 (owner: 10Catrope) [03:52:51] Obviously we need much, much better docs for all the different OOUI classes [03:52:55] I mean for all layouts in general. [03:53:07] Explaining what they are and how they are different from their sibling classes [03:53:32] Re demos [03:53:37] The demo already uses FieldLayout extensively :) [03:53:45] The demo itself is laid out using FieldLayouts [03:53:55] Although to be fair, it should show off the different label alignments you cna use [03:54:08] that's what my WIP is for [03:54:12] Oh nice [03:54:15] demo/layouts and demo/dialogs [03:55:02] but before I could do that, I had to refactor dialogs with Trevor because I deemed them unusable from an API point of view when used outside context of VE where instantiation complexity doesn't matter because it is abstracted behind 5 layers there anyway. [03:55:11] Right [03:55:33] Ahm https://gerrit.wikimedia.org/r/#/c/109006/ doesn't have layout demos? [03:55:37] Which is this one: https://gerrit.wikimedia.org/r/#/c/112132/ [03:55:49] Yeah just looking at that now [03:56:13] https://gerrit.wikimedia.org/r/#/c/109006/ currently is a WIP that lays the ground to actually set up layouts and dialogs from an object literal descriptor (like in buttons demos) [03:56:25] once that is ready, it's just a matter of populating it with a bunch [03:57:07] I want to do demos/layouts first, but we currently don't use them outside dialogs I think, and there's some issues with that [03:57:53] Layouts don't require dialogs to work correctly, do they? [03:57:59] Although it's true we only use them in dialogs right now [03:58:22] (03PS6) 10Krinkle: [WIP] Convert styles to LESS and implement grunt task [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [03:58:54] (03CR) 10Krinkle: "Plucked I171874d50 (Add dialogs demo) out of the dependency stack." [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [04:04:15] (03CR) 10Catrope: [C: 04-1] "Looks good overall, minor comments inline" (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/112132 (owner: 10Krinkle) [04:17:04] (03PS4) 10Krinkle: Refactor dialog and window sets [oojs/ui] - 10https://gerrit.wikimedia.org/r/112132 [04:17:25] (03CR) 10Krinkle: "Addressed in next patch set." (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/112132 (owner: 10Krinkle) [04:43:09] Krinkle|detached: Could you merge https://gerrit.wikimedia.org/r/114407 real quick? [04:54:15] RoanKattouw: The default message doesn't exist? [04:54:17] wh? [04:57:01] (03CR) 10Krinkle: [C: 032] Remove .static.title from ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114406 (owner: 10Catrope) [04:57:39] (03CR) 10Krinkle: [C: 032] "Verified using " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114407 (owner: 10Catrope) [04:58:03] (03Merged) 10jenkins-bot: Remove .static.title from ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114406 (owner: 10Catrope) [04:58:55] (03Merged) 10jenkins-bot: Give MWAlienExtensionInspector its title back [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114407 (owner: 10Catrope) [05:18:39] (03PS1) 10Mooeypoo: [wip] Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 [05:19:54] (03CR) 10jenkins-bot: [V: 04-1] [wip] Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [05:20:17] O.O [05:20:22] What just happened [05:20:42] RoanKattouw, since you seem to be around, do you have any idea what this is about? https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/8020/console [05:23:24] Holy crap [05:23:28] That looks like a bug [05:23:36] Wait, no it's not a bug [05:23:41] The MWDeprecationWarnings are just noise [05:24:01] Going to look at the 12 MB of full logs [05:24:25] 05:19:21 ve.dm.MWConverter - getDomFromModel...ERROR [05:24:27] 05:19:21 >> Message: undefined (data hasn't changed) [05:24:38] I see [05:24:54] mooeypoo: There are tests asserting that running the converter (toDomElements in particular) doesn't change the linear model data [05:25:16] Your implementation of toDomElements appears to somehow modify dataElement.attributes by reference to add defaultSize=false if it's not present [05:25:56] ...which is blindingly obvious on lines 185 and 187 [05:26:34] So, yeah, for future reference: modifying dataElement from within a toDomElements function is not allowed [05:27:09] Krinkle|detached: Is there something you/we could do to not make Jenkins's qunit job generate 12 MB of MWDeprecationWarning noise? https://integration.wikimedia.org/ci/job/mwext-VisualEditor-qunit/8020/console [06:39:18] RoanKattouw_away: When did that start? [06:39:19] wtf [06:39:38] Oh, argh [06:39:45] test.mediawiki.qunit.testrunner [06:39:48] well, no, not test.mediawiki.qunit.testrunner [06:39:54] QUnit global preservation [06:40:01] detection of globals [06:40:11] it iterates over window to find keys and see if there are new ones [06:40:32] It doesn't access the value but it's enough to trigger the ES5 getter, and thus trigger that [06:43:04] Can you file a bug? Currently trying to unbreak mediawiki-core jenkins but for some reason I can't push fixes. Jenkins is being unsure of itself. I'm giving it the very auth tokens it gives me in the UI but rejecting to authenticate.. [07:33:11] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/114427/ [09:52:46] (03PS3) 10Esanders: Ensure VE init runs after mw.util.init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113544 [14:30:22] (03PS1) 10Hashar: json syntax error with escaped single quotes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114464 [15:17:34] (03CR) 10Jforrester: [C: 032] json syntax error with escaped single quotes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114464 (owner: 10Hashar) [15:18:50] (03Merged) 10jenkins-bot: json syntax error with escaped single quotes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114464 (owner: 10Hashar) [15:20:21] (03CR) 10Alex Monk: Track edits where user switched into wikitext editor from VE (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113665 (owner: 10Alex Monk) [15:20:58] (03PS1) 10Esanders: Resize handle images [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114475 [15:30:47] (03PS5) 10Alex Monk: Track edits where user switched into wikitext editor from VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113665 [15:39:01] (03CR) 10Alex Monk: [C: 032] Clean up onResourceLoaderRegisterModules() to make it more data-driven [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113473 (owner: 10Catrope) [15:40:09] (03Merged) 10jenkins-bot: Clean up onResourceLoaderRegisterModules() to make it more data-driven [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113473 (owner: 10Catrope) [16:26:26] (03PS1) 10Esanders: Allow annotations to remove other annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114488 [16:30:59] (03PS2) 10Esanders: Allow annotations to remove other annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114488 [16:31:51] (03CR) 10Esanders: "Are the 'set' and 'clear' methods ever used?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114488 (owner: 10Esanders) [16:33:03] (03CR) 10Cmcmahon: [C: 032] [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [16:38:56] (03CR) 10jenkins-bot: [V: 04-1] [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [16:40:45] (03PS6) 10Jhall: [Browser test] WIP New test for VE Page Settings menu. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110659 [16:44:19] (03PS17) 10Jhall: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 [16:44:51] Heya. [16:47:29] (03CR) 10Cmcmahon: [C: 032] [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [16:49:21] (03Merged) 10jenkins-bot: [Browser test] Headless browser test(s) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/111890 (owner: 10Jhall) [16:51:57] Hey mooeypoo. [17:01:28] heyhey [17:02:04] Internet at campus is really meh. [17:02:12] :-( [17:07:45] It's a little funny, considering I'm right under the computer science department... [17:09:02] anyways, James_F just FYI https://gerrit.wikimedia.org/r/#/c/114420/ <-- I am still working on a couple of details but i think the direction should work. It won't take into account *user* preferences, though. Only wiki preferences. [17:13:35] bbiab, moving to another hall [17:16:47] unimoo: Great. :-) [17:54:09] (03PS6) 10Robmoen: WIP: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 [17:55:24] mediawiki.org keeps throwing bad error messages at me :( [17:55:29] (03CR) 10jenkins-bot: [V: 04-1] WIP: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [18:50:04] mooeypoo: ping [19:02:35] (03PS11) 10Alex Monk: Mark hidden categories as different in the meta-data dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 [19:03:19] (03CR) 10Alex Monk: "Got halfway through fixing these and realised the parent commit was broken (probably compatibility with my version of MW core or something" (038 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk) [19:03:29] gwicke: I think mooeypoo is at college right now. [19:04:53] I see, thanks [19:05:06] (03PS12) 10Alex Monk: Mark hidden categories as different in the meta-data dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 [19:18:14] (03PS1) 10Jforrester: Fix broken JSON in modules/syntaxhighlight/rules/mysql.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114518 [19:34:04] James_F: Hallo. https://www.mediawiki.org/wiki/Google_Summer_of_Code_2014#Automatic_cross-language_screenshots_for_user_documentation is pretty neat. [19:34:12] Did you add it? When? [19:34:32] I wrote about something very similar on the QA list and Andre replied with this link :) [19:35:24] aharoni: I did, a few month or so aog. [19:35:48] aharoni: It came up as part of the discussions about making the VE user guide easy to translate but at the same time actually useful. [19:40:20] James_F: I didn't bother to look at the current GSoC proposals before writing that email. I really, really, really love it, and hope that it gets accepted. [19:41:52] (03CR) 10Krinkle: [C: 032] Fix broken JSON in modules/syntaxhighlight/rules/mysql.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114518 (owner: 10Jforrester) [19:42:23] aharoni: So do I. :-) [19:42:45] Krinkle: But really we should port all that code over to the SyntaxHighlight_GeSHi repo so that it's in the "right" place. [19:43:01] (03Merged) 10jenkins-bot: Fix broken JSON in modules/syntaxhighlight/rules/mysql.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114518 (owner: 10Jforrester) [19:43:09] Krinkle: That way we don't have merged-but-not-used code sitting in a repo. [19:43:12] * Krinkle mumbles something about time and space. [19:43:18] Krinkle: Should I do it? [19:43:32] * James_F hugs the ever-wonderful Krinkle. [19:53:32] James_F: Sounds good. Would that be the first ve-plugin from an mw extension? [19:56:08] Oh, Krinkle, I poked you yesterday about what is unfinished in core jsduck world [19:56:20] (03PS1) 10Trevor Parscal: Add autosize option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114522 [19:59:16] (03PS2) 10Trevor Parscal: Add autosize option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114522 [20:00:04] (03PS1) 10Jforrester: Remove SyntaxHighlight code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114523 [20:00:18] Krinkle: Second; is already done, though not yet merged. [20:00:26] Krinkle: ^^^ Feel free to merge. :-) [20:02:41] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (93f94e059f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114525 [20:08:04] (03PS2) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (93f94e059f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114525 [20:08:34] (03PS1) 10Trevor Parscal: Make template parameter value inputs autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114527 [20:09:03] (03CR) 10jenkins-bot: [V: 04-1] Make template parameter value inputs autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114527 (owner: 10Trevor Parscal) [20:11:32] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=61289 [20:13:00] (03PS2) 10Trevor Parscal: Make template parameter value inputs autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114527 [20:13:27] (03CR) 10jenkins-bot: [V: 04-1] Make template parameter value inputs autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114527 (owner: 10Trevor Parscal) [20:39:28] (03PS3) 10Catrope: Add autosize option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114522 (owner: 10Trevor Parscal) [20:40:16] (03PS13) 10Alex Monk: Mark hidden categories as different in the meta-data dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 [20:40:18] (03CR) 10Alex Monk: Mark hidden categories as different in the meta-data dialog (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk) [20:40:49] RoanKattouw, I think I've cleaned up most of that train wreck of a commit [20:40:54] Awesome [20:40:57] still some room for improvement [20:41:30] (03CR) 10jenkins-bot: [V: 04-1] Mark hidden categories as different in the meta-data dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk) [20:41:38] or not [20:41:39] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/114523/ is probably the easiest +2 you'll ever do. :-) [20:41:46] Krenair: :-( [20:41:53] Bet I left a var lying around >_> [20:42:17] id is defined but never used. sigh [20:42:18] (03CR) 10Catrope: [C: 04-1] Add autosize option to OO.ui.TextInputWidget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/114522 (owner: 10Trevor Parscal) [20:42:21] VE do rather enforce things, don't we? :-) [20:43:09] Krenair: I probably won't get around to reviewing it until tomorrow [20:43:16] that's fine [20:48:58] (03PS1) 10Esanders: Add #compareTo to ve.dm.Annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114534 [20:49:00] (03PS1) 10Esanders: LanguageInputWidget rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114535 [20:49:05] (03PS1) 10Esanders: Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 [20:49:48] (03CR) 10jenkins-bot: [V: 04-1] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [20:56:33] (03PS14) 10Alex Monk: Mark hidden categories as different in the meta-data dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 [21:08:33] (03CR) 10Alex Monk: Mark hidden categories as different in the meta-data dialog (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk) [21:14:21] (03PS4) 10Trevor Parscal: Add autosize option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114522 [21:15:50] TrevorParscal: if you have a moment, would you mind taking a look at https://gerrit.wikimedia.org/r/#/c/108945/ and tell me what i'm doing wrong please :) I'm having a terrible that i've been stuck on for a while. I'm happy to walk you through the code and happy to receive any feedback on my approach ( maybe there is an easier way ). Anyway, mucho appreciated [21:16:11] (03PS1) 10Krinkle: Ensure we use our references to certain native or upstream methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114618 [21:17:05] (03PS2) 10Krinkle: Ensure we use our references to certain native or upstream methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114618 [21:21:48] rmoen: I'd be happy to do a debugging/troubleshooting session with you too but I have classes today, so that would have to be tomorrow [21:21:56] Or any day that's not a Tuesday or Thursday, more generally [21:23:30] (03CR) 10Catrope: [C: 032] Ensure we use our references to certain native or upstream methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114618 (owner: 10Krinkle) [21:24:31] (03Merged) 10jenkins-bot: Ensure we use our references to certain native or upstream methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114618 (owner: 10Krinkle) [21:25:02] (03CR) 10Krinkle: "fixme: Please follow-up with using QUnit.newMwEnvironment#setup and let the central system do the restore instead of remembering to do it " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/107539 (owner: 10Catrope) [21:28:28] (03CR) 10Catrope: "Adding Ed because despite what Gerrit claims, he wrote this code." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/107539 (owner: 10Catrope) [21:32:46] (03PS1) 10Krinkle: Ensure we use our references to certain native or upstream methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114620 [21:32:47] (03PS5) 10Trevor Parscal: Add autosize option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114522 [21:32:47] (03PS6) 10Trevor Parscal: Add autosize option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114522 [21:32:55] (03PS3) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (93f94e059f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114525 [21:33:17] (03PS4) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (93f94e059f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114525 [21:33:53] (03PS3) 10Trevor Parscal: Make template parameter value inputs autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114527 [21:34:22] (03CR) 10jenkins-bot: [V: 04-1] Make template parameter value inputs autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114527 (owner: 10Trevor Parscal) [21:35:00] (03CR) 10Trevor Parscal: [C: 032] Remove SyntaxHighlight code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114523 (owner: 10Jforrester) [21:35:28] edsanders: Bascially, in the relevant test suite, use "QUnit.module( name, QUnit.newMwEnvironment() )" on top instead of "QUnit.module( name )". Then just pass anything to mw.config.set and it'll be restored automatically. Refer to core unit tests for examples. [21:35:31] (03CR) 10Trevor Parscal: [C: 032] Revert "Set href attribute of newly inserted image to image title" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114352 (owner: 10Jforrester) [21:35:49] (03CR) 10Trevor Parscal: [C: 032] Split VE-MW's ve.ce.Node.css file into per-node files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113487 (owner: 10Jforrester) [21:35:56] (call mw.config within a QUnit.test) [21:35:59] (03PS2) 10Jforrester: Split up ext.visualEditor.mwcore into smaller parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 [21:36:08] (03CR) 10jenkins-bot: [V: 04-1] Split up ext.visualEditor.mwcore into smaller parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [21:36:11] (03Merged) 10jenkins-bot: Remove SyntaxHighlight code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114523 (owner: 10Jforrester) [21:36:12] RoanKattouw_away: thx, https://gerrit.wikimedia.org/r/#/c/114620/ as well? [21:37:16] (03Merged) 10jenkins-bot: Revert "Set href attribute of newly inserted image to image title" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114352 (owner: 10Jforrester) [21:37:20] (03CR) 10jenkins-bot: [V: 04-1] Split VE-MW's ve.ce.Node.css file into per-node files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113487 (owner: 10Jforrester) [21:37:45] (03CR) 10Krinkle: Split up ext.visualEditor.mwcore into smaller parts (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [21:38:27] (03CR) 10Krinkle: Implement 'change' events in templates models (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/100416 (owner: 10Trevor Parscal) [21:38:52] (03CR) 10Trevor Parscal: [C: 04-1] "The context menu doesn't come up for references, links or transclusions. Not sure why yet, but this isn't a problem in master." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [21:39:22] (03PS3) 10Trevor Parscal: Split up ext.visualEditor.mwcore into smaller parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [21:39:24] (03PS3) 10Divec: [WIP] Prepare-Observe-Fixup for keyboard events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105172 [21:39:31] (03CR) 10jenkins-bot: [V: 04-1] Split up ext.visualEditor.mwcore into smaller parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [21:40:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Prepare-Observe-Fixup for keyboard events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105172 (owner: 10Divec) [21:45:04] Krinkle, what's that about? [21:45:48] https://gerrit.wikimedia.org/r/107539 [21:45:53] (03PS3) 10Trevor Parscal: Split VE-MW's ve.ce.Node.css file into per-node files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113487 (owner: 10Jforrester) [21:46:01] (03CR) 10Trevor Parscal: [C: 032] Split VE-MW's ve.ce.Node.css file into per-node files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113487 (owner: 10Jforrester) [21:46:44] (03PS1) 10Krinkle: doc: Use lowercase types where primitives (not objects) are expected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114628 [21:48:01] (03CR) 10Krinkle: Add a getDirectionFromRange Method to ve.ce.Document (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/101125 (owner: 10Mooeypoo) [21:48:10] (03Merged) 10jenkins-bot: Split VE-MW's ve.ce.Node.css file into per-node files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113487 (owner: 10Jforrester) [21:48:22] I'm just looking through "Draft Comments" on Gerrit, places I started writing comments, but never submitted. [21:48:29] Gerrit's UI makes it quite easy to forget that. [21:49:45] (03CR) 10Trevor Parscal: "Please rebase and consider Timo's comment." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [21:51:53] (03PS5) 10Trevor Parscal: Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 (owner: 10Kaldari) [21:55:37] (03PS6) 10Trevor Parscal: Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 (owner: 10Kaldari) [21:55:46] (03CR) 10Trevor Parscal: [C: 032] Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 (owner: 10Kaldari) [21:58:04] (03Merged) 10jenkins-bot: Converting ViewPageTarget CSS files to LESS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114004 (owner: 10Kaldari) [22:00:28] (03CR) 10Trevor Parscal: [C: 032] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [22:00:28] (03CR) 10Trevor Parscal: [C: 032] LanguageInputWidget rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114535 (owner: 10Esanders) [22:00:45] (03CR) 10jenkins-bot: [V: 04-1] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [22:19:06] (03CR) 10Trevor Parscal: [C: 032] Add #compareTo to ve.dm.Annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114534 (owner: 10Esanders) [22:20:11] (03Merged) 10jenkins-bot: Add #compareTo to ve.dm.Annotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114534 (owner: 10Esanders) [22:20:13] (03Merged) 10jenkins-bot: LanguageInputWidget rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114535 (owner: 10Esanders) [22:32:31] (03CR) 10Trevor Parscal: [C: 032] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [22:33:41] (03CR) 10jenkins-bot: [V: 04-1] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [22:41:29] (03PS1) 10Trevor Parscal: Fix a missing { and remove some debugging CSS left in 4a067460 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 [22:42:31] (03PS2) 10Trevor Parscal: Fix a missing { and remove some debugging CSS left in 4a067460 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 [22:43:56] Krinkle: could you +2 this for me https://gerrit.wikimedia.org/r/#/c/114637/ [22:44:00] it's semi urgent [22:44:36] I +2'd a patch by Ryan, but when I tested it I must have been on the wrong branch and a couple things slipped past me [22:44:49] now it's causing a problem in beta labs [22:45:08] RoanKattouw: you could help if Krinkle isn't alive [22:45:23] checking [22:45:26] we need less linting in jenkins for VE [22:45:44] wait, why is there .less files in VE? [22:45:46] That's not cool. [22:45:53] it's not VE core [22:45:56] it's vemw [22:45:58] only for init [22:45:58] so? [22:46:03] Why? Since when? [22:46:28] (03PS3) 10Krinkle: Fix a missing { and remove some debugging CSS left in 4a067460 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:47:09] (03CR) 10Krinkle: "What does 4a067460 refer to?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:47:20] (03CR) 10Krinkle: "Ah, c6bcc10d6c6c79a9." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:47:26] (03PS4) 10Krinkle: Fix a missing { and remove some debugging CSS left in c6bcc10d6c6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:48:11] (03CR) 10Krinkle: "Neither commit relates to this files, so still unsure what this is referring to. Please amend with something that I can resolve." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:48:36] i'm back [22:48:49] sorry, ok, explain why we wouldn't want to use less in vemw? [22:51:16] (03CR) 10Kaldari: [C: 032] Fix a missing { and remove some debugging CSS left in c6bcc10d6c6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:53:49] (03CR) 10Krinkle: [C: 04-1] "(cancelled Kaldari's +2). As I pointed out, the commit message refers to an unrelated commit. Please fix." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:53:57] (03PS5) 10Trevor Parscal: Fix a missing { and remove some debugging CSS left in Ied29358 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 [22:55:51] (03PS1) 10Krinkle: Revert "Converting ViewPageTarget CSS files to LESS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114643 [22:56:31] (03Abandoned) 10Trevor Parscal: Fix a missing { and remove some debugging CSS left in Ied29358 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114637 (owner: 10Trevor Parscal) [22:57:10] (03CR) 10Trevor Parscal: [C: 032] "Premature mergification" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114643 (owner: 10Krinkle) [22:57:34] (03CR) 10Trevor Parscal: [C: 032] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [22:59:02] (03Merged) 10jenkins-bot: Revert "Converting ViewPageTarget CSS files to LESS" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114643 (owner: 10Krinkle) [23:00:03] (03CR) 10jenkins-bot: [V: 04-1] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:06:24] (03PS2) 10Trevor Parscal: Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:07:40] (03CR) 10jenkins-bot: [V: 04-1] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:11:54] (03PS1) 10Trevor Parscal: Fix documentation error in ve.ui.LanguageInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114649 [23:12:59] James_F: https://gerrit.wikimedia.org/r/#/c/114649/ [23:13:32] (03CR) 10Jforrester: [C: 032] Fix documentation error in ve.ui.LanguageInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114649 (owner: 10Trevor Parscal) [23:14:32] (03Merged) 10jenkins-bot: Fix documentation error in ve.ui.LanguageInputWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114649 (owner: 10Trevor Parscal) [23:14:43] (03CR) 10Trevor Parscal: [C: 032] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:15:53] (03CR) 10jenkins-bot: [V: 04-1] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:23:12] (03CR) 10Trevor Parscal: [C: 032] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:24:20] (03CR) 10jenkins-bot: [V: 04-1] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:27:42] Krinkle: I'm in a fight with gerrit and, as usual, I am losing [23:27:44] https://gerrit.wikimedia.org/r/#/c/114536/ [23:28:06] it's not merging because of a doc error in core, which I fixed in https://gerrit.wikimedia.org/r/114649 [23:29:08] TrevorParscal: Need to update the submodule [23:29:18] ah... right [23:29:22] too many repos [23:29:24] I'm currently working on creating jsduck test for ve/ve [23:29:29] (like, at this moment) [23:29:34] to prevent that [23:30:24] (03PS3) 10Trevor Parscal: Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:33:14] (03CR) 10Trevor Parscal: [C: 032] Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:34:22] (03Merged) 10jenkins-bot: Update MWLanguageInputWidget to new API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [23:34:30] (03CR) 10Trevor Parscal: [C: 032] Ensure we use our references to certain native or upstream methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114620 (owner: 10Krinkle) [23:35:40] (03Merged) 10jenkins-bot: Ensure we use our references to certain native or upstream methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114620 (owner: 10Krinkle) [23:38:10] Krinkle: you have some comments that aren't addressed yet on https://gerrit.wikimedia.org/r/#/c/113544/ but it's not -1, maybe you shoudd -1? [23:42:38] (03PS11) 10Trevor Parscal: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [23:42:46] (03CR) 10jenkins-bot: [V: 04-1] Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [23:45:39] (03PS12) 10Trevor Parscal: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [23:47:30] (03PS13) 10Trevor Parscal: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [23:49:51] (03CR) 10Trevor Parscal: [C: 032] Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [23:50:15] (03CR) 10Krinkle: [C: 031] "I thought the patch would need more, but I think this does it. Cool :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113544 (owner: 10Esanders) [23:51:02] (03Merged) 10jenkins-bot: Revamp media edit dialog's position widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/112041 (owner: 10Mooeypoo) [23:55:51] TrevorParscal: I didn't -1, but the next patch set did address my comments. [23:55:53] so it's good now [23:57:05] (03PS1) 10Krinkle: Sample commit for Jenkins [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114661 [23:58:00] (03CR) 10Robmoen: "Addressed the above comments. incomming patch / rebase hopefully its right." (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen) [23:58:02] (03CR) 10jenkins-bot: [V: 04-1] Sample commit for Jenkins [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114661 (owner: 10Krinkle) [23:58:19] (03PS2) 10Krinkle: Sample commit for Jenkins [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114661 [23:58:23] (03CR) 10Krinkle: "Lost?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114661 (owner: 10Krinkle) [23:58:58] (03PS3) 10Robmoen: Create mixin for node that responds to node click events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 [23:59:15] (03CR) 10jenkins-bot: [V: 04-1] Sample commit for Jenkins [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114661 (owner: 10Krinkle) [23:59:33] (03PS4) 10Robmoen: Create mixin for node that responds to node click events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062