[00:00:41] rdwrer: yeah, I know - unfortunately, while you are correctly redirecting me and I don't think you are doing anything wrong here, you are effectively suggesting I go pick a fight with a designer about a product I know very little about because I'm not personally impressed with something [00:00:51] probably not a good way to use my time or make friends [00:01:13] Heh [00:01:19] * James_F hugs TrevorParscal. [00:01:27] TrevorParscal: Good point, but it's not like we're not soliciting feedback [00:01:40] where are you soliciting feedback? [00:01:58] https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer [00:02:05] Bugzilla [00:02:07] Mingle [00:02:12] Errrrrverywherrrrre [00:04:11] no offense to the efforts, but there probably will never be a way to solicit feedback from a broad enough audience at WMF, not because of the mechanisms or visibility, but the unresponsiveness [00:04:15] but, I will give it a shot [00:04:38] don't want to sell Pau short based on the likes of his colleagues [00:05:44] TrevorParscal: If you have design feedback that's valid, it's better to have it and address it later than not have it and be unable - or so I'd say [00:07:03] I'm going to provide it, I don't want to be a downer... but dude. Where have you been working for the past couple years? Communication about design at Wikimedia is a one way street [00:07:17] Heh [00:07:29] TrevorParscal: I don't worry about design too much, I guess [00:08:45] TrevorParscal: The inline menu - how do I set a value to be displayed in the collapsed widget? [00:08:57] I want it to show the currently selected value [00:09:21] it uses the value of the selected item [00:09:34] if you don't have a selected item, you can use setLabel() [00:09:43] Hm. [00:09:44] it already does what you want [00:09:59] for items use OO.ui.MenuItemWidget [00:10:01] That's weird 'cause it isn't [00:10:02] Aha. [00:10:19] use the demos/widgets.js as an example [00:10:21] it's the last one [00:36:14] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Refactor dialog and window sets [oojs/ui] - 10https://gerrit.wikimedia.org/r/112132 (owner: 10Krinkle) [00:36:41] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Refactor dialog and window sets [oojs/ui] - 10https://gerrit.wikimedia.org/r/112132 (owner: 10Krinkle) [00:37:03] (03PS7) 10Trevor Parscal: [WIP] Convert styles to LESS and implement grunt task [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 [00:50:05] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (68c91ae065) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114901 [00:53:15] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (68c91ae065) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114902 [00:53:44] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (68c91ae065) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114902 (owner: 10Trevor Parscal) [02:38:41] RoanKattouw: Per Trevor, please merge https://gerrit.wikimedia.org/r/#/c/114892/ and https://gerrit.wikimedia.org/r/#/c/114899/ and then do a new OOjs UI build for MW core. [02:50:15] (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (68c91ae065) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114901 (owner: 10Trevor Parscal) [02:50:33] TrevorP|Away: grumble grumble grumble ---^^ [03:17:54] (03CR) 10Catrope: [C: 04-1] Add OO.ui.InlineMenuWidget (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/114892 (owner: 10Trevor Parscal) [03:18:37] (03PS3) 10Catrope: Add OO.ui.InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114892 (owner: 10Trevor Parscal) [03:18:52] (03PS4) 10Catrope: Add OO.ui.InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114892 (owner: 10Trevor Parscal) [03:19:01] (03CR) 10Catrope: [C: 032] Add OO.ui.InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114892 (owner: 10Trevor Parscal) [03:19:05] (03PS2) 10Trevor Parscal: Basic support for automatically rendering menus above or below [oojs/ui] - 10https://gerrit.wikimedia.org/r/114899 [03:19:12] (03PS3) 10Catrope: Basic support for automatically rendering menus above or below [oojs/ui] - 10https://gerrit.wikimedia.org/r/114899 (owner: 10Trevor Parscal) [03:20:30] (03Merged) 10jenkins-bot: Add OO.ui.InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/114892 (owner: 10Trevor Parscal) [03:37:02] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/113514/ [03:38:42] (03CR) 10Catrope: [C: 04-1] "This completely breaks the link inspector's input widget. It tries to render above (instead of below) always, but the suggestions still re" [oojs/ui] - 10https://gerrit.wikimedia.org/r/114899 (owner: 10Trevor Parscal) [03:43:51] RoanKattouw: https://gerrit.wikimedia.org/r/114909 [04:22:48] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (68c91ae065) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114901 (owner: 10Trevor Parscal) [04:23:52] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (68c91ae065) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114901 (owner: 10Trevor Parscal) [15:37:32] (03PS4) 10Alex Monk: Don't show edit summary preview if it's blank [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114737 [15:39:29] (03CR) 10Esanders: [C: 032] Don't show edit summary preview if it's blank [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114737 (owner: 10Alex Monk) [15:41:16] (03Merged) 10jenkins-bot: Don't show edit summary preview if it's blank [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114737 (owner: 10Alex Monk) [20:52:37] Hello. Which part of VisualEditor should I read to understand how to add support for another skin? [20:53:20] I already found the 'supported skins' line and added a skin to it, but of course clicking 'edit' produces no reaction and no error. [20:54:54] gry: your skin is probably missing some of the ids/classes Vector and Monobook place on their content [20:55:25] gry: it will likely be a lot easier for you to add those, than try to get visualeditor to recognize yours [20:55:27] Right. Where can I read more on which ones VisualEditor uses. [20:56:10] I'm not very good on skimming through its entire files tree and unerstanding which one is responsible for DOM interaction. [20:56:30] i doubt you can read about it anywhere :P my bet would be that it requires #ca-edit at least [20:56:39] (since it hooks to clicks on that) [20:57:19] or #ca-ve-edit, this can depend on some configuration [20:58:48]
  • Edit
  • [20:58:48]
  • Edit source
  • [20:58:51] that seems to be there [21:08:35] gry: also, the developers are rarely here on weekends :/ try asking on monday, during working hours San Francisco time [21:09:10] it's funny how the other skins aren't supported but it's not documented how to do it [21:09:28] so I end up wasting time of the developers who said they don't want to support other skins :)