[00:08:55] (03CR) 10Catrope: [C: 032] Always try to put redirects at index 0, offset 0 [extensions/VisualEditor] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115309 (owner: 10Catrope) [00:10:19] (03Merged) 10jenkins-bot: Always try to put redirects at index 0, offset 0 [extensions/VisualEditor] (wmf/1.23wmf15) - 10https://gerrit.wikimedia.org/r/115309 (owner: 10Catrope) [00:45:28] (03CR) 10Catrope: [C: 032] Add placeholders to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114773 (owner: 10Mooeypoo) [00:46:33] (03Merged) 10jenkins-bot: Add placeholders to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114773 (owner: 10Mooeypoo) [01:11:30] (03CR) 10Catrope: [C: 04-1] "Per PS6: the size inputs need to be disabled when the "default" button is depressed, otherwise you can enter things there, save, and be su" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [01:19:25] (03CR) 10Catrope: [C: 031] "Looks fine (but depends on an unmerged change in VE core)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115307 (owner: 10Mooeypoo) [01:41:43] gwicke, around? [01:43:55] Krenair, what's up? [01:44:09] gwicke, have been looking into MW's support for gzipped HTTP responses [01:44:38] As far as I can tell, in production you should be getting a header like "Accept-Encoding: identity, deflate, gzip" [01:46:34] Regardless of whether the function calling MWHttpRequest sets the header, because with the cURL backend (which is installed in production) it should always enable compression [01:48:01] Krenair, I did not look at actual requests; Varnish ignores the client-side Accept-Encoding header for the backend request anyway [01:48:34] it always tries to get a gzipped response from the backend and caches that [01:48:51] when a client requests an uncompressed version it decompresses on the fly [01:49:43] since this is small data and on a fast internal network using compression between mw and parsoid is actually not that important [01:53:04] gwicke, yeah so this is low priority [01:53:22] gwicke, Just trying to work out why MW apparently isn't requesting a gzipped version [01:54:51] Krenair, did you check the headers on the wire? [01:59:10] gwicke, just did that, I see "Accept-Encoding: deflate, gzip" [02:01:55] Krenair: that sounds like 'worksforme' then [02:03:16] do you get a compressed response from parsoid? [02:06:10] (03PS8) 10Robmoen: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 [02:06:29] gwicke, yep [02:07:26] (03CR) 10jenkins-bot: [V: 04-1] Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [02:07:33] that then also verifies that decompression works [02:09:22] (03CR) 10Robmoen: [C: 04-1] "I still probably need to address some of the feedback Roan left, also as to be almost predicted there are some issues with transclusions i" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [02:25:53] alright I updated the bugs with my thoughts, thanks gwicke [02:27:53] Krenair, thanks for investigating it! [05:08:53] (03PS8) 10Mooeypoo: [wip] Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 [05:17:42] (03PS1) 10Mooeypoo: Add 'change' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 [05:18:45] (03CR) 10jenkins-bot: [V: 04-1] Add 'change' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 (owner: 10Mooeypoo) [05:18:48] (03PS9) 10Mooeypoo: [wip] Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 [05:20:25] (03PS2) 10Mooeypoo: Add 'change' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 [07:16:42] >> var a = { b: 123 }, b = false; b && a [07:16:43] Krinkle: (boolean) false [07:16:46] >> var a = { b: 123 }, b = false; a && b [07:16:46] Krinkle: (boolean) false [07:16:53] >> var a = { b: 123 }, b = false; !b && a [07:16:54] Krinkle: (object) {b: 123} [09:34:12] (03CR) 10Krinkle: [C: 04-1] Mark hidden categories as different in the meta-data dialog (039 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113464 (owner: 10Alex Monk) [10:12:14] (03CR) 10Nemo bis: "Thanks for your first patch to MediaWiki and welcome! I've added a couple reviewers from the file's history. How is this patch related to " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113173 (owner: 10Ltrlg) [10:56:27] (03CR) 10Esanders: Allow dynamic limit to maxDimensions (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115306 (owner: 10Mooeypoo) [14:59:15] (03PS1) 10Cmcmahon: Disable headings test while Bug 61856 is under investigation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115380 [15:21:17] (03PS2) 10Krinkle: Update specs example to use new types (without "string/" prefix) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113173 (owner: 10Ltrlg) [15:21:24] (03CR) 10Krinkle: [C: 032] "Thanks!" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113173 (owner: 10Ltrlg) [15:22:15] (03Merged) 10jenkins-bot: Update specs example to use new types (without "string/" prefix) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113173 (owner: 10Ltrlg) [15:51:19] (03PS1) 10Esanders: Check indentation was successful before trying again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115385 [16:16:26] (03CR) 10Cmcmahon: [C: 032] Disable headings test while Bug 61856 is under investigation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115380 (owner: 10Cmcmahon) [16:17:45] (03Merged) 10jenkins-bot: Disable headings test while Bug 61856 is under investigation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115380 (owner: 10Cmcmahon) [16:24:19] (03CR) 10Krinkle: [C: 04-1] "Issues pointed out on Feb 20 for Patch Set 3." [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [17:28:01] (03PS1) 10Esanders: Add special case to de-indentation for slugs in listItems [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115402 [17:40:04] (03PS3) 10Mooeypoo: Allow dynamic limit to maxDimensions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115306 [17:53:10] we're now using OOJS in core? [17:54:55] edsanders: Yes. [17:55:19] Not yet (I think), but it's there for usage by certain extensions to avoid duplicating the module and keeping us on-track with compatibility and starting to get more users. [17:55:29] James_F: Are we using it in core itself yet though? [17:55:58] (UI that is) [17:56:06] Krinkle: I parsed Ed's statement as "{we}'re now using {OOjs UI in core}". [17:56:42] Krinkle: As in "VisualEditor is now using OOjs UI supplied by MW-core". [17:56:44] Krinkle: So far it's only used in three extensions and not in MW-core itself, no. [17:57:14] (We could have this conversation in the Hangout.) [17:57:17] Oh, we (VisualEditor) using UI from core. Yep, that too :) We're eating our own dog food. [17:57:50] I'm looking forward to the other we (Wikimedia) using OOjs UI in mediawiki core (as opposed to just providing it) [17:57:59] Yeah, agreed. [17:58:14] Delayed, will be there in 4 minutes. [18:00:34] James_F: Do you know if TrevorP|Away's patch to add the drop-down is in mediawiki/core yet? [18:00:49] (03PS4) 10Esanders: Allow enforce(Min|Max)Dimensions to be changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115306 (owner: 10Mooeypoo) [18:00:53] rdwrer: Umm. Can't remember. [18:00:59] rdwrer: Think I may have forgotten. [18:01:21] (03CR) 10Esanders: [C: 032] Allow enforce(Min|Max)Dimensions to be changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115306 (owner: 10Mooeypoo) [18:01:31] Woo. [18:01:55] James_F, do you want me to file a bug about those categories now even if we don't know what's wrong with them? [18:01:56] rdwrer: InlineMenuWidget? It's in MW-core's build of OOjs UI now. [18:01:58] https://gerrit.wikimedia.org/r/#/c/114892/ merged, but maybe or maybe not in core [18:02:01] Oh, cool. [18:02:03] Elitre: Please do. [18:02:03] * rdwrer will update [18:02:22] (03Merged) 10jenkins-bot: Allow enforce(Min|Max)Dimensions to be changed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115306 (owner: 10Mooeypoo) [18:03:02] Ah man, that's super cool. [18:04:08] rdwrer: But not the scroll-up thing - apparently TrevorP|Away e-mailed Pau (and you?) about it. [18:05:35] Oh, well [18:05:39] I should look at that then [18:08:07] (03PS3) 10Mooeypoo: Limit thumbnail dimensions in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115307 [18:13:16] James_F, I took off the [wip] from the ve-mw patch whose dependencies in ve-core was merged, but i left it on the one that's still waiting.. or should I remove from both? They're ready, just awaiting ve-core change to merge. [18:13:21] oh, I'm still unimoo. [18:13:38] Much better. [18:13:39] mooeypoo: [WIP] isn't needed for things with cross-repo dependencies. [18:14:09] James_F, I was concerned it would be merged before the cross-repo dependencies were, but I think it's pretty clear with the commit message. I'll take the [wip] off. [18:15:27] mooeypoo: Also it shouldn't actually merge, I think. [18:15:31] I /think/ Jenkins will stop you merging it. [18:17:27] (03PS10) 10Mooeypoo: Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 [18:17:40] James_F, it's more of a logical dependency, I don't think jenkins would know about it. [18:18:20] mooeypoo: You don't pull in lib/ve in the change? [18:18:43] no, I always leave it out, I thought that causes problems? [18:19:07] Is that the way to do it? [18:19:19] Yeah, though it means your code needs re-basing later instead. [18:19:56] (03PS3) 10Mooeypoo: Add 'change' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 [18:19:58] (03PS1) 10Jforrester: Update VE core submodule to master (48a5607) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115414 [18:20:17] oh. hm [18:20:43] mooeypoo: If you base your changes off 115414 it should work. [18:20:51] Oh, except for the one that's not merged yet. [18:21:02] yeah :\ [18:21:18] though it's relatively tiny [18:21:39] Yeah, but change events can have unexpected results in VE (or, at least, they used to). [18:21:51] Krinkle: Could you review, do you think? https://gerrit.wikimedia.org/r/#/c/115338/ [18:23:51] (03PS11) 10Jforrester: Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [18:24:19] (03CR) 10jenkins-bot: [V: 04-1] Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [18:24:33] mooeypoo: ^^^ So I made it depend on 115414 and also on 115338. [18:24:51] mooeypoo: If that makes sense? [18:24:53] James_F: now at https://bugzilla.wikimedia.org/show_bug.cgi?id=61921 . [18:24:59] Elitre: Thanks! [18:25:23] sorry my tests weren't much useful. [18:25:51] Elitre: Do the categories show up on other category pages? [18:26:13] yes -_- [18:26:45] good morning [18:26:48] https://it.wikipedia.org/wiki/Categoria:Aggiornare_-_scienze_sociali?veaction=edit is similar, but it's fine [18:26:57] I just work up, left my phone in the car so I had no alarm :( [18:27:21] TrevorParscal: Fool. :-) [18:27:31] Elitre: Hmm. Well, that's good. [18:28:02] (03PS4) 10Krinkle: Add 'change' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 (owner: 10Mooeypoo) [18:28:18] yes, it means categories still work on category pages :) but probably doesn't help us triage that bug :) [18:28:20] dude, I haven't slept in on accident like that in a long time - it feels really good, until you realize what time it is, then it feels really bad [18:28:36] TrevorParscal: Psh, næ bother laddie. [18:29:00] Elitre: I'll ask RoanKattouw_away to look at it when he's back. [18:29:02] Krinkle: i'm tearing into the template editing stuff [18:29:24] Haven't yet identified the best collaboration points so, feel free to steer clear for a day [18:29:33] k [18:30:05] Krinkle: I've got loads of other things you could work on if you want. ;-) [18:30:20] edsanders: If you don't feel up to much more, there's some fun icon-making requests in your list, BTW. [18:31:18] BTW, I like the icon with sliders :) [18:33:01] (03CR) 10Krinkle: [C: 031] "Looks good. Would like to keep this pending (but approved) until we have at least one listener though (since this class isn't currently be" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 (owner: 10Mooeypoo) [18:33:38] James_F: Got about 10 minutes before dinner for small things if you got them for me. Else I'll dive in now instead of after. [18:34:12] out of curiosity, which icons need making? [18:34:26] Hm.. nvm. Went quicker than I thought. biab [18:35:04] and also, i love that Ed makes icons for us - out team is has so many hybrids [18:35:58] ooh, media inspector icons [18:35:59] nice [18:36:33] * TrevorParscal returns to template editing mayhem [18:39:47] TrevorParscal: Yeah, and bold ones for a few languages. [18:41:15] https://gerrit.wikimedia.org/r/#/c/113464/14/modules/ve-mw/ui/widgets/ve.ui.MWCategoryItemWidget.js [18:41:41] anyone know what Krinkle is expecting for "Be sure to document @cfg hidden."? AFAICT no other object key is documented there, so... [18:42:34] (03CR) 10Jforrester: "Krinkle: See Ib973ea2afa96090a4ba linked in the commit summary for the use…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 (owner: 10Mooeypoo) [18:43:02] Krenair: Oh, you should have a comment about that specific config item. [18:44:23] Krenair: So " * @cfg {boolean} [hidden] Hide this" [18:45:21] Oh okay. Where does the @cfg come from? [18:45:59] Krenair: It's implicit (human reading of "@param {Object} [config] Configuration options" combined with @cfg statements). [18:46:23] I probably should have read it more carefully - I see there's already a @cfg there [18:46:26] It's a JSDuck thing. [18:46:38] Alright, makes sense, thanks James_F [18:48:50] Krinkle|detached, the listener for https://gerrit.wikimedia.org/r/#/c/115338/ is in https://gerrit.wikimedia.org/r/#/c/114420/ [19:08:53] mooeypoo: Hm.. no dependency? [19:08:55] Oh, it's in a different repo. Right. [19:08:57] I was looking for a dependency, but only saw a seemingly unrelated submodule update [19:09:00] makes sense :) [19:09:23] Krinkle, sorry, I am still trying to figure out how to point to a dependency when it's cross-repo [19:09:36] I tried to point it out in the commit, but that can be confusing too. [19:09:37] Krinkle: Blame me. :-) [19:16:00] edsanders: Feel like making strike-through icons? :-) Finnish want Y… [19:16:20] add it to my list [19:17:58] edsanders: I did. [19:18:04] k [19:18:06] edsanders: But are you going to do them? :-P [19:18:26] yes [19:18:35] OK. :-) [20:08:17] (03PS1) 10Esanders: Bold/italic icons for ksh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115424 [20:09:45] (03CR) 10Jforrester: [C: 031] Bold/italic icons for ksh [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115424 (owner: 10Esanders) [20:32:35] (03PS1) 10Jhall: [Browser test] WIP Addtional Scenario for bug 59091 regression. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115510 [20:32:52] Krinkle: Most useful right now would be code-review of https://gerrit.wikimedia.org/r/#/c/115338/ https://gerrit.wikimedia.org/r/#/c/115385/ https://gerrit.wikimedia.org/r/#/c/115402/ and https://gerrit.wikimedia.org/r/#/c/113464/ [20:33:08] (03CR) 10Krinkle: [C: 032] Add 'change' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 (owner: 10Mooeypoo) [20:33:15] Krinkle: :-) [20:34:08] (03Merged) 10jenkins-bot: Add 'change' event to MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115338 (owner: 10Mooeypoo) [20:35:18] (03PS2) 10Jforrester: Update VE core submodule to master (f173ff2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115414 [20:38:43] (03PS12) 10Jforrester: Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [20:38:44] (03CR) 10Krinkle: Set up wiki-default image size (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [20:40:50] Krinkle: Sorry for my rebase messing up your review. [20:40:58] (03CR) 10Jforrester: "PS12 is a rebase onto the patch bringing the dependencies into this repo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [20:47:57] (03CR) 10Jforrester: [C: 031] "All changes are benign (or in the case of I52e6a28e5a16e have already made the changes necessary)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115414 (owner: 10Jforrester) [21:01:56] (03CR) 10Krinkle: Update OOjs UI to v0.1.0-pre (68c91ae065) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114901 (owner: 10Trevor Parscal) [21:02:58] (03CR) 10Krinkle: [C: 032] "Is this thing turned on?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115414 (owner: 10Jforrester) [21:04:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (f173ff2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115414 (owner: 10Jforrester) [21:05:51] (03PS1) 10Esanders: Strikethrough icon for fi [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115512 [21:09:54] * James_F|Away hugs Krinkle for making him laugh. [21:10:02] (03CR) 10Mooeypoo: Set up wiki-default image size (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [21:11:57] Krinkle, ^^ (comments in ps11) -- I'm particularly unsure about the potential case of width/height being both null. Not sure how to deal with that, but I'm also not sure it's even ever supposed to happen..? [21:14:00] TrevorP|Away, why are the bold/italic icons oo- prefixed? [21:14:18] (03CR) 10Jforrester: [C: 031] Strikethrough icon for fi [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115512 (owner: 10Esanders) [21:16:41] edsanders: Maybe they should be moved into OOjs UI? [21:31:36] edsanders: hey, icons... [21:31:52] so, the icon system could probably be improved [21:32:32] but right now, there's no icon registry, we just assume there's a CSS class for .oo-ui-icon-{icon name} [21:32:55] so, if we make the icons provided by ve use ve-ui-icon-{icon-name} it won't find them [21:33:29] we could add an icon registry where you could provide a CSS class name for a given symbolic name, which might be nice - but it's one more thing to maintain [21:33:39] edsanders: does that answer your question? [21:34:57] I see [21:46:19] (03PS13) 10Mooeypoo: Set up wiki-default image size [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 [21:58:29] edsanders: Want to have a go at thinking about how we'll add
support? https://gerrit.wikimedia.org/r/#/c/72840/ was sort-of working, except that it didn't work (because they aren't ContentBranchNodes, but directly contain content)? Maybe we could instead do it via it being a class on a paragraph which gets rendered out in the converter into a
, and so the indent/outdent funct [21:58:30] ionality just magically works on selections? [22:16:43] James_F: making good progress on template editor [22:16:48] lots to show tomorrow I thinl [22:16:50] *think [22:16:57] taking a quick break, brb [22:17:18] TrevorParscal: Yay. :-) [22:17:27] TrevorParscal: Screencast or it didn't happen. ;-) [22:57:32] James_F|Away, who should I poke about rebasing https://gerrit.wikimedia.org/r/#/c/113488/ ? [23:39:58] TrevorParscal: You're on IRC. Great. Now check google hangout :P [23:40:06] k