[11:26:01] (03CR) 10Krinkle: [C: 04-1] "This is how to generate that diff cleanly btw, since doing a plain oojs-ui-update with the bin script in VE will also include a few other " [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [11:26:42] (03PS17) 10Krinkle: Convert styles to LESS and implement grunt task [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [12:14:33] (03CR) 10Krinkle: "More diff: https://gist.github.com/Krinkle/26b30b270262b27423ea" [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [12:14:50] (03PS18) 10Krinkle: Convert styles to LESS and implement grunt task [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [12:16:01] (03CR) 10Krinkle: "Fixed 2 things:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [12:16:28] (03CR) 10Krinkle: "Everything commented so far has been fixed by Trevor or me. Found one last thing:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [13:10:51] James_F|Away, you're wrong but I forgive you [13:14:40] that's an interesting statement :) [13:33:59] (03PS2) 10Esanders: Alignment icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115664 [13:50:08] (03CR) 10Esanders: "FIXME: This commit completely breaks frameless float-right images. Consider reverting." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [13:58:26] (03CR) 10Esanders: "FIXME: This completely breaks image editing (no context icon shows). Consider reverting!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [14:06:24] (03CR) 10Esanders: "The problem is MWDialogTool needs to be split up, otherwise it will try to register tools against classes that don't exist yet. This commi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [14:06:43] (03PS1) 10Krinkle: ve.ui.MediaSizeWidget: Use lowercase types hint for primitive value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115904 [14:06:47] (03CR) 10Krinkle: "Fixed in I456d011c61a205be48c8dcb1f417a216bfc44612." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114773 (owner: 10Mooeypoo) [14:07:49] Krinkle, can you confirm my concerns with 113488 [14:08:12] it appears Trevor mentioned the same problem at PS2 but it was never addressed [14:09:55] checking [14:13:36] edsanders: Well, in latest mwext-ve, I don't see a way to edit images at all (the image inspector doesn't show up in context), and I don't see it in Beta features either [14:13:50] or mwlinks [14:14:01] (which definitely isn't a beta feature!) [14:14:15] ok will revert [14:14:19] Indeed, though that one still works when selecting hte link and clicking via toolbar [14:14:21] Yeah [14:14:36] Not sure which one of those commits caused it (assuming its one of those), but stuff is definitely broken in master [14:20:02] (03PS1) 10Esanders: Revert "Split up ext.visualEditor.mwcore into smaller parts" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115909 [14:20:37] diagnosed 113488 through bisect, also found what I think is the cause (MWDialogTool) [14:20:47] (03CR) 10jenkins-bot: [V: 04-1] Revert "Split up ext.visualEditor.mwcore into smaller parts" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115909 (owner: 10Esanders) [14:22:17] doesn't rebase *sigh* [14:25:27] wow this is a total mess, that changed 100+ lines, and there have been 4 commits since then [15:18:14] (03PS1) 10Esanders: Fix everything [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 [15:18:38] (03Abandoned) 10Esanders: Revert "Split up ext.visualEditor.mwcore into smaller parts" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115909 (owner: 10Esanders) [15:20:25] (03CR) 10Esanders: [C: 04-2] "links still broken" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [15:32:36] does anyone have ideas as to why templates such as infobox person can be moved around by dragging, while others like babelboxes (created by templates as well) aren't? [15:45:17] (03PS2) 10Esanders: Fix everything [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 [15:47:17] (03CR) 10Esanders: "Links fixed. Review please." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [15:47:38] Krinkle, ^^ [15:55:27] Elitre: example page? [15:56:30] krinkle: https://en.wikipedia.org/w/index.php?title=User:Elitre_%28WMF%29/Sandbox&oldid=597383746&veaction=edit [15:57:04] it totally works if there's an empty line between them in wikicode, instead [15:57:20] i cant drag either of those [15:57:34] because there's no such a line :D [15:57:54] you should be able to drag them, check the current version of that sandbox [15:58:19] cant [16:00:10] rechecking. [16:01:24] VE is trolling me. [16:07:58] I'll never make statements including the word "totally works" again. [16:12:01] * Elitre waves at James. [16:15:23] krinkle: you can move templates when you add them the first time, but not when you edit the page again. you can add another one to https://en.wikipedia.org/wiki/User:Elitre_(WMF)/SandboxVE if you want to try - I used Infobox person. [16:15:51] James_F, MWAlienExtension WFM... [16:16:17] what's broken? [16:16:18] Elitre: indeed [16:16:22] I can move that one [16:16:50] Elitre: If I copy and paste templates, this doesnt' change [16:16:52] (03PS3) 10Jforrester: Follow-up: I6374854eaa1 - split out MWDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [16:16:59] copies of ones I inserted remain moveable [16:17:02] copies of existing ones don't [16:17:03] edsanders: ^^^ fixed now I think. [16:17:15] Krinkle: Please focus on reviewing 115920. [16:17:23] Elitre: Hey. Sorry, we're a bit busy right now. [16:17:43] edsanders: Not broken, just badly split up. [16:17:44] so, this has nothing to do with floated/unfloated templates, I think. no worries, I can file a bug later if you need me to. [16:18:02] (03CR) 10jenkins-bot: [V: 04-1] Follow-up: I6374854eaa1 - split out MWDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [16:18:07] James_F: I reviewed the code a few minutes ago, currently trying to understand a little bit better why it makes it work. [16:18:10] edsanders: ve.ui.MWInspector.css didn't relate to ve.ui.MWInspector.js because that doesn't exist. [16:18:27] your PS mentions modules/ve-mw/ui/tools/ve.ui.MWInspectorTool.js [16:18:46] Gah, should have used add -p. [16:19:34] (03PS4) 10Jforrester: Follow-up: I6374854eaa1 - split out MWDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [16:20:16] edsanders: New diff is https://gerrit.wikimedia.org/r/#/c/115920/2..4/VisualEditor.php https://gerrit.wikimedia.org/r/#/c/115920/2..4/modules/ve-mw/ui/styles/ve.ui.MWAlienExtensionInspector.css https://gerrit.wikimedia.org/r/#/c/115920/2..4/modules/ve-mw/ui/styles/ve.ui.MWExtensionInspector.css [16:21:41] edsanders: Re. reverting 114420 (frameless float-rights) I'd be really sad; is there a quick fix for that one? [16:22:06] I haven't looked into it [16:25:39] edsanders: So what race condition was being triggered? [16:25:45] Registered too late I presume, but too late for what? [16:26:44] ve.ui.MWMediaEditDialogTool.static.modelClasses = [ ve.dm.MWBlockImageNode ]; [16:26:54] when ve.dm.MWBlockImageNode is undefined [16:27:48] The load order was precarious, and my failure to split the monolithic file and pull the pieces through to the right points broke things. [16:28:54] Right, so the main issue is that ve.ui.MWDialogTool.js is still part of the mwcore module [16:29:04] Yeah. [16:29:09] It was missed from the split. [16:29:29] because as of the split, the ve.dm references were undefined as they are loaded afterwards. [16:29:30] OK [16:31:17] We should probably do a proper hunt for remaining omnibus files and split them up. [16:33:20] (03PS5) 10Krinkle: Fix-up mwcore split: Split out MWDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [16:33:35] Rephrased to incorporate what was said by you and Ed here and on the other change in the comments [16:33:42] * James_F nods. [16:34:06] Krinkle: LGTM. [16:34:18] (03CR) 10Krinkle: [C: 032] "WFM." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [16:34:54] Excellent. [16:34:57] edsanders: You looking at 114420? [16:35:24] (03CR) 10Jforrester: "Fixed in Ic05b173d730a8a." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113488 (owner: 10Jforrester) [16:36:39] (03Merged) 10jenkins-bot: Fix-up mwcore split: Split out MWDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115920 (owner: 10Esanders) [17:10:58] edsanders, float-right frameless images work for me in firefox and chrome... can you be more specific? where did they break? did you use a specific wikitext? [17:11:27] [[Image:foo.jpg|right]] [17:12:16] the left of the image aligns to the right of the document, such that the image is almost completely off the screen and unclickable [17:12:44] git bisect points the blame at the commit I commented on [17:13:16] Elitre: :-) [17:13:41] edsanders, I see it. [17:16:28] James_F: O:-) if you have a sec now, maybe you can tell me if what I was discussing with Krinkle earlier deserves a bug or something. [17:17:35] Elitre: That's because edsanders still hasn't fixed that bug. ;-) [17:18:18] Elitre: Though really we should just make block transclusions draggable too. [17:18:27] which one is it then? [17:18:45] Elitre: When you first insert a transclusion, we don't know whether it's block or inline, so we assume it's the former (which is draggable); when you save, Parsoid tells us it's block, so we stop you dragging it the second time. [17:19:01] Elitre: I'll make a bug. [17:19:49] ok, tnx. waiting for the # here so I'll report on en.wp feedback page [17:22:33] Elitre: https://bugzilla.wikimedia.org/show_bug.cgi?id=62006 [17:22:39] James_F / edsanders seems I'm missing 'type:none' in the select. No type is almost like frameless but not exactly, so it can't fall back to 'frameless'. I'm taking care of it now, but for the moment adding 'none' as a choice. We can figure out how to handle this later. [17:22:59] mooeypoo: OK… [17:24:02] (03PS7) 10Divec: Fix handleEnter in nodes that don't split [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 [17:24:21] Woo. [17:24:41] mooeypoo: Have you talked with edsanders/TrevorParscal about the image model work? [17:25:10] not in the past couple of days. I understand TrevorParscal was working on a base for it. [17:25:29] * James_F nods. [17:25:40] Right now he's working on the template stuff, though. [17:25:53] I see. [17:26:31] well, the image model is supposed to simplify the way things work and allow for inline/block conversions [17:26:41] * James_F nods. [17:26:46] James_F, can you help me out here for a sec? https://en.wikipedia.org/wiki/Wikipedia:Extended_image_syntax#Type [17:26:56] the difference between having no type and having 'frameless' [17:27:35] i don't understand, the 'default size' is the only difference? if so, do I bother to make a new select button, or do I go with "none" being selected as "frameless" as default value? [17:27:36] mooeypoo: Frameless !== none. [17:27:42] right, that's what I understand. [17:28:12] mooeypoo: We may want to re-jigger types anyway, but no, I'd say we'll just label this as "basic" or something. [17:28:18] (this == 'none'). [17:28:29] * mooeypoo nods [17:30:45] james_F: thanks. what about misalignment for those blocks? as in https://en.wikipedia.org/w/index.php?title=User:Scott_Martin/sandbox&oldid=597374014&veaction=edit ? [17:41:00] mooeypoo, I don't know if you remember, but we were talking a while back about VisualEditor not pulling images when MW is installed in the root. Anyway, that bug was closed blaming the MW search, but this is not the case. I opened a new bug, 62007, and attacked pcap files and my LocalSettings.php (keys and DB stuff removed) [17:41:45] RobertLabrie, you manage to find them in your wiki with the same search? [17:42:10] (03PS1) 10Mooeypoo: Add type 'none' to the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [17:42:20] James_F , edsanders|away ^^^ [17:43:28] mooeypoo, that's right. Once I added File to the search namespace list for my user, I was able to do a partial filename search and get results back. That is, if I searched for "WOM" I get back "File:WOM HighLevelDesign Breeze.PNG" [17:43:44] mooeypoo, that's using the search box on in the upper right hand corner [17:44:09] but you don't get tht in the image insert dialog in VE ? [17:45:28] mooeypoo, thats right. I get no results in the insert dialog. Also, when I'm entering text in the search box in the insert dialog, I don't see that being sent to the API to query for matching media [17:45:43] hmmm. [17:45:53] mooeypoo, when I open the dialog, a request goes out to the API, it gets a valid response, but that's the end of it [17:45:59] and If you put the entire file name? [17:46:06] mooeypoo, standby [17:47:29] mooeypoo, even enter the full filename with namespace in the VE insert media dialog search box, I get no results [17:47:58] :\ that's odd. [17:48:03] okay, I'll take a look. Hmm. [17:49:26] I do get local image to pop up, but only when I use its full name [17:49:29] that is odd. [17:51:18] mooeypoo, when filerepoinfo fires, I get a response, but thats it. I can type whatever I want into the search box, and it's never even sent to the API [17:55:22] RobertLabrie, that's what baffles me. I do have requests to the API. [18:09:26] RobertLabrie, so, I see you have $wgUseInstantCommons = false; is that because you want to only have images from your local repo ? [18:10:25] I set it to false on my end, and I still get responses from the API but must put a *full* name, otherwise the API search doesn't find it. [18:11:12] RobertLabrie, so, for example, I have a file called 'westmintpalace.jpg' -- it wouldn't find it in local as anything other than the full name (including .jpg) for me. I am thinking that the problem is the API, but i"m a bit concerned that you don't even *see* API requests at all. [18:17:58] what in the name of Chrome is going on. [18:18:40] edsanders, James_F|Away all block images are broken for me in chrome on master now... they seem to all be surrounded by ::before [18:19:26] it *just* started. [18:20:06] Is it something anyone else sees? [18:24:15] ok clearing cache fixed that. yeesh. [18:24:42] mooeypoo: Very odd! [18:24:49] extremely :\ [18:26:32] ok James_F there seem to be a confusing detail about none vs everything else (including frameless). None's default size is its original size, as opposed to all else whose default size is the wiki default. I can add it in, but i'm going to have to run to class in less than half hour, and i'm worried to rush things. The fix that I put up should at least let users not experience breakage. [18:26:41] and I'll work on the default fix this evening. [18:31:17] mooeypoo, sorry, I was in a meeting [18:31:49] mooeypoo: Sure, yeah, sorry I should have mentioned that bit too. [18:31:53] * James_F sucks. [18:34:08] James_F, the docs are so confusing. [18:35:10] RobertLabrie, no problems, I need to go to class soon, but I'm looking into the issue. It's very odd. [18:35:17] The oddest is that you're not getting any API requests. [18:39:55] mooeypoo, right, I think maybe that VE doesn't like the response it gets from filerepoinfo [18:40:28] mooeypoo, one thing worth notiing is that if I enable commons as a repo for VE, it does search commons, so I know at least that works [18:40:44] yes, but Commons uses a different search engine :\ [18:41:03] but I know my search engine works, VE is just never sending the request [18:41:12] yeah that's what's weird here. [18:41:16] I can't replicate *that* behavior. [18:41:25] it sends requests for me, whether I have instant commons on or off. [18:41:57] mooeypoo, can you try to install MW in the root and see if you can reproduce? I remember that being considered unusual for us [18:42:08] Yes, I might have to. [18:42:55] Very odd problem. [18:43:06] when filerepoinfo responds, displyname is "null" and scriptDirUrl is "", so I'm wondering if maybe something in there is upsetting VE [18:43:09] RobertLabrie, I had to restart chrome, I lost the bug link can you link it again? [18:43:24] mooeypoo, it's 62007 [18:43:38] got it [18:44:25] cool, ty. I attached wireshark pcap files so you can see what my UA was sending and what the server sent back [18:44:35] * mooeypoo nods [18:44:36] thanks! [18:45:22] work comes in waves for me, so I might not be able to respond to inquiries quickly, but this is an active project for us, so if you need something more from me, I will get it to you eventually [18:47:04] * mooeypoo nods [18:47:14] I'll post comments in the bug, if I need anything when you're not on IRC [18:47:31] I must run to class, but I'm going to look into this closer when I get back [21:09:41] unimoo: When you get back, I created https://www.mediawiki.org/wiki/VisualEditor:TestImageTypes for you – but note the (major) difference of appearance in between regular appearance and when you have the "Typography Update" Beta Feature switched on. [21:20:26] (03PS2) 10Jforrester: Add type 'none' to the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [21:22:06] (03CR) 10Jforrester: "Breakage for floated none-type images tracked in bug 62013." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114420 (owner: 10Mooeypoo) [21:24:12] (03CR) 10Jforrester: [C: 04-1] ""Basic" ('none') images should have the "default size" button greyed out (because there's no such thing, like for 'frame' images)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [22:52:03] https://bugzilla.wikimedia.org/show_bug.cgi?id=54965 - this is strange... it appears the CSS height value is getting set to 0px [22:52:10] but only in monobook [22:58:25] Looks like an oojs-ui bug... I think... [23:09:14] Krenair: Does Monobook have a clashing style, somehow? [23:09:33] Krenair: (But I thought we were namespaced in class names…) [23:12:01] James_F, appears to be related to OO.ui.ClippableElement [23:12:14] Oooooh. [23:12:14] * James_F sighs. [23:12:16] I hate z-index. [23:12:23] It's always Monobook's z-indexes. [23:13:31] I don't think it's that. desiredHeight (OO.ui.ClippableElement.prototype.clip) is being calculated to a negative value under monobook. Although that function doesn't appear to get called at all on vector... [23:13:55] Krenair: TrevorParscal is the expert. [23:14:13] actually it is called. hm [23:27:11] (03PS1) 10Trevor Parscal: Refactor OutlineControlsWidget, add remove button [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 [23:31:53] (03PS3) 10Trevor Parscal: OOjs UI to v0.1.0-pre (144d950375) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115539 [23:33:59] adding 9880 to this.$clippableContainer.innerHeight() makes it display correctly on monobook (9880 is the value in vector, obviously this breaks other stuff) [23:34:54] Krenair: That feels like a huge hack though… [23:35:03] yeah [23:35:12] I'm not proposing it as an actual fix :) [23:35:56] * James_F grins. [23:39:29] (03PS4) 10Trevor Parscal: Update core (If994572) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 [23:39:59] (03CR) 10jenkins-bot: [V: 04-1] Update core (If994572) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 (owner: 10Trevor Parscal) [23:42:45] edsanders: You're back! [23:43:58] (03PS5) 10Trevor Parscal: Update core (If994572) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 [23:44:06] (03PS3) 10Trevor Parscal: Redesign template parameter pages to be more space efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115548 [23:44:08] (03PS3) 10Trevor Parscal: Use label of first template as Template dialog title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115546 [23:44:10] (03PS2) 10Trevor Parscal: Remove outline from TemplateDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115547 [23:44:12] (03PS2) 10Trevor Parscal: Cleanup duplication in TransclusionDialog classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115545 [23:44:35] (03CR) 10jenkins-bot: [V: 04-1] Update core (If994572) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 (owner: 10Trevor Parscal) [23:44:44] (03CR) 10jenkins-bot: [V: 04-1] Redesign template parameter pages to be more space efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115548 (owner: 10Trevor Parscal) [23:44:58] (03CR) 10jenkins-bot: [V: 04-1] Use label of first template as Template dialog title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115546 (owner: 10Trevor Parscal) [23:45:15] (03CR) 10jenkins-bot: [V: 04-1] Remove outline from TemplateDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115547 (owner: 10Trevor Parscal) [23:45:28] (03CR) 10jenkins-bot: [V: 04-1] Cleanup duplication in TransclusionDialog classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115545 (owner: 10Trevor Parscal) [23:46:07] (03CR) 10Trevor Parscal: "It's just a typo fix. There's no such thing as iconedElement-label, there's only labeledElement-label and iconedElement-icon." [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [23:50:56] (03CR) 10Esanders: [C: 04-1] Use CSS to style figure and figcaption (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [23:55:47] James_F, bah, vector sets height: 100% on body elements. monobook doesn't. [23:56:27] Krenair: That might do it.