[00:01:53] James_F, I guess we should just shove html, body { height: 100%; } in core's skins/monobook/main.css then [00:03:08] Krenair: Will that break other things? [00:03:18] Krenair: (Though it's Monobook, so…) [00:03:25] heh :) [00:03:29] * James_F laughs. [00:03:56] James_F, it might. But I haven't seen anything that it breaks [00:04:23] I'm guessing if it does break anything it's as well hidden as this bug. [00:04:38] * James_F nods. [00:05:51] ryasmeen_: https://translatewiki.net/w/i.php?title=Special%3AMessageGroupStats&x=D&group=ext-visualeditor-0-all&suppressempty=1#sortable:3=desc [00:07:14] (03PS4) 10Trevor Parscal: Redesign template parameter pages to be more space efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115548 [00:07:45] (03CR) 10jenkins-bot: [V: 04-1] Redesign template parameter pages to be more space efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115548 (owner: 10Trevor Parscal) [00:07:49] James_F, using this.$clippableContainer.innerHeight() || this.$clippableContainer.parent().parent().innerHeight() might also work [00:07:52] James_F, I think it would be best if TrevorParscal or another one of the experts on this sort of thing does any of the changes though [00:07:54] (03PS1) 10Trevor Parscal: Use template name as dialog title whenever possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116006 [00:08:11] (03PS1) 10Trevor Parscal: Move parameter adding to a placeholder page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116007 [00:08:22] (03CR) 10jenkins-bot: [V: 04-1] Use template name as dialog title whenever possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116006 (owner: 10Trevor Parscal) [00:08:38] (03CR) 10jenkins-bot: [V: 04-1] Move parameter adding to a placeholder page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116007 (owner: 10Trevor Parscal) [00:09:06] Krenair: Hmm. [00:09:06] (03PS1) 10Trevor Parscal: Cleanup page class names and comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116009 [00:09:16] (03PS1) 10Trevor Parscal: Cleanup dialog properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116010 [00:09:37] (03CR) 10jenkins-bot: [V: 04-1] Cleanup page class names and comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116009 (owner: 10Trevor Parscal) [00:09:46] (03CR) 10jenkins-bot: [V: 04-1] Cleanup dialog properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116010 (owner: 10Trevor Parscal) [00:10:42] that code change I considered above probably breaks stuff by assuming .parent().parent() will have the relevant height. [00:10:43] (03PS1) 10Trevor Parscal: Fix off-by-one error in TransclusionModel when moving items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116011 [00:11:00] (03PS1) 10Trevor Parscal: Use small option for template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116012 [00:11:11] (03CR) 10jenkins-bot: [V: 04-1] Fix off-by-one error in TransclusionModel when moving items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116011 (owner: 10Trevor Parscal) [00:11:14] (03PS1) 10Trevor Parscal: Prevent superfluous setPage calls by introducing a lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116013 [00:11:27] (03CR) 10jenkins-bot: [V: 04-1] Use small option for template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116012 (owner: 10Trevor Parscal) [00:11:42] (03CR) 10jenkins-bot: [V: 04-1] Prevent superfluous setPage calls by introducing a lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116013 (owner: 10Trevor Parscal) [00:13:06] What's up with jenkins-bot? [00:13:19] I dunno [00:13:27] There are...issues [00:13:35] 00:08:21 stderr: fatal: reference is not a tree: 49e352be16b18723e7e0eac15805422d7aa063fe [00:13:35] 00:08:21 Unable to checkout '49e352be16b18723e7e0eac15805422d7aa063fe' in submodule path 'lib/ve' [00:13:37] is the error given [00:13:56] Eff. [00:13:59] That's because Trevor's pulling commits that aren't in gerrit yet, I think. [00:14:04] Oh. [00:14:06] Well then good [00:14:12] Yay for submodules. [00:31:51] (03CR) 10Jforrester: [C: 031] "All issues now reported fixed; Timo, do you want to merge?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [00:54:34] (03PS7) 10Trevor Parscal: Add documentation for -1 tabIndex option, which disables tab indexing [oojs/ui] - 10https://gerrit.wikimedia.org/r/115536 [00:54:45] (03PS6) 10Trevor Parscal: Manage active state of BookletLayout pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/115537 [00:54:52] (03PS6) 10Trevor Parscal: Disable vertical scrolling in continuous layout mode [oojs/ui] - 10https://gerrit.wikimedia.org/r/115538 [00:54:57] (03PS4) 10Trevor Parscal: Make text inputs gray when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/115804 [00:55:10] (03CR) 10Jforrester: [C: 032] Make text inputs gray when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/115804 (owner: 10Trevor Parscal) [00:55:22] (03CR) 10Jforrester: [C: 032] Disable vertical scrolling in continuous layout mode [oojs/ui] - 10https://gerrit.wikimedia.org/r/115538 (owner: 10Trevor Parscal) [00:55:34] (03CR) 10Jforrester: [C: 032] Manage active state of BookletLayout pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/115537 (owner: 10Trevor Parscal) [00:55:54] (03CR) 10Jforrester: [C: 032] Add documentation for -1 tabIndex option, which disables tab indexing [oojs/ui] - 10https://gerrit.wikimedia.org/r/115536 (owner: 10Trevor Parscal) [00:56:22] (03PS2) 10Jforrester: Refactor OutlineControlsWidget, add remove button [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 (owner: 10Trevor Parscal) [00:56:25] (03PS3) 10Trevor Parscal: Refactor OutlineControlsWidget, add remove button [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 [01:03:02] Krenair: could you write a ClippableElement patch and I will take a look at it? [01:05:27] TrevorParscal, the only idea I had for modifying that was using "this.$clippableContainer.innerHeight() || this.$clippableContainer.parent().parent().innerHeight()" instead of just this.$clippableContainer.innerHeight(), but that would probably break something... [01:06:19] Krinklee: Hey, we had a bit of a Jenkins hiccup while you were out, if you have time to help diagnose mwext-FundraisingChart-.* that would be awesome [01:06:26] You can see wikitech-l e.g [01:06:27] . [01:07:10] Krenair: that sounds like a strong maybe [01:07:38] rdwrer: I suspect that Krinklee is a false-connect from the bouncer… [01:08:00] Ah. [01:08:08] A less-likely-to-break-stuff idea is to simply shove "html, body { height: 100%; }" in core's skins/monobook/main.css [01:08:09] rdwrer: He said he was going to bed at roughly-normal AMS time. [01:08:15] Well, fine then [01:08:18] rdwrer: Sorry. [01:08:20] Grumble grumble [01:08:30] James_F: Aren't your peeps all coming into town soon? [01:08:39] rdwrer: 3 weeks' time. [01:08:43] Oh, wow [01:08:45] 'kay [01:08:49] rdwrer: Sorry. [01:08:51] (03PS4) 10Mooeypoo: Use CSS to style figure and figcaption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 [01:09:20] rdwrer: Also, for three weeks and *in* three weeks. [01:09:20] *shrug* no skin off my back [01:10:41] Krenair: well, I would prefer to make OOUI more compatible than that if possible [01:11:07] James_F, the plot thickens. 'none' and 'framed' don't have default, right? [01:11:09] Will .parent().parent() work for link inspector triggered inside dialogs? [01:11:17] frameless does... ? [01:11:19] i am so confused. [01:11:48] James_F: we will need to find out [01:12:17] I don't have enough available RAM to fire up a JS/CSS instance in my brain right now [01:12:17] mooeypoo: Exactly. "Default" applies to thumb and frameless, and not frame and none (which just take full size); border applies to frameless and none, but not the other two. [01:12:27] ok. [01:12:28] TrevorParscal: Lazy. :-P [01:12:31] working on adjusting now. [01:15:14] fine... [01:15:28] James_F, this shouldn't make any difference to the link inspector.. [01:19:01] (03PS1) 10Trevor Parscal: Make TransclusionContent inputs full width and autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116032 [01:19:33] (03CR) 10jenkins-bot: [V: 04-1] Make TransclusionContent inputs full width and autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116032 (owner: 10Trevor Parscal) [01:23:33] James_F, are you available for a couple of questions about the fix? I'm close, but there are a few behavior issues I"d like to flush out [01:24:04] or is it flesh out? [01:24:30] ... to figure out. There. [01:26:33] (03PS3) 10Mooeypoo: [wip] Add type 'none' to the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [01:27:53] mooeypoo: Sure! [01:28:07] James_F, turned it into 'wip' so i can figure out the last bits of behavior before it's merged. You can test/see it at work. I need to see what happens to an image that was default thumb (or default frameless) and now becomes "framed" or "basic". The numbers turn "real" (so no default possible) but values are of default. Should I preserve the original image dimensions? [01:28:56] mooeypoo: If you take a "thumb" with default size and convert to a "basic", it should just lose the data. [01:29:01] another question: right now if an image is thumb and you set 0x0 the dimensions turn default. What do I do in this case for frameless? I can store the original domensions of the *image* (which is, technically its "default") [01:29:13] mooeypoo: If you take a "thumb" with *custom* size and convert to a "basic", it should probably retain the size. [01:29:24] mooeypoo: I think? [01:29:49] this *should* work [01:29:50] the other way around is the tricky one [01:29:59] in terms of UX, what the user sees in the widget [01:30:18] (03PS2) 10Trevor Parscal: Move parameter adding to a placeholder page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116007 [01:30:39] (03PS2) 10Trevor Parscal: Cleanup page class names and comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116009 [01:30:42] (03PS2) 10Trevor Parscal: Cleanup dialog properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116010 [01:30:45] (03PS2) 10Trevor Parscal: Fix off-by-one error in TransclusionModel when moving items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116011 [01:30:48] (03CR) 10jenkins-bot: [V: 04-1] Move parameter adding to a placeholder page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116007 (owner: 10Trevor Parscal) [01:30:50] (03PS2) 10Trevor Parscal: Use small option for template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116012 [01:30:52] (03PS2) 10Trevor Parscal: Prevent superfluous setPage calls by introducing a lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116013 [01:30:54] (03PS2) 10Trevor Parscal: Make TransclusionContent inputs full width and autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116032 [01:31:08] (03CR) 10jenkins-bot: [V: 04-1] Cleanup page class names and comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116009 (owner: 10Trevor Parscal) [01:31:22] mooeypoo: OK… [01:31:27] (03CR) 10jenkins-bot: [V: 04-1] Cleanup dialog properties [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116010 (owner: 10Trevor Parscal) [01:31:37] (03CR) 10jenkins-bot: [V: 04-1] Fix off-by-one error in TransclusionModel when moving items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116011 (owner: 10Trevor Parscal) [01:31:44] mooeypoo: I think the widgets should always be present, but be disabled when inappropriate. [01:31:44] James_F, it's the game of "which one is default" that i need to work on. "default" as in 'don't show size explicitly'. For thumb/frameless it's defined in config. For the rest, it's their original file size. So, do I show this in the media widget too? or just settle on it for the wikitext? what should the user see when they convert from thumb(default) to "basic" or "frame" [01:31:48] (03CR) 10jenkins-bot: [V: 04-1] Use small option for template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116012 (owner: 10Trevor Parscal) [01:32:04] (03CR) 10jenkins-bot: [V: 04-1] Prevent superfluous setPage calls by introducing a lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116013 (owner: 10Trevor Parscal) [01:32:05] mooeypoo: Rather than things animating in and out of the dialog. [01:32:18] (03CR) 10jenkins-bot: [V: 04-1] Make TransclusionContent inputs full width and autosize [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116032 (owner: 10Trevor Parscal) [01:32:23] ah, but it *is* appropriate, you can change the size. The question is what starting-dimensions you go with? [01:32:54] Inappropriate isn't just type, it's also options. [01:33:25] I'm a little confused. [01:34:17] oh, I think I was unclear: when I said 'don't show size explicitly' I meant *in wikitext*. [01:34:24] Ah, right. [01:34:26] Yes, totally. [01:34:42] so, "default" (no size in wikitext) is different for thumb/frameless AND for basic/framed/border ,etc. [01:35:11] if we start with a default thumb, we get the widget to show placeholders with the wiki's default size [01:35:33] Yes. [01:35:39] (But border is a flag, not a type.) [01:35:58] mooeypoo: my only point is that a checkbox is not something that should expand/contract an area on the screen [01:36:05] ah, well, we'll need to get that out to another select, then [01:36:18] it's not what the user expects to happen, they expect the box to be ticked/unticked and that's about it [01:36:27] if i change that image now to 'basic'... what *numbers* should appear in the size widget? the so-called-default (the image's full size) [01:36:34] or some other value? [01:36:34] so, if we want to do some progressive disclosure we need a different control [01:36:52] something that makes it clear that it will expand/contract as well as enable/disable [01:37:00] TrevorParscal, nothing is removed from the dialog though [01:37:06] things just get enabled or disabled [01:37:16] Standard insert is type: thumb, size: default, float: default. [01:37:32] This in wikitext terms is [[File:Foo.png|thumb]] [01:37:32] right [01:37:45] I know that's what we do, and are going to continue doing, I'm just saying - I'm open to progressive disclosure to make it less imposing on a user when there are lots of possible controls but only a few enabled ones [01:37:53] Standard basic is type: none, size: default, float: default. [01:37:57] This in wikitext terms is [[File:Foo.png\]] [01:38:03] (Ignore the \.) [01:38:06] but, we need to come up with a well designed affordance for that sort of thing [01:38:11] Yeah. [01:39:03] oh, hm. I think that there's going to be a stage where we will have to admit we are slaves to wikitext... which can be incredibly complex with the options and changing parameters based on flag combinations. [01:39:26] It's a little messy in general, so we might have to figure out how we can try and make it more understandable to users. [01:39:27] Perhaps. [01:40:18] James_F, right, the wikitext is clear. I am trying to see what to do in the UI as we change these flags/types and combinations. [01:41:23] if you have left with type you get block, but without a type it's inline, as is with frameless, unless it's set to no float, and then it's block ---- the whole image wikitext business is confusing by the way it's done. [01:42:28] So making a UI with these rules is going to involve all these combinations too. If you click a certain type with a certain flag, some options turn off or on. I am not sure how "intuitive" it can be when the wikitext isn't at all. [01:43:39] Also, if the "Typography Update" goes through we should revisit our needs. [01:43:48] so the output, ironically, is relatively easy -- the problem is how to respond to changes the user does to images in the UI :p [01:44:46] 'Cos that's going to effectively remove the "frame" option, and make "frameless" and "thumb" differ /only/ in size ability. [01:45:44] If we have that, we'd effectively be able to hide the type entirely – you either want it with caption (thumb / frameless) or without (basic), and if the size is full then frameless, otherwise thumb. [01:45:48] (03CR) 10Catrope: [C: 032] Convert styles to LESS and implement grunt task [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [01:45:49] Yay, simplicity. [01:46:01] (03CR) 10Catrope: [C: 032] Add documentation for -1 tabIndex option, which disables tab indexing [oojs/ui] - 10https://gerrit.wikimedia.org/r/115536 (owner: 10Trevor Parscal) [01:46:02] But confusion for existing wikitext users, of course. [01:46:16] (03Merged) 10jenkins-bot: Convert styles to LESS and implement grunt task [oojs/ui] - 10https://gerrit.wikimedia.org/r/114093 (owner: 10Trevor Parscal) [01:46:18] (03Merged) 10jenkins-bot: Add documentation for -1 tabIndex option, which disables tab indexing [oojs/ui] - 10https://gerrit.wikimedia.org/r/115536 (owner: 10Trevor Parscal) [01:46:20] (03Merged) 10jenkins-bot: Manage active state of BookletLayout pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/115537 (owner: 10Trevor Parscal) [01:46:22] (03Merged) 10jenkins-bot: Disable vertical scrolling in continuous layout mode [oojs/ui] - 10https://gerrit.wikimedia.org/r/115538 (owner: 10Trevor Parscal) [01:46:26] (03Merged) 10jenkins-bot: Make text inputs gray when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/115804 (owner: 10Trevor Parscal) [01:47:03] hah [01:47:16] That would be a little more organized, yeah. [01:47:55] Hm. Okay, for the moment, I think I'm going to treat "no size" (value of 0x0 or coming out of 'default' of thumb, etc) for basic images as their original size [01:48:03] * James_F nods. [01:48:06] which is technically and visually what it is.. [01:48:09] But major changes in wikitext support are outwith our workload. :-) [01:48:12] Yeah. [01:48:34] yeah, no, I'm tryingto make sense of how to not make the user's brain drip out of their ears while trying to set images up :P [02:05:58] James_F, so, considering the fact there technically *is* a 'default' size for non thumbs (that is, they 'default' to their original size, and I show it in the widget) do you still want me to disable the option? Maybe I should keep it open for users to set it if they want to (they will see the values, which are the original image's values) [02:06:00] does this make sense? [02:13:07] (03PS4) 10Jforrester: [UNMERGED] Update OOjs UI to v0.1.0-pre (0198123819) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115539 (owner: 10Trevor Parscal) [02:13:09] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (96ae071da9) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116039 [02:20:10] (03CR) 10Jforrester: "Equivalent to pull through for MW-core is If55f8a78f410f35e." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116039 (owner: 10Jforrester) [02:28:04] mooeypoo: I think having a "default" option and a "full size" option which both do the same thing would be confusing. [02:28:26] mooeypoo: (Also, maybe we should move "make full size" into the same group as the other two options, at least for now?) [02:40:01] (03PS6) 10Jforrester: [UNMERGED] Update core (If994572) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 (owner: 10Trevor Parscal) [02:40:08] (03CR) 10jenkins-bot: [V: 04-1] [UNMERGED] Update core (If994572) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 (owner: 10Trevor Parscal) [02:53:51] (03PS4) 10Mooeypoo: [wip] Add type 'none' to the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [02:55:04] James_F|Away, I'm not sure I can disable only 1 option within the select. I created a version that should do what we discussed, I think it works well. IT also falls back to "default" (whatever the default is) when the size widget values are either 0x0 or just erased. [03:05:14] (03PS5) 10Mooeypoo: [wip] Add type 'none' to the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [13:24:03] (03CR) 10Esanders: "Captions overlaps borders (chrome): http://i.imgur.com/HJ8DCgI.png" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [13:26:49] (03CR) 10Esanders: [C: 04-1] "also see screenshot in previous comment" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [15:56:13] (03PS1) 10Esanders: Blur the surface when a dialog is opened [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116114 [16:06:48] (03PS1) 10Esanders: Don't show phantoms for hidden protected items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116116 [16:37:14] Hai all, was just poking around with visual editor and wanted to inquire as to whether this was a recommended build for usage [16:43:09] Ulfr_: Hey; master is generally best. [16:43:13] Ulfr_: But it depends on what context you want to use it in. [16:43:36] James_F: My boss has an attention span limited to one shot with new things [16:43:49] I'd *really* like to be able to use this so people stop derping with wikicode [16:44:34] (03PS1) 10Esanders: Move relocatable mixin to MWInlineImage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116118 [16:45:27] (03PS14) 10Jforrester: [WIP] Create remaining meta items in DM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 [16:45:43] Ulfr_: Ha. Internal MediaWiki instance? [16:45:54] James_F: Sorta, it's a medical wiki that doctors work on [16:46:38] Ulfr_: Right. It's a little tricky to get VisualEditor set up – you'll need latest MediaWiki (1.22.x), and to install Parsoid as a (nodejs) service. [16:46:54] Ulfr_: But if you've got both of those, it should Just Work™. [16:47:01] James_F: Yeah, I did that a couple months ago but I recall encountering problems with elemnts and such [16:47:14] I'm quite familiar with mediawiki's Just Work, and the required finagling [16:47:15] Ulfr_: Ah, do you have any interesting extensions? That might be a problem. [16:47:22] * James_F grins. [16:47:23] I'm just wondering if the current version is fairly stable/usable [16:47:39] James_F: I *really* don't want to talk about some of the stuff I have to keep running [16:47:41] * Ulfr_ shudders [16:47:43] Yes, it's fairly stable, but if you've only got one shot it might be worth post-poning. [16:47:46] My sympathies. [16:48:13] Thanks :) [16:48:32] I'm not saying it has to be feature complete or anything, just able to edit consistently without having to go back in and fix the wikicode [16:48:39] (03CR) 10Jforrester: "What do you mean it doesn't work? It's been working for a year now…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116118 (owner: 10Esanders) [16:48:52] Oh, that's the case now, yes. [16:49:21] We've got exceedingly low corruption of wikitext in actual use. [16:49:29] Still things to improve, of course. [16:49:50] But in practice the main blocker is familiarity (and browser support). [16:50:12] Welp, if it gets my users to stop putting pipes in template values [16:50:19] I will educate the hell out of my users [16:50:37] Well, we don't actually defensively code around that right now. [16:51:07] (Because template values are arbitrary wikitext, so you might well actually be doing {{echo|Foo {{echo|Bar}}}}.) [16:51:19] James_F: But that's predictable [16:51:26] You know what isn't predictable? Doctors on computers. [16:51:39] One of the big things coming soon-ish is rich-content editing of parameter values, so it will be a full rich editing surface for each parameter. [16:51:41] * James_F grins. [16:51:53] * Ulfr_ begins salivating [16:52:20] (And typing of parameters, so if you say a parameter is a username we can auto-suggest from the list of users, etc.) [16:52:57] Now you're just teasing me. [16:53:01] :-) [16:53:59] There are some pretty major simplifications to the template and reference interfaces coming in the next two weeks, so if you're just trialling it before deployment it might be worth holding off a tad (or upgrading after a little). [16:54:16] I'll definitely keep that in mind [16:54:39] Not gonna demo it for awhile in any case, mostly because I need to figure out how everything works [16:55:24] For Parsoid, I use three load balanced Frontends to serve content, would it be prudent to have them all have local parsoid instances? or just have one machine running it and let the other two mooch [16:56:47] We use Varnish in front of our Parsoid instances – so have a Parsoid instance on one, and Varnishes on all three? [16:58:01] * Ulfr_ begins googling [17:01:08] James_F: What have you done. [17:02:53] Ulfr_: See https://wikitech.wikimedia.org/wiki/Parsoid#Data_flow and https://wikitech.wikimedia.org/wiki/Parsoid#Caching_and_load_balancing [17:04:11] James_F: I've been too scared to search of an alternative to squid for reverse proxying [17:04:19] and there you go, just dropping one in my lap [17:05:06] Ulfr_: Ha. We've abandoned Squid for Varnish at WMF. It's great. [17:05:20] Ulfr_, are you concerned about performance or availability? [17:05:43] gwicke: I'm terrified of angering squid. [17:06:07] It's mostly I don't really understand how it all works, and every time I poke the bear everything breaks [17:06:12] squid will work just as well; just trying to understand your larger goal [17:06:26] gwicke: I'm whining about an intimidating level of redesigning [17:06:34] this is actually an excellent discovery [17:07:13] Ulfr_, in any case if your goal is perf and you have a lot of volume, then you want one cache and several parsoids [17:08:15] (03Abandoned) 10Esanders: Move relocatable mixin to MWInlineImage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116118 (owner: 10Esanders) [17:08:41] gwicke: Interesting. I think I'm going to go with identical builds so my servers stay identical [17:09:24] I use AWS hosting so it's nice to have templates [17:11:04] I was thinking that it might be feasible to have a little instance that just did parsoid, but varnish changed everything [17:11:43] Ulfr_, I'd run parsoid on a large instance along with other stuff [17:12:07] it uses little memory and single request latency improves with single-thread performance [17:12:27] gwicke: Solid candidate to just plop on with the rest of the stuff on the frontends then [17:12:43] I'd actually be surprised if you needed more than one parsoid instance [17:13:20] our production cluster (24 machines) is running at ~10% while tracking all edits from all wikis [17:13:58] We only get like 400k hits per day, but occasionally a big DDoS hits us and derps the crap out of whatever had the ip at the time, so I like being able to just repoint the IP and then triage [17:14:12] It's less about capacity and more about interchangability [17:14:34] it's a web service, so easy to move around [17:15:00] also, we have a deb now [17:15:05] for varnish? [17:15:12] sadly not yet for varnish [17:15:24] oh, for parsoid? [17:15:35] varnish is packaged of course, but you'll need a lot of custom config [17:15:40] yes, for parsoid [17:15:46] neat. [17:16:10] you can give it a shot: "deb http://parsoid.wmflabs.org:8080/debian wmf-production/" [17:16:14] let's be real, when does actually doing due diligence as far as server admins go not require a lot of custom config [17:16:16] anyone remembers that website checking js and css cross-browser compatibilities? I can't find it [17:16:17] apt-get update && apt-get install parsoid [17:16:56] mooeypoo, caniuse.com? [17:17:05] ah! that. I think. [17:17:15] google had no idea what I'm talking about. [17:17:45] I'm not sure what frightens me more when google [17:17:47] googling* [17:17:55] when google knows what i'm talking about, or when it doesn't [17:18:52] gwicke, i'm checking and answering ed's comments about display:table; looking hackish. This looks somewhat compatible, though? http://caniuse.com/#search=display%3A%20table [17:19:13] mooeypoo, I linked to that in my mail ;) [17:19:27] (03CR) 10Mooeypoo: Use CSS to style figure and figcaption (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [17:19:48] gwicke well. that'll teach me to check the original mail before wrestling with Google. [17:19:49] mooeypoo, it's CSS2 only [17:20:16] (I think I linked, could have just mentioned it & asked you to take my word for it) [17:20:56] I lied, no link [17:21:20] i just checked, yeah. Nevermind, it seems okay. I wonder if there's a better way to do this in CSS3 though. [17:21:37] though it SEEMS to be supported and future supported, at least if I understand the caniuse table right [17:21:39] Google's webkit is irritatingly broken at the moment [17:22:25] mooeypoo, basically only IE6/7 don't handle it well [17:22:34] IE6/7 doesn't handle anything right. [17:22:40] and those can be worked around with JS if absolutely needed later [17:22:57] although by then IE6 will be dead anyway [17:23:01] currently 0.3% [17:23:07] weren't these versions unsupported for a year at least? [17:23:36] yeah, there is even a ms website discouraging their use [17:23:48] yeah I remembered something about those from when I worked in AIP [17:24:12] though for us it was worse; our web system was meant for campuses, who, unfortunately, still live in IE-dinosaur era. [17:24:34] http://www.modern.ie/ie6countdown [17:25:06] wow, China seems to keep it alive [17:25:24] http://www.ie6death.com/ says a bit over 2 months to go [17:26:02] looks random though [17:26:33] I'm pretty happy it works in the modern IE. That's not as obvious as it should be. [17:27:55] gwicke, can you take a look at my 2 explanations in that fix? if i didn't miss anything important, I think I'll use them to rewrite the commit message. [17:29:36] mooeypoo, looks good [17:30:08] not sure what's up with the borders though [17:39:14] gwicke: Sorry to bovver again, but do squid and varnish function the same way? Or is it backwards [17:40:30] (03CR) 10Krinkle: "fixme: Use ve.indexOf instead of $.inArray." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 (owner: 10Trevor Parscal) [17:40:34] Ulfr_, at a very high level they can be used for the same things [17:41:04] (03CR) 10Krinkle: "nevermind." [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 (owner: 10Trevor Parscal) [17:41:18] Krinkle: ? [17:41:19] we heavily used Squid since 2004, but recently switched to Varnish for its better support for customization and focus on the reverse proxy use case [17:42:03] (03CR) 10Jforrester: [C: 032] ve.ui.MediaSizeWidget: Use lowercase types hint for primitive value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115904 (owner: 10Krinkle) [17:42:13] gwicke: Yeah. I'm trying to figure out how things worked with squid so I can connect things up [17:42:24] but I knew this was going to be about as much fun as a bag of hammers. [17:43:25] Ulfr_, for parsoid I'd wait until you are sure you actually need it [17:43:48] varnish is no protection against a DOS [17:44:15] gwicke: No, it's more like it'd be fantastic to actually be able to gather metrics rather than having to guess because squid scares me [17:44:30] (03Merged) 10jenkins-bot: ve.ui.MediaSizeWidget: Use lowercase types hint for primitive value [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115904 (owner: 10Krinkle) [17:45:00] I'll stop being a bother but this is something I've needed to for a long time [17:50:09] Ulfr_: Don't worry about being a bother! [18:00:43] (03PS10) 10Robmoen: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 [18:02:49] (03CR) 10jenkins-bot: [V: 04-1] Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [18:12:29] divec: Holy crap, https://gerrit.wikimedia.org/r/#/c/109693/ is no longer WIP? [18:12:44] divec: How mergeable is it? Either way I'll take a look at it today [18:13:59] could that have counted as RoanKattouw-and-run [18:14:11] roan-and-run. Nickcompleter fail. [18:17:16] mooeypoo: I must be very tired, I don't get the joke :S [18:17:29] RoanKattouw, it's okay, it was a lame joke. [18:18:26] (03PS1) 10Alex Monk: Make new category suggestion section for hidden categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116132 [18:18:36] RoanKattouw: It's mergeable now, I understand. [18:18:44] OK [18:18:47] Well the code looks good [18:18:55] RoanKattouw: Also, it's the second time it's been de-WIP'ed, remember. :-) [18:18:58] I'm gonna submit a small documentation tweak, give it a spin locally and then merge it [18:20:20] RoanKattouw: Or… come in? :-) [18:20:35] RoanKattouw: Karen presumably wants to be introduced to me, right? Right? [18:21:38] ^ in that patch I should probably check this.categoryHiddenStatus before running the extra query, and if we don't need to query anything then don't... but that leaves us with data in a different format which is messy [18:24:15] James_F|Away: Yeah I'm coming in in a bit [18:29:02] (03PS8) 10Catrope: Fix handleEnter in nodes that don't split [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 (owner: 10Divec) [18:29:22] (03CR) 10Catrope: [C: 032] Fix handleEnter in nodes that don't split [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 (owner: 10Divec) [18:30:07] divec: (Never mind, I just went ahead and merged it, James said he understood it was mergeable and everything looked fine to me) [18:30:28] (03Merged) 10jenkins-bot: Fix handleEnter in nodes that don't split [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109693 (owner: 10Divec) [18:35:11] (03CR) 10Alex Monk: Make new category suggestion section for hidden categories (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116132 (owner: 10Alex Monk) [18:37:00] OK coming into the office now [18:51:37] James_F: I have defeated the squid and it is good. [18:52:10] James_F: question re parsoid edit caching change: what testing has this gone through? [18:54:41] greg-g, that change basically switches on HTTP request to parsoid for the long tail of inactive wikis [18:55:55] so it's not really a code change more of a load change? [18:55:59] those wikis are already available in parsoid through the public API [18:56:25] I don't think that there will be any noticeable load change [18:56:40] all the major wikipedias are already enabled [18:57:02] James_F, what's the count currently? [18:57:21] gwicke: It's from ~300 to ~700. [18:57:24] we are at around 10 to 15% on the parsoid cluster [18:57:43] gwicke: But in terms of edit load it's from ~85% to ~100%, I understand. [18:57:44] and this includes Kiwix spidering full dumps etc [18:58:05] James_F: so, your response to Erik asking "has this gone through testing" would be? [18:58:15] VE edits would require VE to be enabled there, which is not the case afaik [18:58:26] (he asked me, and I couldn't give an answer :) ) [18:58:50] greg-g, it has not gone through testing with a replica of the production setup [18:59:13] nothing has [18:59:16] heh [18:59:34] we deploy much more interesting stuff all the time [19:00:55] greg-g, you can sell it as 'this will prime the caches for smaller projects so that Kiwix dumps on them are even less noticeable' [19:01:12] not that we notice them now, mind you [19:01:17] right [19:01:41] that'd be a good way of describing the change (not "we do more interesting things all the time" ;) ) [19:01:59] both is true though [19:02:15] one is useful one isn't :) [19:02:39] the main effect is that it saves us time by simplifying the config [19:04:00] The main motivation for the config simplification is Flow [19:04:16] they tried to enable on meta and found there was no Parsoid there, oops :) [19:04:53] (which we fixed for meta specifically, but we're now fixing ahead of time for all other wikis) [19:05:39] it's also nice for gadgets on smaller projects to get cache hits [19:15:24] (03CR) 10Catrope: [C: 04-1] Refactor OutlineControlsWidget, add remove button (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 (owner: 10Trevor Parscal) [19:15:33] gwicke, in parsoid, images with mw-default-size directly from wikitext seem to render with width/height that isn't the wiki default. Is this a bug, or on purpose? I saw a couple of bug reports discussing something similar but I'm a bit confused. [19:15:55] edsanders:https://bugzilla.wikimedia.org/show_bug.cgi?id=62031 and https://bugzilla.wikimedia.org/show_bug.cgi?id=62022 - these are the two new bugs reported yesterday [19:15:58] right now I'm fixing the size in the data model if it's default to fit the wiki default size, but it seems a bit backwards. Shouldn't we get the size already from Parsoid? [19:16:44] mooeypoo, we chose the wikipedia default rather than the mediawiki default [19:16:45] (03CR) 10Catrope: [C: 032] Don't show phantoms for hidden protected items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116116 (owner: 10Esanders) [19:16:56] as in most-large-wikipedias [19:17:25] the reasoning is that we want to avoid re-loading all thumbs when switching to VE [19:17:43] :| This package gave my server a tummy ache [19:17:46] (03Merged) 10jenkins-bot: Don't show phantoms for hidden protected items [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116116 (owner: 10Esanders) [19:17:47] the parsoid one [19:17:48] >> [19:17:50] gwicke, that means I have to force wiki-default in data model, then. It's a bit backwards, I can only do that in the dm by recalculating the aspect ratio (yet again) but this time from the given image, which, technically, is not its original size. [19:18:14] gwicke, but that means the images look a certain size in view and a bigger size in edit (unless I force them) [19:18:45] Ulfr_, so far we only heard of successes [19:18:55] gwicke: It executes! [19:19:03] the calculation is done over a recalculated size.. isn't that redundant? [19:19:16] But I apparently am running the unclean version of ubuntu server, 12.04, so everything's kinda wonked [19:19:48] mooeypoo, we were shooting for the same size in view & edit [19:20:11] IMO you should assume that we are serving you the wiki default size [19:20:25] but it's not :\ [19:20:38] my wiki has 180px as default. I get the images as 220 [19:20:51] ahh, *your* wiki [19:20:56] (03CR) 10Catrope: [C: 032] Blur the surface when a dialog is opened [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116114 (owner: 10Esanders) [19:21:06] well, I did that so I can test with different local wiki settings. [19:21:19] Isn't that the point of local wiki settings? [19:21:21] mooeypoo, there is no api that exposes default thumb sizes yet, so we just picked the one used in wikpedias [19:21:42] exposing that info is on our todo [19:21:55] (03Merged) 10jenkins-bot: Blur the surface when a dialog is opened [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116114 (owner: 10Esanders) [19:22:02] gwicke, I use this: $wgThumbLimits[ $wgDefaultUserOptions['thumbsize'] ] [19:22:15] Oh, hey now. I out the package [19:22:19] mooeypoo: right, in PHP [19:22:21] to get the wiki default thumbnail size. All new thumbs (and thumbs that have no size from wikitext) appear with that constraint. [19:22:22] * Ulfr_ notes the problem was between the keyboard and chair [19:22:32] gwicke, yeah, I send it to js later. No can do on your side? [19:22:47] mooeypoo: no API yet, as I said [19:22:59] we can add it to siteinfo [19:23:13] ah, yes, no it doesn't appear in the api. I forgot that annoying detail. [19:23:21] ok, so for now I'll recalculate in dm [19:23:31] RoanKattouw, it will make your math-spidey-senses tingle, I warn. [19:23:36] mooeypoo, for wikipedia it's better if you don't [19:23:46] also in the longer term you should not [19:24:25] Well, I am not sure how else we can do this. The images are rendered in the wrong dimensions. Not all wikis use the 220 size, as I understood from the bug report(s) about default size [19:24:45] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/112837/ [19:24:46] James_F, fyi [19:24:57] as I said, most large wikipedias *are* using 220px [19:25:14] if you are rescaling to the wiki's default then that's fine [19:25:21] yes, that's what I am doing. [19:25:27] (but you should not do so in the longer term) [19:25:47] re-scaling to MW default would be wrong [19:25:53] Why? [19:26:07] MW default it 180px [19:26:13] most wikipedias are using 220px [19:26:17] But you can change it in the wiki settings. [19:26:35] right, in which case it is the wiki's setting and no longer MW default [19:26:57] but aren't they reflected in the $wgDefaultUserOptions[ 'thumbsize' ] ? [19:27:35] what is they? [19:27:42] (03PS1) 10Jforrester: Add tooltip to page options menu widget in the toolbar [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116145 [19:27:51] Wikipedia's default 220px thumbnail dimensions. [19:27:53] there is a MW default that you can override in LocalSettings [19:28:00] when I ask for $wgThumbLimits[ $wgDefaultUserOptions['thumbsize'] ] that's what I'll get. No? [19:28:02] using the actually configured value is fine [19:28:14] but using the MW default while ignoring the actually configured value is wrong [19:28:42] you'll get the actually configured value that way [19:28:45] What mooeypoo is using should be the actually configured value [19:28:58] that it should, but now I'm re-checking the docs just to make sure. [19:29:18] you literally change that global variable in LocalSettings [19:29:18] yep: https://www.mediawiki.org/wiki/Manual:$wgDefaultUserOptions [19:29:57] 'thumbsize' overrides the mw default with local defaults. [19:30:12] it uses an integer value of the index for the $wgThumbLimits array [19:30:29] which is why I get the dimension value with the nested $wgThumbLimits[ $wgDefaultUserOptions['thumbsize'] ] [19:30:49] mooeypoo, that's fine [19:31:20] I'm just a bit concerned about the fact we're rescaling images based on aspect ratio that was calculated from an already calculated value from Parsoid [19:31:21] we should move that code to the api really [19:31:30] we really should :\ [19:32:06] mooeypoo, you can always do a new imageinfo call to get the new correct aspect ratio [19:32:26] but IMO it makes more sense to not do anything like that in VE [19:32:33] RoanKattouw, I would have left the calculation for the CE, so it could be based on "original dimensions" (which we ask for the API) *but* that would leave the dm without dimensions, or with wrong dimensions, or with dimensions that are not the same as the CE, which causes all sorts of problems. [19:32:34] and just do it in Parsoid instead [19:32:58] yeah, that's what I think too, but since it doesn't exist in the API, it's a problem. [19:33:04] (03PS4) 10Jforrester: Refactor OutlineControlsWidget, add remove button [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 (owner: 10Trevor Parscal) [19:33:12] (03CR) 10Jforrester: Refactor OutlineControlsWidget, add remove button (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 (owner: 10Trevor Parscal) [19:33:27] for the moment, the closest thing to a working consistent behavior would be dealing with it on our end in the dm. But it's far from perfect. Would be much better if we can get the images already scaled to the local default [19:34:10] mooeypoo, I bumped the prio of https://bugzilla.wikimedia.org/show_bug.cgi?id=43336 [19:34:55] oh awesome [19:34:58] thansk gwicke [19:35:50] i saw a couple of other bug reports related to default size, it seems to be a hot topic [19:36:28] in parsoid that's the only one about thumb sizes [19:37:10] there is another about sound icons: https://bugzilla.wikimedia.org/show_bug.cgi?id=49689 [19:37:57] cscott is working on it [19:38:28] yeah I saw that too... weird, I could've sworn I saw another one. I think I even posted it here a couple of days ago with a question. [19:38:43] anyways, not important, I may be mixing two unrelated discussions (or a closed bug) [19:43:07] (03PS6) 10Mooeypoo: [wip] Add type 'none' to the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [19:45:03] oh, foo, I forgot to add the second bug this fixes. [19:46:25] (03PS7) 10Mooeypoo: [wip] Add type 'none' to the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [20:03:04] (03CR) 10Catrope: [C: 04-1] [UNMERGED] Update core (If994572) (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 (owner: 10Trevor Parscal) [20:04:21] (03CR) 10Catrope: [C: 031] Cleanup duplication in TransclusionDialog classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115545 (owner: 10Trevor Parscal) [20:05:20] (03CR) 10Catrope: [C: 032] Cleanup duplication in TransclusionDialog classes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115545 (owner: 10Trevor Parscal) [20:05:25] (03CR) 10Catrope: [C: 032] Use label of first template as Template dialog title [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115546 (owner: 10Trevor Parscal) [20:05:42] (03CR) 10Catrope: [C: 032] Remove outline from TemplateDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115547 (owner: 10Trevor Parscal) [20:11:22] (03CR) 10Catrope: [C: 032] Redesign template parameter pages to be more space efficient [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115548 (owner: 10Trevor Parscal) [20:12:08] RoanKattouw: Can we shoot for monday? I think I'm going to have a really long lunch [20:13:07] We are sorta celebrating my birthday early i guess [20:13:38] (03CR) 10Catrope: [C: 04-1] Cleanup duplication in TransclusionDialog classes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115545 (owner: 10Trevor Parscal) [20:13:59] (03CR) 10Catrope: Cleanup duplication in TransclusionDialog classes (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115545 (owner: 10Trevor Parscal) [20:14:20] (03CR) 10Catrope: [C: 031] "Should this be combined with https://gerrit.wikimedia.org/r/#/c/115546 ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116006 (owner: 10Trevor Parscal) [20:14:26] rmoen: OK that's fine [20:14:42] As you may have heard I don't know if I'm still gonna be useful this afternoon anyway [20:14:47] I went to bed at 6 [20:15:03] And I was still adrenalined-out so I didn't sleep until 6:30 [20:15:43] rmoen: I deleted our appointment for today, could you self-schedule a new one for Monday? [20:23:13] (03CR) 10Catrope: [UNMERGED] Update core (If994572) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115543 (owner: 10Trevor Parscal) [20:29:10] (03CR) 10Catrope: [C: 04-1] Move parameter adding to a placeholder page (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116007 (owner: 10Trevor Parscal) [20:29:48] (03CR) 10Catrope: [C: 032] "lol, good catch" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116009 (owner: 10Trevor Parscal) [22:41:57] * edsanders despairs at ce [22:42:46] * edsanders goes to check what ve.ce.Surface#getNearestCorrectOffset is supposed to return ... nothing apparently [22:43:43] edsanders: Great. :-( [23:07:32] (03PS8) 10Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [23:07:50] Oh this fix is getting better and better.... [23:08:49] (03CR) 10jenkins-bot: [V: 04-1] [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [23:09:19] :\ [23:09:53] hm is jenkins off its rocker again? [23:11:53] (03PS1) 10Esanders: Don't allow getNearestCorrectOffset to return -1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116172 [23:25:47] Still, maybe [23:26:53] mooeypoo: TypeError: 'undefined' is not an object (evaluating 'classes.indexOf') [23:27:01] mooeypoo: QUnit test failure, not a Jenkins problem [23:28:21] hmm [23:28:38] Oh, grunt doesn't do qunit, apparently. [23:29:08] mooeypoo: Stand-alone tests are run by grunt, but not MW tests. [23:29:15] ahh [23:29:28] mooeypoo: For those you need to go to [[Special:JavaScriptTests/qunit]] on your development wiki. [23:30:11] rdwrer, where did you see the TypeError? [23:30:18] oh, I see [23:41:06] (03PS9) 10Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [23:55:16] mooeypoo: James_F mentioned you're working with Gabriel to push VE's CSS for images into Parsoid. Yay, since Flow renders Parsoid HTML directly so figures look wrong. Is there a tracking bug for the work? [23:55:34] (03CR) 10Catrope: [C: 032] Don't allow getNearestCorrectOffset to return -1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116172 (owner: 10Esanders) [23:56:04] spagewmf, e oh, I'm not sure there's a tracking bug for it. There's a commit underway, though [23:56:25] spagewmf, https://gerrit.wikimedia.org/r/#/c/115533/ [23:56:38] (03Merged) 10jenkins-bot: Don't allow getNearestCorrectOffset to return -1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116172 (owner: 10Esanders) [23:58:50] (03CR) 10Catrope: [C: 032] Refactor OutlineControlsWidget, add remove button [oojs/ui] - 10https://gerrit.wikimedia.org/r/116001 (owner: 10Trevor Parscal)