[11:43:54] (03PS1) 10Esanders: Use align icons in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 [11:44:11] (03CR) 10Esanders: "http://i.imgur.com/hTqnsG0.png" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders) [11:44:26] (03CR) 10jenkins-bot: [V: 04-1] Use align icons in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders) [12:40:28] (03PS1) 10Esanders: Image frame icons [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 [12:41:13] (03CR) 10Esanders: "http://i.imgur.com/DaSY7RD.png" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders) [13:16:40] (03PS1) 10Esanders: Increase keyboard shortcut height hack to work in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116479 [14:54:45] (03PS1) 10Esanders: Consistency in test header comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116484 [14:54:47] (03PS1) 10Esanders: Remove MW-specific config and genericise tests in ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116485 [14:54:52] (03PS1) 10Esanders: Consistency in DM MW test naming and comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116486 [14:54:54] (03PS1) 10Esanders: MW configuration for modelRegistry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116487 [14:56:04] (03CR) 10jenkins-bot: [V: 04-1] MW configuration for modelRegistry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116487 (owner: 10Esanders) [14:58:14] (03CR) 10Esanders: [C: 031] "Not sure if this is necessarily the right approach but we need to majorly refactor protected/focusable/relocatable/clickable in the near f" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen) [15:44:20] (03CR) 10Esanders: "Are you saying we shouldn't be using these icons?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders) [16:27:49] (03CR) 10Ladsgroup: "you should use a better icon that stands for italic version of a text" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders) [16:50:35] (03PS1) 10Esanders: Changeable UI language in SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116497 [17:00:11] (03CR) 10Esanders: "What do you mean by "better"? Do you mean this character but bolder, or a different character?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders) [17:09:47] Morning. [17:11:04] (03CR) 10Jforrester: "This looks a little ugly. Also, isn't most of the point of the icons to not need descriptions?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders) [17:21:19] (03CR) 10Ladsgroup: ""کج" in Persian means italic, so Don't change the character, but bolder" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders) [17:24:01] (03CR) 10Jforrester: "* You don't have an icon for the basic image type" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders) [17:45:18] (03CR) 10Mooeypoo: "We should discuss the behavior of the border and frame options for the user, as well as several other wikitext-dependent behaviors that ca" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders) [17:45:49] James_F, can we set up a hangout to discuss image behavior stuff? will you have time today? [17:48:03] mooeypoo: Sure. [17:48:29] mooeypoo: How does 11:00 (14:00 for you) work? [17:49:04] I'm free all day 'till 7pm my time tonight [17:49:07] so that's perfect [17:49:07] * Elitre waves [17:49:14] heya Elitre [17:49:27] OK. :-) [17:49:29] Hey Elitre. [17:49:35] thanks James_F for fixing a bug before I could actually report it back at the feedback page :D [17:49:46] James_F, I've added a 'border' flag to the superfix, and then realized that it's not quite just a flag, and that we should really.. discuss. So, yeah. That'll be good :D [17:50:14] at the same time, /me shows fist at James_F who made my inbox unusable this weekend. [17:50:39] haha [17:50:51] Elitre: Sorry. :-( [17:51:10] james_F: was yours in the same condition? [17:51:44] Elitre: No, because I was the person that initiated the change (but I'm copied on all ~ 3000 VisualEditor tickets in Bugzilla). [17:52:17] that's what filters are for [17:52:22] life savers. [17:52:26] True. [17:52:28] well... inbox-savers. [17:52:45] Which, I guess, is related when you work life is tied to your inbox. [17:53:58] I'm too lazy to setup a work-only bugzilla account. [17:54:47] Elitre, use the + feature [17:54:54] yourmail+tag@gmail.com [17:54:57] or a filter [17:59:22] (the filter wouldn't probably work because my gmail had a weird bug years ago - long story short, everything ends up archived as soon as it arrives, otherwise it won't get downloaded. so I never really use the inbox, I have to check All messages anyway.) [18:18:42] mooeypoo, http://i.imgur.com/HJ8DCgI.png on https://gerrit.wikimedia.org/r/#/c/115533 [18:25:14] edsanders, gah, thanks [18:25:23] edsanders, is this on chrome? [18:27:33] err quick reboot, brb [18:27:40] yes [19:15:34] (03CR) 10Catrope: [C: 032] Consistency in test header comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116484 (owner: 10Esanders) [19:16:41] (03Merged) 10jenkins-bot: Consistency in test header comments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116484 (owner: 10Esanders) [19:21:52] (03CR) 10Catrope: [C: 032] Remove MW-specific config and genericise tests in ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116485 (owner: 10Esanders) [19:22:46] (03CR) 10Catrope: [C: 032] Consistency in DM MW test naming and comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116486 (owner: 10Esanders) [19:22:56] (03Merged) 10jenkins-bot: Remove MW-specific config and genericise tests in ModelRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116485 (owner: 10Esanders) [19:24:02] (03Merged) 10jenkins-bot: Consistency in DM MW test naming and comments [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116486 (owner: 10Esanders) [19:26:05] (03PS2) 10Jforrester: MW configuration for modelRegistry [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116487 (owner: 10Esanders) [19:30:03] RoanKattouw: Review me: https://gerrit.wikimedia.org/r/#/c/116487/ [19:31:07] (03PS3) 10Catrope: Update VE core submodule to master (74be717) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116487 (owner: 10Esanders) [19:33:14] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (74be717) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116487 (owner: 10Esanders) [19:35:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (74be717) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116487 (owner: 10Esanders) [19:43:37] James_F, err, even after the hangout's off, it takes forever in my comp to get the size widget to update. Can you test to see if you have the same problem? I think it's local :\ [19:48:49] mooeypoo: Seems fine here, I think? [19:49:21] I'm testing now in my laptop's vm but I didn't update it for a while so it's crying for attention. I'm pretty sure it's a local issue in my computer. [20:09:16] ok, it doesn't work for me on my VM either. I"m stumped. RoanKattouw can I bug you about help with this very very weird bug? [20:10:13] no console errors.. no indication of anything, everything works fine except the media size widget doesn't get focused. [20:11:56] in master, too. what is going on... [20:14:30] (03CR) 10Catrope: [C: 032] Increase keyboard shortcut height hack to work in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116479 (owner: 10Esanders) [20:15:32] (03Merged) 10jenkins-bot: Increase keyboard shortcut height hack to work in FF [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116479 (owner: 10Esanders) [20:20:59] https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-visualeditor-0-all&language=fy&filter=translated&action=translate [20:21:04] https://translatewiki.net/w/i.php?title=Special%3AMessageGroupStats&x=D&group=ext-visualeditor-0-all#sortable:3=desc [20:22:03] (03CR) 10Catrope: [C: 032] "Dude this is awesome" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116497 (owner: 10Esanders) [20:23:06] (03Merged) 10jenkins-bot: Changeable UI language in SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116497 (owner: 10Esanders) [20:40:23] (03PS2) 10Esanders: Bold/italic icons for fa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 [20:40:25] (03CR) 10jenkins-bot: [V: 04-1] Bold/italic icons for fa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders) [20:48:35] (03PS3) 10Esanders: Bold/italic icons for fa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 [21:01:53] (03PS10) 10Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [21:02:02] James_F, ^^^ default/full switch + border checkbox. [21:02:05] (03CR) 10jenkins-bot: [V: 04-1] [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [21:02:37] James_F, I'm going to make the 'full size' button optional in the mediasize widget, since that's where it comes from atm (and also why it's still there in that fix) [21:04:05] James_F, also, for me, in both my desktop and my VM, and in both chrome and firefox, *ALL* input textboxes are non responsive. [21:04:49] I'll post a bug [21:05:57] let me amend that: all input textboxes inside dialogs. Link seems to work ok. [21:07:41] mooeypoo: OK. [21:07:54] mooeypoo: https://bugzilla.wikimedia.org/62163 from ryasmeen? [21:09:45] yep that seems to be the same bug [21:10:09] Fun. :-( [21:11:05] I added a comment [21:11:10] it's the same bug as far as I see. [21:11:24] I get no console errors at all [21:12:37] was there any changes recently (over the weekend?) about dialogs or textboxes? [21:13:17] For now I suspect Ed's change that blurs the surface in certain cases [21:13:23] But I'll bisect and find out [21:13:38] I tried to follow the code with tons of debugs, but that led me in circles [21:13:44] debuggy circles. [21:15:01] It's broken in Alex's commit which I just fetched, that already rules some things out [21:16:07] Hmm, [BREAKING CHANGE] Refactor dialog and window sets [21:16:10] I wonder ... [21:17:16] OK it looks like this is an oojs-ui problem [21:18:45] Nope that commit is not to blame though [21:20:07] cad99fd2a25baa30df379d12dae6a4e90b6cb2a4 in core (oojs-ui update) introduces the bug [21:20:23] So I'll bisect in oojs-ui [21:21:02] Is bisect the same as Dissect only for code? [21:21:32] git bisect is a tool that lets you find which commit introduced a bug using binary search [21:21:43] oh! [21:21:49] I thought you were being fancy. [21:22:45] innnteresting [21:23:28] So the way it works is, you give it a "bad" starting point (git bisect bad master) and a "good" point in the past (git bisect good 064484f9af), then it gives you a commit to try out [21:23:37] You test that commit, and type either 'git bisect good' or 'git bisect bad' [21:24:02] Then it gives you more commits to test, until it's narrowed down the point where the state switches from good to bad [21:26:12] OK I don't understand why yet, but the breaking commit is: [21:26:14] !g 51f922ba17c1ac42a5b45b0e976134cfa1ecf0a1 [21:26:22] !change 51f922ba17c1ac42a5b45b0e976134cfa1ecf0a1 [21:26:24] Come on wm-bot [21:26:43] Anyway, it's "Refactor OutlineControlsWidget, add remove button" in oojs-ui by TrevorParscal [21:27:07] https://gerrit.wikimedia.org/r/#/c/116001/ [21:45:26] James_F, so, I want to make the 'original dimensions' button optional in the mediasize widget, but i have a conceptual issue to consult when you have a moment. The button *in* the widget only gets enabled if and when 'original dimensions' are actually set. So, by taking the button out of the widget, I'll need to duplicate that functionality [21:45:33] especially since the original dimensions come from the api [21:46:51] but if we take that button out of the widget, it also means that if original dimensions are unavailable, we can't have a "default" (faux-default) for basic and frame images [21:47:33] any ideas for a fallback? there might not be a way to have any, though.. we seem to count on those details being available in the API :\ [22:02:00] do we have a ve native way to compare two objects for equality? [22:04:36] mooeypoo: OO.compare [22:04:44] mooeypoo: May I ask what the use case is? [22:04:45] it's deep-comparing? [22:04:48] Yes [22:04:59] I am checking current dimensions equal to original (full) dimensions [22:05:22] in the case of a user selecting "thumb" as type and then clicking "full size", the size is injected into the media size widget [22:05:25] Oh OK [22:05:34] buttttt since now you have *actual* dimensions instead of just placeholders showing, it's considering "custom" [22:05:35] So just comparing two objects of the form {width:123, height:456} ? [22:05:56] ... so I want to compare if the height/width are the full size for this type of object, keep the button on the full size. [22:05:56] yes [22:06:31] OK then OO.compare() is totally fine [22:07:23] awesomesauce. [22:07:39] this whole behavior is getting elaborate, but i think it's the only way to make it make sense to the user. [22:08:45] mooeypoo, I'm look at the special character widget. In what situations did you envisage the button label differing from the return value? [22:09:00] edsanders, diacritics in hebrew [22:09:12] you have a code (usually invisible) to inject, but you want the user to see some representation of it [22:09:15] I see, combining marks [22:09:16] ok [22:10:11] edsanders, there's a list of those as example in hewiki if you want, I can find them for you [22:10:29] that's fine - I was just wondering if we can get rid of the duplication in most of the lists [22:11:02] maybe a ['a', 'c', 'd', ['e','label'], 'f'] type data structure, but might not be worth the hassle now [22:11:55] sure, that can work [22:12:19] I don't know how many other diacritics you have that use weird codes vs something more user-friendly as labels [22:12:30] but the hebrew case was the main one I know of [22:36:36] (03PS1) 10Mooeypoo: Make the 'full size' button optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116647 [22:37:43] (03PS11) 10Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [22:37:49] phew. [22:37:59] James_F, I need someone to click lots and lots of buttons on that dialog :p [22:38:32] (03CR) 10jenkins-bot: [V: 04-1] [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [22:38:36] test all the fallbacks and switches. There's a bunch that depend on one another there, as we discussed before. [22:38:45] er [22:40:49] (03PS12) 10Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [22:46:34] (03PS1) 10Trevor Parscal: Convert remaining browser-prefixed rules to LESS mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/116650 [22:46:40] (03PS1) 10Trevor Parscal: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 [22:46:46] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Split styles up into base styles and a theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 [22:47:02] (03CR) 10jenkins-bot: [V: 04-1] Convert remaining browser-prefixed rules to LESS mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/116650 (owner: 10Trevor Parscal) [22:52:17] rmoen|away: ping [22:52:18] (03PS1) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (950a25c8b3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116654 [23:00:31] (03PS1) 10Trevor Parscal: Update VE core submodule to a887f525ad4503965c99ee28ac1e0f4b97c83d32 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116657 [23:01:08] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to a887f525ad4503965c99ee28ac1e0f4b97c83d32 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116657 (owner: 10Trevor Parscal) [23:03:46] (03PS1) 10Esanders: Cleanup SpecialCharacterInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116660 [23:03:48] (03PS1) 10Esanders: Special character inspector styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116661 [23:04:05] RoanKattouw: James_F the LD for today? ya'll have that yet? [23:04:26] greg-g: We have a cherry-pick and I just wrote a config fix [23:04:32] cool [23:04:40] Turned out the 2pm deployment did break *something*: people couldn't use VE to sign up for their massages :) [23:04:47] I'm just checking in because I won't be around (I'm on eastern time) [23:04:50] (because we forgot that some private wikis like officewiki also have VE) [23:04:51] oh my [23:18:32] (03PS2) 10Catrope: Convert remaining browser-prefixed rules to LESS mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/116650 (owner: 10Trevor Parscal) [23:22:43] (03CR) 10Catrope: [C: 032] Convert remaining browser-prefixed rules to LESS mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/116650 (owner: 10Trevor Parscal) [23:23:10] (03Merged) 10jenkins-bot: Convert remaining browser-prefixed rules to LESS mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/116650 (owner: 10Trevor Parscal) [23:25:49] (03PS2) 10Catrope: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [23:27:51] (03PS1) 10Trevor Parscal: Allow focusing of inputs in booklet layouts without continuous pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/116664 [23:30:40] (03PS2) 10Jforrester: Allow focusing of inputs in booklet layouts without continuous pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/116664 (owner: 10Trevor Parscal) [23:31:09] (03PS5) 10Divec: WIP: don't cause needless surface refreshes on overwriting. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 [23:31:25] (03CR) 10Catrope: [C: 032] Allow focusing of inputs in booklet layouts without continuous pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/116664 (owner: 10Trevor Parscal) [23:31:56] (03Merged) 10jenkins-bot: Allow focusing of inputs in booklet layouts without continuous pages [oojs/ui] - 10https://gerrit.wikimedia.org/r/116664 (owner: 10Trevor Parscal) [23:33:26] (03CR) 10Catrope: WIP: don't cause needless surface refreshes on overwriting. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [23:36:55] https://bugzilla.redhat.com/show_bug.cgi?id=1072095 [23:39:23] (03CR) 10Catrope: WIP: don't cause needless surface refreshes on overwriting. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [23:44:44] (03CR) 10Catrope: [C: 04-1] WIP: don't cause needless surface refreshes on overwriting. (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [23:57:06] (03CR) 10Catrope: WIP: don't cause needless surface refreshes on overwriting. (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec)