[00:01:10] (03PS1) 10Trevor Parscal: Add maxrows option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/116665 [00:02:15] (03PS2) 10Trevor Parscal: Add maxrows option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/116665 [00:12:20] (03CR) 10Catrope: [C: 032] Revert "Revert "Set href attribute of newly inserted image to image title"" [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116211 (owner: 10Catrope) [00:13:30] (03Merged) 10jenkins-bot: Revert "Revert "Set href attribute of newly inserted image to image title"" [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116211 (owner: 10Catrope) [00:21:24] RoanKattouw: https://gerrit.wikimedia.org/r/116666 is phase 1 of the OOjs UI breaking change (i.e., all the trivial changes that are non-breaking). [00:21:55] Thanks [00:23:45] RoanKattouw: I'll do phase 2 for MW-core when you merge Trevor's change, but obviously the hard work is beyond me. [00:25:40] (03PS1) 10Trevor Parscal: Adjust the size when a textarea is inserted into the DOM [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 [00:26:18] (03PS2) 10Trevor Parscal: Adjust the size when a textarea is inserted into the DOM [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 [00:26:29] (03PS3) 10Catrope: Adjust the size when a textarea is inserted into the DOM [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 (owner: 10Trevor Parscal) [00:27:56] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Split styles up into base styles and a theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 [00:28:45] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Split styles up into base styles and a theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 [00:29:25] (03PS6) 10Divec: Don't cause needless surface refreshes on overwriting. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 [00:35:03] (03PS3) 10Catrope: Add maxrows option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/116665 (owner: 10Trevor Parscal) [00:39:31] (03CR) 10Catrope: [C: 032] Add maxrows option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/116665 (owner: 10Trevor Parscal) [00:39:31] Krinkle: You around for a quick npm consult? [00:39:54] (03Merged) 10jenkins-bot: Add maxrows option to OO.ui.TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/116665 (owner: 10Trevor Parscal) [00:43:20] (03PS4) 10Trevor Parscal: Adjust the size when a textarea is inserted into the DOM [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 [00:46:02] James_F: yes? [00:46:12] Krinkle: Seem to have fixed it, don't worry. [00:46:30] Krinkle: Brew was fighting with itself as to who had installed npm (it had, but it had forgotten about it). [00:47:00] Krinkle: Actually, no. [00:47:02] * James_F sighs. [00:47:25] If you don't mind running latest stable nodejs, I'd do: brew install nodejs && npm install -g npm; [00:47:38] Krinkle: That's what I did. [00:48:04] Krinkle: "-bash: /usr/local/bin/npm: No such file or directory " [00:48:13] Run brew update first [00:48:16] I did. [00:48:19] k [00:48:22] what's node --version? [00:48:29] Did you open a new shell since the install? [00:48:35] 10.26, and no. [00:48:53] open new terminal tab, close old one. might help [00:49:16] Still no success. It's not a path issue, npm deleted itself mid-update, then failed. [00:50:07] * James_F `brew uninstall nodejs && brew install nodejs && npm install -g npm`s [00:50:14] (Again.) [00:51:30] so what does that last part do? [00:52:02] I"m assuming npm will refuse update and rollback because it refuses to update the symlinks pointing from /usr/local to brew's nodejs bundled npm version [00:52:37] which is what latest brew does, and basically means you can't/shouldn't (but also: don't need to) update npm manually, it's taken care of by nodejs updates [00:53:11] Yes. [00:53:25] but that's a bigger update each time, so if you're in a situation where you don't want to update node but do update npm, that's totally possible (npm is backwards compatible) but you'd have to remove al npm-related symlinks manually [00:53:30] I'd recommend not doing that unless you have to [00:53:41] At this point I just want a system with npm installed. [00:53:48] so forget about npm install -g npm in that case, it should already be new enough if you run latest nodejs [00:53:59] the brew install nodejs should take care of that [00:54:10] What about the CA change? [00:54:14] if not, you can reset any weirdness with brew unlink nodejs brew link nodejs [00:54:23] Hmm. [00:54:27] that's rolled out with the minor update in nodejs I think [00:54:49] both in nodejs itself and inside the bundled npm package within nodejs [00:54:52] Hmm. OK. [00:54:56] v0.10.25 [00:55:31] (03CR) 10Krinkle: Adjust the size when a textarea is inserted into the DOM (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 (owner: 10Trevor Parscal) [00:55:34] npm --version [00:55:39] 1.4.3 [00:55:41] Is that OK? [00:56:41] Also, should `brew unlink nodejs && brew link nodejs` remove and add the same number of symlinks, or am I just mad? :-) [00:57:26] yes, but if it's uneven it means something was stuck and has now been unstuck [00:57:37] e.g. if you or a script you ran messed up some of the links [00:57:42] unequal* [00:57:45] (03CR) 10Catrope: [C: 04-1] Adjust the size when a textarea is inserted into the DOM (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 (owner: 10Trevor Parscal) [00:57:50] I just ran it three times in a row. [00:57:54] if you run it again it'll be equal [00:57:57] no? [00:57:59] -1402 +1192. [00:58:01] Each time. [00:58:05] * James_F sighs at node. [00:59:48] (03CR) 10Trevor Parscal: Adjust the size when a textarea is inserted into the DOM (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 (owner: 10Trevor Parscal) [00:59:55] v0.10.26 and/or v1.4.3 is good [00:59:59] e.g. post CA fix [01:00:40] (03CR) 10Catrope: [C: 031] "Looks good to merge, but not merging yet in anticipation of some other stuff that might land first." [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [01:01:22] Krinkle: Except `npm install` in OOjs UI is still failing, now with comment telling me to talk to you. :-) [01:01:35] James_F: What/ [01:01:38] Which comment is that [01:01:56] npm ERR! oojs-ui@0.1.0 prepublish: `grunt build` [01:01:57] npm ERR! Exit status 127 [01:02:40] Krinkle: Could you comment on https://gerrit.wikimedia.org/r/#/c/116652/3/Gruntfile.js ? The commit says Trevor wrote it but really I wrote it on his computer (just that one file, I'm starting to review the rest of that commit now) [01:02:43] James_F: rtm, I suppose you implicitly uninstalled grunt when you switched from a manual npm install to the npm bundled with nodejs [01:02:55] since they have separate module directories and preusmably you no longer have the other one in your PATH [01:03:01] npm install -g grunt-cli [01:03:22] Krinkle: Argh, yes, grunt-cli not just grunt. [01:03:23] * James_F sighs. [01:03:26] Working now. [01:04:12] James_F: Do not install 'grunt' globally or otherwise, that's a local package used inside package.json. [01:04:16] just grunt-cli [01:04:24] Krinkle: Oh, oops. Should I uninstall? [01:04:27] Yes [01:05:26] npm lets you install any package globally, which, if it isn't a cli package, will just mean it is available to nodejs through require() at any time (as opposed to beign available in your PATH at any time) [01:05:34] Right. [01:05:47] usually not what you mean, but it doesn't have a separate flag for global include and bin path. [01:05:57] Helpful [01:08:01] (03CR) 10Catrope: [C: 032] "This event is deprecated but we desperately need this behavior right now, so merging this and telling Trevor to fix it later." [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 (owner: 10Trevor Parscal) [01:08:24] (03Merged) 10jenkins-bot: Adjust the size when a textarea is inserted into the DOM [oojs/ui] - 10https://gerrit.wikimedia.org/r/116669 (owner: 10Trevor Parscal) [01:08:33] (03CR) 10Krinkle: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [01:09:37] (03CR) 10Catrope: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [01:12:35] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116678 [01:13:33] RoanKattouw: 646b4e9 [01:13:53] RoanKattouw: f3bc5c6c1cb109 [01:17:36] (03CR) 10Krinkle: [C: 04-1] "Should be a -pre build, unless this was/is a release." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116678 (owner: 10Jforrester) [01:17:47] TrevorParscal, so https://gerrit.wikimedia.org/r/#/c/116652/ is more or less final and we can try to base our work on it on mobile? [01:18:03] yeah [01:18:08] we are working on merging it now [01:18:12] ok, thanks [01:23:32] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/116682/ [01:27:44] Krinkle: https://gerrit.wikimedia.org/r/#/c/116678/ is broken because you broke @version. [01:27:54] Krinkle: Roan is angry with you, but… [01:29:13] James_F: RoanKattouw: I don't think I broke it [01:29:18] git-build is still there [01:29:29] Hmm [01:29:29] grunt test runs git-build first, which sets that version number [01:29:39] So grunt build produces a -pre file and grunt produces a non-pre file [01:29:43] Maybe the script runs the wrong one [01:29:48] Or which one produces which changed [01:29:52] grunt build doesn't do that because that hook is run before publishing to npm etc. [01:30:00] Krinkle: At some point I did observe @VERSION stuff in files but that seems to be gone now [01:30:28] "grunt [default]" is default, what that does is variable. Mainly concern with "grunt test" and "grunt build" [01:30:31] I think default=test [01:30:38] in oojs/ui it is [01:30:50] test runs git-build, build and unit tests [01:31:27] The -1 here isn't @version showing up, that was fixed a while back [01:31:57] Krinkle: The script is in bin/update-oojs-ui.sh [01:32:45] James_F: That seems to do the right thing (run grunt default/test, not grunt build) [01:33:04] your commit seems to be the result of something slightly different [01:33:27] Krinkle: And yet it's the result of `./bin/update-oojs-ui.sh ~/Documents/git/oojs-ui/ && git review` [01:33:35] Krinkle: So… [01:34:47] I just verified locally, that running that produces * OOjs UI v0.1.0-pre (f3bc5c6c1c) [01:34:50] not * OOjs UI v0.1.0 [01:34:59] latest lib/ve@master, latest oojs/ui@master [01:35:22] Krinkle: So… is there something wrong with my local grunt? [01:35:31] If Roan's near you, maybe have him look instead, probably more efficient than me doing it over irc [01:35:46] Krinkle: He's busy with deployment stuff. [01:36:40] James_F: cd oojs/ui; git status; git log --oneline -1; tail Gruntfile.js [01:36:55] Krinkle: Yes? [01:36:56] grunt.registerTask( 'default', 'test' ); [01:37:02] Yes. [01:37:05] clean status, [01:37:05] f3bc5c6 Adjust the size when a textarea is inserted into the DOM [01:37:13] ? [01:37:14] you should see those three things [01:37:37] No? [01:37:40] grunt.registerTask( 'test', ['git-build', 'build', 'jshint', 'csslint', 'qunit'] ); [01:37:40] grunt.registerTask( 'default', 'test' ); [01:37:40] }; [01:37:57] yes, that's the same [01:38:05] what about `git status; git log --oneline -1` ? [01:38:14] "clean status," and "f3bc5c6 Adjust the size when a textarea is inserted into the DOM" aren't in it. :-) [01:38:38] "f3bc5c6 Adjust the size when a textarea is inserted into the DOM" as expected. [01:39:16] but not up-to-date with origin/master, working copy clean? [01:39:29] Oh, sorry, yes, obviously that. [01:39:38] so, all three OK [01:39:43] All three? [01:39:47] Ooooooh. [01:40:03] "Clean status," was your cryptic comment about what I should interpret, not a string that I should see? [01:40:26] Then, in cd lib/ve && git remote update && git checkout origin/master && ./bin/update-oojs-ui.sh ~/Documents/git/oojs-ui/ && git show [01:40:28] Concision has its limits. :-) [01:40:34] (git show instead of review, so you can look at it locally before pushing) [01:40:46] Of course. [01:41:05] (I don't actually && git review, I normally git log just to check.) [01:41:06] If that does not produce a pre build, your system is.. wrong. [01:41:13] " Update OOjs UI to v0.1.0 " [01:41:28] So, we're agreed that my system is wrong. Any ideas how to fix it? :-) [01:43:46] Try a hammer? [01:43:50] This doesn't make sense [01:44:31] James_F: https://gist.github.com/Krinkle/e725da2b6b0773555871 [01:44:37] Krinkle: I could totally uninstall brew, node, npm, grunt-cli, python, git, git review to try fix it. [01:44:44] Krinkle: Oh, wait, that's what I did this afternoon… [01:50:13] Krinkle: What version of git are you running? Perahsp that might be it? [01:50:31] You've done this countless times before, https://gerrit.wikimedia.org/r/#/q/branch:master+message:oojs+message:update+message:ui+is:merged,n,z [01:50:34] they all looked fine [01:50:54] Indeed, hence why it might be something that's just changed this afternoon? [01:51:13] I've just upgraded to git v1.9.0 [01:51:28] Do you have the same problems now you've upgraded? [01:51:34] No [01:51:39] (I've got 1.9.0.) [01:51:41] Bah. :-( [01:51:43] James_F: Try one more time, this time make sure you really are at latest ve master [01:51:50] your local 'master' branch may be out of sync [01:52:26] for example, in contrast to the ve-submodule update script for ve-mw, the oojs update script for lib/ve doesn't create a fresh branch. [01:52:26] Already on 'master' [01:52:26] Your branch is up-to-date with 'origin/master'. [01:52:26] Already up-to-date. [01:52:29] it commits from and to whatever branch you are on [01:52:33] k [01:52:38] True, but we're not even doing that commit yet. [01:52:48] and git log shows an upstream commit, and git status is clean? [01:52:57] There's the OOjs/UI -> VE/VE, then VE/VE -> MW/ext/VE one. [01:53:37] whereas the submodule update script does a reset first, and sets up a fresh sync-repos branch. Anyway, it looks like that's not the problem though. [01:53:44] Yeah. [01:53:47] Bu that's the only thing I can imagine could be the probelm. [01:53:47] jdforrester@local:~/Documents/git/vagrant/mediawiki/extensions/VisualEditor/lib/ve$ git log --oneline [01:53:47] c960944 Update OOjs UI to v0.1.0 [01:53:47] 6a885bf Localisation updates from https://translatewiki.net. [01:53:49] c75315f Merge "Changeable UI language in SA demo" [01:53:56] I'm going to blame Roan. [01:53:57] Ah, so you're not clean [01:54:13] you're one commit off of origin/master [01:54:20] I'm not clean /now/, because I'm on master. [01:54:20] the earlier version of your update [01:54:35] try git reset --hard origin/master [01:54:38] Done. [01:54:40] and then re-run the update script [01:54:58] jdforrester@local:~/Documents/git/vagrant/mediawiki/extensions/VisualEditor/lib/ve$ git log --oneline [01:54:58] f6295f1 Update OOjs UI to v0.1.0 [01:55:00] 6a885bf Localisation updates from https://translatewiki.net. [01:55:02] c75315f Merge "Changeable UI language in SA demo" [01:58:01] Krinkle: In oojs-ui `git tag -l` should show just one entry ("v0.1.0") and `git branch -l` should show a bunch of entries, with master shown as selected, right? [01:59:02] $ git tag -l [01:59:02] v0.1.0 [01:59:04] $ git br -a [01:59:06] * master [01:59:08] remotes/origin/HEAD -> origin/master [01:59:10] remotes/origin/master [02:00:01] OK, same here. [02:00:57] you're sure you're not working with more than one oojs/ui copy, right? [02:01:29] How would I be doing that? [02:01:32] the path you pass to the oojs-ui-update script is the same path you executed those git commands in earlier [02:01:41] e.g. not like you have two clones laying around [02:01:43] and mixing them up [02:02:07] Oh, right. [02:02:08] No, sadly. [02:02:53] grep "OOjs UI v" dist/oojs-ui.js | head -n 1 | grep -Eo '\bv[0-9a-z.-]+\b.*$' definitely comes out with v0.1.0, as it should. [02:03:19] those functions/regexes are fine [02:03:27] the problem is in the oojs-ui.js the regex looks inside of [02:03:45] Yeah. [02:03:48] I'm not -1'ing for the commit message not having that in there. [02:03:51] the file itself is different [02:03:59] the grunt build is producing a different file [02:04:00] AHA! [02:04:02] Found it. [02:04:05] * James_F sighs. [02:04:08] I'm an idiot. [02:04:09] Sorry. [02:04:26] `grunt` was working fine in VE-MW, VE-VE, MW-core, OOjs, etc. [02:04:33] But not in OOjs-UI. [02:04:57] Hm.. and it slurps the error? [02:05:05] what error are you getting [02:05:29] I was getting: [02:05:29] presumably you still had the build file in your local dist/ and thus grunt effectively didn't run, but the updat escript continued anyway. [02:05:31] Interesting [02:05:33] jdforrester@local:~/Documents/git/oojs-ui$ grunt [02:05:33] grunt-cli: The grunt command line interface. (v0.1.13) [02:05:34] Fatal error: Unable to find local grunt. [02:05:38] Yeah. [02:05:40] Whoops. [02:05:43] aha, npm-install :) [02:05:52] Yeah, npm-install made things work. :-) [02:08:07] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (f3bc5c6c1c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116678 [02:08:09] Krinkle: Fixed now. [02:10:07] Krinkle: BTW, slightly worrying diff there: [02:10:39] https://gerrit.wikimedia.org/r/#/c/116678/1..2/lib/oojs-ui/oojs-ui.js <-- substantive code change (from e87a54e) [02:10:51] https://gerrit.wikimedia.org/r/#/c/116678/1..2//COMMIT_MSG <-- no substantive change [02:10:55] * James_F sighs. [02:11:01] Something to watch for, I guess. [02:12:30] Krinkle: If you could merge that, that'd be great, BTW; it's already merged in MW-core (https://gerrit.wikimedia.org/r/#/c/116666/) so it's just reflecting reality. [02:13:11] (03PS1) 10Krinkle: Update scripts: Ensure clean master, latest npm dependencies, abort on grunt error [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116689 [02:13:14] James_F: ^ [02:13:33] Krinkle: Hmm. [02:14:08] Krinkle: I think the ability to (implicitly) specify a particular version was a feature, not a bug. [02:14:15] Basically that version would've worked for you without an error, and if npm-install or grunt showed a different error than the one you had (missing local grunt), this will catch it [02:14:22] Krinkle: It was made by Roan so you could easily pull through changes. [02:14:25] James_F: That is unchanged. [02:14:43] This is resetting the target repo [02:14:46] (ve) [02:14:48] Oh, I see, yeah. [02:15:10] so you're not committing on top of a local branch you happen to be on, or on a 'master' that already contains something else (eg. a preious attempt at running the script) [02:15:12] Krinkle: Changes look good to me and produce the desired output on master right now. [02:15:32] Yeah, though if you want to chain an OOjs and an OOjs UI change together I guess you're now fucked. [02:15:39] (But we've never needed to do that, so…) [02:15:56] James_F: Not really, they create separate branches [02:16:20] Krinkle: You'll need to do this to mw-core's resources/oojs/update-oojs.sh and resources/oojs-ui/update-oojs-ui.sh [02:16:34] Krinkle: I suppose they don't directly depend as they're not executed, true. [02:16:41] You can always make them depend. [02:16:53] (03CR) 10Jforrester: [C: 032] Update scripts: Ensure clean master, latest npm dependencies, abort on grunt error [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116689 (owner: 10Krinkle) [02:17:23] (And yes, having these scripts in two target repos makes me feel we should instead have them in the source repos with a flag for what kind of build to make, but…) [02:17:35] * Krinkle saves ": You'll need to do this to mw-core's" to notepad and calls it a night [02:17:46] Krinkle: *grins* [02:17:51] Krinkle: Sleep well, and see you tomorrow. [02:18:25] (03Merged) 10jenkins-bot: Update scripts: Ensure clean master, latest npm dependencies, abort on grunt error [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116689 (owner: 10Krinkle) [02:24:47] Krinkle|detached: Changes made for you as https://gerrit.wikimedia.org/r/116695 – just needs your +2. :-) [02:35:34] (03PS1) 10Jforrester: Update VE core submodule to master (674b245) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116699 [02:41:16] (03CR) 10Jforrester: [C: 032] "Trivial changes to non-SA code; allow testing of bug 60180 fix." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116699 (owner: 10Jforrester) [02:42:16] (03PS2) 10Jforrester: [UNMERGED] Update OOjs UI to v0.1.0-pre (950a25c8b3) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116654 (owner: 10Trevor Parscal) [02:42:26] (03Merged) 10jenkins-bot: Update VE core submodule to master (674b245) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116699 (owner: 10Jforrester) [02:43:51] (03CR) 10Jforrester: [C: 032] "These are already in effect in MW-core's version of OOjs UI, due to 6c03dceae4 being merged; pulling through here for sanity." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116678 (owner: 10Jforrester) [02:44:49] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (f3bc5c6c1c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116678 (owner: 10Jforrester) [02:48:22] (03PS2) 10Jforrester: [UNMERGED] Update VE core submodule to a887f52 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116657 (owner: 10Trevor Parscal) [02:48:30] (03CR) 10jenkins-bot: [V: 04-1] [UNMERGED] Update VE core submodule to a887f52 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116657 (owner: 10Trevor Parscal) [02:52:59] (03PS1) 10Jforrester: Update VE core submodule to master (f93e960) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116702 [02:53:21] (03CR) 10Jforrester: [C: 032] "Meaningless pull-though, but avoids distractions." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116702 (owner: 10Jforrester) [02:55:09] (03Merged) 10jenkins-bot: Update VE core submodule to master (f93e960) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116702 (owner: 10Jforrester) [03:05:43] (03PS3) 10Jforrester: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [03:05:59] (03CR) 10Jforrester: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [03:07:13] (03CR) 10Jforrester: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [03:08:42] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Split styles up into base styles and a theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 [03:43:21] (03PS1) 10Vikassy: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116712 [04:48:44] (03CR) 10Catrope: [BREAKING CHANGE] Split styles up into base styles and a theme (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 (owner: 10Trevor Parscal) [04:49:08] (03CR) 10Catrope: [C: 04-1] "See inline comments on PS3" [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 (owner: 10Trevor Parscal) [07:24:26] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Split styles up into base styles and a theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 [07:26:22] (03CR) 10Trevor Parscal: [BREAKING CHANGE] Split styles up into base styles and a theme (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 (owner: 10Trevor Parscal) [11:00:30] Hi, I've enabled visual editor on my wiki (http://namingschemes.com) but anonymous edits will not work. But logged in users can edit fine. [11:01:10] Am I missing something obvious? [13:44:15] (03PS6) 10Esanders: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 [13:45:14] (03CR) 10jenkins-bot: [V: 04-1] Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [14:02:36] (03PS7) 10Esanders: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 [14:08:04] (03CR) 10Esanders: "Given Trevor put in some changes I'm assuming he's test it on OSX, can you recheck Timo?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [14:09:25] (03PS1) 10Esanders: Vector style tweaks for collapsible slugs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116742 [14:09:57] (03CR) 10jenkins-bot: [V: 04-1] Vector style tweaks for collapsible slugs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116742 (owner: 10Esanders) [15:18:08] So I was linked a parsoid package that works well with ubuntu and everything, then totally forgot where I saved the link [15:18:35] Any chance I can get that again? I'll save it this time I promise! [16:25:54] (03PS1) 10Esanders: Use previous breakpoint's range when undoing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 [16:26:55] (03CR) 10jenkins-bot: [V: 04-1] Use previous breakpoint's range when undoing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 (owner: 10Esanders) [16:29:59] Heya. [16:30:03] Ulfr_: Argh, yeah – deb http://parsoid.wmflabs.org:8080/debian wmf-production/ [16:30:05] Ulfr_: I think. [16:30:12] James_F: Thanks! [16:30:24] Ulfr_: Or that's possibly the specific set-up we use here; can't find the general tree. [16:30:39] dalurka: Hey, have you set anything in DefaultSettings.php? [16:30:53] James_F: np, I accidentally the doc I had with that url [16:31:33] Ulfr_: Know the feeling. :-) [16:32:11] worst part is it was just JS formatting gone awry that closed it. stupid notepad++ [16:33:47] James_F: Okay. Now I feel superdumb. What do I do with the link? Sources.list gets really unhappy when I add that without something at the end. [16:33:50] Sorry for being a bother [16:39:18] James_F: nope [16:39:51] Ulfr_: Sorry, I don't do package management; I have no idea. :-9 [16:40:05] dalurka: So each user has to opt-in manually? [16:40:07] James_F: There was a second line you gave me that made it go [16:40:12] I'll figure it out :) [16:40:42] deb-src http://parsoid.wmflabs.org:8080/debian wmf-production/ [16:40:45] James_F: No I'm not sure..it just shows up [16:40:52] James_F: as the default [16:43:16] James_F: Yup! Thanks! [17:23:52] Good morning people [17:24:35] James_F: I got Roan to review my change, I fixed it up, but I guess he never actually merged it? [17:24:42] TrevorParscal: Yeah. :-( [17:24:42] Is that on purpose? [17:24:49] (03CR) 10Esanders: [C: 04-2] "Behaviour not quite right yet, rewriting." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 (owner: 10Esanders) [17:24:52] RoanKattouw_away: how away are you? [17:24:55] TrevorParscal: He probably fell asleep. [17:25:04] TrevorParscal: He's not connected to IRC. Text him? [17:25:05] I drove him home quite late [17:25:19] TrevorParscal: Told you he couldn't really come over. :-) [17:29:02] James_F: try to edit http://namingschemes.com/TEST123 [17:29:18] you'll get an unknown error [17:29:45] I'm not sure how to debug it since no error shows up in parsoid or the php error log [17:30:05] if I'm logged in then I'll be able to edit fine [17:31:47] would I need to increase the logginglevel or something? [17:50:45] dalurka: Hmm, odd. [17:51:42] dalurka: How is your Parsoid connection set up? Are you using $wgVisualEditorParsoidForwardCookies? [17:56:45] RoanKattouw: ^^^ TrevorParscal wants you to merge his code for Mobile. [17:56:51] (03PS2) 10Esanders: Use previous breakpoint's range when undoing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 [17:58:08] James_F: I'm about to hit +2 [17:58:11] Just checking IRC to verify there isn't some catastrophe going on [17:58:21] RoanKattouw: No, everything is well, go go go. [17:58:44] RoanKattouw: (Also needs the MW pull-in commit merged for Mobile, I imagine.) [18:00:13] Well, so about that [18:00:37] TrevorParscal: Do we have a VE-MW commit that hooks this up with the resourceloader modules and stuff? [18:00:51] James_F: As a matter of a fact, do we have one for MW core? It's nontrivial due to the added files [18:00:58] I thought you were writing one? [18:01:03] (03CR) 10Catrope: [C: 032] Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [18:01:17] (03PS3) 10Esanders: Use previous breakpoint's range when undoing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 [18:01:22] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Split styles up into base styles and a theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 (owner: 10Trevor Parscal) [18:01:27] (03Merged) 10jenkins-bot: Break up stylesheets into separate files to make a 1:1 ratio of JS and LESS [oojs/ui] - 10https://gerrit.wikimedia.org/r/116651 (owner: 10Trevor Parscal) [18:01:40] I'd be happy to do that but I wouldn't be able to do it today then [18:01:51] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Split styles up into base styles and a theme [oojs/ui] - 10https://gerrit.wikimedia.org/r/116652 (owner: 10Trevor Parscal) [18:13:32] (03PS4) 10Esanders: Store previous range in breakpoint for undo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 [18:13:34] (03CR) 10Esanders: Store previous range in breakpoint for undo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 (owner: 10Esanders) [18:14:33] (03CR) 10Esanders: [C: 031] "Removing -2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 (owner: 10Esanders) [18:19:25] edsanders: You know you can CR as 0 to remove a -2 without +1'ing your own code, right? [18:19:41] I did a CR0 and it didn't work [18:20:36] Esanders 6:13 PM [18:20:36] Patch Set 3: -Code-Review [18:20:46] and it stayed as -2 [18:20:52] How odd. [18:21:00] Yay gerrit bugs. [18:26:16] TrevorParscal: Want me to make the pull-in change of OOjs UI for VE and VE-MW? [18:37:44] Krinkle, TrevorParscal: Fixed up https://gerrit.wikimedia.org/r/#/c/116770/ to work. [18:51:06] James_F: i'm working on it [18:52:17] TrevorParscal: Do the simple<->advanced conversion instead? I can do the pull-in easily. [18:56:11] (03PS1) 10Trevor Parscal: Make ButtonOptionWidget background transparent [oojs/ui] - 10https://gerrit.wikimedia.org/r/116772 [18:56:20] merge that first [18:56:51] (03CR) 10Jforrester: [C: 04-1] "Fix the errant comment and it's good to go." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116772 (owner: 10Trevor Parscal) [18:57:57] James_F: all the other files have those comments...?? [18:58:15] TrevorParscal: No, they don't. I stripped them all out per Timo and Roan last night. [18:59:01] well, look at master james [18:59:05] they made it back in somehow [18:59:16] i was just making it consistent [18:59:27] They did? [18:59:31] Gah. [18:59:32] i don't care if they are there or not, just that it's consistent [18:59:36] Sure. [18:59:59] TrevorParscal: Pull master. [19:00:24] TrevorParscal: head src/styles/*.less [19:00:27] i did [19:00:35] look at src/themes/ [19:01:06] i guess you only pulled them from one place, not the other [19:01:11] TrevorParscal: Ah, they weren't removed from the themes, just from the styles. [19:01:26] so, you want me to change that or can we fix that later? [19:01:28] TrevorParscal: Because you made the themes afterwards and Roan didn't notice. [19:01:43] (03CR) 10Jforrester: [C: 032] "Let's fix it in post." [oojs/ui] - 10https://gerrit.wikimedia.org/r/116772 (owner: 10Trevor Parscal) [19:01:47] k [19:02:05] (03Merged) 10jenkins-bot: Make ButtonOptionWidget background transparent [oojs/ui] - 10https://gerrit.wikimedia.org/r/116772 (owner: 10Trevor Parscal) [19:05:27] James_F: this was the tricky one: https://gerrit.wikimedia.org/r/116775 [19:07:21] feel free to make/update sync commits for ve core (update https://gerrit.wikimedia.org/r/#/c/116654/) and vemw [19:07:42] i'm going to switch gears to transclusion stuffs [19:07:46] TrevorParscal: Will do. [19:08:56] (03PS1) 10Jforrester: Remove /* OO.ui.… */ comments from LESS theme files [oojs/ui] - 10https://gerrit.wikimedia.org/r/116776 [19:10:36] Krinkle: Want to merge ^^^ given you asked for those to be removed from the other ones? [19:19:18]