[00:28:30] TrevorP|Away: OK. [01:43:47] (03CR) 10Jforrester: "I've still not been able to check this out (because my local install is hosed)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [01:49:19] (03CR) 10Mooeypoo: "It's ready -- but since there's a fairly elaborate set of usability rules in terms of the buttons and size widget, I really want someone t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [02:40:31] (03CR) 10Inez: Don't break core's parserTests if VisualEditor is installed (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84436 (owner: 10Cscott) [03:00:57] (03PS13) 10Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [03:23:00] (03PS14) 10Jforrester: Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [03:52:49] (03PS15) 10Mooeypoo: [wip] Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [03:52:53] oh boo [03:53:48] (03PS16) 10Mooeypoo: Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 [08:46:57] James_F|Away: no $wgVisualEditorParsoidURL = 'http://localhost:8000'; [08:47:05] James_F|Away: should I be using that? [08:47:52] James_F|Away: and it is called $wgVisualEditorEnableExperimentalCode but it is commented [10:46:02] (03CR) 10Zfilipin: [C: 032] [Browser tests] Updated Ruby version from 2.1.0 to 2.1.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116712 (owner: 10Vikassy) [10:48:27] (03Merged) 10jenkins-bot: [Browser tests] Updated Ruby version from 2.1.0 to 2.1.1 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116712 (owner: 10Vikassy) [12:26:16] (03PS2) 10Krinkle: WindowSet: Add support for overriding the creation a window [oojs/ui] - 10https://gerrit.wikimedia.org/r/116891 (owner: 10Trevor Parscal) [14:19:12] (03PS1) 10Esanders: Support platform specific message in keyboard shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116964 [14:19:14] (03PS1) 10Esanders: Support multiple shortcuts per trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116965 [14:19:16] (03PS1) 10Esanders: Add cmd/ctrl+y as alternative shortcut for redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116966 [14:19:18] (03PS1) 10Esanders: Add cmd/ctrl+m as alternative shortcut for clear formatting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116967 [14:19:20] (03PS1) 10Esanders: Update MWCommandHelpDialog now core supports multiple shortcuts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116968 [14:19:28] (03CR) 10jenkins-bot: [V: 04-1] Update MWCommandHelpDialog now core supports multiple shortcuts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116968 (owner: 10Esanders) [15:18:09] (03CR) 10Krinkle: [C: 04-1] "The margin set on the focussed block slug seems a bit arbitrary. Between focussing the block slug and typing (at which point it is replace" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [15:46:11] (03PS8) 10Krinkle: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [15:46:57] (03CR) 10jenkins-bot: [V: 04-1] Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [15:51:45] (03PS9) 10Krinkle: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [15:51:54] (03CR) 10Krinkle: "(removed debugging)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [15:52:26] (03CR) 10Krinkle: [C: 031] "Made a few changes to make it feel smoother and (hopefully) easier to maintain:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [16:00:00] (03PS1) 10Krinkle: ve.ce.Node: Clean up whitespace in rgba?() syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116979 [16:00:35] edsanders: Can you verify https://gerrit.wikimedia.org/r/109307 works well for Firefox / Linux ? [16:33:34] I'll double check [16:34:46] yeah seems to work ok [16:35:25] oh wait [16:35:28] you made changes [16:36:14] the marign-top: 1px was added to remove a jiggle I was seeing [16:37:54] Krinkle, the target are in FF is now very narrow [16:38:17] like 3-4px [16:38:55] and is narrower that in was in Chrome [16:39:14] edsanders: Does it look narrower than it was before in Chrome for you as well? [16:39:37] it's a about 2px narrower than it was before [16:39:43] in Chrome [16:40:36] FF was also narrower than Chrome before, and is now even more so [16:40:52] to the point where it's difficult to use [16:42:00] ah, found it [16:42:02] 0.5em [16:42:08] that wasn't intentional, I'll add that back [16:43:03] (03PS10) 10Krinkle: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [16:43:33] (03CR) 10Krinkle: "Restored inner padding from 0.2 to 0.2em (as was in 573bf7f)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [16:44:02] edsanders: checking out 573bf7f, loading page, checking out latest changeset, and opening new tab. hover state looks pixel identical for me now in Chrome. [16:45:13] looks 2px narrower for me [16:45:16] the focussed state is different but that's intentional. In the old version, margin would be added once you start typing (thus bumping down the "Single template, floated right" in the demo, wheareas my revision will not do that. [16:45:32] Do you get that as well? [16:45:56] yes, it moves when you type [16:46:13] *moved [16:46:34] Hm. indeed, in Firefox it gets thinner. [16:46:39] weird [16:46:47] and it is thinner there to begin with [16:46:52] I'll see what I can do about that [16:55:07] edsanders: The cause is Firefox's lack of a minimum font-size and us making it smaller than needed [16:55:18] chrome wasn't going lower than 0.4em when we specify 0.2em [16:55:30] and since the padding is in em, it shrinks because of that [16:55:52] figured it out when replacing the slug contents with 'x' instead of nbsp, the x was very tiny and got bigger than I changed it to 0.4em in FIrefox, and didn't change anything in Chrome [16:56:15] (03PS11) 10Krinkle: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [16:59:32] (03CR) 10Krinkle: [C: 031] "Bumped font-size in the collapsed slug from 0.2em to 0.4em. Made no difference in Chrome due to 0.4em being the minimum (not the relative " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [16:59:43] edsanders: That should do it. [17:02:16] Krinkle, so FF & Chrome are the same now, but they're both about 2px smaller than they were [17:02:55] if it's possible to make it bit bigger than would be good, as it's quite a hard target area to hit [17:03:02] Yeah [17:03:29] edsanders: I don't see that here though. You mean between 573bf7f and latest revision? Or against master? Could be OS level font rendering related. [17:03:42] the former [17:03:44] Can you confirm whether the size diff is in the complete occupied space and/or in the grey box? [17:04:22] so in 573 the box is larger, and the first paragraph sits lower on the page [17:08:18] it's 5px taller in Chrome by my screenshot [17:08:20] strange [17:08:55] only 2px but 5px when I increase it [17:09:00] so it goes exp. [17:13:12] (03PS12) 10Krinkle: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [17:13:26] edsanders: lol, I didn't anticipiate font-size being that small. [17:13:32] bumped it again to 0.7em, still the same in Chrome [17:13:37] 0.8em is where it starts increasing [17:14:02] makes more sense. didn't make sense that 0.4em of the default size was 9px [17:14:15] (default: 16px) [17:15:20] (03CR) 10Krinkle: "Bumped font-size again, to 0.7em. Still no difference in Chrome (computed minimum: 9px, <= 0.7em is 9px, after that it starts increasing)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [17:15:33] Looks better in Firefox now for me [17:16:33] that's good, it's now 1px bigger in Chrome than before [17:16:52] fine by me :) [17:17:16] we don't have to use the minimum, that's an arbitrary Chrome restriction anyway. [17:17:25] may 1px smaller in FF, but good enough [17:19:41] have you checked: https://gerrit.wikimedia.org/r/#/c/116742/ ? [17:20:03] (03CR) 10Krinkle: [C: 032] "Bold." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [17:20:37] edsanders: Not yet. [17:20:47] edsanders: I've done this testing in standalone demo. [17:21:00] (03Merged) 10jenkins-bot: Collapse block slugs and expand on hover/focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109307 (owner: 10Esanders) [17:21:12] Krinkle: FFS. [17:21:17] Krinkle: I was in the middle of -2'ing that. [17:21:22] Oh? [17:21:25] Yeah. [17:21:29] What up [17:21:30] No product review /at all/. [17:21:33] No design review. [17:21:34] WTF? [17:21:38] Trevor made it [17:21:47] Ed made it. [17:21:53] Trevor did some tweaks. [17:21:56] Yeah [17:22:05] No-one actually properly reviewed the functionality from the user perspective. [17:22:07] you assigned the bug to Trevor [17:22:19] A year ago as something to consider. [17:22:26] But now you want me to defend it, unseen? [17:22:31] Not cool. [17:22:52] I think you're overreacting, but either way. No problem. Will revert. [17:22:53] (03PS1) 10Esanders: Slightly strong shading on slug hover target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116993 [17:23:01] No no. [17:23:04] It's probably fine. [17:23:19] But major UX changes shouldn't just get merged under the "be bold" principle. [17:23:36] I'll review it now and we can make the decision then. [17:23:38] The bug was accepted as something we'd want (maybe a year ago as just to consider, but Ed and Trevor have worked on it a fair bit so I'm assuming by now the bug as still not being wontfix we want the idea), and Trevor made adjustments to it visually so it seems acceptable from his point of view. [17:24:13] James_F, it's been sitting around as a commit for weeks, and as a bug for months - perhaps you should raise your objections sooner [17:24:26] Any reason why the durations of the two animations are different? [17:24:43] edsanders: I did. With Roan and Trevor, saying we should properly review it and not just slip it out… [17:24:48] * James_F sighs. [17:25:00] outline-color and background-color are animated for 400ms but the dimensions (height, font-size, margin, padding) are animated for 200ms [17:25:40] RoanKattouw: They are separate animations though (not at the same time). One is for hover, the other is when clicking it to expand. Different types of animations, shouldn't be the same per se. Though having said that, I didn't introduce that and don't want them to be different per se either. [17:25:55] (03PS2) 10Krinkle: ve.ce.Node: Clean up whitespace in rgba?() syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116979 [17:25:56] one is style, the other is box model/redraw [17:25:57] James_F, then there are the pitfalls of conducting important conversions offline [17:25:59] (03CR) 10Jforrester: [C: 032] ve.ce.Node: Clean up whitespace in rgba?() syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116979 (owner: 10Krinkle) [17:26:27] Krinkle: Right. I only saw that one of them was animating a descendant of the other, it wasn't clear from the CSS directly when they happened [17:27:02] (03Merged) 10jenkins-bot: ve.ce.Node: Clean up whitespace in rgba?() syntax [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116979 (owner: 10Krinkle) [17:27:52] edsanders: True. We also spoke about it during the stand-ups, if you recall. :-) [17:27:57] James_F: After you/Roan have reviewed, can you let us know whether it's good enough to fix up before the end of today (we can revise https://gerrit.wikimedia.org/r/#/c/116993/1 to include any other changes we want) - and alternatively confirm we want to revert if it's too nontrivial / needs more thinking for ux [17:28:15] Code looks reasonable to me [17:28:15] Krinkle: It will be part of the weekly code review, don't worry. [17:28:43] I'm not a big fan of the way this.$slugWrapper is checked for truthiness rather than non-emptiness, but .addClass()/.removeClass() on an empty selection doesn't hurt [17:29:09] Hmm, actually I guess it's fine because it gets nulled out so the next time around that code path won't be taken [17:30:41] James_F, not in any standup I was present at [17:30:44] hey guys [17:31:04] edsanders: I said it sounded cool and we'd need to look at it. [17:31:08] mooeypoo: Hey! [17:31:20] edsanders: It should have been noted on the commit. The timing was really unfortunate; James and I were talking about this on the way in and he was about to note this and -2 it when Timo merged it [17:31:29] So, good intentions, suboptimal communication, unfortunate timing [17:32:27] (03CR) 10Catrope: [C: 04-1] Pass surface set into ve.ui.Dialog and ve.ui.Inspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 (owner: 10Trevor Parscal) [17:33:39] (03CR) 10Catrope: [C: 032] WindowSet: Add support for overriding the creation a window [oojs/ui] - 10https://gerrit.wikimedia.org/r/116891 (owner: 10Trevor Parscal) [17:33:46] (03PS2) 10Trevor Parscal: Add more dialog sizes and make them switchable [oojs/ui] - 10https://gerrit.wikimedia.org/r/116892 [17:34:05] (03Merged) 10jenkins-bot: WindowSet: Add support for overriding the creation a window [oojs/ui] - 10https://gerrit.wikimedia.org/r/116891 (owner: 10Trevor Parscal) [17:34:11] nevermind, you reviews will come to the same conclusion anyway, which is that it's awesome [17:34:22] edsanders: I'm sure it is. :-) [17:36:06] James_F, did you see my mail? [17:36:17] RoanKattouw: Can you answer my question on the patch you just merged? [17:36:21] https://gerrit.wikimedia.org/r/#/c/116891/ [17:36:43] Krinkle: https://gerrit.wikimedia.org/r/#/c/116889/2/modules/ve/ui/ve.ui.WindowSet.js [17:36:52] Bottom 3 lines [17:37:35] (03CR) 10Krinkle: [C: 04-1] Pass surface set into ve.ui.Dialog and ve.ui.Inspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 (owner: 10Trevor Parscal) [17:37:36] RoanKattouw: OK [17:37:51] Krinkle, btw, thank you for the caps-to-lowercase corrections you submitted and merged with {boolean}.. it's actually not sublime, it's me forgetting not to capitalize. I'm forcing myself to get used to it, like Learning to Stop Writing Everything in Camel Case [17:38:01] Krinkle: hah good catch [17:40:04] edsanders: So.. what is https://gerrit.wikimedia.org/r/#/c/116742/1/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-vector.css supposed to do actually? It doesn't explain in the commit or on the bug why mediawiki/vector needs to zero out that 1px margin (whih btw, I phased out in my patch, so this'd have to change and/or bring back that 1px in core) [17:40:28] (03CR) 10Catrope: [C: 04-1] "Per James's comment" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116892 (owner: 10Trevor Parscal) [17:42:04] (03CR) 10Catrope: [C: 04-1] Make it possible to toggle the outline in a booklet layout (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [17:43:10] Krinkle, it was to kill the flicker when you start typing, but it looks unnecessary now [17:44:28] edsanders: You mentioned that flicker before but the other way around (it being there for you in ve standalone and needing the 1px to fix it) [17:48:00] I'm not seeing any flickers any more [17:48:30] that said in MW it doesn't really slide down [17:48:37] it snaps to large then wobbles a bit [17:48:46] (when you focus) [17:49:01] but holds steady when you start typing [17:50:06] mooeypoo: No? [17:50:46] (03CR) 10Catrope: [C: 031] "Code looks good, haven't tested yet." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 (owner: 10Esanders) [17:52:46] James_F, ... oops, who did I send the mail to [17:53:39] James_F, oh, I sent it to your wikimedia email. It's not urgent, but it has a weird issue there about the uberfix. Nothing that should prevent it from being merged, worse case it can be a small fix on top. It's just a bit baffling. [17:53:58] also, James_F, there will be issues with inline-to-block (and vise versa) until we sort out an inline image edit [17:54:11] especially with frameless being both [17:55:23] * James_F nods. [17:55:39] There are already issues with inline<->block, so… [17:56:51] yep [17:57:02] James_F, I was goin gover all the bugs, including ed's bug [17:57:05] most of the issues are solved [17:57:35] Good. :-) [17:58:13] except for issues of block/inline [17:58:21] Yeah. [17:58:44] James_F, these can just be a bit annoying because "frameless" with some mix of none alignments is an inline image [17:59:04] Framless|none, right? [17:59:09] or with actual alignment, it's block.. etc. So a user may encounter a situation where they edit a block and get an inline image they can't edit anymore. [17:59:10] yes [17:59:43] Yeah, I think Rummana reported that one. [17:59:50] Anyway, stand-up. [18:08:14] (03Abandoned) 10Esanders: Vector style tweaks for collapsible slugs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116742 (owner: 10Esanders) [18:13:54] ok, my computer crashed [18:13:55] :\ [18:14:11] mooeypoo: Yeah, but Timo and Trevor also dropped out of the call – we think there was a Google issue. [18:14:16] mooeypoo: Anyway, no matter. [18:14:35] ah, ok [18:14:45] tried to connect with my phone but that too kept tossing me out [18:15:01] James_F, anyways, i'll resend the email from yesterday [18:15:33] some weirdness is happening there. Might be an issue with the php parser, actually. [18:16:03] mooeypoo: Did you see cscott's bug comment in Parsoid? [18:16:48] about filing the bug? doing that now [18:17:12] oh, no, what? I think I missed something [18:20:07] edsanders: Very odd behaviour by your slug commit. [18:20:45] edsanders: https://www.dropbox.com/s/aiz9spntqxxfi90/Slug%20animation%20oddity.mov [18:22:38] James_F, betalabs is updated with master, right? [18:23:34] mooeypoo: Yes, Beta Labs currently has VE d7eaf9e, which is master. [18:24:13] awesomesauce [18:25:25] edsanders, Krinkle: Any thoughts? [18:28:56] James_F: What is the bug? Invisible cursor? That seems cut off to the left of the capture. [18:29:05] are you clicking or just hovering? [18:29:43] Krinkle: Clicking. The bug is that it jumps down and then back up. [18:30:09] James_F: I assume this is specific to that flow context and doesn't happen at the top of a plain document? [18:30:20] Are you testing in mw or in ve standalone. Better make sure the latter works first. [18:30:58] The update in core will be accomodated with style rules for vector. [18:31:02] Krinkle: No, it judders at the top of the document too, it's just worse in that particular context. [18:31:05] update in mwext* [18:31:12] And this is inside MW. [18:31:26] Well, OK, except Ed just abandonned the Vector-specific style commit. [18:31:49] Because that patch was no longer relevant, but I'm sure we'll find other rules that need changing inv ector [18:32:00] (Trevor and I changed implementation since that patch was created) [18:32:07] Sure. [18:32:12] So fix it, rather than abandon? [18:32:16] James_F: Can you make a capture of the bug on demos/ve in libs/ve@master ? [18:32:28] it was WFM when I abandoned it [18:32:30] It might seem the same to you, but it's all in the details. [18:32:48] as in, works for me here in chrome :) [18:33:25] It grows in an effectively downwards-looking transition [18:35:44] James_F: http://cl.ly/0f2U0h0s293m [18:36:47] that's how it looks for me too [18:38:25] Krinkle: Yeah, it's fine in tests, just broken in MW. [18:38:45] Krinkle: But of course this now blocks all normal pull-throughs of VE-core into VE-MW until it's fixed. [18:39:50] well, you say it's broken in MW [18:40:13] also it's sub-optimal broken, not broken broken [18:41:30] the main feature is collapsing the line height and providing the hover cue so people don't try to delete extra paragraphs [18:41:56] compared to that, a bit of flicker on the animation is a minor bug [18:44:34] It's not-going-out broken. [18:45:03] You can make arguments about how bad or good it is, but you don't have to represent the product, so tough. :-) [18:54:51] edsanders: when is tal going to be in SF? [18:54:59] TrevorParscal, 31st [18:55:06] until? [18:55:13] 29th? [18:55:13] 29th [18:56:31] James_F, that's silly James, the feature works exactly as it's supposed to bar a minor animation glitch - if it *really* upsets you we can disable the transitions for now [18:57:44] edsanders: It's not the animations that are broken, is it? [18:58:11] James_F, the heights in your video look correct [18:58:25] edsanders: So it's meant to get larger and then shrink? [18:58:31] it stays the same on hover, then expands on focus [18:59:02] edsanders: Yes, that bit's great. [18:59:15] getting large, then shrinking is a transition problem [18:59:15] edsanders: But on focus it goes small -> large -> medium. [18:59:19] the end points are fine [18:59:40] You sure it's not re-calculating the size or something odd? [19:00:25] also looking at your video "large" = "medium" + 1px, so it's a pretty small wobble [19:00:36] not sure the cause, I think there are two transitions (font size and margin) [19:00:49] Timo is looking into it no? [19:00:57] aren't you guys using the same OS/Browser? [19:01:44] Right. [19:01:49] I have no idea what Timo is doing. :-) [19:02:00] edsanders: James_F: Which one? [19:02:25] James_F, that's a general statement for all occasions [19:02:48] Krinkle, whatever James is using in his video [19:04:02] * James_F grins. [19:04:09] Krinkle: Chrome latest / OS X latest. [19:04:24] James_F: OS X latest sounds implausible [19:04:29] I did ask something but, just read through your convo, havent' seen a reply to that yet. [19:04:31] James_F: [19:04:39] I know which os/browser he uses [19:04:48] I can't reproduce that issue though, and would like to see it happen for him in standalone instead of mw. [19:05:33] James_F: it's never meant to shrink at any point [19:05:42] unless you click outside of it after having click/focussed it [19:05:51] see my video [19:05:55] http://cl.ly/0f2U0h0s293m [19:06:07] Krinkle: We've already had this discussion. [19:06:29] "But on focus it goes small -> large -> medium." I don't see that [19:06:34] In MW? [19:06:55] It's not in MW, and when it will be, the person making that commit should add rules to make it behave correctly. [19:06:58] Test in ve please. [19:07:14] AERAHBFKASLCJZSADCAS [19:07:15] FFS. [19:07:25] Krinkle: I HAVE TESTED IT IN VE CORE AND TOLD YOU IT IS FINE. [19:07:27] I know it's broken in MW, that's obvious, it wasn't build for that. [19:07:32] Krinkle: WE ARE TALKING ABOUT IT BEING BROKEN IN MW. [19:07:39] That was the one detail you haven't told me yet. [19:07:41] * James_F cries in the corner. [19:07:43] that it worked for you in ve core. [19:07:55] Krinkle: Not true. [19:08:00] James uses all caps to express patience and understanding [19:08:10] Yeah. This is me in a good mood. :-) [19:08:38] (03PS3) 10Trevor Parscal: Pass surface set into ve.ui.Dialog and ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 [19:09:46] (03CR) 10Catrope: [C: 032] "Minor comments inline, but merging anyway. Please fix them post-merge." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [19:10:11] mooeypoo: ---^^ +2ed because of urgency, but with inline comments and a bug report from James, both of which I'd like you to fix after it merges [19:11:19] RoanKattouw, okay [19:11:21] (03Merged) 10jenkins-bot: Deal with 'none'/'border' and default size in media edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo) [19:12:08] (03PS1) 10Jforrester: [WIP] Update VE core submodule to master (4513d9c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117018 [19:12:33] James_F: Anyway, it needing rules in mediawiki is no more than natural given that there's a huge number of extra styles (mediawiki core, vector etc.). So really, nothing is broken. Whenever a commit is made to mwext to update the submodule, we'll account for anything that needs integration, just like we do with everything else. WE'll figure it out, don't worry :) [19:12:54] That commit :) [19:13:01] Krinkle: Yes, except you did this on a Wednesday. [19:13:15] Krinkle: I.e. that "fix up" blocks merging all commits for the deployment run. [19:13:41] Krinkle: Hence my irritation. The code itself is awesome (thanks edsanders) and just needs a little work, but it's really badly timed. [19:13:58] (03PS4) 10Trevor Parscal: Pass surface set into ve.ui.Dialog and ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 [19:14:27] We don't have to update VE core in mwext, we can even update it to the commit before this one, or use wmf branches if we have to. And besides, this was an unforseen sideefffect because it seemed to work fine within ve-mw. I didn't plan to need a fixup, I was just quickly moving on after you mentioned. Afaik this is regular practice as you recommend it. [19:15:25] edsanders: James_F: Ill check out 117018 now to make any changes needed [19:15:51] Not regular practice as I recommend it. In general, code in VE-core that needs to be pulled through in VE-MW without modifications can be left, but you should check it works first. [19:16:14] (03CR) 10Trevor Parscal: Add more dialog sizes and make them switchable (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/116892 (owner: 10Trevor Parscal) [19:16:24] (03PS2) 10Trevor Parscal: Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 [19:16:26] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [19:16:40] Krinkle: VE-MW was sitting on master of VE-core before this commit (we try to keep them close), and there's lots of cool code from Ed and others that we'll want to pull through. [19:16:44] In general, we make merge to VE whenever a change is ready to be merged. If it obviously needs fixes in ve-mw, we should avoid that. However at the time of review of this change, I (and I think Ed as well) did not see any incompatibility with ve-mw, so just like any other random change merged in ve-core, it was fine to merge. [19:16:55] Absolutely. [19:20:09] edsanders: Is https://gerrit.wikimedia.org/r/#/c/107142/ un-WIP-able? [19:20:29] James_F, NO [19:20:30] No [19:20:40] edsanders: OK. (Boo.) [19:20:41] (03PS3) 10Trevor Parscal: Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 [19:20:43] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [19:21:02] it's blocked on rewriting some getoffset code [19:21:05] edsanders: Do you know how you're going to get it to be un-WIP-able? [19:21:06] Right. [19:27:01] James_F: Please do product review of: https://gerrit.wikimedia.org/r/#/c/116993/ https://gerrit.wikimedia.org/r/116754 https://gerrit.wikimedia.org/r/116902 https://gerrit.wikimedia.org/r/116968 https://gerrit.wikimedia.org/r/116132 https://gerrit.wikimedia.org/r/116661 (low prio: https://gerrit.wikimedia.org/r/105231 ) [19:27:09] (03PS3) 10Trevor Parscal: Add more dialog sizes and make them switchable [oojs/ui] - 10https://gerrit.wikimedia.org/r/116892 [19:27:10] (In roughly that order) [19:27:49] (03CR) 10Jforrester: [C: 031] "Product happy." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116993 (owner: 10Esanders) [19:28:24] (03PS4) 10Trevor Parscal: Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 [19:28:26] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [19:29:21] (03CR) 10Catrope: [C: 04-1] Make the 'full size' button optional (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116647 (owner: 10Mooeypoo) [19:29:50] mooeypoo: Re https://gerrit.wikimedia.org/r/#/c/116647/1/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js , AFAICT the 'originaldimensions-available' event is both unused and undocumented, can it be killed? [19:30:44] RoanKattouw, absolutely, that's actually not supposed to be there. I missed it when redoing that commit. I'll post another patch. [19:30:55] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/116754/ needs testing but not product review, it's the same behaviour but less buggy [19:34:55] (03PS2) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (a7609fed77) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116895 [19:35:37] (03PS5) 10Trevor Parscal: Pass surface set into ve.ui.Dialog and ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 [19:38:32] (03PS3) 10Trevor Parscal: Update VE core submodule to 4513d9c21a9502b2fc2d9b6739c2dac0af21e03e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 [19:42:41] (03PS2) 10Mooeypoo: Make the 'full size' button optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116647 [19:43:39] (03CR) 10Catrope: [C: 032] Slightly strong shading on slug hover target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116993 (owner: 10Esanders) [19:44:36] (03Merged) 10jenkins-bot: Slightly strong shading on slug hover target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116993 (owner: 10Esanders) [19:45:44] (03PS4) 10Trevor Parscal: [WIP] Update VE core submodule to 4513d9c21a9502b2fc2d9b6739c2dac0af21e03e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 [19:46:09] edsanders: James_F: I can reproduce the bug in standalone ve if I make the grey box/border visible at all times instead of just during hover [19:46:19] the problem is that we're adding padding to inside the

in the slug [19:46:20] (03PS2) 10Trevor Parscal: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 [19:46:25] which regular paragraphs don't have [19:46:34] we're trying to make the box bigger while the font-size is still small [19:46:50] the only way to make it bigger than it would be without the padding is by increasing the font-size [19:46:57] (03CR) 10jenkins-bot: [V: 04-1] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal) [19:47:06] (03PS1) 10Mooeypoo: Inline CR fixes for Media Edit Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117025 [19:47:07] which is fine, the only thing we'll give up with that is the cursor animating more prominently [19:47:17] I don't know if a growing cursor was an intentional ux thing or not [19:48:44] (03PS3) 10Trevor Parscal: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 [19:49:07] (03PS5) 10Trevor Parscal: Update VE core submodule to 4513d9c21a9502b2fc2d9b6739c2dac0af21e03e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 [19:49:16] (03CR) 10jenkins-bot: [V: 04-1] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal) [19:51:33] Krinkle, I did the font size transition like that original for that reason [19:51:47] *orignally [19:52:07] TrevorParscal removed it because he always thinks he knows better :) [19:52:29] ???? [19:52:42] It's okay, we'll send you on a CSS training course [19:52:42] oh, animating font sizes is really bad [19:52:52] (03CR) 10Catrope: [C: 032] Store previous range in breakpoint for undo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 (owner: 10Esanders) [19:53:35] edsanders: Figured it out [19:54:41] (03Merged) 10jenkins-bot: Store previous range in breakpoint for undo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116754 (owner: 10Esanders) [19:57:42] TrevorParscal: Please review icon stuff https://gerrit.wikimedia.org/r/115664 https://gerrit.wikimedia.org/r/116475 https://gerrit.wikimedia.org/r/116471 [19:58:58] (03PS1) 10Trevor Parscal: Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 [19:59:14] (03CR) 10jenkins-bot: [V: 04-1] Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [20:06:25] (03CR) 10Catrope: [C: 04-1] Hack for preventing opacity-related rendering glitches (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [20:06:41] TrevorParscal: See inline comment on ---^^ for something that might surprise you [20:07:30] (03CR) 10Catrope: [C: 032] Make the 'full size' button optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116647 (owner: 10Mooeypoo) [20:08:26] (03Merged) 10jenkins-bot: Make the 'full size' button optional [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116647 (owner: 10Mooeypoo) [20:09:45] (03CR) 10Catrope: [C: 032] Support platform specific message in keyboard shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116964 (owner: 10Esanders) [20:10:47] (03Merged) 10jenkins-bot: Support platform specific message in keyboard shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116964 (owner: 10Esanders) [20:16:29] (03PS1) 10Krinkle: ve.ce.Node: Don't use padding or height in the slug transition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117034 [20:16:58] edsanders: James_F: Was able to patch it in ve-core instead without a ve-mw override. [20:18:16] (03PS2) 10Krinkle: ve.ce.Node: Don't use padding or height in the slug transition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117034 [20:20:36] (03CR) 10Catrope: [C: 04-1] "Minor comments inline" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116965 (owner: 10Esanders) [20:20:46] Krinkle: Awesome, thanks [20:21:03] edsanders: Shortcut change looks good to merge today, but there's something weird going on with event emission, could you comment? --^^ [20:28:44] ryasmeen, woot, are you verifying the fixing of all the bugs? [20:34:30] (03CR) 10Catrope: [C: 032] Add cmd/ctrl+y as alternative shortcut for redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116966 (owner: 10Esanders) [20:36:53] (03PS2) 10Catrope: Add cmd/ctrl+y as alternative shortcut for redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116966 (owner: 10Esanders) [20:45:24] yes mooeypoo, verified 62013,61155 and 62024 so far :) [20:45:42] woooo [20:46:01] :) [20:47:32] Argh [20:47:56] TrevorParscal: I experimented with making the reference dialog small, and it's just a few px too big so it has a tiny vertical scrollbar :( [20:49:23] However mooeypoo, I am getting this issue where if I make the position of an image to Right and Image type to Basic/Frame , it goes totally outside of the page [20:51:16] (03CR) 10Catrope: [C: 032] ve.ce.Node: Don't use padding or height in the slug transition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117034 (owner: 10Krinkle) [20:52:14] (03Merged) 10jenkins-bot: ve.ce.Node: Don't use padding or height in the slug transition [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117034 (owner: 10Krinkle) [21:04:14] ryasmeen, hmm [21:18:06] ryasmeen, I can't manage to replicate. What image did you choose to switch to basic/right when this happened? I chose thumb|left -> basic right, and it works for me [21:20:29] (03PS2) 10Catrope: Support multiple shortcuts per trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116965 (owner: 10Esanders) [21:22:32] (03CR) 10Catrope: [C: 032] Support multiple shortcuts per trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116965 (owner: 10Esanders) [21:22:37] (03PS3) 10Esanders: Add cmd/ctrl+y as alternative shortcut for redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116966 [21:23:30] (03Merged) 10jenkins-bot: Support multiple shortcuts per trigger [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116965 (owner: 10Esanders) [21:24:42] (03CR) 10Catrope: [C: 032] Add cmd/ctrl+y as alternative shortcut for redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116966 (owner: 10Esanders) [21:24:46] (03PS2) 10Esanders: Add cmd/ctrl+m as alternative shortcut for clear formatting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116967 [21:24:56] (03CR) 10Catrope: [C: 032] Add cmd/ctrl+m as alternative shortcut for clear formatting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116967 (owner: 10Esanders) [21:25:45] (03Merged) 10jenkins-bot: Add cmd/ctrl+y as alternative shortcut for redo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116966 (owner: 10Esanders) [21:26:15] (03Merged) 10jenkins-bot: Add cmd/ctrl+m as alternative shortcut for clear formatting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116967 (owner: 10Esanders) [21:28:31] Argh [21:29:03] There's a bug with rendering multiple shortcuts in the shortcuts dialog, but it wasn't exposed because all multi-shortcut actions just happened to be the last item in their section [21:30:15] edsanders: You done wrong. [21:30:49] I'm looking into it [21:31:33] (03PS1) 10Catrope: Add Ctrl+? shortcut for the shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117087 [21:32:07] (03CR) 10Catrope: [C: 04-2] "This exposes a bug in the rendering of multi-shortcut actions in the shortcuts dialog :( looking into it" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117087 (owner: 10Catrope) [21:36:32] mooeypoo: if you go this page and see the first image that I added in it:http://en.wikipedia.beta.wmflabs.org/wiki/5thfebchrome?veaction=edit [21:38:14] ryasmeen, ok [21:38:15] (03PS2) 10Catrope: Add Ctrl+? shortcut for the shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117087 [21:38:17] (03PS1) 10Catrope: Fix rendering of multi-shortcut actions in shortcut dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117092 [21:38:30] (03CR) 10Catrope: Add Ctrl+? shortcut for the shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117087 (owner: 10Catrope) [21:38:42] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/117092/1 [21:38:59] ryasmeen, it's already aligned right. if i make it 'basic' it loses its frame, as it should. I... don't see the problem. [21:39:07] ryasmeen, what browser are you using? [21:39:47] (03CR) 10Trevor Parscal: [C: 032] Fix rendering of multi-shortcut actions in shortcut dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117092 (owner: 10Catrope) [21:39:48] moeeypoo , yeah just talked to James_F about it, its an expected behavior [21:40:01] I was using chrome by the way [21:40:57] (03Merged) 10jenkins-bot: Fix rendering of multi-shortcut actions in shortcut dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117092 (owner: 10Catrope) [21:44:11] ryasmeen, you mean the size is too big? [21:44:24] ryasmeen, if so, yeah, that's expected... it's "default" size ( = full size) [21:45:02] mooeypoo: Yay for MW's sensible image options. :-( [21:45:04] yeah I get it now [21:45:33] heh [21:45:38] i DID find a bug though [21:45:45] James_F, it's with the shield [21:45:56] ryasmeen, go to that page you gave me, now make the top image "thumb" [21:46:02] mooeypoo: Of course there is. Yay shields. [21:46:03] now the shielf of the second image covers the one of the top [21:46:05] * James_F grumbles about CE. [21:46:18] I'm not sure why this happens though :\ [21:46:29] James_F, heh.. it seems to be changing sizes ? [21:46:31] James_F: I'm sure CE would grumble about you if it had vocal chords [21:46:53] James_F, see here, make the top image "thumb" http://en.wikipedia.beta.wmflabs.org/wiki/5thfebchrome?veaction=edit [21:46:58] rdwrer: But it's wrong. :-) [21:47:47] James_F: CE is always wrong. [21:47:58] yes , moooeypoo, I am getting different issues with shields/phantoms [21:48:07] :\ [21:48:50] James_F, I also posted that bug about captions, so the redundant | should go away at some point [21:48:55] it's in parsoid [21:49:48] mooeypoo: Right. [21:54:17] mooeypoo: Erk, https://bugzilla.wikimedia.org/show_bug.cgi?id=62279 [21:55:46] yeah I saw that. Hah. I didn't think about rounding the user-inputted values. Do we want to not allow dots at all, or just round off the result on 'apply' ? [21:57:21] (03PS3) 10Catrope: Add Ctrl+Shift+/ shortcut for the shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117087 [21:57:36] James_F: ---^^ is ready to merge now [21:58:31] (03CR) 10Jforrester: [C: 032] Add Ctrl+Shift+/ shortcut for the shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117087 (owner: 10Catrope) [21:59:28] (03Merged) 10jenkins-bot: Add Ctrl+Shift+/ shortcut for the shortcuts dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117087 (owner: 10Catrope) [22:19:54] (03CR) 10Catrope: [C: 032] Cleanup SpecialCharacterInspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116660 (owner: 10Esanders) [22:20:54] (03Merged) 10jenkins-bot: Cleanup SpecialCharacterInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116660 (owner: 10Esanders) [22:25:38] (03CR) 10Catrope: [C: 04-1] "Also needs a pull commit that removes GroupButtonWidget from VisualEditor.php" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116661 (owner: 10Esanders) [22:32:07] James_F, i am a little confused. Is the wiki default thumb size settings a bounding box, or a width ? I thought it was a bounding box (docs are, of course, lacking) but I am starting to think I was wrong, or that it restricts the smaller side [22:34:11] James_F: The slug change looks good to me except for https://bugzilla.wikimedia.org/show_bug.cgi?id=62285 , are you happy for it to go out with that? [22:35:31] (03PS1) 10Catrope: Update VE core submodule to master (e64d6e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117097 [22:42:37] (03PS6) 10Catrope: Update VE core submodule to 4513d9c21a9502b2fc2d9b6739c2dac0af21e03e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 (owner: 10Trevor Parscal) [22:50:53] (03PS1) 10Catrope: Make the order of insert tools consistent in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117101 [22:54:37] (03CR) 10Catrope: Make new category suggestion section for hidden categories (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116132 (owner: 10Alex Monk) [22:59:05] James_F: https://gerrit.wikimedia.org/r/117097 [22:59:54] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (e64d6e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117097 (owner: 10Catrope) [23:00:33] (03CR) 10Jforrester: [C: 032] Make the order of insert tools consistent in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117101 (owner: 10Catrope) [23:01:06] (03Merged) 10jenkins-bot: Update VE core submodule to master (e64d6e7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117097 (owner: 10Catrope) [23:01:38] (03CR) 10Catrope: [C: 032] Special character inspector styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116661 (owner: 10Esanders) [23:02:03] (03Merged) 10jenkins-bot: Make the order of insert tools consistent in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117101 (owner: 10Catrope) [23:05:49] (03CR) 10Catrope: [C: 032] Special character inspector styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116661 (owner: 10Esanders) [23:06:49] (03Merged) 10jenkins-bot: Special character inspector styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116661 (owner: 10Esanders) [23:16:42] (03PS1) 10Catrope: Force thumb and frameless images to default size in DM [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117106 [23:40:02] (03PS1) 10Catrope: Update VE core submodule to master (165594b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117110 [23:40:30] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (165594b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117110 (owner: 10Catrope) [23:40:53] (03PS4) 10Catrope: Add more dialog sizes and make them switchable [oojs/ui] - 10https://gerrit.wikimedia.org/r/116892 (owner: 10Trevor Parscal) [23:41:35] (03CR) 10Catrope: [C: 032] Add more dialog sizes and make them switchable [oojs/ui] - 10https://gerrit.wikimedia.org/r/116892 (owner: 10Trevor Parscal) [23:41:52] (03PS5) 10Trevor Parscal: Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 [23:41:54] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [23:41:59] (03Merged) 10jenkins-bot: Add more dialog sizes and make them switchable [oojs/ui] - 10https://gerrit.wikimedia.org/r/116892 (owner: 10Trevor Parscal) [23:42:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (165594b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117110 (owner: 10Catrope) [23:42:26] (03CR) 10Esanders: "They don't _need_ text, but where we have plenty of room we should for clarity, cf. the text formatting dropdown. I don't think it looks u" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders) [23:42:28] (03CR) 10Catrope: [C: 032] Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [23:42:30] (03CR) 10jenkins-bot: [V: 04-1] Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [23:42:54] (03CR) 10Jforrester: [C: 04-1] "The left- and right-align icons still look like an American flag (one reversed), and differ from the centre-align one (no lines above, lik" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115664 (owner: 10Esanders) [23:44:09] (03PS2) 10Jforrester: Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [23:44:19] (03PS3) 10Trevor Parscal: Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 [23:44:33] (03PS6) 10Catrope: Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [23:44:54] (03CR) 10Catrope: [C: 032] Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [23:45:13] (03PS4) 10Trevor Parscal: Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 [23:45:45] (03CR) 10jenkins-bot: [V: 04-1] Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [23:45:47] (03CR) 10jenkins-bot: [V: 04-1] Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [23:46:46] (03Merged) 10jenkins-bot: Make it possible to toggle the outline in a booklet layout [oojs/ui] - 10https://gerrit.wikimedia.org/r/116893 (owner: 10Trevor Parscal) [23:50:18] (03CR) 10Jforrester: [C: 031] "On reflection, happy to go out once icons are fixed up." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders)