[00:00:13] (03CR) 10MarkTraceur: [C: 032] mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117230 (owner: 10Jforrester) [00:00:26] (03CR) 10MarkTraceur: [C: 032] mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117228 (owner: 10Alex Monk) [00:01:39] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117230 (owner: 10Jforrester) [00:02:39] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117228 (owner: 10Alex Monk) [00:03:17] James_F: Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=54965#c5 [00:03:32] MatmaRex: I saw. TrevorParscal's the one whose code it is. [00:04:26] (on a side note, new opera's debugger ain't half bad.) [00:06:43] Thanks MatmaRex [00:10:24] (03CR) 10Krinkle: [C: 04-1] Create mixin for ce nodes that responds to dblclick (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen) [00:10:35] (03PS9) 10Krinkle: Mixin ClickableNode with ce nodes that have tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen) [00:13:06] (03CR) 10jenkins-bot: [V: 04-1] Mixin ClickableNode with ce nodes that have tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen) [00:21:24] (03CR) 10Krinkle: "Code looks fine, untested. I'm a bit suspicious of how the emission of events happen. Event handlers (the DOM ones, not EventEmitter ones)" (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen) [00:37:55] Hey James_F. If you're around, can you help me with the OPW stuff I asked about ^. [00:38:32] madhuvishy: Hey! [00:38:35] madhuvishy: Yes, absolutely. [00:38:58] madhuvishy: What are you interested in doing, specifically? There are lots of kinds of plug-in you could build for VisualEditor. [00:39:19] madhuvishy: This one? https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Visual_translation:_Integration_of_page_translation_with_Visual_Editor [00:41:19] Okay! Yes, I was thinking of building a plugin, like the one mentioned there (one to insert or modify Wikidata content) - or any plugin that's high on feature requests. The page translation integration sounds challenging too, but I have done a lot of JS but no PHP so not sure if I'm the right person for that. [00:42:52] James_F ^ [00:43:11] * James_F nods [00:43:58] madhuvishy: I think the language one is probably the most-desired / high request, but it's important that you find it interesting/useful too. :-) [00:44:32] madhuvishy: It would be mostly in JS, I think; Niklas would be the expert on what changes might be needed. [00:46:34] James_F, Ah yes, it does sound interesting. The tags "difficult project" and "PHP" made me pause though. :) [00:46:55] But I will be game to learn stuff and work towards it [00:47:54] madhuvishy: :-) [00:48:10] madhuvishy: There are others too, you shouldn't feel like this is your only option. [00:48:37] James_F, sumanah says Hi from Hackerschool :) [00:48:46] madhuvishy: Awesome. Hi back! :-) [00:49:43] madhuvishy: The advantage (I would say this, wouldn't I!) to the translation work is that there are lots of pieces to it, and even if you don't get them all done each piece done is a great step forwards. [00:49:55] James_F, :) [00:50:14] madhuvishy: On the other hand, it means that you don't get anything "shiny" for users to play with until quite late in the project, which is had. [00:50:18] Err. Bah. [00:50:23] James_F, Right. [00:50:25] "… which is sad". [00:52:10] * madhuvishy oscillates between shiny new plugin and translation work [00:53:28] James_F, okay, can I do some research, poke my head into some code to find out more about the translation project? [00:56:40] madhuvishy: Of course! [00:56:43] also it's not listed here : https://www.mediawiki.org/w/index.php?title=FOSS_Outreach_Program_for_Women/Round_8#Featured_project_ideas [00:57:02] James_F, okay, any pointers on where I can get started? [00:57:10] madhuvishy: Hmm, it should be there. [00:57:53] madhuvishy: It's at https://www.mediawiki.org/w/index.php?title=FOSS_Outreach_Program_for_Women/Round_8#Visual_translation:_Integration_of_page_translation_with_Visual_Editor but not in "Featured Projects". [00:57:57] Anyway [00:58:05] Ah right. [00:58:18] madhuvishy: https://www.mediawiki.org/wiki/Extension:Translate has a sort-of introduction [00:58:28] madhuvishy: (That's the bit that's in PHP and currently doesn't work with VisualEditor.) [00:58:47] Okay... [00:59:32] madhuvishy: https://www.mediawiki.org/wiki/Help:Extension:Translate#Content_translation includes some high-level details from the user side. [00:59:44] madhuvishy: https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_example is more detailed about what it feels like to the user. [01:00:17] madhuvishy: https://www.mediawiki.org/wiki/Help:Extension:Translate/Components is "Translate explained for developers", though it's marked as "in progress". [01:00:53] James_F, great, thanks! [01:01:18] madhuvishy: (I'm not sure how helpful it is – it would be worth speaking to the i18n team to get advice.) [01:03:12] James_F, Aah. Okay. I will read all this stuff and poke you again with more questions. [01:10:51] Thanks for all the help. [01:10:58] madhuvishy: Brilliant. Happy to help. [01:11:09] James_F, :) [10:09:38] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [10:10:46] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal) [11:34:50] hey Krinkle, you around? [11:36:48] there's https://bugzilla.wikimedia.org/show_bug.cgi?id=62366 which might be related to the latest VE update on wikipedias? It's being reported today. [12:23:48] (03CR) 10Siebrand: Re-label "Transclusion" button to "Template", as that's now the default (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117151 (owner: 10Jforrester) [13:03:31] :D :D @ the last grrrit-wm's comment [13:15:33] gry: for more awe, https://www.mediawiki.org/wiki/VisualEditor?veaction=edit and try to edit the template on the right. [13:16:27] note to self: reminding James that nearly-white-grey is not an option for parameters' descritpion. [13:17:32] good note [13:18:05] when adding a new template does it include some fields ('required' ones) by default? [13:18:19] i'd play with citeweb but it's not at this wiki [13:21:07] yes, sorry I can't remember templates with TemplateData at mw.org . [13:21:59] ahh ok [14:04:24] (03CR) 10Esanders: "I'm not sure these can be iconed as they're weird MW specific concepts. Most don't consistently have a border or caption so trying to desc" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders) [16:18:24] (03PS1) 10Esanders: Add indicators to demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/117421 [16:19:45] (03PS1) 10Esanders: Balance margins around icon on iconed ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/117422 [16:20:47] (03PS2) 10Esanders: Balance margins around icon on iconed ButtonWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/117422 [16:37:14] (03PS2) 10Esanders: Add indicators to demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/117421 [16:42:55] (03PS1) 10Esanders: Add missing 75% transparency to add-item [oojs/ui] - 10https://gerrit.wikimedia.org/r/117426 [16:43:42] (03CR) 10Mooeypoo: [C: 031] "Works for me." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/114770 (owner: 10Ltrlg) [16:45:35] (03PS3) 10Esanders: Add indicators to demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/117421 [16:46:33] (03PS4) 10Esanders: Add indicators to demo page [oojs/ui] - 10https://gerrit.wikimedia.org/r/117421 [17:14:36] (03PS1) 10Esanders: Add missing returns documentation to getSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117430 [17:59:10] (03CR) 10Robmoen: "I like the idea of not binding to things that will just be buried. Perhaps per your suggestion I could determine all of the possible mix" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen) [18:27:31] hi, Roan and James. thanks for looking into 62366 [18:29:27] Elitre: Bad bug. :-( [18:29:33] Krinkle: Heya. [18:30:41] Elitre: Thanks for reporting it, [[User:Whatamidoing (WMF)]] independently reported getting lots of needcheck-tagged edits in RC on enwiki, which is the same bug :) [18:31:10] (03CR) 10Jforrester: "> I'm not sure these can be iconed as they're weird MW specific concepts." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders) [18:31:50] James_F: Internet is flaky, will be back later to push more. [18:31:58] Krinkle: Cool. [18:32:18] you're welcome. fridays are hard :) [18:36:09] Argh, they're actually separate bugs [18:36:16] One of them is the one I thought I deployed a fix for on Wednesday [18:36:25] Except the fixed code seems to not actually be on enwiki somehow [18:36:57] The |upright thing is a separate bug [18:37:30] RoanKattouw, so this is slightly more complex than I thought. We have a blur/focus events on the document which we can use to set a focused state, but there's also the possible that focus was given to an inspector, in which case the selection is still visible, so the document selection should still be usable [18:37:41] Well, probably. It seems that fixing this bug may mask the |upright bug [18:37:53] edsanders: Riiight [18:38:17] RoanKattouw, just for sharing the fun, did you know parser has a method called "maybeMakeExternalImage" *and* another called "maybeMakeExternalImage2" ? [18:38:43] edsanders: As a proxy, maybe track whether focus remains inside of a descendant of ve-ui-surface or something? [18:38:51] mooeypoo: Yeah that sounds like the parser :( [18:39:14] Although that is somewhat bad even relative to other parser code [18:39:24] but then we don't get a blur event if you go from inspector -> something else [18:39:40] But from my current investigation, it seems like the thumbsize user option is strictly for width UNLESS there's 'upright' and then it's not. [18:41:14] Ha! [18:41:24] Soooo, that corruption fix that I thought I deployed on Wednesday... [18:41:33] Well, I wrote it on Wednesday, it just never got deployed anywhere [18:41:35] Oops [18:41:40] RoanKattouw, what we need is a selection change event [18:43:14] (03PS1) 10Catrope: Work around DOM corruption for default-sized images [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117445 [18:44:22] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/117161/ [18:45:16] (03CR) 10Mooeypoo: "From my current investigation and playing with different outputs, it seems as 'thumbsize' user option works for limiting width, unless the" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo) [18:48:21] RoanKattouw, that fixes the issue on loading the images, though it doesn't yet deal with upright [18:48:33] Yeah, I just assessed the state of |upright in master [18:48:38] The sizing isn't right [18:48:46] But |upright isn't removed unless you change the size [18:48:53] Even if you touch the caption or the alignment [18:49:20] RoanKattouw, the 'upright' was the next thing I was going to deal with. The first step was to make sure default size is only limiting width instead of being a bounding box [18:49:24] see the fix above [18:50:01] I'm going to try and emulate the Parser with 'upright' but the Parser code is pretty... elaborate [18:50:33] just for the sake of organization, I"ll build that fix for upright on top of the default width fix I have pending now, to make things easier on review [18:56:02] Oooh that fix will be nice [18:56:05] Just saw the commit msg [18:57:08] I just noticed I wrote "two things" and there are 4 [18:57:09] hah [18:59:46] mooeypoo: ~10 years ago I used to watch this show that would parody people, mostly politicians [18:59:59] So around the election debates they'd have a fake debate skit on their show [19:00:20] (03PS1) 10Jdlrobson: Re-enable VisualEditor's toolbar icons on mobile. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117447 [19:00:32] One of the politicians they were parodying often enumerated lots of points [19:01:03] So in the skit, he'd interject or answer a question by saying "I would like to say seven things about that" [19:01:10] haha [19:01:22] rmoen: Give me a minute, walking over to the big monitor [19:01:34] Well, I did work in diplomacy for a while, i may have been more affected than I thought..... [19:01:43] RoanKattouw: no worries [19:04:48] RoanKattouw, see parsoid chat about 'upright' btw. Might have to wait with supporting it? [19:06:25] hey James_F [19:06:45] so how can i stop lib/oojs-ui/oojs-ui.svg.css from loading now… o_O? [19:06:52] i missed a memo i think [19:07:15] jdlrobson: skinStyles. [19:07:26] James_F: but Minerva is not a registered skin.. [19:07:32] jdlrobson: "default" is set to pull in oojs-ui-apex.css, but you can vary that. [19:07:32] and it's not in core.. [19:07:46] did we fix the brokenness of skinStyles too? [19:07:46] Ah. That's… an issue. [19:07:59] skinStyles is a broken part of RL [19:08:00] I don't know – was Krinkle|detached working on something to do with that? [19:08:13] in my opinion it should be done via hooks or something. [19:08:33] oh god yes please let's kill skinStyles [19:08:37] If you see resources/Resources.php it can be over-ridden with a different value. [19:08:57] jdlrobson: finally something we agree about :D [19:13:25] James_F: I do not follow… anyway.. skinStyles should die horribly and the skin itself should have the ability to disable styles on certain modules in place of their own if they want to. [19:17:56] jdlrobson: Talk to Trevor, not me. :-) [19:29:03] James_F: jdlrobson: We fixed skinStyles not being read properly by the max-timestamp cache invalidation logic, thus essentially any change to files in skinStyles wouldn't appear on any mw install with caching until a another file in that module that isn't in skinStyles gets updated. [19:29:34] in case of jquery.ui and ve, we quite often update the .js files too, so it didn't always trigger [19:29:42] * James_F nods. [19:29:51] Krinkle: How's that e-mail about jQuery update coming, BTW? [19:30:19] but a hot-fix to ve.mw.viewpagetarget-vector.css didn't get deployed previously and we always found out randomly and touched it again and again to no end until we either gave up or touched an unrelated file to purge it [19:30:38] James_F: Good, was able to reduce it a lot by linking to jQuery's blogpost and upgrade guide. It's pretty good. [19:31:49] (03CR) 10Mooeypoo: [C: 031] "Works for me." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (owner: 10Ltrlg) [19:31:58] Krinkle, ^^ when you get time [19:32:25] (03PS1) 10Esanders: WIP Disable certains tools when surface loses focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [19:32:42] Krinkle: Want me to review still? [19:33:03] Yep, will send you a draft via eitherpad later today. Got caught u in a few other things first. [19:33:11] No worries. :-) [19:40:39] Krinkle: so the issue here is really that Minerva (mobile skin) is not in core and has no way to register skinStyles [19:40:59] which is also a problem for custom skins that live in their own extension - it would be good to have a generic solution to this [19:49:57] jdlrobson: Yes, I said that while in SF. [19:50:11] TrevorParscal seemed open to the idea [19:50:14] as well [19:50:23] Krinkle: yup just reiterating this discussion [19:51:01] hmm guys, if i were to propose a gsoc skinning cleanup project that would include that, can i expect someone to mentor me? :D [19:51:06] Krinkle: we just need to come up with a non-evil way to allow RL modules to be hooked into [19:51:16] jdlrobson: The method I'm thinking of using is a hook that will provide additional skinStyles. [19:51:19] The problem is module context [19:51:28] The files you'd register would be in your extension [19:51:35] MatmaRex: yeah, I think there are a few people that might be down for that [19:51:45] whereas the module you're extending would be in core (or some other extension) [19:51:56] that causes all kinds of conflicts and incompatibilities, starting with the file path expansion. [19:52:25] Krinkle: no no no... you just have to be able to define a skin style as a module name [19:52:31] which introduces a dependency [19:52:36] bye guys, have a nice weekend. [19:52:39] and is imported using styles only [19:53:17] at least one idea [19:53:24] TrevorParscal: Can't use actual dependencies though, as that'll break in unexpected ways with regards to addModuleStyles [19:53:32] plus efficiency and module registry in general [19:53:49] maybe resolve server-side by concatenating the module styles of the other module in getStyles [19:54:23] you could also make it so OOJS-UI depends on a module, which is an object, which is hookable [19:54:24] so you'd create a module, but not register it (how?) and use that object in skinStyles, which we'd then resolve as its own module and then concat [19:54:38] and that module, say ResourceLoaderThemeModule could be reused in other places too [19:55:18] no changes in the API or dependency system, just needs some rigging to be able to interact with existing ResourceLoaderThemeModule objects [19:56:35] RoanKattouw: https://www.mediawiki.org/w/index.php?title=Typography_refresh/Font_choice/Test&diff=922942&oldid=922936 :-) [20:05:13] (03PS1) 10JGonera: Remove unneeded assignment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117459 [20:08:32] (03CR) 10Catrope: [C: 032] Work around DOM corruption for default-sized images [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117445 (owner: 10Catrope) [20:09:45] (03Merged) 10jenkins-bot: Work around DOM corruption for default-sized images [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117445 (owner: 10Catrope) [20:15:09] RoanKattouw / James_F the 'upright' fix will have to wait for Parsoid, just fyi. [20:15:32] OK [20:15:34] mooeypoo: You mean editing of upright images? I know. [20:15:36] So for the moment, there's a fix in gerrit for limiting width-only (and small changes) [20:15:40] * James_F nods. [20:15:43] James_F, even recognizing and sizing them properly [20:15:49] James_F: Deployment done [20:15:49] Sorry, yes, that too. [20:16:03] But the corruption bug is fixed (masked) by RoanKattouw's deployment, right? [20:16:13] RoanKattouw: Thanks. :-) [20:16:33] yep, and the gerrit fix will adjust the way VE sizes images [20:16:41] that should fix both [20:18:00] * James_F nods. [20:30:09] Argh... xs4all has some kind of issue where IP prefixes (IPv6 prefixes) are being invalidated causing my connection to drop for 20 minutes or more (yesterday it was for several hours) [20:30:27] Meanwhile when searching on Twitter is see they're giving internet to Ukraine via dial-up, theirs is working :P [20:31:17] Libyans, not Ukraine, I think [20:31:36] Both even. [20:34:46] https://twitter.com/xs4all/status/274631880429670400 https://twitter.com/CogitoAnon/status/442029666564853761 [20:34:48] interesting :) [21:20:20] Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=62405 would be nice to fix if you have a moment. (OOjs documentation bug.) [21:34:52] (03PS1) 10Krinkle: inheritClass: Use Class.super instead of this.constructor.super [oojs/core] - 10https://gerrit.wikimedia.org/r/117479 [21:35:41] James_F: More than a documentation bug, "fortunately" we still haven't started using .super, but we likely would've made the same mistake. [21:35:57] Though we have sufficient number of sub classes that our unit tests would never pass with that though [21:37:40] Krinkle: *nods* [21:40:36] /back [21:41:22] (03CR) 10Catrope: [C: 032] Re-enable VisualEditor's toolbar icons on mobile. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117447 (owner: 10Jdlrobson) [21:53:29] RoanKattouw: TrevorParscal: James_F: So the rfc meet that's supposed to start in a few minutes, is that for real? [21:55:24] (03Merged) 10jenkins-bot: Re-enable VisualEditor's toolbar icons on mobile. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117447 (owner: 10Jdlrobson) [21:56:36] Krinkle: I don't know, I'll ask TrevorParscal when he's done talking to Alolita [22:02:49] first real use for mw.libs.ve.addPlugin! https://he.wikipedia.org/wiki/MediaWiki:Gadget-VeExtendedBar.js [22:04:14] eranroz: Hey. [22:04:25] hi [22:04:27] eranroz: Is that dir=rtl/ltr editing? [22:04:53] it is related - a button for adding ‏ [22:05:01] Ah. [22:05:03] Interesting! [22:05:05] which is very useful for Hebrew/Arabic [22:05:09] Yeah. [22:06:48] eranroz: BTW instead of ve.init.mw.targets[0].surface you can do this.toolbar.getSurface() [22:07:09] eranroz: Also, VE Gadgets! Awesome! :D [22:07:14] Yeah. :-) [22:08:42] RoanKattouw: thanks. fixed it (https://he.wikipedia.org/w/index.php?title=%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Gadget-VeDirectionMarkTool.js&diff=15209445&oldid=15209333) [22:20:20] Awesome [22:22:21] (03CR) 10Catrope: [C: 04-1] Enforce width-only default size only on larger images (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo) [22:22:29] mooeypoo: Minor non-code comments --^^ [22:32:05] rmoen: So I talked to James about the TOC widget and he says it should appear in the correct place (maybe not respecting __TOC__, but at least in the default position, i.e. before the first heading) rather than at the top before we could merge/enable this feature [22:32:10] Which... argh [22:32:11] eranroz: I've made a minor edit with some coding conventions you might find useful. Note that it's all ran through a minifier by the server, so whitespace is not an issue [22:32:35] If doing that is difficult we'd probably just want to feature flag what you have now, get it merged, then move it to the correct position [22:32:43] (03PS1) 10Cmcmahon: Updates to transclusion tests should turn build green [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117611 [22:32:49] Cause putting it in the right place may not be doable without doing all that DM stuff [22:32:54] RoanKattouw: I'm confused because right now it is in the default place. [22:32:59] No, it's not [22:33:03] It's all the way at the top, isn't it? [22:33:17] (03PS2) 10Cmcmahon: (browsertests) Updates to transclusion tests should turn build green [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117611 [22:33:22] RoanKattouw: Its in the same element that the standard toc element is in [22:33:23] If there is text before the first heading ("section 0"), that'll be below the TOC in your implementation, but above the TOC in the MW view [22:33:50] RoanKattouw: Really? [22:34:20] Yeah I just confirmed it locally [22:34:40] GET https://upload.wikimedia.org/wikipedia/commons/thumb/4/4e/VisualEditor_-_Icon_-_Move-ltr.svg/24px-VisualEditor_-_Icon_-_Move-ltr.svg.png 404 (Not found) [22:34:50] Krinkle: ... wat? [22:34:59] https://he.wikipedia.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7Sandbox?veaction=edit [22:35:03] Oh [22:35:14] GET https://upload.wikimedia.org/wikipedia/commons/thumb/4/4e/VisualEditor_-_Icon_-_Move-ltr.svg/24px-VisualEditor_-_Icon_-_Move-ltr.svg.png 404 (Not found) [22:35:15] jQuery.fn.extend.addClass [22:35:15] OO.ui.PopupToolGroup.setActive [22:35:19] Weird [22:35:19] RoanKattouw: that is so strange because its being put into $( '#bodyContent' ) [22:35:57] RoanKattouw: I will look into that [22:38:19] Krinkle: thanks for the coding convention fix. didn't understand the icon issue [22:38:21] (03PS3) 10Cmcmahon: (browsertests) Updates to transclusion tests should turn build green [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117611 [22:38:32] rmoen: It's because that's where the real view content is, and all that stuff gets hidden in favor of the VE surface [22:38:33] rmoen: Beware, here be dragons, etc.: putting it in the middle of the surface may prove difficult [22:39:25] RoanKattouw: Aye [22:48:05] Krinkle: I just added /* @noflip */ to the gadget css. it seems that the problem in the icon is due to RL automaticlly replace RTL to LTR for ?uselang=en :) [22:48:25] eranroz: Yeah if you have -ltr / -rtl in your file name, that happens :) [22:48:54] RoanKattouw: Didn't think that would apply to urls though [22:48:58] that's pretty cool [22:48:59] We ran into that for the language inspector where we have icons representing "this text is ltr" and "this text is rtl" [22:49:01] Krinkle: Yeah of course it does [22:49:06] See undo/redo icons for instance [22:49:11] RoanKattouw: You say that but I'm pretty sure we've never ever used that [22:49:13] undo is something like arrow-ltr and redo is arrow-rtl [22:49:17] for http urls [22:49:26] Yeah not for external URLs [22:49:33] But we use it for local images all the time [22:49:37] yeah [22:51:00] I know it may change css but thought it ignores urls. but it is a cool feature [22:57:16] (03PS4) 10Jforrester: [Browser tests] Updates to transclusion tests should turn build green [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117611 (owner: 10Cmcmahon) [22:57:49] (03CR) 10Jforrester: "This seems sane (and understandable), but I can't run the tests locally so…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117611 (owner: 10Cmcmahon) [23:19:40] (03PS4) 10Ltrlg: Make TemplateDataGenerator use new types [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 [23:19:53] (03PS2) 10Ltrlg: Do not add 'required' if not set and false wanted [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/114770 [23:22:32] [07-Mar-2014 23:20:57] Fatal error: Call to a member function getId() on a non-object at /usr/local/apache/common-local/php-1.23wmf16/extensions/VisualEditor/VisualEditor.hooks.php on line 158 [23:22:32] Server: mw1025 [23:22:35] from #mediawiki-core [23:22:46] ...there's a mediawiki-core channel [23:22:47] What [23:23:06] yeah, for WMF's Core team [23:25:38] Sigh. [23:25:46] yeah. [23:25:47] This would probably be solved by moving wikibugs. [23:26:52] About the actual error: Probably not VE's fault - why is MediaWiki firing the PageContentSaveComplete hook with a null Revision object? [23:27:23] (03CR) 10Krinkle: Do not add 'required' if not set and false wanted (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/114770 (owner: 10Ltrlg) [23:27:25] (03CR) 10Krinkle: [C: 032] Do not add 'required' if not set and false wanted [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/114770 (owner: 10Ltrlg) [23:27:45] mooeypoo: what are you flights? [23:27:51] (03Merged) 10jenkins-bot: Do not add 'required' if not set and false wanted [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/114770 (owner: 10Ltrlg) [23:27:59] like, when do you arrive, depart, what flights are you on? [23:28:03] we are trying to schedule stuffs [23:28:50] and, if you want like - rides home from the airport... [23:31:57] (03CR) 10Krinkle: Make TemplateDataGenerator use new types (033 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (owner: 10Ltrlg) [23:32:26] (03CR) 10Krinkle: [C: 04-1] "Few minor code quality points." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/113183 (owner: 10Ltrlg) [23:33:29] TrevorParscal / James_F checking hang on [23:39:32] Krinkle: I always feel scared when I do this, but we definitely always load jQuery and mediaWiki before anything else, right? [23:39:57] rdwrer: Yes, but if the browser ins't supported then neither loads [23:40:05] if(window.mw){ [23:40:11] rdwrer: What context are you in? [23:40:46] modules=startup is the first rl-controlled script tag, and it doesn't finish until jquery|mediawiki is loaded and doesnt' l oad anything else until it does so [23:41:23] anything that isn't controlled by RL that uses RL stuff (e.g. mw.config.set) is therefor wrapped in that conditional [23:41:25] Krinkle: MMV [23:41:28] k [23:41:32] So yeah [23:41:34] That's fine then [23:41:41] Fewer dependencies makes it easier [23:41:51] rdwrer: Where in MMV are you asking this yourself? [23:41:59] Debugging something? [23:42:28] (03PS1) 10Alex Monk: Fix fatal when user switches from VE to the old editor and makes a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 [23:42:39] (03CR) 10jenkins-bot: [V: 04-1] Fix fatal when user switches from VE to the old editor and makes a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 (owner: 10Alex Monk) [23:43:05] (03CR) 10Alex Monk: Track edits where user switched into wikitext editor from VE (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113665 (owner: 10Alex Monk) [23:43:10] Krinkle: Just running through our module defs and cleaning them up [23:43:21] Like, moving dependencies, messages, etc. [23:43:27] ah, yeah, don't add mw or jq to your deps [23:43:42] in fact, since they aren'y loaded by mw.loader, adding them as deps might cause them to be loaded *again* [23:43:47] leading to all kinds of weird stuff [23:44:11] we should blacklist them and selfdestruct the CPU if this is detected during startup [23:44:17] Hah [23:44:25] Will do. [23:44:43] * Krinkle adds unit test to core [23:45:31] (03PS2) 10Alex Monk: Fix fatal when user switches from VE to the old editor and makes a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 [23:46:28] Krinkle: Thought: Should our init script be top-loaded? [23:46:47] It modifies the click event of all images on the page, which may include things above the fold [23:47:03] rdwrer: Does it make visual changes above the fold? [23:47:31] No, just behaviour [23:47:50] In that case I'd defer. There's not much gain in blocking the html parser for that [23:47:56] it has to wait for the body to be ready anyway [23:48:10] so you'd basically load from the top only to bind a ready event for when the page is ready [23:48:18] so bottom [23:48:36] 'kay [23:49:56] (03CR) 10Krinkle: Fix fatal when user switches from VE to the old editor and makes a null edit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 (owner: 10Alex Monk) [23:57:16] (03CR) 10Alex Monk: Fix fatal when user switches from VE to the old editor and makes a null edit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 (owner: 10Alex Monk)