[00:54:17] <grrrit-wm>	 (03PS2) 10Jforrester: Keep label and disabled state of transclusion dialog apply button in sync [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal)
[00:54:30] <grrrit-wm>	 (03CR) 10Jforrester: [C: 04-1] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal)
[09:00:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal)
[09:07:27] <grrrit-wm>	 (03PS18) 10Amire80: [WIP] [Browser test] Testing typing in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/83966 
[12:58:13] <Fannon>	 Hi! Is somebody here, working on the VisualEditor? I've got some questions about it - and thinking about contributing to the project
[13:15:14] <Fannon>	 Hello! I've got a few Questions about the VisualEditor Project and I'm thinking about mabybe contributing it. Someone here to talk to?
[13:50:45] <Fannon>	 Hello! I've got a few Questions about the VisualEditor Project and I'm thinking about mabybe contributing it. Someone here to talk to?
[13:55:59] <Elitre>	 Hi Fannon, you need technical information I guess? In that case, all the devs are away, as you can see - it's almost 7 am in San Francisco, but those located elsewhere might be available soon.
[13:56:19] <Fannon>	 Hello Elitre!
[13:56:38] <Fannon>	 yes, you're right about the techical information
[13:57:13] <Fannon>	 thank for the info! then I'll wait some time
[13:57:41] <Elitre>	 you're welcome.
[13:57:53] <Fannon>	 All Dev's are working in SF ?
[13:59:14] <Elitre>	 no, but I don't know where the others are - they might be travelling, or something :)
[13:59:25] <Fannon>	 ok ;)
[14:14:33] <Elitre>	 otherwise, Fannon, I suggest you leave your question at https://www.mediawiki.org/wiki/VisualEditor/Feedback .
[14:18:44] <Fannon>	 ok, I still have to wrap my head around the VisualEditor / Parsoid / Wikitext.next Projects
[14:18:54] <Fannon>	 so its hard to formulate fixed questions right now
[14:26:59] <Elitre>	 well, you'll want to think of precise questions for devs anyway :)
[14:29:36] <Fannon>	 yes, I have some starting points ;)
[14:29:48] <Fannon>	 but you're right... i'll get some more information first
[15:03:20] <cscott>	 the README in visual editor is a mess
[15:03:31] <cscott>	 it refers to a non-existent CODING.md, and CONTRIBUTING.md says, "We inherit the contribution guidelines from VisualEditor core. Be sure to read the Contribution guidelines in the VisualEditor repository." where "Contribution guidelines" is a hyperlink to.... CONTRIBUTING.md.
[17:18:39] <grrrit-wm>	 (03PS1) 10Krinkle: ve.ce.Node: Change slug color from darker grey to lighter blue/grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117895 
[17:18:41] <grrrit-wm>	 (03PS1) 10Krinkle: ve.ce.Node: Emphasise growing action through outline offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 
[17:18:47] <grrrit-wm>	 (03PS2) 10Krinkle: ve.ce.Node: Emphasise growing action through outline offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 
[17:18:49] <grrrit-wm>	 (03PS2) 10Krinkle: ve.ce.Node: Change slug color from darker grey to lighter blue/grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117895 
[17:19:36] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Node: Emphasise growing action through outline offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 (owner: 10Krinkle)
[17:19:45] <James_F>	 Krinkle: Heya.
[17:20:02] <James_F>	 Krinkle: See ^^^ cscott's request to fix the README.md files in VE repos pointing at each other. :-)
[17:22:21] <grrrit-wm>	 (03PS3) 10Krinkle: ve.ce.Node: Emphasise growing action through outline offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 
[17:22:44] <Krinkle>	 James_F: I said that Friday
[17:22:58] <James_F>	 Krinkle: I know.
[17:26:33] <grrrit-wm>	 (03PS1) 10Krinkle: Fix dead links in README.md and CONTRIBUTING.md [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117897 
[17:28:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix dead links in README.md and CONTRIBUTING.md [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117897 (owner: 10Krinkle)
[17:28:45] <James_F>	 Krinkle: Thanks.
[17:29:16] <Krinkle>	 James_F: btw, nice that one can preview it in gitblit
[17:29:16] <Krinkle>	 https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FVisualEditor/7599551aef00b98595990dc7c53b6bd99b28a2d4/README.md
[17:29:19] <Krinkle>	 before merging
[17:29:34] <Krinkle>	 "```php" doesn't work apparantly
[17:29:45] <James_F>	 Krinkle: Ooh, is that new?
[17:29:46] <Krinkle>	 I'll attribute that to gitblit's weird parser though
[17:30:03] <Krinkle>	 https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/CONTRIBUTING.md#running-tests
[17:30:04] <Krinkle>	 no
[17:30:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix dead links in README.md and CONTRIBUTING.md [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117897 (owner: 10Krinkle)
[17:30:15] <Krinkle>	 https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FVisualEditor/7599551aef00b98595990dc7c53b6bd99b28a2d4/CONTRIBUTING.md
[17:30:23] <James_F>	 I thought git.wikimedia.org only got code once it was merged?
[17:30:37] <Krinkle>	 James_F: No, it's a mirror of gerrit's repo.
[17:30:45] <James_F>	 Interesting.
[17:31:04] <Krinkle>	 But any clone of it (like yours and our local ones) won't contain any of it because git only traverses branches you check out 
[17:31:08] * James_F  nods.

[17:32:07] <Krinkle>	 The link is in the gerrit UI, too "(gitblit)", for each patch set
[17:33:04] <James_F>	 Now you say that, I see it. :-)
[17:33:11] <James_F>	 Yay for interface blindness.
[18:19:36] <Krinkle>	 TrevorParscal: https://gerrit.wikimedia.org/r/#/c/117895/ Let me know what you think
[18:19:45] <Krinkle>	 TrevorParscal: And follow-up https://gerrit.wikimedia.org/r/#/c/117896/
[18:23:52] <InezK>	 Hello :)
[18:24:31] <InezK>	 RoanKattouw: Maybe you could help.. I need to create a class for showing and hiding editor loading indicator, and later on saving indicator.
[18:25:04] <InezK>	 I was thinking about calling it ve.indicator, but the problem is, that I need to use it in "init", when ve "namespace" is not used yet. Do you have some idea how to handle it?
[18:25:29] <InezK>	 I was thinking, that maybe my new class could initialize ve to {}, and then current ve.js instead of overwriting it - it would extend it
[18:26:50] <James_F>	 Krinkle: https://gerrit.wikimedia.org/r/#/c/117896/ 's commit message doesn't mention the word "slug" at all, despite that being what you're changing.
[18:29:28] <grrrit-wm>	 (03PS4) 10Krinkle: ve.ce.Node: Emphasise slug transition with increasing outline offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 
[18:29:41] <grrrit-wm>	 (03CR) 10Krinkle: "@Trevor: It seems useful to have this kind of emphasis, but not sure if this is" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 (owner: 10Krinkle)
[18:30:57] <James_F>	 Krinkle: Thanks. :-)
[18:31:45] <RoanKattouw>	 InezK: "indicator" is already a term that is used in oojs-ui
[18:31:54] <RoanKattouw>	 Oh, hmm
[18:32:18] <InezK>	 RoanKattouw: ok, we can call it then progressIndicator or something like this, but the main problem still remains
[18:32:27] <RoanKattouw>	 If it's MW-specific you could attach it to mw.libs.ve instead and then move it to ve when it becomes available?
[18:32:27] <RoanKattouw>	 I don't know
[18:32:28] <RoanKattouw>	 Maybe Krinkle has idea
[18:32:30] <RoanKattouw>	 s
[18:33:22] <Krinkle>	 InezK: This is for MW/Wikia integration, right?
[18:34:43] <Krinkle>	 In that case I'd put it in mw.libs.ve.* or wikia.* (do you have your own global?)
[18:34:51] <Krinkle>	 RoanKattouw: I'm also thinking of doing the same for all of our MW stuff
[18:35:13] <Krinkle>	 e.g. no ve.ui.MWDialog but mw.ve.Dialog or something
[18:35:18] <Krinkle>	 .ui.*
[18:35:22] <InezK>	 We don't have single Wikia global :) we have just bunch of globals.. and I don't want to create a new one :)
[18:35:26] <Krinkle>	 Namespace pollution
[18:35:37] <InezK>	 Krinkle: and yes - this is for MW/Wikia integration
[18:36:13] <Krinkle>	 InezK: mw.libs.ve.* is probably best. Though as general javascript structure, you should probbaly have a mw.wikia.ve or wikia.ve at some point, but prolly not justified to do all that for just this one thing.
[18:36:30] <Krinkle>	 Don't have to move it to ve.* after init though, you can keep it there. 
[18:36:51] <InezK>	 mw.libs.ve sounds pretty good for now, I will give it a try
[18:36:53] <Krinkle>	 that also makes it harder to mess up when accessing it (it'll require you to do /*global mw */ and thus make sure the file is mw specific)
[18:37:47] <InezK>	 RoanKattouw, Krinkle: thanks
[18:38:21] * mooeypoo  is finally here

[18:39:51] <mooeypoo>	 James_F, anyhoos, what do I do with this? https://bugzilla.wikimedia.org/show_bug.cgi?id=62293
[18:40:24] <mooeypoo>	 do we know if this is something specific to an OS or specific to an image? or... I can't replicate, and it seems neither can you? :\
[18:44:42] <James_F>	 mooeypoo: Did you mean that bug or the other one?
[18:45:24] <James_F>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=61282 specifically.
[18:45:44] <James_F>	 I was going to ask Rummana to do a full cache clear and reproduce, and then mark as "WFM"…
[18:47:55] <Rummana>	 James_F , I could reproduced it using another OS/Browser and added the comment in the bug
[18:48:42] <Rummana>	 I am going to try again now
[18:48:43] <mooeypoo>	 oops. yes, the other one
[18:48:56] <mooeypoo>	 that one I posted should be fixed real soon (fixing up Roan's CR comments now)
[18:49:23] <mooeypoo>	 Rummana, the latest comment on the bug -- the wikitext output ? that's intended behavior
[19:02:59] <grrrit-wm>	 (03PS3) 10Mooeypoo: Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 
[19:03:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo)
[19:05:16] <grrrit-wm>	 (03PS4) 10Mooeypoo: Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 
[19:11:52] <Rummana>	 mooeypoo, I just added a new screenshot in the bug ,reproduced it using windows 8 and chrome
[19:13:34] <Rummana>	 However, the behavior is slightly different than MAC OSX ,it appears as a bar going out of the border of the page
[19:14:06] <James_F>	 RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=49603
[19:15:28] <grrrit-wm>	 (03PS1) 10Catrope: Stop special-casing comments and recognize them as tagName='#comment' instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 
[19:18:22] <mooeypoo>	 Rummana, i'm testing it now again in chrome/win8
[19:19:02] <Rummana>	 ok
[19:19:45] <mooeypoo>	 Rummana, do you have a ready test page?
[19:20:33] <Rummana>	 I reproduce it on :http://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_(WMF)?veaction=edit
[19:21:50] <mooeypoo>	 hah! I just clicked on 0's to make the number big
[19:21:56] <mooeypoo>	 and now I have 8e+21in "width"
[19:22:06] <mooeypoo>	 ... overshooting, just a bit
[19:22:28] <Rummana>	 yes, that is another issue , I showed James_F other day
[19:22:43] <mooeypoo>	 that's not really an issue
[19:22:57] <mooeypoo>	 8e+21 is a mathematical way of saying 8 with 21 zeros
[19:23:02] <Rummana>	 also mooeypoo, if you try t delete those extra 0s it will turn into a fraction number in the width
[19:23:10] <mooeypoo>	 but we probably do need to figure out a limit 
[19:23:25] <mooeypoo>	 which extra zeros?
[19:23:46] <mooeypoo>	 so I'm at 80000000000 and still the image behaves ok
[19:23:59] <Rummana>	 the ones you keep on adding to make the number big
[19:24:28] <mooeypoo>	 800000000000000 ... still good
[19:24:40] <Rummana>	 Did you select the image type Frame?
[19:24:51] <mooeypoo>	 yup
[19:24:55] <mooeypoo>	 Frame / right
[19:24:59] <mooeypoo>	 80000000000000000000 <-- still good
[19:25:11] <mooeypoo>	 but, really, do we really expect people to play with numbers that big?
[19:25:20] <mooeypoo>	 shouldn't we just limit those in any case?
[19:25:21] <mooeypoo>	 James_F, 
[19:25:45] <mooeypoo>	 and Rummana the fraction isn't a fraction, it's just scientific notation
[19:26:11] <mooeypoo>	 6.8e+21 is 68e+20 or 68 and 20 zeros after it. It's just a way to write the number. 
[19:26:17] <mooeypoo>	 Granted, it's a little ridiculous in images
[19:26:33] <mooeypoo>	 which is why I think we might want to limit the size at some point even if wikitext doesn't.
[19:26:47] <Rummana>	 so for the first image on that page , I didnt try 800000000000, I just added zeros to the default size like 640000000000000 for Width
[19:26:52] <Rummana>	 can you try that?
[19:27:21] <mooeypoo>	 yah, applied, the image is huge
[19:27:49] <Rummana>	 hmm :\
[19:28:17] <mooeypoo>	 there, I managed to replicate
[19:28:21] <mooeypoo>	 when the image has scientific notation
[19:28:24] <Rummana>	 phew!
[19:28:35] <mooeypoo>	 64e+22
[19:28:36] <mooeypoo>	 that did it.
[19:29:02] <Rummana>	 yay! :)
[19:29:07] <mooeypoo>	 James_F, can we please limit the size of all images so no user is allowed to give a ridiculously horrific 64e+22 width?
[19:29:12] <mooeypoo>	 :P
[19:29:50] <mooeypoo>	 I *could* tell the widget to literally translate the notation back into raw pixels... but... it sounds like the issue is more about limiting that size to begin with
[19:30:39] <mooeypoo>	 James_F, we can limit to .. like... 10,000pixels? is that ok? just to put some sane cap there.
[19:33:36] <James_F>	 mooeypoo: That seems sane.
[19:39:23] <helderwiki>	 Is this supposed to be possible (splitting a table into two tables using VE)? https://pt.wikipedia.org/w/index.php?diff=38365876
[19:40:12] <mooeypoo>	 James_F, some images seem to be limited to their max size and some aren't
[19:40:52] <James_F>	 mooeypoo: SVGs are.
[19:41:39] <mooeypoo>	 hm, I have a jpg that seems to be too
[19:42:13] <mooeypoo>	 http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Mooeypoo/Test
[19:42:51] <James_F>	 Oh, yeah, there are image display types that have size limits.
[19:42:58] <mooeypoo>	 James_F, [[File:Hedrick (1921) - Bartlett.jpg|800000000000000000000000000000000000000000px|frame|Caption]] <-- and yet, the image seems to have width="920"
[19:43:11] * mooeypoo  shakes fist at wikitext

[19:43:16] <mooeypoo>	 so.. what do I limit to? :\
[19:44:38] <James_F>	 mooeypoo: |frame images limit to original size.
[19:44:46] <James_F>	 mooeypoo: |thumb and |frameless /don't/, I think.
[19:46:19] <mooeypoo>	 James_F,  :\ http://en.wikipedia.beta.wmflabs.org/wiki/User:Mooeypoo/Test
[19:46:23] <mooeypoo>	 so far, it seems they all are
[19:49:53] <mooeypoo>	 This is super confusing. and the docs are worthless.
[20:14:37] <James_F>	 mooeypoo: Yeah. :-(
[20:17:29] <mooeypoo>	 James_F, I'm going to leave this for now until I run more tests to figure out what to limit when. I'll work on the magnify button for the moment, I think that's the last "big" bug left.
[20:19:51] <mooeypoo>	 anyone knows when does "onSplice" run? is it only on creation and edit of the node?
[20:20:22] * James_F  nods.

[20:22:57] <grrrit-wm>	 (03PS2) 10Catrope: Stop special-casing comments and recognize them as tagName='#comment' instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 
[20:22:59] <grrrit-wm>	 (03PS1) 10Catrope: Make DOM<->model tests actually display message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117923 
[20:23:01] <grrrit-wm>	 (03PS1) 10Catrope: Make 'comment' its own metaitem type [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 
[20:23:16] <RoanKattouw>	 mooeypoo: onSplice runs when a node's children array is modified
[20:24:04] <mooeypoo>	 hmmm
[20:24:26] <TrevorParscal>	 mooeypoo: if a node's length is changed (like a paragraph node as you type text) an update happens
[20:24:28] <mooeypoo>	 RoanKattouw, so, wait, I'm confused. The MWImageCaptionNode is a child of MWBlockImageNode
[20:24:43] <RoanKattouw>	 Yes
[20:24:50] <TrevorParscal>	 we only splice when we really have to add/remove/replace a whole node
[20:24:51] <mooeypoo>	 so when does MWImageCaptionNode's onSplice triggered?
[20:24:58] <RoanKattouw>	 mooeypoo: It has a TextNode child
[20:24:59] <mooeypoo>	 it's already the child
[20:25:00] <mooeypoo>	 oh
[20:25:04] <mooeypoo>	 so only on text change.
[20:25:16] <RoanKattouw>	 Nope
[20:25:29] <RoanKattouw>	 Only construction or insertion/removal of inline nodes like templates and inline images
[20:25:46] <mooeypoo>	 hm
[20:25:47] <RoanKattouw>	 Text changes are simple length changes on the TextNode, they don't destroy&recreate so they don't splice
[20:26:00] <RoanKattouw>	 They do cause a length update on the CaptionNode
[20:26:03] <mooeypoo>	 why is the magnify button even dealt with there then
[20:26:22] <RoanKattouw>	 I don't know
[20:26:33] <mooeypoo>	 This bit of code is a bit confusing. It seems to also work backwards (though the behavior itself is good) .. if it's thumb, "detach"
[20:26:38] <mooeypoo>	 that's backwards ... 
[20:26:45] <RoanKattouw>	 Yeah that seems like a terrible idea
[20:26:46] <mooeypoo>	 The whole segment there is confusing me 
[20:26:50] <RoanKattouw>	 It shouldn't be in onSplice
[20:26:59] <RoanKattouw>	 Ooooh I see why it's in there though
[20:27:02] <RoanKattouw>	 Needs access to the parent
[20:27:07] <mooeypoo>	 well
[20:27:08] <RoanKattouw>	 But there's other stuff for that
[20:27:12] <mooeypoo>	 I am thinking one of two things though
[20:27:23] <RoanKattouw>	 Like the attach event
[20:27:34] <mooeypoo>	 either I trigger the magnify from the parent itself -- like, on type change of MWBlockImageNode
[20:27:51] <mooeypoo>	 *or* I always have the magnify there, and I just hide/show it with CSS dependent on styles
[20:27:57] <mooeypoo>	 to save building/detaching it 
[20:28:05] <RoanKattouw>	 Oooh the latter would be clever
[20:28:22] <mooeypoo>	 that's what I thought of doing in the first place, but then the onSplice threw me off
[20:28:43] <RoanKattouw>	 It's just because the parent isn't known at construction time
[20:28:52] <mooeypoo>	 wspecially since it seems to be backwards... shouldn't it be *built* if the parent is thumb, though?
[20:29:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Restore error box to VE demo page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117652 (owner: 10Esanders)
[20:29:45] <mooeypoo>	 It's like we're destroying and retaching it every time the caption for the thumb gets changed. Hm.
[20:29:49] <mooeypoo>	 ok, I'll work on this. Just got confused. Thanks!
[20:30:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: Restore error box to VE demo page [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117652 (owner: 10Esanders)
[20:31:13] <grrrit-wm>	 (03PS2) 10Trevor Parscal: Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 
[20:34:55] <grrrit-wm>	 (03CR) 10Robmoen: "Responded to comments. Incoming patch which covers most of this." (0316 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen)
[20:34:58] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.ce.Node: Change slug color from darker grey to lighter blue/grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117895 (owner: 10Krinkle)
[20:35:11] <grrrit-wm>	 (03CR) 10Catrope: "Trevor and James said this looks good" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117895 (owner: 10Krinkle)
[20:35:23] <grrrit-wm>	 (03PS11) 10Robmoen: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 
[20:36:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ce.Node: Change slug color from darker grey to lighter blue/grey [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117895 (owner: 10Krinkle)
[20:36:45] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen)
[20:50:55] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core submodule to master (a2ac637) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117926 
[20:51:42] <grrrit-wm>	 (03PS1) 10Mooeypoo: Show/hide the magnify button on type change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117928 
[20:51:44] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (a2ac637) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117926 (owner: 10Catrope)
[20:52:22] <grrrit-wm>	 (03PS1) 10Catrope: Update VE core for comment updates and update VE-MW accordingly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117929 
[20:53:03] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update VE core for comment updates and update VE-MW accordingly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117929 (owner: 10Catrope)
[20:53:09] <mooeypoo>	 wait.. what's.. that file 
[20:53:22] <mooeypoo>	 A file snuck into my commit!
[20:53:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (a2ac637) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117926 (owner: 10Catrope)
[20:53:32] <RoanKattouw>	 mooeypoo: Yeah I saw
[20:53:35] <RoanKattouw>	 Side effect from running grunt
[20:53:39] <RoanKattouw>	 It must be out of date
[20:53:40] * RoanKattouw  fixes

[20:53:42] <mooeypoo>	 ah
[20:53:48] <mooeypoo>	 is it a rebase issue?
[20:53:52] <RoanKattouw>	 Maybe
[20:53:54] <RoanKattouw>	 But probably grunt
[20:53:56] <mooeypoo>	 weird
[20:54:38] <mooeypoo>	 ok, anyways, I figured out why it was in onSplice, and it should work properly in hiding/showing the magnify button now through CSS. Though I was a bit smartass'y with the :not() rule
[20:55:01] <mooeypoo>	 as far as I saw, it should be supported in most browsers
[20:55:43] <RoanKattouw>	 Yeah :not is fine
[20:55:51] <RoanKattouw>	 We use way more exotic stuff than that
[20:56:39] <mooeypoo>	 yeah, I was concerned with the mix of :not() with typeof but there was no need for any special asterixes in the 'typeof' this time, so I think this is probably safe
[20:57:04] <RoanKattouw>	 mooeypoo: Why is the magnify icon rebuilt every time
[20:57:20] <mooeypoo>	 it's rebuilt when the caption changes structure
[20:57:24] <RoanKattouw>	 There is no href in there (it's commented out)
[20:57:26] <mooeypoo>	 without it, the icon seemed to be at the bottom 
[20:57:33] <RoanKattouw>	 Ooooh right
[20:57:38] <mooeypoo>	 it moved around without being rebuilt
[20:57:42] <RoanKattouw>	 Yeah that makes sense
[20:58:28] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Show/hide the magnify button on type change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117928 (owner: 10Mooeypoo)
[20:58:30] <mooeypoo>	 yeah I tried at first to just attach it directly, but then saw why onSplice was needed :)
[20:58:39] <RoanKattouw>	 Crap, canceled +2
[20:58:45] <RoanKattouw>	 That file is still in there, I was gonna fix that
[20:58:59] <mooeypoo>	 wait, +2 with that file
[20:59:01] <mooeypoo>	 oh
[21:00:33] <grrrit-wm>	 (03PS1) 10Catrope: Rebuild eg-iframe.html for e1d8ebd in VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117932 
[21:00:43] <RoanKattouw>	 mooeypoo: Do me a favor and merge that ---^^ , then rebase your commit
[21:04:07] <James_F>	 mooeypoo: (Do it, do it!)
[21:04:48] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] "Per Roan" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117932 (owner: 10Catrope)
[21:05:09] <James_F>	 Whee.
[21:05:37] <mooeypoo>	 wooooo
[21:05:50] <mooeypoo>	 So that's how you merge-pong?
[21:06:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rebuild eg-iframe.html for e1d8ebd in VE core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117932 (owner: 10Catrope)
[21:06:19] <grrrit-wm>	 (03PS2) 10Mooeypoo: Show/hide the magnify button on type change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117928 
[21:07:20] <mooeypoo>	 yay, the stray file vanished
[21:07:42] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117928 (owner: 10Mooeypoo)
[21:07:45] <James_F>	 mooeypoo: Yes. :-)
[21:08:40] <mooeypoo>	 hah
[21:09:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Show/hide the magnify button on type change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117928 (owner: 10Mooeypoo)
[21:09:10] <mooeypoo>	 yay
[21:15:46] <mooeypoo>	 TrevorP|Away / edsanders|away I remember you guys changed the resizable handles a little while back? I wanted to verify with you before I take a stab at this: https://bugzilla.wikimedia.org/show_bug.cgi?id=62283
[21:16:11] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Table of contents widget (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen)
[21:16:36] <grrrit-wm>	 (03CR) 10Catrope: Table of contents widget (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen)
[21:17:13] <RoanKattouw>	 mooeypoo: TrevorP|Away went home sick and edsanders|away is on vacation in what looks like the Alps or something
[21:17:29] <mooeypoo>	 oh! I thought he just showed an image he downloaded from Commons.
[21:17:30] <mooeypoo>	 :D
[21:17:46] <mooeypoo>	 "Here's a mountain" was so random.
[21:18:05] <RoanKattouw>	 It's pretty quiet today
[21:18:19] <RoanKattouw>	 David is also on vacation, in Iceland, although I think today is their last day there
[21:18:42] <mooeypoo>	 yeah David I knew was on vacation
[21:18:48] <mooeypoo>	 Ed's vacation looks pretty epic
[21:20:32] <mooeypoo>	 ok, I'll leave it 'till they get back, then. I see that they purposefully added in multi-directional resize handles, so I don't want to touch it before I go over it with one of them.
[21:20:43] <matanya>	 hi mooeypoo 
[21:20:47] <mooeypoo>	 heya matanya 
[21:20:48] <James_F>	 RoanKattouw: https://bugzilla.wikimedia.org/buglist.cgi?bug_status=PATCH_TO_REVIEW&list_id=284574&order=priority%2Cchangeddate%2Cbug_severity&product=VisualEditor&query_based_on=&query_format=advanced
[21:21:33] <matanya>	 any news regarding the https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%A2%D7%95%D7%A8%D7%9A_%D7%97%D7%96%D7%95%D7%AA%D7%99/%D7%9E%D7%A9%D7%95%D7%91#.D7.9E.D7.A1.D7.A4.D7.95.D7.A8_.D7.94.D7.A2.D7.A8.D7.AA_.D7.A9.D7.95.D7.9C.D7.99.D7.99.D7.9D
[21:22:37] <mooeypoo>	 matanya, sorry, which one on the feedback page is that
[21:22:49] <matanya>	 last
[21:23:43] <mooeypoo>	 ok, I remember having a talk a while back, didn't check about status though
[21:24:15] <mooeypoo>	 James_F, you remember there was an issue with reference numbering after edit?
[21:24:19] <matanya>	 same for https://bugzilla.wikimedia.org/show_bug.cgi?id=58315
[21:25:08] <mooeypoo>	 Yeah that one's not sorted yet
[21:25:29] <mooeypoo>	 I can't find the bug report for the references... I'm looking for the one I saw last time
[21:26:47] <James_F>	 Fun.
[21:27:50] <mooeypoo>	 James_F, I could've sworn I've seen the bug but I can't find it now. Do you remember there was an issue with weird numbering for references when the reference list is edited? I can just post a new bug, but I could've sworn it was there.
[21:29:32] <James_F>	 mooeypoo: Bug 50474 perhaps?
[21:30:05] <mooeypoo>	 hm, no, there was an issue with renumbering of the references.
[21:30:13] <mooeypoo>	 I'll add the bug again, if it's a dupe, we'll find and undupe it.
[21:30:33] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo)
[21:31:44] <mooeypoo>	 it's a similr issue though
[21:32:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo)
[21:32:08] <mooeypoo>	 woot
[21:33:35] <mooeypoo>	 wait, yes, it was that. matanya, the issue was editing reference through template, right?
[21:33:43] <mooeypoo>	 I'm reviewing the diff again
[21:33:54] <matanya>	 yes, i think it was
[21:34:46] <mooeypoo>	 yeah. I forgot to connect the bug to the report in the feeback page
[21:35:09] <grrrit-wm>	 (03PS1) 10Krinkle: ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 
[21:36:26] <grrrit-wm>	 (03CR) 10Krinkle: Stop special-casing comments and recognize them as tagName='#comment' instead (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope)
[21:36:45] <mooeypoo>	 matanya, I connected the report now. 
[21:38:04] <grrrit-wm>	 (03PS2) 10Krinkle: ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 
[21:38:41] <grrrit-wm>	 (03PS3) 10Krinkle: ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 
[21:38:47] <grrrit-wm>	 (03PS4) 10Krinkle: ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 
[21:45:30] <mooeypoo>	 James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=62279 this should be fixed too now
[21:45:41] <mooeypoo>	 and this! https://bugzilla.wikimedia.org/show_bug.cgi?id=62279
[21:45:56] <RoanKattouw>	 mooeypoo: Those two are the same ...
[21:46:08] <mooeypoo>	 rofl.. stupid copy/paste, computer. hang on
[21:46:23] <mooeypoo>	 this: https://bugzilla.wikimedia.org/show_bug.cgi?id=62293
[21:46:24] <James_F>	 mooeypoo: Anyway, I've marked them as fixed.
[21:46:33] <James_F>	 But slow Internet is slow.
[21:46:35] <mooeypoo>	 yay
[21:46:44] <mooeypoo>	 the list is shrinkinggggg.
[21:46:57] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] [WIP] Create remaining meta items in DM (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 (owner: 10Jforrester)
[21:47:10] <mooeypoo>	 I'm trying to figure out Robert's bug. It's tough to replicate.
[21:47:46] <grrrit-wm>	 (03CR) 10Catrope: [WIP] Create remaining meta items in DM (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 (owner: 10Jforrester)
[21:50:02] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "These variables are named this way to match the (apparently incorrectly named) toDomElements function and the domElements argument to toDa" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 (owner: 10Krinkle)
[21:54:55] <mooeypoo>	 any apache masters around? I've been trying to change my mw install to be in root, and nothing works... probably due to my noobiness in linux.
[21:57:54] <RoanKattouw>	 mooeypoo: You need to update LocalSettings.php accordingly as well
[21:58:35] <mooeypoo>	 RoanKattouw, that I know
[21:58:46] <mooeypoo>	 but I'm trying to figure out how to get apache to load mw from root
[21:58:50] <mooeypoo>	 I have symlinks now
[21:59:07] <mooeypoo>	 from var/www/wiki -> ~/dev/localwiki
[21:59:11] <mooeypoo>	 but that won't work for root
[21:59:34] <mooeypoo>	 and I can't find httpd.conf file at all in my computer. Isn't that weird?
[22:01:24] <mooeypoo>	 ah! I think I found it.
[22:10:41] <grrrit-wm>	 (03PS1) 10Catrope: Followup 4bd80b62: fix JS error on page save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118021 
[22:12:08] <grrrit-wm>	 (03PS2) 10Jforrester: Followup 4bd80b62: fix JS error on page save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118021 (owner: 10Catrope)
[22:12:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Followup 4bd80b62: fix JS error on page save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118021 (owner: 10Catrope)
[22:14:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Followup 4bd80b62: fix JS error on page save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118021 (owner: 10Catrope)
[22:26:32] <grrrit-wm>	 (03CR) 10Krinkle: "I didn't rename the method nor the root node (arg "domElement"). Merely the child nodes. I don't think there is any reason not to rename t" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 (owner: 10Krinkle)
[22:26:35] <Krinkle>	 RoanKattouw: ^
[22:27:04] <Krinkle>	 Remember that element is a subclass of node.
[22:27:16] <RoanKattouw>	 I realize that now :)
[22:27:19] <RoanKattouw>	 Not when I wrote his
[22:27:29] <grrrit-wm>	 (03CR) 10Catrope: "Yeah that looks fine. Just saying you can't necessarily conquer the whole thing, but it sounds like you're not planning to." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 (owner: 10Krinkle)
[22:28:13] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 (owner: 10Krinkle)
[22:32:26] <grrrit-wm>	 (03CR) 10Krinkle: Stop special-casing comments and recognize them as tagName='#comment' instead (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope)
[22:35:04] <grrrit-wm>	 (03CR) 10Catrope: Stop special-casing comments and recognize them as tagName='#comment' instead (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope)
[23:18:53] <mooeypoo>	 ah. Time for class.