[00:02:01] (03PS3) 10Alex Monk: Fix fatal when user switches from VE to the old editor and makes a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 [00:25:24] (03PS8) 10JGonera: Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 [00:25:26] (03PS5) 10JGonera: Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 [00:25:28] (03PS1) 10JGonera: [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 [00:26:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [00:29:58] (03PS5) 10JGonera: Use DesktopSurface and MobileSurface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 [00:30:00] (03PS1) 10JGonera: [WIP] Add mobile-specific styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118225 [00:30:34] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopSurface and MobileSurface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 (owner: 10JGonera) [00:30:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add mobile-specific styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118225 (owner: 10JGonera) [00:32:22] (03PS2) 10JGonera: [WIP] Add mobile-specific styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118225 [00:32:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add mobile-specific styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118225 (owner: 10JGonera) [00:36:21] (03Abandoned) 10Mooeypoo: Fix SelectWidget's selectItem method [oojs/ui] - 10https://gerrit.wikimedia.org/r/113162 (owner: 10Mooeypoo) [03:10:11] (03PS1) 10Mooeypoo: Deal with images whose size is smalled than default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118231 [11:52:02] would the first VE dev available please shout? :) Thanks! [14:24:17] (03CR) 10Siebrand: Update MWLanguageInputWidget to new API (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/114536 (owner: 10Esanders) [15:42:13] mooeypoo: was I discussing Gmail filters with you? [15:47:18] Elitre: Hey. [15:47:27] Elitre: If you're still around? :-) [15:47:37] I think so. [15:47:57] I'm having fights with the character inserter :/ [15:49:30] James_F: I can't understand anymore where it grabs the characters from. [15:50:00] Elitre: From the message? [15:50:08] Elitre: Which wiki is this on? [15:51:26] French and Italian [15:51:59] the Italian ones features Titles With Capital Letters that are not in the mediawiki message on it.wp [15:52:48] the fr.wp one didn't even have a local mediawiki message until today, but even when they created the page, the tool seems to load unrelated characters [15:53:31] Hmm. [15:54:46] please tell me it's me :) [15:54:48] Elitre: The original default set in English is https://www.mediawiki.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert?uselang=en [15:55:40] Elitre: Italian uses the default set - see https://www.mediawiki.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert/it [15:56:06] Elitre: But the Italian wiki has over-ridden the message for Italian interface users: https://it.wikipedia.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert [15:56:21] Yes James, we have overidden that. [15:56:23] But *not* for e.g. English speakers: https://it.wikipedia.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert/en [15:56:41] The message shows in the user interface language, rather than the content language. We should probably change that. [15:57:32] French has a custom "translation": https://www.mediawiki.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert/fr [15:58:44] For some reason the French Wikipedia has customised its message, but without changes (?), so it just shows badly. [15:58:55] james: that's not what I see on the French wikipedia, my language being set up as French. [16:00:36] Oh. There's a syntax error in it. [16:00:57] That probably doesn't help. [16:01:01] As in, it will break things. [16:01:19] I assumed that, but couldn't understand which page was the source... [16:01:44] I will fix it. [16:02:39] {{done}} [16:03:13] which one did you fix? [16:05:13] https://fr.wikipedia.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert [16:05:21] I'll also fix it in the translation. [16:06:18] (It may take some time to come through, maybe a few minutes?) [16:08:42] so, since the page that was created today had that missing comma, its source must have that missing comma as well [16:08:56] Yes. [16:12:56] what about the capital letters for names of the sections of the Italian tool? I can't find them in the overriden message. [16:14:57] Elitre: I think it might just capitalise the first character of the message. [16:16:07] will try to test. [16:23:16] (03PS1) 10Jforrester: Add some more characters to the special character inserter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 [16:24:45] we should probably test some more wikis to make sure they are getting the tool right. [16:25:16] Yeah. [16:36:02] Hi James_F, when you get a chance could you give me feedback on my proposal? https://www.mediawiki.org/wiki/User:Mvolz/OPW_proposal_round_8#Synopsis and https://www.mediawiki.org/wiki/User:Mvolz/OPW_proposal_round_8#Deliverables [16:36:34] I'm not sure it has enough detail and the "deliverables" section needs major revision [16:36:49] (03CR) 10Siebrand: "Can you clarify which "special characters" do and do not qualify to be in this list? There are potentially some 30.000 that could be added" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [16:42:30] (03CR) 10Jforrester: "This is subject to an on-going discussion on wiki, and I don't think it's appropriate to repeat here. (But yes, clearly we're unlikely to " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [16:45:06] (03CR) 10Siebrand: "It might be useful to link to the discussion that's going on on a wiki, just to allow those coming across here to not start repeating it h" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [16:45:49] (03CR) 10Jforrester: "Sorry, https://www.mediawiki.org/wiki/VisualEditor/Feedback — meant to post it before and forgot." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [16:48:57] James_F: should the &uselang= trick be enough to test on each wiki without changing the language from the preferences? [16:49:18] mvolz: Will look! [16:49:25] Elitre: Yes. [16:51:08] James_F: thanks! [16:51:27] James_F: so, I'm using english on most of the wikis I check, but if they're all using the same source for that, I don't need to check it on each of them. [16:52:23] Elitre: Yeah, in English it will be the same unless they've over-ridden. [16:52:54] Elitre: In the local language it will be the same as English unless a translator has over-ridden, unless they've over-ridden. [16:55:03] James_F, got back earlier than I expected today, will be available to join the hangout [16:55:57] Krenair: Yay. :-) [16:56:57] I'll just check local language and make sure it's the kinda short,3 section set I remember. Or we might wait for them to speak up like the French did. [16:57:08] * James_F nods. [16:57:17] If they haven't customised, it's probably fine. [17:05:28] it thinks the hangout plugin is not installed... [17:12:05] (03CR) 10Siebrand: "https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Special_characters should be more future resistant." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [17:23:13] TrevorP|Away: function Foo() {} function Bar() { Super.call(this); } OO.inheritClass( Bar, Foo ); Bar.prototype.stuff = function () { Foo.prototype.stuff.call(this); }; [17:23:23] before: [17:23:24] function Foo() {} function Bar() { Foo.call(this); } OO.inheritClass( Bar, Foo ); Bar.prototype.stuff = function () { Foo.prototype.stuff.call(this); }; [17:23:26] after: [17:23:43] function Foo() {} function Bar() { Bar.super.call(this); } OO.inheritClass( Bar, Foo ); Bar.prototype.stuff = function () { Bar.super.prototype.stuff.call(this); }; [17:24:10] (03PS1) 10Cmcmahon: Remove dumb stuff from steps. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118304 [17:30:02] (03PS2) 10Jforrester: [Browser tests] Remove dumb stuff from steps. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118304 (owner: 10Cmcmahon) [17:30:26] james_F: did you also fix the translation? ^^^17:05:25 [17:30:31] (03CR) 10Cmcmahon: [C: 032] "no change to function, just aesthetics and improvements" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118304 (owner: 10Cmcmahon) [17:32:23] (03Merged) 10jenkins-bot: [Browser tests] Remove dumb stuff from steps. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118304 (owner: 10Cmcmahon) [17:37:49] Elitre: Yes. [17:41:44] because I couldn't find recent edits from you on mw.org, so that confused me. [17:42:11] They're edited on TranslateWiki.net, not MW.org. [17:42:24] So that means he fixed the translation but not with immediate effect [17:45:25] Hi, I have been contributing to mediawiki core for a couple of months now. I am entusiastic about doing a GSoc Project for mediawiki. I am interested in developing plugins or improving Visual Editor. I find it as a really interesting part of mediawiki and would be ready to take up a challenging project. It would be helpful if someone can suggest something or guide me for some project. [17:49:28] kunalg_: Hi! You might want to join #mediawiki-visualeditor [17:49:38] I know James_F is the fella to talk to about that [17:50:34] Yeah I would be interested. [17:50:48] rdwrer: Check which channel you're in ;) [17:51:36] ...oh wow. [17:51:42] * rdwrer puts self in stocks [17:52:20] RoanKattouw: I'm tired, leave me alone [17:54:35] oh my god, internet. I just got a call from "IT wall" (!?) telling me there's a horrible virus on my computer, and if I can just quickly give them access to take over my laptop, they'll fix it. [17:54:37] .... [17:55:14] So, does anyone have an idea to implement which I can take up as a project? [17:55:51] James_F: ---^^ ? [17:55:59] Have we thought about GSoC ideas for VE? [17:56:07] Cause apparently it's that time of year again [17:57:18] I talked to Niklas and he told that integration with Translate extension is too complex for GSoc. Yet I will be interested if we can split the task into smaller tasks which can be completed in this time frame. [17:58:36] Hey. [17:59:05] kunalg_: So mvolz is also interested in working on VE, and specifically on the Translate extension. [17:59:28] kunalg_: There are a number of possible things that you could work on that aren't the Translate extension in VE, however. :-) [17:59:37] kunalg_: So it doesn't have to be either/or. [18:03:26] Hey [18:05:11] Hey [18:05:58] kunalg_: So https://bugzilla.wikimedia.org/show_bug.cgi?id=46803 has a number of linked possible VE plugins to create if any of them are of interest. [18:07:39] (03PS2) 10Catrope: Deal with images whose size is smalled than default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118231 (owner: 10Mooeypoo) [18:09:08] (03CR) 10Catrope: [C: 032] Deal with images whose size is smalled than default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118231 (owner: 10Mooeypoo) [18:10:13] (03CR) 10Catrope: [C: 032] Fix fatal when user switches from VE to the old editor and makes a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 (owner: 10Alex Monk) [18:10:14] James_F: Which one would you suggest is good enough for a GSoc project? I would prefer something slightly challenging. [18:10:18] (03PS2) 10Catrope: Rename 'wasve' parameter to 'veswitched' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117660 (owner: 10Alex Monk) [18:10:51] (03Merged) 10jenkins-bot: Deal with images whose size is smalled than default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118231 (owner: 10Mooeypoo) [18:11:03] (03CR) 10Catrope: [C: 032] Rename 'wasve' parameter to 'veswitched' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117660 (owner: 10Alex Monk) [18:12:38] (03Merged) 10jenkins-bot: Fix fatal when user switches from VE to the old editor and makes a null edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117621 (owner: 10Alex Monk) [18:14:14] (03Merged) 10jenkins-bot: Rename 'wasve' parameter to 'veswitched' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117660 (owner: 10Alex Monk) [18:15:06] (03CR) 10Catrope: Make 'comment' its own metaitem type (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [18:15:25] Krinkle: Re https://gerrit.wikimedia.org/r/#/c/117924/2/modules/ve/dm/metaitems/ve.dm.CommentMetaItem.js , feel free to grep for things before complaining that they shouldn't be used ;) [18:19:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [18:26:09] (03PS1) 10Krinkle: ve.ce.getDomText: Document node types and use .data instead of .nodeValue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118323 [18:26:48] (03PS3) 10Catrope: Stop special-casing comments and recognize them as tagName='#comment' instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 [18:28:22] (03PS2) 10Krinkle: ve.ce.getDomText: Document node types and use .data instead of .nodeValue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118323 [18:29:12] (03CR) 10Catrope: ve.ce.getDomText: Document node types and use .data instead of .nodeValue (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118323 (owner: 10Krinkle) [18:29:24] (03CR) 10Catrope: [C: 032] ve.ce.getDomText: Document node types and use .data instead of .nodeValue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118323 (owner: 10Krinkle) [18:31:07] (03CR) 10Krinkle: ve.ce.getDomText: Document node types and use .data instead of .nodeValue (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118323 (owner: 10Krinkle) [18:32:07] (03Merged) 10jenkins-bot: ve.ce.getDomText: Document node types and use .data instead of .nodeValue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118323 (owner: 10Krinkle) [18:33:31] (03CR) 10Krinkle: "Reviewing.." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope) [19:07:17] (03PS1) 10Catrope: Fix JS error trying to access this.saveDialog from switch to source mode code path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118331 [19:22:59] (03CR) 10Krinkle: [C: 031] "K, took the oppertunity to familiarise myself with lots of things that changed in DM that I didn't really know well. Looks all good. A few" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope) [19:23:05] (03PS3) 10Krinkle: Make ve.dm.Converter assertions actually display message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117923 (owner: 10Catrope) [19:23:17] (03CR) 10Krinkle: [C: 031] Make ve.dm.Converter assertions actually display message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117923 (owner: 10Catrope) [19:23:46] (03CR) 10Krinkle: [C: 032] Stop special-casing comments and recognize them as tagName='#comment' instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope) [19:23:50] (03CR) 10Krinkle: [C: 032] Make ve.dm.Converter assertions actually display message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117923 (owner: 10Catrope) [19:24:09] (03PS3) 10Krinkle: Make 'comment' its own metaitem type [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [19:28:44] (03Merged) 10jenkins-bot: Stop special-casing comments and recognize them as tagName='#comment' instead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope) [19:28:46] (03Merged) 10jenkins-bot: Make ve.dm.Converter assertions actually display message [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117923 (owner: 10Catrope) [19:33:04] (03PS4) 10Krinkle: Make 'comment' its own metaitem type [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [19:33:55] (03CR) 10Krinkle: [C: 031] "Removed not-so-usefull description, added new line for consistency, using .super to call parent constructor." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [19:34:00] (03PS6) 10Krinkle: ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 [19:36:05] (03PS7) 10Krinkle: ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 [19:36:31] (03CR) 10Krinkle: Stop special-casing comments and recognize them as tagName='#comment' instead (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117911 (owner: 10Catrope) [19:40:19] (03CR) 10Krinkle: "Looks good. Only wondering if maybe we should call it something other than plain 'comment' in our model to avoid confusion or potential co" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [19:49:03] (03PS1) 10Catrope: Fix JS error when pressing Enter with selection across multiple paragrahps [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 [19:54:13] (03PS2) 10Catrope: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:54:31] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:54:57] (03PS2) 10Divec: Fix JS error when pressing Enter with selection across multiple paragraphs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 (owner: 10Catrope) [19:56:08] (03PS3) 10Catrope: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:56:18] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [20:02:58] (03CR) 10Divec: [C: 04-1] Fix JS error when pressing Enter with selection across multiple paragraphs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 (owner: 10Catrope) [20:03:22] Krinkle: Hmm. https://bugzilla.wikimedia.org/show_bug.cgi?id=62576 should already be fixed. [20:03:31] Krinkle: There's definitely a CH test in the init code somewhere. [20:03:35] Krinkle: I'll fix. [20:04:06] James_F: I know, I wrote that iiirc [20:05:01] Argh, semantic forms is lying [20:05:59] Krinkle: Well, that explains. Was just looking at the code… [20:06:15] yeah :) [20:06:24] I thought maybe wikitech was running an old version that didn't have the check yet [20:06:26] but that's not the case either [20:06:40] mw.config.get( 'wgPageContentModel' ) === 'wikitext' [20:06:45] It's from a while ago. [20:06:54] https://wikitech.wikimedia.org/w/load.php?debug=true&lang=en&modules=ext.visualEditor.viewPageTarget.init&only=scripts&skin=vector&* [20:06:55] Yep [20:11:11] (03CR) 10Krinkle: Fix JS error when pressing Enter with selection across multiple paragraphs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 (owner: 10Catrope) [20:18:02] (03CR) 10Catrope: Fix JS error when pressing Enter with selection across multiple paragraphs (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 (owner: 10Catrope) [20:18:26] (03PS3) 10Catrope: Fix JS error when pressing Enter with selection across multiple paragraphs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 [20:26:35] JamesF: I was looking through the logs and it looks like you told another candidate (but for GSoc) that I was working on the Translate extension? I think there was some miscommunication there, what I talked with Trevor about was actually doing a citation engine extension that would interact with the *translocution* dialog. I guess they both start with trans :). [20:27:22] Unfortunately kunalg_ seems to have signed off :( [20:27:55] mvolz: Sorry, yes, you're right, I meant a different candidate – I was reading yours at the time so I wrote your name in. :-( [20:28:05] Oh ok, nevermind then! [20:29:02] Did mine seem workable? I believe the timeline needs to be a bit more explicit [20:38:05] (03CR) 10Divec: [C: 032] Fix JS error when pressing Enter with selection across multiple paragraphs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 (owner: 10Catrope) [20:39:18] mvolz: Yeah; will give you some proper feedback in a bit. :-) [20:40:19] (03Merged) 10jenkins-bot: Fix JS error when pressing Enter with selection across multiple paragraphs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118340 (owner: 10Catrope) [20:40:21] James_F: Thanks! [21:01:17] (03PS1) 10Catrope: Add ve.dm.Transaction.newFromReplacement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118348 [21:01:32] (03PS7) 10Catrope: Don't cause needless surface refreshes on overwriting. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [21:01:46] divec: ---^^ [21:02:02] (03CR) 10jenkins-bot: [V: 04-1] Add ve.dm.Transaction.newFromReplacement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118348 (owner: 10Catrope) [21:02:29] (03CR) 10jenkins-bot: [V: 04-1] Don't cause needless surface refreshes on overwriting. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [21:02:49] :( [21:03:36] (03PS2) 10Catrope: Add ve.dm.Transaction.newFromReplacement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118348 [21:04:27] (03PS8) 10Catrope: Don't cause needless surface refreshes on overwriting. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [21:20:52] gwicke, do you know where Parsoid decides to return an HTTP 504 timeout? [21:22:27] Krenair: It doesn't, Varnish does [21:23:31] Hm. Okay. [21:23:36] Guess I need to get that setup then [21:23:45] Don't even try [21:23:54] 504 is an infrastructural failure [21:23:58] It's Varnish overload, I think [21:24:29] If you want to test that it gets handled correctly, just hack your api.php to return 504s [21:25:52] ok, thanks RoanKattouw [21:26:56] (03PS1) 10Krinkle: mw.ViewPageTarget: Tag our state changes and reject foreign states [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118357 [21:28:48] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Tag our state changes and reject foreign states [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118357 (owner: 10Krinkle) [21:29:49] (03CR) 10Catrope: "DM names can be anything, the only restriction is that the first character cannot be a slash. But as you noted, we also already have parag" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [21:30:10] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Tag our state changes and reject foreign states [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118357 (owner: 10Krinkle) [21:30:36] TrevorParscal: https://gerrit.wikimedia.org/r/118348 [21:32:57] (03CR) 10Trevor Parscal: [C: 032] Add ve.dm.Transaction.newFromReplacement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118348 (owner: 10Catrope) [21:33:33] (03CR) 10Catrope: [C: 032] Don't cause needless surface refreshes on overwriting. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [21:33:54] (03Merged) 10jenkins-bot: Add ve.dm.Transaction.newFromReplacement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118348 (owner: 10Catrope) [21:35:12] (03Merged) 10jenkins-bot: Don't cause needless surface refreshes on overwriting. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/105231 (owner: 10Divec) [21:37:56] (03CR) 10Catrope: [C: 032] Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118029 (owner: 10Jforrester) [21:38:56] (03PS9) 10JGonera: Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 [21:38:58] (03PS2) 10JGonera: [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 [21:39:00] (03PS6) 10JGonera: Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 [21:39:33] (03Merged) 10jenkins-bot: Enable VisualEditor by default in NS_USER as well as $wgContentNamespaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118029 (owner: 10Jforrester) [21:40:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [21:44:00] (03PS14) 10Robmoen: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 [21:46:01] (03CR) 10jenkins-bot: [V: 04-1] Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [21:47:58] (03CR) 10Catrope: [C: 032] ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 (owner: 10Krinkle) [21:48:27] (03CR) 10Catrope: "So I think this is in keeping with existing naming conventions" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [21:48:43] (03CR) 10Krinkle: "This caused bug 43013 because the ve-init-mw-viewPageTarget-toolbar-editNotices-notice class (which we told the community is an API to cha" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/90378 (owner: 10Trevor Parscal) [21:49:47] Krinkle: It didn't cause bug 43013, it re-broke 43013. [21:55:00] Krinkle: Could you merge https://gerrit.wikimedia.org/r/117924 so I can do a pull-through [21:55:04] (after that merges and a few other things) [21:55:24] RoanKattouw: OK, in a minute. [21:55:51] Sure [21:56:18] (03PS3) 10Trevor Parscal: Keep label and disabled state of transclusion dialog apply button in sync [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 [21:56:29] (03PS4) 10Trevor Parscal: Keep label and disabled state of transclusion dialog apply button in sync [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 [21:56:49] (03PS3) 10Trevor Parscal: Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 [21:57:34] (03CR) 10Krinkle: [C: 032] Make 'comment' its own metaitem type [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [21:58:34] (03Merged) 10jenkins-bot: Make 'comment' its own metaitem type [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117924 (owner: 10Catrope) [21:58:36] (03Merged) 10jenkins-bot: ve.dm.Converter: Refer to nodes instead of elements where appropiate [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118012 (owner: 10Krinkle) [22:03:53] Thanks Kr [22:03:55] Thanks Krinkle [22:11:58] (03PS1) 10Krinkle: mw.Target: Add class "mw-ve-editNotice" to edit notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118369 [22:12:24] (03PS1) 10Krinkle: ve.ui.MWPopupTool: Simplify code complexity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118370 [22:12:43] (03PS1) 10Catrope: Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 [22:13:26] (03CR) 10Catrope: [C: 032] mw.Target: Add class "mw-ve-editNotice" to edit notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118369 (owner: 10Krinkle) [22:13:48] (03PS2) 10Catrope: ve.ui.MWPopupTool: Simplify code complexity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118370 (owner: 10Krinkle) [22:14:46] (03CR) 10Catrope: [C: 032] ve.ui.MWPopupTool: Simplify code complexity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118370 (owner: 10Krinkle) [22:15:15] (03Merged) 10jenkins-bot: mw.Target: Add class "mw-ve-editNotice" to edit notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118369 (owner: 10Krinkle) [22:16:31] (03Merged) 10jenkins-bot: ve.ui.MWPopupTool: Simplify code complexity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118370 (owner: 10Krinkle) [22:19:26] RoanKattouw, what is the text returned by the api when it times out? [22:19:52] I got it to simply set the status to 504, doesn't appear to be enough [22:20:50] The API doesn't return anything in that case [22:20:54] Varnish returns something [22:21:03] Different 5xx error codes depending on specifics [22:21:31] "doesn't appear to be enough" --> enough for detection on JS side, or enough to reproduce the bug? [22:22:05] I'm trying to reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=50475 [22:22:15] (03CR) 10Catrope: [C: 032] Add text direction to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 (owner: 10Esanders) [22:22:26] I am unclear about exactly what is going on in WMF's setup involving Varnish, the API, and parsoid [22:22:48] https://wikitech.wikimedia.org/wiki/Parsoid#Data_flow [22:23:12] (03Merged) 10jenkins-bot: Add text direction to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 (owner: 10Esanders) [22:27:19] (03CR) 10Divec: [C: 04-1] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [22:28:35] RoanKattouw: ø Ø [22:30:01] (03PS1) 10Trevor Parscal: Split part of getOpeningHtmlTag out to getHtmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118376 [22:33:00] (03PS4) 10Trevor Parscal: Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 [22:33:22] TrevorParscal: https://gerrit.wikimedia.org/r/117896 [22:35:39] (03PS1) 10Krinkle: ve.ce.Surface: Document version number in focus workaround for Opera [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118379 [22:35:42] RoanKattouw, this is only more confusing - Varnish is behind the API, so the API must return something to indicate Varnish gave it an error code. [22:35:48] But the API doesn't return anything... [22:35:53] (03CR) 10Krinkle: "Added in I93d37d5a511a958c." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/71249 (owner: 10Bartosz Dziewoński) [22:35:57] There's another layer of Varnish on top of the API [22:36:00] Which is not documented on that page [22:36:33] (03CR) 10Catrope: [C: 032] ve.ce.Surface: Document version number in focus workaround for Opera [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118379 (owner: 10Krinkle) [22:36:41] Oh, that's what you mean. [22:36:46] Sorry [22:36:58] (03CR) 10Trevor Parscal: [C: 032] ve.ce.Node: Emphasise slug transition with increasing outline offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 (owner: 10Krinkle) [22:37:02] There's multiple layers of everything and I'm way too accustomed to talking to people who've also memorized all of them :S [22:37:03] I'm goign through all commits I starred on Gerrit (commits there was something pending still) [22:37:06] I'm like 10 months behind [22:37:12] Glad almost all of them are dealt with, except for a few [22:37:39] (03Merged) 10jenkins-bot: ve.ce.Surface: Document version number in focus workaround for Opera [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118379 (owner: 10Krinkle) [22:37:40] I use star as my "needs fixup" or "should never merge, but don't want to stay on reviewer list" [22:37:45] (03PS2) 10Catrope: Add some more characters to the special character inserter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [22:38:01] (03CR) 10Catrope: [C: 032] Add some more characters to the special character inserter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [22:38:10] (03Merged) 10jenkins-bot: ve.ce.Node: Emphasise slug transition with increasing outline offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117896 (owner: 10Krinkle) [22:39:00] RoanKattouw, so I hacked the API module to return 504 like this bug says [22:39:11] (03Merged) 10jenkins-bot: Add some more characters to the special character inserter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118294 (owner: 10Jforrester) [22:39:35] Opened a local wiki tab, clicked edit to go to VE. 504 error in console, great [22:39:48] The bug says 'results in a popup "Error loading data from server: error. Would you like to retry?". Trying again, repeats the issue' [22:39:55] But I just see nothing [22:40:26] Weird [22:40:30] Excluding the console error, it's as if I never clicked edit [22:42:19] (03CR) 10Catrope: [C: 032] Split part of getOpeningHtmlTag out to getHtmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118376 (owner: 10Trevor Parscal) [22:42:28] That's even worse [22:43:48] (03Merged) 10jenkins-bot: Split part of getOpeningHtmlTag out to getHtmlAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118376 (owner: 10Trevor Parscal) [22:44:57] RoanKattouw: If you have aminute, can you look at the bottom of https://gerrit.wikimedia.org/r/#/c/77389/2/modules/ve/dm/annotations/ve.dm.TextStyleAnnotation.js and explain a bit about that pattern? It seems odd to me since I rarely see that kind of fallback anywhere else. [22:45:10] If that is indeed needed in that case, is there another way to deal with it? [22:45:15] RoanKattouw, ah, right. I am stupid [22:45:29] Krenair: Could well have been modified since then. [22:45:33] I assumed that reloading the page would cancel Chrome's "prevent this page from launching more popups" or something along those lines [22:45:42] e.g. in the phase where we create the data elements from HTML/Parsoid DOM, do set it right the first time [22:46:01] The popup does appear, chrome was just preventing it because I had told it to earlier [22:46:20] Krenair: Ha. :-) [22:46:39] RoanKattouw: http://codepad.org/NGPjR4fl :-) [23:07:34] (03CR) 10Siebrand: [C: 04-1] "Nice. Parameter documentation is missing." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [23:08:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal) [23:11:12] (03PS1) 10Catrope: Update VE core submodule to master (8c017ae) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118389 [23:12:45] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8c017ae) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118389 (owner: 10Catrope) [23:16:18] (03PS2) 10Catrope: Update VE core submodule to master (8c017ae) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118389 [23:18:19] (03CR) 10Catrope: [C: 032] Keep label and disabled state of transclusion dialog apply button in sync [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal) [23:20:47] (03PS5) 10Catrope: Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [23:20:57] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (8c017ae) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118389 (owner: 10Catrope) [23:21:28] (03Merged) 10jenkins-bot: Keep label and disabled state of transclusion dialog apply button in sync [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 (owner: 10Trevor Parscal) [23:21:30] (03PS6) 10Jforrester: Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [23:23:23] (03Merged) 10jenkins-bot: Update VE core submodule to master (8c017ae) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118389 (owner: 10Catrope) [23:23:58] (03CR) 10Catrope: [C: 032] Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [23:25:22] rmoen: Hey, what's the status of the TOC work? [23:25:24] (03Merged) 10jenkins-bot: Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343 (owner: 10Trevor Parscal) [23:25:32] I saw a new patchset appear, how functional is it? [23:38:29] (03PS1) 10Jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118394 [23:40:57] (03PS1) 10Jforrester: Re-sort the i18n files alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118397 [23:41:22] (03PS1) 10Alex Monk: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 [23:42:55] RoanKattouw: hey so the TOC work is all checked off. I'm still messing with some very minor RTL stuff like the toctitle isn't on the correct side. but everything else is good in RTL.. I've checked off all the items in the etherpad [23:43:33] RoanKattouw: toctitle being the word "Contents" at the top [23:44:30] RoanKattouw: The feature flag is setup. So it would be nice to have this chunk merged [23:44:37] Sweetness [23:44:43] I'll play with it in a minute, talking to David now [23:45:06] RoanKattouw: Ok cool, I'm going to step out for a bit and I'll be back in a while to check for any messages if you happen to leave any :) [23:45:22] (03CR) 10Alex Monk: [C: 04-1] More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 (owner: 10Alex Monk) [23:56:18] (03PS2) 10Jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118394