[00:01:24] (03PS3) 10Jforrester: Make references list dialog small, and vary 'insert' vs. 'apply' button text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118394 [00:05:10] (03CR) 10Jforrester: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 (owner: 10Alex Monk) [00:11:37] (03CR) 10Alex Monk: "Have been testing this by adding this code to the top of ApiVisualEditor::execute, by the way:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 (owner: 10Alex Monk) [00:16:13] (03CR) 10Catrope: [C: 04-1] Table of contents widget (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [00:18:36] (03PS2) 10Trevor Parscal: Re-sort the i18n files alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118397 (owner: 10Jforrester) [00:19:03] (03CR) 10Trevor Parscal: [C: 032] Re-sort the i18n files alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118397 (owner: 10Jforrester) [00:20:35] (03PS15) 10Catrope: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [00:21:47] (03CR) 10Trevor Parscal: [C: 032] Make references list dialog small, and vary 'insert' vs. 'apply' button text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118394 (owner: 10Jforrester) [00:22:03] (03CR) 10jenkins-bot: [V: 04-1] Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [00:22:28] (03CR) 10Catrope: "PS15 adds the feature flag to VisualEditor.php" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [00:23:06] (03CR) 10Catrope: [C: 04-1] "Bug report: the show/hide link works initially, but after the TOC has been rebuilt once (add, remove or split a heading to make this happe" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [00:23:52] (03Merged) 10jenkins-bot: Make references list dialog small, and vary 'insert' vs. 'apply' button text [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118394 (owner: 10Jforrester) [00:23:54] (03Merged) 10jenkins-bot: Re-sort the i18n files alphabetically [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118397 (owner: 10Jforrester) [00:30:31] (03PS1) 10Trevor Parscal: Make dialogs a little taller [oojs/ui] - 10https://gerrit.wikimedia.org/r/118405 [00:31:37] (03PS1) 10Catrope: Actually make the save dialog grow when showing a diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118406 [00:32:31] (03CR) 10Catrope: [C: 032] Make dialogs a little taller [oojs/ui] - 10https://gerrit.wikimedia.org/r/118405 (owner: 10Trevor Parscal) [00:32:42] TrevorParscal: https://gerrit.wikimedia.org/r/118406 [00:32:53] (03Merged) 10jenkins-bot: Make dialogs a little taller [oojs/ui] - 10https://gerrit.wikimedia.org/r/118405 (owner: 10Trevor Parscal) [00:35:05] (03CR) 10Trevor Parscal: [C: 032] Actually make the save dialog grow when showing a diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118406 (owner: 10Catrope) [00:36:27] (03Merged) 10jenkins-bot: Actually make the save dialog grow when showing a diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118406 (owner: 10Catrope) [00:38:26] (03PS1) 10Jforrester: Make the reference dialog medium, not large [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118408 [00:39:10] (03CR) 10Catrope: "Depends on https://gerrit.wikimedia.org/r/118405 being pulled into MW core" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118408 (owner: 10Jforrester) [00:40:31] (03CR) 10Catrope: [C: 031] Make the reference dialog medium, not large [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118408 (owner: 10Jforrester) [00:40:33] jgonera: https://gist.github.com/trevorparscal/9519741 [00:40:42] thanks TrevorParscal [00:42:10] (03CR) 10Trevor Parscal: [C: 032] Make the reference dialog medium, not large [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118408 (owner: 10Jforrester) [00:42:13] (03PS1) 10Kaldari: Adding a comment explaining where the i18n messages are [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118409 [00:42:36] (03CR) 10Jforrester: [C: 032] Adding a comment explaining where the i18n messages are [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118409 (owner: 10Kaldari) [00:43:46] (03Merged) 10jenkins-bot: Make the reference dialog medium, not large [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118408 (owner: 10Jforrester) [00:43:48] (03CR) 10Catrope: "Address the inline comments on PS14, fix the show/hide bug, and fix the things Jenkins is complaining about, and I'll be happy to merge th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [00:43:59] (03Merged) 10jenkins-bot: Adding a comment explaining where the i18n messages are [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118409 (owner: 10Kaldari) [00:44:54] (03PS2) 10Alex Monk: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 [00:45:36] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (46ccd5b3a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118413 [00:46:11] RoanKattouw: https://gerrit.wikimedia.org/r/118411 and https://gerrit.wikimedia.org/r/118413 please. [00:51:46] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (46ccd5b3a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118413 (owner: 10Jforrester) [00:52:43] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (46ccd5b3a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118413 (owner: 10Jforrester) [00:53:05] (03CR) 10Trevor Parscal: [C: 032] More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 (owner: 10Alex Monk) [00:54:31] (03Merged) 10jenkins-bot: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 (owner: 10Alex Monk) [00:54:38] (03CR) 10Trevor Parscal: [C: 032] Fix JS error trying to access this.saveDialog from switch to source mode code path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118331 (owner: 10Catrope) [00:55:52] (03PS10) 10JGonera: Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 [00:55:54] (03PS3) 10JGonera: [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 [00:55:56] (03PS7) 10JGonera: Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 [00:56:10] (03Merged) 10jenkins-bot: Fix JS error trying to access this.saveDialog from switch to source mode code path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118331 (owner: 10Catrope) [00:56:29] (03CR) 10Trevor Parscal: [C: 032] Add createSurface() to Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118042 (owner: 10JGonera) [00:56:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [00:57:59] (03Merged) 10jenkins-bot: Add createSurface() to Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118042 (owner: 10JGonera) [01:31:04] (03PS2) 10Jforrester: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [01:31:08] (03CR) 10Jforrester: Follow redirects in the category widgets (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [01:31:20] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/118218/ <-- :-) [01:41:00] (03PS4) 10Catrope: [WIP] Red link support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 [01:41:19] Krinkle: That commit ---^^ is almost done, could you give me some preliminary CR on it in the next two days? [01:42:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Red link support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope) [01:42:44] RoanKattouw: If you have aminute, can you look at the bottom of https://gerrit.wikimedia.org/r/#/c/77389/2/modules/ve/dm/annotations/ve.dm.TextStyleAnnotation.js and explain a bit about that pattern? It seems odd to me since I rarely see that kind of fallback anywhere else. If that is indeed needed in that case, is there another way to deal with it? [01:42:50] e.g. in the phase where we create the data elements from HTML/Parsoid DOM, do set it right the first time [01:42:53] RoanKattouw: OK [01:42:57] Krinkle: Sorry, yes, forgot about that [01:42:59] Will do [01:44:12] Krinkle: So, there are two ways an annotation (or node or meta item) can be created. If it's present in the initial Parsoid document, the converter will create it by invoking toDataElement. But the user can also take an action that causes a UI component to create it later [01:44:25] So this is preexisting vs user-created [01:44:33] OK [01:44:45] For preexisting things, we add all sorts of information about what the HTML that we based the node on looked like [01:44:58] For user-created things, there is no HTML that it was based on, and so a lot of that information just isn't there [01:45:11] and because it goes through toDataElement, that one is always fully formed and valid, we take care of fallbacks if needed there. [01:45:16] So you can't have toDomElements just assume that data elements will look exactly the way toDomElement made them [01:45:19] (03PS15) 10Jforrester: [WIP] Create remaining meta items in DM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 [01:45:24] Because the UI can generate "incomplete" data elements [01:45:32] RoanKattouw: Where does the data go into the data models that UI components create? [01:45:47] I mean, obviously they have to have enough attributes to make sense, but they won't have attributes relevant to HTML-specific state [01:45:50] I mean, we don't question every property in toDomElements [01:46:03] only some, so I presume that's arbitrary based on what our UI layers don't always set? [01:46:03] No, we generally do question every property [01:46:41] But some properties are only for round-tripping in toDomElements, and some only for rendering in the CE node [01:46:46] Some do both [01:46:52] OK [01:47:22] Right now it's messy, because the individual attributes and their semantics arent' documented, where they're used isn't documented, which attrbiutes are required for editor-created nodes isn't documented, etc etc [01:47:31] it feels wrong to have UI layers just fragily create data model stuff that may or may not be complete. Feels like maybe we should have a method for that that can demand parameters and fills in the rest as needed. [01:47:37] Yes, exactly [01:47:52] There should be more abstraction so the UI layer can create data elements more nicely [01:48:10] e.g. setDataElement or something like that. And the UI layer would call that once, once it has everything (or all its changes anyways, setDataElement could use the existing data as default) [01:48:16] k, great. [01:48:45] RoanKattouw: Something else if you have a minute. [01:49:17] CentralAuth is doing something shhitty, and I'd like to change it. But I need a little confidence or counter advise from you to make sure what I'm doing isn't insane or bad performant [01:49:33] https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/master/specials/SpecialCentralAutoLogin.php#L445-L487 [01:49:45] Inline script, a huge one. I wanna move it to a file and have it minified. [01:49:58] It can't be API or load.php for now, special page that has its own cache control. [01:50:25] file_get_contents and JavaScriptMinifier? and cache by some key (contents md5?) in memcached, like we do in ResourceLoader? [01:53:55] Ugh [01:54:18] Probably [01:54:25] There isn't a really nice way to do this right now [01:55:32] Krinkle: Either way, do you understand why the nodeName attribute needs a fallback there now? [01:55:54] (This is especially relevant because James just wrote similar code for the __NOCC__ node) [01:56:13] yes, because there is a UI tool or dialog creating that kind of dm node and that one doesn't specify a nodeName [01:56:22] Exactly [01:56:40] And it shouldn't, because nodeName is specific to the node having been converted from an HTML source [01:56:53] (03PS16) 10Jforrester: Create remaining meta items in DM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 [01:57:49] (03PS17) 10Jforrester: Create remaining meta items in DM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 [01:57:57] (03CR) 10Jforrester: Create remaining meta items in DM (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 (owner: 10Jforrester) [02:06:59] (03PS12) 10Jforrester: [WIP] Add demo for dialogs and layouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/109006 (owner: 10Krinkle) [02:07:14] Krinkle: How far away is ^^^ ? [02:08:10] (03CR) 10Catrope: Follow redirects in the category widgets (0310 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [02:08:18] (03CR) 10Catrope: [C: 04-1] Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [02:11:08] (03CR) 10Catrope: [C: 032] Create remaining meta items in DM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 (owner: 10Jforrester) [02:12:53] (03Merged) 10jenkins-bot: Create remaining meta items in DM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 (owner: 10Jforrester) [02:19:31] (03CR) 10Alex Monk: Follow redirects in the category widgets (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [02:21:07] RoanKattouw, yeah, I think I got the function naming/docs wrong [02:21:23] item is a string at that point [02:22:27] (There seems to be about 3 or 4 different ways of representing categories internally in those files, which might be why I was confused when writing the doc.) [02:23:14] Also see http://tools.wmflabs.org/wm-bot/logs/index.php?start=03%2F11%2F2014&end=03%2F11%2F2014&data=true&display=%23mediawiki-visualeditor - 2014-03-11 22:15:54 [02:24:25] which has logs of discussion about that nasty hack with Trevor [02:26:50] Need to fix in that file: page title/HTML, exactMatch, function doc and name, $.grep usage (I had thought this was working ok... huh), categoryRedirects overwriting [04:07:32] (03PS1) 10Mooeypoo: Fix regression bug 'default size' change on alignment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118427 [06:18:41] gwicke, awake? [11:05:01] Hello [11:05:26] How can I start contributing to the visualEditor ? [11:06:00] I'm trying to apply to the opw program [11:07:07] Hello [11:07:51] gargi: The team is in SF so they aren't usually active until 9am their time [11:08:23] I see! That make sense. I am from India. Thank you :) [11:40:18] gargi, have you checked out https://www.mediawiki.org/wiki/Annoying_little_bugs#Visual_Editor_and_Parsoid ? [11:40:43] (but read the entire page for hints and recommendations how to get started contributing to MediaWiki) [15:33:02] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118468 (owner: 10Cmcmahon) [15:34:26] (03Merged) 10jenkins-bot: [browser test] "Apply changes" is now "Insert template" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118468 (owner: 10Cmcmahon) [15:36:08] (03CR) 10Jforrester: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 (owner: 10Alex Monk) [15:56:11] (03CR) 10Jforrester: [C: 04-1] [WIP] Red link support (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope) [17:07:00] (03PS1) 10Cmcmahon: [browser test] Navigate different path through template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118568 [17:08:02] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118568 (owner: 10Cmcmahon) [17:10:06] (03Merged) 10jenkins-bot: [browser test] Navigate different path through template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118568 (owner: 10Cmcmahon) [17:14:00] (03CR) 10Krinkle: "Fixes bug 56978" [oojs/core] - 10https://gerrit.wikimedia.org/r/112148 (owner: 10Krinkle) [17:27:51] (03CR) 10Siebrand: More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118398 (owner: 10Alex Monk) [17:49:32] (03PS1) 10Krinkle: EventEmitter: Improve test coverage for disconnect() [oojs/core] - 10https://gerrit.wikimedia.org/r/118574 [17:58:37] (03CR) 10Krinkle: Show % scale on ResizableNodes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/109519 (owner: 10Esanders) [17:58:42] (03Merged) 10jenkins-bot: readme: Use
instead of
to satisfy gitblit's Markdown parser [oojs/ui] - 10https://gerrit.wikimedia.org/r/118575 (owner: 10Krinkle) [18:26:47] Hi people [18:27:26] Really loved the VisualEditor and if I understood correctly it's javascript based (so not dependent on PHP?) [18:27:54] yaniv: The editor itself is not dependent; but the MediaWiki integration is done in PHP [18:27:56] yaniv: Hey. Yes, it's a stand-alone JS app, though the version for MediaWiki has a lot of code specific to that. [18:27:58] As always [18:28:09] Yes, it makes sense [18:28:14] rdwrer: Only about 100 lines of PHP; most of the MW-specific code is in JS. [18:28:23] * rdwrer blows smoke off pistol, spins it back into holster [18:30:01] basically I have a website in Ruby on Rails that would really benefit from integrating the wikimedia visualeditor, I wondered if any of you knows if it is possible to integrate with a ROR application [18:30:06] Shouldn't be a problem if it's JS based [18:31:25] Hmm. Actually, it's 2799 lines of PHP (including comments, blank lines, etc.), and 353000 of JS. [18:31:32] Whoa [18:31:50] "for f in `find $PWD -name '*.js'`; do cat "$f" | wc -l" isn't exactly rocket science. :-) [18:31:58] yaniv: Yes, that should be totally do-able. [18:32:31] Do you know of anyone who already went through the process? [18:33:02] yaniv: No, you would be the first. [18:33:17] Ok, there's always the first for everything I guess [18:33:34] yaniv: The code you care about is https://git.wikimedia.org/summary/VisualEditor%2FVisualEditor.git [18:33:37] Hm. What's the best way to append text to an element? (Text to escape/sanitise, etc.) .append seems to take HTML... [18:33:54] yaniv: In that repo, see demos/ve/ for some stand-alone demos. [18:34:07] Thanks James, I'll start there [18:34:17] yaniv: If you have any questions, we'd love to help. [18:34:43] Obviously I could make another span or something, call .text on it and append that element instead. I'd prefer to avoid it though [18:35:31] Thanks James, I have some things to finish before trying to integrate that, but I'll probably need your help pretty soon :) [18:35:38] yaniv: Awesome. :-) [18:36:05] Thanks, tty soon ;) [18:39:36] Krinkle: Any idea why http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=jsonfm&prop=pageprops&titles=Template:Infobox%20person/doc has TD but http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=jsonfm&prop=pageprops&titles=Template:Infobox%20person doesn't? [18:42:59] Krenair: so, you would normally use .text() [18:43:04] but that would wipe out existing content [18:43:15] you want something like appendText (which doesn't exist) [18:43:38] so you could append a span (which is probably a good idea for later styling flexibility) which you use .text() on [18:45:25] or, you could use an intermediate span, like this: $thing.append( $( '' ).text( stuffThatNeedsEscaping ).html() ); [18:46:34] I would suggest just inserting a span: $thing.append( $( '' ).text( stuffThatNeedsEscaping ).addClass( 've-ui-className' ) ) unless you have good reason not to [18:46:45] that way you can target it with CSS easily [18:46:55] Krenair: that answer your question? [19:12:43] TrevorParscal, that's exactly what I was asking [19:13:06] Thank you [19:17:08] Krinkle: so, I'm having some issues, hoping you can give me some help [19:17:15] you around? [19:17:16] brb in 20 min [19:17:19] I need like 10 min [19:17:25] ok, that's fine, I will go get lunch [19:17:27] lets talk in 20 [20:40:50] TrevorParscal: here [20:41:33] so, I figured out a way to get what I needed, basically had to use mw.message( key ).plain() to prevent the JS message parser from going crazy trying to parse JSON as Wikitext [20:42:15] but basically, I'm using MediaWiki:Visualeditor-cite-tool-definition to store the JSON blob [21:02:05] (03PS1) 10Krinkle: Remove incorrect documentation for the .static containers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118599 [21:02:15] (03PS1) 10Krinkle: ve.ui.Trigger: Clean up indentation and documentation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118600 [21:02:29] TrevorParscal: Right [21:02:47] TrevorParscal: How are you delivering the message? [21:03:35] TrevorParscal: btw, use a .json extension [21:03:39] (I think) [21:04:00] Not sure if it does what I think it does, but it'll allow content handler on some wikis to display it nicer. Won't help you here though [21:04:10] TrevorParscal: Can we really express everything we want in pure json? [21:04:36] I don't think that's enough. It might be enough to declare what it needs to do, but it isn't enough information. We'll need to fetch other messages based on it [21:04:36] yes, we can [21:04:55] the names are associated to messages [21:05:00] I'd recommend we do it as part of the ve data module (or a new module) that uses that message as source, still, but processes it into something we can use. [21:05:01] you don't have to do much [21:05:21] How will you get those messages? [21:05:29] Or if they're extra messages (as opposed to the default ones) [21:05:39] Roan pointed this out as well I think. [21:05:44] I did. :-) [21:06:02] well, I'm going with a simpler solution right now to get it going, we can get fancier with this part of it later if needed [21:07:07] +1. [21:07:23] If the json interface you're making has a key for 'message-key' or something like that, and it only works if you specify one of 10 messages we hackishly already preload, that's not a feature but a bug. [21:07:28] We need those messages. [21:07:30] (03CR) 10Catrope: [C: 032] Fix regression bug 'default size' change on alignment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118427 (owner: 10Mooeypoo) [21:07:36] (03PS1) 10Catrope: Fix regression bug 'default size' change on alignment [extensions/VisualEditor] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118601 [21:08:02] And presumably other things as well, though I wouldn't know the specifics of that, so that can wait. [21:09:19] (03Merged) 10jenkins-bot: Fix regression bug 'default size' change on alignment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118427 (owner: 10Mooeypoo) [21:11:02] Krinkle: the way it works right now is the tool names are appended to "visualeditor-cite-tool-name-' to come up with a message key to use as a title [21:11:17] don't have to go this way, just see the WIP when it lands in gerrit [21:11:23] OK [21:11:28] and we can talk about it then [21:12:19] should prolly take arbitrary strings and other message keys as well (so that 1) we don't force them to create non-standard messages in our visualeditor-prefixed space, and 2) dont' force them to create message pages just to add a label or tooltip if they're not a multi-lingual wikis, as 99% of wikis are) [21:14:16] Krinkle: Could you do a Lightning deploy for wmf18 (i.e., MW.org etc.) in just under two hours' time? [21:14:29] Yes [21:15:08] Excellent. [21:32:10] (03PS1) 10Krinkle: license: Add COPYING file for GNU GPL v2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/118607 [21:32:30] (03CR) 10Krinkle: "We'll join mediawiki/services/parsoid in not having license headers of any kind in any file :)" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/118607 (owner: 10Krinkle) [21:43:58] TrevorParscal, btw, Roan asked whether you are okay with that autoEllipsis hack we discussed being used [21:47:03] (see http://tools.wmflabs.org/wm-bot/logs/index.php?start=03%2F11%2F2014&end=03%2F11%2F2014&data=true&display=%23mediawiki-visualeditor 2014-03-11 22:14:54) [21:51:19] Krenair: well, I'm not really inspired by it - it's a dirty hack really [21:52:12] is there a cleaner way we could handle this? Like, say using a config on the menu widget to disable fitting labels? Or a config option on the option widgets to bypass fitLabel? [21:54:57] (03CR) 10Jforrester: [C: 04-1] "You should also specify the display name of the licence for Special:Version in the $wgExtensionCredits hook ('license-name'), lest the fil" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/118607 (owner: 10Krinkle) [22:03:18] (03PS4) 10JGonera: [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 [22:04:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [22:19:20] (03PS2) 10Krinkle: license: Add COPYING file for GNU GPL v2 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/118607 [22:19:34] (03CR) 10Krinkle: "All of 2 extensions deployed on Wikimedia have that set, and it's not documented in DefaultSettings.php, not in the Example extension. Exa" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/118607 (owner: 10Krinkle) [22:25:45] TrevorParscal, could modify OOjs to do that I guess [22:26:09] Are we able to rely on the latest version of OOjs being present for VE? [22:28:31] Krenair: Of OOjs UI and OOjs, yes. [22:28:38] Krenair: Well, to a first approximation. [22:33:05] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=62581 doesn't happen to me in master :\ [22:33:23] mooeypoo: It does on http://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit for me… [22:33:52] Krinkle: You around? [22:35:03] James_F: yep [22:35:17] Krinkle: Any idea why http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=jsonfm&prop=pageprops&titles=Template:Infobox%20person/doc has TD but http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&format=jsonfm&prop=pageprops&titles=Template:Infobox%20person doesn't? [22:36:17] Krinkle: I've purged and null-edited the pages a few times without effect. [22:36:47] Krinkle: Oh, never mind. Now I do it /again/ it worked. [22:36:49] * James_F sighs. :-) [22:37:20] err [22:38:07] Krinkle, I can't seem to get 'master' now after yesterday's renaming? I tried 'git checkout remote/master' and 'git pull' but I get HEAD detached [22:38:35] mooeypoo: 'remote' doesn't work, you have to tell it the name of the remote [22:38:39] checkout origin/master [22:38:45] however that will give you a detached head [22:38:54] it'll created a detach pointer to what is origin/master [22:38:54] sorry, I did that.. not sure why I typed 'remote' in the chat... [22:39:06] mooeypoo: Just do 'git checkout master' [22:39:17] I did 'git checkout origin/master' [22:39:23] ok, 'git checkout master' give me [22:39:24] error: pathspec 'master' did not match any file(s) known to git. [22:39:30] it'll autocreate a branch named 'master' and point it to the first non-local branch named 'master' it can find (in this case origin/) [22:39:40] mooeypoo: do 'git remote -v' [22:39:44] do you have more than 1 remote? [22:40:00] e.g. 'origin' and something else [22:40:06] I seem to have 2 fetch/pull pairs [22:40:17] origin and gerrit [22:40:19] either way, the long way is 'git branch master -t origin/master' to create it and then 'git checkout master' to check it out [22:40:31] mooeypoo: Does one of them have ssh:// and the other not? [22:40:36] Or are they the same url? [22:40:40] They're all the same [22:40:47] in that case, git remote rm gerrit [22:41:51] ah! now it works, but for some reason i have a modified file I didn't modify.. [22:41:55] modified: .docs/eg-iframe.html [22:42:14] just reset --hard it or is this an indication of another problem? [22:44:12] (03PS1) 10Trevor Parscal: Use mw.message's plain method for JSON in SpecialCharacterInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118621 [22:44:51] (03PS1) 10Trevor Parscal: Cleanup docs and method of tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118622 [22:44:51] (03PS1) 10Trevor Parscal: Refactor getToolsForNode and getToolsForAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118623 [22:44:56] (03PS2) 10Trevor Parscal: Refactor getToolsForNode and getToolsForAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118623 [22:45:28] (03PS2) 10Trevor Parscal: Cleanup docs and method of tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118622 [22:45:54] (03PS2) 10Trevor Parscal: Use mw.message's plain method for JSON in SpecialCharacterInspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118621 [22:46:06] (03PS3) 10Trevor Parscal: Refactor getToolsForNode and getToolsForAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118623 [22:46:19] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=62591 [22:47:57] mooeypoo: .docs/eg-iframe.html is normally altered by a grunt run; ideally you should make sure that grunt changes to it are in your commit when you put up your first one. [22:49:01] mooeypoo: In this case, it was Roan (tsk). [22:49:37] (03PS1) 10Jforrester: Add new ve.dm.CommentMetaItem.js to .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118626 [22:49:42] mooeypoo: ^^^ That's me fixing it. [22:55:16] ahh hehe o [22:55:17] ok [22:56:10] mooeypoo: Feel free to merge. :-) [22:56:53] James_F, I tested the 'undefined' bug twice now, in both chrome and firefox and I can't reproduce it. I added an image to the page, saved, clicked' edit' again (so, no refresh) and i can open the edit dialog just fine [22:58:53] (03CR) 10Mooeypoo: [C: 032] "A grunty approval" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118626 (owner: 10Jforrester) [22:59:33] (03PS11) 10JGonera: Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 [22:59:35] (03PS5) 10JGonera: Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 [22:59:37] (03PS8) 10JGonera: Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 [23:00:15] mooeypoo: Re-testing now. :-) [23:00:58] (03CR) 10jenkins-bot: [V: 04-1] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [23:01:00] (03Merged) 10jenkins-bot: Add new ve.dm.CommentMetaItem.js to .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118626 (owner: 10Jforrester) [23:01:42] Okay, so I downloaded the oojs/ui repository and started trying to run npm install [23:01:59] Krenair: It didn't work? [23:02:02] unfortunately it fails because it's trying to find 'node' rather than 'nodejs' while installing some dependency [23:03:59] Krenair: Hmm. You don't have node in your path? [23:04:18] I don't have a 'node' command [23:04:25] (03PS2) 10Catrope: Fix regression bug 'default size' change on alignment [extensions/VisualEditor] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118601 [23:04:33] (03CR) 10Krinkle: [C: 032] Fix regression bug 'default size' change on alignment [extensions/VisualEditor] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118601 (owner: 10Catrope) [23:04:35] (03CR) 10jenkins-bot: [V: 04-1] Fix regression bug 'default size' change on alignment [extensions/VisualEditor] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118601 (owner: 10Catrope) [23:05:19] Krenair: But you have a 'nodejs' command? [23:05:28] James_F, yep [23:05:34] Krenair: Interesting. What system? [23:05:44] Ubuntu 13.10 [23:05:54] Hmm. Odd. [23:06:04] (03PS3) 10Catrope: Fix regression bug 'default size' change on alignment [extensions/VisualEditor] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118601 [23:06:04] Did you install node as a package or manually? [23:06:36] It points to the file for debian mentioning why they decided to rename 'node' to 'nodejs' [23:07:16] Hm... looks like I did it manually... [23:07:17] Oh, helpful. So Debian's packagers yet again tried to break systems? Surprise. :-( [23:11:03] (03CR) 10Krinkle: [C: 032] Fix regression bug 'default size' change on alignment [extensions/VisualEditor] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118601 (owner: 10Catrope) [23:11:30] (03CR) 10Jforrester: license: Add COPYING file for GNU GPL v2 (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/118607 (owner: 10Krinkle) [23:12:06] (03Merged) 10jenkins-bot: Fix regression bug 'default size' change on alignment [extensions/VisualEditor] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118601 (owner: 10Catrope) [23:12:16] TrevorParscal: Please merge https://gerrit.wikimedia.org/r/#/c/118411/ [23:21:38] https://groups.google.com/forum/#!topic/Nodejs/Z8F8uDXY8XE [23:21:39] https://wiki.debian.org/Javascript/Policy [23:21:44] Yay, nodejs [23:21:55] Fun read over lunch [23:22:12] TrevorParscal, does http://pastebin.com/P9e7ccaD seem better than the hack? [23:25:04] absolutely - if I had to nitpick, I would say that it should be called autoFitLabel, obscuring the implementation detail of ellipsis, and also document as @cfg {bool} [autoFitLabel=true] ... [23:25:20] we may later fit the label using a combination of methods [23:25:21] :) [23:25:41] including reducing the letter spacing (MacOS does this, it's quite cool) [23:25:44] I was going to try to patch the oojs/ui repo, which appears to be completely different to the single file in mediawiki core [23:27:49] I guess I'll do it anyway and mark it as not fully tested :/ [23:30:50] well, the single file is just generated [23:31:16] that code belongs in ooui-js/src/elements/LabeledElement.js [23:32:56] yeah [23:33:06] (03PS1) 10Alex Monk: Make it possible to configure LabeledElement to not use autoEllipsis [oojs/ui] - 10https://gerrit.wikimedia.org/r/118635 [23:48:03] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (5345806a96) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118639 (owner: 10Jforrester) [23:58:50] Krinkle: ^^^ :-(