[00:00:24] ew [00:00:36] TrevorParscal, I guess it requires 'boolean' instead of 'bool'? [00:00:49] Krenair: He just left for the day. (Typical. :-)) [00:01:12] 23:47:39 Warning: /srv/ssd/jenkins-slave/workspace/VisualEditor-jsduck/lib/oojs-ui/oojs-ui.js:2451: Unknown type bool [00:01:13] :/ [00:04:59] no, i has not [00:05:22] James_F: At least, now we catch it in ve instead of in mw-ve [00:05:35] we didn't always have the jsduck test there [00:05:36] Krinkle: Yeah, but why was it not caught in oojs-ui? [00:05:48] because that one doesn't have a jsduck pipeline yet [00:06:02] (03PS1) 10Alex Monk: Use boolean instead of bool in LabeledElement docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/118645 [00:06:24] (03CR) 10Krinkle: [C: 032] Use boolean instead of bool in LabeledElement docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/118645 (owner: 10Alex Monk) [00:06:50] (03Merged) 10jenkins-bot: Use boolean instead of bool in LabeledElement docs [oojs/ui] - 10https://gerrit.wikimedia.org/r/118645 (owner: 10Alex Monk) [00:07:24] Krinkle: Yeah. :-( [00:07:53] Which is a little more elaborate than adding a jenkins job because it needs config, and jsduck plugins. And there's the open issue of jsduck 5.x [00:08:06] too.. much... stuff... [00:08:21] Yeah. [00:08:24] * James_F hugs Krinkle. [00:08:32] Can I have another me for my birthday ^_^ [00:08:35] Krinkle: I'll pay you in pizza next week. :-) [00:08:48] Krinkle: Sure. You have to find them and train them up, however. ;-) [00:08:51] That sounded very ego, didn't mean it like that :P [00:09:12] Although I hear rumours Tesla worked on a machine like that in his day [00:09:15] (The Prestige) [00:09:39] * James_F grins. [00:09:48] Krinkle: We're used to your ego, don't fret. [00:10:59] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (ac0cc69508) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118639 [00:11:55] Krinkle: OK, now /you/ can +2 https://gerrit.wikimedia.org/r/118639 and https://gerrit.wikimedia.org/r/118640 for Krenair. :-) [00:12:17] Krenair: Or you can, if you want. :-) [00:12:43] Krenair: (Welcome to VE's fun world of repo management; we "only" have 7 repos between us.) [00:14:02] James_F, I notice that your commit message mentions a change that only affects oojs ui's readme.md, which doesn't exist in mw core or ve [00:14:15] this is an automated script right? [00:14:24] Krenair: Yeah, the script doesn't care what files get touched. [00:14:34] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (ac0cc69508) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118639 (owner: 10Jforrester) [00:14:45] Uh... Hm [00:14:58] I can't +2 in VE/VE [00:15:10] I guess he intended for you to merge teh second one [00:15:14] I didn't see that, did both. [00:15:15] Krenair: Specifically, in MW-core it's resources/oojs-ui/update-oojs-ui.sh (and resources/oojs/update-oojs.sh); for VE-core it's bin/update-oojs-ui.sh &c.; for MW-VE it's bin/updateSubmodule.sh [00:15:30] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (ac0cc69508) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118639 (owner: 10Jforrester) [00:15:43] Krinkle: Never mind. [00:15:50] Krenair: Hmm, yeah, need to add you to the ACL. [00:16:17] (or rather, when he said that, I thought James_F meant "do it for (as a favour to) Krenair" [00:17:02] Krinkle: I did, you were right. I just changed my mind after saying it to give Alex a feel for what it's like. :-) [00:17:09] k [00:17:23] this.langs.en.confidence++ [00:17:57] * James_F hugs the ever-brilliant Krinkle. [00:20:03] Krinkle: Surely this.langs['en'].confidence++ ? :-) [00:20:18] Or even ++this.langs['en'].confidence [00:20:22] * James_F whistles. [00:20:48] (03PS3) 10Alex Monk: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 [00:22:01] James_F: eh..? even if ISO would approve a javascript keyword as language code, those are allowed in dot position for a while now. [00:22:18] except for hyphens of course [00:22:36] (03PS4) 10Alex Monk: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 [00:23:05] Krinkle: "en" is a child object of "langs" in your model? I assumed "this" was Krinkle and langs was the "language facility" of Krinkle. [00:24:04] (03CR) 10Alex Monk: [C: 04-1] "still one thing left to do from PS1" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [00:24:05] Yes. Unless you meant to emphasise something other than ` ['key'] ` vs. ` .key `, you failed to change the statement, because they are exactly the same [00:24:27] Gah, I hate JS. :-) [00:25:23] .key is property accessor like ['key'], except the latter is more verbose/slower (string construction), but has the freedom of taking variables as input. [00:25:55] * James_F nods. [00:26:29] * James_F has memories of reflection in Java coming back. [00:26:55] And yes, en-GB was the key that came to mind. [00:31:00] James_F: http://bugs.jquery.com/ticket/12365 (re: ++var) [00:31:02] :) [00:31:15] +keyword: dbr (dramatic bug reading, jQuery Portland 2013) [00:37:16] Krinkle: :-) [10:18:21] (03PS1) 10Amire80: Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 [10:19:38] (03CR) 10jenkins-bot: [V: 04-1] Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [15:01:47] Hi VisualDevelopers, scream when you're available please? :) [15:48:23] Elitre: Hey. [15:53:34] (03CR) 10Jforrester: [C: 032] Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [15:54:46] (03CR) 10jenkins-bot: [V: 04-1] Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [15:55:40] hello PM :) [15:56:19] Elitre: How can I help? [15:56:32] James_F: I think I have a problem at https://fr.wikipedia.org/wiki/Yulia_Lipnitskaya?veaction=edit [15:56:32] (possibly with slugs?) [15:57:00] Elitre: What's the problem? [15:57:31] It seems impossible to create a new section after the existing Notes one [15:57:53] without it ending up like this https://fr.wikipedia.org/w/index.php?title=Yulia_Lipnitskaya&diff=prev&oldid=101949023 , with == exposed. [15:58:15] Elitre: Huh. I can edit it fine… [15:58:46] Elitre: Are you sure that your cursor is after the reference list and before the "Champions olympiques patinage artistique par équipes" box? [15:59:27] Oh, hmm. [15:59:34] I can reproduce your error, however. [15:59:42] Darn Parsoid bug. [15:59:49] that error doesn't happen in sandboxes, apparently. [16:00:01] I'm sure it does. [16:00:22] Parsoid and VE have no concept of different behaviour in sandboxes, so it will happen everywhere or nowhere. [16:00:29] But it may be hard to reproduce. [16:00:51] the light-blue dotted boxes, are those slugs? [16:08:48] James_F: that same edit resulted in no bug at my sandbox, and bug in the ns0 :D I'm just trying to understand where I should put my cursor to avoid it. This is not clear to me. [16:11:07] Elitre: Yes, the light-blue dotted boxes are slugs. [16:11:29] Elitre: It's possible that the templates act differently in NS0 – it's possible to hack them. [16:11:37] Elitre: It's not a good idea, though. [16:30:15] James_F: then in that page I only see two slugs after the references, and then a big blue area caused by a template below. I don't understand where I should click to start a new section. [16:31:46] Elitre: Click in the slug. Type something. Done. [16:37:03] James_F: yes, and that lead to https://fr.wikipedia.org/w/index.php?title=Yulia_Lipnitskaya&diff=prev&oldid=102060031 . I was wondering if the bug could be avoided :) Should I file a bug? [16:38:07] Elitre: I will make a video. :-) [16:38:14] (And yes, file a bug please.) [16:40:26] looking forward to that video. [17:09:48] that would be https://bugzilla.wikimedia.org/show_bug.cgi?id=62647 . [17:18:28] Elitre: Video at https://dl.dropboxusercontent.com/u/17195534/Bug%2062647%20video.mov [17:19:05] Elitre: The first slug is between the and the Commons template, and works fine. The second slug is between the Commons template and the navigation template, and that's what breaks. [17:20:43] subbu: ^^^ for the issue in VE terms. [17:20:56] subbu: It's possibly something VE is doing wrong, though it's hard to see what. [17:21:13] k . waiting fo the movie to download [17:22:31] hmm ... taking too long. [17:22:39] Oh, sorry. It's "only" 20 MiB. [17:24:38] even so ... something is not right on my end. i dont see any entwork activity .. will figure out. [17:33:36] it is ff misbeahving .. i just used wget and opened it in vlc ... so, it seems like it is the serializer not doing it right from the movie. [17:49:02] subbu: Yeah, {{xxxx}}== Foo == is always bad wikitext, even if {{xxx}} produces no output, right? [17:49:49] not for php, i think. let me try {{echo|}}==foo== in the sandbox. [17:50:43] php parser of course supports that, but parsoid probably doesn't (and maynot). [17:50:55] so, we have to add a line break there. [17:51:03] Of course. :-( [17:51:12] * James_F grumbles about MW parser being a POC. [17:59:08] you mean POS? ;) [18:01:14] gwicke: Anyone using MW for Point Of Sale systems deserves to be shot. :-) [18:10:09] James_F, touch� [18:22:35] (03CR) 10Trevor Parscal: [C: 032] Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [18:24:38] (03PS1) 10Jforrester: Update VE core submodule to master (07923f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118734 [18:24:52] (03CR) 10jenkins-bot: [V: 04-1] Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [18:24:58] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (07923f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118734 (owner: 10Jforrester) [18:27:06] (03Merged) 10jenkins-bot: Update VE core submodule to master (07923f7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118734 (owner: 10Jforrester) [18:35:51] (03PS7) 10JGonera: Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 [18:35:53] (03PS1) 10JGonera: Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 [18:36:01] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 (owner: 10JGonera) [18:40:11] (03PS8) 10JGonera: Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 [18:40:13] (03PS2) 10JGonera: Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 [18:40:21] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 (owner: 10JGonera) [18:40:29] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [18:44:46] (03PS2) 10Jforrester: Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [18:45:03] (03CR) 10Jforrester: [C: 032] Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [18:46:26] (03Merged) 10jenkins-bot: Replace semicolon with full-stop in two messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118678 (owner: 10Amire80) [18:49:47] (03PS9) 10JGonera: Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 [18:49:49] (03PS3) 10JGonera: Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 [18:49:57] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 (owner: 10JGonera) [18:50:05] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [18:54:02] (03PS9) 10Trevor Parscal: Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 (owner: 10JGonera) [18:54:16] (03CR) 10jenkins-bot: [V: 04-1] Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 (owner: 10JGonera) [18:54:42] (03PS4) 10Trevor Parscal: Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [18:54:52] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [19:00:38] (03PS10) 10Trevor Parscal: Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 (owner: 10JGonera) [19:02:05] (03CR) 10Trevor Parscal: [C: 032] Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 (owner: 10JGonera) [19:03:06] (03Merged) 10jenkins-bot: Split ve.ui.Surface into DesktopSurface and MobileSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118033 (owner: 10JGonera) [19:09:36] (03PS5) 10Jforrester: Update VE core submodule to master (dd15f23) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [19:11:28] (03PS12) 10Trevor Parscal: Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 (owner: 10JGonera) [19:12:11] (03PS1) 10Jforrester: Add OOjs UI's sco.json i18n file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118743 [19:16:40] (03CR) 10Trevor Parscal: [C: 032] Add OOjs UI's sco.json i18n file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118743 (owner: 10Jforrester) [19:17:54] (03Merged) 10jenkins-bot: Add OOjs UI's sco.json i18n file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118743 (owner: 10Jforrester) [19:19:10] (03PS10) 10Trevor Parscal: Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 (owner: 10JGonera) [19:19:13] (03PS6) 10Trevor Parscal: Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [19:20:31] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 (owner: 10JGonera) [19:20:50] (03CR) 10jenkins-bot: [V: 04-1] Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [19:31:33] Gerrit down ? [19:31:47] Back up :) [19:39:47] (03PS13) 10Trevor Parscal: Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 (owner: 10JGonera) [19:40:09] (03CR) 10Trevor Parscal: [C: 032] Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 (owner: 10JGonera) [19:41:15] (03Merged) 10jenkins-bot: Split ve.ui.Context into DesktopContext and MobileContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118034 (owner: 10JGonera) [19:44:38] James_F, you around? I have... questions about images, with images. [19:45:56] mooeypoo: Sure. [19:47:02] Hold back your enthusiasm! Anyways. Check this out: [19:47:04] http://en.wikipedia.beta.wmflabs.org/wiki/User:Mooeypoo/Test_Huge_Images/SVG [19:47:12] versus http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Mooeypoo/Test_Huge_Images/PNG&action=edit [19:47:50] Inconsistencies are plenty. [19:48:01] (03CR) 10Robmoen: "PS16 fixes these issues." (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [19:48:32] (03CR) 10Robmoen: "PS16 fixes these problems" (036 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [19:49:04] mooeypoo: So… [19:49:28] So, thumb and frameless are limited to max image, the rest seem to not be, regardless of svg or png [19:49:44] Right? [19:49:51] mooeypoo: For raster images, right now MW resizes down but not up for thumb/frame/frameless? [19:50:42] frameless has a difference between svg and png [19:50:43] mooeypoo: For SVG images, MW resizes up for SVG, apparently ignoring wgSVGMaxSize (?), for all(?) types? [19:50:57] Oh, wait, no, not for frame. [19:51:15] Yeah. [19:51:20] I'm going to make a table. [19:51:29] This is so confusing. [19:51:30] Good idea. [19:51:45] Also, some of these differences in behaviour are bugs (yay). [19:51:51] I got into the code, and saw wgSVGMaxSize, but the actual behavior seems to not be consistent... [19:51:53] And some are not (even more fun). [19:51:58] I'm shocked. :-) [19:52:01] hah [19:52:55] okay, I'll make a table. Maybe a graph! :p [19:53:48] * James_F grins. [19:54:21] (03PS1) 10Trevor Parscal: Update VE core submodule to master (520299e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118749 [19:54:52] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (520299e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118749 (owner: 10Trevor Parscal) [19:56:54] (03PS16) 10Robmoen: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 [19:58:24] James_F, RoanKattouw_away: PS16 *Should* be G2G :) [19:58:42] rmoen: Oooh. :-) [19:58:47] Also, fixed the show/hide bug that RoanKattouw_away reported [19:58:59] Nice. [20:04:24] (03Abandoned) 10Jforrester: Use DesktopSurface in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118736 (owner: 10JGonera) [20:04:55] (03Abandoned) 10Jforrester: Use DesktopContext and MobileSurface/Context [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118043 (owner: 10JGonera) [20:05:11] (03PS2) 10Trevor Parscal: Update VE core submodule to master (520299e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118749 [20:05:15] (03PS6) 10Trevor Parscal: Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [20:05:53] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (520299e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118749 (owner: 10Trevor Parscal) [20:06:05] (03CR) 10jenkins-bot: [V: 04-1] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [20:11:38] James_F, I sent you the table. It seems there's nothing to fix in VE... not sure if that's because it's the intended behavior or a bug, but it seems to be the same as wikitext rendering. [20:12:06] So, the bug rumanna reported is probably a problem with scientific notation alone. I'll fix that, but it seems I shouldn't be limiting any sizes? [20:12:52] mooeypoo: Maybe we should just set a maximum? [20:13:02] we could. [20:13:07] (03PS3) 10Jforrester: Update VE core submodule to master (520299e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118749 (owner: 10Trevor Parscal) [20:13:11] wikitext doesn't. [20:13:29] I don't know what anyone would want to put an image at 1000000px for, but wikitext allows... [20:13:50] You want to limit all sizes to some VE limit? [20:15:02] wait, hm, okay, these tests are how image first render in VE.. it appears i have to fix the behavior for when you change types [20:15:52] Yeah. [20:15:57] * James_F sighs. [20:16:09] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (520299e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118749 (owner: 10Trevor Parscal) [20:17:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (520299e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118749 (owner: 10Trevor Parscal) [20:24:04] (03PS7) 10Trevor Parscal: Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [20:28:33] (03CR) 10Trevor Parscal: [C: 032] Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [20:29:30] (03Merged) 10jenkins-bot: Style MobileContext as a dropdown drawer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118223 (owner: 10JGonera) [20:31:08] (03PS1) 10Trevor Parscal: Update VE core submodule to master (a651f19) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118754 [20:45:26] (03PS1) 10Trevor Parscal: Bring back localOverlayMenus, but only in DesktopSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118757 [20:46:26] (03CR) 10Jforrester: [C: 032] Bring back localOverlayMenus, but only in DesktopSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118757 (owner: 10Trevor Parscal) [20:46:34] (03PS1) 10Jforrester: [WIP] Add a clean-up script for use as a pre-commit hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118758 [20:47:28] (03Merged) 10jenkins-bot: Bring back localOverlayMenus, but only in DesktopSurface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118757 (owner: 10Trevor Parscal) [20:48:34] (03PS1) 10Jforrester: Update VE core submodule to master (cd00a93) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118759 [20:49:03] (03CR) 10Jforrester: [C: 032] "Per Trevor." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118759 (owner: 10Jforrester) [20:49:16] (03Abandoned) 10Jforrester: Update VE core submodule to master (a651f19) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118754 (owner: 10Trevor Parscal) [20:50:27] (03Merged) 10jenkins-bot: Update VE core submodule to master (cd00a93) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118759 (owner: 10Jforrester) [21:23:55] (03PS1) 10JGonera: Merge two Properties blocks in DesktopContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118766 [21:24:05] TrevorParscal, we forgot about this ^ [21:25:27] mooeypoo: Also, guess what just got merged in Parsoid? https://gerrit.wikimedia.org/r/103360 :-) [21:25:48] (03CR) 10Jforrester: [C: 032] Merge two Properties blocks in DesktopContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118766 (owner: 10JGonera) [21:26:52] (03Merged) 10jenkins-bot: Merge two Properties blocks in DesktopContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118766 (owner: 10JGonera) [21:31:26] (03PS1) 10Trevor Parscal: [WIP] Citation tool and dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118768 [21:32:51] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Citation tool and dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118768 (owner: 10Trevor Parscal) [21:35:31] James_F, ooooh [21:35:34] TrevorParscal: https://gist.github.com/anonymous/9557453 [21:40:42] mooeypoo: Not a huge priority user-wise, though. [21:43:12] yeah, but good to add to the list. [21:43:58] That dialog is getting mighty complex though.. adding inline images like this will be a mess. [21:44:56] Another, higher-priority request is to render a preview of the image in the dialog. [21:45:02] No idea how that will work. :-) [21:45:21] hmm yeah I started thinking about that. [21:45:31] I am thinking we can do that with a separate surface. [21:45:37] We can talk about this next week [21:45:57] Definitely. :-) [21:46:11] Also, other things you can work on. I imagine you're sick of images. :-) [21:50:45] I am fond of images. It's the image wikitext that irks me.... :D [21:51:26] * James_F grins. [21:56:55] RoanKattouw: the solution to the isCompatible firestorm of death is solved by this: https://gerrit.wikimedia.org/r/#/c/118623/ [21:57:00] and you get to figure out why [22:17:11] If I don't see you guys when I get back -- see you tomorrow/next-week ! :) [22:17:17] moo|dinner: See you!@ [22:20:40] (03PS17) 10Catrope: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [22:21:11] (03CR) 10Catrope: "PS17 fixes a bug where the TOC rendering would flash if you split a heading while the TOC's contents were hidden." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [22:28:42] (03PS1) 10Catrope: Rerun grunt to regenerate eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118775 [22:29:21] (03CR) 10Catrope: [C: 032] Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [22:31:11] (03Merged) 10jenkins-bot: Table of contents widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108945 (owner: 10Robmoen) [22:53:03] (03CR) 10Jforrester: [C: 032] Rerun grunt to regenerate eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118775 (owner: 10Catrope) [22:54:33] (03Merged) 10jenkins-bot: Rerun grunt to regenerate eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118775 (owner: 10Catrope) [23:31:17] (03PS1) 10Catrope: Make ContentBranchNode echo suppression work in CBNs that contain inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118785 [23:32:00] (03CR) 10jenkins-bot: [V: 04-1] Make ContentBranchNode echo suppression work in CBNs that contain inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118785 (owner: 10Catrope) [23:34:33] (03PS2) 10Catrope: Make ContentBranchNode echo suppression work in CBNs that contain inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118785 [23:35:30] (03CR) 10jenkins-bot: [V: 04-1] Make ContentBranchNode echo suppression work in CBNs that contain inline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118785 (owner: 10Catrope)