[00:05:26] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/113339/
[00:43:04] <RoanKattouw>	 >>> s = ''; !s
[00:43:04] <ecmabot-wm>	 RoanKattouw: (boolean) true
[00:43:09] <RoanKattouw>	 mooeypoo: ---^^
[00:43:27] <James_F>	 >>> !''
[00:43:28] <ecmabot-wm>	 James_F: (boolean) true
[00:43:53] <James_F>	 >>> !'' || '' & ''===!''
[00:43:53] <ecmabot-wm>	 James_F: (boolean) true
[00:44:13] <James_F>	 RoanKattouw: New Brainfuck-like syntax for you there.
[00:44:38] <mooeypoo>	 woot, thanks RoanKattouw 
[00:45:41] <RoanKattouw>	 >>> '' & ''
[00:45:41] <ecmabot-wm>	 RoanKattouw: (number) 0
[00:45:48] <mooeypoo>	 >>> s=0; !s
[00:45:48] <ecmabot-wm>	 mooeypoo: (boolean) true
[00:45:51] <mooeypoo>	 hm.
[00:45:55] <RoanKattouw>	 >>> '' & '' === !''
[00:45:55] <ecmabot-wm>	 RoanKattouw: (number) 0
[00:46:01] <mooeypoo>	 >>> s=null; !s
[00:46:01] <ecmabot-wm>	 mooeypoo: (boolean) true
[00:46:06] <RoanKattouw>	 >>> 5 & 4
[00:46:06] <ecmabot-wm>	 RoanKattouw: (number) 4
[00:46:07] <mooeypoo>	 >>> s=''; !s
[00:46:08] <ecmabot-wm>	 mooeypoo: (boolean) true
[00:46:09] <RoanKattouw>	 >>> 5 & 4 === 3
[00:46:09] <ecmabot-wm>	 RoanKattouw: (number) 0
[00:46:37] <mooeypoo>	 ok, so '', null and 0 are all true for !s values. hm.
[00:47:09] <RoanKattouw>	 >>> (boolean)''
[00:47:10] <ecmabot-wm>	 RoanKattouw: SyntaxError: Unexpected string
[00:47:12] <RoanKattouw>	 >>> (boolean)null
[00:47:12] <ecmabot-wm>	 RoanKattouw: SyntaxError: Unexpected token null
[00:47:14] <RoanKattouw>	 Urgh
[00:47:18] <RoanKattouw>	 >>> (bool)null
[00:47:18] <ecmabot-wm>	 RoanKattouw: SyntaxError: Unexpected token null
[00:47:33] <mooeypoo>	 >>> s=undefined; !s
[00:47:34] <ecmabot-wm>	 mooeypoo: (boolean) true
[00:52:34] <grrrit-wm>	 (03PS1) 10Jforrester: Disable VisualEditor on Page Translation output pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119427 
[01:04:33] <RoanKattouw>	 James_F: TrevorParscal is here now BTW
[01:04:45] <RoanKattouw>	 Or was 20 mins ago at lesat
[01:10:50] <James_F>	 RoanKattouw: Office hours, sorry.
[01:14:09] <RoanKattouw>	 mooeypoo: https://gerrit.wikimedia.org/r/#/c/73965/
[01:22:14] <RoanKattouw>	 mooeypoo: https://www.mediawiki.org/wiki/User:Catrope/Ridiculous_VE_commits
[01:44:24] <grrrit-wm>	 (03PS1) 10Catrope: [WIP] Followup 1b9c077: debounce toolbar's onSurfaceViewKeyup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119432 
[01:45:21] <James_F>	 RoanKattouw: Do you have performance numbers on that change?
[01:45:31] <RoanKattouw>	 Not yet
[01:45:37] <RoanKattouw>	 I'm also not done with it
[01:45:40] * James_F  nods.

[01:45:48] <RoanKattouw>	 I'll measure it when I'm done
[01:46:03] <James_F>	 So, never? ;-)
[01:46:10] <James_F>	 Performance is a process, not a goal.
[01:48:06] <James_F>	 RoanKattouw: David Gerard suggests doing performance metrics off [[w:en:OpenOffice.org]].
[01:48:19] <RoanKattouw>	 I'm hoping that commit and https://bugzilla.wikimedia.org/show_bug.cgi?id=62812 will take care of most of the typing issues
[01:48:22] <RoanKattouw>	 James_F: That would be good
[01:48:35] * James_F  nods.

[01:49:41] <RoanKattouw>	 I've been using Kuala Lumpur lately but that's only because that's what Kenan showed me
[01:49:54] <RoanKattouw>	 But I'd be very happy to use a page that's been identified by a community member as notorious
[01:50:18] <James_F>	 RoanKattouw: If we could do a July 2013 vs. now metric that'd be awesome, BTW.
[01:51:52] <RoanKattouw>	 That's reliant on me importing a realistic version of a big page into a local wiki
[01:52:01] <RoanKattouw>	 But if that could be done then this would be easy
[01:52:22] <James_F>	 RoanKattouw: Or running off prod with switched-out JS?
[01:56:35] <RoanKattouw>	 That is how I usually test perf fixes, but only for trivial changes
[01:56:44] <RoanKattouw>	 It's harder to do for large-scale rollbacks, although it could be attempted
[01:56:50] * James_F  nods.

[01:57:10] <James_F>	 RoanKattouw: MatmaRex was using a local proxy that transparently substituted bits calls, IIRC.
[01:57:36] <RoanKattouw>	 I can also point my Parsoid URL to prod again, and pull some oldid shenanigans
[01:57:48] <James_F>	 RoanKattouw: True.
[01:58:09] <James_F>	 RoanKattouw: Numbers about bandwidth, speed, memory and CPU would all be good, of course.
[02:32:04] <isaaclw>	 according to the "MediaWiki" download tool... I'm supposed to consult the documentation about "registering" the plugin, I don't see any instructions inside the folder, though, so I tried adding this: `require_once "$IP/extensions/VisualEditor/VisualEditor.php";` and it didn't seem to work. What did I miss?
[02:33:05] <grrrit-wm>	 (03PS1) 10Mooeypoo: [WIP^2] Refactor Scalable and MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 
[02:33:42] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP^2] Refactor Scalable and MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo)
[02:34:21] <RoanKattouw>	 isaaclw: See https://www.mediawiki.org/wiki/Extension:VisualEditor#Basic_setup_instructions for installation instructions
[02:42:24] <grrrit-wm>	 (03PS6) 10Catrope: Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 
[02:42:26] <grrrit-wm>	 (03PS1) 10Catrope: Add lookupTitle attribute [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119436 
[02:44:02] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[02:44:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add lookupTitle attribute [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119436 (owner: 10Catrope)
[02:45:09] <grrrit-wm>	 (03PS7) 10Catrope: Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 
[02:46:12] <grrrit-wm>	 (03PS8) 10Catrope: Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 
[02:46:14] <grrrit-wm>	 (03PS2) 10Catrope: Add lookupTitle attribute [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119436 
[02:47:44] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[02:47:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add lookupTitle attribute [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119436 (owner: 10Catrope)
[02:53:34] <Meiko>	 grrrit-wm's IRC real-name is the best
[02:53:40] <Meiko>	 I just noticed it
[02:53:57] <RoanKattouw>	 haha
[02:54:10] <RoanKattouw>	 The name of the tool project (and the original name of the bot) is lolrrit-wm
[02:54:23] <Meiko>	 ah, still funny :P
[02:54:28] <Meiko>	 my bot is boring
[02:54:41] <Meiko>	 you can probably see it by doing /whois MeikoBot
[02:55:02] <Meiko>	 all it does is read recent changes from every wiki at http://www.brickimedia.org
[02:55:09] <grrrit-wm>	 (03PS9) 10Catrope: Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 
[02:55:09] <Meiko>	 and is really glitchy
[02:55:41] <Meiko>	 some mornings when I wake up the bot will just be broken and I can't get it to disconnect from freenode sometimes. It is sooo annoying
[04:25:02] <isaaclw>	 Thanks RoanKattouw. I think that took care of it for me.
[05:37:13] <gjack>	 what previous knowledge is required to work on the visual editor translate extension?
[06:52:37] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Display links to nonexistent pages as red (038 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[06:55:07] <grrrit-wm>	 (03CR) 10Krinkle: "Various things to be optimised." (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/70918 (owner: 10Robmoen)
[10:35:22] <grrrit-wm>	 (03CR) 10Nikerabbit: Disable VisualEditor on Page Translation output pages (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119427 (owner: 10Jforrester)
[10:39:13] <grrrit-wm>	 (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar)
[10:39:18] <grrrit-wm>	 (03PS8) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 
[10:41:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar)
[12:18:37] <grrrit-wm>	 (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar)
[12:27:04] <grrrit-wm>	 (03PS1) 10Esanders: Use this.constructor.super instead of ClassName.super [oojs/core] - 10https://gerrit.wikimedia.org/r/119466 
[12:28:47] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use this.constructor.super instead of ClassName.super [oojs/core] - 10https://gerrit.wikimedia.org/r/119466 (owner: 10Esanders)
[12:38:35] <grrrit-wm>	 (03Abandoned) 10Esanders: Use this.constructor.super instead of ClassName.super [oojs/core] - 10https://gerrit.wikimedia.org/r/119466 (owner: 10Esanders)
[13:08:56] <grrrit-wm>	 (03PS1) 10Esanders: User super to call parent constructor [oojs/ui] - 10https://gerrit.wikimedia.org/r/119470 
[13:08:58] <grrrit-wm>	 (03PS1) 10Esanders: Use super to call parent methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/119471 
[13:10:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] User super to call parent constructor [oojs/ui] - 10https://gerrit.wikimedia.org/r/119470 (owner: 10Esanders)
[13:10:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use super to call parent methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/119471 (owner: 10Esanders)
[13:12:40] <tonythomas>	 Hi! I was working on replacing the $.proxy with ve.bind (https://bugzilla.wikimedia.org/show_bug.cgi?id=62762). The documentation of ve.bind = $.proxy; in ve.js shows that its a wrapper for function#bind. Actually, it is the function $.proxy getting wrapped by ve.bind right ? 
[13:16:56] <grrrit-wm>	 (03PS1) 10Esanders: Increase width of toggle switch widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119472 
[13:18:11] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Increase width of toggle switch widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119472 (owner: 10Esanders)
[13:19:55] <tonythomas>	 edsanders:  Hi ! you around ?
[13:20:18] <tonythomas>	 Cab you help me with this bug https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 ?\
[13:43:44] <edsanders>	 tonythomas, I can try, what's the problem?
[13:44:53] <tonythomas>	 edsanders: Hi.! As commented in BZ, the trick is to change ve.bind() to a wrapper that uses native .bind(). 
[13:45:27] <tonythomas>	 wait a minute. The bug, is to replace the $.proxy with ve.bind (https://bugzilla.wikimedia.org/show_bug.cgi?id=62762). 
[13:48:04] <edsanders>	 we don't use $.proxy
[13:48:14] <edsanders>	 we just have ve.bind = $.proxy
[13:53:48] <tonythomas>	 edsanders: but, that means $.proxy is wrapped by ve.bind right ? or am I taking the concept of wrapper wrong ?
[14:06:30] <edsanders>	 tonythomas, there's no wrapping there, ve.bind and $.proxy are now identical object pointers
[14:08:41] <tonythomas>	 edsanders:  ok , I got confused by https://git.wikimedia.org/blob/VisualEditor%2FVisualEditor.git/HEAD/modules%2Fve%2Fve.js#L111 
[14:08:54] <tonythomas>	 it says Wrapper for Function#bind.
[15:34:08] <grrrit-wm>	 (03PS1) 10Esanders: Add disabled styling to InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119491 
[15:36:28] <grrrit-wm>	 (03PS2) 10Esanders: Add disabled styling to InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119491 
[15:39:06] <grrrit-wm>	 (03PS1) 10Esanders: Promote zIndex of InlineMenuWidget options list [oojs/ui] - 10https://gerrit.wikimedia.org/r/119492 
[16:03:31] <grrrit-wm>	 (03CR) 10Esanders: "Do we need to be adding the dropdown to an overlay layer and positioning it like we do with TextInputMenuWidget?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/119492 (owner: 10Esanders)
[16:13:57] <James_F>	 Heya.
[16:26:00] <tonythomas>	 James_F: Hi ! I talked with hoo on yesterdays bug on getting rid of $.proxy() 
[16:26:36] <James_F>	 tonythomas: Oh?
[16:30:58] <tonythomas>	 James_F:  yeah ! and he told me about adding something like ve.bind = function( func, c) {
[16:30:58] <tonythomas>	 	  func.bind.apply( c, arguments );
[16:30:58] <tonythomas>	 	}
[16:31:51] <grrrit-wm>	 (03PS1) 10Esanders: Fix documentation of toolFactory [oojs/ui] - 10https://gerrit.wikimedia.org/r/119497 
[16:32:35] <grrrit-wm>	 (03PS2) 10Esanders: Fix documentation of toolFactory [oojs/ui] - 10https://gerrit.wikimedia.org/r/119497 
[16:32:58] <tonythomas>	 James_F: that can come in replacement of ve.bind = $.proxy ? 
[16:51:29] <James_F>	 tonythomas: I'm not an expert – Krinkle|detached or RoanKattouw_away should be able to help more, sorry.
[16:51:47] <tonythomas>	 James_F: Thats ok. I will try to get them 
[17:13:07] <Krinkle>	 tonythomas: I've replied on the bug report for that
[17:18:05] <grrrit-wm>	 (03PS2) 10Krinkle: Use super to call parent constructor [oojs/ui] - 10https://gerrit.wikimedia.org/r/119470 (owner: 10Esanders)
[17:19:02] <grrrit-wm>	 (03PS2) 10Krinkle: Use super to call parent methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/119471 (owner: 10Esanders)
[17:19:05] <tonythomas>	 Krinkle: so, it has to be like bind with a small wrapper to bind using bind ?
[17:19:17] <tonythomas>	 almost got me confused 
[17:19:34] <tonythomas>	 but anyway, does something like ve.bind = function( func, c) { 
[17:19:38] <tonythomas>	 func.bind.apply( c, arguments );
[17:19:46] <tonythomas>	 } do it ?
[17:21:25] <Krinkle>	 tonythomas: like, but not that
[17:21:54] <Krinkle>	 In order to wrap func.bind( context, param... ) you have to call the 'bind' function in the contet of 'func', not 'context'
[17:22:23] <Krinkle>	 Lets' say function helloWorld() { expect(this).is(bar); }
[17:23:00] <Krinkle>	 helloWorld.bind( bar ); <!-- This calls Function.prototype.bind in context of helloWorld, with bar as first parameter
[17:23:25] <Krinkle>	 helloWorld inherits from Function.prototype, so helloWorld.bind === Function.prototype.bind
[17:23:48] <Krinkle>	 so you'll want to bind.apply( func, .. )
[17:24:08] <Krinkle>	 And, because your argument signature is off by one (not compatible with .bind(), you have an extra first parameter, the function), youll need to shift the arguments
[17:24:26] <Krinkle>	 convert arguments to an array, shift by one, pass that as bind context, and pass the rest through to bind as its arguments
[17:24:38] <Krinkle>	 var args = Array#slice(arguments);
[17:24:44] <tonythomas>	 ok. 
[17:24:53] <Krinkle>	 var args = Array#slice.call(arguments, 1);
[17:27:37] <tonythomas>	 Krinkle: can you explain that argument signature off by one a bit ?
[17:28:11] <Krinkle>	 tonythomas: Give me an example of calling bind() without a wrapper, giving it 'x' as context and '1' and '2' as predefined arguments.
[17:30:09] <RoanKattouw>	 Krinkle: Re your comments on https://gerrit.wikimedia.org/r/#/c/70918/2/modules/ve/ui/ve.ui.Toolbar.js , did you see https://gerrit.wikimedia.org/r/119432 ?
[17:30:26] <Krinkle>	 >> var x = { hello: function() { console.log({ context: this.toString(), args: [].slice.call(arguments) }); }, toString: function () { return '[object X]'; } };  x.hello(1, 2);
[17:30:26] <ecmabot-wm>	 Krinkle: undefined; Console: {args: [1, 2], context: '[object X]'}
[17:30:54] <Krinkle>	 >> var x = { hello: function() { console.log({ context: this.toString(), args: [].slice.call(arguments) }); }, toString: function () { return '[object X]'; } };  var y = x.hello; y(); // without any binding
[17:30:54] <ecmabot-wm>	 Krinkle: undefined; Console: {args: [], context: '[object global]'}
[17:31:08] <Krinkle>	 >> var x = { hello: function() { console.log({ context: this.toString(), args: [].slice.call(arguments) }); }, toString: function () { return '[object X]'; } };  var y = x.hello.bind( x, 1, 2 ); y();
[17:31:08] <ecmabot-wm>	 Krinkle: undefined; Console: {args: [1, 2], context: '[object X]'}
[17:31:19] <Krinkle>	 tonythomas: That one makes sense, right?
[17:32:44] <Krinkle>	 So arguments of bind() are bind( context, param1, param2,  ..) 
[17:33:01] <Krinkle>	 arguments of ve.bind and $.proxy are: proxy( function, context, param1, param2, .. )
[17:33:25] <Krinkle>	 Where prototype methods transfer the function via their own context, this one has to take it as an argument, so its off by one
[17:33:48] <Krinkle>	 if you pass 'arguments' as is, it'll be broken and be doing somethign completely different
[17:35:05] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Use super to call parent constructor [oojs/ui] - 10https://gerrit.wikimedia.org/r/119470 (owner: 10Esanders)
[17:35:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use super to call parent constructor [oojs/ui] - 10https://gerrit.wikimedia.org/r/119470 (owner: 10Esanders)
[17:36:25] <tonythomas>	 Krinkle: Thanks. i will do the same in an hour. brb. Sorry
[17:40:22] <RoanKattouw>	 Krinkle: (Please see my ping above)
[17:42:01] <grrrit-wm>	 (03PS1) 10Krinkle: demo: Add ToggleSwitchWidget (disabled, checked) [oojs/ui] - 10https://gerrit.wikimedia.org/r/119513 
[17:42:59] <James_F>	 Krinkle: If we're going to have a disabled/checked state for the toggle, shouldn't we also have an enabled/checked one?
[17:43:15] <Krinkle>	 James_F: That one you can click and toggle in the demo
[17:43:19] <Krinkle>	 the disabled one not so much
[17:43:28] <James_F>	 Krinkle: But the demos page is meant to an exhaustive list of widgets with some examples, not an exhaustive list of their states…
[17:43:37] <James_F>	 Krinkle: Sure you can; that's what the consoles are for. :-)
[17:44:05] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] demo: Add ToggleSwitchWidget (disabled, checked) [oojs/ui] - 10https://gerrit.wikimedia.org/r/119513 (owner: 10Krinkle)
[17:44:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: demo: Add ToggleSwitchWidget (disabled, checked) [oojs/ui] - 10https://gerrit.wikimedia.org/r/119513 (owner: 10Krinkle)
[17:44:41] <grrrit-wm>	 (03CR) 10Catrope: Display links to nonexistent pages as red (037 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[17:46:40] <grrrit-wm>	 (03CR) 10Krinkle: [C: 031] [WIP] Followup 1b9c077: debounce toolbar's onSurfaceViewKeyup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119432 (owner: 10Catrope)
[17:47:45] <RoanKattouw>	 Krinkle: Does ---^^ address what you were talking about? The performance suggestions you brought up are good and I hadn't thought of them, but the main issue in terms of time is getSelectionRect() and that one isn't very avoidable without debouncing
[17:50:00] <Krinkle>	 RoanKattouw: I hadn't even looked inside getSelectionRect yet
[17:50:11] <Krinkle>	 That method seems to be an ombinus of calculate and reflow friggin everything
[17:50:25] <Krinkle>	 We used to have that for the floating logic before I implemented the toolbar tracker
[17:50:47] <Krinkle>	 Which made a noticeable increase in scrolling and resize performance at the time.
[17:51:27] <RoanKattouw>	 Right
[17:51:42] <RoanKattouw>	 We got rid of the toolbar tracker though because the save dialog isn't anchored to it any more
[17:51:52] <RoanKattouw>	 Also, when I said getSelectionRect, I mainly meant the native method
[17:52:01] <RoanKattouw>	 1/2 to 2/3 of the slowness is there
[17:52:15] <RoanKattouw>	 Though if you find optimizations in our getSelectionRect function that would be awesome in any case
[17:53:36] <Krinkle>	 The focusable node calculation for example, is a perfect example of where data should be shared instead of inspecting the dom for yourself. Focusable node is in control of its position and dimensions, it can provide this with 0 dom overhead.
[17:54:21] <Krinkle>	 Not the biggest overhead it would appear (haven't measured it for myself yet, will take your word for it), but tha tkind of thing adds up
[17:57:11] <Krinkle>	 toolbar height doesn't change unless window width changes and the thing breaks up a line, so that can be saved as well.
[17:57:51] <Krinkle>	 same for its offset, that never changes over the course of one page execution (fixed by stylesheet, we used to or are relying on this not changing elsewhere too)
[18:00:38] <RoanKattouw>	 Right
[18:01:06] <RoanKattouw>	 Also did you see the other perf bug I filed yesterday?
[18:01:10] * RoanKattouw  looks it up

[18:01:23] <grrrit-wm>	 (03PS1) 10Esanders: Basic toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/119516 
[18:01:25] <grrrit-wm>	 (03PS1) 10Esanders: Disabled styling for MenuToolgroup items [oojs/ui] - 10https://gerrit.wikimedia.org/r/119517 
[18:01:27] <grrrit-wm>	 (03PS1) 10Esanders: Force visible label for MenuToolGroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119518 
[18:01:43] <RoanKattouw>	 Krinkle: https://bugzilla.wikimedia.org/show_bug.cgi?id=62812
[18:02:08] <James_F>	 edsanders: You trying to put Krinkle out of a job? :-)
[18:02:33] <grrrit-wm>	 (03CR) 10Krinkle: Display links to nonexistent pages as red (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[18:02:35] <James_F>	 edsanders: https://gerrit.wikimedia.org/r/#/c/109006/ could do with some love, for example.
[18:03:05] <grrrit-wm>	 (03PS2) 10Esanders: Basic toolbar demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/119516 
[18:03:07] <grrrit-wm>	 (03PS2) 10Esanders: Disabled styling for MenuToolgroup items [oojs/ui] - 10https://gerrit.wikimedia.org/r/119517 
[18:03:09] <grrrit-wm>	 (03PS2) 10Esanders: Force visible label for MenuToolGroups [oojs/ui] - 10https://gerrit.wikimedia.org/r/119518 
[18:03:59] <edsanders>	 didn't see that - although mine was so I could demonstrate the bugs in the two later commits
[18:04:28] <James_F>	 edsanders: Sure. :-)
[18:04:50] <edsanders>	 also that is for dialogs and layouts, mine is for toolbars
[18:04:55] <edsanders>	 I see no conflict there
[18:04:55] <James_F>	 Krinkle: Are you planning to un-WIP 109006 (the OOjs UI widgets and dialog demo)?
[18:05:14] <James_F>	 edsanders: Not conflict, just that this was the area Timo was working in. :-)
[18:08:29] <Krinkle>	 RoanKattouw: Hadn't seen it yet no.
[18:11:30] <grrrit-wm>	 (03CR) 10Krinkle: Display links to nonexistent pages as red (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[18:13:45] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Fix documentation of toolFactory [oojs/ui] - 10https://gerrit.wikimedia.org/r/119497 (owner: 10Esanders)
[18:14:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix documentation of toolFactory [oojs/ui] - 10https://gerrit.wikimedia.org/r/119497 (owner: 10Esanders)
[18:22:14] <grrrit-wm>	 (03CR) 10Catrope: Display links to nonexistent pages as red (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[18:22:50] <grrrit-wm>	 (03CR) 10Krinkle: "Checked out, ran grunt build, ack'ed for 'parent method' -Q -i -A1 dist/, found three more matches that don't use super:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/119471 (owner: 10Esanders)
[18:23:46] <grrrit-wm>	 (03CR) 10Krinkle: Display links to nonexistent pages as red (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[18:24:16] <James_F>	 edsanders: Want me to fix ^^^ those for you?
[18:30:03] <grrrit-wm>	 (03PS3) 10Jforrester: Use super to call parent methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/119471 (owner: 10Esanders)
[18:33:49] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Use super to call parent methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/119471 (owner: 10Esanders)
[18:34:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use super to call parent methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/119471 (owner: 10Esanders)
[19:01:14] <grrrit-wm>	 (03PS1) 10Krinkle: readme: Use HiDPI version of npm badge [oojs/core] - 10https://gerrit.wikimedia.org/r/119538 
[19:02:00] <grrrit-wm>	 (03PS2) 10Krinkle: readme: Use HiDPI version of npm badge [oojs/core] - 10https://gerrit.wikimedia.org/r/119538 
[19:02:06] <grrrit-wm>	 (03CR) 10Krinkle: "Parser failure. http://git.wikimedia.org/blob/oojs%2Fcore/2237584797f85540fe45321d1f94f0925af666e8/README.md" [oojs/core] - 10https://gerrit.wikimedia.org/r/119538 (owner: 10Krinkle)
[19:02:24] <grrrit-wm>	 (03CR) 10Krinkle: "Works. http://git.wikimedia.org/blob/oojs%2Fcore/829e0c8e2b6607afdf9b5e920aebf15591daf9e6/README.md" [oojs/core] - 10https://gerrit.wikimedia.org/r/119538 (owner: 10Krinkle)
[19:02:32] <mooeypoo>	 >>> s=null; !!s
[19:02:33] <ecmabot-wm>	 mooeypoo: (boolean) false
[19:02:48] <mooeypoo>	 >>> s=undefined; !!s
[19:02:48] <ecmabot-wm>	 mooeypoo: (boolean) false
[19:25:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] readme: Use HiDPI version of npm badge [oojs/core] - 10https://gerrit.wikimedia.org/r/119538 (owner: 10Krinkle)
[19:25:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: readme: Use HiDPI version of npm badge [oojs/core] - 10https://gerrit.wikimedia.org/r/119538 (owner: 10Krinkle)
[19:28:00] <grrrit-wm>	 (03PS10) 10Catrope: Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 
[19:28:02] <grrrit-wm>	 (03PS3) 10Catrope: Add lookupTitle attribute [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119436 
[19:40:36] <tonythomas>	 Krinkle: will something like this work ? 
[19:40:36] <tonythomas>	 var args = Array#slice.call(arguments, 1); 
[19:40:36] <tonythomas>	 ve.bind = function( func, c) { 
[19:40:36] <tonythomas>	       bind.apply( func, c, args );
[19:40:36] <tonythomas>	 }
[20:05:15] <aharoni>	 hi vikas 
[20:05:30] <vikas>	 hello aharoni
[20:12:11] <vikas>	 I was working on browser tests for visual editor on my local machine, when I click on save page I get only 1 iframe, because of which tests were failing in my machine 
[20:12:33] <vikas>	 but in http://en.wikipedia.beta.wmflabs.org/ I get 2 iframes 
[20:12:45] <vikas>	 any idea of why it is happening ? 
[20:14:33] <aharoni>	 vikas: which test scenario did you run?
[20:14:40] <aharoni>	 which feature file and line number?
[20:14:44] <aharoni>	 chrismcmalunch: ^
[20:15:15] <chrismcmahon>	 hi aharoni vikas
[20:15:27] <vikas>	 chrismcmohan: hello 
[20:15:38] <MatmaRex>	 can i get myself a Krinkle for five minutes? why is jshint failing https://gerrit.wikimedia.org/r/#/c/119553/ when i haven't modified any of the .js files (only moved them)?
[20:15:59] <vikas>	 it used to happen for all tests, but i was specifically checking for bullets.feature
[20:23:15] <aharoni>	 vikas: on which line does it fail?
[20:24:00] <vikas>	 I click Review your changes => line 7 => bullets.feature
[20:24:20] <vikas>	 error: timed out after 5 seconds, waiting for {:class=>"oo-ui-labeledElement-label", :text=>"Review your changes", :tag_name=>"span"} to become present (Watir::Wait::TimeoutError)
[20:26:01] <aharoni>	 so, vikas chrismcmahon James_F|Away rmoen - do you happen to know whether this test is supposed to run successfully at this time?
[20:26:46] <aharoni>	 is it incorrect specification in the selenium tests or a bug in ve? Without looking too deeply into it, I suspect that the problem is in the review_changes element definition, though I might be wrong.
[20:27:01] <chrismcmahon>	 vikas:  that test is passing right now in beta labs https://wmf.ci.cloudbees.com/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/407/
[20:27:49] <vikas>	 chrismcmohan: yup it works on en.wikipedia.beta.wmflabs.org but not on local machine 
[20:34:12] <vikas>	 chrismcmahon:  yup it works on en.wikipedia.beta.wmflabs.org but not on local machine 
[20:39:23] <vikas>	 chrismcmahon: check this => http://etherpad.wikimedia.org/p/vikassy
[20:40:10] <chrismcmahon>	 vikas:  I don't know.  This is why I use beta labs
[20:47:33] <vikas>	 chrismcmahon: ok :) 
[20:51:08] <Krinkle>	 MatmaRex: It is failing, most likely because someone enabled jshint on a repository without a .jshintrc file
[20:51:56] <Krinkle>	 Add the file in a separtae commit, get it merged (I'll +2) and rebase.
[20:52:07] <aharoni>	 mooeypoo: happy yomuledet
[21:22:14] <grrrit-wm>	 (03CR) 10Catrope: Display links to nonexistent pages as red (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[21:29:43] <mooeypoo>	 aharoni, \o/ thanks!!
[21:56:31] <RoanKattouw>	 rmoen: Ahm.... http://imgur.com/3rzwBsr
[21:56:49] <RoanKattouw>	 rmoen: It looks like the TOC isn't torn down right on surface teardown, because if you do Edit -> Read -> Edit, you get two TOCs
[21:58:09] <grrrit-wm>	 (03PS11) 10Catrope: Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 
[22:03:23] <rmoen>	 RoanKattouw: lol /facepalm
[22:03:50] <rmoen>	 RoanKattouw: Thanks i'll make a patch for that
[22:04:19] <James_F>	 rmoen: Whee.
[22:04:27] <rmoen>	 :)
[22:19:27] <RoanKattouw>	 Krinkle: Amended ---^^
[22:25:31] <grrrit-wm>	 (03PS2) 10Catrope: Disable VisualEditor on Page Translation output pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119427 (owner: 10Jforrester)
[22:26:02] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Disable VisualEditor on Page Translation output pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119427 (owner: 10Jforrester)
[22:26:14] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Disable VisualEditor on Page Translation output pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119427 (owner: 10Jforrester)
[22:27:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Disable VisualEditor on Page Translation output pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119427 (owner: 10Jforrester)
[22:27:43] <grrrit-wm>	 (03PS14) 10Catrope: Create mixin that tries to execute primary node command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[22:30:02] <grrrit-wm>	 (03CR) 10Jforrester: "FIXME, plz." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders)
[22:30:41] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Create mixin that tries to execute primary node command (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[22:33:32] <grrrit-wm>	 (03CR) 10Catrope: Create mixin that tries to execute primary node command (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[22:49:25] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Mixin ClickableNode and add primary command names (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[22:50:04] <RoanKattouw>	 rmoen: Are you around and ready to fix the ClickableNode commit? ---^^ We want it to land today, so if you're not, I'll fix it up, but if you're around we can work in parallel and be more efficient
[22:50:46] <rmoen>	 RoanKattouw: one sec, i haven't checked the comments yet
[22:50:55] <grrrit-wm>	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (53f2410336) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119654 
[22:51:05] <rmoen>	 RoanKattouw: im putting in this fix for the toc teardown
[22:51:43] <RoanKattouw>	 Oh right
[22:51:45] <RoanKattouw>	 Cool
[22:51:46] <grrrit-wm>	 (03PS1) 10Robmoen: Properly teardown TOC widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119655 
[22:51:59] <RoanKattouw>	 Sorry I forgot you already had that on your plate
[22:52:48] <grrrit-wm>	 (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (53f2410336) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119654 
[22:52:49] <rmoen>	 RoanKattouw: ok that should be good.  Looking at the clickable
[22:53:22] <grrrit-wm>	 (03CR) 10Krinkle: [C: 04-1] Display links to nonexistent pages as red (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 (owner: 10Catrope)
[22:53:46] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (53f2410336) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119654 (owner: 10Jforrester)
[22:54:42] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/119656
[22:55:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (53f2410336) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119654 (owner: 10Jforrester)
[22:57:22] <rmoen>	 RoanKattouw: Where do you suppose it would be best to register the non core commands?
[22:57:51] <RoanKattouw>	 We'd need to add a new file to VE-MW
[22:57:59] <RoanKattouw>	 Like ve.ui.MWCommandRegistry
[22:58:22] <grrrit-wm>	 (03PS1) 10Jforrester: Update VE core submodule to master (afbe6b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119657 
[23:01:35] <rmoen>	 RoanKattouw: ok that will work
[23:02:50] <rmoen>	 RoanKattouw: I can put them in that file but it seems i will still need to register them in ve.ui.commandRegistry, sound right ?
[23:03:18] <RoanKattouw>	 Yes
[23:03:23] <RoanKattouw>	 The code should be exactly the same
[23:03:28] <rmoen>	 RoanKattouw: otherwise, i'll have to change the riggings for commands themselves.  ok 
[23:03:34] <RoanKattouw>	 It just needs to be lifted out of that file verbatim and moved
[23:03:38] <rmoen>	 RoanKattouw: gotcha
[23:06:46] <grrrit-wm>	 (03PS12) 10Catrope: Display links to nonexistent pages as red [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118045 
[23:07:27] <RoanKattouw>	 Krinkle: Good catch. Grmbl. Just going back to duplicating that code in a closure for now. Eventually the link-specific part can move to a link-specific subclass and once that happens the circular dependency issue goes away
[23:12:22] <grrrit-wm>	 (03CR) 10Robmoen: "Patch incoming." (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[23:13:03] <grrrit-wm>	 (03PS15) 10Robmoen: Create mixin that tries to execute primary node command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 
[23:14:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Update VE core submodule to master (afbe6b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119657 (owner: 10Jforrester)
[23:16:14] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (afbe6b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119657 (owner: 10Jforrester)
[23:20:00] <rmoen>	 RoanKattouw: Is there a reason to have a command for MWAlienExtensionNode ?  what tool would it open ?
[23:20:13] <RoanKattouw>	 rmoen: There is an MWAlienExtensionInspector
[23:20:17] <RoanKattouw>	 This is a bit confusing
[23:20:22] <RoanKattouw>	 MWExtensionNode is an abstract class
[23:20:42] <RoanKattouw>	 MWAlienExtensionNode is a subclass of that which is what we use if we don't have another subclass (e.g. MWGalleryNode) that fits
[23:21:36] <rmoen>	 Oh i forgot about MWAlienExtensionInspector
[23:25:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Properly teardown TOC widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119655 (owner: 10Robmoen)
[23:26:06] <RoanKattouw>	 rmoen: I did too. I happen to have a <syntaxhighlight> tag on my Main Page and wasn't surprised when ClickableNode didn't work because the SyntaxHighlight code was fraught with problems, but then James pointed out he'd removed the SH code and this was actually an AlienExtensionNode
[23:26:56] * James_F  , schooling RoanKattouw in his own code since 2012…

[23:27:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Properly teardown TOC widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119655 (owner: 10Robmoen)
[23:28:51] <Krenair>	 James_F, been looking at the Cite changes
[23:28:58] <Krenair>	 ( https://bugzilla.wikimedia.org/show_bug.cgi?id=51260 )
[23:29:01] <James_F>	 Krenair: Oh, cool. Thoughts?
[23:29:17] <Krenair>	 No idea what I'm doing with RTL stuff.
[23:29:33] <James_F>	 Ah, there are RTL issues? (When aren't there? ;-))
[23:30:08] <Krenair>	 I have no idea. I honestly know nothing about RTL apart for the fact that some languages use it instead of LTR
[23:30:32] <James_F>	 Throw it in and trust that we'll do RTL checking in the code review if you're worried.
[23:30:40] <James_F>	 Roan is particularly good at that.
[23:30:57] <Krenair>	 You implied there was an existing issue with RTL support, I have no idea how it is related to this bug though
[23:31:07] <James_F>	 Oooooh.
[23:31:14] <James_F>	 Yes, there was a comment further up the bug.
[23:31:15] <grrrit-wm>	 (03PS15) 10Robmoen: Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 
[23:31:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:31:37] <James_F>	 Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=51260#c15
[23:32:11] <James_F>	 Krenair: It means that multi-columns in RTL is already broken, and if we're encouraging it we'll need to fix it first.
[23:32:11] <grrrit-wm>	 (03PS16) 10Robmoen: Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 
[23:32:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:32:24] <grrrit-wm>	 (03CR) 10Catrope: Follow redirects in the category widgets (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk)
[23:32:43] <rmoen>	 hmmm thought i rebased..
[23:34:55] <rmoen>	 RoanKattouw: help? I am stuck with a rebase conflict on lib/ve ;( 
[23:36:22] <Krenair>	 RoanKattouw, RE your comment: I did some horrible changes to attempt to fix the exactMatch issues you pointed out (see PS4..PS5)
[23:36:28] <RoanKattouw>	 rmoen: Sorry was in a meeting
[23:36:40] <RoanKattouw>	 rmoen: When in doubt, git add lib/ve and clean it up later
[23:36:41] <rmoen>	 RoanKattouw: no worries.
[23:37:11] <rmoen>	 before rebase if i do git status, it doesn't show lib/ve..  still add it though? 
[23:37:20] <RoanKattouw>	 Yes
[23:37:23] <rmoen>	 oh
[23:38:05] <RoanKattouw>	 Krenair: I may end up just merging that because the whole category suggestion thing has gotten out of control and needs cleanup anyways, and I might as well do that as part of integrating it with my new LinkCache thing
[23:38:24] <Krenair>	 It involves going back to check exactMatch after all the getMenuItemWidgetFromCategoryName (which handles searching for the redirects - and possible changing exactMatch based on this) calls are done, and inserting the right UI elements in
[23:38:27] <RoanKattouw>	 "do that" being "rewrite this whole category suggestion nightmare"
[23:38:48] <Krenair>	 I hate this change, so if you have a better idea...
[23:39:08] <rmoen>	 RoanKattouw: still failing, can you take a look at https://gerrit.wikimedia.org/r/#/c/103063/16 ? 
[23:40:54] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Show blockedtext message in edit notices (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119204 (owner: 10Alex Monk)
[23:41:11] <RoanKattouw>	 rmoen: I'll grab it and try to rebase it
[23:41:18] <Krenair>	 RoanKattouw, actually I think I do have a better way. will mark as -1
[23:41:28] <RoanKattouw>	 OK, cool
[23:41:28] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "think I've spotted a much nicer way of doing it" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk)
[23:42:28] <rmoen>	 RoanKattouw: ty
[23:44:35] <grrrit-wm>	 (03PS17) 10Catrope: Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:45:07] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:45:08] <RoanKattouw>	 rmoen: What might have happened is I merged something that caused yet another conflict while you were resolving the first one
[23:45:20] <RoanKattouw>	 Either way, it's resolved now
[23:45:50] <rmoen>	 ty
[23:46:25] <RoanKattouw>	 rmoen: Please undo your changes to MWExtensionNode / MWExtensionInspector
[23:46:27] <RoanKattouw>	 Those are abstract
[23:46:39] <RoanKattouw>	 So they shouldn't have names or primaryCommand and shouldn't be registered
[23:46:55] <RoanKattouw>	 MW*Alien*ExtensionNode/Inspector do need them
[23:47:02] <RoanKattouw>	 (Sorry, this structure is a bit confusing)
[23:47:02] <rmoen>	 Ok
[23:48:26] <RoanKattouw>	 rmoen: Once you get rid of that stuff I'll merge
[23:48:31] <RoanKattouw>	 So it'll make tomorrow's cut-off
[23:50:31] <grrrit-wm>	 (03PS18) 10Robmoen: Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 
[23:50:54] <rmoen>	 RoanKattouw: done
[23:50:59] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:52:11] <RoanKattouw>	 Thanks
[23:52:30] <rmoen>	 RoanKattouw: I guess MWExtensionNode doesn't need clickableNode mixed in either
[23:52:46] <rmoen>	 ?
[23:52:56] <RoanKattouw>	 No that is actually useful
[23:52:59] <RoanKattouw>	 Because then it gets inherited
[23:53:09] <RoanKattouw>	 And so all the others don't need to mix it in explicitly
[23:53:26] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Mixin ClickableNode and add primary command names (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:53:34] <RoanKattouw>	 OK, last thing I swear
[23:53:39] <RoanKattouw>	 There's a JS error when I load this code, see ---^^
[23:53:53] <rmoen>	 oh crap
[23:53:55] <rmoen>	 oops
[23:53:56] <rmoen>	 1 sec
[23:54:41] <grrrit-wm>	 (03PS19) 10Robmoen: Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 
[23:55:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Mixin ClickableNode and add primary command names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:57:14] <rmoen>	 RoanKattouw: sorry that should be it
[23:58:03] <RoanKattouw>	 Awesome