[00:00:02] jgonera: TrevorParscal wants me to point you to https://gerrit.wikimedia.org/r/#/c/119341/ and https://gerrit.wikimedia.org/r/#/c/119351/ [00:00:50] thanks James_F, what's "omnibus"? [00:02:57] jgonera: A file that does multiple things. [00:05:54] jgonera: We try to avoid monolithic files, especially ones that span multiple RL modules. :-) [00:08:00] I see, thanks [00:16:55] (03PS1) 10Esanders: Return null in Element#getDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/120969 [00:16:57] (03PS1) 10Esanders: Add Element#isElementAttached [oojs/ui] - 10https://gerrit.wikimedia.org/r/120970 [00:16:59] (03PS1) 10Esanders: Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 [00:17:23] (03CR) 10jenkins-bot: [V: 04-1] Add Element#isElementAttached [oojs/ui] - 10https://gerrit.wikimedia.org/r/120970 (owner: 10Esanders) [00:17:25] (03CR) 10jenkins-bot: [V: 04-1] Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 (owner: 10Esanders) [00:17:27] (03CR) 10jenkins-bot: [V: 04-1] Return null in Element#getDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/120969 (owner: 10Esanders) [00:33:05] (03PS2) 10Esanders: Return null in Element#getDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/120969 [00:33:07] (03PS2) 10Esanders: Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 [00:33:09] (03PS2) 10Esanders: Add Element#isElementAttached [oojs/ui] - 10https://gerrit.wikimedia.org/r/120970 [03:04:27] (03CR) 10Jforrester: [C: 031] Increase width of toggle switch widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119472 (owner: 10Esanders) [03:07:23] (03CR) 10Jforrester: [C: 031] "Happy to +2 if Željko is OK with it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120832 (owner: 10Cmcmahon) [03:10:26] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (1c7875205a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120984 [03:37:46] (03CR) 10Jforrester: [C: 04-2] "Breaks in MW core tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120984 (owner: 10Jforrester) [15:49:59] (03PS1) 10Cmcmahon: [browser test] Wait longer for save in multiedit workflow. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121092 [15:50:53] (03CR) 10Jforrester: [C: 032] [browser test] Wait longer for save in multiedit workflow. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121092 (owner: 10Cmcmahon) [15:52:41] (03CR) 10Cmcmahon: [C: 032] "increase wait timeout on save." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121092 (owner: 10Cmcmahon) [16:08:03] (03Merged) 10jenkins-bot: [browser test] Wait longer for save in multiedit workflow. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121092 (owner: 10Cmcmahon) [16:18:15] RoanKattouw: +547861, -712061 — https://gerrit.wikimedia.org/r/#/c/119658/ (!) [17:51:30] (03CR) 10Jforrester: [C: 031] "Now works fine." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120984 (owner: 10Jforrester) [17:54:34] (03Abandoned) 10Jforrester: Update OOjs UI to v0.1.0-pre (1c7875205a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120984 (owner: 10Jforrester) [17:55:10] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (1c7875205a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120717 (owner: 10JGonera) [17:56:34] (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (1c7875205a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120717 (owner: 10JGonera) [17:57:38] (03CR) 10Esanders: [C: 04-1] Refactor Scalable functionality (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [17:59:03] (03PS7) 10Jforrester: [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [17:59:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [18:03:11] (03PS2) 10Catrope: Protect against invalid/absent in ve.resolveUrl() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120835 [18:03:15] (03PS4) 10Catrope: Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 [18:08:26] Krinkle: Could you respond to Roan's CR on https://gerrit.wikimedia.org/r/#/c/119682/ ? [18:09:22] Checking [18:13:39] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (1c7875205a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120717 (owner: 10JGonera) [18:14:38] (03PS4) 10Esanders: Disable certains tools when surface loses focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [18:16:28] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (1c7875205a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120717 (owner: 10JGonera) [18:16:36] (03CR) 10jenkins-bot: [V: 04-1] Disable certains tools when surface loses focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [18:27:39] (03Abandoned) 10Catrope: [WIP] Citation tool and dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118768 (owner: 10Trevor Parscal) [18:33:32] (03PS10) 10Mooeypoo: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [18:41:30] Krinkle: https://gerrit.wikimedia.org/r/119914 [18:41:57] (03Abandoned) 10Krinkle: ToggleButtonWidget: Remove duplication in setValue [oojs/ui] - 10https://gerrit.wikimedia.org/r/119682 (owner: 10Krinkle) [18:42:00] (03CR) 10Catrope: [C: 032] Show blockedtext message in edit notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119204 (owner: 10Alex Monk) [18:44:24] James_F: So magically https://gerrit.wikimedia.org/r/#/c/120836/ is not anywhere on the dashboard ^^ [18:46:45] RoanKattouw: Aha. [18:46:57] RoanKattouw: Commit message matches the "browser…test" exclusion. [18:47:03] (03CR) 10Catrope: [C: 032] Blank the reference and media search queries when closing dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120566 (owner: 10Jforrester) [18:47:25] (03PS5) 10Jforrester: Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 (owner: 10Catrope) [18:48:55] (03PS5) 10Catrope: Disable certain tools when surface loses focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [18:49:55] (03CR) 10jenkins-bot: [V: 04-1] Disable certain tools when surface loses focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [18:55:32] (03CR) 10Krinkle: [C: 032] Hack around Parsoid's href prefixing in rendering new links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119914 (owner: 10Catrope) [18:58:39] (03CR) 10Krinkle: [C: 032] Add for relative URLs in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120834 (owner: 10Catrope) [18:59:37] (03Merged) 10jenkins-bot: Add for relative URLs in tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120834 (owner: 10Catrope) [19:06:23] (03CR) 10Krinkle: [C: 04-1] "per RL convo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120835 (owner: 10Catrope) [19:24:31] Hello, is there a way to use VisualEditor to insert parser functions? Does that need to be done with wikitext? [19:26:31] jolit: you could probably pretend it's a template named "#if: " or something, i don't think it checks that you're actually trying to insert a template [19:26:38] or at least it used not to [19:26:59] VE is not really intended for this kind of usage, so it's very low priority (if at all on the roadmap) [19:27:54] I tried that before, and it resulted in a javascript error "Unable to parse title" [19:28:48] As a workaround, I have had success using a template to generate the parser function call. I guess I'll stick with that. [19:34:45] It seems that it accepts non-existent template names, but not invalid ones, so parser functions following the form {{#foo:}} don't work. Thanks for confirming that it's unsupported. [20:06:54] Krinkle: WTF is going on at https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default , things you +2ed before lunch haven't been processed by Jenkins yet [20:07:32] RoanKattouw_away: Apparently there is a -qunit job somewhere clogging the queue, see https://integration.wikimedia.org/zuul/ [20:08:07] and though 'test' pipeline jobs run independent, we 'optimise' gate-and-submit jobs in sequence instead of parallel. [20:18:27] (03CR) 10Catrope: [C: 032] Fix copyright year range for fourteen files not updated to 2011-2014 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120741 (owner: 10Jforrester) [20:19:16] RoanKattouw_away: Just let it breath for now (don't rebase or re-submit the ones arlready +2'ed) [20:19:24] Feel free to add more, but don't break it, it's queued. [20:19:32] Something was clogged, fixed now, gonna take a few to catch up [20:20:56] (03CR) 10Catrope: [C: 032] Block non-JSON API access to VisualEditor, as it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 (owner: 10Jforrester) [20:22:57] (03CR) 10Catrope: [C: 032] Switch Beta Features hook to use new ltr/rtl screenshot style [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120254 (owner: 10Jforrester) [20:26:26] (03CR) 10Catrope: [C: 032] Fix copyright year range for one file not updated to 2011-2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120740 (owner: 10Jforrester) [20:27:29] (03Merged) 10jenkins-bot: Fix copyright year range for one file not updated to 2011-2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120740 (owner: 10Jforrester) [20:31:47] Krinkle: https://gerrit.wikimedia.org/r/121146 [20:44:04] Krinkle: OK I'm not touching it [20:44:27] (03PS6) 10Catrope: Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 [20:44:29] (03PS3) 10Catrope: Protect against invalid/absent in ve.resolveUrl() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120835 [20:44:31] (03PS1) 10Catrope: Add a to every test document by default [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121230 [20:45:22] Krinkle: ---^^ I addressed the CR on the invalid/absent base thing but as part of that I also redid the commit underneath it. Except that it had already been merged, so I re-redid it [20:48:01] (03CR) 10Krinkle: [C: 031] Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 (owner: 10Catrope) [20:48:57] (03CR) 10Krinkle: [C: 031] Protect against invalid/absent in ve.resolveUrl() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120835 (owner: 10Catrope) [20:49:51] (03PS1) 10Alex Monk: Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 [20:51:58] RoanKattouw_away, TrevorParscal: Why does autoEllipsis use highlightText? Is this a feature we want to document or is it something we can kill? [20:53:14] Oh, Krinkle explained partly [20:59:57] RoanKattouw_away: maybe we can hack on real time collab when i'm in SFO may 10-17? [21:00:11] cscott: Yes let's [21:00:22] I will be out Tues & Thurs [21:00:31] But other than that go bonkers with my calendar [21:00:44] it looks like i might be in SFO may 10-26 (two weeks) so we should have plenty of time [21:00:55] Awesome [21:01:02] I am going to Zurich May 8-12 I think? [21:01:06] marktraceur: how does it use it? [21:01:29] i'm not going to zurich, but i'm coming to SFO right after people get back from zurich. [21:01:37] marktraceur: and what do you mean by highlightText? [21:01:44] Oh OK [21:01:46] TrevorParscal: Apparently to highlight search results; never mind, ignore me [21:01:55] I think you might be arriving while we're in Zurich [21:02:02] (my wife works at google and has a google team meeting in MTV, so i'm tagging along and we're making it a big west coast family trip) [21:02:08] oh, it's probably something to do with simplesearch [21:02:12] Oh nice [21:02:25] cscott: That ain't workin', that's the way you do it, you work for Google down in MTV... [21:03:33] ♫♪𝅗𝅥♫ [21:04:37] cscott: Money for coders and transit for free [21:04:44] No wait [21:04:48] Trix for free [21:06:03] (03PS2) 10Catrope: Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 (owner: 10Alex Monk) [21:06:55] RoanKattouw, it's been changed quite a bit from the EditPage/Article version [21:07:03] Hmm OK [21:07:05] But yes it did start off as a copy :/ [21:07:09] I guess at least the logic is copied from there? [21:07:26] (03PS3) 10Catrope: Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 (owner: 10Alex Monk) [21:08:23] (03CR) 10jenkins-bot: [V: 04-1] Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 (owner: 10Alex Monk) [21:08:54] ?!? [21:09:09] (03PS4) 10Alex Monk: Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 [21:09:17] How did that magically fail to merge? [21:09:18] Well, that seems to work. [21:09:21] I don't know. [21:09:58] WEird [21:10:05] Well Jenkins has done weirder things today [21:12:29] (03CR) 10jenkins-bot: [V: 04-1] Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 (owner: 10Alex Monk) [21:12:59] sigh. Line exceeds 100 characters; contains 116 characters [21:13:02] at least it could merge it this time [21:16:02] (03PS5) 10Alex Monk: Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 [21:19:19] Krenair: During testing I found https://bugzilla.wikimedia.org/show_bug.cgi?id=63146 [21:19:27] Also, a fatal error [21:20:17] (03PS6) 10Catrope: Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 (owner: 10Alex Monk) [21:21:20] Oh I put that $targetUser->getUserPage() in the wrong place [21:21:20] sorry [21:23:40] (03CR) 10Catrope: [C: 032] Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 (owner: 10Alex Monk) [21:24:03] Krenair: There's another bug there actually: if the API fatals with a 500, we just say "error" [21:24:09] Filing a bug to improve that too [21:28:44] (03Merged) 10jenkins-bot: Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121232 (owner: 10Alex Monk) [21:39:21] (03PS1) 10Alex Monk: Update use of newarticletext for added parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121251 [21:47:37] (03CR) 10Krinkle: [C: 032] Block non-JSON API access to VisualEditor, as it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 (owner: 10Jforrester) [21:48:01] (03CR) 10Krinkle: [C: 032] Blank the reference and media search queries when closing dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120566 (owner: 10Jforrester) [21:49:04] (03Merged) 10jenkins-bot: Block non-JSON API access to VisualEditor, as it won't work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119912 (owner: 10Jforrester) [21:49:37] (03Merged) 10jenkins-bot: Blank the reference and media search queries when closing dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120566 (owner: 10Jforrester) [21:54:21] (03CR) 10Esanders: [C: 04-1] "not you but you touched the line" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 (owner: 10Catrope) [21:57:55] (03CR) 10Catrope: [C: 032] Update use of newarticletext for added parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121251 (owner: 10Alex Monk) [21:59:04] RoanKattouw, looks like we should get rid of $wgVisualEditorEditNotices... [22:00:09] (03CR) 10Trevor Parscal: [C: 032] Increase width of toggle switch widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119472 (owner: 10Esanders) [22:00:46] (03Merged) 10jenkins-bot: Update use of newarticletext for added parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121251 (owner: 10Alex Monk) [22:01:16] (03Merged) 10jenkins-bot: Increase width of toggle switch widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119472 (owner: 10Esanders) [22:02:38] (03PS7) 10Catrope: Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 [22:03:45] (03CR) 10Trevor Parscal: Disable tool groups when all its tools are disabled (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 (owner: 10Esanders) [22:04:06] (03CR) 10Trevor Parscal: [C: 032] Add Element#isElementAttached [oojs/ui] - 10https://gerrit.wikimedia.org/r/120970 (owner: 10Esanders) [22:04:38] (03PS3) 10Esanders: Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 [22:06:25] RoanKattouw, wonder why it is a global... I can't find any use of it anywhere [22:07:17] TrevorParscal, This is for you: https://bugzilla.wikimedia.org/show_bug.cgi?id=63132 [22:07:53] It is occurring in Betalabs only, not on test2 [22:08:36] (03PS1) 10Esanders: Use less variable for travel distance [oojs/ui] - 10https://gerrit.wikimedia.org/r/121260 [22:12:16] (03PS3) 10Esanders: Promote zIndex of InlineMenuWidget options list [oojs/ui] - 10https://gerrit.wikimedia.org/r/119492 [22:12:18] (03PS4) 10Esanders: Add disabled styling to InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119491 [22:13:51] Krenair: FlaggedRevs? [22:15:28] (03PS1) 10Catrope: Fix padding on icon in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121261 [22:16:01] TrevorParscal: Review me: https://gerrit.wikimedia.org/r/121261 [22:16:13] (03CR) 10Trevor Parscal: [C: 032] Promote zIndex of InlineMenuWidget options list [oojs/ui] - 10https://gerrit.wikimedia.org/r/119492 (owner: 10Esanders) [22:16:48] RoanKattouw, can't find any use of it there... Why would FR need to put in a special edit notice for VE only anyway? FR just uses the normal MediaWiki mechanism for edit notices (TitleGetEditNotices hook, which we run with $page->getEditNotices()) [22:17:08] (03CR) 10Trevor Parscal: [C: 032] Fix padding on icon in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121261 (owner: 10Catrope) [22:17:30] (03Merged) 10jenkins-bot: Fix padding on icon in TextInputWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121261 (owner: 10Catrope) [22:18:06] I don't know [22:18:10] I don't remember what it was used for [22:18:16] Let me see if it's in mediawik-config maybe? [22:18:32] (03CR) 10Trevor Parscal: [C: 032] Add disabled styling to InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119491 (owner: 10Esanders) [22:18:52] (03Merged) 10jenkins-bot: Add disabled styling to InlineMenuWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/119491 (owner: 10Esanders) [22:18:54] (03Merged) 10jenkins-bot: Promote zIndex of InlineMenuWidget options list [oojs/ui] - 10https://gerrit.wikimedia.org/r/119492 (owner: 10Esanders) [22:19:16] (03CR) 10Trevor Parscal: [C: 032] Use less variable for travel distance [oojs/ui] - 10https://gerrit.wikimedia.org/r/121260 (owner: 10Esanders) [22:19:19] Krenair: Weird, I can find absolutely nothing that uses it, you're right [22:19:32] Krenair: Feel free to put in a commit to kill it, but I won't merge it until after tomorrow's deployment train [22:19:34] yeah, I already checked mediawiki-config [22:19:37] (03Merged) 10jenkins-bot: Use less variable for travel distance [oojs/ui] - 10https://gerrit.wikimedia.org/r/121260 (owner: 10Esanders) [22:19:40] Okay [22:20:22] (03CR) 10Trevor Parscal: [C: 032] Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 (owner: 10Esanders) [22:21:55] edsanders: https://gerrit.wikimedia.org/r/#/c/119471/ [22:23:30] Krinkle: *cough* https://gerrit.wikimedia.org/r/#/c/120835 https://gerrit.wikimedia.org/r/#/c/120836 *cough* [22:24:04] (03CR) 10Krinkle: [C: 032] Add a to every test document by default [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121230 (owner: 10Catrope) [22:24:47] RoanKattouw: One of https://gerrit.wikimedia.org/r/#/c/119706/ and https://gerrit.wikimedia.org/r/#/c/119644/ [22:25:00] (03Merged) 10jenkins-bot: Add a to every test document by default [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121230 (owner: 10Catrope) [22:25:09] Reviewing the rest of that stack now [22:25:36] (03PS1) 10Alex Monk: Kill $wgVisualEditorEditNotices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121263 [22:27:27] (03CR) 10Catrope: "Do not merge until Thursday afternoon" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121263 (owner: 10Alex Monk) [22:28:17] Krinkle: Dude https://gerrit.wikimedia.org/r/#/c/119706 is awesome! [22:31:57] (03CR) 10Krinkle: [C: 032] Protect against invalid/absent in ve.resolveUrl() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120835 (owner: 10Catrope) [22:32:06] RoanKattouw: :) [22:32:27] RoanKattouw: btw, the commit message reveals why I spent an hour last week trying to get my working patch to work. [22:32:42] wgInvalidateCacheOnLocalSettingsChange = true; [22:32:43] (03PS1) 10Catrope: Bring CommandHelpDialog CSS back [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121264 [22:32:50] so every time I changed some random wg var, it worked [22:32:53] regardless of my patch [22:33:09] Took me a while to figure out why however my patch was still very much needed [22:33:16] haha yeah [22:33:28] because locally I just have a plain LocalSettings.php [22:33:31] :) [22:33:39] and wgCacheEpoch is uber used in RL [22:34:20] Yeah [22:34:26] And the epoch is tied to LocalSettings.php [22:34:26] (03Merged) 10jenkins-bot: Protect against invalid/absent in ve.resolveUrl() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120835 (owner: 10Catrope) [22:34:41] We kind of may have accidentally enabled that setting in production once [22:34:44] Oops? :) [22:34:51] (03CR) 10Jforrester: [C: 032] Bring CommandHelpDialog CSS back [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121264 (owner: 10Catrope) [22:35:03] Wouldn't do a whole lot since our LocalSettings.php doesn't change much. [22:35:09] Although we do re-create it each wmf branch [22:35:30] so cache that is supposed to stay acrross versions within a wiki would purge like crazy [22:35:39] oh and we do have a fair amount of those kind of caches :P [22:39:45] (03Merged) 10jenkins-bot: Bring CommandHelpDialog CSS back [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121264 (owner: 10Catrope) [22:40:16] Krinkle: Ahm, well, it does something once [22:40:22] It moves $wgCacheEpoch forward by like a decade [22:40:45] (03PS1) 10Trevor Parscal: Make cite transclusion tools actually work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121266 [22:40:55] RoanKattouw: And (depending on how long it stays) it would purge all cache each wmf branch creation (which is when php-*/LocalSettings.php is created again with a fresh touch time) [22:41:17] eventhough it'll have the same contents [22:41:36] (03PS8) 10Krinkle: Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 (owner: 10Catrope) [22:42:05] (03PS2) 10Catrope: Make cite transclusion tools actually work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121266 (owner: 10Trevor Parscal) [22:42:31] (03PS3) 10Catrope: Make cite transclusion tools actually work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121266 (owner: 10Trevor Parscal) [22:42:55] Krinkle: Yeah exactly [22:43:09] But the impact of moving it from like 2005ish to 2011 was pretty immediate [22:45:36] yeah, no shit [22:47:31] (03CR) 10Catrope: [C: 032] Make cite transclusion tools actually work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121266 (owner: 10Trevor Parscal) [22:48:07] * RoanKattouw wonders whether https://gerrit.wikimedia.org/r/#/c/119914/ will ever be merged by Jenkins [22:48:39] Krinkle: There's a bunch of stuff not in the Zuul queue that's +2ed and unmerged, should I re+2 those? [22:48:55] (03Merged) 10jenkins-bot: Make cite transclusion tools actually work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121266 (owner: 10Trevor Parscal) [22:52:45] (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120254 (owner: 10Jforrester) [22:52:53] (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120741 (owner: 10Jforrester) [22:53:43] (03CR) 10Jforrester: [C: 032] "Per Timo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119914 (owner: 10Catrope) [22:54:34] (03Merged) 10jenkins-bot: Switch Beta Features hook to use new ltr/rtl screenshot style [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120254 (owner: 10Jforrester) [22:55:09] (03Merged) 10jenkins-bot: Fix copyright year range for fourteen files not updated to 2011-2014 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120741 (owner: 10Jforrester) [22:56:03] (03Merged) 10jenkins-bot: Hack around Parsoid's href prefixing in rendering new links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119914 (owner: 10Catrope) [22:59:10] mooeypoo: http://www.amazon.com/dp/B009FU2AYU [23:00:49] (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119204 (owner: 10Alex Monk) [23:02:26] (03Merged) 10jenkins-bot: Show blockedtext message in edit notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119204 (owner: 10Alex Monk) [23:04:06] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/120685/ https://gerrit.wikimedia.org/r/#/c/120340/ [23:06:01] (03PS2) 10Trevor Parscal: Add display: block; property to labelElement to make the text-overflow: ellipsis work correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/120340 (owner: 10Fantasticfears) [23:09:15] (03CR) 10Trevor Parscal: [C: 032] Fixes bug where InlineMenuWidget would "steal" DOM labels on selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/120685 (owner: 10Gilles) [23:09:37] (03Merged) 10jenkins-bot: Fixes bug where InlineMenuWidget would "steal" DOM labels on selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/120685 (owner: 10Gilles) [23:10:19] (03CR) 10Trevor Parscal: [C: 032] Add display: block; property to labelElement to make the text-overflow: ellipsis work correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/120340 (owner: 10Fantasticfears) [23:10:42] (03Merged) 10jenkins-bot: Add display: block; property to labelElement to make the text-overflow: ellipsis work correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/120340 (owner: 10Fantasticfears) [23:17:28] (03CR) 10Krinkle: [C: 032] Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 (owner: 10Catrope) [23:19:11] (03Merged) 10jenkins-bot: Use DOMParser in ve.createDocumentFromHtml() if available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/120836 (owner: 10Catrope) [23:25:48] Krinkle: https://code.google.com/p/chromium/issues/detail?id=314291 [23:27:37] Krinkle: https://code.google.com/p/chromium/issues/list?can=1&q=reporter%3Arkattouw%40wikimedia.org+OR+reporter%3Aroan%40wikimedia.org+OR+reporter%3Aroan.kattouw%40gmail.com&colspec=ID+Pri+M+Iteration+ReleaseBlock+Cr+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=tiles [23:33:22] (03PS1) 10Catrope: Don't use transitions for opacity on hover for now [oojs/ui] - 10https://gerrit.wikimedia.org/r/121279 [23:38:32] (03CR) 10Trevor Parscal: [C: 032] Don't use transitions for opacity on hover for now [oojs/ui] - 10https://gerrit.wikimedia.org/r/121279 (owner: 10Catrope) [23:38:53] (03Merged) 10jenkins-bot: Don't use transitions for opacity on hover for now [oojs/ui] - 10https://gerrit.wikimedia.org/r/121279 (owner: 10Catrope) [23:54:24] (03PS1) 10Trevor Parscal: Filter calls to selectItem and highlightItem on SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121281