[00:14:57] (03PS1) 10Catrope: [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 [00:15:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [00:59:04] (03PS9) 10Esanders: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [00:59:06] (03PS4) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121534 [03:28:05] (03PS3) 10Esanders: Return null in Element#getDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/120969 [03:28:07] (03PS4) 10Esanders: Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 [03:28:09] (03PS3) 10Esanders: Add Element#isElementAttached [oojs/ui] - 10https://gerrit.wikimedia.org/r/120970 [06:47:25] (03PS1) 10Vikassy: [browser test] Testing existing reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 [06:55:25] (03PS2) 10Vikassy: [browser test] Testing existing reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 [06:56:34] (03PS3) 10Vikassy: [browser test] Testing existing reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 [07:38:15] I feel lost. I couldn't find a way how to enable support for standalone version. [07:48:25] (03PS4) 10Vikassy: [browser test] Testing existing reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 [08:16:54] (03PS5) 10Vikassy: [browser test] Testing use of existing reference in Reference User Interface. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 [14:42:04] hi VE wizards, please scream when you read this? :) [15:32:57] hi, James_F. [15:45:15] Hey. [15:45:35] Elitre: You wanted to hear from us? [15:56:31] I did. I'll paste a couple of diffs. [15:59:54] James_F: at the French wp, diffs like this https://fr.wikipedia.org/w/index.php?title=Le_Concert_de_l%27Hostel_Dieu&curid=4767714&diff=102434225&oldid=99541547 are being reported. single or multiple inserting of random characters at the beginning of the article. I couldn't reproduce but it doesn't look intentional to me. [16:00:43] edsanders: See you soon. Moriel and I are here waiting for you. :-) [16:01:06] Elitre: Huh. That's very odd. Are they using the same browser/browser plug-in? [16:04:13] James, most of them are IPs, so we can't ask, and the other are newbies - unlikely to get answers that make sense from them, although we can always try. [16:04:43] * James_F nods. [16:05:54] James_F: someone says it has to do with 47790 being fixed. https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis#Mais_qu.27est-ce_donc_encore... [16:06:19] Elitre: That seems very unlikely. [16:08:12] James_F: for it.wp instead, https://it.wikipedia.org/w/index.php?title=Respirazione_olotropica&curid=856162&diff=65014587&oldid=64980151 showed up recently, and I filed a bug for that today. [16:09:19] Elitre: Yeah, that's not good. [16:09:51] wondering why it only shows up at it.wp (among my wikis, I mean). [16:10:03] Same user each time? [16:10:43] apparently not, although I'd need a checkuser to know for sure. [16:11:02] * James_F nods. [16:42:43] (03PS2) 10Catrope: [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 [16:43:56] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [16:46:12] (03PS3) 10Catrope: [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 [16:47:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [16:47:34] (03CR) 10Catrope: [C: 04-1] "Judging from the test failure, it seems like changes to VisualEditor.php are needed" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [16:49:42] (03CR) 10Catrope: "Sorry, misdiagnosed. All that's going on is that https://gerrit.wikimedia.org/r/#/c/121537/ needs to merge first." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [16:55:55] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5a86ff9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [16:57:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (5a86ff9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121538 (owner: 10Jforrester) [18:02:08] (03CR) 10Krinkle: [C: 032] Return null in Element#getDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/120969 (owner: 10Esanders) [18:02:33] (03Merged) 10jenkins-bot: Return null in Element#getDocument [oojs/ui] - 10https://gerrit.wikimedia.org/r/120969 (owner: 10Esanders) [18:39:51] (03CR) 10Jforrester: [C: 032] Add Element#isElementAttached [oojs/ui] - 10https://gerrit.wikimedia.org/r/120970 (owner: 10Esanders) [18:40:14] (03Merged) 10jenkins-bot: Add Element#isElementAttached [oojs/ui] - 10https://gerrit.wikimedia.org/r/120970 (owner: 10Esanders) [18:48:47] edsanders: Seen Timo's comments on https://gerrit.wikimedia.org/r/#/c/120971/3/src/ToolGroup.js ? [18:56:16] (03PS1) 10Trevor Parscal: Rename CSS file to relate to actual style names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121711 [18:57:06] (03CR) 10Jforrester: [C: 032] Rename CSS file to relate to actual style names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121711 (owner: 10Trevor Parscal) [18:57:10] (03CR) 10Catrope: [C: 032] Rename CSS file to relate to actual style names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121711 (owner: 10Trevor Parscal) [18:58:54] (03Merged) 10jenkins-bot: Rename CSS file to relate to actual style names [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121711 (owner: 10Trevor Parscal) [19:04:11] (03PS5) 10Esanders: Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 [19:04:45] (03CR) 10Divec: [C: 04-1 V: 04-1] [WIP^n] getOffset rewrite (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [19:05:39] (03PS6) 10Esanders: Disable tool groups when all its tools are disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/120971 [19:09:11] (03CR) 10Catrope: [WIP^n] getOffset rewrite (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [19:12:59] (03PS1) 10Trevor Parscal: Split-up theme-specific styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121713 [19:13:14] (03PS1) 10Trevor Parscal: Split-up theme-specific styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121714 [19:14:46] (03CR) 10jenkins-bot: [V: 04-1] Split-up theme-specific styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121713 (owner: 10Trevor Parscal) [19:17:07] (03PS2) 10Jforrester: Split-up theme-specific styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121714 (owner: 10Trevor Parscal) [19:17:54] (03CR) 10Jforrester: [C: 032] Split-up theme-specific styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121714 (owner: 10Trevor Parscal) [19:18:55] (03Merged) 10jenkins-bot: Split-up theme-specific styles [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121714 (owner: 10Trevor Parscal) [19:20:52] (03PS2) 10Jforrester: Update VE core submodule to master (e972bb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121713 (owner: 10Trevor Parscal) [19:22:06] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (e972bb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121713 (owner: 10Trevor Parscal) [19:32:22] (03PS1) 10Esanders: Watch less files instead of css files [oojs/ui] - 10https://gerrit.wikimedia.org/r/121796 [19:35:23] Krinkle|detached, ^^ [19:48:26] (03CR) 10Divec: [C: 031] Filter calls to selectItem and highlightItem on SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121281 (owner: 10Trevor Parscal) [19:52:16] (03CR) 10Divec: [WIP^n] getOffset rewrite (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [19:56:26] (03PS3) 10Catrope: Update VE core submodule to master (e972bb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121713 (owner: 10Trevor Parscal) [19:58:07] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (e972bb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121713 (owner: 10Trevor Parscal) [20:06:21] I looked into that edit conflict issue some more [20:07:05] Swapping the values of baseTimeStamp and startTimeStamp stops any conflict from being detected :/ [20:07:12] (03PS2) 10Esanders: Grunt-watch less files [oojs/ui] - 10https://gerrit.wikimedia.org/r/121796 [20:07:40] (03CR) 10Krinkle: [C: 032] Grunt-watch less files [oojs/ui] - 10https://gerrit.wikimedia.org/r/121796 (owner: 10Esanders) [20:08:06] (03Merged) 10jenkins-bot: Grunt-watch less files [oojs/ui] - 10https://gerrit.wikimedia.org/r/121796 (owner: 10Esanders) [20:08:06] Krenair: Yeah, MW's timestamps are Broken By Design™ :-( [20:08:14] Krenair: RoanKattouw_away is our expert… [20:08:33] Yeah the whole timestamp thing is scary [20:08:38] What are you looking into exactly? [20:09:55] ( Krenair ---^^ ) [20:10:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=56835 RoanKattouw [20:10:21] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=56835#c6 [20:10:26] * James_F grins. [20:11:36] RoanKattouw: So, I told TrevorParscal yesterday, not sure you heard... mw.loader implements Promise now [20:13:45] (03Merged) 10jenkins-bot: Update VE core submodule to master (e972bb7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121713 (owner: 10Trevor Parscal) [20:15:18] Krinkle: I saw a commit summary, not more than that [20:16:33] Krenair: OK so those two wp* things are probably backwards [20:16:55] Is the oldid parameter passed correctly? That's what caused this bug last time [20:17:06] I don't understand yet how it's always flagging a conflcit [20:17:13] RoanKattouw: I'd like your eye on https://gerrit.wikimedia.org/r/#/c/72534/ I'm happy to review myself (It's Hoo man's patch) but I changed it a fair bit and would like a double check on the logic. [20:17:51] RoanKattouw, it's always flagging a conflict due to the wp* things being the wrong way around, I think [20:18:20] This gets suppressed for logged in users due to the way Revision::userWasLastToEdit works [20:18:23] Right [20:35:06] (03PS3) 10Jforrester: Introduce ve.ui.Tool and make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [20:35:24] (03PS3) 10Jforrester: Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [20:36:04] (03CR) 10jenkins-bot: [V: 04-1] Introduce ve.ui.Tool and make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [20:36:21] (03CR) 10jenkins-bot: [V: 04-1] Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [20:46:25] (03PS1) 10Krinkle: build: Update grunt-recess from v0.5.0 to v0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/121847 [20:47:02] (03CR) 10Krinkle: "Kudos for https://david-dm.org/wikimedia/oojs-ui#info=devDependencies" [oojs/ui] - 10https://gerrit.wikimedia.org/r/121847 (owner: 10Krinkle) [20:49:43] (03CR) 10Catrope: [C: 032] build: Update grunt-recess from v0.5.0 to v0.6.1 [oojs/ui] - 10https://gerrit.wikimedia.org/r/121847 (owner: 10Krinkle) [20:50:04] (03CR) 10Krinkle: "Sorry, made up my mind. Hold on a few minutes." [oojs/ui] - 10https://gerrit.wikimedia.org/r/121847 (owner: 10Krinkle) [20:56:23] (03PS2) 10Divec: DO NOT MERGE: Annotation tests proof of concept. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121284 [20:57:11] (03PS2) 10Krinkle: build: Update devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/121847 [20:57:13] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE: Annotation tests proof of concept. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121284 (owner: 10Divec) [20:57:15] (03CR) 10Esanders: [WIP^n] getOffset rewrite (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [20:58:53] (03PS3) 10Krinkle: build: Update devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/121847 [20:59:00] (03CR) 10Krinkle: [C: 031] build: Update devDependencies [oojs/ui] - 10https://gerrit.wikimedia.org/r/121847 (owner: 10Krinkle) [21:40:14] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/121873 [21:45:06] (03PS2) 10Jforrester: Migrate to JSON i18n [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/121873 (owner: 10Siebrand) [21:45:30] (03CR) 10Jforrester: [C: 032] Migrate to JSON i18n [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/121873 (owner: 10Siebrand) [21:47:19] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/121873 (owner: 10Siebrand) [21:51:57] (03CR) 10Esanders: [C: 032] Filter calls to selectItem and highlightItem on SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121281 (owner: 10Trevor Parscal) [21:52:20] (03Merged) 10jenkins-bot: Filter calls to selectItem and highlightItem on SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/121281 (owner: 10Trevor Parscal) [21:57:37] (03CR) 10Esanders: "Did somebody say ve.ui.Tool? Ia44b093ed89f8a97" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [22:12:45] (03PS10) 10Esanders: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [22:12:47] (03PS5) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121534 [22:12:49] (03PS1) 10Esanders: Introduce ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121878 [22:13:43] (03CR) 10jenkins-bot: [V: 04-1] Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [22:19:46] (03PS6) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [22:21:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [22:21:53] (03PS11) 10Mooeypoo: [WIP] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [22:23:06] (03PS2) 10Esanders: Introduce ve.ui.Tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121878 [22:23:08] (03PS11) 10Esanders: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [22:23:10] (03PS6) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121534 [22:24:05] (03CR) 10jenkins-bot: [V: 04-1] Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [22:26:58] (03PS4) 10Esanders: Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [22:27:30] (03CR) 10jenkins-bot: [V: 04-1] Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [22:42:10] (03PS12) 10Esanders: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 [22:43:18] rmoen: ey [22:43:51] (03CR) 10jenkins-bot: [V: 04-1] Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [22:44:12] InezK: Oi [22:45:04] InezK: Going home for the weekend. I'll be back Sunday night. [22:46:35] (03CR) 10Inez: Disable certain tools when surface has no range (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [23:28:40] (03PS10) 10JGonera: Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 [23:29:20] (03CR) 10jenkins-bot: [V: 04-1] Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 (owner: 10JGonera) [23:30:05] (03PS11) 10JGonera: Style link inspector on mobile [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119413 [23:34:13] (03Abandoned) 10JGonera: [WIP] Limit some styles to desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/119414 (owner: 10JGonera) [23:56:07] (03PS1) 10Jforrester: Bump media search result size to 20 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121898 [23:56:42] TrevorParscal: https://gerrit.wikimedia.org/r/121898