[11:51:37] (03CR) 10Zfilipin: "Is somebody working on this WIP commit, or should we abandon it?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108987 (owner: 10Jhall) [11:52:09] (03CR) 10Zfilipin: "Is somebody working on this WIP commit, or should we abandon it?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110659 (owner: 10Jhall) [11:53:46] (03CR) 10Zfilipin: "Is somebody working on this WIP commit, or should we abandon it?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115510 (owner: 10Jhall) [13:20:20] (03PS1) 10Jagori79: WIP: Visual Editor adding long Target Links Bug: 63104 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [13:21:09] (03PS2) 10Jagori79: WIP: Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [13:40:20] (03CR) 10Zfilipin: [C: 04-1] WIP: Visual Editor adding long Target Links (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [14:09:47] (03CR) 10Gilles: "https://bugzilla.wikimedia.org/show_bug.cgi?id=63303" [oojs/core] - 10https://gerrit.wikimedia.org/r/112148 (owner: 10Krinkle) [15:21:34] (03Abandoned) 10Jforrester: [Browser test] WIP New test(s) for editing with VisualEditor via mobile user interface. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/108987 (owner: 10Jhall) [15:22:07] (03Abandoned) 10Jforrester: [Browser test] WIP Additional Scenario for bug 59091 regression. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115510 (owner: 10Jhall) [15:22:26] (03Abandoned) 10Jforrester: [Browser test] WIP New test for VE Page Settings menu. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110659 (owner: 10Jhall) [16:02:45] Hello, is there a known bug with these letters added at the top of articles https://fr.wikipedia.org/w/index.php?title=Jean-Marc%20Ayrault&diff=102519420&oldid=102518983&unhide=1 https://fr.wikipedia.org/w/index.php?title=Fish_Tank&diff=102518620&oldid=100127556 ? [16:09:49] Frakir: Hey, yes, it was suggested that people are just typing badly – no-one has given details of how to reproduce it as a bug. [16:10:23] Ok [16:10:49] Frakir: Without more details there's not really anything we can do. :-( [16:11:19] it is very strange [16:22:19] Yes. [16:49:15] (03PS3) 10Catrope: WIP: [Browser test] Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [17:24:21] James_F: It was really difficult to understand everything people were saying today. :/ [17:24:40] Krenair: Sorry. :-( Was it better from me and David when we were standing up? [17:25:47] I heard that there are some birthdays today#@$ [17:26:02] That's right! [17:27:00] :-) [17:27:04] James_F, I think it was a bit.. [17:27:08] yeah, happy birthday :) [17:27:18] Krenair: OK, will shout at people to stand in future. [17:27:19] Thanks. :-) [17:27:28] Happy birthday, fellas [17:27:46] James_F, https://gerrit.wikimedia.org/r/#/c/120962/ is up for review now. Looking through your list on the bug: [17:27:53] * Not sure about RTL stuff [17:28:32] * defaults of the new attributes -> I think that can be considered separately from this patch [17:30:00] * list-style is limited to a list of possible list-style-type values. It's also case-sensitive with this check which might not be wanted [17:30:26] * James_F nods [17:30:55] * I have made local changes to VE and Parsoid to deal with these new attributes. The Parsoid changes are the bare minimum I've needed to get the VE side working. Might be more to do here, should probably talk to Gabriel about that [17:31:09] Yeah. [17:31:13] Hey BladeBronson. [17:34:09] James_F, I think that we need to make sure the VE commit gets deployed at the same time as the commit to Cite [17:34:42] Krenair: Yes, though that's not too hard if RoanKattouw is the merger of both. :-) [17:34:58] yeah :) [17:42:34] James_F, for actually selecting a list style type in the UI I need to add a localised dropdown I think [17:43:16] My current version relies on the user knowing the possible values, which of course are all CSS values so in english [17:48:03] Krenair: *nods* [17:48:05] TrevorP|Away, http://madebymany.github.io/sir-trevor-js/ :) [18:01:03] edsanders|away: Fixme: https://gerrit.wikimedia.org/r/#/c/107142/ [18:05:09] (03PS3) 10Esanders: WIP Fix deletion inside a structural node at start/end of document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/107142 [18:08:45] (03CR) 10Trevor Parscal: Disable certain tools when surface has no range (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [18:15:58] (03PS1) 10Esanders: Show VE demo error in VE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122443 [18:27:43] subbu: great name, crap product :( [18:28:30] TrevorParscal, sure .. it was the name which prompted me to share it :) [18:28:55] >>> ( new Array( 200 ) ).join( '.' ) [18:28:57] ... [18:29:08] I was hoping it would be awesome, it's very similar to many of my ideas and designs and it has my name on it [18:29:11] ty ecmabot-wm [18:29:43] Krinkle: I killed yer bot [18:29:57] With, AFAICT, valid ES. [18:30:03] marktraceur: Tsk. :-) [18:32:57] (03PS1) 10Esanders: Actually use getRelative[Content|Structural]Offset wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122451 [18:42:07] >>> (new Array( 200 ) ).join( '.' ) [18:42:07] RoanKattouw: (string) '.......................................................................................................................................................................................................' [18:42:11] jdlrobson: ----^^ [18:42:37] RoanKattouw: hhmm? [18:43:10] marktraceur: Could be memory related. That's pretty much the only thing that can kill it by design (It has a limited job grid memory allocation) [18:43:30] ...wat [18:43:49] Oh, like, a memory leak somewhere? [18:43:53] Because this time it worked [18:44:01] >>> ( new Array( 200 ) ).join( '.' ) [18:44:02] marktraceur: (string) '.......................................................................................................................................................................................................' [18:50:12] (03CR) 10Catrope: [C: 032] Actually use getRelative[Content|Structural]Offset wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122451 (owner: 10Esanders) [18:50:20] marktraceur: Yeah, bot if the bot's been running for a few weeks, a larger operation might neck it [18:50:29] Ah. [18:50:36] Larger operation. [18:50:39] Either a leak, or maybe too much other things at the same time (incoming traffic) [18:50:57] if it's the latter, I can just increase the memory limit a bit [18:51:20] I've seen it die more often even when it wasn't given a command. [18:51:35] Which means either there is a leak in the message processing instead, or the limit is too low again. [18:51:36] (03Merged) 10jenkins-bot: Actually use getRelative[Content|Structural]Offset wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122451 (owner: 10Esanders) [18:51:40] Right [18:51:53] * Krinkle bumps the limit [18:52:24] 1024M -> 1280M [18:57:23] (03CR) 10Catrope: [C: 04-1] Show VE demo error in VE (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122443 (owner: 10Esanders) [18:58:57] edsanders: $( '' ).text( textToEscape ).html() [19:01:00] (03PS2) 10Esanders: Show VE demo error in VE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122443 [19:03:40] (03CR) 10Catrope: [C: 032] Show VE demo error in VE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122443 (owner: 10Esanders) [19:04:35] (03Merged) 10jenkins-bot: Show VE demo error in VE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122443 (owner: 10Esanders) [19:27:09] Quick OOjs UI question: Is there a nice way to create a dropdown box like the format tool but for use in a dialog? [20:44:23] Krenair: There's Menu[...]Widget I think [20:44:26] But TrevorParscal is the expert [20:44:57] Yeah I have a MenuWidget [20:45:25] Which contains selectable items etc., but isn't a dropdown box [20:45:44] There is something that marktraceur made TrevorParscal put in that looks like a dropdown I thin [20:45:46] k [20:47:15] I quite like the format tool one, but that.. looks limited to the toolbar. I want to use it in a dialog [20:48:07] Krinkle: InlineMenuWidget [20:49:16] Er. Krenair ^^ [20:49:18] :) [20:49:25] Effing complicated nick ambiguity [20:51:21] Thanks marktraceur [20:53:48] Yup [20:54:19] (03PS1) 10Esanders: Fix handlesOwnChildren check in getRelativeOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122556 [20:55:26] marktraceur, hm... this is okay, except on initial load the display shows no item (but an item is selected if you open the dropdown). If you then select an item the display is fine [20:55:57] Yeah [20:56:12] (03PS2) 10Esanders: Fix handlesOwnChildren check in getRelativeOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122556 [20:57:22] (03CR) 10Catrope: [C: 032] Fix handlesOwnChildren check in getRelativeOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122556 (owner: 10Esanders) [20:59:06] (03Merged) 10jenkins-bot: Fix handlesOwnChildren check in getRelativeOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122556 (owner: 10Esanders) [22:25:09] (03PS1) 10Trevor Parscal: Emit event when insertion annotations change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122585 [22:31:53] (03PS1) 10Trevor Parscal: Remove constructive flag from return to save form button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122593 [22:36:23] (03CR) 10Jforrester: [C: 032] Remove constructive flag from return to save form button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122593 (owner: 10Trevor Parscal) [22:37:44] (03Merged) 10jenkins-bot: Remove constructive flag from return to save form button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122593 (owner: 10Trevor Parscal)