[00:00:07] In most cases all commits are relevant to the change log, sometimes some are better left out. Other times I do a minor copy edit to make them easier to scan where the original message isn't as useful to explain what changed, and some times just making them slightly more consistent. [00:00:08] Krinkle: We could fix it to "Copy the resulting list into a new section on History.md, but change it to make Krinkle happy."? :-) [00:00:12] The former two can be included in the readme [00:00:14] * James_F nods. [00:00:17] the latter is more for CR [00:00:20] Yeah. [00:00:22] (eg. like in this edit) [00:00:31] Hm. Could use some aesthetics. [00:00:39] But this is beta, yes? [00:00:39] justin_zw: Putting it mildly. :-) [00:00:55] justin_zw: Yeah, it's not close to a finished product yet. [00:01:24] Well... What areas are currently in need of love, and how can I get involved? Specifically, where's the repo that I can fork? :P [00:01:29] justin_zw: As you can see, you can trivially edit the contents of cells, but you can't add or remove columns/rows, insert a new table, merge/split cells, … [00:01:40] justin_zw: https://git.wikimedia.org/summary/VisualEditor%2FVisualEditor.git is the main repo for VisualEditor. [00:01:47] justin_zw: It's… a complicated project. :-) [00:02:03] I'm notoriously good at learning those when I want to. [00:02:08] Awesome. [00:02:17] justin_zw: It might be worth exploring how some of the existing editing tools work. [00:03:20] Yeah, that was my plan. Viewing source code and documentation is pretty much how I learned MediaWiki. [00:03:32] justin_zw: Things to remember: We can't "dirty" the DOM (because it's converted into human-readable wikitext and minimal diffs are important), we must make changes in reversible transactions (because we're planning to do real-time collaborative editing and self-describing edits), and UX simplicity and extensibility is important over quick fixes. [00:03:37] * James_F nods. [00:03:48] We'd love to answer any questions, of course. [00:04:32] James_F: I'll let you do the push to npm in a bit. Finishing something else first. [00:04:49] Krinkle: Merge it so I can do the rest of the local stuff? [00:04:54] When you say "dirty" the DOM, what exactly do you mean? (The dirtying part, not what is the DOM :P) [00:04:56] What rest? [00:05:05] Ah, the tag. [00:05:06] Right [00:05:09] Krinkle: The MW- and VE- updates. [00:05:13] Krinkle: And the tag, yes. :-) [00:05:38] James_F: Well, you can't do that until the npm is pushed. Otherwise you'd be copying a local build instead of the canonical one (and no timestamp/hash url to verify against) [00:05:45] At least shouldn't [00:05:49] justin_zw: Things like moving attributes from parent to child DOM objects, or re-ordering things. [00:05:52] Krinkle: Eh. [00:06:51] So basically it can't move stylings around or re-arrange cells. [00:06:58] So basically it can't move stylings around or re-arrange cells. [00:07:06] Oh, crap, I forgot this wasn't skype. Sorry. [00:07:27] (I'm not terribly used to IRC) [00:08:02] justin_zw: No worries. Yeah, we make minimal changes to the data model. [00:08:36] Because in most cases, they'll be templates, right? [00:08:51] And that could complicate things very quickly. [00:09:22] Well, yeah, I'm choosing to ignore those for now. [00:09:55] The MediaWiki extension that lets you use VisualEditor inside a MediaWiki instance – and adds a huge amount of MediaWiki-specific features – is at https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FVisualEditor.git [00:10:12] VisualEditor is a stand-alone HTML editor that we've built for our own needs, but also those of others. [00:10:39] Does MediaWiki ship with VisualEditor? [00:10:48] Because I think we have it installed over at Zelda Wiki. [00:11:04] justin_zw: Not yet; that's probably going to happen in the next few months, though. [00:11:15] Ah. [00:11:24] But it doesn't stop people installing it. :-) [00:11:35] I know :P [00:11:44] I'm our systems administrator, and I don't remember installing it [00:11:51] * James_F grins. [00:12:06] I think it just kinda popped up. [00:12:18] In MW it relies on Parsoid, a nodeJS service, so you'll remember if you installed it. [00:12:28] Oh, well then I guess I didn't. [00:12:40] So I'll have to get node.js, then. [00:12:56] And I'm guessing I can just do npm install Parsoid for that? [00:13:11] Not sure; gwicke? [00:13:36] (I use a custom Vagrant development image which makes things easy, but not great for production.) [00:13:41] James_F, I'd love to say apt-get install parsoid at this point, but we still don't have a nice longer-term repo for our deb package [00:13:45] * gwicke blames ops [00:13:49] gwicke: :-( [00:13:56] gwicke: npm package it? [00:14:11] that won't set up init scripts, install node for you etc [00:14:20] True. [00:14:30] set up proper log rotation, users, ... [00:14:31] Oh, you want to package node.js with it, as well. [00:14:44] no, our package just depends on the node package [00:14:50] I know. It's a dependency. [00:15:00] So you want it to install the depencies as well. [00:15:09] apt-get does such things [00:15:16] npm does not [00:15:23] I know. [00:15:52] That's because apt-get is for actual package management and configuration, while npm is just for installing node packages. [00:17:00] I happen to use Ubuntu 12.04 as my OS of choice, both for servers and home use :P [00:17:07] justin_zw, https://www.mediawiki.org/wiki/Parsoid/Setup [00:17:23] if you feel adventurous, you can also use a provisional deb repo [00:17:36] deb http://parsoid.wmflabs.org:8080/debian wmf-production/ [00:17:45] apt-get update && apt-get install parsoid [00:37:32] (03PS13) 10Jforrester: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [00:37:56] (03CR) 10Jforrester: [C: 032] "Per Trevor." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [00:38:56] (03Merged) 10jenkins-bot: Disable certain tools when surface has no range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117453 (owner: 10Esanders) [00:40:52] (03CR) 10Krinkle: [C: 032] Tag v1.0.9 [oojs/core] - 10https://gerrit.wikimedia.org/r/123137 (owner: 10Jforrester) [00:41:11] (03Merged) 10jenkins-bot: Tag v1.0.9 [oojs/core] - 10https://gerrit.wikimedia.org/r/123137 (owner: 10Jforrester) [00:41:57] Yay. [00:43:08] Krinkle: OK, so now you just need to auth me to `npm publish`. :-) [00:47:03] James_F: git clone oojs.github.io locally [00:47:14] https://github.com/oojs/oojs.github.io [00:50:57] Krinkle: OK… [00:52:03] That's where you'll copy the release after pushing to npm [00:52:10] I'm having trouble adding you to npm auth [00:52:28] Helpful. :-) [00:56:17] (03CR) 10Jforrester: [C: 032] apex/button: Reset border-color of disabled button when not hovered [oojs/ui] - 10https://gerrit.wikimedia.org/r/122879 (owner: 10Krinkle) [00:56:47] (03Merged) 10jenkins-bot: apex/button: Reset border-color of disabled button when not hovered [oojs/ui] - 10https://gerrit.wikimedia.org/r/122879 (owner: 10Krinkle) [00:57:03] (03PS1) 10Esanders: Indentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/123152 [00:58:25] The main thing that I'd really like to contribute to this project is to allow users to edit just specific tables. [00:59:09] That was what my staffers really wanted. [00:59:27] Krinkle: Once you've done this, could you respond on https://bugzilla.wikimedia.org/show_bug.cgi?id=63303 please? Presumably a shim won't be sufficient? [00:59:44] justin_zw: It might be a lot of work to just edit one kind of table. :-( [01:02:03] (03PS2) 10Jforrester: demos/tools: Indentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/123152 (owner: 10Esanders) [01:02:09] (03CR) 10Jforrester: [C: 032] demos/tools: Indentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/123152 (owner: 10Esanders) [01:02:36] (03Merged) 10jenkins-bot: demos/tools: Indentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/123152 (owner: 10Esanders) [01:03:23] So this is what happens when I try to clone the repo. First I used https, and the second time was just http. http://pastebin.com/xwBUpZJH [01:03:43] justin_zw: Suggest you use SSH [01:03:55] It's more reliable, when our SSL certs are acting up [01:04:09] This is a common problem, then? :P [01:04:17] I've seen it a few times [01:05:05] When you say ssh... do you mean just scp it or something? [01:05:31] Or can I use SSH as the protocol for the clone? [01:05:42] justin_zw: There's an SSH URL next to the HTTPS one I think [01:06:28] Krinkle: What's the expected support matrix for OOjs? [01:07:25] James_F: Should be ES3 syntax, with dependency on the environment to provide polyfillable ES5 features. [01:07:28] Holy crap. You guys seem to have a lot of convoluting contributions. How do you keep it all together without rebasing every couple commits? [01:07:39] Who says we don't? :P [01:07:46] lol [01:07:56] justin_zw: We have scripts to do a bunch of the cross-repo dependency stuff. [01:08:02] justin_zw: Honestly gerrit and jenkisn are pretty crackerjack at rebasing for us [01:08:04] James_F: Technically we are compliant. Using reserved words in dot position is allowed as of ES5. And in ES3 it should only be forbidden for reserved words, not future reserved words. [01:08:06] justin_zw: That, and experts in the middle helping out. :-) [01:08:21] Krinkle: But IE8 ignores ES3 spec? Shock, etc. [01:08:26] Looks like IE got it wrong. I tested a few others. Future reserved words like "throws" do not crash IE8 [01:08:33] Is there any difference between cloning from git.wikimedia.org and gerrit ? [01:08:45] Krinkle: Helpful. [01:08:49] huh_: Pushing is a pain. [01:08:50] Haha, well that's nice and fancy. [01:10:02] James_F: git clone https://gerrit.wikimedia.org/r/p/x/y/z vs git clone https://git.wikimedia.org/summary/xyz ? [01:10:02] James_F: My proposal is to 1) define .super as ['super'] in oojs so that it doesn't trip old browsers, 2) provide an alt alias named .parent (or whatever). Projects that require ES5 anyway, can continue to read the property via .super. Then projects that need ES3 support can read it as .parent [01:10:23] James_F: alternatively, don't do #2, and have Es3 projects access it like ['super'], though that's ugly. [01:10:31] not sure how pushing comes into this [01:10:36] Krinkle: That works. [01:10:50] huh_: git.wikimedia.org is a read-only copy of gerrit, where the code is mastered. So… [01:11:10] James_F: However not a prio yet, since we don't yet have an integrated es5 shim yet, so you can't use OOjs on IE8 anyway. Even if we'd fix this parse error, it'll still trip on a dozen other things after it. [01:11:28] * James_F nods. [01:11:43] James_F: So as it is I'd replace this bug with an enhancement to support ES3, of which one dependency would be the existing "settle on a ES5 shim" bug. [01:11:45] and this the other [01:11:45] Krinkle: But stopping using .super quickly (as a breaking change) would be a good idea. [01:42:48] (03PS2) 10Jforrester: Emit event when insertion annotations change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122585 (owner: 10Trevor Parscal) [01:42:52] (03CR) 10Jforrester: Emit event when insertion annotations change (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122585 (owner: 10Trevor Parscal) [02:32:46] (03PS1) 10Jforrester: Update OOjs to v1.0.9-pre (b5f4657e06) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123164 [02:32:55] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8986c46d35) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123165 [02:33:17] (03PS1) 10Jforrester: Update VE core submodule to master (31a244e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 [02:34:56] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (31a244e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [04:31:08] (03PS6) 10Vikassy: [browser test] Testing use of existing reference in Reference User Interface. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 [12:27:58] (03CR) 10Zfilipin: "testing replies" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [12:31:29] (03CR) 10Jagori79: "Reply testing" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [12:38:49] (03PS4) 10Jagori79: WIP: [Browser test] Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [12:44:21] (03PS5) 10Jagori79: WIP: [Browser test] Adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [13:00:22] (03CR) 10Jagori79: "Trying to publish my comments" (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [13:15:20] (03CR) 10Zfilipin: [C: 04-1] WIP: [Browser test] Adding long Target Links (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [13:47:03] (03CR) 10Zfilipin: [C: 04-1] [browser test] Testing use of existing reference in Reference User Interface. (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 (owner: 10Vikassy) [14:19:04] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (owner: 10Alex Monk) [14:46:16] Okay, so the only dependency I have to install after git cloning the repo is the npm package Parsoid, right? [14:46:26] Or are there more dependencies? [14:56:45] justin_zw: You should also do git submodule --init [14:57:09] From the VisualEditor directory? [14:57:33] justin_zw: Yes. [14:58:03] justin_zw: Specifically, mediawiki/extensions/VisualEditor has lib/ve which is a submodule. [14:58:23] justin_zw: See bottom of https://www.mediawiki.org/wiki/Extension:VisualEditor#Download [14:58:33] justin_zw: `git submodule update --init`, sorry. [14:59:05] Is it supposed to only take a split second? :P [14:59:14] I was expecting at least some output. [14:59:24] justin_zw: Yeah, it should be very quick. [14:59:37] Welcome to git submodule's mysterious output. :-( [14:59:58] Haha. I learn something new about git every time I work on something. [15:01:07] So it should be set up and ready, if I did this right. I put the parsoid into a subdirectory of VisualEditor and ran npm install, which added the node_modules directory into that subdirectory. [15:01:16] (Hope that made sense) [15:01:38] Where you put Parsoid doesn't matter, but sure. [15:02:00] K. I'll enable it and see if it's horribly broken or not. [15:02:44] You need to run the Parsoid service, BTW, not just install it. [15:06:06] Is it a daemon? [15:06:50] Yeah; `node api/server.js`. [15:07:30] I have to configure more local settings? [15:07:45] { [Error: Cannot find module '/var/www/html/wikidev/extensions/VisualEditor/parsoid/api/localsettings.js'] code: 'MODULE_NOT_FOUND' } [15:08:26] Oh, yes, you need to use `localsettings.js.example` as an example. [15:09:46] This is a very labor-intensive process :P [15:09:52] Indeed. :-( [15:10:19] Now I see why you guys said it should be bundled into an apt repo. [15:11:10] * James_F nods. [15:15:45] if i have a 1.22 deployment, is there a recent visual editor i could set up on it for testing/feedback ? [15:15:57] i have parsoid set up already [15:16:19] Richlv: Hey. I /think/ that master of VisualEditor should work with MW 1.22. [15:16:48] Richlv: However, I could be wrong; if so, there's a not-very-recent MW1.22 cut that was taken when MW 1.22 was branched, and so will definitely work. [15:17:22] James_F, last 1.22 one i spotted was some 5 months old - i'll try master then :) [15:17:31] Yeah. [15:18:32] James_F: I wanted to run something by you. So a company in london refme.co saw my OPW application and contacted me about possibly helping with the referencing war effort but they had some questions I wasn't really sure how to answer [15:18:42] I think they might be interested in providing an API [15:19:04] but obviously that wouldn't be native code [15:19:22] And I didn't want to say you guys would or would not be interested in that sort of relationship [15:25:24] James_F, oh - thanks :) [15:25:53] mvolz: Hey, sorry for not answering yesterday. [15:26:17] no problem [15:26:48] mvolz: In general we're pretty difficult to work with outsiders because of our OSS policy (no non-open source software in production) and our privacy policy (no third-party hosting in production). [15:27:05] mvolz: So it depends what the details of what they were offering might be, and how it would work. [15:27:09] Ok that's basically what I told them but I wasn't entirely sure [15:27:28] They were pretty short on details [15:27:37] * James_F nods. [15:27:41] They let me poke around in their code base and it's not terribly mature [15:27:53] Right. [15:27:59] But they're working in a similar direction [15:28:51] Also learned some interesting things, like both the public DOI and ISBN databases aren't very robust [15:29:14] They subscribe to Elivesier for ISBN, for instance, and apparently crossref is best for DOI but not very reliable [15:29:27] I think the DOI expander uses crossref and a few others [15:29:36] Yeah, it does. [15:29:50] And yes, I'm a bit worried about data source quality. [15:31:31] Hmm. I wonder if it's too out of scope for wikimedia to run their own? Kind of a big task but it seems within scope of the foundation. Would be awesome. Probably not a short term solution but might be good long term [15:31:43] Right. [15:31:49] Certainly something we could consider. [15:32:20] maybe as part of wikidata? [15:32:20] But at the same time, we don't want to crowd out other open content providers in this space. [15:32:21] yeah good point :) [15:32:29] Yeah, that's likely where we'll end up storing proper data. [15:32:56] Just 'cos we're big, well-funded and well-known doesn't mean we should trample over other people already doing a great job. [15:33:22] :) [15:34:03] Anyway would it be okay if I just CC-ed you on a quick e-mail? and you can give the party line so I don't seem like the bad guy on third party ;) [15:34:11] maybe they'll contribute coding manpower! :) [15:34:48] I told them about Wikimania, they seem interested in coming [15:37:20] Yes, of course. :-) [15:43:01] Sweet, thanks. is there a good link to that license? google is sadly failing me. [15:55:09] mvolz: Which licence? Our privacy policy? [15:56:26] James_F: oh I see, they're two separate liscences. Found it now :) [15:59:11] I'll come back later. I'm a bit tied up at the moment, but I am very interested in contributing to this. [15:59:16] Cheers! [17:44:54] (03PS6) 10Esanders: Separate out debug bar for use outside the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123039 [18:03:24] (03PS7) 10Esanders: Separate out debug bar for use outside the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123039 [18:03:26] (03PS1) 10Esanders: Support null ranges in the demo debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123354 [18:25:08] (03PS6) 10Esanders: Show the debug bar in MW if ve.debug is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123042 [18:25:37] (03PS7) 10Esanders: Show the debug bar in MW if ve.debug is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123042 [18:27:14] (03CR) 10jenkins-bot: [V: 04-1] Show the debug bar in MW if ve.debug is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123042 (owner: 10Esanders) [18:33:32] (03PS1) 10Esanders: Add missing ve.ui.Tool.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123364 [18:33:48] fixme merge please ^^ [18:34:07] (03CR) 10Catrope: [C: 032] Add missing ve.ui.Tool.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123364 (owner: 10Esanders) [18:35:02] (03CR) 10jenkins-bot: [V: 04-1] Add missing ve.ui.Tool.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123364 (owner: 10Esanders) [18:35:50] (03CR) 10Catrope: [C: 04-2] "Needs pull-through of the commit that creates ve.ui.Tool.js first" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123364 (owner: 10Esanders) [18:53:11] I have a question about default values in TemplateData. Is Timo around? Or does anyone else want to volunteer? [18:53:25] Ask, I or someone will read and answer later. [18:53:59] I'd like to add a default value to a template. But when I did — see http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:Citation_needed/doc&diff=86037&oldid=86036 — it didn't actually put the default text into wikitext. [18:54:40] What I wanted was "|date=" to automagically say (plain text) "April 2014". What I got was "April 2014" displaying in the template dialog in light gray, [18:55:00] but nothing in the wikitext (just "{{citation needed|date= }}" ). [18:55:50] So I need to know whether I screwed up the TemplateData formatting, or whether this is actually broken at the moment. [19:00:41] (03CR) 10Catrope: [C: 032] Support null ranges in the demo debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123354 (owner: 10Esanders) [19:03:21] (03Merged) 10jenkins-bot: Support null ranges in the demo debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123354 (owner: 10Esanders) [19:08:23] (03PS1) 10Esanders: Adjust loop counters in word break detection when removing item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123373 [19:12:33] ryasmeen_: [19:13:01] ryasmeen_: Could you send me your bug list again? [19:13:08] I lost my tabs :( [19:13:31] okay [19:13:32] (03CR) 10Catrope: [C: 032] Adjust loop counters in word break detection when removing item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123373 (owner: 10Esanders) [19:13:48] Bug 63154 - VisualEditor: Uncaught Error: Unbalanced set of replace operations found and few more errors appear in the console while trying to change bullet list to numbered list [19:13:55] Bug 63386 - VisualEditor: Link does not get applied after concatenating a text to the existing link and reapplying the link (edit) [19:14:05] Bug 63093 - VisualEditor: An empty selection box is appearing while inserting a math formula [19:14:14] Bug 56801 - VisualEditor: Inspectors break up or appear in the wrong place after coming back from another window (edit) [19:14:22] Bug 63341 - VisualEditor: "Insert Transclusion" button remains enabled while adding an empty content section [19:14:29] (03Merged) 10jenkins-bot: Adjust loop counters in word break detection when removing item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123373 (owner: 10Esanders) [19:14:31] Bug 63340 - VisualEditor: "Insert Transclusion" button becomes enabled after adding a second empty template [19:14:39] Bug 63333 - VisualEditor: Adding a space after a formatted link throws error Uncaught TypeError: Cannot read property 'constructor' of undefined (edit) [19:14:43] RoanKattouw: Fool. :-P [19:14:53] Bug 63209 - VisualEditor: Changing the format of a nested list with a block slug breaks badly (edit) [19:15:30] RoanKattouw: ^^ :) [19:16:59] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/123373/ backport to wmf20. [19:18:09] I have a new question: Are (1) internal and external links or (2) hieroglyphics considered "nodes" in VisualEditor's terms? [19:18:23] whatami: Hieroglyphics yes [19:18:45] whatami: Links: generally not, except if they're automatically numbered external links like [http://www.example.com] turning into [1] [19:18:55] whatami: Default text in TemplateData is "if you don't fill anything in, the template will fill it in for you". [19:19:01] Links are generally annotations [19:19:21] James_F, the default text didn't actually get filled in. [19:19:43] whatami: Is the TemplateData change you made a lie, then? [19:20:09] RoanKattouw, so I'm looking at the very cool "double-click to open a node" item. It doesn't open hieroglyphics. I'm not sure that it should, though. [19:20:23] Ahm... [19:20:28] That's a bug [19:20:33] whatami: What you probably want is to put {{#ifeq:{{{input|}}}||Default value}} instead of {{{input|}}} in the template. [19:20:37] James_F, try inserting {{citation needed}} over at beta labs. [19:20:38] It's definitely intended to open on hieroglyphics [19:20:52] (03CR) 10Catrope: [C: 032] Emit event when insertion annotations change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122585 (owner: 10Trevor Parscal) [19:21:06] whatami: If it's "today's date", that would be {{#ifeq:{{{input|}}}||{{subst:CURRENTYEAR}}-{{subst:CURRENTMONTH}}}} or something. [19:21:24] Okay RoanKattouw , I'll file a hieroglyphics-related bug [19:21:43] whatami: Well, you didn't update the actual template, just changed the documentation: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:Citation_needed&action=history [19:21:43] James_F, yes, that would be nice. But right now, I'm trying to get **anything** to turn up in the article as the default. [19:21:57] whatami: That's a matter of template programming. TemplateData doesn't do that. [19:22:20] What is the point of TemplateData's default value, if it's not to provide a default value? [19:22:39] whatami: whatami: Default text in TemplateData is "if you don't fill anything in, the template will fill it in for you". [19:22:53] That's what I thought. [19:22:57] (03Merged) 10jenkins-bot: Emit event when insertion annotations change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/122585 (owner: 10Trevor Parscal) [19:22:59] Now I am telling you: It did not work. [19:23:02] whatami: Most templates will automatically put a value in if you don't specify one. [19:23:20] whatami: The fact that the citation templates don't is something you should ask the community, not us. :-) [19:23:52] What I'm asking you is whether, having defined a default value in TemplateData, there ought to have been a default value **supplied by TemplateData**. [19:24:05] No. [19:24:08] What does VisualEditor do with the "default" in TemplateData? [19:24:17] (03CR) 10Catrope: [C: 04-1] Make tools use commands (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [19:24:17] It displays it for info. [19:24:26] If the TemplateData lies, no-one can really fix that. [19:24:44] So "default" means "please change the light gray text". [19:24:53] Yes. [19:24:55] It does not mean "please make this the default". [19:24:57] We talked about this on Monday. [19:25:02] Err. Tuesday. [19:25:33] I said that there is a proposal to add "auto-fill" to ask clients (in this case, VE) to automatically fill in a particular value if the user doesn't set one. [19:26:02] But that's not what "default" means on Commons or English Wikipedia or Meta template documentation systems, so it's not what TemplateData codes. :-) [19:26:36] How exactly does "default" (as implemented in TemplateData) differ from "label"? [19:26:52] What? [19:26:55] * James_F is confused. [19:27:11] That's like asking how country differs from president. [19:27:13] Click here: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:Citation_needed/doc&action=edit [19:27:32] If you define "label", it puts that information inside the parameter box, in light grey text (right?) [19:27:36] No. [19:28:05] Label goes on the left. Description goes underneath. Default is the placeholder text. [19:28:13] None of them conflict with each other. [19:28:29] Okay. [19:28:42] So "default" means "put light gray text inside the box". [19:28:50] Placeholder text, yes. [19:29:00] Like in almost every other Web system on Earth. :-) [19:29:42] And there isn't any way to make that text actual be real text, until some autofill system is added. [19:29:43] If you don't have a value for the parameter, 'default value' is used. [19:29:52] No, it's not. [19:29:59] Argh. [19:30:08] whatami: Yes, it is, if the template author is competent. [19:30:14] It's supposed to be. [19:30:22] Otherwise it's not 'default' :\ [19:30:41] whatami: Rephrasing mooeypoo's comment, "If you don't have a value for the parameter, 'default value' is used ." [19:31:26] I'm confused. [19:32:04] whatami, I think the difference is between "what should be happening" and "what is happening in bad templates" [19:32:18] Ideally, default value is the value that is inserted if there's no value given by the user. [19:32:26] http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Whatamidoing_(WMF)/Sandbox&diff=86043&oldid=86040 clearly is not adding what is defined as the default value in TemplateData (date) for that template. [19:32:26] whatami: TemplateData documents a template, it does not write the template for you. [19:32:49] If some templates don't do that, they're badly designed. So TemplateData assumes that if you have "default: something" it means that the default value for the parameter is "something". [19:32:50] whatami: TemplateData does not and will not modify a template. That's the job of a human who modifies the template. [19:33:11] whatami, that means the documentation is wrong, then. [19:33:15] whatami: If you make the TemplateData lie about how the template works, then it will lie. [19:33:17] TemplateData is supposed to tell VisualEditor to do things. What I want *VisualEditor* to do is to type that default value in for me. [19:33:35] whatami: Wrong. TemplateData is supposed to tell consumers of templates how the template works. [19:33:48] whatami: That's a template's job, not VisualEditor's. [19:33:53] But also, it appears in the placeholder text -- that's the convention for "default" values all over the internet. [19:34:03] whatami: If it's "today's date", that would be {{#ifeq:{{{input|}}}||{{subst:CURRENTYEAR}}-{{subst:CURRENTMONTH}}}} or something. [19:34:04] It makes it clear that there's no *user* input, but some default input from the system. [19:34:37] If the template was autofilling a parameter that we didn't want people to touch, we'd just omit it from TemplateData. [19:35:03] it's not that you don't want them to touch it, it's that you say that if they don't fill in the value, it has some other value. [19:35:10] that usually means the parameter is optional, too. [19:35:43] You want to let users change it, but you also want to make sure they realize that if they have *nothing* in there, there's some other value that will appear whether they realized it or not. [19:36:10] So TemplateData cannot provide information to VisualEditor. [19:36:12] That's the same concept that size uses, btw. IF you choose 'default' size in the widget, it shows you the placeholders -- so the user understands that they put nothing in there, but the *system* will. [19:36:18] Well, it *can*—that's the only reason it exists, in fact—but it is currently restricted to providing only the parts of the template that come before the equals signs. [19:36:29] whatami, it provides a presentation information, mostly. [19:37:18] I don't think filling in the default value directly as input for template parameters is good UX though, whatami [19:37:45] I think that providing it pre-typed (when it's simple enough) is a great idea. [19:37:52] if you already add this parameter in VE, you probably want to change it. So it is inserted empty (with a visual indication that "hang on user, if you put nothing here, the system will fill X in for you" so the user has no surprises) but also allowing the user to put in whatever they wish. [19:38:05] Users can change it later if they needed to. [19:38:36] I disagree; I think users should be aware of whether the value is automatic from the system or user-defined [19:38:44] whatami, another issue with default is that it can be CHANGED in the template [19:39:01] I'm not seeing the downside to having VisualEditor type "April 2014" into the date parameter. [19:39:18] If you want to manually change it, then you can. If you don't, then it's obvious that it's being added. [19:39:19] As we discussed, it's a feature request. [19:39:27] so, if I insert a template with some parameter as default, it means I (the user) didn't write anything in it which also means that if someone changes the original template, default changes. [19:39:47] It's pretty much the same as default size. You consciously make the choice to use default, whatever default is and whatever it will be in the future. [19:39:50] Parameter data is stored locally. [19:40:32] The result is {{fact|date=April 2014}} in every separate instance. Changing the template at Template:Fact has no effect on the date in your local article. [19:40:52] whatami, but what's the default value for this template? [19:41:32] To have a bot fill in the date later, because people didn't know to add it, didn't want to bother, or screwed up the dat eformat. [19:41:48] whatami, but that's a problem with the template, it seems. [19:42:16] I mean, date= should be a mandatory non-defaulted value if that's the case. And that's a *template* parameter change, not VE. [19:42:26] VE listens to the instructions. The instructions in this case seem to be wrong. [19:42:54] If we generalize the case to most other templates, it won't be a good idea to put the default value into the parameter inputs in VE... see what I mean? [19:43:20] Yes, forcing the inclusion of a date would be ideal. But there's a middle option: make it possible for VisualEditor to auto-fill data into parameters. [19:43:29] As James says, it's an open feature request. [19:43:50] whatami: So why did we just spend 20 minutes arguing about it? :-( [19:44:10] giving it as an option maybe, but not doing it automatically, imho. [19:44:14] Because I had somehow gotten the idea that the "default" actually provided a very limited way of doing this. [19:44:15] (03CR) 10Catrope: Make tools use commands (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [19:44:19] Now, not someday. [19:44:37] whatami, look here: http://en.wikipedia.beta.wmflabs.org/wiki/Template:Citation_needed --> date is *required* but has a default value. [19:44:41] That's the definition of that template. [19:45:03] If you think that the default is silly (Which it may well be) then the problem is with the *template* having that issue, VE just reflects it by acting the way it asks. [19:45:20] Date is called "required", but the requirement is not enforced. The "default" in TemplateData is meaningless. [19:45:30] whatami, *by the template*. [19:45:31] It produces light gray text in the box, and then does nothing. [19:45:40] yes, because that's what templates give you. [19:45:51] whatami: It represents what the person who wrote the template documentation said the template did. [19:45:57] ok, let's take another simple template as an example, like the "hi there" example template. [19:46:12] whatami: If people lie when they write template documentation, the problem is with the lying liers. [19:46:48] Sure: Shall we rename "required" to "suggested by someone"? ;-) [19:46:52] whatami, see here for instance -- http://www.mediawiki.org/wiki/Help:Templates#Default_values [19:47:02] No. We should ban users who violate WP:BEANS. :-) [19:47:04] the silly little "{{Welcome}}" example template.. [19:47:23] (03PS5) 10Catrope: Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [19:47:26] (03CR) 10jenkins-bot: [V: 04-1] Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [19:47:34] (03CR) 10Catrope: Make tools use commands (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [19:48:48] so, "reason" is required but has default value "everything". If I put in reason= it will produce "Everything". Why? Because that's how the template author wrote it. VisualEditor just reflects that fact, it won't change the way templates behave. In this template (the welcome one) it makes sense -- but other templates (like the one you gave) use it in a way that makes no sense. But again, that's *the template's* problem. [19:49:10] TemplateData forced template authors to document what the template does, so it may expose problems with the inherent design of some templates... does this make sense? [19:49:40] I totally agree with you that using default for dates make no sense, btw. [19:49:48] but that's a weird template implementation. [19:50:04] mooeypoo, Yes, it makes some sense. [19:51:28] Also, whatami, consider this too - if I add {{Welcome}} to the page, I know that it will use default values. I do this *consciously* because I want the default to appear, so that if someone goes to the template code and changes the default "reason" from "Everything" to "Something" the template I just put up will change too. [19:51:44] So there's a difference in *intent* as well between inserting a value and using the default value. [19:52:19] (Same thing with size, btw -- using 'default size' isn't just about filling in whatever size is right now the default,but it's purposefully NOT adding size in, so wiki default takes over *even* if we change it globally at some point) [19:52:44] that's why all these "default" stuff are so confusing, at least to me -- they're supposed to be another intended behavior. [19:53:04] (03CR) 10Catrope: [C: 031] Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [19:54:20] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (8986c46d35) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123165 (owner: 10Jforrester) [19:55:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8986c46d35) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123165 (owner: 10Jforrester) [20:03:13] (03PS6) 10Catrope: Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [20:03:45] (03CR) 10jenkins-bot: [V: 04-1] Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [20:06:39] (03PS7) 10Catrope: Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [20:06:45] (03PS1) 10Esanders: Skip over handlesOwnChildren nodes in newFromAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123429 [20:07:26] [13:06] in about an hour, cscott will be asking for discussion on Square bounding boxes and Scoped language converter RfCs in #wikimedia-office [20:07:31] mooeypoo, James_F ---^^ [20:07:46] wait, is that 13:06 your time? [20:07:57] mooeypoo: Yeah like just now [20:08:00] 13:06 + 1 hour + converting to my time [20:08:04] * mooeypoo 's head explodes [20:08:05] The discussion is at 14:00 PDT / 17:00 EDT [20:08:08] So in 54 minutes [20:08:09] thank you. [20:08:22] wow. I retreat in shame now. [20:08:54] (03CR) 10Catrope: [C: 032] Skip over handlesOwnChildren nodes in newFromAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123429 (owner: 10Esanders) [20:09:35] (03PS5) 10Catrope: Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [20:10:14] (03Merged) 10jenkins-bot: Skip over handlesOwnChildren nodes in newFromAnnotation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123429 (owner: 10Esanders) [20:12:08] 2100 UTC [20:12:42] http://www.timeanddate.com/worldclock/fixedtime.html?msg=RFC+Meeting&iso=20140402T21 [20:13:17] I am usually good in converting time, but after coming back from SF, my laptop was still PDT, my main computer was EST but not fixed for DST, and my phone auto-updated to the correct time. [20:13:25] I felt like Marty McFly there for a while. [20:15:17] (03PS2) 10Trevor Parscal: Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 [20:15:28] (03CR) 10jenkins-bot: [V: 04-1] Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [20:16:23] VisualEditor template entry with parameters is *better* than {{something|guess}}, then preview, then open the list of templates, then open the template in a new page, then fix it. <3 ++ ! [20:19:11] hah! [20:28:43] spagewmf: Glad to make you happy. :) [20:30:18] (03PS1) 10Esanders: Improve hasFocus check to compare the anchorNode to the parent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123437 [20:36:08] (03CR) 10Catrope: [C: 032] Improve hasFocus check to compare the anchorNode to the parent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123437 (owner: 10Esanders) [20:36:09] * mooeypoo chokes on a rebase [20:36:36] eek.. uh, RoanKattouw, I am rebasing this: https://gerrit.wikimedia.org/r/#/c/119435/ and after "git rebase master" I got a page-and-a-half of "applying: ...." stuff [20:37:00] mooeypoo: Is your master up to date? [20:37:07] (03Merged) 10jenkins-bot: Improve hasFocus check to compare the anchorNode to the parent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123437 (owner: 10Esanders) [20:37:18] I updated it just before taking in the review (that's why I noticed I hsould rebase) [20:37:22] updated mw to [20:37:23] too [20:37:42] VE stopped loading after that due to OOJS error so I figured I should rebase. [20:38:49] RoanKattouw, http://pastebin.com/NpbESYUw [20:39:25] Whooooaaa [20:39:30] What is this I don't even [20:39:39] mooeypoo: Try git rebase --onto master HEAD^ [20:39:53] It might be that you've accidentally interactively rebased a whole bunch of stuff I guess? [20:39:58] RoanKattouw, so first "git rebase --abort" I assume? [20:40:30] well, I'm in lib/ve .. I also have a patch up on vemw but it shouldn't rebase that when I am in the submodule, I don't think [20:40:56] uh, RoanKattouw when I go "git rebase --abort" I get "no rebase in progress".. wtf? [20:41:17] OK well whatever is going on [20:41:23] That --onto command should fix it? [20:41:38] I want to make sure I am first not IN a rebase yet, but I guess that's a no. [20:42:07] ok that worked better. I got a conflict in a file I actually worked on, and the rest are files I actually touched. [20:44:17] (03PS13) 10Mooeypoo: [WIP] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [20:44:24] one down. Two to go. [20:44:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [21:00:02] Krinkle: I'm ignoring the doc sprint because there's a lot of CR on my plate already [21:00:05] Just FYI [21:00:06] Belatedly. [21:00:55] marktraceur: Ooh, you're doing CR? Please +2 https://gerrit.wikimedia.org/r/#/c/123348/ and https://gerrit.wikimedia.org/r/#/c/122086/ ;-) [21:01:02] No no no. [21:01:02] marktraceur: (No huge rush.) [21:01:04] CR for my team. [21:01:12] * James_F nods. :-( [21:05:26] (03PS5) 10Jforrester: Use CSS to style figure and figcaption [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [21:08:17] something's really weird with my rebasing today... [21:08:23] (03PS2) 10Jforrester: Update VE core submodule to master (ef6096a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 [21:08:54] http://pastebin.com/djve6F5E RoanKattouw_away any idea? (When you get back) -- does this mean I don't need to rebase? It said applying, then did nothing... and when I later did 'git rebase master' it said the patch is up to date. I'm confused. [21:09:45] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (ef6096a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [21:10:22] mooeypoo: It means it's a trivial rebase and so it succeeded. [21:10:45] so do I send it to review? [21:11:17] 'cause VE doesn't load now at all (again) :( [21:11:46] That means there's probably a logical but not file-level conflict. [21:12:03] yeah, no errors again [21:12:06] (03PS16) 10Jforrester: [WIP^3] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [21:12:14] See? [21:12:18] hm [21:12:20] (03PS7) 10Jforrester: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [21:12:25] what about the one ab--- yes. [21:12:33] okay. Let me re-pull stuff and see if VE loads now [21:12:44] Also, boo to 113163 being a WIP. :-( [21:12:46] * James_F nods. [21:13:04] Remember not to pull master of ve-core but git submodule update. [21:13:05] It's only a WIP because the other commit keeps adjusting it [21:13:16] Apparently Ed broke core completely, according to Roan. [21:13:23] (03CR) 10jenkins-bot: [V: 04-1] [WIP^3] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [21:13:25] I can take the WIP off and start a new commit on top of it [21:13:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [21:13:42] for all the changes that the model requires [21:16:48] James_F, remember how TrevorP|Away showed me how to check for MW errors when ve didn't load? from the load.php resources? [21:17:07] .... I have two files with the absolutely incredibly unhelpful exception "/* Internal error */" [21:17:08] :(( [21:20:18] mooeypoo: Fun. [21:20:29] mooeypoo: I blame ResourceLoader. [21:21:11] This is really frustrating. SOMETHING is stopping VE from loading, and I have no idea what. [21:22:19] James_F, I assume it can't be what it was last time because ve core was updated [21:37:48] (03PS1) 10Cmcmahon: [browser test] extend timeout waiting for edit surface to appear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123450 [21:38:46] [13oojs.github.io] 15jdforrester pushed 1 new commit to 06master: 02https://github.com/oojs/oojs.github.io/commit/2f8eb9273968cf6227218a630599433b6e42f734 [21:38:47] 13oojs.github.io/06master 142f8eb92 15James D. Forrester: Publish v1.0.9 release from npm [22:15:46] mooeypoo: This might be due to ve.ui.Tool.js being missing from VisualEditor.php [22:15:56] I'll be fixing that later today but you can patch that locally and see if it changes anything [22:16:04] RoanKattouw, wouldn't that throw an exception? [22:16:21] Yeah but those get put in comments by RL [22:16:27] mooeypoo: you getting some of those comments? [22:16:31] Oh wait I see what you're saying [22:16:33] hmmm [22:16:39] Alright well I'm gonna try and get things back into a usable state [22:16:43] I get /* Internal error */ [22:16:47] which is very helpful. [22:16:53] mooeypoo: Anything useful in the Apache logs? [22:16:56] Well, that's descriptive! [22:16:57] checking now [22:16:59] tail /var/log/apache2/error.log [22:17:27] yikes [22:17:38] got a whole bunch, but from yesterday [22:17:48] none from April 2 [22:18:07] I have quite a number of these: [Tue Apr 01 01:01:32.287716 2014] [core:warn] [pid 11537] AH00045: child process 30763 still did not exit, sending a SIGTERM [22:18:12] but these are from yesterday [22:23:45] (03PS1) 10Catrope: Revert "Improve hasFocus check to compare the anchorNode to the parent" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123463 [22:24:50] (03CR) 10Catrope: [C: 032] Revert "Improve hasFocus check to compare the anchorNode to the parent" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123463 (owner: 10Catrope) [22:25:49] (03Merged) 10jenkins-bot: Revert "Improve hasFocus check to compare the anchorNode to the parent" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123463 (owner: 10Catrope) [22:26:47] (03PS1) 10Catrope: Revert "Detect document focus properly and allow null selection in model" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123464 [22:26:52] (03CR) 10Catrope: [C: 032] Revert "Detect document focus properly and allow null selection in model" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123464 (owner: 10Catrope) [22:27:49] (03Merged) 10jenkins-bot: Revert "Detect document focus properly and allow null selection in model" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123464 (owner: 10Catrope) [22:29:16] TrevorParscal: https://www.npmjs.org/package/oojs?kjfnwejf1 [22:29:53] (03PS8) 10Catrope: Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [22:31:41] (03PS6) 10Catrope: Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [22:34:10] (03CR) 10Cmcmahon: [C: 032] "merging, this timeout was the only cause of today's test failures, and Bug 63447 covers the issue" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123450 (owner: 10Cmcmahon) [22:35:37] (03Merged) 10jenkins-bot: [browser test] extend timeout waiting for edit surface to appear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123450 (owner: 10Cmcmahon) [22:36:59] James_F, ooh, my picture was added to the staff page, but my name isn't linked anywhere. [22:37:15] do I ask to link it to mediawiki.org profile or should I open a brand new one somewhere? [22:37:23] we talked about this, and I don't remember what the conclusion was. [22:39:37] oh, scratch that, I have a page. [22:47:08] (03CR) 10Catrope: [C: 04-1] Correctly insert or update citations based on template option (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [22:47:23] TrevorParscal: plz fix ---^^ [22:49:34] (03PS3) 10Catrope: Update VE core submodule to master (7976a9a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [22:49:46] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (7976a9a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [22:51:00] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (7976a9a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [23:00:53] (03PS1) 10Catrope: Revert "Fix handlesOwnChildren check in getRelativeOffset" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123472 [23:00:58] (03CR) 10Catrope: [C: 032] Revert "Fix handlesOwnChildren check in getRelativeOffset" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123472 (owner: 10Catrope) [23:01:57] (03Merged) 10jenkins-bot: Revert "Fix handlesOwnChildren check in getRelativeOffset" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123472 (owner: 10Catrope) [23:03:16] Awesome: http://aem1k.com/world/ [23:03:35] TrevorParscal: Can you please look into this when you have some time: https://bugzilla.wikimedia.org/show_bug.cgi?id=63452 [23:15:08] (03PS4) 10Catrope: Update VE core submodule to master (9484b81) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [23:17:53] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (9484b81) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [23:19:10] (03Merged) 10jenkins-bot: Update VE core submodule to master (9484b81) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123166 (owner: 10Jforrester) [23:22:37] (03CR) 10Alex Monk: Support new column-width and list-style attributes to Cite's (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (owner: 10Alex Monk) [23:25:12] (03PS3) 10Trevor Parscal: Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 [23:25:24] (03CR) 10jenkins-bot: [V: 04-1] Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [23:27:27] (03PS4) 10Trevor Parscal: Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 [23:27:39] (03CR) 10Catrope: [C: 032] Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [23:27:41] (03CR) 10jenkins-bot: [V: 04-1] Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [23:27:44] (03CR) 10Catrope: [C: 032] Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [23:28:41] (03Merged) 10jenkins-bot: Make tools use commands [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121466 (owner: 10Trevor Parscal) [23:28:45] (03Merged) 10jenkins-bot: Make getToolsForNode place primary commands first [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121468 (owner: 10Trevor Parscal) [23:31:17] (03PS2) 10Catrope: Update VE core submodule to master (c5f4f78) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 (owner: 10Trevor Parscal) [23:31:28] (03PS5) 10Catrope: Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [23:32:52] (03CR) 10jenkins-bot: [V: 04-1] Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [23:38:45] (03PS6) 10Catrope: Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [23:42:11] (03CR) 10Catrope: [C: 032] Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [23:42:17] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c5f4f78) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 (owner: 10Trevor Parscal) [23:43:49] edsanders: [23:43:51] edsanders: https://gist.github.com/catrope/9945583 [23:44:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (c5f4f78) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 (owner: 10Trevor Parscal) [23:45:01] edsanders: https://gist.github.com/catrope/9945606 [23:45:07] (03Merged) 10jenkins-bot: Correctly insert or update citations based on template option [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123124 (owner: 10Trevor Parscal) [23:46:26] ryasmeen_: The citation inspector on image bug should now be fixed on beta labs as well [23:47:20] okay RoanKattouw [23:47:20] `checking it [23:47:50] (03CR) 10Alex Monk: Support new column-width and list-style attributes to Cite's (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (owner: 10Alex Monk) [23:48:14] I dont see it fixed RoanKattouw? [23:48:29] I am still getting those exception errors [23:50:33] (03PS1) 10Esanders: Minor documentation fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123484 [23:51:37] (03CR) 10Catrope: [C: 032] Minor documentation fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123484 (owner: 10Esanders) [23:52:33] (03Merged) 10jenkins-bot: Minor documentation fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123484 (owner: 10Esanders) [23:53:14] (03PS1) 10Esanders: Set content directionality on the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123485 [23:53:16] (03PS1) 10Esanders: Pass SurfaceFragments, not Surfaces, to Dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 [23:54:24] (03PS2) 10Jforrester: Update OOjs to v1.0.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123164 [23:58:22] (03PS1) 10Jforrester: Update OOjs to v1.0.9 [oojs/ui] - 10https://gerrit.wikimedia.org/r/123487 [23:59:14] (03PS3) 10Jforrester: Use new OO#initClass method for base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/123120 (owner: 10Esanders)