[00:00:12] Krinkle: OOjs 1.0.8 -> 1.0.9 updates are https://gerrit.wikimedia.org/r/#/c/123452/ https://gerrit.wikimedia.org/r/#/c/123164/ and https://gerrit.wikimedia.org/r/#/c/123487/ [00:03:21] (03PS1) 10Catrope: Restore selection after ListAction too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123488 [00:04:29] (03CR) 10Esanders: [C: 032] Restore selection after ListAction too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123488 (owner: 10Catrope) [00:05:26] (03Merged) 10jenkins-bot: Restore selection after ListAction too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123488 (owner: 10Catrope) [00:06:35] (03PS8) 10Catrope: Separate out debug bar for use outside the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123039 (owner: 10Esanders) [00:08:03] (03PS9) 10Catrope: Separate out debug bar for use outside the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123039 (owner: 10Esanders) [00:08:26] (03CR) 10Catrope: [C: 032] Separate out debug bar for use outside the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123039 (owner: 10Esanders) [00:08:45] (03Abandoned) 10Catrope: Add missing ve.ui.Tool.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123364 (owner: 10Esanders) [00:08:47] (03CR) 10Krinkle: [C: 032] Update OOjs to v1.0.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123164 (owner: 10Jforrester) [00:08:53] (03CR) 10Krinkle: [C: 032] Update OOjs to v1.0.9 [oojs/ui] - 10https://gerrit.wikimedia.org/r/123487 (owner: 10Jforrester) [00:11:40] (03Merged) 10jenkins-bot: Update OOjs to v1.0.9 [oojs/ui] - 10https://gerrit.wikimedia.org/r/123487 (owner: 10Jforrester) [00:12:08] (03Merged) 10jenkins-bot: Separate out debug bar for use outside the demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123039 (owner: 10Esanders) [00:12:10] (03Merged) 10jenkins-bot: Update OOjs to v1.0.9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123164 (owner: 10Jforrester) [00:13:08] RoanKattouw: Reopening it:https://bugzilla.wikimedia.org/show_bug.cgi?id=63452 [00:13:55] ryasmeen_: Urgh, checking [00:20:09] RoanKattouw: Check it in this page: http://en.wikipedia.beta.wmflabs.org/wiki/2ndaprilChrome?veaction=edit [00:25:51] Also , RoanKattouw, Is the fix for this bug got merged to Betalabs yet? https://bugzilla.wikimedia.org/show_bug.cgi?id=63154 [00:30:17] Let me see... [00:30:51] (03PS1) 10Catrope: Update VE core submodule to master (8dd6a63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123495 [00:31:45] (03PS8) 10Catrope: Show the debug bar in MW if ve.debug is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123042 (owner: 10Esanders) [00:33:15] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (8dd6a63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123495 (owner: 10Catrope) [00:33:36] (03PS9) 10Catrope: Show the debug bar in MW if ve.debug is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123042 (owner: 10Esanders) [00:33:38] (03PS2) 10Catrope: Update VE core submodule to master (8dd6a63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123495 [00:36:50] (03CR) 10Catrope: [C: 032] Show the debug bar in MW if ve.debug is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123042 (owner: 10Esanders) [00:36:59] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/123495 [00:37:34] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (8dd6a63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123495 (owner: 10Catrope) [00:37:59] James_F: git blame -C -M file [00:38:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (8dd6a63) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123495 (owner: 10Catrope) [00:40:03] (03Merged) 10jenkins-bot: Show the debug bar in MW if ve.debug is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123042 (owner: 10Esanders) [00:40:05] ryasmeen_: That bug fix for 63154 is on its way to beta labs, it should be there soon [00:40:17] Then again last time I looked it was an hour behind so who knows what will actually happen :S [00:40:29] okay [00:51:44] (03PS4) 10Krinkle: Use new OO#initClass method for base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/123120 (owner: 10Esanders) [00:51:58] (03CR) 10Krinkle: [C: 031] Use new OO#initClass method for base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/123120 (owner: 10Esanders) [01:17:02] (03PS1) 10Alex Monk: Give the edit tab
  • closest to the collapsed tabs menu class=collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123503 [10:23:43] if i'm using https://www.mediawiki.org/wiki/Special:ExtensionDistributor/VisualEditor , what do i actually get in relation to https://git.wikimedia.org/branches/mediawiki%2Fextensions%2FVisualEditor ? [10:23:50] if they are directly related at all, that is [10:27:40] ok, extension distributor gets me an older version :) [10:49:41] https://www.mediawiki.org/wiki/Extension:VisualEditor "The latest version of one of the extensions branches" says to click 'snapshot', but there is no such link :) [11:00:17] and so i finally set up visual editor master with 1.22. i get 'create/edit' actions, but clicking them does not open visualeditor (it just opens the page itself) - what could be the reason ? [11:00:24] tried with opera & firefox :) [11:08:58] if anybody has a moment to make a guess why that fails, it's https://www.zabbix.org [12:19:20] Richlv: most of VE devs are in san francisco AFAIK, so highly unlikely they can pay much attention since it's 5.20 am there ;) [12:19:58] Elitre, thanks, i'll make sure to repeat my question in a few hours then :) [12:20:48] I'm wondering why this isn't mentioned in the channel presentation above. [12:36:35] Richlv: you see the "Edit" and "Edit Source" button? [12:40:55] mvolz, yes, both [12:41:11] mvolz, but clicking 'edit' does not seem to do anything at all [12:41:22] that can be observed at https://www.zabbix.org [12:41:29] although one needs an account, hmm [12:42:42] Yeah account creation doesn't seem to be working for me. [12:42:58] it can be pretty slow depending on your server [12:43:17] it'll show a preview for a short time and then the editor will be available [12:43:36] so try clicking on "edit" and then waiting like a good 10 seconds and then seeing if the page is editable maybe? [12:48:43] the dev version has a little progress bar to show you it's loading but the older versions don't have that I think [12:49:34] (03PS6) 10Jagori79: WIP: [Browser test] Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [12:59:50] (03CR) 10Jagori79: "Replying to comment - patch set 5" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [13:37:01] mvolz, sorry for disappearing, got distracted. account creation works if you specify 'real name' - it turned out to be a great spam protection ;) [13:38:50] mvolz, tried to wait for a longer period of time after clicking 'edit', doesn't seem to help - and there should be some progress indicator, right ? [13:39:02] oh, you mentioned that already :) [13:41:45] yeah, nothing opened still [13:45:16] is James_F really around? [13:59:35] Richlv: did you do git submodule update --init when fetching the extension from git? [14:01:02] mvolz, admittedly, i just used https://git.wikimedia.org/zip/?r=mediawiki/extensions/VisualEditor&h=refs/heads/master&format=gz link :) [14:01:06] from https://www.mediawiki.org/wiki/Extension:VisualEditor [14:03:12] hmm, that page says latest version is 0.1.0, mine has 0.0.0 in package.json [14:04:08] Richlv: yeah, that's the issue. That snapshot doesn't contain the submodules, which are basically dependencies that go in the /lib/ folder [14:07:29] mvolz, dang, that link is quite misleading then - thanks. will grab from git directly then [14:08:09] mvolz, not that it's very important, but what about the version number mismatch ? [14:11:43] Richlv: yeah, the extension information box is generated, and the submodule thing pretty much confuses everyone at first [14:12:16] no idea about version number :) [14:13:20] oh, yay. it seems to work now =) [14:52:48] and just got a question from a user - is it possible to use visual editor, then see the source it would save without saving it first ? [14:53:06] sort of switching from ve to source editing, while keeping all the changes [14:55:41] Not as such, but if you go to "save" you can then press "review changes" and that will give you the diff in wikitext [14:56:17] Not sure if that helps though [15:05:44] mvolz, ah, that's something - thanks :) [15:08:30] hmm, could it be that there is no button "continue editing" in the save dialog ? [15:09:58] ah, there's 'X' in the upper right corner. except that it's not visible in opera :) [15:19:35] screenshot and file a bug: https://bugzilla.wikimedia.org/ :) [15:19:57] mvolz, admittedly, most of the toolbar does not appear either ;) [15:30:33] Richlv: you can switch from VE to wikicode without saving, yes. [15:31:54] Richlv: Options menu, [] Switch to source editing (or whatever it's called now.) [15:33:00] Elitre, ah, "3 horizontal lines" icon - but that option does not seem to work :) [15:34:02] Richlv: on your wiki, you mean? it should work on Wikipedias. [15:34:44] Elitre, on my own wiki, yes [15:35:11] mvolz, as you already have an account... if you try to edit https://zabbix.org/wiki/Docs/visual_editor_test , do you also see the link missing in visual editor ? [15:35:49] Richlv: works for me! [15:35:57] Richlv: ok, I don't know what you need to make it work there, but generally speaking that feature is available and working. [15:36:09] Elitre: thanks, I didn't know about that option [15:36:36] mvolz: you're welcome! it's VE's best kept secret :p [15:36:41] mvolz, and if you hit cancel, then 'edit' again ? [15:39:08] Richlv: yeah the option doesn't seem to be working on your site :( [15:41:40] Richlv: might be parsoid related. check node.js logs? [15:44:11] oh, actually, link not working is producing errors... [15:47:24] mvolz, what does this look like ? - http://pastebin.com/dtuSaYZh [15:49:21] "switch to source editing" does not seem to produce any errors in node.js output [15:50:35] ah, but there's javascript error when i try to switch to source editing : http://pastebin.com/Mpzj827d [15:50:50] "Uncaught exception: Error: OO.ui.Tool.onSelect not implemented in this subclass:function VeUiMWEditModeSourceTool(toolGroup,config)" [15:53:34] aha. That second one looks promising. [15:58:35] meaning ? :) [16:02:01] meaning we've reached the limit of my understanding but luckily the big dogs should be around any minute ;) [16:03:40] mvolz, heh, thanks. what about the first one, btw ? :) [16:04:00] 19:03 here, so i'd like to gather as much info as possible :) [16:06:52] A problem with how you wrote the template maybe? Not sure. [16:07:11] As for the latter, that's definitely what's causing the issue with the edit source button. [16:08:04] Looks like an inheritance issue with the JS. I poked around in that file (modules/ve-mw/ui/tools/ve.ui.MWEditModeTool.js) but I don't know enough to debug, sorry :( [16:10:53] mvolz, well, that template seems to work just fine in all other places :) [16:11:24] no, no it's definitely your fault, VE is perfect and bug free in every way! [16:11:36] anyway it seems to work fine :). [16:12:43] I can't seem to replicate the edit source issue unfortunately which makes it hard to debug. Do you know what version JS your server is running? only thing I can think of for the difference but I doubt that's it... [16:13:14] mvolz, js as in node.js ? [16:13:44] that would be node-v0.10.26 [16:17:26] Yeah :( [16:25:53] So I can't say this will fix your problem but my working localhost install is running: { http_parser: '1.0', [16:25:54] node: '0.8.2', [16:25:54] v8: '3.11.10.14', [16:25:54] ares: '1.7.5-DEV', [16:25:54] uv: '0.8', [16:25:54] zlib: '1.2.3', [16:25:55] openssl: '1.0.0f' } [16:26:22] which is all a bit older than yours [16:28:04] heh, distro packages had node.js 0.8-something. i thought i should get the latest one :) [17:08:36] James_F: Hey, are there breaking changes in oojs-ui that we don't know about? Locally our share/embed/download tabs were working but now on beta they're not: http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo?debug=true#mediaviewer/File:Tamme-Lauri%20tamm%20suvep%C3%A4eval.jpg [17:24:44] (03CR) 10Bartosz Dziewoński: "Now that I think about it, this might not be the best idea until VE is actually used for the majority of edits." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123503 (owner: 10Alex Monk) [18:10:55] marktraceur: earlier today there was someone getting oojs-ui related errors as well... does this look anything like the error you're getting? http://pastebin.com/Mpzj827d [18:15:16] mvolz: We aren't getting errors, just not seeing events fired [18:27:09] where are my devs? [18:29:06] Elitre: Metrics prolly [18:31:59] :/ whatever. I'll be back tomorrow I guess. thanks, c u :) [18:48:06] (03PS1) 10Esanders: Listen to close events on window sets to give focus back to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123695 [18:49:18] (03PS2) 10Esanders: Listen to close events on window sets to give focus back to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123695 [19:39:17] James_F: Bother bother bother [19:58:35] Krinkle: on removing $.proxy will this code act as a wrapper ? [19:58:43] ve.bind = ( function() { [19:58:43] return $.bind(); [19:58:43] } ); [20:09:41] 1. as mvolz noted, i'm seeing javascript errors when i try to switch to source editing from ve - any other info i could provide ? - http://pastebin.com/Mpzj827d [20:10:18] 2. i don't see some links (coming from a mw template), and i get errors in node.js output - again, any more debugging i could provide to figure out why so ? - http://pastebin.com/dtuSaYZh [20:11:05] this is ve master from earlier today on mw 1.22; both problems visible on https://www.zabbix.org ; to create an account there, "real name" must be provided ;) [20:11:22] i'd be glad to provide any other info needed, although not for long today - 23:11 here :) [20:31:21] tonythomas: Whats the bug report again? [20:43:59] (03CR) 10Catrope: [WIP^n] getOffset rewrite (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [21:24:00] (03CR) 10Alex Monk: "Why do you think that?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123503 (owner: 10Alex Monk) [21:33:34] Hm [21:34:09] Just clicked "Switch to source editing" (with no changes to VE), nothing happens and "Uncaught Error: OO.ui.Tool.onSelect not implemented in this subclass:function VeUiMWEditModeSourceTool(toolGroup,config){ve.ui.MWEditModeTool.call(this, toolGroup,config);}" shows up in console [21:34:57] Oh dear. [21:36:11] James_F: We're seeing breaking changes too, did you get my message earlier? [21:36:51] marktraceur: No? I'm still in back-to-back meetings since 09:30, I'm hoping to have lunch in an hour. Did you speak to an engineer? [21:37:09] Argh. [21:37:12] * marktraceur does [21:37:40] marktraceur: It's a Thursday with Metrics. I never have time to answer questions on Thursdays, and it's always the time that the deploy goes wrong. Sorry. :-( [21:38:00] edsanders, RoanKattouw_away, TrevorP|Away, I'm seeing oojs-ui breaking on betalabs and on mediawiki.org; did something change this week to make MenuWidget act differently? [21:38:26] marktraceur: No, /talk/ to them. This is what having an office is for. [21:38:35] None of them are at their desks [21:38:47] In that case, they're sure as hell not on IRC. [21:38:56] Where are they? [21:39:14] Also, no, no breaking changes should have gone out; we would have told you. [21:39:29] I'd have though [21:39:30] t [21:39:35] But it's happened before I think [21:39:47] Once. By mistake. And we said we were sorry. :-( [21:40:13] I know, but still [21:40:27] * marktraceur attempts to debug [21:41:28] I `git reset --hard` to a commit from one week ago, no error when clicking "Switch to source editing" now [21:43:04] marktraceur: git log origin/wmf/1.23wmf20..origin/wmf/1.23wmf21 resources/oojs-ui [21:43:15] marktraceur: One breaking change, but only for toolbars (which you don't use). [21:43:26] Hm. [21:43:49] marktraceur: Maybe " 897b30f Return null in Element#getDocument "? [21:44:00] Maybe. [21:44:04] * marktraceur will look [21:48:20] Just clicked "Switch to source editing" (with no changes to VE), nothing happens and "Uncaught Error: OO.ui.Tool.onSelect [21:48:23] YEAH [21:48:26] that's the same i'm getting ;) [21:48:37] :-( [21:48:45] at least i'm no the only one [21:49:00] well, i also have that problem with some links not showing up in ve :) [21:49:08] I happen to be working on a completely separate issue with that feature at the moment [21:50:16] for the record (again, sorry) - my log on javascript error : [21:50:20] 1. as mvolz noted, i'm seeing javascript errors when i try to switch to source editing from ve - any other info i could provide ? - http://pastebin.com/Mpzj827d [21:53:14] (03PS5) 10Trevor Parscal: Use new OO#initClass method for base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/123120 (owner: 10Esanders) [21:56:12] Richlv: James_F I can repro the js error on beta labs when clicking 'Switch to source editing'. Do you need a bz ticket for that? [21:56:50] chrismcmalunch, i guess the question about bugzilla is for James_F :) [21:56:59] SUre. [21:57:02] Richlv: yes [21:58:02] James_F: OK. Also my test for this clearly needs some maintenance. It passes but it should not. [21:58:13] chrismcmalunch: :-( [21:58:18] chrismcmalunch: Such is life. [21:58:38] so maybe i should just create a bugreport about my second issue, too (instead of whining here :) ) ? [21:58:40] 2. i don't see some links (coming from a mw template), and i get errors in node.js output - again, any more debugging i could provide to figure out why so ? - http://pastebin.com/dtuSaYZh [21:58:41] James_F: c'est la vie indeed. I didn't write the test, but I think I reviewed it at the time. I'll hack on it. [21:59:25] TrevorParscal, Krinkle|detached, edsanders - I'm seeing OOjs-UI failing to fire 'select' events in master [21:59:28] Affecting production now [21:59:40] marktraceur: wmf21 only? [21:59:46] I think so [22:00:17] James_F: Yeah [22:00:29] marktraceur: OK, well that's something, at least. [22:00:34] *nod* [22:00:44] * James_F hopes to escape meetings of doom soon. [22:09:39] (03PS1) 10Alex Monk: Fix order of start and base timestamps when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123795 [22:10:46] Okay, now I've finally got my head around that, I guess I'll look into the error me and Richlv ran into [22:10:55] Krenair, thanks :) [22:26:18] Richlv, I think this is to blame: https://gerrit.wikimedia.org/r/#/c/121514/2/modules/ve-mw/ui/tools/ve.ui.MWEditModeTool.js [22:27:11] Adding that function back in makes it work again [22:29:01] TrevorParscal, ^ [22:29:06] Krenair, somewhat funnily, that page does not work in opera :) [22:29:24] (03CR) 10Alex Monk: "Broke things. See inline comment" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 (owner: 10Trevor Parscal) [22:30:21] * marktraceur notes that, in-person, we've found a bug and a fix is on the way [22:31:55] Not for that bug, but yes. [22:33:06] (03CR) 10Jforrester: "Caused bug 63503." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 (owner: 10Trevor Parscal) [22:34:41] marktraceur, which bug is that ? [22:34:58] Richlv: The selecting-doesn't-select bug [22:35:38] That's bug 63502 and maybe a different number too if Multimedia have filed one. [22:40:34] (03CR) 10Jforrester: "Caused bug 63502 in VE's link inspector (and probably dozens of other placess), and in MediaViewer." [oojs/ui] - 10https://gerrit.wikimedia.org/r/121281 (owner: 10Trevor Parscal) [23:03:56] marktraceur, cool, thanks. i just have to find somebody to bug about links-not-showing-up-bug :) [23:20:55] (03PS7) 10Jagori79: WIP: [Browser test] Scenario added for long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [23:28:39] (03PS1) 10Trevor Parscal: Add pressed state to option widgets and use instead of initializing selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 [23:29:08] (03PS2) 10Trevor Parscal: Add pressed state to option widgets and use instead of initializing items [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 [23:31:11] edsanders: ^^^ [23:37:30] (03PS3) 10Jforrester: Add pressed state to option widgets and use instead of initializing items [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (owner: 10Trevor Parscal) [23:45:44] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/121514/2/modules/ve-mw/ui/tools/ve.ui.MWEditModeTool.js [23:49:27] (03CR) 10Esanders: [C: 04-1] Add pressed state to option widgets and use instead of initializing items (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (owner: 10Trevor Parscal) [23:50:20] TrevorParscal, getting rid of that function relies on MWEditModeTool inheriting from ve.ui.Tool. But it inherits from OO.ui.Tool [23:51:57] (03PS4) 10Jforrester: Add pressed state to option widgets and use instead of initializing items [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (owner: 10Trevor Parscal) [23:52:03] (03CR) 10Jforrester: Add pressed state to option widgets and use instead of initializing items (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (owner: 10Trevor Parscal) [23:54:51] TrevorParscal, additionally, I think the code in MWEditAction is wrong - there is no getTarget method on a DesktopSurface, the original code had a toolbar object and ran getTarget on that [23:55:02] (03CR) 10Esanders: [C: 032] Add pressed state to option widgets and use instead of initializing items [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (owner: 10Trevor Parscal) [23:55:19] (03PS1) 10Trevor Parscal: Revert edit mode tool's onSelect method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123806 [23:55:30] (03Merged) 10jenkins-bot: Add pressed state to option widgets and use instead of initializing items [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (owner: 10Trevor Parscal) [23:56:34] Krenair: you are absolutely right, I screwed that up when converting things en-masse to use commands [23:57:10] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (eaa1b7f06d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123808 [23:57:26] (03PS2) 10Trevor Parscal: Revert edit mode tool's onSelect method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123806 [23:57:29] (03CR) 10Jforrester: [C: 032] "Pull through." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123808 (owner: 10Jforrester) [23:57:35] there, that should fix it properly [23:58:43] (03PS3) 10Alex Monk: Revert edit mode tool's onSelect method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123806 (owner: 10Trevor Parscal)