[00:00:24] TrevorParscal, shouldn't you be doing this.setActive( false ); still too? [00:00:24] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (eaa1b7f06d) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123808 (owner: 10Jforrester) [00:01:38] probably... [00:01:40] yes [00:02:01] (03PS4) 10Trevor Parscal: Revert edit mode tool's onSelect method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123806 [00:02:11] I'm guessing you missed it because your new ve.ui.Tool.prototype.onSelect function handles that for commands with deactivateOnSelect [00:02:37] Welcome to VE, where it's not important if you ever get it right, so long as you keep pretending you know what you are doing [00:04:01] :) [00:04:06] you missed Bug: 63503 from ps4 [00:04:30] (03PS5) 10Alex Monk: Revert edit mode tool's onSelect method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123806 (owner: 10Trevor Parscal) [00:04:53] thanks [00:05:22] (03CR) 10Alex Monk: [C: 032] "(Last PS was just a commit message change to include bug)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123806 (owner: 10Trevor Parscal) [00:07:30] (03Merged) 10jenkins-bot: Revert edit mode tool's onSelect method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123806 (owner: 10Trevor Parscal) [00:07:51] (03CR) 10Alex Monk: Update VE core submodule to master (c5f4f78) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121514 (owner: 10Trevor Parscal) [00:13:09] TrevorParscal: I think there's still an issue on manual selectItem() calls [00:13:14] Because our initial load won't work [00:14:01] i.e. on opening the dialog, and on each tab, we selectItem() the default [00:14:02] are you using initializeSelection ? [00:14:09] Uhhh maybe not. [00:14:19] I guess someone needs to deploy this fix at some point. I don't really know how that works. [00:15:07] Krenair: Krinkle probably will [00:15:36] Yep, I'm waiting for someone to confirm the fix in beta labs and for James_F / greg-g to approve a window [00:15:40] greg-g: Krenair [00:16:09] TrevorParscal: Hm, yeah, we are [00:16:17] We're also using selectItem() though [00:16:36] Krinkle: I'mma gonna wait until marktraceur and TrevorParscal figure out what's up with MediaViewer [00:17:29] I guess the embed tab doesn't use initializeSelection, but download does, and neither of them are working [00:17:45] marktraceur: if you use initializeSelection it won't emit the select event, it's sort of evil [00:17:52] it should be used with great care [00:18:01] just use selectItem instead [00:18:02] TrevorParscal: Well, both are using selectItem() [00:18:06] So... [00:18:16] Krinkle, it's rather easy to confirm that this fixed the issue on beta labs [00:18:36] because if you use initializeSelection then when you use selectItem it doesn't emit a select event because nothing has changed [00:18:48] that's ok, just don't use initializeSelection and you will be in good shape [00:19:18] if you aren't using initializeSelection anywhere, thats a different issue [00:19:20] But embed also doesn't work, and doesn't use initialize... [00:19:28] can I see it live, or should I come over to you? [00:21:04] greg-g, send out everything at once? makes sense. Do you get pinged when anyone says 'deploy' by the way? [00:21:31] Krenair: no :) [00:21:51] Krenair: I was just talking about this in -operations and mark said he was chatting about it in here :) [00:21:51] oh ok, you just happened to appear at that moment :) [00:22:59] * greg-g is in too many channels [00:23:23] OK, there's an issue but it's with our use of oojssui [00:23:26] oojs-ui [00:23:41] So you could merge and deploy and go [00:23:46] And we can follow up tomorrow or Monday [00:23:47] kk [00:24:04] go forth, Krinkle :) [00:24:30] * greg-g goes home [00:55:46] Krinkle: https://gerrit.wikimedia.org/r/#/c/123814/ [01:05:19] (03CR) 10Krinkle: "couple of improvement suggestions for later." (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/123803 (owner: 10Trevor Parscal) [01:05:28] TrevorParscal: edsanders: ^^ [01:35:49] OK...sigh [01:35:51] "TypeError: this.embedSwitch.initializeSelection is not a function" [object Error] [01:36:06] this.embedSwitch is an OoUiButtonSelectWidget [01:36:14] Which obviously has initializeSelection [01:36:56] ....huh [01:37:00] Maybe I misspelled it? [01:37:28] Weird [01:37:36] Oh, derp [01:55:15] Turns out "intializeSelection" was the right way to write it. [01:55:17] Of course. [01:56:50] (03PS1) 10Trevor Parscal: Turns out, intialize ain't even a word! [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123823 [02:00:11] (03PS1) 10Trevor Parscal: Fix some intialize typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/123824 [02:00:14] (03CR) 10jenkins-bot: [V: 04-1] Fix some intialize typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/123824 (owner: 10Trevor Parscal) [02:01:34] (03PS2) 10Jforrester: [BREAKING CHANGE] Fix some intialize -> initialize typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/123824 (owner: 10Trevor Parscal) [02:01:56] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Fix some intialize -> initialize typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/123824 (owner: 10Trevor Parscal) [02:04:13] (03PS3) 10Jforrester: [BREAKING CHANGE] Fix some intialize -> initialize typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/123824 (owner: 10Trevor Parscal) [02:04:43] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Fix some intialize -> initialize typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/123824 (owner: 10Trevor Parscal) [02:05:25] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Fix some intialize -> initialize typos [oojs/ui] - 10https://gerrit.wikimedia.org/r/123824 (owner: 10Trevor Parscal) [02:06:35] (03CR) 10Esanders: [WIP^3] Work with Scalable model in images (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [02:10:57] (03PS1) 10Jforrester: Revert edit mode tool's onSelect method [extensions/VisualEditor] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/123825 [02:15:01] (03CR) 10Jforrester: [C: 04-1] "This should be done at the same time as the new OOjs UI pull-through." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123823 (owner: 10Trevor Parscal) [02:22:23] er is there a problem with gerrit? [02:22:32] hi btw [05:14:10] (03PS14) 10Mooeypoo: [WIP] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [05:14:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [08:24:52] (03CR) 10Siebrand: Support new column-width and list-style attributes to Cite's (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (owner: 10Alex Monk) [14:32:01] (03PS4) 10Alex Monk: Support new column-width and list-style attributes to Cite's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 [14:43:47] yay, switching to source from ve now works [14:44:36] but still a lot of problems with opera. should i try to report them ? :) [14:44:39] (on linux) [16:24:21] (03CR) 10Esanders: [C: 04-1] [WIP] Refactor Scalable functionality (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [16:38:26] (03PS1) 10Esanders: Fix debug bar margins [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123877 [16:44:10] Richlv: That'd be very helpful, yes please! [17:04:16] (03PS15) 10Mooeypoo: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [17:21:52] (03PS2) 10Trevor Parscal: Turns out, intialize ain't even a word! [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123823 [17:28:51] TrevorParscal, shouldn't there be a commit to VisualEditor/VisualEditor or something to get the oojs-ui change this relies on? [17:33:15] Krenair: for the typo? [17:33:46] yeah, it should be pulled through together, maybe James_F could make one of those for me? [17:35:43] :-P [17:35:44] But yes. [17:39:45] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (98570355f6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123883 [17:40:58] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (98570355f6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123883 (owner: 10Jforrester) [17:42:24] (03PS1) 10Jforrester: Update VE core submodule to master (7f97fd8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123884 [17:46:31] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (7f97fd8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123884 (owner: 10Jforrester) [17:51:20] (03PS2) 10Esanders: 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 [17:51:22] (03PS3) 10Esanders: Listen to close events on window sets to give focus back to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123695 [17:51:24] (03PS1) 10Esanders: Set content directionality on the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123887 [17:54:28] (03PS1) 10Esanders: Use new model directionality in model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 [17:54:30] (03PS1) 10Esanders: WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 [17:56:43] (03PS6) 10Jforrester: Use new OO#initClass method for base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/123120 (owner: 10Esanders) [17:57:35] (03CR) 10Jforrester: [C: 032] Use new OO#initClass method for base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/123120 (owner: 10Esanders) [17:58:03] (03Merged) 10jenkins-bot: Use new OO#initClass method for base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/123120 (owner: 10Esanders) [18:06:35] (03PS1) 10Catrope: Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123891 [18:06:37] (03PS1) 10Catrope: Adjust range manually in isolateAndUnwrap() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123892 [18:07:11] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Examplary qqq, Alex. Nice work." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123093 (owner: 10Alex Monk) [18:11:25] RoanKattouw: James_F: Makes me sad: https://de.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-navigation-popups.js&diff=101897668&oldid=101419243 [18:11:49] Krinkle: Can't we just have the site segfault IE8 users? [18:12:04] We can in fact [18:12:16] Sounds like a plan. [18:12:37] http://www.howtogeek.com/howto/33394/how-to-crash-any-version-of-internet-explorer-with-simple-html/ [18:13:02] http://crashie8.com/ http://www.crashie.com/ etc. [18:13:07] there's one for every version so far [18:13:08] :) [18:44:41] (03PS1) 10Esanders: Inpsectors should only hide on blur if the selection has been cleared [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123896 [18:46:20] (03PS2) 10Esanders: Inspectors should only hide on blur if the selection has been cleared [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123896 [18:50:34] (03CR) 10Catrope: [C: 032] Inspectors should only hide on blur if the selection has been cleared [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123896 (owner: 10Esanders) [18:51:32] (03PS1) 10Cmcmahon: [browser test] maintenance, locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123898 [18:51:59] (03CR) 10Cmcmahon: [C: 032] [browser test] maintenance, locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123898 (owner: 10Cmcmahon) [18:52:40] (03CR) 10Catrope: [C: 04-1] "As James said, this needs to be combined with pulling in fixes in OOJS-UI." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123823 (owner: 10Trevor Parscal) [19:02:18] (03CR) 10Catrope: [C: 032] Fix order of start and base timestamps when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123795 (owner: 10Alex Monk) [19:02:52] (03CR) 10Catrope: [C: 032] Give the edit tab
  • closest to the collapsed tabs menu class=collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123503 (owner: 10Alex Monk) [19:03:31] TrevorParscal: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Closure [19:06:13] (03CR) 10Catrope: [C: 032] Fix debug bar margins [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123877 (owner: 10Esanders) [19:10:29] (03CR) 10Esanders: "Click on 'default' size should probably reset the width/height back to the numerical values of the default size." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [19:10:58] (03CR) 10Esanders: "Also this need a rebase" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [19:26:57] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (98570355f6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123883 (owner: 10Jforrester) [19:28:46] (03Merged) 10jenkins-bot: Update VE core submodule to master (7f97fd8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123884 (owner: 10Jforrester) [19:28:53] (03Merged) 10jenkins-bot: Inspectors should only hide on blur if the selection has been cleared [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123896 (owner: 10Esanders) [19:28:55] (03Merged) 10jenkins-bot: Fix debug bar margins [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123877 (owner: 10Esanders) [19:29:40] (03CR) 10Esanders: [C: 04-1] Refactor Scalable functionality (0329 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [19:30:24] (03CR) 10jenkins-bot: [V: 04-1] WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [19:31:08] (03Merged) 10jenkins-bot: [browser test] maintenance, locator changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123898 (owner: 10Cmcmahon) [19:31:59] (03Merged) 10jenkins-bot: Fix order of start and base timestamps when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123795 (owner: 10Alex Monk) [19:32:22] (03Merged) 10jenkins-bot: Give the edit tab
  • closest to the collapsed tabs menu class=collapsible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123503 (owner: 10Alex Monk) [19:33:56] (03PS1) 10Jforrester: Update VE core submodule to 58c01b5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123904 [19:38:24] (03CR) 10Krinkle: [C: 032] Update VE core submodule to 58c01b5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123904 (owner: 10Jforrester) [19:40:05] James_F: https://en.wikipedia.org/wiki/%25s [19:43:32] (03Merged) 10jenkins-bot: Update VE core submodule to 58c01b5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123904 (owner: 10Jforrester) [19:44:30] (03PS3) 10Jforrester: Update VE core submodule to 33e6dcd [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123823 (owner: 10Trevor Parscal) [19:59:44] Argument 1 passed to VisualEditorHooks::onInputBoxGetCreatePageActionParamName() must be an instance of string, string given [19:59:49] must be instance of string, string given [19:59:53] sigh, PHP... [20:00:42] wtf [20:00:45] yep. [20:01:55] (03PS17) 10Mooeypoo: [WIP^3] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [20:02:41] Can't type hint for scalar types (int, string, resource, trait, etc.) [20:03:23] (03CR) 10jenkins-bot: [V: 04-1] [WIP^3] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [20:06:27] (03CR) 10Mooeypoo: "Re comment on patchset 16 - The default size changes between the different types, so this behavior (changing to default values for the giv" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [20:06:51] edsanders, you want to discuss the dir css dm/ce/ui things? [20:10:16] hm, I'm getting an error when I run grunt [20:10:17] Running "jscs:src" (jscs) task [20:10:17] Fatal error: The config file .jscs.json was not found! [20:11:07] (03PS18) 10Mooeypoo: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [20:12:24] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [20:32:31] npm install? [20:32:52] mooeypoo, we're going to keep the code but move it [20:33:33] what code? [20:33:39] move where? [20:33:49] I'm confused. Are we talking about npm? [20:42:54] James_F, btw, thanks for pushing me to study.. just got the results of Exam #1 (morning).. I got 96, and the average is 65. [20:44:33] mooeypoo: I just got the same jscs error and per Timo's instructions, running npm install fixed it for me [20:44:56] How many times do I need to tell you RoanKattouw, there is always money in the banana stand! [20:45:03] Apparently he moved .jscs.json to .jscsrc because that's where the new version of jscs looks, but until such time as you update your version of jscs that's going to break (obviously). npm install updates it [20:45:49] mooeypoo: Yay. :-) [20:48:03] (03PS1) 10Krinkle: grunt: Run grunt-build as part of grunt-test and grunt-watch [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124002 [20:48:49] (03PS1) 10Krinkle: grunt: Run grunt-build as part of grunt-test and grunt-watch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124004 [20:49:45] RoanKattouw, awesome, thanks [20:54:02] (03PS1) 10Esanders: Apply annotations to partially annotated selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124006 [20:54:43] (03CR) 10Catrope: [C: 032] grunt: Run grunt-build as part of grunt-test and grunt-watch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124004 (owner: 10Krinkle) [20:55:52] (03Merged) 10jenkins-bot: grunt: Run grunt-build as part of grunt-test and grunt-watch [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124004 (owner: 10Krinkle) [20:56:06] (03CR) 10Catrope: [C: 032] grunt: Run grunt-build as part of grunt-test and grunt-watch [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124002 (owner: 10Krinkle) [20:56:42] RoanKattouw: mooeypoo: You might want to create a bash alias that runs 'npm install &&' before grunt (or npm test) whatever you like. So you'd have alias foo='npm install && grunt' or foo='npm install && npm test' [20:57:17] is there a difference between running 'grunt' and 'npm test' ? [20:57:25] or are these the same action [20:57:26] (03Merged) 10jenkins-bot: grunt: Run grunt-build as part of grunt-test and grunt-watch [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124002 (owner: 10Krinkle) [21:01:58] RoanKattouw: http://git-scm.com/docs/git-status [21:02:07] (porcelain) [21:02:12] Yeah just swa [21:02:14] sane exit status code and stable output [21:11:14] Krinkle, is there a difference between 'npm test' and 'grunt' or are these just aliases of one another? [21:23:51] mooeypoo: npm test runs the package.json#scripts.test command [21:24:00] which is 'grunt test' [21:24:15] 'grunt' runs 'grunt default' as defined in Gruntfile.js#registerTask-default [21:24:24] which is ['test'] [21:24:36] Though the latter isn't always the case, depends on the repository [21:25:07] so I'd generally recommend running npm test so you only rely on defaults provided by the local repository and not by the defaults of grunt or whatever. [21:25:40] Krinkle, wsn't there also something with grunt build ? [21:26:11] Krinkle|detached, I'm trying to see if I should do 'grunt' as a general case or 'npm test' [21:30:07] (03PS16) 10Mooeypoo: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [21:31:14] (03CR) 10jenkins-bot: [V: 04-1] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:09:50] (03PS1) 10Jforrester: Switch over to grunt-banana-checker now that it's a real boy [oojs/ui] - 10https://gerrit.wikimedia.org/r/124021 [22:24:02] (03PS1) 10Jforrester: Use new banana checker as a linter to avoid lacking qqq messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124023 [22:33:31] mooeypoo: npm-test is the general one that will work more widely where 'grunt' can sometimes be too specific or too generic. [22:33:37] (semantic intent) [22:34:26] James_F: https://www.npmjs.org/package/grunt-banana-checker has been refreshed since [22:34:27] lists mw now [22:34:29] (03PS1) 10Jforrester: Update VE core submodule to master (d6feda2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 [22:34:30] lists me now* [22:34:34] Krinkle: I saw. [22:34:45] Krinkle: You are mw and you know it. :-) [22:35:25] (03CR) 10Krinkle: [C: 032] Switch over to grunt-banana-checker now that it's a real boy [oojs/ui] - 10https://gerrit.wikimedia.org/r/124021 (owner: 10Jforrester) [22:35:47] (03CR) 10Krinkle: [C: 032] Use new banana checker as a linter to avoid lacking qqq messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124023 (owner: 10Jforrester) [22:35:52] Krinkle: https://gerrit.wikimedia.org/r/#/c/123782/ [22:35:54] :-) [22:35:56] (03Merged) 10jenkins-bot: Switch over to grunt-banana-checker now that it's a real boy [oojs/ui] - 10https://gerrit.wikimedia.org/r/124021 (owner: 10Jforrester) [22:36:11] (03CR) 10Krinkle: [C: 031] Update VE core submodule to master (d6feda2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 (owner: 10Jforrester) [22:36:22] James_F: Yeah, I'm on that one. Asynchronous [22:36:28] stack.pop() is now back at that one [22:37:11] Krinkle: Good. :-) [22:37:22] (03Merged) 10jenkins-bot: Use new banana checker as a linter to avoid lacking qqq messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124023 (owner: 10Jforrester) [23:00:53] (03PS1) 10Esanders: Debug bar fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124031 [23:22:26] (03CR) 10Esanders: [C: 04-1] Refactor Scalable functionality (038 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [23:23:00] (03CR) 10Catrope: [C: 032] Debug bar fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124031 (owner: 10Esanders) [23:24:03] (03Merged) 10jenkins-bot: Debug bar fixes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124031 (owner: 10Esanders) [23:24:05] (03CR) 10Esanders: Refactor Scalable functionality (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [23:27:02] (03PS4) 10Catrope: [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 [23:28:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] getOffset rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope)