[00:04:57] Hi there, just trying to run a private instance on an intranet wiki, I have no issues with connecting to Parsoid and I can edit documents successfully, however when I try to 'Insert Media' the box returns empty and no search yield any results. Checking the browser the only call to the api made after hitting 'Insert media' is to 'api.php?format=json&action=query&meta=filerepoinfo' which returns successful. I'm fully updated [00:04:57] with VE and Parsoid. [01:10:38] dmotd, weird, it works for me. does the call to filerepoinfo return anything? [01:14:57] Krenair, ya it does. the json is as follows: {"query":{"repos":[{"name":"local","displayname":null,"rootUrl":"/wiki/images","local":true}]}} [01:15:50] Krenair, the mediawiki is on a site structured 'domain/wiki' [01:17:57] Krenair, I can manually query the api with 'api.php?action=query&list=allimages&format=json' and that returns valid images. [01:30:46] dmotd, I took a quick look at the search requests done on enwiki, seems it's based off the values of scriptDirUrl in the filerepoinfo response... [01:31:42] which you don't appear to get :/ [01:32:32] dmotd, there's a comment in the media search widget that says: "If we don't have either 'apiurl' or 'scriptDirUrl' the source is invalid, and we will skip it" [01:32:48] So that is not a valid source as far as this code is concerned [01:32:52] What version of MediaWiki are you running? [01:52:58] Krenair, mediawiki 1.22.2 [01:58:18] Krenair, in LocalSettings.php: $wgScriptPath = "/wiki"; [02:03:53] Krenair, also I have no problems adding media manually with [[File:image.ext]] [02:14:45] dmotd, I will look into your issue a bit more later. Have to go now, sorry [02:15:43] Krenair, no issue, will stick around. [02:15:53] Krenair, thanks. [06:30:01] (03CR) 10Siebrand: [C: 032] "Per discussion on https://gerrit.wikimedia.org/r/#/c/124133/." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124279 (owner: 10Jforrester) [07:49:15] (03CR) 10Bartosz Dziewoński: Move VisualEditor disabling from now-scrapped preferences section (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124279 (owner: 10Jforrester) [08:48:08] (03Merged) 10jenkins-bot: Move VisualEditor disabling from now-scrapped preferences section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124279 (owner: 10Jforrester) [09:40:49] (03CR) 10Siebrand: Move VisualEditor disabling from now-scrapped preferences section (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124279 (owner: 10Jforrester) [09:46:22] (03PS1) 10Siebrand: Move VisualEditor disabling from now-scrapped preferences section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124297 [09:47:08] (03CR) 10Siebrand: "Followed-up in https://gerrit.wikimedia.org/r/#/c/124297/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124279 (owner: 10Jforrester) [09:57:36] (03CR) 10Bartosz Dziewoński: [C: 032] "I hope these are really all now. :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124297 (owner: 10Siebrand) [09:58:50] (03Merged) 10jenkins-bot: Move VisualEditor disabling from now-scrapped preferences section [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124297 (owner: 10Siebrand) [10:03:54] (03CR) 10Siebrand: "I did a search in PhpStorm of all the code I have cloned (core master, most Gerrit extensions but a tiny few), and found no more occurrenc" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124297 (owner: 10Siebrand) [10:48:37] should i report http://pastebin.com/dtuSaYZh for visual editor or parsoid ? [11:00:13] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar) [11:00:15] (03PS9) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 [11:03:01] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/36739 (owner: 10Hashar) [12:28:42] ok, reported it for parsoid :) [12:28:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=63613 [14:33:30] (03CR) 10Zfilipin: WIP: [Browser test] Scenario added for long Target Links (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [14:37:41] in firefox, i have to click on the text on buttons (like saving/cancelling), i can't use whole button area. works ok in opera. known issue ? [14:57:14] Richlv: have you checked bugzilla? I recall something like that, but it was, like, last July! [15:01:17] Elitre, not yet, i reported one problem in ve, one in parsoid and got lazy ;) [15:02:02] I see, I see! will check that for you ASAP then - but only this time! [15:04:16] Richlv: can't reproduce. skin and OS? [15:06:18] Elitre, well, it seems to be reproducible here :) - https://www.zabbix.org/wiki/Visual_editor_test [15:06:55] well, the actual testpage is https://www.zabbix.org/wiki/Docs/visual_editor_test , but it should not matgter that much [15:06:57] matter [15:08:15] well, I can't test there, and it doesn't seem to happen on Wikipedias, that's why I was asking which skin and OS you're using. [15:09:08] os - linux; skin - mw one ? if so, i think it should be the default vector one [15:09:35] oh, interesting. doesn't happen anymore... [15:09:52] maybe it's related to some sequence or similar [15:21:58] Hello. [15:25:02] * Elitre waves at her PM. [15:25:45] * Richlv reports a bunch of problems for ve with opera :) [15:32:31] (03CR) 10Zfilipin: [C: 04-1] WIP: [Browser test] Scenario added for long Target Links (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [15:35:23] James_F: I can askz question? [15:36:13] * Elitre https://encrypted-tbn1.gstatic.com/images?q=tbn:ANd9GcQRWNzyVSe_dUKY3vRHWhgAzXh1jey5A6E7jJVvJA5tF1OAdXWUTA [15:46:16] Elitre: Sure! [15:46:50] James_F: was it the pic? because I can make sure to bookmark it :) [15:46:56] * James_F grins. [15:47:03] No, it was me returning to my desk. :-) [15:47:54] * Elitre grins [15:48:35] https://www.mediawiki.org/wiki/Special:MessageGroupStats/agg-VisualEditor#sortable:3=desc shows a different number of messages depending on the language. why is that? [15:49:22] Never seen that page on MW.org before. What's it meant to contain? [15:50:33] all translatable messages evah for VE, I /think/? [15:50:59] Oh, MW-hosted translated pages. [15:51:02] Hmm. [15:52:20] No idea. Maybe the i18n team might know how it's meant to work? [15:52:47] * Elitre switches tab and drags the cat to i18n [15:54:25] notice that if i18n doesn't know, I'll kill it. [15:58:34] * James_F nods. [16:04:20] luckily i18n avoided bloodshed. [16:18:31] Yay. [16:20:39] (03CR) 10Divec: [C: 031] "Only not plustwoing because I haven't actually tested it yet :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [16:21:49] (03CR) 10Divec: "(Also because it says WIP^n (and the "BIOHAZARD DO NOT TOUCH" is a subtle clue too))" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/121563 (owner: 10Catrope) [16:41:13] (03CR) 10Catrope: [C: 032] Re-sync generated files output from `grunt` [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124068 (owner: 10Jforrester) [16:41:53] (03CR) 10Catrope: [C: 032] Use new banana checker as a linter to avoid lacking qqq messages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124069 (owner: 10Jforrester) [16:43:03] (03Merged) 10jenkins-bot: Re-sync generated files output from `grunt` [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124068 (owner: 10Jforrester) [16:44:02] (03Merged) 10jenkins-bot: Use new banana checker as a linter to avoid lacking qqq messages [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124069 (owner: 10Jforrester) [17:20:44] For RoanKattouw_away or whoever else wants to see Bad Things Happening: https://en.wikipedia.org/w/index.php?title=User:Tamravidhir&curid=36507398&diff=603142575&oldid=603142295 [17:28:55] whatami: Alright, I've cleaned the page back up ( https://en.wikipedia.org/w/index.php?title=User%3ATamravidhir&diff=603178393&oldid=603142859 ) but if you edit it again ( https://en.wikipedia.org/w/index.php?title=User:Tamravidhir&veaction=edit ) you'll see that you get the corruption warning in the save dialog and if you preview the diff you'll see the same garbage [17:28:56] (03PS5) 10Esanders: 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 [17:28:58] (03PS5) 10Esanders: Listen to close events on window sets to give focus back to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123695 [17:29:00] (03PS3) 10Esanders: Use #isContentOffset instead of slug detection for word expansion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124038 [17:29:02] (03PS3) 10Esanders: Set content directionality on the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123887 [17:29:04] So VE is definitely doing something bad [17:29:04] (03PS2) 10Esanders: WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 [17:29:06] (03PS2) 10Esanders: Use new model directionality in model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 [17:30:47] (03CR) 10jenkins-bot: [V: 04-1] WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [17:33:59] RoanKattouw: isn't that the "batman" bug the Parsoid guys are working on? [17:34:07] Batman? [17:34:13] nananana.... [17:34:13] Are you talking about NaNxNaNpx? [17:34:16] yep. [17:34:27] (03PS1) 10Esanders: Revert "Revert "Detect document focus properly and allow null selection in model"" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [17:34:44] I love that they're calling that the Batman bug [17:35:03] For those that don't get the reference, that's a great excuse to watch https://www.destroyallsoftware.com/talks/wat [17:35:13] (if you do get the reference, it's also a great excuse to watch that video :) ) [17:35:29] (03PS1) 10Jforrester: core: Avoid an IE8 bug causing a fatal error when loaded on that platform [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 [17:35:47] (should I ask them?) [17:36:21] i guess modifying tables (rows/columns) is not supported yet, right ? [17:37:24] Richlv: Correct. :-( [17:37:42] edsanders|away: https://gerrit.wikimedia.org/r/#/c/123463/ [17:39:46] RoanKattouw, do you want me to file a bug for that, or can I safely assume that it's the Batman bug/already filed? [17:41:41] (03PS2) 10Jforrester: core: Avoid an IE8 bug causing a fatal error when loaded on that platform [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 [17:43:18] The Batman bug is known, I don't know where it's filed [17:43:39] (03PS2) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [17:43:41] RoanKattouw: that's why I suggested asking them :p [17:43:43] However, we generally have to do something weird to trigger the Batman bug [17:44:05] In this case, what we're doing is caused by Parsoid giving us a very weird image [17:44:35] Of the "go home Parsoid, you're drunk" variety [17:45:01] James_F: I forgot to remind everyone that I will be stepping out for a couple hours today for a dental appointment. 2-4pm [17:46:09] In the standup that is [17:46:24] Complete with null DSRs, which generally means Parsoid is saying "I don't know where I am, I'm lost" [17:46:46] James_F, thanks for confirmation - i can stop trying to do so ;) [17:47:01] I'm gonna try and write a minimal test case, but it's probably as easy as having a block image inside of a [17:47:02] rmoen: Kk. Have… 'fun'. [17:48:17] James_F: I'm sure it will be a good old time. :) [17:49:57] (03PS1) 10Cmcmahon: [browser test] Fix edit mode test. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124362 [18:07:35] (03Abandoned) 10Esanders: Set content directionality on the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123485 (owner: 10Esanders) [18:10:08] James_F: http://i.imgur.com/QDY32zJ.png [18:10:18] (03CR) 10Esanders: Set content directionality on the model (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123887 (owner: 10Esanders) [18:13:19] whatami: Filed https://bugzilla.wikimedia.org/show_bug.cgi?id=63642 against Parsoid [18:14:58] Elitre: You might care too --^^ [18:24:05] whatami, Elitre: Basically what's going on there is Parsoid is doing something extremely unexpected (and forbidden by their own rules), so we get confused and do weird things, and in response to that they do even weirder things. It's kind of like sending your 1040 tax form to the DMV and them sending you back a driver's license that claims you were born on the 30th of February 1568 and are... [18:24:07] ...12 feet 17 inches tall [18:24:22] (That's the least lame analogy I could come up with, I swear :P ) [18:25:04] So "Bad things happen when editing complicated pages" [18:25:11] thanks Roan. leaving now. /me waves [18:25:58] whatami: Yeah, but I haven't found a pattern that describes in what way a page has to be complicated to be affected by this bug [18:26:13] I've attempted to recreate parts of that page's structure and not triggered the bug [18:26:19] RoanKattouw, would you like to have a vague bug filed, just to keep track of it? [18:26:52] Against VE? I think we're fine with the Parsoid bug [18:27:22] Do you have the Parsoid bug number? I could add the diff to it. [18:27:36] Or I can leave it all in your capable hands, and not worry about it any longer. [18:27:36] VE doing strange things when Parsoid gives us stuff they've promised to never give us isn't really a bug in VE [18:27:52] whatami: https://bugzilla.wikimedia.org/show_bug.cgi?id=63642 is the Parsoid bug, it has the diff linked in my comment somewhere I think [18:28:04] whatami: But please do stalk that bug and make sure it gets some love [18:28:25] My hands are fairly capable when it comes to filing bugs but much less so when it comes to staying on top of them [18:28:38] (Being in the office only 3 days a week doesn't help with that either) [18:28:55] I can nag you about it, if that would help. [18:29:14] It would [18:29:34] I am here on Mondays, Wednesdays and Fridays [18:29:57] (03PS6) 10Esanders: 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 [18:29:59] (03PS4) 10Esanders: Use #isContentOffset instead of slug detection for word expansion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124038 [18:30:00] Okay. I'll make a note to remind you about it on Friday. [18:30:01] (03PS4) 10Esanders: Set content directionality on the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123887 [18:30:03] (03PS3) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [18:30:08] (03PS3) 10Esanders: WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 [18:30:10] (03PS3) 10Esanders: Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 [18:30:34] whatami: Thanks [18:30:35] (03CR) 10jenkins-bot: [V: 04-1] WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [18:30:40] I've gone and poked the Parsoid people in their channel [18:30:42] (03CR) 10jenkins-bot: [V: 04-1] Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [18:31:52] https://en.wikipedia.org/wiki/Power_symbol?veaction=edit#Definitions this table looks very silly in edit mode. [18:33:11] MatmaRex: Hmm that seems to be because of the block slugs before and after the images [18:33:19] There are places for you to insert the cursor before and after each image [18:33:39] And those end up taking up vertical space :( [18:34:00] (screenshot: http://i.imgur.com/XDC8l0Z.png) [18:34:32] i don't mean just that it's spread vertically, but it apparently has border and cellspacing for some reason [18:35:43] Yeah that too [18:35:51] I don't know why that is, I was looking at the dimensions first [18:37:52] [18:37:55] Is what's in the HTML [18:38:29] This makes me strongly suspect there's border, cellpadding and cellspacing in the Parsoid HTML [18:38:51] Hmm, or not [18:39:01] Ugh, oh right [18:39:06] I forgot about this [18:39:29] MatmaRex: VisualEditor adds border, cellspacing and cellpadding to rendered tables, presumably to make them more visible [18:39:56] huh. [18:40:25] i suppose wikimedians like to abuse tables, so this makes sense sort of, but… cellpadding=5 and cellspacing=5? [18:40:32] See the constructor in ve.ce.TableNode.js [18:40:35] Yeah, I know [18:40:43] I blame.... I don't know. Someone else :P [18:41:11] James_F: Thoughts re forced border=1 cellpadding=5 cellspacing=5 on tables in VE rendering? [18:41:34] RoanKattouw: i say kill the spacing and padding, and only show the border on hover? like the slugs background? [18:41:58] Yeah, maybe? [18:42:04] Sounds vaguely reasonable to me [18:46:49] (03PS2) 10Cmcmahon: [browser test] Fix edit mode test. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124362 [18:47:19] RoanKattouw: WFM. Or just silently add class=wikitable? [18:51:02] (03PS3) 10Cmcmahon: [browser test] Fix edit mode test. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124362 [19:10:26] (03PS1) 10Trevor Parscal: [BREAKING CHANGE] Death to initializeSelection [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 [19:11:44] (03PS2) 10Catrope: [BREAKING CHANGE] Death to initializeSelection [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 (owner: 10Trevor Parscal) [19:12:04] ryasmeen: What's the bug number for "if I click on the first item in a menu, nothing happens"? [19:13:15] RoanKattouw: it's this one: https://bugzilla.wikimedia.org/show_bug.cgi?id=63544 [19:13:26] Thanks [19:13:40] (03PS3) 10Catrope: [BREAKING CHANGE] Death to initializeSelection [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 (owner: 10Trevor Parscal) [19:15:44] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Death to initializeSelection (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 (owner: 10Trevor Parscal) [19:15:52] (03PS1) 10Trevor Parscal: Additional initializeSelection methodicde [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124382 [19:26:17] (03PS4) 10Jforrester: [BREAKING CHANGE] Death to initializeSelection [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 (owner: 10Trevor Parscal) [19:26:20] (03CR) 10Jforrester: [BREAKING CHANGE] Death to initializeSelection (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 (owner: 10Trevor Parscal) [21:05:24] James_F, jdlrobson told me there's a bug in the compact personal bar related to EL. can you point me to it? [21:07:48] jgonera: Bug 63535. [21:07:56] thanks [21:07:58] jgonera: I couldn't reprodice, though. [21:08:01] *u [21:32:00] RoanKattouw, about https://bugzilla.wikimedia.org/show_bug.cgi?id=63651 : If it's supposed to be fixed, and the commit status is "merged", then [21:32:16] it should be working at Beta Labs, right? Because it's not, [21:35:48] Hmm, hold on [21:35:59] Yeah I think that should be working on beta labs [21:36:01] Lemme test that locally [21:36:28] (03PS1) 10Catrope: Clean up lots of minor things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124465 [21:36:42] I'm testing it here: http://en.wikipedia.beta.wmflabs.org/w/index.php?oldid=86043#Hieroglyphics [21:43:17] whatami: Argh, you're right, it's broken [21:43:43] (03CR) 10Esanders: [C: 032] [BREAKING CHANGE] Death to initializeSelection [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 (owner: 10Trevor Parscal) [21:44:20] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Death to initializeSelection [oojs/ui] - 10https://gerrit.wikimedia.org/r/124381 (owner: 10Trevor Parscal) [21:45:50] (03PS1) 10Catrope: Actually actually fix double-clicking on hieroglyphics nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124469 [21:52:46] (03CR) 10Catrope: [C: 032] Additional initializeSelection methodicde [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124382 (owner: 10Trevor Parscal) [21:54:06] (03Merged) 10jenkins-bot: Additional initializeSelection methodicde [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124382 (owner: 10Trevor Parscal) [22:20:02] James_F: https://gerrit.wikimedia.org/r/#/c/124477/ [22:24:03] (03CR) 10Esanders: [C: 04-1] "Still seeing http://i.imgur.com/HJ8DCgI.png" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [22:25:52] (03CR) 10Trevor Parscal: 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 (owner: 10Esanders) [22:29:08] (03PS7) 10Esanders: 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 [22:29:10] (03PS4) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [22:43:41] (03CR) 10Trevor Parscal: [C: 032] 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 (owner: 10Esanders) [22:46:50] (03PS1) 10Catrope: Additional initializeSelection methodicde [extensions/VisualEditor] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124484 [22:48:09] (03CR) 10Trevor Parscal: [C: 032] Use #isContentOffset instead of slug detection for word expansion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124038 (owner: 10Esanders) [22:48:43] (03CR) 10Trevor Parscal: [C: 032] Set content directionality on the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123887 (owner: 10Esanders) [22:49:34] (03CR) 10Trevor Parscal: [C: 032] Listen to close events on window sets to give focus back to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123695 (owner: 10Esanders) [22:52:07] (03Merged) 10jenkins-bot: Listen to close events on window sets to give focus back to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123695 (owner: 10Esanders) [22:52:10] (03Merged) 10jenkins-bot: Set content directionality on the model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123887 (owner: 10Esanders) [22:52:12] (03Merged) 10jenkins-bot: Use #isContentOffset instead of slug detection for word expansion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124038 (owner: 10Esanders) [22:52:13] (03Merged) 10jenkins-bot: 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 (owner: 10Esanders) [22:53:45] (03PS1) 10Catrope: Adjust loop counters in word break detection when removing item [VisualEditor/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124488 [22:54:52] (03PS4) 10Esanders: WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 [22:54:54] (03PS19) 10Esanders: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [22:54:56] (03PS4) 10Esanders: Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 [22:56:45] (03CR) 10jenkins-bot: [V: 04-1] WIP Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [22:57:02] (03CR) 10jenkins-bot: [V: 04-1] Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [22:57:20] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [23:03:13] (03PS5) 10Esanders: Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 [23:04:29] (03CR) 10jenkins-bot: [V: 04-1] Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [23:04:42] (03CR) 10Esanders: "** BREAKING CHANGE **" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123486 (owner: 10Esanders) [23:10:57] (03PS1) 10Catrope: Add excludeInsertion to translateRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124491 [23:10:59] (03PS1) 10Catrope: Add excludeInsertion property to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 [23:11:01] (03PS1) 10Catrope: Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124493 [23:14:01] (03CR) 10jenkins-bot: [V: 04-1] Add excludeInsertion property to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 (owner: 10Catrope) [23:14:03] (03CR) 10jenkins-bot: [V: 04-1] Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124493 (owner: 10Catrope) [23:20:46] (03CR) 10Catrope: [C: 032] Adjust loop counters in word break detection when removing item [VisualEditor/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124488 (owner: 10Catrope) [23:22:18] (03CR) 10Esanders: Refactor Scalable functionality (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [23:22:42] (03Merged) 10jenkins-bot: Adjust loop counters in word break detection when removing item [VisualEditor/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124488 (owner: 10Catrope) [23:26:48] (03PS1) 10Catrope: Update VE core submodule to wmf20 for cherry-pick [extensions/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124495 [23:27:27] Krinkle: https://gerrit.wikimedia.org/r/124494 is that the best way to test for VE? [23:27:28] (03CR) 10Catrope: [C: 032] Update VE core submodule to wmf20 for cherry-pick [extensions/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124495 (owner: 10Catrope) [23:28:09] (03CR) 10Catrope: [C: 032] Revert edit mode tool's onSelect method [extensions/VisualEditor] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/123825 (owner: 10Jforrester) [23:29:08] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to wmf20 for cherry-pick [extensions/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124495 (owner: 10Catrope) [23:29:24] (03CR) 10Catrope: [C: 032] Additional initializeSelection methodicde [extensions/VisualEditor] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124484 (owner: 10Catrope) [23:30:41] ^ cc rmoen TrevorP|Away [23:30:45] (03Merged) 10jenkins-bot: Revert edit mode tool's onSelect method [extensions/VisualEditor] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/123825 (owner: 10Jforrester) [23:30:49] (03Merged) 10jenkins-bot: Additional initializeSelection methodicde [extensions/VisualEditor] (wmf/1.23wmf21) - 10https://gerrit.wikimedia.org/r/124484 (owner: 10Catrope) [23:37:06] jdlrobson: checking [23:37:51] thanks Krinkle should be a really quick review - patch is tiny [23:37:53] jdlrobson: Yes, though it does exclude one condition: userPrefEnabled [23:37:55] (03CR) 10Catrope: [V: 032] Update VE core submodule to wmf20 for cherry-pick [extensions/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124495 (owner: 10Catrope) [23:38:08] Krinkle: could you base the required test there too? [23:38:33] jdlrobson: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js#L356-L431 [23:38:34] although James_F I know it was still up in the air about whether this was going to launch via user preference on mobile [23:38:45] (since we have the switcher) [23:38:59] Yeah, you probably won't be using the same preferences? [23:39:03] Or at all [23:39:13] yeh we're not sure right now [23:39:19] that's kenanwang's call [23:39:32] (03CR) 10Catrope: [C: 032 V: 032] Update VE core submodule to wmf20 for cherry-pick [extensions/VisualEditor] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/124495 (owner: 10Catrope) [23:39:35] isAvailable asserts browser support, skin support, title qualification (namespace being whitelisted and wikipage content model being wikitext for Parsoid) [23:39:38] we have a few stories that track the various use cases [23:39:38] jdlrobson: [23:40:42] it does *not* assert userEnabled which asserts wgConf/VisualEditor/disableForAnons, and the 'visualeditor-betatempdisable' user preference [23:42:09] Krinkle: my gut says we should think about this closer to the launch - i think theo is just interested in the 3rd party use case here (right now it just explodes) [23:42:30] jdlrobson: Use mw.libs.ve && mw.libs.ve.isAvailable [23:45:21] thanks Krinkle much appreciated [23:48:47] (03CR) 10Esanders: [C: 04-1] Add excludeInsertion property to SurfaceFragment (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 (owner: 10Catrope)