[00:38:52] http://cl.ly/image/0B3b233A0U2p [02:05:27] mooeypoo, I'm going to fix up the comments in the Scalalbe stuff as we've inadvertently made it a block on core getting merged [02:05:33] also going to do a bit of refactoring [02:11:11] (03PS17) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [02:11:13] (03CR) 10jenkins-bot: [V: 04-1] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [02:11:45] (03PS20) 10Esanders: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [02:13:07] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [02:56:56] (03PS2) 10Catrope: Add excludeInsertion property to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 [02:57:02] (03PS2) 10Catrope: Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124493 [03:33:54] (03Abandoned) 10Catrope: Adjust range manually in isolateAndUnwrap() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123892 (owner: 10Catrope) [03:38:21] edsanders, oh, ok, cool, thanks [03:38:37] I have a couple of questions about the language change though [03:40:41] edsanders, so, the document direction is coming from DM now, I see. But what happens to language blocks? One of the reason it made sense to check CE is because dir= and lang= are inherited; so if you check the current node's direction in the ce, you'll always get the actual value even if it is inline or inside a new block. [03:53:06] (03PS18) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [03:53:08] (03CR) 10jenkins-bot: [V: 04-1] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [03:53:12] (03PS21) 10Esanders: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [03:53:51] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [03:54:50] (03CR) 10Mooeypoo: "One of the reason it made sense to check CE is because dir= and lang= are inherited; so if you check the current node's direction in the C" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [03:59:50] (03CR) 10Mooeypoo: [C: 04-1] Use new model directionality in MW (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [13:28:03] huh. looks like parsoid in node.js eats a huge amount of memory... [15:17:25] (03PS1) 10Gilles: Avoid error when a select event reaches an InlineMenuWidget and its corresponding MenuItemWidget no longer exists [oojs/ui] - 10https://gerrit.wikimedia.org/r/124611 [15:26:50] (03PS8) 10Alex Monk: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 [15:27:20] (03PS9) 10Alex Monk: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 [15:28:44] (03CR) 10jenkins-bot: [V: 04-1] Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [15:28:55] (03CR) 10Alex Monk: "Removing -2, although I didn't end up rethinking this and just tried to fix the issues I could find" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [15:31:43] (03CR) 10Mooeypoo: "Where did the API 'original dimensions' call go?" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [15:39:14] (03PS10) 10Alex Monk: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 [16:38:10] Guest77094: You look a lot like a friend of mine [17:17:29] TrevorParscal, edsanders when you're both back -- let me know if you want to schedule a short whaddup-with-scay-lable-stuffs meeting. [17:17:34] And when. [17:18:25] yeah - i think it's semi-urgent because aparently I've merged a few things that have nessecitated this being sorted before we can pull anything through to vemw [17:24:52] ah, that's why the urgency. Ok, yeah, I'm also working on the model which depends on it, so it all puts a bit of a halt on the rest of that work too (Though that's not as urgent) [17:26:05] TrevorParscal, I'm available whenever you guys are. Hangout will probably be best [17:27:04] TrevorParscal, I'm going to make myself lunch -- can you msg me on hangouts with whenever you guys are good to talk? I'm free all day today (no classes) so it's up to whatever works for you [17:32:32] (03CR) 10Zfilipin: [C: 031] [browser test] Fix edit mode test. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124362 (owner: 10Cmcmahon) [18:09:17] Is there something that changed in oojs recently? I'm seeing issues with subclasses not inheriting methods in prototypes. [18:09:33] Not on beta, for some reason, but locally on latest mediawiki and latest MMV [18:28:25] I would poke people but I guess most of the maintainers aren't around? [18:36:20] * marktraceur says the magic word James_F for good measure [18:36:35] ? [18:36:40] Oh. [18:36:45] You mean OOjs or OOjs UI? [18:36:48] OOJS. [18:37:01] It's happening in a class that doesn't use OOJSUI [18:38:17] marktraceur: https://github.com/wikimedia/oojs/blob/master/History.md <- maybe somehow the first entry (initClass) broke something for you? [18:38:27] marktraceur: OOjs isn't meant to have any breaking changes at all ever. [18:38:59] I don't think so? [18:39:12] We aren't using static methods in this class [18:39:17] Very odd. [18:39:18] It's a prototype method that's not working right [18:39:29] The v1.0.9 release is the only change in the past two weeks. [18:39:37] Hm. [18:39:42] And that's the only non-documentation/tests/etc. change in it. [18:39:44] Well, and other classes seem to be working fine [18:39:48] :-( [18:40:16] * marktraceur tries going back to before 1.09 [18:40:35] No, still broken there [18:40:37] Maybe it's our fault [18:40:38] Sec [18:41:03] Oh, I bet it's ori's fault [18:41:10] Hm, nope [18:50:45] Ignore me [18:50:49] It's apparently working fine now [18:56:01] marktraceur: *hugs* [18:56:21] *nod* [18:56:33] It's that kind of day I guess [18:56:42] * marktraceur looks forward to forgetting life and doing karaoke instead [19:15:30] (03PS1) 10Trevor Parscal: Limit the number of initially visible parameters in the parameter search widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 [19:22:39] (03PS19) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [19:23:47] (03CR) 10jenkins-bot: [V: 04-1] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [19:28:37] (03CR) 10Trevor Parscal: [C: 032] Actually actually fix double-clicking on hieroglyphics nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124469 (owner: 10Catrope) [19:29:55] (03Merged) 10jenkins-bot: Actually actually fix double-clicking on hieroglyphics nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124469 (owner: 10Catrope) [19:30:30] (03PS2) 10Trevor Parscal: Don't assume selection is of an item, sometimes it's null [oojs/ui] - 10https://gerrit.wikimedia.org/r/124611 (owner: 10Gilles) [19:30:36] (03CR) 10Trevor Parscal: [C: 032] Don't assume selection is of an item, sometimes it's null [oojs/ui] - 10https://gerrit.wikimedia.org/r/124611 (owner: 10Gilles) [19:31:06] (03Merged) 10jenkins-bot: Don't assume selection is of an item, sometimes it's null [oojs/ui] - 10https://gerrit.wikimedia.org/r/124611 (owner: 10Gilles) [19:37:44] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 (owner: 10Trevor Parscal) [19:40:41] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (70932872ba) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124664 [20:01:36] (03PS8) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [20:02:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [20:54:06] RoanKattouw_away: TrevorParscal we're currently blocked on an mw.api patch to core. Krinkle had been chiming in, but there's been no activity for a while. can you guys help us move forward on this? https://gerrit.wikimedia.org/r/#/c/116037/ [20:54:17] anyone feeling up to reviewing this https://gerrit.wikimedia.org/r/#/c/124662/ ?? [20:54:27] awjr: lookin [20:55:17] thanks TrevorParscal [20:56:52] Krinkle: are you around? I see that you had some comments on this patch [20:57:07] I personally think this is something you are better suited to approve [20:57:19] TrevorParscal: checking [21:02:12] (03PS2) 10Krinkle: Limit the number of initially visible parameters in the parameter search widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 (owner: 10Trevor Parscal) [21:13:36] (03PS5) 10Esanders: Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 [21:14:07] (03CR) 10jenkins-bot: [V: 04-1] Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [21:14:40] (03PS6) 10Esanders: Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 [21:15:08] (03CR) 10jenkins-bot: [V: 04-1] Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [21:33:05] (03PS20) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [21:34:09] (03CR) 10jenkins-bot: [V: 04-1] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [21:45:53] (03PS21) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:50:06] TrevorParscal, RoanKattouw_away this should start getting some review love: https://gerrit.wikimedia.org/r/#/c/119435/20 [22:58:23] are you guys done changing it? [23:12:25] (03PS1) 10Alex Monk: Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 [23:13:51] (03CR) 10jenkins-bot: [V: 04-1] Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [23:26:55] (03PS2) 10Alex Monk: Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775