[00:47:35] edsanders, yo, did you end up adding the type consideration to the image node? or should I? [00:48:02] edsanders, I don't want to step on code-toes, but I suddenly realized I may have misunderstood whether you picked it up or was I supposed to [00:49:00] I haven't done it yet if you want to do it before tomorrow [00:50:33] yeah I am just hoping I will follow what you had in mind. [06:16:26] (03PS22) 10Mooeypoo: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [06:17:02] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [06:21:04] (03PS22) 10Mooeypoo: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 [09:04:25] (03CR) 10Jagori79: "Submitting reply to comment on patch set 7" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [09:08:36] (03CR) 10Jagori79: "Noted the feedback on patch 5.Thanks." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [09:24:31] (03CR) 10Zfilipin: WIP: [Browser test] Scenario added for long Target Links (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [09:50:15] (03PS8) 10Jagori79: WIP: [Browser test] Scenario added for long Target Links and added few whitespaces in bottom existing scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [09:51:15] (03CR) 10Jagori79: WIP: [Browser test] Scenario added for long Target Links and added few whitespaces in bottom existing scenario (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [09:51:50] (03PS9) 10Jagori79: WIP: [Browser test] Scenario added for long Target Links and added few whitespaces in bottom existing scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [10:00:32] (03PS10) 10Jagori79: WIP: [Browser test] Scenario added for long Target Links and added few white-spaces in bottom existing scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [10:01:10] (03PS11) 10Jagori79: WIP: [Browser test] Scenario added for long Target Links and added few white-spaces in bottom existing scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [12:02:07] (03CR) 10Siebrand: Use updated tab labels on description pages for files in foreign repos (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [12:15:18] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 (owner: 10Trevor Parscal) [14:08:08] (03CR) 10Cmcmahon: [C: 032] "merge after review" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124362 (owner: 10Cmcmahon) [14:09:28] (03Merged) 10jenkins-bot: [browser test] Fix edit mode test. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124362 (owner: 10Cmcmahon) [15:21:13] Hello all. We’ve just started integrating the VisualEditor into our existing site. We’re at a bit of a loss; how do we extract the contents of our VisualEditor document when our users want to save their changes? [15:24:59] nummi: I'm not sure I understand the question! There's a save page button at the top right hand corner? [15:26:25] Not at the moment. We don’t have a save button in our UI. [15:26:58] We’d like to be able to invoke the save function/action from javascript if possible. [15:27:44] Could you post a screenshot? Are you writing your own UI? [15:29:35] http://i.imgur.com/VDwmzUS.png [15:30:11] That was the result of this: [15:30:11] target = new ve.init.sa.Target( [15:30:20] container, [15:30:20] ve.createDocumentFromHtml(html) [15:30:20] ) [15:30:52] we pretty much took the js from the demo [15:37:31] Sorry, lost connection. :(. [15:41:36] Is there a reason you're not using the packaged UI? [16:53:53] nummi: ve.dm.converter.getDomFromModel( target.surface.getModel().getDocument() ) returns an HTMLDocument [16:54:13] nummi: Are you integrating with something that's not MediaWiki? If so, we're very interested in your experiences and happy to help [16:54:32] Also, this reminds me, I suppose Target really needs a getSurface() method [16:56:07] (03CR) 10Alex Monk: Use updated tab labels on description pages for files in foreign repos (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [17:10:16] mvolz: We weren’t consciously trying to use something atypical. We had been using CKEditor and we used the code from the VisualEditor demo to spike out the initial functionality. [17:10:37] sorry for the long silence we were at lunch :) [17:11:28] (03CR) 10Krinkle: Use updated tab labels on description pages for files in foreign repos (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [17:11:30] RoanKattouw: yeah, we’re trying to integrate VisualEditor into a non-MediaWiki project [17:12:55] The api documentation is pretty complete, but the surface area is so large it can be hard to know where to get started. [17:18:20] (03CR) 10Siebrand: [C: 04-1] "Adding -1 because of the button label discussion." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [17:35:57] (03PS6) 10Esanders: Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 [17:36:36] (03CR) 10jenkins-bot: [V: 04-1] Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [17:37:13] mooeypoo, when you're in ve-mw, run git submodule udpate to make sure you have the appropriate core version for that branch (not master) [17:37:43] (03PS7) 10Esanders: Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 [17:38:10] (03CR) 10jenkins-bot: [V: 04-1] Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [17:44:17] (03CR) 10Catrope: [C: 04-1] "Hasn't initializeSelection() been removed completely now?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123823 (owner: 10Trevor Parscal) [17:45:02] RoanKattouw: Yes, but that was made 6 days ago. [17:45:14] RoanKattouw: If it had been merged at the time… [17:45:25] (03Abandoned) 10Jforrester: Update VE core submodule to 33e6dcd [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123823 (owner: 10Trevor Parscal) [17:46:38] (03PS2) 10Jforrester: Update VE core submodule to master (4964b82) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 [17:47:30] looks like we rebased the core changes on master which is a problem [17:49:35] (03CR) 10Jforrester: "Needs I0fae3e5ff and I6e99db601a to be merged into this pull through. Fun." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 (owner: 10Jforrester) [17:49:38] edsanders, and then pull the ve-core dependent commit, no? [17:50:39] also, edsanders I added what we talked about to the image node, but I didn't edit the media edit dialog to fully work with it -- because the "image model" commit completely rewrites the dialog anyways. [17:52:35] edsanders, okay, thanks! it works now, and I foudn a rather silly typo on my end. Fixing now. [17:55:42] After IRL conversation with Ed, I'm now going to temporarily revert things in VE core to make our dependency graph acyclic [17:55:56] He's convinced me that the current cyclic dependency graph is impossible to resolve [17:55:57] (03PS23) 10Mooeypoo: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [17:56:35] cyclic dependency graph? That sounds like ti could be modeled with a physical equation from field theory. [17:56:36] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [17:58:52] (03PS24) 10Esanders: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [17:59:19] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [17:59:48] mooeypoo, onAttributeChange isn't called on initialisation [17:59:59] so the thumbnail restrictions still aren't set on load [18:00:08] (03CR) 10Alex Monk: Use updated tab labels on description pages for files in foreign repos (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [18:00:21] oh, foo. You're right. [18:00:43] I'm fixing it up [18:01:50] make sure to download PS24 first [18:03:07] (03PS1) 10Catrope: Revert "'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear();" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124890 [18:03:15] (03CR) 10Catrope: [C: 032] Revert "'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear();" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124890 (owner: 10Catrope) [18:04:26] (03Merged) 10jenkins-bot: Revert "'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear();" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124890 (owner: 10Catrope) [18:07:14] edsanders, crap. Okay. Redoing. [18:07:16] (03CR) 10Alex Monk: Use updated tab labels on description pages for files in foreign repos (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [18:08:51] (03PS3) 10Catrope: Update VE core submodule to master (7cd2605) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 (owner: 10Jforrester) [18:11:44] (03PS1) 10Jforrester: [BREAKING CHANGE] 'The great ' + getRandom(classList) + ' rewrite of ' + new Date().getFullYear(); (reprise) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124893 [18:12:29] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (70932872ba) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124664 [18:14:07] (03PS5) 10Jforrester: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [18:16:10] (03PS7) 10Catrope: Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [18:17:12] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (70932872ba) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124664 (owner: 10Jforrester) [18:17:31] (03PS25) 10Mooeypoo: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [18:17:32] edsanders, ^^ [18:17:58] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [18:18:11] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (70932872ba) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124664 (owner: 10Jforrester) [18:20:44] (03PS4) 10Catrope: Update VE core submodule to master (35c09bf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 (owner: 10Jforrester) [18:21:28] (03PS8) 10Catrope: Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [18:22:57] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (35c09bf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 (owner: 10Jforrester) [18:24:23] (03Merged) 10jenkins-bot: Update VE core submodule to master (35c09bf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124026 (owner: 10Jforrester) [18:26:06] (03CR) 10Catrope: [C: 032] Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [18:27:30] (03Merged) 10jenkins-bot: Use new model directionality in MW [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123889 (owner: 10Esanders) [18:36:10] (03PS23) 10Catrope: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [18:59:15] mooeypoo, looks good [18:59:22] edsanders, \o/ [18:59:24] can you rename toType to type [18:59:29] as we don't have a fromType [18:59:39] oh, sure. [19:00:48] (03PS2) 10Jforrester: [BREAKING CHANGE] Pass fragments, not surfaces, to windows (reprise) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124893 [19:03:00] (03PS26) 10Mooeypoo: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [19:03:11] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [19:06:15] (03PS1) 10Esanders: Remove grey background from disabled MenuToolgrop in apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/124911 [19:07:25] Krinkle: Hey is that standalone dialog demo viewable somewhere? [19:16:44] rmoen: there's a [WIP] patch in gerrit under my name, unfinished though [19:16:46] still [19:16:53] Krinkle: Cool, ty [19:21:52] (03PS6) 10Jforrester: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [19:25:16] RoanKattouw: is there anyway to strip out the classes VisualEditor applies to the document? Right now we’re using a regex on the result we get from ve.dm.converter.getDomFromModel() [19:25:19] (03PS1) 10Esanders: Convert language name to lower case when looking for i18n file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124915 [19:25:34] nummi: What do you mean "classes VE applies to the document"? [19:25:56] Also, why are you using a regex if what you're getting back is an HTML DOM? [19:26:28] (03CR) 10Catrope: [C: 04-1] Refactor Scalable functionality (0316 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [19:26:44]

Lorem ipsum dolor sit amet

[19:26:59] nummi: Ahm, that's almost certainly not what you're getting back from getDomFromModel() [19:27:00] we haven’t _actually_ stripped them out yet. [19:27:27] class="ve-ce-branchNode" only appears in the editable surface, not in the getDomFromModel() result [19:29:28] var doc = ve.dm.converter.getDomFromModel(target.surface.getModel().getDocument()); [19:29:29] hmmm. [19:29:55] where we initialized target earlier via ve.init.sa.Target() [19:30:21] So if you look at e.g. doc.body.outerHTML you should see stuff without those classes [19:31:28] unfortunately we still see them. [19:31:35] Even in doc? [19:32:01] I mean, they'll appear in the browser, and they'll appear if you're extracting the contents through some other clandestine way [19:32:54] we’re calling that method in the console at this point. it seems we must be doing something wrong. [19:33:10] Can you show me a screenshot of things going wrong? [19:33:14] Or, even better, a link to a demo? [19:35:23] http://i.imgur.com/joAwb4i.png [19:37:11] sorry we can’t give you something live [19:37:40] Whoaaaaaa [19:37:43] That should *not* be happening [19:37:52] Unless somehow those classes were already there [19:38:01] Can you show me how the target is initialized? [19:38:02] OH!!! [19:38:09] you’re right, I think. [19:38:18] Those class attributes were already there? [19:38:20] we proabably persisted some bad data. [19:38:34] Because you either dirtied it with previous buggy code, or initialized the target twice? [19:38:51] yes. now we feel dumb. [19:38:54] :) [19:38:54] (03CR) 10Divec: [C: 04-1] Convert language name to lower case when looking for i18n file (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124915 (owner: 10Esanders) [19:38:59] one sec. [19:40:07] ugh. You were absolutely correct. [19:40:12] Thank you! [19:42:30] edsanders: https://bugzilla.mozilla.org/show_bug.cgi?id=889335 [19:45:28] aww, you guys are no fun, someone changed my 'scay-lable' to 'scalable' [19:45:57] (03CR) 10Esanders: Refactor Scalable functionality (0315 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [19:46:38] edsanders: one more, http://gu.illau.me/posts/the-problem-of-user-language-lists-in-javascript/ [19:47:50] (03CR) 10Catrope: [C: 04-1] "Looks fine, just needs accurate docs" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 (owner: 10Trevor Parscal) [19:48:10] (03PS24) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [19:48:17] aaa [19:48:40] edsanders, er, are you fixing stuff in there? I started to, but I'll stop if you're working on this commit [19:48:57] I am [19:48:59] have [19:49:14] oh, ok, I saw RoanKattouw's comments and started fixing stuff up [19:49:16] I'll stop, then [19:49:50] mooeypoo: Sorry for the lack of communication [19:49:54] (03CR) 10jenkins-bot: [V: 04-1] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [19:49:58] no problems, just making sure [19:50:04] Ed is sitting next to me and was responding to my comments before I'd even submitted them [19:50:13] good thing I didn't just push (was ready to when I saw ed's comments) :D [19:50:25] oh, ok, so I'm not touching this commit at all [19:50:29] letting you guys fix it up [19:50:37] I'll go back to the image model [19:50:38] Cool thanks [19:51:12] (03PS1) 10Trevor Parscal: Make field labels appear disabled in sync with the field [oojs/ui] - 10https://gerrit.wikimedia.org/r/124989 [19:55:13] (03CR) 10Catrope: [C: 04-1] Make field labels appear disabled in sync with the field (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/124989 (owner: 10Trevor Parscal) [19:56:09] (03PS3) 10Trevor Parscal: Limit the number of initially visible parameters in the parameter search widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 [19:57:38] (03CR) 10Catrope: [C: 032] Limit the number of initially visible parameters in the parameter search widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 (owner: 10Trevor Parscal) [19:58:23] (03PS4) 10Jforrester: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:58:33] (03PS2) 10Trevor Parscal: Make field labels appear disabled in sync with the field [oojs/ui] - 10https://gerrit.wikimedia.org/r/124989 [19:58:35] (03CR) 10Jforrester: "PS4 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:58:43] RoanKattouw: 117658 [20:11:06] (03PS1) 10Trevor Parscal: Prevent context flashing on window resize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124998 [20:14:05] (03CR) 10Catrope: [C: 032] Prevent context flashing on window resize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124998 (owner: 10Trevor Parscal) [20:56:39] James_F|Away, https://bugzilla.wikimedia.org/show_bug.cgi?id=61861 - I think you mean we need to render the redirect as a node that displays like a MW redirect page, right? [21:56:54] (03CR) 10Catrope: [C: 04-1] Refactor Scalable functionality (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:04:29] (03CR) 10Esanders: Refactor Scalable functionality (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:04:34] (03PS25) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:13:00] (03PS26) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:23:26] RoanKattouw: re-review plz https://gerrit.wikimedia.org/r/#/c/124989/ [22:25:13] (03CR) 10Catrope: [C: 032] Make field labels appear disabled in sync with the field [oojs/ui] - 10https://gerrit.wikimedia.org/r/124989 (owner: 10Trevor Parscal) [22:35:05] (03CR) 10Catrope: [C: 04-1] Refactor Scalable functionality (0310 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [22:39:49] (03CR) 10Alex Monk: "Caused bug 63739 ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118357 (owner: 10Krinkle) [22:44:57] Krinkle, around? [22:45:04] Not now [22:45:07] ok [22:52:36] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/125017/ [22:53:32] (03CR) 10Catrope: [C: 04-1] Work with Scalable model in images (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [22:55:33] ryasmeen: What's the bug number for the math inspector thing? [22:55:55] https://bugzilla.wikimedia.org/show_bug.cgi?id=63541 [22:56:46] Thanks [23:03:42] Krenair: Re. bug 61861, yes, we should render the redirect as a node in view mode when returning to read mode from VE if needed. [23:04:16] (03PS1) 10Esanders: Fix covering annotations logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125019 [23:04:41] (03CR) 10Krinkle: [C: 032] "(re+2)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 (owner: 10Trevor Parscal) [23:04:46] (03CR) 10Trevor Parscal: [C: 032] Remove grey background from disabled MenuToolgrop in apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/124911 (owner: 10Esanders) [23:04:59] (03CR) 10Trevor Parscal: [C: 032] Fix covering annotations logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125019 (owner: 10Esanders) [23:05:47] (03PS27) 10Catrope: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [23:06:01] (03Merged) 10jenkins-bot: Remove grey background from disabled MenuToolgrop in apex [oojs/ui] - 10https://gerrit.wikimedia.org/r/124911 (owner: 10Esanders) [23:06:14] (03Merged) 10jenkins-bot: Limit the number of initially visible parameters in the parameter search widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124662 (owner: 10Trevor Parscal) [23:06:54] (03Merged) 10jenkins-bot: Fix covering annotations logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125019 (owner: 10Esanders) [23:07:41] (03CR) 10Catrope: [C: 032] Make field labels appear disabled in sync with the field [oojs/ui] - 10https://gerrit.wikimedia.org/r/124989 (owner: 10Trevor Parscal) [23:07:42] James_F, in view mode when returning to read mode from VE? Now I'm just more confused :/ [23:08:05] (03Merged) 10jenkins-bot: Make field labels appear disabled in sync with the field [oojs/ui] - 10https://gerrit.wikimedia.org/r/124989 (owner: 10Trevor Parscal) [23:09:03] Krenair: When on a page's read mode, click edit into VE. Then blank the page and change the page to be a redirect (Options > Redirect…). Save. Observe entirely blank simulated 'read' page, without a placeholder for the redirect-ness. [23:10:15] (03PS2) 10Krinkle: Prevent context flashing on window resize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124998 (owner: 10Trevor Parscal) [23:10:36] (03CR) 10Krinkle: [C: 032] Prevent context flashing on window resize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124998 (owner: 10Trevor Parscal) [23:11:37] (03Merged) 10jenkins-bot: Prevent context flashing on window resize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124998 (owner: 10Trevor Parscal) [23:12:02] James_F, simulated 'read' page being VisualEditor? [23:13:09] Okay, I think I understand. [23:13:24] Krenair: HI [23:13:31] Krenair: Yeah the result of ?veaction=edit && save. [23:13:38] Krenair: Which is /not/ ?action=view [23:16:57] James_F, okay, so I see a blank editor section after applying the redirect (before pressing save) which is obviously not useful. When I save I see the redirect though [23:17:16] You do? Maybe we fixed it already? [23:17:47] Krinkle: did you manage to get the qunit/jenkins issues from yesterday ironed out [23:17:49] ? [23:17:50] (03CR) 10Esanders: Refactor Scalable functionality (0310 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [23:19:19] awjr: No, still failing randomly 10% of cases regardless of code. [23:19:30] awjr: Been throwing at it for 2 days now. [23:19:34] (03PS28) 10Esanders: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [23:19:41] James_F, well, saving takes me to the normal MW read page showing the redirect... I think there's some misunderstanding here.. [23:19:42] And everything else breaking apart in other areas at the same time isn't helping [23:20:01] Just keep resubmitting until it passes. [23:21:07] Krinkle, hey, so I think https://gerrit.wikimedia.org/r/#/c/118357 is rejecting foreign states that we want, e.g. the user pressing back to leave VE [23:21:18] Krenair: It used to not show the normal MW read page. [23:22:43] Krenair: In that case we need to disambiguate between pop-states for something not related to edit area (e.g. something that enables/disables separate from ve going on and off, e.g. something in the sidebar or some overlay gadget), and foreign popstates that go to an empty state from before visualeditor was enabled. [23:25:01] Krinkle: :( [23:25:10] Krinkle: what a pain, thanks for helping to figure it out [23:25:20] Krinkle: we could still use some help getting https://gerrit.wikimedia.org/r/#/c/116037/ merged [23:25:43] Krinkle: have some time to take a look? [23:26:27] (03PS29) 10Catrope: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [23:26:44] (03PS27) 10Catrope: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [23:26:55] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [23:27:41] Krinkle: and if you're too busy, is there anyone else you would recommend to take a look at it? [23:30:30] Krinkle, I was thinking perhaps we could tag the pop-state that takes us into VE [23:31:49] no, that doesn't make sense [23:31:59] (03PS2) 10Esanders: Convert language name to lower case when looking for i18n file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124915 [23:36:02] Krinkle, yeah, I might not be the best person to solve this bug [23:36:31] awjr: Just +2 it and see if qunit fails. [23:36:37] awjr: That's what we're having to do. :-( [23:37:00] Krenair: We do that already [23:37:10] The bug you're referring to is when we've left ve state [23:37:11] lol James_F im actually less concerned about whether or not qunit fails on that and more concerned about JS-y people being OK to finally merge that patch :p [23:37:25] yeah, I thought it should already be doing that [23:37:37] Krenair: So the pop state event data is foreign (either something unrelated that happened next to VE, or we went back to the state from before VE) [23:37:47] awjr: Ha, OK. [23:37:53] Krenair: If we're navigating to a state previously made by VE, then all is fine. [23:37:57] e.g. from view back to ve-edit [23:38:21] and we do a replace instead of push when we're arriving on a ve-edit permalink [23:38:32] so that we recognise the initial state correctly [23:38:51] Yep, I understand that bit [23:38:51] (03PS1) 10Trevor Parscal: Get rid of useless comments for classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/125036 [23:41:19] (03PS2) 10Krinkle: Get rid of useless comments for classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/125036 (owner: 10Trevor Parscal) [23:41:46] (03CR) 10Krinkle: [C: 032] "Wee" [oojs/ui] - 10https://gerrit.wikimedia.org/r/125036 (owner: 10Trevor Parscal) [23:42:12] (03Merged) 10jenkins-bot: Get rid of useless comments for classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/125036 (owner: 10Trevor Parscal) [23:44:39] (03PS1) 10Jforrester: Update VE core submodule to master (b1f8fe2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125038 [23:45:53] hi all, how would i go about debugging visualeditor not loading properly? the situation is when i click "edit" on a page, nothing happens [23:46:23] the only relevant error in the access logs is: PHP Warning: array_map(): An error occurred while invoking the map [23:46:26] callback in /var/www/html/wiki/includes/resourceloader/ResourceLoaderFileModule.php [23:46:29] on line 652, [23:46:44] (not sure where else I'd look for any error output) [23:47:21] calvin_: What version of MediaWiki and VisualEditor are you using? [23:48:35] mediawiki 1.22 (i think) [23:48:50] and the latest visualeditor from git [23:50:10] ah, mediawiki 1.22.5 to be specific [23:51:26] Hmm. [23:51:42] Do you have any errors on your local Javascript console? [23:52:36] just checked: none [23:54:44] Is this instance public that I could poke at? [23:57:17] it is public, but password protected [23:57:29] would that still be useful? [23:58:28] Sure. [23:59:56] (03PS30) 10Catrope: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo)