[00:05:26] (03PS28) 10Catrope: Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [00:05:38] (03CR) 10jenkins-bot: [V: 04-1] Work with Scalable model in images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [00:13:17] (03PS31) 10Catrope: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [00:14:01] (03CR) 10Catrope: [C: 032] Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [00:14:53] (03Merged) 10jenkins-bot: Refactor Scalable functionality [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/119435 (owner: 10Mooeypoo) [00:15:40] Krinkle: When you get back, how do I find the package.json and Gruntfile.js for MW core? [00:16:14] James_F: Look at a -qunit job for mediawiki-core; it's in cd tests/frontend [00:16:21] Krinkle: Aha. [00:16:23] Krinkle: Thanks! [00:16:26] James_F: I'm in the mushroom trying to focus. Not away. [00:16:37] Krinkle: Kk. Sorry. [00:16:51] (people didn't like package.json in mediawiki-core root, so I moved it there, seemed sensibe) [00:17:09] Eurgh. Screw them. [00:17:43] (03PS1) 10Catrope: Update VE core submodule to b1f8fe2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125047 [00:18:36] (03Abandoned) 10Catrope: Update VE core submodule to b1f8fe2 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125047 (owner: 10Catrope) [00:18:38] Krinkle: 125038 [00:18:41] Bah. [00:18:44] RoanKattouw: 125038 [00:18:57] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (b1f8fe2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125038 (owner: 10Jforrester) [00:20:23] (03Merged) 10jenkins-bot: Update VE core submodule to master (b1f8fe2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125038 (owner: 10Jforrester) [00:30:36] (03PS29) 10Catrope: Update VE core submodule to master (c150259) for scalable changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [00:31:36] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c150259) for scalable changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [00:32:51] (03Merged) 10jenkins-bot: Update VE core submodule to master (c150259) for scalable changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/113163 (owner: 10Trevor Parscal) [00:57:08] (03PS5) 10Jforrester: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [00:57:16] (03CR) 10Jforrester: "PS5 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [00:57:19] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [00:59:08] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (ac6848398c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125054 [01:01:43] (03PS6) 10Jforrester: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [01:03:03] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [01:06:45] (03PS8) 10Jforrester: Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [01:08:52] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (ac6848398c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125054 (owner: 10Jforrester) [01:09:48] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (ac6848398c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125054 (owner: 10Jforrester) [01:11:53] (03PS9) 10Jforrester: Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [01:13:04] (03CR) 10jenkins-bot: [V: 04-1] Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [02:10:23] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Pass fragments, not surfaces, to windows (reprise) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124893 (owner: 10Jforrester) [02:11:17] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Pass fragments, not surfaces, to windows (reprise) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124893 (owner: 10Jforrester) [02:11:27] (03PS10) 10Catrope: Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [02:12:45] (03CR) 10jenkins-bot: [V: 04-1] Use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [02:20:57] (03PS11) 10Catrope: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [02:48:36] (03CR) 10Catrope: [C: 04-1] Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [02:51:25] (03PS12) 10Catrope: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [03:30:33] (03PS1) 10Catrope: Fix ve.dm.SurfaceFragment#getSelectedNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125069 [03:31:33] (03PS13) 10Catrope: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [03:33:02] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [03:33:56] (03PS2) 10Catrope: Fix ve.dm.SurfaceFragment#getSelectedNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125069 [03:34:31] (03Merged) 10jenkins-bot: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [03:38:12] (03CR) 10Catrope: [C: 032] Convert language name to lower case when looking for i18n file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124915 (owner: 10Esanders) [03:39:04] (03Merged) 10jenkins-bot: Convert language name to lower case when looking for i18n file [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124915 (owner: 10Esanders) [04:22:47] (03CR) 10Esanders: [C: 032] Fix ve.dm.SurfaceFragment#getSelectedNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125069 (owner: 10Catrope) [04:23:41] (03Merged) 10jenkins-bot: Fix ve.dm.SurfaceFragment#getSelectedNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125069 (owner: 10Catrope) [04:24:40] (03CR) 10Esanders: [C: 04-1] Add excludeInsertion to translateRange() (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124491 (owner: 10Catrope) [04:26:40] (03CR) 10Esanders: [C: 032] Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123891 (owner: 10Catrope) [04:27:32] (03Merged) 10jenkins-bot: Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/123891 (owner: 10Catrope) [04:35:52] (03CR) 10Esanders: [C: 04-1] Clean up lots of minor things in SurfaceFragment (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124465 (owner: 10Catrope) [04:39:47] (03PS2) 10Catrope: Clean up lots of minor things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124465 [04:40:02] (03PS2) 10Catrope: Add excludeInsertion to translateRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124491 [04:41:12] (03CR) 10Esanders: [C: 032] Add excludeInsertion property to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 (owner: 10Catrope) [04:41:22] (03PS3) 10Catrope: Add excludeInsertion to translateRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124491 [04:41:29] (03PS3) 10Esanders: Add excludeInsertion property to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 (owner: 10Catrope) [04:41:38] (03CR) 10Esanders: [C: 032] Add excludeInsertion property to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 (owner: 10Catrope) [04:41:46] (03PS3) 10Esanders: Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124493 (owner: 10Catrope) [04:42:28] (03CR) 10Esanders: [C: 032] Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124493 (owner: 10Catrope) [04:43:48] (03CR) 10Esanders: [C: 032] Add excludeInsertion to translateRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124491 (owner: 10Catrope) [04:44:14] (03CR) 10Esanders: [C: 032] Clean up lots of minor things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124465 (owner: 10Catrope) [04:45:10] (03Merged) 10jenkins-bot: Clean up lots of minor things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124465 (owner: 10Catrope) [04:45:12] (03Merged) 10jenkins-bot: Add excludeInsertion to translateRange() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124491 (owner: 10Catrope) [04:45:14] (03Merged) 10jenkins-bot: Add excludeInsertion property to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124492 (owner: 10Catrope) [04:45:16] (03Merged) 10jenkins-bot: Exclude insertions in ve.dm.SurfaceFragment#isolateAndUnwrap [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124493 (owner: 10Catrope) [05:15:27] (03PS7) 10Catrope: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [05:15:56] (03PS8) 10Catrope: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [05:23:30] (03PS7) 10Catrope: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [05:24:45] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [05:30:07] (03CR) 10Catrope: [C: 04-2] "Looks fine, but do not merge until VE-MW support has been fixed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [05:30:37] (03PS8) 10Catrope: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [05:31:54] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [05:33:19] (03CR) 10Catrope: [C: 04-1] "Still broken: after inserting a reference, there's a crash because MWReferenceModel tries to insert at the selection, but it's null. So MW" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [10:19:28] (03PS1) 10Siebrand: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125130 [14:18:55] ok.... running under IE9 [14:19:34] undo icon works after edit is made... at least it changes color [14:19:45] clicking does nothing [14:19:56] save page doesn't change color [14:20:33] Any clues about where to look for trigger to change color [14:20:35] ? [14:20:45] * hexmode tests IE10 [14:23:52] oo! undo works in IE10 :) [14:24:26] but not green button [14:24:30] * hexmode opens cosnsole log [14:25:57] fwiw, though, undo sometimes un-does 1 keystroke, sometimes 2 [14:27:26] ah, yes. Here is where I left this yesterday: console.warn doesn't support apply (in IE9) [14:30:19] * hexmode looks for a bug against mediawiki.js [14:38:39] * hexmode files bug #63770 [14:49:12] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125130 (owner: 10Siebrand) [14:50:48] (03Merged) 10jenkins-bot: Remove zh-[cn|tw] in favour of zh-han[s|t] [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125130 (owner: 10Siebrand) [15:24:52] (03PS1) 10Jforrester: Removing zh-(cn|hk|tw) i18n files, per TWN policy change [oojs/ui] - 10https://gerrit.wikimedia.org/r/125199 [15:26:19] (03CR) 10Jforrester: [C: 032] "Already undertaken in https://gerrit.wikimedia.org/r/#/c/125143/ downstream." [oojs/ui] - 10https://gerrit.wikimedia.org/r/125199 (owner: 10Jforrester) [15:26:55] (03Merged) 10jenkins-bot: Removing zh-(cn|hk|tw) i18n files, per TWN policy change [oojs/ui] - 10https://gerrit.wikimedia.org/r/125199 (owner: 10Jforrester) [15:56:13] (03PS1) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [16:01:29] Interesting stuff on https://bugzilla.wikimedia.org/show_bug.cgi?id=63038 [16:01:59] oops, meant https://bugzilla.wikimedia.org/show_bug.cgi?id=63039 [16:05:50] hexmode: Yes, VE uses MW's jQuery. [16:09:41] older version had one bundled in, though, right, James_F? [16:11:19] (03CR) 10Jforrester: [C: 032] Remove zh-[hk|tw] in favour of zh-han[s|t] [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125214 (owner: 10L10n-bot) [16:12:17] (03Merged) 10jenkins-bot: Remove zh-[hk|tw] in favour of zh-han[s|t] [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125214 (owner: 10L10n-bot) [16:12:56] hexmode: VE-core has jQuery, but has never used that inside MediaWiki. [16:13:07] hexmode: You can't run parallel jQuery versions without headaches. [16:15:36] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (729c7bbe31) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125217 [16:15:51] James_F: Oh, I get the headaches bit :) . I thought I was able to fix some problems with IE by changing the jquery in VE-core. [16:16:16] hexmode: In the stand-alone editor or inside MW? [16:16:23] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (729c7bbe31) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125217 (owner: 10Jforrester) [16:16:30] James_F: inside MW [16:16:40] Hmm. Seems… unlikely? [16:17:04] hopefully I won't be able to reproduce it now that I've updated my VE code [16:17:27] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (729c7bbe31) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125217 (owner: 10Jforrester) [16:45:34] (03PS9) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [16:47:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [17:19:43] ugh... now to track down a bug that disappears when the debugger is loaded [17:24:12] TrevorParscal: can i borrow you for a bit? [17:25:56] (03PS1) 10Jforrester: Update VE core submodule to master (74353d9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125231 [17:28:42] (03CR) 10Alex Monk: "Hi Siebrand, please review your -1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [17:31:01] (03PS1) 10Alex Monk: Only make tab changes on articles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 [17:31:58] edsanders|away: https://gist.github.com/anonymous/10404785 [17:33:46] (03CR) 10Alex Monk: [C: 04-2] "Annoyingly breaks other pages in some cases." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [17:34:44] jdlrobson: you promise to give me back when you are done? [17:39:29] (03CR) 10Jforrester: "Can't we just fix EducationProgramme to emit wgPageContentModel correctly?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [17:43:50] I've got something weird going on with VisualEditor. [17:44:48] I'm running 1.23 and a recent copy of VE (pulled from a couple days ago), and the edit button does nothing. [17:45:15] No errors, no messages, click the link and absolutely nothing happens. Edit source works as expected, but edit does nothing. [18:01:36] (03CR) 10Siebrand: Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [18:10:27] (03PS9) 10Catrope: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [18:10:57] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [18:11:15] (03CR) 10Alex Monk: "Yes, that's what I'm planning to do instead." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [18:15:36] (03PS1) 10Trevor Parscal: [THOU SHALT NOT MERGE THEE] BetaWelcome tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125242 [18:15:51] (03CR) 10Trevor Parscal: [C: 04-2] [THOU SHALT NOT MERGE THEE] BetaWelcome tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125242 (owner: 10Trevor Parscal) [18:25:32] James_F, I had been assuming that EP was using a custom content model, but it seems that's not right... [18:26:39] Krenair: I think it predates ContentHandler. [18:26:50] yeah... [18:27:12] Not sure if there's a value CH can take for "please don't touch this". :-) [18:28:25] Is there a way to turn on debugging for VE? &veaction=edit is just redisplaying the page, and I can't figure out why. [18:28:59] Rosencrantz: &veaction=edit&debug=true [18:29:29] And be patient, the VE codebase has MANY files and will take ages to load up due to massive number of requests [18:29:57] do I need to have wgDebugLog set for that to do anything? [18:31:28] James_F, well we could check to see if mw.educationProgram is set [18:31:51] debug=true is a ResourceLoader thing [18:32:00] it loads scripts directly, without fancy processing [18:32:52] Or I thought we could. what the hell is going wrong now [18:33:18] Krenair: That sounds like a hack in VE to support a broken extension… [18:34:14] oh, now that's interesting… there's a couple of js files that are getting a 404 [18:34:25] James_F, turns out that won't fix it for logged out users anyway [18:34:35] Krenair: Great. :-( [18:34:45] Rosencrantz: That's a bad start. [18:35:22] uuhh yeah [18:35:33] VisualEditor/lib/ve probably shouldn't be empty [18:36:02] (03PS9) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [18:36:08] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (74353d9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125231 (owner: 10Jforrester) [18:38:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (74353d9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125231 (owner: 10Jforrester) [18:40:49] (03CR) 10TheDJ: [C: 04-1] "kbd is an inline element. The block behavior is needed here, because for some commands, there are multiple key combinations that need to b" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [18:42:00] (03PS10) 10Esanders: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 [18:42:38] (03CR) 10jenkins-bot: [V: 04-1] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [18:43:05] (03PS10) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [18:44:50] (03PS11) 10Esanders: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 [18:46:52] (03CR) 10Jforrester: "Ha, this is what happens when you fail to check in the CSS changes alongside the JS ones. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [18:47:18] James_F, Also I wonder why I thought I could fix this without changing the PHP side too [18:47:39] (03PS1) 10Trevor Parscal: Limit the number of citation tools to 5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125251 [18:47:39] Krenair: :-) [18:48:08] (03CR) 10Jforrester: [C: 032] Limit the number of citation tools to 5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125251 (owner: 10Trevor Parscal) [18:48:28] (03PS2) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [18:51:10] (03Merged) 10jenkins-bot: Limit the number of citation tools to 5 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125251 (owner: 10Trevor Parscal) [18:53:47] (03PS12) 10Esanders: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 [18:56:55] (03PS1) 10Esanders: Remove remaining uses of surfaceModel#getSelection in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 [18:57:35] (03PS13) 10Esanders: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 [18:59:52] (03CR) 10Esanders: "ve-mw fixed in I1d6aa5e00a93" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [19:00:16] (03PS2) 10Alex Monk: Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 [19:02:01] (03PS14) 10Esanders: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 [19:02:55] (03CR) 10jenkins-bot: [V: 04-1] Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [19:04:28] (03CR) 10Esanders: "This can be merged separate of all the null surface stuff, as it just won't trigger until that is merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:07:48] (03PS1) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [19:09:23] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [19:17:43] (03CR) 10Krinkle: "Per conversation, let's see if we can solve this with a feature test further downstream instead. Battling against it inside here seems moo" [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (owner: 10Jforrester) [19:17:47] (03CR) 10Krinkle: [C: 04-1] core: Avoid an IE8 bug causing a fatal error when loaded on that platform [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (owner: 10Jforrester) [19:31:04] (03PS1) 10Krinkle: ButtonedElement: Use tabIndex property and "tabindex" attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/125268 [19:36:33] (03CR) 10Jforrester: [C: 032] Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:38:10] (03Merged) 10jenkins-bot: Disable MW tools when surface loses focus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117658 (owner: 10Esanders) [19:38:25] (03PS1) 10Jdlrobson: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 [19:39:02] (03PS2) 10Jdlrobson: [THOU SHALT NOT MERGE THEE] BetaWelcome tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125242 (owner: 10Trevor Parscal) [19:49:37] jdlrobson: ^^ :) [20:29:26] James_F, we discussed https://bugzilla.wikimedia.org/show_bug.cgi?id=61861 yesterday - something you said implied that the behaviour had changed since the bug was made. Is this still valid? [20:32:34] Krenair: Checking. [20:34:33] Krenair: Aha, I thought it was a different bug, since fixed. Still valid. [20:36:55] James_F, so this bug: make a page a redirect using VE. apply changes, save page, save page. [20:37:10] I'm then viewing the redirect [20:38:18] James_F, does this bug instead mean that after applying changes, the redirect marker should show up as a node in VE? [20:43:36] Krenair: Yes. What do you think? [20:46:13] Apr 10 00:08:29 Krenair: When on a page's read mode, click edit into VE. Then blank the page and change the page to be a redirect (Options > Redirect�). Save. Observe entirely blank simulated 'read' page, without a placeholder for the redirect-ness. [20:47:02] this is why I was confused [20:51:12] Krenair: Yeah, sorry, I misled myself. [20:51:22] Krenair: What do you think about the change, though? Sane? [20:51:46] James_F, it makes sense to show the redirect as part of the document as that's what MW does [20:52:18] * James_F nods. [20:52:25] I'll need to look into the dm/ce stuff as I haven't dealt with this area of VE yet [20:52:33] Sure. :-) [21:04:50] Anyone else getting "Uncaught TypeError: Object # has no method 'getSurface'" when opening VE on a page that redirects somewhere? [21:05:50] Hallo. [21:06:10] About the message "Visualeditor-mediasizewidget-label-scale": [21:06:45] The message is "Scale" and the qqq is "Label for the media size widget scale size section." [21:06:59] And... I don't understand what does it mean. [21:12:07] James_F|Away, AnnaKoval, marktraceur ^ [21:12:27] :) hi amir [21:12:30] * marktraceur looks about [21:12:41] I'm not familiar with that [21:17:12] marktraceur: I thought that maybe you'll know, given your involvement with media. [21:17:13] http://www.merriam-webster.com/dictionary/scale has quite a lot of meanings. [21:17:58] I guess that it has something to do with scaling in the sense of auto-resizing the image, but I need to be sure. [21:18:12] aharoni: I'd imagine it's a click-and-drag resize interface [21:18:13] But not sure [21:19:38] InezK, Eloquence , tewwy , see above... do you happen to know what does "Scale" mean exactly? [21:23:25] aharoni: wouldn’t rmoen know the context? [21:24:42] aharoni: if I had to guess I’d think it’s 6scale definition 5a or b [21:25:40] because of the mention of “size” in the qqq [21:25:56] aharoni: scale as in proportional to aspect ratio i believe. [21:26:36] tewwy: I love the way you referenced the definition :) [21:27:12] tewwy: aye, 5a [21:27:25] :-) [21:27:26] +5b [21:29:45] I think https://gerrit.wikimedia.org/r/#/c/123890/ has caused "Uncaught TypeError: Object # has no method 'getSurface'" when opening VE on a page that redirects somewhere [21:32:55] (03CR) 10Alex Monk: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [21:34:11] Hi [21:34:16] aharoni: did you find out what Visualeditor-mediasizewidget-label-scale it about? [21:34:55] InezK: not completely sure yet, although rmoen's pointer to a particular dictionary definition should be helpful [21:35:23] I'm trying to run my own VE to see how it works and having trouble with starting a Parsoid service. [21:35:31] (I haven't done it in a while.) [21:40:15] edsanders, hi [21:53:37] edsanders: https://bugzilla.wikimedia.org/show_bug.cgi?id=63791 [22:03:32] (03CR) 10TTO: [C: 031] Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [22:13:25] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=63791 [22:25:43] (03PS2) 10Jdlrobson: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 [22:26:21] (03PS1) 10Krinkle: doc: Clean up (remove redundant @method and minor fixes) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125339 [22:27:05] TrevorParscal: edsanders: https://gerrit.wikimedia.org/r/#/c/125268/ [22:37:02] Krinkle, is Ed around? [22:39:41] Krenair: Yep, he's talking with TrevorParscal [22:39:47] okay [22:39:52] sup [22:40:04] edsanders, I think https://gerrit.wikimedia.org/r/#/c/123890/ has caused "Uncaught TypeError: Object # has no method 'getSurface'" when opening VE on a page that redirects somewhere [23:06:01] And this week in Big stack & Little stack, we just pop 'n apply! [23:06:18] happy happy joy joy, pop 'n apply, undo stack, just pop [23:06:24] – TrevorP|Away (lyrics to a tech song) [23:06:32] (03PS2) 10Krinkle: doc: Clean up (remove redundant @method and minor fixes) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125339 [23:06:50] TrevorP|Away: https://gerrit.wikimedia.org/r/#/c/125268/1 ; https://gerrit.wikimedia.org/r/#/c/125339/ [23:09:32] edsanders, also this error causes the dialog to become unresponsive [23:10:04] Krenair, ^^ "can you run that in debug mode and find out which line is trigger the error" [23:10:06] *triggering [23:13:03] edsanders, It's the one I commented on (see the gerrit change) [23:22:52] (03CR) 10Trevor Parscal: [C: 032] ButtonedElement: Use tabIndex property and "tabindex" attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/125268 (owner: 10Krinkle) [23:23:22] (03Merged) 10jenkins-bot: ButtonedElement: Use tabIndex property and "tabindex" attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/125268 (owner: 10Krinkle) [23:24:12] (03PS3) 10Trevor Parscal: doc: Clean up (remove redundant @method and minor fixes) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125339 (owner: 10Krinkle) [23:34:00] (03CR) 10Trevor Parscal: [C: 032] doc: Clean up (remove redundant @method and minor fixes) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125339 (owner: 10Krinkle) [23:34:29] (03Merged) 10jenkins-bot: doc: Clean up (remove redundant @method and minor fixes) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125339 (owner: 10Krinkle) [23:35:11] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/72534/