[00:08:47] (03PS3) 10Alex Monk: Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 [00:10:22] (03CR) 10jenkins-bot: [V: 04-1] Don't change tabs on Education Program pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [00:15:22] Hm. [00:15:31] Krinkle, please see that change that just got Verified-1 [00:15:40] 00:09:13 [L160:C50] W069: ['education_program'] is better written in dot notation. [00:15:40] but [00:15:54] 19:01:08 [L160:C0] W106: Identifier 'education_program' is not in camel case. [00:16:29] Krenair: Hm.. there's probably a better way to do that. Ideally we shouldn't have those kind of identifiers. [00:16:37] I don't control what it's called... [00:16:42] Krenair: Possible work around to defer this problem is by using canonicalnamespacename instead of id [00:16:52] we generally don't use namespace ids. [00:17:00] except for mapping to other namespace ids. [00:17:47] Guess I'll do it that way instead. I still believe that this reveals an issue with the test [00:19:20] yes and no, the test is there because we should never create interfaces in javascript that result in crappy identifiers that don't follow our naming convention. If something takes an arbitrary string, it should be a parameter. [00:19:35] Similar to how the DOM interface doesn't use 'border-color', it uses borderColor [00:20:25] but when using an "upstream" interface you don't control, then you may have to disable that warning inline [00:20:27] or abstract it [00:21:28] (03CR) 10Krinkle: "Why is EP included in the first place? Don't we check "content namespace" and "wikitext" model? Either one of those should not be true, or" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [00:21:52] (03CR) 10Krinkle: "Ideally VisualEditor doesn't contain code knowing about other extensions, acceptible last resort or temp solution though." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125233 (owner: 10Alex Monk) [00:21:53] Krinkle, right, but upstream [00:22:18] Krenair: If there wasn't a work around, it'd be okay to disable the warnign inline with /*jshint -Wxxx */ [00:23:51] Krinkle, so I was expecting EP to have it's own content model as well. Apparently not. James suggested that it predates ContentHandler [00:24:54] Krenair: If that's the only reason, maybe fix this in wmf-config by removing EP from wgVisualEditorNamespaces (instead of doing so in visualeditor extension itself) [00:25:11] then have EP fix their content model (assuming it is indeed not really wikitext), and once done, remove that line from our config [00:25:14] All VE does there is change "Edit" to "Create source" [00:25:20] Ah [00:25:31] It doesn't provide Edit/ve or Create/ve? [00:25:32] Interesting [00:25:55] I replicated this without modifying wgVisualEditorNamespaces [00:27:12] Krenair: wgVisualEditorNamespaces = wgContentNamespaces by default [00:27:41] I'm assuming that the reason EP shows up with VE is that they are both in content namespaces, and, not changing contentmodel from wikitext to something else [00:28:06] I don't know why or if they intend to be in content namespaces, but VE has its own config variable that it can be removed from if needed without changing wgcontentnamespaces. [00:28:11] It shows up in VE because it's a content namespace, yes [00:28:22] enwiki; $wgContentNamespaces = [0] [00:28:26] 'wmgVisualEditorNamespaces' => array( [00:28:26] 'default' => array( NS_USER, NS_FILE, NS_HELP, NS_CATEGORY ), [00:28:30] Doesn't show up as a content namespace [00:28:55] uh. hm. [00:28:57] enwiki: wgVisualEditorConfig.namespaces [00:28:57] [0, 2, 100, 108, 118, 2, 6, 12, 14] [00:29:10] enwiki wgNamespaceIds.education_program [00:29:10] > 446 [00:29:14] It's not in there [00:29:17] https://en.wikipedia.org/wiki/Education_Program:University_of_Oklahoma# [00:29:22] Okay [00:29:23] shows neither VE or Edit [00:29:29] ? [00:30:16] Krinkle, the issue is that Edit becomes Create source [00:30:24] (VE does this) [00:30:42] you won't necessarily have the ability to edit that page on enwiki [00:35:27] Krinkle, so we can check wgVisualEditorConfig.namespaces.indexOf( wgNamespaceNumber ) !== -1 [00:35:36] before making tab changes [00:36:39] Krenair: Krinkle and I have been investigating. [00:37:44] Krenair: Use wgIsArticle for "is an editable page". [00:37:51] Krenair: And then kill the EP with fire. [00:38:21] James_F, I found that wgIsArticle isn't true on things like history and the wikitext editor [00:39:01] Krenair: Yeah, you have to evaluate it on the read page. :-( [00:39:06] Hm.. [00:39:30] So to summarise that James_F and I were saying IRL [00:39:45] We can't use content model, because on "Schema" pages on metawiki, for example, we still want it to say "Edit source" [00:39:53] becuase while they don't use wikitext, they are editable as pages. [00:40:21] Content model doesn't matter for what the " .. source" tab looks like, contnet model only determines whether we can edit it with VE (or rahter, whether Parsoid can parse it) [00:40:43] namespaces similarly, is for where we want to expose VE, the source tab is and should be unaffected by it [00:41:06] EP pages don't have page ids, don't have revisions. They're essentially like the Special namespace. [00:41:36] They actually do have their own system of revisions. [00:41:45] but yes [00:42:11] similarly to how AbuseFilter has its own system. From MW point of view, not to be treated as editable. [00:42:41] except that it chose to implement its stuff in a namespace instead of Special. Which means they're doing all kinds of crazy things to surpress everything MW wants to do. [00:42:54] Maybe it should be assigned a negative namespace ID, like -1 and -2 [00:44:05] Or… moved. [00:44:29] Looking at OutputPage. isArticle is right to be false on action edit/history. [00:45:03] wgIsArticle is a subset of 'is the associated page a wiki page' (where wiki page means something with regular page id/revision id/history etc.) [00:45:16] it is only true when on action=view [00:45:22] OutputPage::isArticleRelated() looks promising [17:05:27] (03PS2) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [17:08:12] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [17:09:05] (03CR) 10Catrope: doc: Clean up (remove redundant @method and minor fixes) (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125339 (owner: 10Krinkle) [17:10:24] (03CR) 10Catrope: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [17:14:08] (03PS1) 10Catrope: Fix JS error when opening VE on redirect page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125422 [17:14:14] Krenair: https://gerrit.wikimedia.org/r/125422 [17:14:29] (03CR) 10Catrope: Update VE core submodule to master (55a5cdc): use new ve.ui.Dialogs and ve.ui.Inspectors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123890 (owner: 10Esanders) [17:16:00] (03CR) 10Esanders: [C: 032] Fix JS error when opening VE on redirect page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125422 (owner: 10Catrope) [17:16:32] Thanks RoanKattouw & edsanders [17:17:44] Hi all. Does anyone know if VE has support for placeholder text? [17:18:29] (03Merged) 10jenkins-bot: Fix JS error when opening VE on redirect page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125422 (owner: 10Catrope) [17:21:17] nummi: You mean placeholder text in the editor itself? [17:21:37] Yep. [17:23:34] I did a search for placeholder in the docs but I don’t think the classes applied to the editor. [17:25:32] (03CR) 10Catrope: [C: 04-1] "There's a clear missing somewhere or something, because things now render as:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [17:30:30] (03PS3) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [17:30:40] nummi: Yeah so the only places we use 'placeholder' right now is for placeholder text in plain input fields [17:30:46] What would placeholders in VE look like? [17:31:15] (03PS1) 10Mooeypoo: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [17:31:25] (03PS4) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [17:31:49] (03CR) 10Jforrester: "Helps to actually put a clear: into the CSS. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [17:32:37] edsanders, ^^^ can you take a look here? I added a more focused test for dimensions object, and fixed a small typo. This seems to work better for me now, as it just doesn't accept { width: undefined } as an object at all and doesn't mess up calculations -- but I didn't find the *cause* of *why* we're getting the {width:undefined} value before we get a proper one. [17:34:30] RoanKattouw / edsanders I need to run to a (hopefully quick) doc's appointment, I added you both on to the review, and if I'm needed, hit me up through hangout chat. I'll be back in hopefully not too long. [17:36:45] (03PS1) 10Catrope: Fix JS error when opening VE on redirect page [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125429 [17:41:00] (03CR) 10Catrope: [C: 04-1] "This breaks inserting citations. It inserts the citation template *after* the reference rather than inside it: {{cite web|...}}" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [17:43:55] (03PS5) 10Jforrester: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 [17:46:14] (03PS2) 10Catrope: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:50:16] (03PS3) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [17:51:38] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [17:53:19] (03CR) 10Catrope: [C: 04-1] Small validation fixes to scalable (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:54:12] (03CR) 10Catrope: "What bugs is this fixing that I can test are now fixed?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 (owner: 10Mooeypoo) [17:54:16] moo|away: --^^ [17:56:35] (03CR) 10Catrope: [C: 032] Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [17:57:34] (03Merged) 10jenkins-bot: Put CommandHelpDialog keyboard shortcuts in kbd not div elements [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125212 (owner: 10Jforrester) [18:05:03] (03PS4) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [18:06:20] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [18:06:57] (03PS5) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [18:08:16] (03CR) 10jenkins-bot: [V: 04-1] Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [18:10:22] (03PS1) 10Catrope: Update VE core submodule to master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 [18:11:44] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [18:14:49] (03PS2) 10Trevor Parscal: Remove remaining uses of surfaceModel#getSelection in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [18:17:39] RoanKattouw: Our old implementation with CKEditor. "Type the body of your manuscript here": http://i.imgur.com/JtowZs8.png [18:17:50] Hah [18:17:58] Yeah that's a feature VE doesn't have [18:18:06] Interesting feature request though [18:18:09] James_F: Thoughts? --^^ [18:18:29] Yeah, users don’t know where to click to start editing. [18:19:11] (03PS2) 10Krinkle: Update VE core submodule to latest master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [18:19:37] Unfortunately contenteditable elements don’t support a placeholder attributes. [18:19:51] Yeah exactly [18:19:54] (03PS6) 10Krinkle: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [18:19:55] So we'd have to fake it [18:20:03] Which is possible, and probably not even very difficult [18:20:09] We just haven't had a need for this so we haven't done it [18:20:35] So unless James_F knows of a reason why we'd placeholder support for MediaWiki purposes, patches are welcome ;) [18:20:54] *why we'd need [18:21:06] I hacked it together for the “Type your manuscript title here” field. (which doesn’t use VE) [18:21:30] We might want it in MW for the VE-equivalent of "preload". [18:31:48] Krenair: Ah, sorry, the reply I referred to in the KIT wasn't submitted yet (wrote it yesterday in a tab) [18:31:54] https://bugzilla.wikimedia.org/show_bug.cgi?id=53477#c7 [18:40:43] (03CR) 10Catrope: [C: 032] Remove remaining uses of surfaceModel#getSelection in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [18:43:15] (03Merged) 10jenkins-bot: Remove remaining uses of surfaceModel#getSelection in dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125255 (owner: 10Esanders) [18:50:53] (03PS7) 10Trevor Parscal: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 [18:56:41] Krinkle, thanks. I don't think this bug is important enough to VE to justify making major changes to another extension [18:56:49] kflorence: o/, do you have an invite for Atom editor for me? [18:57:15] kflorence: rmoen|away just gave me one, thanks :) [18:57:18] Krinkle, I can invite you [18:57:20] ok [19:00:51] (03PS1) 10Catrope: Followup b2296bdd2: the property is called requiresRange, not requiresFocus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125439 [19:00:57] edsanders: ---^^ [19:05:40] (03PS1) 10Catrope: Followup 7e39f497: call parent method in DialogTool so disabling works [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125440 [19:05:47] edsanders: --^^ [19:06:14] (03CR) 10Esanders: [C: 032] Followup b2296bdd2: the property is called requiresRange, not requiresFocus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125439 (owner: 10Catrope) [19:06:50] (03PS1) 10Jforrester: Update VE core submodule to master (1064150) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125441 [19:06:52] (03CR) 10Esanders: [C: 032] Followup 7e39f497: call parent method in DialogTool so disabling works [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125440 (owner: 10Catrope) [19:08:20] (03Merged) 10jenkins-bot: Followup 7e39f497: call parent method in DialogTool so disabling works [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125440 (owner: 10Catrope) [19:08:31] (03Merged) 10jenkins-bot: Followup b2296bdd2: the property is called requiresRange, not requiresFocus [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125439 (owner: 10Catrope) [19:09:43] (03CR) 10Jforrester: [C: 032] Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [19:11:11] (03Merged) 10jenkins-bot: Use updated tab labels on description pages for files in foreign repos [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/124775 (owner: 10Alex Monk) [19:11:39] (03PS11) 10Catrope: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [19:12:01] (03PS1) 10Esanders: Fix styling of list tool group label when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/125444 [19:14:53] (03CR) 10Catrope: [C: 032] Fix styling of list tool group label when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/125444 (owner: 10Esanders) [19:17:59] (03Merged) 10jenkins-bot: Fix styling of list tool group label when disabled [oojs/ui] - 10https://gerrit.wikimedia.org/r/125444 (owner: 10Esanders) [19:19:31] (03PS1) 10Catrope: Also set requiresRange for CitationDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 [19:23:06] edsanders: https://gerrit.wikimedia.org/r/125449 [19:24:18] (03CR) 10Esanders: [C: 032] "Statistically we should probably default requiresRange to true." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 (owner: 10Catrope) [19:26:17] (03CR) 10jenkins-bot: [V: 04-1] Also set requiresRange for CitationDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 (owner: 10Catrope) [19:26:33] (03Merged) 10jenkins-bot: Also set requiresRange for CitationDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125449 (owner: 10Catrope) [19:33:07] (03PS3) 10Jforrester: Update VE core submodule to latest master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [19:59:13] RoanKattouw, got a moment? [20:05:27] hm. James_F, around? [20:16:22] (03PS10) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [20:17:53] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [20:50:20] ... what in the name of all that is gitty is going on. [20:51:46] RoanKattouw_away, I have been fighting with { width: undefined } for almost 4 hours last night... and now I can't replicate it. [21:12:25] (03PS3) 10Mooeypoo: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [21:29:28] rmoen|away: oh good, you finally got an Atom invite :) [21:56:02] (03PS1) 10Catrope: Make OO.ui.Element.onDOMEvent/offDOMEvent static [oojs/ui] - 10https://gerrit.wikimedia.org/r/125517 [21:56:31] James_F, so as I think I mentioned earlier, unless there's a lot of docs that I have missed, I'm going to need someone to explain some VE internals to me. I see that Parsoid gives us a but I'm really not sure where to go from there to end up with a redirect node on the editing screen [21:57:25] Krenair: Sure. Documentation right now is… poor. [21:57:28] * James_F blames RoanKattouw. [21:58:13] RoanKattouw: AAAAAA. I think the code is afraid of you. I *swear* I've been fighting this damn { width: undefined } for hours last night. Swear! Pinky swear! ... and yet, it won't come back. [21:58:27] Krenair: Is now a good time for me to tell you know we go from a in Parsoid's output to an editable redirect [21:58:51] mooeypoo: Might it be because of the minor changes I made to the scalable commit before I merged it [21:59:06] Cause I tweaked things that seemed to be related to a 0x0 bug [21:59:12] RoanKattouw, but you made it yesterday evening, no? I worked last night.. like.. 3-4am my time. [21:59:30] Yeah that was last night [21:59:40] RoanKattouw, I know we can edit the redirect from the page settings dialog if that's what you mean [21:59:50] RoanKattouw, I *think* I might have had a problem with my API responses, though, which I can't replicate now. So, api was slow and caused weird dimensions. [22:00:14] [14:57] Krenair [2014-04-11 13:55:19] James_F, so as I think I mentioned earlier, unless there's a lot of docs that I have missed, I'm going to need someone to explain some VE internals to me. I see that Parsoid gives us a but I'm really not sure where to go from there to end up with a redirect node on the editing screen [22:00:17] Krenair: Is now a good time for me to give you that explanation? [22:00:23] So I think the fixes could be good in a defensive sort of way anyways -- but if not, then at least we should fix up the setDefaultDimensions typo (there's this.dimensions instead of this.defaultDimensions in there) [22:00:59] RoanKattouw, yes [22:01:03] mooeypoo: Could you submit that typo fix separately then? [22:01:31] RoanKattouw, sure (though I really think the 'dimensions validation' test is a good idea regardless) [22:01:41] Krenair: OK, so, we receive Parsoid input, and we run that through ve.dm.Converter's getDataFromDom() method, which recursively builds a linear model from a DOM tree [22:01:47] Do you know what linear model data looks like? [22:01:59] we go dimensions = ve.copy( dimensions ) too quickly imho, especially when some of those come from the API. [22:02:22] RoanKattouw, I don't think so [22:03:00] Krenair: So, dm.Converter produces a data model that looks like [ {type:'paragraph'}, 'H', 'e', 'l', 'l', 'o', ' ', 'w', 'o', 'r', 'l', 'd', {type:'/paragraph'} ] [22:03:28] The whole document is one big flat array with opening objects, closing objects, and individual characters [22:03:51] Okay [22:04:24] And annotated characters (e.g. bold) characters are represented as something like [ 'H', 'e', 'l', 'l', 'o', ' ', ['w', bold], ['o', bold], ['r', bold], ['l', bold], ['d', bold] ] [22:04:43] (That's simplifying it a bit but it's close enough) [22:05:08] ok [22:05:55] So there's a bunch of DM classes that define what to do with a given HTML element [22:06:21] If you look at ve.dm.HeadingNode for instance [22:07:06] It has some static properties declaring what kind of node it is, a static property declaring that it wants to handle

,

, ...,

and two static functions for DOM->data and data->DOM conversion respectively [22:07:55] When ve.dm.Converter converts a DOM to linear model data (also called "linmod" or simply "data"), it asks ve.dm.ModelRegistry what class should handle it [22:08:04] ModelRegistry figures this out based on .static.matchTagNames etc. [22:08:26] So, for redirects in particular, there's ve.dm.MWRedirectMetaItem [22:08:42] As I kind of alluded to earlier, there are three types of "models" (things that DOM nodes can represent): nodes, annotations and meta items [22:08:59] Nodes are "normal" things that possibly contain other things or text, like tables, table rows, table cells, paragraphs, headings, etc. [22:09:10] Annotations are things that apply to text, like bold, italic, link, etc. [22:09:31] right [22:09:47] Meta items are things like and that represent data about the page, but whose position isn't very meaningful (comments are meta items too) [22:10:11] So ve.dm.MWRedirectMetaItem is the altter [22:10:13] *latter [22:10:13] (03PS1) 10Mooeypoo: Fix typo in ve.dm.Scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125522 [22:10:24] RoanKattouw, ^^ (I'll rebase the other patch on top of this one) [22:11:47] Because meta items often represent data about the page, there's ve.dm.MetaList which aggregates them [22:12:04] (03PS4) 10Mooeypoo: Small validation fixes to scalable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125428 [22:12:18] So the code that deals with redirects accesses the redirect meta item (if it exists) through the MetaList [22:12:56] Krenair: So, that's about as much as I can tell you about how redirects are born in general without knowing the context in which you asked [22:13:09] I may be able to give you more information if you tell me what you're trying to do [22:13:47] James_F: jsduck --config="{config}" --footer="Generated for branch ${{version}} on {{DATE}} by {{JSDUCK}} {{VERSION}}." --processes 0 --warnings-exit-nonzero 2>&1 | tee jsduck.log [22:14:13] RoanKattouw, when you make a page redirect somewhere, editing it in VE shows a blank page... it should probably show the redirect [22:14:33] Oh you mean it should render something visually? [22:14:45] Yes [22:14:59] OK so you're touching on a larger issue here: some meta items should be visible [22:15:07] This would be useful for comments too [22:15:20] It's on my list somewhere to work on this but I'm not particularly close to starting work on it [22:15:22] Yes, I think this idea goes against what I now understand about meta items [22:15:35] Yeah meta items actually get yanked /out/ of the linear model ata [22:15:37] *data [22:15:47] So that when you delete across them, they're preserved at a similar position [22:16:05] Making them rendered would presumably mean making them deletable as well [22:17:09] MediaWiki redirects only work when they are the only thing on a page as far as I can tell [22:18:02] (although Parsoid... doesn't appear to be aware of this) [22:19:03] So if you have a page that's just "hi\n#redirect [[somewhere]]", that's not a valid redirect. Parsoid still outputs a though [22:19:57] No, you can have stuff below a redirect as well, just not above it [22:20:14] So you can have #REDIRECT [[Somewhere]]\n\n[[Category:Silly redirects]] [22:20:20] That's relatively common AFIAK [22:20:57] argh, mediawiki. what. [22:21:22] Sigh, I tested content both above and below, and content above. not only content below. [22:22:37] So basically a valid redirect is the first thing in the document, otherwise it's just a list item labelled 'redirect' and has a link. [22:22:55] TrevorParscal: https://gerrit.wikimedia.org/r/125517 [22:23:10] Krenair: Yes. Parsoid hasn't implemented this correctly I don't think [22:24:10] (03CR) 10Trevor Parscal: [C: 032] Make OO.ui.Element.onDOMEvent/offDOMEvent static [oojs/ui] - 10https://gerrit.wikimedia.org/r/125517 (owner: 10Catrope) [22:24:36] (03Merged) 10jenkins-bot: Make OO.ui.Element.onDOMEvent/offDOMEvent static [oojs/ui] - 10https://gerrit.wikimedia.org/r/125517 (owner: 10Catrope) [22:25:44] RoanKattouw, okay. With all this in mind I'm going to suggest to James_F unassigning this bug and marking it as dependent on 1) meta items becoming visible and having a known position and 2) Parsoid implementing redirects correctly [22:28:35] Yeah that would be my suggestion [22:28:43] Block this on the DM I have to do anyway for editable comments [22:31:35] James_F: --warnings=+A,-B,+C [22:36:03] Thanks RoanKattouw [22:40:27] James_F: https://gerrit.wikimedia.org/r/#/c/108053/ [23:10:03] (03PS1) 10Esanders: Prevent iframe windows from wiping parent document selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/125531 [23:17:02] (03CR) 10Catrope: [C: 032] Prevent iframe windows from wiping parent document selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/125531 (owner: 10Esanders) [23:17:33] (03Merged) 10jenkins-bot: Prevent iframe windows from wiping parent document selection [oojs/ui] - 10https://gerrit.wikimedia.org/r/125531 (owner: 10Esanders) [23:20:27] (03PS12) 10Catrope: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [23:21:20] (03CR) 10jenkins-bot: [V: 04-1] Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 (owner: 10Esanders) [23:25:49] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (d7cbc785a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 [23:26:48] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (d7cbc785a7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 (owner: 10Catrope) [23:34:24] eh RoanKattouw did I do something wrong here? the patch seems to depend on some random merged commit...? :\ https://gerrit.wikimedia.org/r/#/c/125522/ [23:37:54] (03PS1) 10Catrope: Fix jsduck errors [oojs/ui] - 10https://gerrit.wikimedia.org/r/125535 [23:38:24] (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (eca1fc20e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 [23:38:33] mooeypoo: No that's normal [23:38:39] I don't know why it shows it by default [23:38:54] Normally the dependencies section is supposed to be initially collapsed in that case [23:40:47] edsanders: https://gerrit.wikimedia.org/r/125534 [23:41:22] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (eca1fc20e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 (owner: 10Catrope) [23:42:18] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (eca1fc20e7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125534 (owner: 10Catrope) [23:44:19] (03PS13) 10Esanders: Detect document focus properly and allow null selection in model [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/124359 [23:44:34] edsanders: Could you merge https://gerrit.wikimedia.org/r/125535 too? [23:44:49] I forgot that that oojs-ui pull-through included that change, which is unmerged (oops :P ) [23:45:10] (03CR) 10Esanders: [C: 032] Fix jsduck errors [oojs/ui] - 10https://gerrit.wikimedia.org/r/125535 (owner: 10Catrope) [23:45:14] Thanks [23:45:56] (03Merged) 10jenkins-bot: Fix jsduck errors [oojs/ui] - 10https://gerrit.wikimedia.org/r/125535 (owner: 10Catrope) [23:47:53] RoanKattouw, oh, I thought that if it is based on master, then it has no actual dependencies. [23:47:57] listed, i mean. [23:48:13] anyways, I made the *other* commit depend on this one, so it may be showing the dependencies because it has something depended on it? [23:48:49] edsanders: And https://gerrit.wikimedia.org/r/125536 too? [23:49:02] Then "detect focus properly" will become mergable [23:49:36] Thanks