[02:24:48] Krenair, hello, just a reminder of an issue I'm experiencing where items in the media library don't show up when I use 'Insert Media', not sure if you found the time to follow this up.. [02:30:15] dmotd, that was a week ago. I don't remember what I found out [02:35:47] dmotd, do you change $wgLocalFileRepo anywhere in your config? [04:38:18] Krenair, no change from defaults [04:40:08] Krenair, a direct query to the api: api.php?action=query&list=allimages&format=json returns all uploaded images [04:48:13] Krenair, mw 1.22.2, parsoid and VE updated last week. [05:19:09] Krenair, further, if I drop in a file to a page manually using edit source, edit the page with VE - double click the file, i get a dialog window which seems useful, but none of the settings apply and it's actually impossible to close the dialog.. [07:29:42] (03CR) 10Nemo bis: "Thanks for your patch and welcome in gerrit. The commit message could be improved: https://www.mediawiki.org/wiki/Gerrit/Commit_message_gu" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [13:52:36] dmotd, around? [15:31:23] (03CR) 10Zfilipin: "Vikassy, do you plan to work on this commit? Do you need help?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 (owner: 10Vikassy) [15:36:23] (03CR) 10Zfilipin: [C: 04-1] WIP: [Browser test] Scenario added for long Target Links and added few white-spaces in bottom existing scenario (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [16:14:50] James_F, hey. Is Timo around? [16:15:04] Krenair: No, sorry; he's checking out. [16:15:10] Krenair: He flies back in a few hours. [16:15:20] oh, okay [16:23:56] (03PS1) 10Alex Monk: Always replace state with VE tag when loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125745 [16:28:17] James_F, ^ this patch fixes the issue. It might not be the correct solution, I had been intending to ask Timo to look at it before today's hangout [16:31:22] * James_F nods. [16:35:22] James_F, also I noticed you changed https://bugzilla.wikimedia.org/show_bug.cgi?id=61861 back to assigned [16:39:08] Krenair: Yes. "NEW" means "this has not yet been accepted by the team as a bug that should be fixed". You probably didn't mean that. :-) [16:40:53] Krenair: His flight isn't for another three hours so I'll ping him and see if he has time to review that commit [16:41:49] James_F, oh, okay. NEW has different meanings elsewhere on BZ [17:11:19] I have no idea if you guys could even see me today. internet connection is not good. was difficult working out what some people were saying [17:13:50] Krenair: Your video was a bit blocky but your audio was pretty good [17:13:56] I could hear what you were saying just fine [17:15:27] RoanKattouw: Is mw.loader smart enough that when we start loading a library with mw.loader.load and then later call mw.loader.using, it won't try to download it again? [17:15:33] I assume yes but if there's a red flag... [17:17:55] marktraceur: It's supposed to be, yes [17:18:09] 'kay [17:18:19] I will assume that is the case until we hear reports otherwise [17:21:23] (03CR) 10Catrope: [C: 04-1] Create ve#contains (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125557 (owner: 10Esanders) [17:27:35] (03PS2) 10Catrope: Create ve#contains [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125557 (owner: 10Esanders) [17:27:46] (03CR) 10Catrope: [C: 032] Create ve#contains [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125557 (owner: 10Esanders) [17:27:51] (03PS2) 10Catrope: Prevent pasteTarget selection while already selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125559 (owner: 10Esanders) [17:29:17] (03Merged) 10jenkins-bot: Create ve#contains [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125557 (owner: 10Esanders) [17:35:28] (03CR) 10Catrope: [C: 032] Prevent pasteTarget selection while already selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125559 (owner: 10Esanders) [17:36:30] (03Merged) 10jenkins-bot: Prevent pasteTarget selection while already selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125559 (owner: 10Esanders) [17:41:19] (03CR) 10Catrope: [C: 032] Event sequencer cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125544 (owner: 10Esanders) [17:42:31] (03Merged) 10jenkins-bot: Event sequencer cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125544 (owner: 10Esanders) [17:47:21] lol: [e8897bf6] /w/index.php?title=Special:UserLogin&returnto=Main+Page&type=signup Exception from line 160 of /home/catrope/git/mediawiki/extensions/ConfirmEdit/FancyCaptcha.class.php: Ran out of captcha images [17:51:59] (03PS1) 10Divec: Make the DOM hash ignore text node splitting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125757 [18:08:57] (03CR) 10Catrope: [C: 032] Make the DOM hash ignore text node splitting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125757 (owner: 10Divec) [18:14:54] (03Merged) 10jenkins-bot: Make the DOM hash ignore text node splitting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125757 (owner: 10Divec) [18:42:49] edsanders / TrevorParscal you around for a quick question/consultation? [18:43:52] edsanders, TrevorParscal I'm working on the image model and encountered a small issue. When the user changes type in the dialog, we want everything to adjust -- the type->scalable considerations are in the image *node* now, which is great for when the node actually changes, but the dialog works without changing the node yet (It creates a new node, removing the old one, but only if the user *applies*) [18:44:37] It would be silly to move the logic away from the node as edsanders pointed out, but that means that if the user changes type in the dialog, I have to get the scalable max/default calculations through the node, which effectively changes the scalable object *attached* to the node [18:45:27] So, my idea for the moment is to let that happen, but "reset" the node (so, call imageNode.updateType() on its current type) if the user *cancels* the dialog. [18:45:46] But this is a bit roundtrippy.. I want to make sure I'm not missing anything, and that this strategy sounds okay to you two. [18:53:02] if it's a new image node then it should have a new scalable [18:53:10] with properties copied from the old one [18:53:26] Right. But it's getting a scalable object from the existing node. [18:53:51] Or I could copy the scalable... that's a good point. [18:54:15] But still, the logic of how to adjust the scalable properties according to the type is in the *image* node [18:55:06] not the scalable. So I have to call an image node. Either a new one or the old one. I am outputting the new one at the very end when the user applies, so I am only dealing with properties and at the end I group them into a transaction to create a node. [19:00:45] so the problem is the new image node doesn't exist until you apply? [19:01:03] if so it sounds like you need staged transactions, which is what I'm working on [19:01:31] yes, so in order to get the proper calculation, I either create a new node to work on throughout the process, or I use the old one for the calculation -- but that means I'll have to "cancel" it if the user does. [19:07:55] (03PS1) 10Cmcmahon: [browser test] make test pass in both Chrome and FF [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125775 [19:10:12] (03PS2) 10Cmcmahon: [browser test] make test pass in both Chrome and FF [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125775 [19:10:46] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125775 (owner: 10Cmcmahon) [19:12:22] (03Merged) 10jenkins-bot: [browser test] make test pass in both Chrome and FF [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125775 (owner: 10Cmcmahon) [19:19:24] (03PS1) 10Catrope: Revert "Make the DOM hash ignore text node splitting" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125780 [19:19:31] (03CR) 10Catrope: [C: 032] Revert "Make the DOM hash ignore text node splitting" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125780 (owner: 10Catrope) [19:21:06] (03Merged) 10jenkins-bot: Revert "Make the DOM hash ignore text node splitting" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125780 (owner: 10Catrope) [19:43:06] (03PS1) 10Trevor Parscal: (Bug 61885) Inserting ref list while selecting another kind of node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125799 [19:44:30] (03PS2) 10Jforrester: Fix inserting references list while selecting another kind of node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125799 (owner: 10Trevor Parscal) [19:45:27] (03CR) 10Jforrester: [C: 032] Fix inserting references list while selecting another kind of node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125799 (owner: 10Trevor Parscal) [19:49:31] (03Merged) 10jenkins-bot: Fix inserting references list while selecting another kind of node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125799 (owner: 10Trevor Parscal) [21:32:04] (03PS1) 10Jforrester: Update VE core submodule to master (5243788) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125882 [22:02:27] James_F, hi. Can you find stuff to put on my list please? [22:04:49] Krenair: Anything from https://bugzilla.wikimedia.org/buglist.cgi?bug_status=ASSIGNED&component=MediaWiki%20integration&order=priority%2Cbug_severity%2C&product=VisualEditor&query_format=advanced take your fancy? [22:07:22] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=52261 and https://bugzilla.wikimedia.org/show_bug.cgi?id=63540 would be good to fix. [22:09:19] Krenair: https://bugzilla.wikimedia.org/show_bug.cgi?id=57536 sounds like the kind of integration you're great at, too. :-) [22:09:34] James_F, I'll look into these. Thanks [22:09:45] Cool. :-) [22:43:58] (03PS1) 10Jforrester: Re-apply "Make the DOM hash ignore text node splitting" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125892 [22:45:21] (03CR) 10Catrope: [C: 032] Re-apply "Make the DOM hash ignore text node splitting" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125892 (owner: 10Jforrester) [22:46:12] (03PS1) 10Trevor Parscal: Only blur inputs within booklet pages when moving away [oojs/ui] - 10https://gerrit.wikimedia.org/r/125894 [22:46:20] (03Merged) 10jenkins-bot: Re-apply "Make the DOM hash ignore text node splitting" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125892 (owner: 10Jforrester) [22:48:24] (03PS2) 10Catrope: Only blur inputs within booklet pages when moving away [oojs/ui] - 10https://gerrit.wikimedia.org/r/125894 (owner: 10Trevor Parscal) [22:49:12] (03CR) 10Catrope: [C: 04-1] Only blur inputs within booklet pages when moving away (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/125894 (owner: 10Trevor Parscal) [22:55:54] (03PS1) 10Catrope: Followup d7cbc785a: focus iframe content div before open event [oojs/ui] - 10https://gerrit.wikimedia.org/r/125896 [22:57:57] (03CR) 10Esanders: [C: 032] Followup d7cbc785a: focus iframe content div before open event [oojs/ui] - 10https://gerrit.wikimedia.org/r/125896 (owner: 10Catrope) [22:59:19] (03Merged) 10jenkins-bot: Followup d7cbc785a: focus iframe content div before open event [oojs/ui] - 10https://gerrit.wikimedia.org/r/125896 (owner: 10Catrope) [23:00:15] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (eba79af989) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125897 [23:01:11] (03PS1) 10Catrope: Add .focus() to SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125898 [23:16:34] (03PS2) 10Catrope: Update VE core submodule to master (5aa55c5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125882 (owner: 10Jforrester) [23:16:47] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5aa55c5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125882 (owner: 10Jforrester) [23:18:01] (03CR) 10Ori.livneh: [C: 032] Update VE core submodule to latest master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [23:18:51] (03PS1) 10Esanders: Pass required params to open for save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125902 [23:18:53] (03Merged) 10jenkins-bot: Update VE core submodule to master (5aa55c5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125882 (owner: 10Jforrester) [23:19:06] RoanKattouw, ^^ [23:19:33] (03CR) 10Catrope: [C: 032] Pass required params to open for save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125902 (owner: 10Esanders) [23:20:00] (03Merged) 10jenkins-bot: Update VE core submodule to latest master (74353d9) [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125431 (owner: 10Catrope) [23:20:24] (03PS2) 10Ori.livneh: Fix JS error when opening VE on redirect page [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125429 (owner: 10Catrope) [23:20:29] (03CR) 10Ori.livneh: [C: 032] Fix JS error when opening VE on redirect page [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125429 (owner: 10Catrope) [23:21:59] (03Merged) 10jenkins-bot: Pass required params to open for save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125902 (owner: 10Esanders) [23:22:09] (03PS1) 10Catrope: Pass required params to open for save dialog [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125904 [23:23:24] (03Merged) 10jenkins-bot: Fix JS error when opening VE on redirect page [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125429 (owner: 10Catrope) [23:24:01] (03PS2) 10Ori.livneh: Pass required params to open for save dialog [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125904 (owner: 10Catrope) [23:24:12] (03CR) 10Ori.livneh: [C: 032 V: 032] Pass required params to open for save dialog [extensions/VisualEditor] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/125904 (owner: 10Catrope) [23:27:14] (03PS1) 10Catrope: [UNMERGED] Update VE core submodule to bc506367b88e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125909 [23:28:12] (03PS1) 10Catrope: Focus the surface in the reference dialog after it opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125911 [23:28:32] (03CR) 10jenkins-bot: [V: 04-1] [UNMERGED] Update VE core submodule to bc506367b88e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125909 (owner: 10Catrope) [23:29:50] (03CR) 10jenkins-bot: [V: 04-1] Focus the surface in the reference dialog after it opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125911 (owner: 10Catrope) [23:30:12] hi grrrit-wm [23:30:24] oops! [23:30:29] hi gwicke [23:37:10] edsanders: When you have a minute: https://gerrit.wikimedia.org/r/#/c/125898/ [23:40:55] (03PS1) 10Jforrester: Hide the beta welcome via a preference, not a cookie, for logged in users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 [23:49:13] (03PS1) 10Esanders: Buttons return false on mouse down [oojs/ui] - 10https://gerrit.wikimedia.org/r/125915 [23:50:04] (03PS2) 10Esanders: Add .focus() to SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125898 (owner: 10Catrope) [23:50:39] (03CR) 10Esanders: [C: 032] "Renamed commit message (SurfaceWidget not SurfaceFragment)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125898 (owner: 10Catrope) [23:57:56] (03PS1) 10Esanders: Fix WindowSet#getCurrentWindow documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/125916