[00:06:56] (03CR) 10Jforrester: [C: 032] Fix WindowSet#getCurrentWindow documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/125916 (owner: 10Esanders) [00:07:24] (03Merged) 10jenkins-bot: Fix WindowSet#getCurrentWindow documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/125916 (owner: 10Esanders) [00:11:15] (03PS1) 10Esanders: Allow the context to close any open inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 [00:11:57] (03CR) 10jenkins-bot: [V: 04-1] Allow the context to close any open inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 (owner: 10Esanders) [00:15:42] (03PS2) 10Esanders: Allow the context to close any open inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 [00:21:26] (03PS1) 10Esanders: Hide inspectors using new method when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125921 [00:31:47] (03PS1) 10Esanders: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 [00:32:08] (03PS2) 10Esanders: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 [00:32:46] (03PS1) 10Esanders: Code style typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125924 [00:33:07] (03CR) 10jenkins-bot: [V: 04-1] Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 (owner: 10Esanders) [01:46:16] (03PS1) 10Esanders: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 [01:55:16] (03CR) 10jenkins-bot: [V: 04-1] Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 (owner: 10Esanders) [03:13:59] (03PS1) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [03:15:00] (03CR) 10jenkins-bot: [V: 04-1] POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [03:54:07] (03CR) 10Jforrester: [C: 032] Code style typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125924 (owner: 10Esanders) [03:55:07] (03Merged) 10jenkins-bot: Code style typos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125924 (owner: 10Esanders) [04:21:16] (03CR) 10Vikassy: "Sorry I am a bit busy with my school work now. Will fix it on Thursday. Hope that is fine." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 (owner: 10Vikassy) [07:44:07] (03CR) 10Zfilipin: "There is no rush, I have just noticed that I have voted -1 a few weeks ago and you did not reply since." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 (owner: 10Vikassy) [09:10:30] (03PS12) 10Jagori79: WIP: [Browser test] Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [09:16:59] (03CR) 10Jagori79: "Changes Done" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [10:32:09] (03PS13) 10Jagori79: WIP: [Browser test] Visual Editor adding long Target Links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [10:33:56] (03PS14) 10Jagori79: WIP: [Browser test]Step definition for long target link scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 [10:48:36] (03CR) 10Jagori79: "Hi," (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/122400 (owner: 10Jagori79) [15:54:51] yay, regressions [15:56:37] If I open VE, click on the document title, and then try to open the page settings dialog (or most other options on that list), nothing happens. Uncaught TypeError: Cannot read property 'start' of null [15:57:08] Krenair: Hmm. I know Roan was working on some bugs yesterday afternoon like that – maybe they didn't get merged? [15:58:09] also once I click on the title and start typing, I get a lot of these errors: Uncaught TypeError: Cannot call method 'isCollapsed' of null [16:00:37] James_F, also I saw you made https://gerrit.wikimedia.org/r/#/c/95726/17/modules/ve-mw/dm/metaitems/ve.dm.MWHiddenCategoryMetaItem.js (you forgot to replace mwNoGallery). [16:01:53] Ooops. :-) [16:02:31] I found it while dealing with a few enhancement bugs, my patch for those will fix this [16:02:55] Cool. [16:39:34] (03PS1) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 [16:41:11] (03CR) 10Alex Monk: Create remaining meta items in DM (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/95726 (owner: 10Jforrester) [16:43:42] (03CR) 10jenkins-bot: [V: 04-1] Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [16:44:13] (03CR) 10Alex Monk: [C: 04-1] "nocc and notc don't work yet, think that might be an issue with the DM code in I752705f6. The error for both is Uncaught TypeError: Cannot" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [17:20:09] Hm... Can't remember what I last changed in my parsoid directory on my laptop, but I'm getting Cannot find module 'yargs' when running nodejs api/server.js [17:20:39] Krenair: Do npm install? [17:41:55] James_F, that was it, thanks [17:45:39] Krenair: Happy to help. :-) [17:46:07] (I had tried node install, but forgot it was supposed to be npm and it obviously didn't work) [17:55:58] (03PS2) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 [17:56:46] (03CR) 10Jforrester: Add checkboxes to set some metadata on page metadata panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [17:57:52] James_F, hm, okay I guess that makes sense [17:58:31] Krenair: But I really like the re-written way of adding new fields. :-) [17:58:36] As I don't speak sr or zh I don't know much about the language conversion stuff [17:58:43] None of us do. [17:58:53] And divec /does/ speak zh. [17:59:47] James_F, yeah, I decided that a lot of the code would be duplicate if I kept with the existing style, so went with this instead [18:00:18] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (eba79af989) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125897 (owner: 10Catrope) [18:01:15] James_F, anyway I'd like to figure out why the nocc/notc options don't save properly [18:01:40] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (eba79af989) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125897 (owner: 10Catrope) [18:01:42] (03Merged) 10jenkins-bot: Add .focus() to SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125898 (owner: 10Catrope) [18:01:48] As I mentioned in my comment on PS1, the errors are in your toDomElements functions [18:02:05] * James_F nods. [18:02:33] Krenair: https://gerrit.wikimedia.org/r/#/c/72053/ would be a nice primer about language converter ;) ("New language variant 'en-x-piglatin' for easier variant testing") [18:02:46] Krenair: Just run away. :-) [18:03:08] it's a pity that we can't get it merged, but the current RFC on language converter syntax will probably help [18:07:38] James_F, I think it's really just a matter of: [18:07:41] - dataElement.attributes.originalProperty || 'mw:PageProp/nocontentconvert' [18:07:42] + ( dataElement.attributes && dataElement.attributes.originalProperty ) || 'mw:PageProp/nocontentconvert' [18:07:44] same for notc [18:07:55] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8197f2cd2e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126033 [18:08:16] Krenair: Yeah, that looks rihgt. [18:08:39] (03CR) 10Jforrester: [C: 032] "Trivial pull-through." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126033 (owner: 10Jforrester) [18:08:46] edsanders: https://gerrit.wikimedia.org/r/126032 [18:09:56] (03PS3) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 [18:10:07] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8197f2cd2e) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126033 (owner: 10Jforrester) [18:10:20] Okay, next thing is moving those language conversion options to the advanced page [18:17:26] (03PS3) 10Esanders: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 [18:17:28] (03PS2) 10Esanders: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 [18:20:37] (03PS4) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 [18:24:52] (03CR) 10jenkins-bot: [V: 04-1] Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [18:30:00] (03PS5) 10Alex Monk: Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 [18:32:38] (03PS1) 10Esanders: Debounce ce.Surface#onFocusChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126042 [18:36:40] Krenair: Whee, passing tests. :-) [18:36:58] yeah [18:42:55] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=63945 and https://bugzilla.wikimedia.org/show_bug.cgi?id=63954. [18:45:46] (03PS3) 10Trevor Parscal: Only blur inputs within booklet pages when moving away [oojs/ui] - 10https://gerrit.wikimedia.org/r/125894 [18:45:52] (03PS1) 10Trevor Parscal: Make fieldset layouts render correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/126043 [18:47:25] (03PS1) 10Trevor Parscal: Make fieldsets render properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126044 [19:20:54] (03PS1) 10Trevor Parscal: Use document direction when a fragment has a null range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126058 [19:26:48] (03PS4) 10Esanders: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 [19:26:50] (03PS3) 10Esanders: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 [19:26:52] (03PS1) 10Esanders: Refactory history state methods to better suit uses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126059 [19:27:59] (03PS5) 10Esanders: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 [19:28:01] (03PS2) 10Esanders: [BREAKING CHANGE] Refactor history state methods to better suit uses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126059 [19:28:03] (03PS4) 10Esanders: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 [19:30:52] (03PS6) 10Esanders: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 [19:30:54] (03PS3) 10Esanders: [BREAKING CHANGE] Refactor history state methods to better suit uses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126059 [19:30:56] (03PS5) 10Esanders: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 [19:32:16] (03PS1) 10Jforrester: Fix fencepost error with MWMoreParametersSearchWidget overflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126061 [19:32:36] (03PS1) 10Jforrester: Update VE core submodule to master (d1f5386) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126062 [19:37:39] (03CR) 10Catrope: [C: 032] Fix fencepost error with MWMoreParametersSearchWidget overflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126061 (owner: 10Jforrester) [19:38:22] (03PS2) 10Catrope: Make fieldset layouts render correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/126043 (owner: 10Trevor Parscal) [19:38:54] (03CR) 10Catrope: [C: 032] Make fieldset layouts render correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/126043 (owner: 10Trevor Parscal) [19:39:41] (03CR) 10Catrope: [C: 032] Debounce ce.Surface#onFocusChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126042 (owner: 10Esanders) [19:42:29] (03CR) 10Catrope: [C: 031] "Looks fine, but wouldn't it be nicer to have getDirectionFromRange() automatically fall back to the document direction?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126058 (owner: 10Trevor Parscal) [19:43:56] (03CR) 10Catrope: [C: 032] "Merging because this fixes a fatal error" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126058 (owner: 10Trevor Parscal) [19:45:49] (03CR) 10Catrope: [C: 032] Allow the context to close any open inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 (owner: 10Esanders) [19:49:05] (03CR) 10Catrope: [C: 04-1] Allow the context to close any open inspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 (owner: 10Esanders) [19:59:32] (03Merged) 10jenkins-bot: Make fieldset layouts render correctly [oojs/ui] - 10https://gerrit.wikimedia.org/r/126043 (owner: 10Trevor Parscal) [20:01:28] (03Merged) 10jenkins-bot: Fix fencepost error with MWMoreParametersSearchWidget overflow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126061 (owner: 10Jforrester) [20:01:30] (03Merged) 10jenkins-bot: Debounce ce.Surface#onFocusChange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126042 (owner: 10Esanders) [20:02:12] (03Merged) 10jenkins-bot: Use document direction when a fragment has a null range [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126058 (owner: 10Trevor Parscal) [20:05:07] (03CR) 10Esanders: Allow the context to close any open inspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 (owner: 10Esanders) [20:09:41] TrevorParscal, can I ask you for a quick review favor? [20:10:16] the Parsoid RL patch at https://gerrit.wikimedia.org/r/#/c/124785/ could use a sanity check [20:12:50] lookin [20:13:18] (03PS3) 10Esanders: Allow the context to close any open inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 [20:13:30] my understanding is that it won't load the css by default [20:14:15] yeah [20:14:38] I tested it locally without ill effects [20:14:45] you would have to have an $out->addModules( array( 'ext.parsoid.styles' ) ) somewhere [20:15:31] I guess right now the intention is to load it dynamically where needed [20:15:34] (03CR) 10Esanders: Allow the context to close any open inspector (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 (owner: 10Esanders) [20:15:35] Or $out->addModuleStyles( array( 'ext.parsoid.styles' ) ) if you want to bake them into the head of the page (beware this is scary) [20:16:05] We'll want to load it for VE. [20:16:09] I guess VE and Flow could request the module from client-side code? [20:16:12] But not needed for e.g. fragments. [20:16:13] Yeah. [20:18:55] TrevorParscal, so if you think this is at least harmless and an okay start then I'd be inclined to merge it [20:19:34] do you think we should go straight for LESS rather than .css? [20:19:53] Yes. [20:22:54] gwicke: (Trevor said "yes, go with LESS" IRL as he walked away.) [20:23:26] how hard is it to change from css to less? [20:23:33] just rename the file? [20:29:29] I think that works [20:30:00] RoanKattouw, just chatted with Trevor; he recommended to start with CSS so that we get CSS Janus testing [20:30:06] easy to switch later [20:32:03] RoanKattouw, if I have a caption document ( new ve.dm.Document() ... ) can I check if it has content? getLength() doesn't seem to work well. Should I go with 'getText()' and check if it's empty? [20:32:07] gwicke: Yeah, just load the file with .less as its filename and RL will magically assume. [20:36:38] mooeypoo: Check MWReferenceDialog for logic that asserts the length is <=4 [20:36:42] Or >4 or whatever [20:38:40] RoanKattouw, ok. It seems that .getText() gives the actual content of the caption, so it might just be straight forward to use getText() !== '' no? [20:38:51] I'm checking the MWReferenceDialog too [20:39:14] disabled = data.length <= 4 [20:39:57] mooeypoo: The caption might contain non-text content [20:40:16] length <= 4 is a hack but it's less bad than getText() === '' [20:41:37] ooh, good point. Okay, I'm looking at the length. [20:43:00] I'm building a transaction now, and insertContent() takes an array of objects, but in the caption, I already have a document. Can I translate the document to that type of object to use with insertContent() or do I need to use the actual transaction in that case? [20:44:27] I have to consider differences between actual caption and caption that magically transforms to be the 'title=', because Wikitext. [20:44:28] Captions are just as much fun as upright. [21:39:48] Can someone check https://bugzilla.wikimedia.org/show_bug.cgi?id=52261 ? [21:40:06] (I don't think it's valid anymore but maybe I'm missing something) [21:40:46] Krenair: Yeah, think you're right. [22:06:27] (03PS1) 10Trevor Parscal: Don't call select on a fragment if it's null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126144 [22:23:45] (03PS2) 10Jforrester: Update VE core submodule to master (d1f5386) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125909 (owner: 10Catrope) [22:24:04] (03Abandoned) 10Jforrester: Update VE core submodule to master (d1f5386) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126062 (owner: 10Jforrester) [22:25:43] (03PS2) 10Jforrester: Focus the surface in the reference dialog after it opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125911 (owner: 10Catrope) [22:35:05] (03CR) 10Esanders: [C: 032] "Eww." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126144 (owner: 10Trevor Parscal) [22:36:06] (03Merged) 10jenkins-bot: Don't call select on a fragment if it's null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126144 (owner: 10Trevor Parscal) [22:37:28] edsanders: Could you merge https://gerrit.wikimedia.org/r/#/c/125909/ quickly? Kthnxbai. [22:40:14] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (d1f5386) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125909 (owner: 10Catrope) [22:40:19] Ta. [22:41:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (d1f5386) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125909 (owner: 10Catrope) [22:42:39] (03PS1) 10Jforrester: Update VE core submodule to master (bb7124b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126152 [22:58:45] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (bb7124b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126152 (owner: 10Jforrester) [23:00:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (bb7124b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126152 (owner: 10Jforrester) [23:13:11] (03CR) 10Krinkle: "Unconditionally replacing the state (as opposed to pushing, which preserves other states) even when on a plain page load that is in 'read'" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125745 (owner: 10Alex Monk) [23:13:17] (03CR) 10Krinkle: [C: 031] Always replace state with VE tag when loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125745 (owner: 10Alex Monk) [23:17:55] (03PS11) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [23:19:19] (03PS1) 10Trevor Parscal: Merge dialog and inspector actions into window actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126164 [23:19:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [23:19:53] (03PS2) 10Trevor Parscal: Merge dialog and inspector actions into window actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126164 [23:21:04] (03PS1) 10Trevor Parscal: Update VE Core (Dialog/Inspector action merge) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126166 [23:21:15] (03CR) 10jenkins-bot: [V: 04-1] Update VE Core (Dialog/Inspector action merge) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126166 (owner: 10Trevor Parscal) [23:22:25] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Merge dialog and inspector actions into window actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126164 [23:22:36] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Update VE Core (Dialog/Inspector action merge) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126166 [23:22:50] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update VE Core (Dialog/Inspector action merge) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126166 (owner: 10Trevor Parscal) [23:37:39] (03PS1) 10Esanders: Clear the surface observer when blurring. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126169 [23:39:10] (03PS2) 10Jforrester: Clear the surface observer when blurring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126169 (owner: 10Esanders) [23:39:14] (03CR) 10Jforrester: [C: 032] Clear the surface observer when blurring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126169 (owner: 10Esanders) [23:39:16] (03PS3) 10Esanders: Clear the surface observer when blurring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126169 [23:42:58] (03CR) 10Jforrester: [C: 032] Clear the surface observer when blurring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126169 (owner: 10Esanders) [23:43:31] (03CR) 10Catrope: [C: 032] Clear the surface observer when blurring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126169 (owner: 10Esanders) [23:43:57] (03Merged) 10jenkins-bot: Clear the surface observer when blurring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126169 (owner: 10Esanders) [23:45:56] (03PS1) 10Jforrester: Update VE core submodule to master (f1dd298) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126171 [23:46:13] (03CR) 10Jforrester: [C: 032] "Let's try this." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126171 (owner: 10Jforrester) [23:47:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (f1dd298) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126171 (owner: 10Jforrester)