[00:33:40] (03PS1) 10Jforrester: Enable the language tool as a Beta Feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126182 [01:11:14] (03PS1) 10Alex Monk: Fix name of advanced settings page in open command [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126187 [02:54:15] [13:42] mooeypoo I'm building a transaction now, and insertContent() takes an array of objects, but in the caption, I already have a document. Can I translate the document to that type of object to use with insertContent() or do I need to use the actual transaction in that case? [02:54:38] mooeypoo: I assume this is when you're translating an inline caption to a block caption or something? [02:54:56] There are several answers I could give depending on context [02:55:54] (03CR) 10Catrope: [C: 032] Fix name of advanced settings page in open command [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126187 (owner: 10Alex Monk) [02:57:07] (03CR) 10Catrope: "Which code path opens a dialog with a null fragment? The beta welcome dialog or something? Meta dialog?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126144 (owner: 10Trevor Parscal) [02:57:32] (03Merged) 10jenkins-bot: Fix name of advanced settings page in open command [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126187 (owner: 10Alex Monk) [03:53:54] RoanKattouw_away, indeed so. You can see what I"m trying to do here: https://gerrit.wikimedia.org/r/#/c/120808/11/modules/ve-mw/dm/models/ve.dm.MWImageModel.js [04:05:35] (03PS1) 10Mooeypoo: Fix border checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126193 [04:07:29] (03CR) 10Catrope: [C: 032] Fix border checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126193 (owner: 10Mooeypoo) [04:08:45] mooeypoo: OK, so the context is you're model-ifying image insertion and you need to insert a caption for block images [04:08:51] (03Merged) 10jenkins-bot: Fix border checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126193 (owner: 10Mooeypoo) [04:09:50] RoanKattouw, yeah, so, I remove the old image and insert a new one, just like with transclusion model -- so, if there's a caption, I have to include it in the insertion [04:09:53] From what I recall from ReferenceModel, the way it's done there IIRC is we insert an empty wrapper (internalItem in that case, mwImageCaption in your case), then use newFromDocumentInsertion (or newFromDocumentReplace or whatever it ended up being called) to insert the document into it [04:10:04] (I also have a problem REMOVING the damn image, but I'll go question-by-question :p ) [04:10:20] Hold on, when you say removing the old image and inserting a new one [04:10:26] Under what circumstances does that happen? [04:10:41] Clicking 'apply' on the edit. [04:10:52] That was Trevor's suggestion on doing this, so everything is always sync'ed. [04:11:05] So you want to regenerate the entire entire image? [04:11:13] the model keeps all the attributes of the new image sync'ed with all the rules, and at the end, it generates an image node to insert. [04:11:30] That will also make it clearer when changing from block to inline and back [04:11:36] Hmm [04:12:09] So for templates we almost certainly don't do this because all changes happen in the mw attribute, so it's just an attribute change [04:12:31] For references I find it hard to believe that we regenerate both the attributes and the content, we probably (hopefully?) update them separately [04:12:38] I was hoping we could do that here too [04:13:09] If the image already exists and continues to be a block image, change the attributes then do a newFromDocumentReplace on the caption [04:13:16] see line #126 https://gerrit.wikimedia.org/r/#/c/120808/11/modules/ve-mw/dm/models/ve.dm.MWImageModel.js [04:13:21] I went by the reference model example [04:13:32] Theoretically you could avoid the latter if the caption didn't change but whatever, I don't think we're that clever for references either [04:13:42] getting a node in (line 86) ... doing the magick... getting a node out. [04:13:57] Hm. [04:14:15] OK but surely when you edit an existing reference, MWReferenceModel doesn't do a full scorch-the-earth then insert-from-scratch? [04:15:13] I'm fine with cutting some of these corners like we did in MWReferenceModel but completely destroying everything every time is a bit much IMO [04:15:29] no, it either inserts or updates but it doesn't have the problem of inline/block translations [04:15:41] that's why I thought it would actually be more consistent this way. [04:16:55] the reference dialog goes by the choice of button -- 'insert' or edit (as far as I understand it at least) -- but since Images don't have it, and can change pretty radically between inline and block due to removing *other* attributes, I thought it made sense [04:17:09] so, if you have a frame image with alignment (like, framed/left) it's a block image. [04:17:14] without alignment, it's inline. [04:18:37] Stuff like that makes everything a bit complicated for consistency. But I can also add something to test if there's a need for a new node, I guess, and then either do what I did before (newFromAttributeChanges) or replacement. [04:25:56] Alright, well let's discuss this with Trevor tomorrow [04:26:44] What I would advocate is to do a newFromAttributeChanges on the image node plus a newFromDocumentReplacement on the caption contents, and special-case the case where we're switching from inline to block or vice versa [04:27:31] But if you want to move on while we figure that out, the building things from scratch approach should be pretty easy [04:28:02] The trick there is to first insert and empty caption node, then do a newFromDocumentReplacement of a zero-length range inside of it [04:28:09] *insert an empty [04:28:42] mooeypoo: So what's the problem with removing the image? [04:30:17] It doesn't get removed. [04:30:29] I think something's wrong with my ranges, but I am not sure. [04:30:47] I was trying to figure out the caption first. [04:31:13] wait, wait [04:31:17] first insert THEN remove? [04:31:59] RoanKattouw, but insertion requires only a single range point and deletion requires a whole range -- when we insert/remove we change the range values, so I though insert first and remove later made more sense ? [04:32:27] OK hold on [04:32:32] I'm talking about two different things [04:32:40] At the top level, you'd 1) remove the old image, 2) insert the new image [04:33:11] I argue that it should be less brute-force than that but that's a discussion that Trevor should be involved in, so ignore my objection to that for now [04:33:36] * mooeypoo nods [04:33:56] Yea, I understood Trevor suggested doing a whole removal/insertion but I may have misunderstood. [04:34:01] Then, at the next level down, the insertion will 2a) insert a block image containing an empty caption, 2b) do a newFromDocumentReplace in that empty caption, replacing emptiness with whatever you need to inject there [04:34:22] "emptiness" == "zero-length range inside caption" [04:34:31] Oh, so you FIRST insert the block image, then "add" the caption [04:34:32] ahhh [04:34:45] that makes sense. So I add an image with an empty caption, THEN add the action caption in. [04:34:49] Well, technically you insert it with the caption, then add the caption /contents/ by replacing nothing with them [04:34:52] Yes [04:35:00] This is what references do on creation too [04:35:03] * mooeypoo nods [04:35:09] oh that makes sense. [04:35:12] We create an empty internalItem, then do a document replacement inside of it [04:35:20] yeah I was a bit confused with the list items in the references. This makes sense. [04:36:13] The main differences with references is that 1) the contents live in an internalItem that's located elsewhere, 2) when you change the contents of an existing reference, we don't regenerate the internalItem but instead just do a document replacement again, replacing the old contents with the new contents [04:36:33] As I said I'm of the opinion that #2 should apply to images too [04:37:18] And I'm playing with the idea of applying #1 to images as well, it could simplify some things but we'd need to consider that carefully (this is totally out of scope for this conversation BTW) [04:37:36] * mooeypoo nods [04:38:22] I'd like to at least get this to work properly. We can then decide if we want to put it up and fix or change before we merge. [04:38:46] So I'll fix up the caption issue -- and hopefully the insertion too, tomorrow. [04:39:13] Although, you know, having a dialog that double-inserts images could be useful. [04:39:19] :p [04:40:13] haha [04:40:31] DYK we had a bug last week that inserted a citation after the reference instead of inside it? [04:40:50] In unmerged code, IIRC [04:41:11] So you'd get {{cite web|....}} instead of {{cite web|...}} [04:42:19] Re deletion: yeah, most probably something's wrong with the range you're passing. Things to look out for are: 1) you need the node's /outer/ range, 2) check if you're processing any other transactions a) between getting the range and using it, or b) between building the transaction and processing it [04:43:12] SurfaceFragment is designed to help you with 2a in general, but in this case you're just dealing with a node whose range you can compute whenever you need to, so you shouldn't need it [04:44:49] Useful debugging steps are: dump the range's contents using documentModel.getData( range ), and dump the resulting transaction (look at tx.operations, and in particular tx.operations[1] which should be the only one with .type !== 'retain') [04:45:47] If it's too much effort to go to the place where the transaction is built to inspect it, you can also dump transactions after they've been applied by looking at documentModel.completeHistory [04:46:01] Which as the name suggests is an array of every transaction that has ever been applied to the document [04:49:39] hmm. [04:49:50] I think I fond my idiotic mistake. [04:50:54] (03CR) 10Catrope: [C: 032] Buttons return false on mouse down [oojs/ui] - 10https://gerrit.wikimedia.org/r/125915 (owner: 10Esanders) [04:51:07] but the bug I'm getting is not really logical for that error.. interesting. SO, I'm using outer ranger to delete, but then outerrange.start to insert [04:51:22] (03Merged) 10jenkins-bot: Buttons return false on mouse down [oojs/ui] - 10https://gerrit.wikimedia.org/r/125915 (owner: 10Esanders) [04:51:23] you would expect this silly mistake would've failed on *insertion* though -- because there's no range after the node's gone [04:52:28] RoanKattouw, but it's actually failing on deletion. So.. either that's not the problem, or the mixup is confusing the code enough to do weird things. [05:00:32] No, the range object will stick around so that should be fine [05:00:43] What is the result right now? No deletion followed by insertion of the new image before the old image? [05:00:56] Or exception mega death? [05:01:45] yeah, insertion only. [05:01:50] no exception. [05:02:28] Does the new image get inserted before or after the old one? [05:02:31] (My hunch is before) [05:02:59] it is. Before. [05:03:06] Right, ok [05:03:07] What does that mean, doctor? [05:03:11] ;) [05:03:29] It almost certainly means that the transaction generated by newFromRemoval is a no-op with a single retain operation [05:03:33] seriously, I'm so baffled. IT *should* work.. I'm using outer range, the right surfacemodel.. meh. [05:03:43] i.e. [ {type: 'retain', length: document.length} ] [05:03:50] hm. [05:03:59] Why, though? [05:04:06] Can you show me the code where you're doing these things? [05:04:10] https://gerrit.wikimedia.org/r/#/c/120808/11/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js [05:04:10] I didn't see it in your commit offhand [05:04:17] line # 517 [05:04:21] that's the removal [05:04:33] Oh, hahaha [05:04:35] wait [05:04:37] Hi, can anyone tell me the current status of tables in VE, and if it's a while off, some recommendations for straight-forward extensions or workarounds? [05:04:39] dear god i just spotted it [05:04:42] Yeah I did too [05:04:42] there's no surfaceModel.change [05:04:45] Exactly [05:04:51] * mooeypoo headdesks [05:04:56] [05:05:05] You build a transaction object, then instead of applying it you just throw it away [05:05:08] Hence the "oh, hahaha" :) [05:05:10] haha [05:05:24] And then I wonder why it won't apply to the surface! [05:05:26] :D [05:05:54] dmotd: I don't know when the work is planned for exactly (that's a question for James_F ) but I do know that editing the contents of table cells works, it's just editing their structure like adding rows etc that doesn't work [05:06:12] And even that can sometimes be worked around by using copypaste in clever ways [05:08:05] RoanKattouw, thanks :) [05:10:03] You'd probably be able to get a better answer from James, but you may have to ask at a time that's closer to business hours PDT [05:10:33] I'm on IRC at 10pm and it's 1am for mooeypoo but not everyone is that crazy :) [05:11:08] oh, wow, it's 1am already. [05:12:39] hm. okay, now it gets deleted. Thanks RoanKattouw !! (Insertion is in the wrong place, but I think I know why) [05:13:59] RoanKattouw, yeah, fair enough.. ass end of the world here in australia so it's still daylight hours.. [09:04:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126182 (owner: 10Jforrester) [12:21:21] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [15:29:41] (03PS2) 10Jforrester: Enable the language tool as a Beta Feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126182 [15:29:51] (03CR) 10Jforrester: Enable the language tool as a Beta Feature (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126182 (owner: 10Jforrester) [15:30:16] (03PS11) 10Jforrester: Follow redirects in the category widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/118218 (owner: 10Alex Monk) [15:30:34] (03PS8) 10Jforrester: Re-split the transclusion dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125260 (owner: 10Trevor Parscal) [15:32:24] (03PS2) 10Jforrester: Hide the beta welcome via a preference, not a cookie, for logged in users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 [15:35:20] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (5c1c6de63a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126374 [15:37:10] (03CR) 10Siebrand: "This may merge-conflict soon." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126182 (owner: 10Jforrester) [15:52:24] (03PS1) 10Cmcmahon: [browser test] Save page is slow. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126595 [15:52:54] (03CR) 10Cmcmahon: [C: 032] [browser test] Save page is slow. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126595 (owner: 10Cmcmahon) [15:54:44] (03Merged) 10jenkins-bot: [browser test] Save page is slow. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126595 (owner: 10Cmcmahon) [17:02:52] (03PS2) 10Alex Monk: Always replace state with VE tag when loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125745 [17:10:45] (03PS12) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [17:10:57] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [17:25:59] (03PS1) 10Mooeypoo: Border checkbox disabling/enabling fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126726 [17:26:55] James_F, ^^ [17:27:36] fix of the fix of the fixing-fixy-fix. Oomph oomph, etc. [17:30:56] (03CR) 10Catrope: [C: 032] Border checkbox disabling/enabling fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126726 (owner: 10Mooeypoo) [17:31:00] * James_F grins. [17:32:20] (03Merged) 10jenkins-bot: Border checkbox disabling/enabling fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126726 (owner: 10Mooeypoo) [17:41:20] RoanKattouw: "We're releasing a bunch of possibly breaking code tomorrow" what sorts of breaking? [17:42:59] (03CR) 10Trevor Parscal: [C: 032] Allow the context to close any open inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 (owner: 10Esanders) [17:43:49] marktraceur: Not OOjs or OOjs UI breaking IIRC [17:44:06] Just rewriting the way we handle selection in VE [17:44:15] And also merging dialog tools and inspector tools [17:44:25] Lots of code flying but all in the VE world I think [17:44:40] marktraceur: I'll give you a more definitive answer after the pre-deployment review at 11:30 [17:44:44] VE and Maths inspector. [17:44:59] (which you're also welcome to just hover at, since it's at my desk, 10 feet away from your desk) [17:45:00] So one external affected, but not marktraceur's team. [17:45:08] RoanKattouw: marktraceur's WFH today. [17:45:44] Oh haha [17:45:45] OK [17:45:52] Well I'll tell you at noonish then [17:46:00] (03Merged) 10jenkins-bot: Allow the context to close any open inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125920 (owner: 10Esanders) [17:49:55] (03CR) 10Catrope: [C: 032] Only blur inputs within booklet pages when moving away [oojs/ui] - 10https://gerrit.wikimedia.org/r/125894 (owner: 10Trevor Parscal) [17:51:50] (03Merged) 10jenkins-bot: Only blur inputs within booklet pages when moving away [oojs/ui] - 10https://gerrit.wikimedia.org/r/125894 (owner: 10Trevor Parscal) [17:51:51] Don't scare me like that man [18:05:11] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (c58b498573) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126743 [18:07:32] (03Abandoned) 10Catrope: Update OOjs UI to v0.1.0-pre (5c1c6de63a) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126374 (owner: 10Jforrester) [18:08:13] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (c58b498573) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126743 (owner: 10Catrope) [18:09:08] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (c58b498573) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126743 (owner: 10Catrope) [18:09:43] (03PS1) 10Jforrester: Update VE core submodule to master (69db959) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126747 [18:17:23] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (69db959) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126747 (owner: 10Jforrester) [18:19:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (69db959) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126747 (owner: 10Jforrester) [18:25:35] (03CR) 10Catrope: [C: 032] Hide inspectors using new method when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125921 (owner: 10Esanders) [18:25:47] (03CR) 10Catrope: [C: 032] Make fieldsets render properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126044 (owner: 10Trevor Parscal) [18:27:06] (03Merged) 10jenkins-bot: Hide inspectors using new method when saving [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125921 (owner: 10Esanders) [18:27:18] (03Merged) 10jenkins-bot: Make fieldsets render properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126044 (owner: 10Trevor Parscal) [18:42:31] (03PS1) 10Catrope: Make inserting reference lists work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126817 [18:42:36] (03PS1) 10Catrope: Fix another surfaceModel.getFragment() in MWCitationDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126818 [18:43:52] (03CR) 10Jforrester: [C: 032] Make inserting reference lists work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126817 (owner: 10Catrope) [18:45:13] (03Merged) 10jenkins-bot: Make inserting reference lists work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126817 (owner: 10Catrope) [18:46:38] (03CR) 10Esanders: [C: 032] Fix another surfaceModel.getFragment() in MWCitationDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126818 (owner: 10Catrope) [18:48:00] (03Merged) 10jenkins-bot: Fix another surfaceModel.getFragment() in MWCitationDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126818 (owner: 10Catrope) [18:48:44] (03CR) 10Trevor Parscal: [C: 032] Always replace state with VE tag when loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125745 (owner: 10Alex Monk) [18:50:10] (03Merged) 10jenkins-bot: Always replace state with VE tag when loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125745 (owner: 10Alex Monk) [18:58:42] edsanders: https://gerrit.wikimedia.org/r/125911 [18:59:19] (03CR) 10Esanders: [C: 032] Focus the surface in the reference dialog after it opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125911 (owner: 10Catrope) [19:00:52] (03Merged) 10jenkins-bot: Focus the surface in the reference dialog after it opens [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125911 (owner: 10Catrope) [19:05:46] RoanKattouw, so I looked into https://bugzilla.wikimedia.org/show_bug.cgi?id=57536, looks like the saving code sends HTML off and does not handle wikitext [19:08:50] In JS yes [19:08:55] In PHP there should be wikitext involved however [19:10:23] Yeah, but this is about the JS side [19:13:49] So people want an opportunity to modify JS client-side before it gets saved? [19:13:58] That would be a major performance hit on save [19:14:32] Well maybe not major [19:14:36] Krenair: Are you sure? I thought this was PHP-side. [19:14:48] But we'd have to have to send all this data down to the client and back again [19:14:55] * James_F is willing to WONTFIX on JS-side hooks. [19:15:23] RoanKattouw, meh. I'm following your instructions here: https://www.mediawiki.org/wiki/VisualEditor/Debugging#To_inspect_HTML [19:15:26] and I'm getting errors. [19:15:32] I'm trying to inspect the HTML sent to parsoid [19:15:38] James_F, well the bug creator mentioned wikipage.content [19:16:06] We could piggyback it on the existing save prep request but I deliberately made that lightweight [19:16:07] I'm getting a really annoying inconsistency, trying to see if it's something I'm missing or if it might be a parsoid bug (I doubt it, I think I'm missing something) -- but can't properly inspect the html :\ [19:16:21] Krenair: What's wikipage.content exactly? [19:16:34] name of a core JS hook [19:16:37] Krenair: Client-side event hooks are not a sane way to develop code. [19:16:50] Krenair: … *sighs* [19:16:56] Krenair: OK, WONTFIXing. [19:16:59] ok [19:17:01] It seems like that hook doesn't interact with wikitext, but with HTML [19:17:10] Like, PHP parser HTML [19:17:33] RoanKattouw, I am getting "TypeError: Object # has no method 'getDomFromData'" [19:18:01] Are you using old code somewhere? [19:18:07] We renamed that to getDomFromModel ages ago [19:18:14] * mooeypoo follows your wiki page [19:18:21] https://www.mediawiki.org/wiki/VisualEditor/Debugging#To_inspect_HTML <-- this [19:18:43] ah, and yes, I think I remember things changed. Hm. ok [19:19:03] Oh I must not have updated those docs :( [19:19:27] I can start tracking down the code and fix, but if you happen to remember or have it handy, it'll save me a lot of time [19:19:54] Oh, there's another trick, that was introduced after these docs were written [19:20:13] If you want to inspect the document, you can simply open the save dialog, then look at ve.init.mw.targets[0].docToSave [19:20:24] I will update the docs [19:21:23] ooh [19:21:33] Updated [19:21:35] that will give me the HTML that's sent to parsoid? [19:21:39] Yeah [19:22:01] You do have to open the save dialog first, otherwise it's not generated [19:22:16] awesome, that works. [19:22:58] thanks RoanKattouw [19:27:38] (03PS1) 10Esanders: Use new dm surface method for checking undo history state [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126830 [19:28:08] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Refactor history state methods to better suit uses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126059 (owner: 10Esanders) [19:28:25] (03PS7) 10Catrope: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 (owner: 10Esanders) [19:29:09] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Refactor history state methods to better suit uses [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126059 (owner: 10Esanders) [19:37:12] (03CR) 10Catrope: [C: 032] Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 (owner: 10Esanders) [19:37:21] (03PS6) 10Catrope: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 (owner: 10Esanders) [19:38:10] (03Merged) 10jenkins-bot: Add system to dm.Surface for staging changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125923 (owner: 10Esanders) [19:40:16] (03CR) 10Catrope: [C: 04-1] "Looks fine, but there's a confusing variable name" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 (owner: 10Esanders) [19:49:24] (03PS7) 10Catrope: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 (owner: 10Esanders) [19:50:23] (03PS1) 10Esanders: Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 [19:50:25] (03CR) 10jenkins-bot: [V: 04-1] Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 (owner: 10Esanders) [19:51:01] (03CR) 10Catrope: [C: 032] Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 (owner: 10Esanders) [19:51:56] (03Merged) 10jenkins-bot: Only hide popups on selection change [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125931 (owner: 10Esanders) [19:52:18] (03PS2) 10Esanders: Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 [19:54:07] (03CR) 10jenkins-bot: [V: 04-1] Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 (owner: 10Esanders) [19:56:18] mooeypoo: Do you have a change in Gerrit that addresses https://bugzilla.wikimedia.org/show_bug.cgi?id=62293 ? [19:56:30] It's an old-ish bug that regressed after the scalable rewrite [20:02:02] (03PS3) 10Esanders: Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 [20:06:22] RoanKattouw, negative, I missed the fact it was reopened. [20:06:41] weird, I was supposed to get it in email.. hm. Okay, I can probably fix it now though. [20:06:42] (03CR) 10Catrope: [C: 04-1] Fix initial selection when focusing in Firefox (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 (owner: 10Esanders) [20:07:40] (03PS4) 10Esanders: Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 [20:08:39] (03CR) 10Catrope: [C: 032] Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 (owner: 10Esanders) [20:09:44] (03Merged) 10jenkins-bot: Fix initial selection when focusing in Firefox [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126835 (owner: 10Esanders) [20:11:12] (03PS13) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [20:11:23] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [20:15:11] (03PS1) 10Esanders: Document focus/blur cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126840 [20:18:31] (03CR) 10Catrope: [C: 032] Document focus/blur cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126840 (owner: 10Esanders) [20:19:35] (03Merged) 10jenkins-bot: Document focus/blur cleanup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126840 (owner: 10Esanders) [20:22:59] James_F, RoanKattouw_away, I can't replicate this bug in master. https://bugzilla.wikimedia.org/show_bug.cgi?id=62293 [22:08:33] James_F: Details re mobile breakage? [22:09:05] I can't find anything very weird in the Context/DesktopContext changes and MobileContext is like 60 lines so I was able to inspect it and determine that it shouldn't be broken in like 30 seconds [22:10:43] ryasmeen: Is there a bug filed about the first-character bug in the media dialog? [22:11:08] I have a fix ready (it was pretty easy, basically the same problem as in the reference dialog) but if there's a bug for it I should tag it against that [22:11:40] RoanKattouw: No i didnt file any separate bug for it, just reopened the one for reference dialog , i thought it is related [22:11:50] Oh OK [22:12:17] 63909, got it [22:13:08] Also RoanKattouw: Regarding mobile breakage, can you reproducing this one:https://bugzilla.wikimedia.org/show_bug.cgi?id=64032 [22:13:21] *can you try * [22:13:36] (03PS1) 10Catrope: Also focus surface in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126855 [22:14:32] Ouch [22:14:35] Yeah lemme look at that [22:14:40] edsanders: https://gerrit.wikimedia.org/r/126855 [22:15:48] (03CR) 10Esanders: [C: 032] Also focus surface in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126855 (owner: 10Catrope) [22:17:16] (03Merged) 10jenkins-bot: Also focus surface in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126855 (owner: 10Catrope) [22:26:53] (03CR) 10Jforrester: [C: 031] Add checkboxes to set some metadata on page metadata panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126015 (owner: 10Alex Monk) [22:28:40] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=63739 should be fixed now [22:29:18] Oh, yes, forgot that one. [22:29:19] Thanks. [22:29:43] actually I could've probably marked it myself, guess the milestone is tomorrow's deployment [22:29:58] Yes, :-) [22:30:05] But I'm happy to do it. [22:31:36] RoanKattouw: [22:31:45] oops [22:31:54] rmoen: [22:31:55] ;-) [22:32:00] ;) [22:37:42] ryasmeen: I can't test VE on mobile beta labs right this second because MobileFrontend is broken, but I submitted a fix for that to the mobile team and they're merging it [22:37:56] So hopefully that'll get there soon and I'll actually be able to start trying to reproduce your bug :S [22:39:49] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=63127 was the Firefox icon position bug I showed you. :-) [22:53:23] (03PS1) 10Esanders: [BREAKING CHANGE] Separate Widget styles properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126861 [22:53:27] (03PS1) 10Esanders: Add reference to DimensionsWidget.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126862 [22:54:43] (03CR) 10jenkins-bot: [V: 04-1] Add reference to DimensionsWidget.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126862 (owner: 10Esanders) [22:56:03] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Separate Widget styles properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126861 (owner: 10Esanders) [22:57:06] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Separate Widget styles properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126861 (owner: 10Esanders) [22:58:12] (03PS2) 10Catrope: Update VE core submodule to master (4366f20) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126830 (owner: 10Esanders) [22:58:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (4366f20) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126830 (owner: 10Esanders) [23:00:50] (03Merged) 10jenkins-bot: Update VE core submodule to master (4366f20) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126830 (owner: 10Esanders) [23:03:11] (03PS2) 10Catrope: Update VE core submodule to master (2d96306) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126862 (owner: 10Esanders) [23:03:41] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (2d96306) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126862 (owner: 10Esanders) [23:05:59] (03Merged) 10jenkins-bot: Update VE core submodule to master (2d96306) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126862 (owner: 10Esanders) [23:16:58] Sigh. MW and VE are up to date. Why do I get console errors when trying to load VE? [23:17:39] Krenair: Error msg? [23:17:43] Also, is MW core up to date? [23:23:54] (03PS1) 10Catrope: Followup 099f26ec: fix $content in FieldsetLayout [oojs/ui] - 10https://gerrit.wikimedia.org/r/126869 [23:26:25] (03PS1) 10Catrope: Make the Add template button not wrap to the next line [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126871 [23:28:36] (03PS1) 10Esanders: Check for left click and disabled state on ButtonedElements [oojs/ui] - 10https://gerrit.wikimedia.org/r/126872 [23:30:05] RoanKattouw, yeah, MW core and the VE extension both have the latest master [23:30:10] Uncaught Error: Unknown dependency: jquery.delayedBind [23:35:58] Oh [23:36:02] Krenair: Update WikiEditor [23:36:15] * RoanKattouw is glad he happened to catch that particular conversation the other day [23:40:38] RoanKattouw, I think it had been occurring twice, now it happens once... [23:44:26] edsanders: https://gerrit.wikimedia.org/r/126871 [23:57:32] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/126871/ [23:57:59] (03CR) 10Trevor Parscal: [C: 032] Make the Add template button not wrap to the next line [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126871 (owner: 10Catrope) [23:59:27] (03Merged) 10jenkins-bot: Make the Add template button not wrap to the next line [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126871 (owner: 10Catrope)