[00:04:10] (03PS1) 10Esanders: Use forced directionality for HieroInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127186 [00:04:43] (03CR) 10Jforrester: [C: 032] Use forced directionality for HieroInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127186 (owner: 10Esanders) [00:06:45] (03Merged) 10jenkins-bot: Use forced directionality for HieroInspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127186 (owner: 10Esanders) [00:22:19] (03CR) 10Jforrester: [C: 032] Add whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126983 (owner: 10Nikerabbit) [00:23:44] (03Merged) 10jenkins-bot: Add whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126983 (owner: 10Nikerabbit) [00:25:00] (03CR) 10Jforrester: "@Krinkle:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 (owner: 10Jforrester) [00:25:44] (03PS3) 10Esanders: Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [00:29:22] (03PS4) 10Esanders: Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [00:35:01] (03PS5) 10Esanders: Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [00:36:52] (03PS6) 10Esanders: Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [00:56:13] (03PS7) 10Esanders: Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [00:57:27] (03PS1) 10Esanders: Make Hiero node live update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127192 [00:57:39] (03CR) 10jenkins-bot: [V: 04-1] Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [00:57:43] edsanders: Ooh, fancy. [00:58:52] (03CR) 10jenkins-bot: [V: 04-1] Make Hiero node live update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127192 (owner: 10Esanders) [00:59:08] (03PS2) 10Esanders: Make Hiero node live update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127192 [00:59:10] (03PS8) 10Esanders: Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [00:59:39] no extra statics required now [01:00:25] * James_F nods. [02:12:29] (03CR) 10Jforrester: [C: 031] Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [04:15:10] (03CR) 10Krinkle: [C: 032] "This isn't going to work for the medium/long term, phantomjs will very soon not be able to keep up with VE on a UI/integration level (it m" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 (owner: 10Jforrester) [04:15:34] (03CR) 10Krinkle: "Is there a bug report or anything about that?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 (owner: 10Jforrester) [04:16:52] (03Merged) 10jenkins-bot: Remove Function.prototype.bind from compatibility check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126920 (owner: 10Jforrester) [04:21:57] (03CR) 10Krinkle: [C: 032] Remove getVersion from api module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126984 (owner: 10Nikerabbit) [04:23:24] (03Merged) 10jenkins-bot: Remove getVersion from api module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126984 (owner: 10Nikerabbit) [15:33:23] (03PS1) 10Zfilipin: [browser test] Run all Selenium tests in Firefox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127258 [15:34:15] (03CR) 10Cmcmahon: [C: 032] [browser test] Run all Selenium tests in Firefox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127258 (owner: 10Zfilipin) [15:37:53] (03Merged) 10jenkins-bot: [browser test] Run all Selenium tests in Firefox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127258 (owner: 10Zfilipin) [16:38:30] (03PS1) 10Cmcmahon: [browser test] increase wait for save to complete [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127270 [16:39:37] (03CR) 10Cmcmahon: [C: 032] [browser test] increase wait for save to complete [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127270 (owner: 10Cmcmahon) [16:41:04] (03Merged) 10jenkins-bot: [browser test] increase wait for save to complete [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127270 (owner: 10Cmcmahon) [17:43:51] James_F|Away: lol, I'm in ur js deleting css [17:43:55] https://am.wikipedia.org/w/index.php?title=%E1%88%98%E1%88%8D%E1%8B%95%E1%8A%AD%E1%89%B5%3ACommon.js&diff=prev&oldid=314043 [17:43:56] classic [18:08:02] (03CR) 10Krinkle: Hide the beta welcome via a preference, not a cookie, for logged in users (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (owner: 10Jforrester) [18:10:40] (03CR) 10Krinkle: Hide the beta welcome via a preference, not a cookie, for logged in users (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (owner: 10Jforrester) [18:15:33] Krinkle: Yes. [18:15:38] (03CR) 10Krinkle: [C: 04-1] Use CSS to style figure and figcaption (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [18:17:10] (03CR) 10GWicke: Use CSS to style figure and figcaption (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [18:22:24] (03CR) 10Trevor Parscal: [C: 032] Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [18:22:33] (03CR) 10Trevor Parscal: [C: 032] Make Hiero node live update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127192 (owner: 10Esanders) [18:23:52] (03Merged) 10jenkins-bot: Create MWLiveExtensionInspector base class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126900 (owner: 10Jforrester) [18:23:59] (03Merged) 10jenkins-bot: Make Hiero node live update [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127192 (owner: 10Esanders) [18:24:41] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/126901/ [18:28:37] TrevorParscal: Plz CR https://gerrit.wikimedia.org/r/126921 [18:31:28] (03CR) 10Trevor Parscal: [C: 032] Clear inspector fragment from teardown(), not close() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126921 (owner: 10Catrope) [18:32:52] (03Merged) 10jenkins-bot: Clear inspector fragment from teardown(), not close() [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126921 (owner: 10Catrope) [18:39:34] (03CR) 10Trevor Parscal: [C: 032] Tests for ce.Surface#getNearestCorrectOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127182 (owner: 10Esanders) [18:39:46] (03CR) 10Catrope: [C: 032] Add getCurrentItem method [oojs/ui] - 10https://gerrit.wikimedia.org/r/127120 (owner: 10Trevor Parscal) [18:40:19] (03Merged) 10jenkins-bot: Add getCurrentItem method [oojs/ui] - 10https://gerrit.wikimedia.org/r/127120 (owner: 10Trevor Parscal) [18:40:45] (03Merged) 10jenkins-bot: Tests for ce.Surface#getNearestCorrectOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127182 (owner: 10Esanders) [18:43:50] (03CR) 10Jforrester: Hide the beta welcome via a preference, not a cookie, for logged in users (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (owner: 10Jforrester) [18:47:49] RoanKattouw: Regression 2 is https://bugzilla.wikimedia.org/show_bug.cgi?id=64034 [18:48:06] RoanKattouw: Regression 1 was fixed by Ed (my fault) and is cherry-picked awaiting Monday's SWAT. [18:51:10] (03CR) 10Catrope: [C: 04-1] Add aggregate method (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/127121 (owner: 10Trevor Parscal) [18:52:02] (03PS2) 10Trevor Parscal: Add aggregate method [oojs/ui] - 10https://gerrit.wikimedia.org/r/127121 [18:54:21] (03CR) 10Catrope: [C: 032] Add aggregate method [oojs/ui] - 10https://gerrit.wikimedia.org/r/127121 (owner: 10Trevor Parscal) [18:54:44] (03CR) 10Catrope: [C: 032] Remove animation of grid layout inside booklets [oojs/ui] - 10https://gerrit.wikimedia.org/r/127165 (owner: 10Trevor Parscal) [18:54:50] (03Merged) 10jenkins-bot: Add aggregate method [oojs/ui] - 10https://gerrit.wikimedia.org/r/127121 (owner: 10Trevor Parscal) [18:55:27] (03Merged) 10jenkins-bot: Remove animation of grid layout inside booklets [oojs/ui] - 10https://gerrit.wikimedia.org/r/127165 (owner: 10Trevor Parscal) [18:58:28] (03PS2) 10Esanders: Add focusing state flag to ce.Surface when programatically focusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127136 [18:58:33] (03CR) 10Catrope: [C: 04-1] Add push/pop pending to Dialog (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/127166 (owner: 10Trevor Parscal) [19:01:16] (03PS3) 10Trevor Parscal: Add push/pop pending to Dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/127166 [19:01:28] (03PS4) 10Trevor Parscal: Add push/pop pending to Dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/127166 [19:11:43] (03CR) 10Catrope: [C: 032] Disable transclusion dialog mode button while loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127168 (owner: 10Trevor Parscal) [19:12:33] (03CR) 10Catrope: [C: 032] Add push/pop pending to Dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/127166 (owner: 10Trevor Parscal) [19:13:02] (03Merged) 10jenkins-bot: Add push/pop pending to Dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/127166 (owner: 10Trevor Parscal) [19:13:11] (03Merged) 10jenkins-bot: Disable transclusion dialog mode button while loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127168 (owner: 10Trevor Parscal) [19:21:09] (03PS1) 10Trevor Parscal: Make dialog overlays... overlaid? [oojs/ui] - 10https://gerrit.wikimedia.org/r/127292 [19:22:37] (03CR) 10Catrope: [C: 032] "Overlain?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/127292 (owner: 10Trevor Parscal) [19:22:47] (03CR) 10Catrope: [C: 032] Check useeditwarning preference before showing warning when browsing away from editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126994 (owner: 10Alex Monk) [19:23:12] (03Merged) 10jenkins-bot: Make dialog overlays... overlaid? [oojs/ui] - 10https://gerrit.wikimedia.org/r/127292 (owner: 10Trevor Parscal) [19:24:24] (03Merged) 10jenkins-bot: Check useeditwarning preference before showing warning when browsing away from editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/126994 (owner: 10Alex Monk) [19:29:50] (03CR) 10Alex Monk: [C: 04-1] "ugh, pushes the saving animation bar thing below the button" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127004 (owner: 10Alex Monk) [19:34:58] Krenair: hey! [19:35:08] did you see the dialog push/pop pending stuff that just landed? [19:35:20] Use that instead of the saving animation bar [19:37:34] haha I love that you guys discovered that bug independently [19:38:20] TrevorParscal, Krenair: Lemme do an oojs-ui pull-through so he can actually use it [19:54:50] TrevorParscal, hey. no I didn't [19:56:16] TrevorParscal, nice, will try it in a moment [20:00:01] Let me do a pull-through for that now [20:00:19] Got distracted with MobileFrontend stuff [20:02:08] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (989950a4db) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127348 [20:02:31] TrevorParscal: ---^^ merge plz [20:02:45] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (989950a4db) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127348 (owner: 10Catrope) [20:02:59] Thanks [20:03:08] TrevorParscal: And https://gerrit.wikimedia.org/r/127349 too? [20:04:06] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (989950a4db) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127348 (owner: 10Catrope) [20:10:35] (03CR) 10Catrope: [C: 032] Make transclusion dialog "pending" while loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127169 (owner: 10Trevor Parscal) [20:10:51] Krenair: https://gerrit.wikimedia.org/r/#/c/127169/ is an example of how to use the push/pop pending stuff [20:12:07] (03Merged) 10jenkins-bot: Make transclusion dialog "pending" while loading [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127169 (owner: 10Trevor Parscal) [20:12:25] (03PS1) 10Trevor Parscal: Reorganize stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127353 [20:12:40] (03PS1) 10Catrope: Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 [20:13:37] (03PS1) 10Trevor Parscal: Reorganize stylesheets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127357 [20:13:53] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/127356/ https://gerrit.wikimedia.org/r/127354 [20:14:13] (03CR) 10Trevor Parscal: [C: 032] Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [20:14:37] (03PS1) 10Catrope: Update VE core submodule to master (a2ddd0c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127359 [20:14:58] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (a2ddd0c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127359 (owner: 10Catrope) [20:15:17] (03CR) 10jenkins-bot: [V: 04-1] Reorganize stylesheets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127357 (owner: 10Trevor Parscal) [20:16:52] (03CR) 10Catrope: [C: 04-1] Reorganize stylesheets (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127353 (owner: 10Trevor Parscal) [20:17:47] (03CR) 10Catrope: Reorganize stylesheets (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127353 (owner: 10Trevor Parscal) [20:19:03] (03Merged) 10jenkins-bot: Update VE core submodule to master (a2ddd0c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127359 (owner: 10Catrope) [20:19:25] (03PS2) 10Trevor Parscal: Reorganize stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127353 [20:21:03] (03PS1) 10Esanders: Create requestParsoid method for all requests to Parsoid API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127361 [20:21:05] (03PS1) 10Esanders: Use Parsoid API for action=parsefragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127362 [20:25:28] (03CR) 10Catrope: [C: 032] Reorganize stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127353 (owner: 10Trevor Parscal) [20:26:35] (03Merged) 10jenkins-bot: Reorganize stylesheets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127353 (owner: 10Trevor Parscal) [20:29:43] (03PS2) 10Catrope: Update VE core submodule to master (33ca43b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127357 (owner: 10Trevor Parscal) [20:29:48] RoanKattouw, TrevorParscal: Okay, so this replaces the current loading bar.. thing? [20:29:53] Yeah [20:30:01] It should [20:30:12] maybe I should do this in a separate commit [20:47:18] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (33ca43b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127357 (owner: 10Trevor Parscal) [20:48:44] (03Merged) 10jenkins-bot: Update VE core submodule to master (33ca43b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127357 (owner: 10Trevor Parscal) [20:50:36] (03PS1) 10Alex Monk: Use new OOUI pending feature rather than loading bar thing on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127366 [20:50:47] (03CR) 10jenkins-bot: [V: 04-1] Use new OOUI pending feature rather than loading bar thing on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127366 (owner: 10Alex Monk) [20:51:15] (03PS1) 10Amire80: Add GENDER to visualeditor-dialog-transclusion-no-template-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127367 [20:51:26] (03CR) 10jenkins-bot: [V: 04-1] Add GENDER to visualeditor-dialog-transclusion-no-template-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127367 (owner: 10Amire80) [20:51:34] I haven't run VE on my machine for a while. Parsoid installation is completely different now. [21:00:46] (03PS2) 10Amire80: Add GENDER to visualeditor-dialog-transclusion-no-template-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127367 [21:02:17] (03CR) 10jenkins-bot: [V: 04-1] Add GENDER to visualeditor-dialog-transclusion-no-template-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127367 (owner: 10Amire80) [21:03:39] (03PS2) 10Alex Monk: Use new OOUI pending feature rather than loading bar thing on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127366 [21:04:49] (03PS3) 10Amire80: Add GENDER to visualeditor-dialog-transclusion-no-template-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127367 [21:06:01] RoanKattouw, hey, is https://gerrit.wikimedia.org/r/127366 what you were expecting? [21:09:21] Looking [21:09:53] Code-wise yes [21:09:58] Does it behave the way you expect? [21:12:06] RoanKattouw, hm... the background of the save dialog is shown as pending but the background of the panel isn't... I wonder if it should be [21:12:17] I think that's intentional [21:12:27] But I'll ask Trevor why he did that when he comes back [21:18:02] (03CR) 10Catrope: [C: 032] Add GENDER to visualeditor-dialog-transclusion-no-template-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127367 (owner: 10Amire80) [21:19:11] (03CR) 10Catrope: [C: 032] Use new OOUI pending feature rather than loading bar thing on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127366 (owner: 10Alex Monk) [21:19:31] (03Merged) 10jenkins-bot: Add GENDER to visualeditor-dialog-transclusion-no-template-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127367 (owner: 10Amire80) [21:20:52] (03Merged) 10jenkins-bot: Use new OOUI pending feature rather than loading bar thing on save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127366 (owner: 10Alex Monk) [21:29:17] RoanKattouw and co' anything controversial with https://gerrit.wikimedia.org/r/#/c/125269/ ? [21:29:36] I don't know [21:29:43] We'll have to be careful though [21:29:59] The last few times things were split like that, display things broke [21:30:19] Other than that it's probably fine, you just need to get Trevor or Timo to review it [21:30:24] And Timo's been traveling back home [21:36:52] RoanKattouw_away: roger [21:48:55] (03PS1) 10Jforrester: [Browser tests] Updated list of production wikis to check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127373 [21:54:46] (03PS2) 10Alex Monk: Add cancel & discard changes button to save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127004 [21:56:59] (03PS2) 10Jforrester: [Browser tests] Updated list of production wikis to check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127373 [22:02:44] (03CR) 10Cmcmahon: [C: 032] [Browser tests] Updated list of production wikis to check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127373 (owner: 10Jforrester) [22:04:09] (03Merged) 10jenkins-bot: [Browser tests] Updated list of production wikis to check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127373 (owner: 10Jforrester) [23:16:59] James_F, do you know the bug number for the missing bullet point [23:32:33] edsanders: https://bugzilla.wikimedia.org/show_bug.cgi?id=64117 [23:59:50] (03CR) 10Catrope: [C: 032] Create requestParsoid method for all requests to Parsoid API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127361 (owner: 10Esanders)