[00:01:19] (03Merged) 10jenkins-bot: Create requestParsoid method for all requests to Parsoid API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127361 (owner: 10Esanders) [00:01:35] (03PS2) 10Krinkle: Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [00:02:18] (03CR) 10GWicke: [C: 031] Use Parsoid API for action=parsefragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127362 (owner: 10Esanders) [00:02:49] (03PS1) 10Esanders: Remove unnecessary overflow:hidden from block slug style [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127387 [00:12:18] (03CR) 10Catrope: [C: 032] Use Parsoid API for action=parsefragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127362 (owner: 10Esanders) [00:13:37] Krenair: Oh dear. [00:13:41] Err. [00:13:43] Krinkle: Oh dear.. [00:13:45] (03Merged) 10jenkins-bot: Use Parsoid API for action=parsefragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127362 (owner: 10Esanders) [00:13:47] (Sorry Krenair.) [00:13:59] (03PS1) 10Catrope: Set context title when rendering edit notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127388 [00:14:55] James_F: Yes? [00:15:03] James_F: I'm fixing oojs-ui update to not forget new files [00:15:05] Krinkle: https://gerrit.wikimedia.org/r/#/c/127354/ is very not good. [00:15:09] and to delete files as needed [00:15:11] Indeed [00:15:21] there's two problems [00:15:22] Krinkle: C+2s are not meant to be preserved between rebases/trivial changes/etc. [00:15:32] Krinkle: Just C[+-]1. [00:15:57] git commit dir/ -m "message"; that first dir argument auto-stages changes in that directory, but not new files. [00:15:59] (The "Zuul forgot about this patch" issue is regrettable but not new.) [00:16:09] and cp -a dir/i18n dir/ does not copy new files either [00:16:13] * James_F nods. [00:16:13] So it seems [00:16:41] (03CR) 10Krinkle: [C: 04-1] Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [00:17:14] (03CR) 10Krinkle: "(clear)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [00:49:25] (03PS1) 10Krinkle: build: Update jscs config and phase out deprecated jshint config [oojs/core] - 10https://gerrit.wikimedia.org/r/127395 [00:49:27] (03PS1) 10Krinkle: build: Clean up grunt task and update grunt-contrib-watch [oojs/core] - 10https://gerrit.wikimedia.org/r/127396 [00:50:24] Krinkle: Won't https://gerrit.wikimedia.org/r/#/c/127394/1/maintenance/resources/update-oojs.sh delete update-oojs.sh? [00:50:49] (03PS1) 10Krinkle: oojs-update.sh: Update to match version of script in mediawiki-core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127397 [00:51:15] James_F: ? [00:51:22] Why would it? [00:51:33] Krinkle: "rsync --recursive --delete --force" [00:51:37] Yes? [00:51:45] Delete destination directory, add new files [00:51:49] Yeah. [00:52:09] update-oojs.sh is in that destination directory. [00:52:09] I guess your mind is out of sync with where the script is [00:52:09] it's in maintenance [00:52:16] It is not [00:52:18] Oooh. Did we move it? [00:52:25] Yes, I had you do it in fact. [00:52:34] This feels great by the way :P [00:53:08] When we did src/ and lib/ we noticed those sh files creeping there [00:53:11] I then moved them [00:53:11] Aha, in https://gerrit.wikimedia.org/r/#/c/124479/. [00:53:15] and you +2'ed [00:53:19] You only moved the oojs.sh one. [00:53:29] The oojs-ui.sh one is still in /lib. [00:53:33] I think? [00:53:34] For now [00:53:36] Yeaj [00:53:41] You going to move it, then? :-) [00:53:42] I'm going to pretty that one up first in ve, and then update in core [00:53:48] Like with oojs one [00:53:48] OK, that works for me. [00:53:50] * James_F nods. [00:53:52] cause they both have bugs [00:54:13] the adding new files isn't much of an issue with oojs core since we don't ahve images or i18n [00:54:21] but certainly is with oojs ui [00:54:23] Indeed. [00:54:45] OK, this looks good to me. (127394 that is.) Content for me to +2? [00:56:45] (03PS2) 10Krinkle: oojs-update.sh: Update to match version of script in mediawiki-core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127397 [00:57:02] (03CR) 10Krinkle: "Fixed "..." to ".." (one too many dots)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127397 (owner: 10Krinkle) [00:57:47] James_F: I don't trust my working copy to test the script, can you run a test for it as well in both mwcore and ve (I'm assuming you'd do that anyway, but just in case) [00:57:51] yeah, go for it :) [00:58:11] Yeah, I tested it. Worked fine. [00:58:17] Though to be fair I only tested it on null. [00:58:49] OK, I'll merge 127395 in OOjs and then test it. [00:59:48] (03CR) 10Jforrester: [C: 032] build: Update jscs config and phase out deprecated jshint config [oojs/core] - 10https://gerrit.wikimedia.org/r/127395 (owner: 10Krinkle) [01:00:10] (03Merged) 10jenkins-bot: build: Update jscs config and phase out deprecated jshint config [oojs/core] - 10https://gerrit.wikimedia.org/r/127395 (owner: 10Krinkle) [01:00:22] (03CR) 10Jforrester: [C: 032] build: Clean up grunt task and update grunt-contrib-watch [oojs/core] - 10https://gerrit.wikimedia.org/r/127396 (owner: 10Krinkle) [01:00:45] (03Merged) 10jenkins-bot: build: Clean up grunt task and update grunt-contrib-watch [oojs/core] - 10https://gerrit.wikimedia.org/r/127396 (owner: 10Krinkle) [01:03:53] Eurgh, now I can't test it. [01:04:05] "No compatible version found: oojs@'/Users/jdforrester/Documents/git/oojs/' " [01:04:10] Which is good, but… [01:04:33] I really don't want to release a new version of OOjs just for this. :-) [01:04:43] James_F: Hold on, I found another small dirty spot I'd like to polish while at it (the "x$FOO" == "x" stuff and != "") [01:04:49] Ah, right. [01:04:51] Yeah. [01:04:57] I believe that it works. [01:05:00] James_F: I'll let you know how you can test it in just a sec. [01:05:03] But will hold on. :-) [01:08:54] (03PS3) 10Krinkle: oojs-update.sh: Update to match version of script in mediawiki-core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127397 [01:12:25] Krinkle: Thoughts on my CR? [01:13:16] James_F: Right, that was ahead for oojsui-update, which will contain both and the x trick [01:13:19] removed for there [01:13:21] * James_F nods. [01:13:45] Good enough for me. [01:14:28] James_F: Hm.. looking in the ui script I see we have \ on multiline things with || and && [01:14:34] I didn't do that here, I guess it works without? [01:15:01] It does, it's just for niceness of reading. [01:15:06] k [01:15:25] Ah, that's for piping though [01:15:30] Yes. [01:15:32] a single statement, instead of multiple statements [01:15:44] Though I guess they might be optional there as well [01:17:45] (03CR) 10Jforrester: [C: 032] oojs-update.sh: Update to match version of script in mediawiki-core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127397 (owner: 10Krinkle) [01:19:17] (03Merged) 10jenkins-bot: oojs-update.sh: Update to match version of script in mediawiki-core [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127397 (owner: 10Krinkle) [01:24:02] James_F: Hm.. is it intentional that update-oojsui does not check out latest master in oojs-ui dir? [01:24:09] It just sticks to whatever state it is in [01:24:43] Hm.. the oojs script did that too [01:24:51] I guess it makes sense in some way, just checking [01:35:32] (03CR) 10Krinkle: Add aggregate method (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/127121 (owner: 10Trevor Parscal) [01:36:04] (03PS1) 10Krinkle: update-oojsui.sh: Replace target dir instead of adding file copies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 [01:36:22] (03PS2) 10Krinkle: update-oojs-ui.sh: Replace target dir instead of adding file copies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 [01:40:03] James_F, RoanKattouw_away: https://bugzilla.wikimedia.org/show_bug.cgi?id=63600 might be related to https://bugzilla.wikimedia.org/show_bug.cgi?id=59608 [01:40:27] Krinkle: Yes, it's intentional. [01:40:33] OK [01:40:38] Krinkle: Allows non-master checkout pulls. [01:40:53] In that case I'll also leave "grunt" as-is instead of reducing it to "grunt build", so that we also still run unit tests [01:40:55] Krenair: Hmm, really? [01:40:57] (seems wise for a non-master build) [01:41:01] Krinkle: Indeed. :-) [01:41:34] Krenair: That'd be… odd. [01:42:01] Krenair: Can you replicate bug 63600 locally? [01:42:10] Krenair: If so, and https://gerrit.wikimedia.org/r/127388 fixes it, awesome. :-) [01:43:10] I've actually just been trying to test this patch on beta [01:43:17] PHP fatal error in /srv/common-local/php-master/extensions/VisualEditor/ApiVisualEditor.php line 304: Call to undefined method ApiVisualEditor::setTitle() [01:43:29] Ho-hum. [01:44:07] probably $this->getContext()->setTitle( $page ) [01:44:22] * James_F blames RoanKattouw_away totally. [01:44:36] It's not just that he wrote this patch, he wrote what this patch is fiddling with too. ;-) [01:45:56] (03PS3) 10Krinkle: update-oojs-ui.sh: Replace target dir instead of adding file copies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 [01:46:27] Krinkle: Are you not also going to do this in mw-core? [01:46:39] Krinkle: 'Cos this build script is almost entirely pointless. [01:47:12] (03PS3) 10Krinkle: Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [01:47:40] James_F: Yeah, once this refactor of update-oojs-ui is good, I'll copy it to core, just like with the oojs-core one [01:47:46] Kk. [01:48:02] Aha, you finally ridded us of images/fade-down.png etc. :-) [01:48:12] Oh, but boo, you copied oojs-ui.css [01:48:19] We've been explicitly excluding that. [01:48:24] (03CR) 10Krinkle: [C: 04-1] "Header doesn't have -pre." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [01:48:30] (03CR) 10Alex Monk: [C: 04-1] Set context title when rendering edit notices (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127388 (owner: 10Catrope) [01:48:38] 'Cos it's a pointless never-used build file for MW. [01:49:09] James_F, yeah I tested the fixed version of that patch, fixes the issue (which I can replicate on deployment-prep, btw) [01:49:18] Krenair: Nice! [01:49:29] Unfortunately doesn't fix the FR bug. I have another solution for that, but it's the wrong solution [01:49:35] Krenair: With the s/$this/$this->getContent()/ change? [01:49:39] I don't see much harm in excluding it from the dist copy though. For one, because this is VE not ve-mw, and it's harmless as long as it isn't referenced in modules manifest [01:49:41] * James_F grins. [01:49:42] James_F, yep [01:49:47] getContext() [01:49:53] Yeah, sorry. [01:50:05] I guess if we do exclude it, we should exclude other build variants as well [01:50:06] Krinkle: Built files in /lib that are unused are bad smells. [01:50:08] and just stuck to one [01:50:29] Yes, ideally we'd fix this in oojs-ui's build script ("only build me the svg version"). [01:51:36] (03PS4) 10Krinkle: Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [01:52:16] (03CR) 10Krinkle: "Ran, this time actually with update-oojsui.sh script of Id97a66df64 (In the previous patch it built using grunt-build instead of grunt-tes" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [01:53:30] James_F: Ah, right, the plain oojs-ui.css isn't non-theme, it's non-svg [01:53:37] Indeed. [01:53:57] Actually, it's oojs-ui.png.css but not named as such for some reason. [01:54:12] yeah [01:54:23] It was done that way to provide a default without needing to make a choice [01:54:24] Ideally we'd call them -vector and -raster rather than be tied to the file format. [01:54:43] well, browser support is tied to png and svg respectively [01:54:49] anyway [01:54:59] * James_F nods. [01:56:21] fixing [01:58:08] (03CR) 10Krinkle: "btw, to bypass that guard, apply before running the script after checking out Id97a66df64:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [01:58:22] Also, it's update-oojs-ui.sh, not update-oojsui.sh [02:00:19] (03PS5) 10Krinkle: Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [02:00:37] (03PS4) 10Krinkle: update-oojs-ui.sh: Replace target dir instead of adding file copies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 [02:00:55] Krenair: Sad that Roan's fix doesn't fix bug 59608 though. :-( [02:01:30] I fixed that a few patch sets back [02:01:30] https://gerrit.wikimedia.org/r/#/c/127401/1..2//COMMIT_MSG [02:01:48] But not in https://gerrit.wikimedia.org/r/#/c/127354/ :-) [02:02:00] (03PS6) 10Krinkle: Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [02:02:03] right [02:02:04] * James_F re-reviews. [02:02:28] 127401 LGTM, provisionally. Make the MW-core version (in maintenance/resources/…)? [02:04:59] (03CR) 10Jforrester: update-oojs-ui.sh: Replace target dir instead of adding file copies (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 (owner: 10Krinkle) [02:05:19] James_F, a slightly different patch fixes 59608. Same position in the same file, except: RequestContext::getMain()->setTitle( $page ); [02:05:49] Krenair: Why do you need to getMain()? And does this change also fix 63600? [02:05:57] Seems to [02:06:06] Let's make that change instead, then. :-) [02:06:18] (03CR) 10Krinkle: update-oojs-ui.sh: Replace target dir instead of adding file copies (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 (owner: 10Krinkle) [02:06:29] Alter the commit, add the new bug to it too, C+1 it, and ping it back to Roan for up/down vote. :-) [02:06:40] (03CR) 10Alex Monk: Set context title when rendering edit notices (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127388 (owner: 10Catrope) [02:06:50] (03CR) 10Jforrester: [C: 032] update-oojs-ui.sh: Replace target dir instead of adding file copies (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 (owner: 10Krinkle) [02:07:27] (03CR) 10Jforrester: "Ideally this should be re-done by a the new update-oojs-ui.sh script from this repo." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [02:08:04] (03Merged) 10jenkins-bot: update-oojs-ui.sh: Replace target dir instead of adding file copies [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127401 (owner: 10Krinkle) [02:09:14] Gah, gerrit thinks the two files are distinct. [02:10:21] (03PS2) 10Alex Monk: Set context title when rendering edit notices and checkboxes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127388 (owner: 10Catrope) [02:12:29] Krenair: BTW, I added you to the dashboard list, so https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default now has commits by you in "Team…" sections. [02:14:39] Krinkle: Tech debt bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=64121. [02:15:08] James_F: correction, git thinks [02:15:17] more than 60% changed [02:15:35] Krinkle: True, but I'm sure that a proper UI would let me do diffs between arbitrary files. [02:15:45] Without having to download them and do it locally. [02:16:06] Maybe we should have done the move and change in different commits? Eh. [02:16:28] Neither git (cli), github, gerrit, Git Tower.app, GitHub Mac.app, etc. does this [02:16:37] Really? How odd. [02:16:41] That would still make it not preserve history afaik. It doesn't track file names. [02:16:51] Eclipse's CVS (!) plugin does, for instance. [02:16:58] I mean, you can lower the treshold in your gitconfig, but that's about it. No diffing between arbitrary files [02:17:01] It does when the file is the same. [02:17:09] Same name, sorry. [02:17:18] Within the diff, yes, but not in the history. [02:17:33] After both commits are in, it will still not have the history. [02:17:48] because it doesn't do file-level history tracking, only code portions. [02:18:12] It's not svn anymore :) [02:18:36] that was about the one nice thing about svn, you can trick it into thinking a file is still the same after it's been rewritten by doing rename and refactor in separate commits [02:18:45] git doesn't. [02:18:46] * James_F nods. [02:19:33] in exchange, git allows you to blame accross copies, file-splits, file-merges and rename without needing to know anything about the files. [02:21:58] (03CR) 10Jforrester: [C: 032] Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [02:22:31] Yes, but what I /want/ is a detached diff tool in my editor, and git diff ain't that. :-) [02:23:16] (03Merged) 10jenkins-bot: Add forgotten OOjs UI i18n files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/127354 (owner: 10Catrope) [02:24:03] Yay. [02:24:47] (03PS4) 10Jforrester: [BREAKING CHANGE] Merge dialog and inspector actions into window actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126164 (owner: 10Trevor Parscal) [02:40:16] Krinkle: How's the doc.wikimedia.org merge/deploy work coming? [02:42:26] slowly but surely [02:42:43] That's "no"? :-P [02:43:39] background process at the moment, but getting back in the foreground now that other things has been popped off the stack [02:43:47] Cool. [02:44:01] Consider this an IRQ for it to remain in the top of your frame. :-) [02:50:25] * James_F goes home. [02:50:35] Krinkle, Krenair: Good night. And stop working, already. :-) [03:39:33] (03PS1) 10Krinkle: StackLayout: Don't fire set event for null, and add unset event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [03:39:50] (03CR) 10Krinkle: Add getCurrentItem method (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/127120 (owner: 10Trevor Parscal) [03:41:22] (03PS2) 10Krinkle: StackLayout: Don't fire set event for null, and add unset event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [03:45:15] (03CR) 10Krinkle: Use CSS to style figure and figcaption (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [03:47:23] (03CR) 10Krinkle: [C: 032] "Hm.. Right, The Title class has no context and uses wfMessage() global to parse it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127388 (owner: 10Catrope) [03:48:55] (03Merged) 10jenkins-bot: Set context title when rendering edit notices and checkboxes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127388 (owner: 10Catrope) [05:05:29] (03PS1) 10Krinkle: Set up jsduck [oojs/ui] - 10https://gerrit.wikimedia.org/r/127418 [05:06:10] (03CR) 10Krinkle: "To test: Install jsduck (5.0 or later) and run "cd oojs-ui; jsduck --config jsduck.config.json". Then view oojs-ui/docs in your browser." [oojs/ui] - 10https://gerrit.wikimedia.org/r/127418 (owner: 10Krinkle) [05:18:19] (03PS2) 10Krinkle: Set up jsduck [oojs/ui] - 10https://gerrit.wikimedia.org/r/127418 [05:45:24] (03PS1) 10Catrope: Use wgPageName instead of wgTitle when fetching language links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127419 [05:45:35] (03CR) 10jenkins-bot: [V: 04-1] Use wgPageName instead of wgTitle when fetching language links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127419 (owner: 10Catrope) [08:58:04] (03PS1) 10Amire80: Clarify the text of visualeditor-dialog-media-position-checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127425 [09:03:55] (03PS1) 10Amire80: Clarify the message visualeditor-dialog-meta-categories-sortkey-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127426 [09:11:15] (03PS1) 10Amire80: Add GENDER support to visualeditor-editconflict [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127427 [16:32:28] (03CR) 10GWicke: Use CSS to style figure and figcaption (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [16:35:29] gwicke, fyi, https://bugzilla.wikimedia.org/show_bug.cgi?id=52073#c2 [16:56:38] (03CR) 10Alex Monk: "for some reason my -1 stuck..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127004 (owner: 10Alex Monk) [17:00:05] (03PS1) 10Alex Monk: Update wgRevisionId when we change wgCurRevisionId [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127441 [18:28:20] (03CR) 10Helder.wiki: [C: 031] Update wgRevisionId when we change wgCurRevisionId [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127441 (owner: 10Alex Monk) [19:49:16] (03CR) 10Jforrester: [C: 032] Clarify the text of visualeditor-dialog-media-position-checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127425 (owner: 10Amire80) [19:49:52] (03CR) 10Jforrester: [C: 04-1] Clarify the message visualeditor-dialog-meta-categories-sortkey-label (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127426 (owner: 10Amire80) [19:50:45] (03Merged) 10jenkins-bot: Clarify the text of visualeditor-dialog-media-position-checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127425 (owner: 10Amire80) [19:50:55] (03CR) 10Amire80: Clarify the message visualeditor-dialog-meta-categories-sortkey-label (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127426 (owner: 10Amire80) [19:52:20] (03PS2) 10Jforrester: Clarify the message visualeditor-dialog-meta-categories-sortkey-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127426 (owner: 10Amire80) [19:53:13] (03CR) 10Amire80: [C: 031] Clarify the message visualeditor-dialog-meta-categories-sortkey-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127426 (owner: 10Amire80) [19:53:43] (03CR) 10Jforrester: [C: 032] Clarify the message visualeditor-dialog-meta-categories-sortkey-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127426 (owner: 10Amire80) [19:55:10] (03Merged) 10jenkins-bot: Clarify the message visualeditor-dialog-meta-categories-sortkey-label [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127426 (owner: 10Amire80)