[00:00:19] (03PS1) 10Esanders: Add AnnotationAction.test.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129076 [00:02:17] (03CR) 10jenkins-bot: [V: 04-1] Add AnnotationAction.test.js [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129076 (owner: 10Esanders) [00:02:28] (03CR) 10Esanders: "In future run grunt build and update compiled html files." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/126164 (owner: 10Trevor Parscal) [00:02:47] (03PS1) 10Esanders: Update built html files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129077 [00:03:31] (03PS1) 10Esanders: Update built html files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129078 [00:19:12] (03PS1) 10Esanders: Add debug bars to surface widgets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129080 [00:19:14] (03PS1) 10Esanders: Prevent SurfaceWidgets from focussing themselves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129081 [00:19:26] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909 (10Gerrit Notification Bot) 5REO>3PAT [00:19:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c13 (10Gerrit Notification Bot) Change 129081 had a related patch set uploaded by Esanders: Prevent SurfaceWi... [00:41:28] 3VisualEditor / 3Editing Tools: VisualEditor Mobile: "Success! Your edit was saved" message stays in the VE mode unless user scrolls down the page - 10https://bugzilla.wikimedia.org/64270 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Created attachment 15174 --> https://bugzilla.wikimedia.org/atta... [00:46:27] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Success! Your edit was saved" message stays in the VE mode unless user scrolls down the page - 10https://bugzilla.wikimedia.org/64270 (10ryasmeen ) [02:03:26] 3VisualEditor / 3Editing Tools: 'Insert Media' in VE fails to search local repo, returns blank. - 10https://bugzilla.wikimedia.org/63989#c3 (10Patrick King) Upgraded mediawiki to 1.22.5. Installed parsoid and VisualEditor as new. Merged basic LocalSettings.php. Uploaded a new file. File and description... [02:04:30] ^^^ this is my bug report, happy to answer any questions. Thanks. [02:26:15] (03CR) 10Jforrester: [C: 032] Update built html files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129078 (owner: 10Esanders) [02:26:35] (03CR) 10Jforrester: [C: 032] Update built html files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129077 (owner: 10Esanders) [02:27:52] (03Merged) 10jenkins-bot: Update built html files [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129078 (owner: 10Esanders) [02:28:29] (03CR) 10Jforrester: "There are releases and release notes…https://github.com/wikimedia/jquery.i18n/releases" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127870 (owner: 10Esanders) [02:29:12] (03Merged) 10jenkins-bot: Update built html files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129077 (owner: 10Esanders) [05:30:25] (03CR) 10Krinkle: "There are no release notes indeed, but please do include which git tag or commit hash you pulled the files from. A url like https://github" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127870 (owner: 10Esanders) [08:05:09] (03PS3) 10Krinkle: StackLayout: Don't fire set event for null, and add unset event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [09:43:26] 3VisualEditor: VisualEditor: Can't save after editing categories - 10https://bugzilla.wikimedia.org/64241#c2 (10Elitre) 5NEW>3UNC Yes. Although as of now, I can't reproduce this issue, so I'm bringing it back to unconfirmed. [16:41:49] >> Math.random() [16:41:49] Krinkle: (number) 0.6829085818026215 [16:44:38] Krinkle: Having fun? [16:48:25] >> function strRand(len) { var i, chrs = []; for (i = 0; i < len; i++) { chrs.push(String.fromCharCode(Math.ceil(Math.random() * 94) + 32 /* 33 - 126 is simple chars*/ )); } return chrs.join(''); } strRand(12);>> function strRand(len) { var i, chrs = []; for (i = 0; i < len; i++) { chrs.push(String.fromCharCode(Math.ceil(Math.random() * 94) + 32 /* 33 - 126 is simple chars*/ )); } return chrs. [16:48:25] Krinkle: SyntaxError: Unexpected token >> [16:48:25] join(''); } strRand(12); [16:48:27] >> function strRand(len) { var i, chrs = []; for (i = 0; i < len; i++) { chrs.push(String.fromCharCode(Math.ceil(Math.random() * 94) + 32 /* 33 - 126 is simple chars*/ )); } return chrs.join(''); } strRand(12); [16:48:27] Krinkle: (string) 'Ksipo@R%?T[E' [16:48:29] >> function strRand(len) { var i, chrs = []; for (i = 0; i < len; i++) { chrs.push(String.fromCharCode(Math.ceil(Math.random() * 94) + 32 /* 33 - 126 is simple chars*/ )); } return chrs.join(''); } strRand(12); [16:48:29] Krinkle: (string) ']^)zY^)GuCXe' [16:48:33] James_F: yeah [16:49:11] Krinkle: Generating passwords using a bot in IRC isn't very secure. ;-) [16:49:19] random != password [16:49:24] * James_F grins. [16:49:27] I guessed. [16:50:49] Hm.. everyone is away [16:50:52] Except us [16:51:09] Yeah, it's known to happen. :-) [17:26:20] Krinkle: could we get a patch to add recommended fields to TD today? [17:40:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: Not getting any result for media search in Betalabs - 10https://bugzilla.wikimedia.org/64253#c1 (10ryasmeen ) 5NEW>3RES/FIX This is now fixed .I am getting search results for the media now [17:42:09] Hi there, I am not sure I am in the right place for such a question... but I will give it a shot. Does Visual Editor support datepicker functionality for template transclusion properties/parameters? [17:44:01] Triangulus: No, not yet. [17:44:11] Triangulus: It's something we're going to add reasonably soon though. [17:46:44] Thanks, James, I will keep an eye on the roadmap then (if this info can be found there) [17:48:41] Triangulus: It is – look for "type support" in templates. [18:00:36] James_F: Sorry, can you provide me with a link? I didn't have any luck finding it. Thanks in advance. [18:02:53] James_F, sigh. still waiting for gmail to reconnect me to the hangout text chat thing [18:03:15] Krenair: Yay. :-( [18:03:21] Today I will attempt to load pages to organise what I'm doing. >_> [18:03:25] Triangulus: https://www.mediawiki.org/wiki/VisualEditor/Roadmap [18:09:17] James_F: Ok. I had that, but was looking for a more explicit breakdown of the types. I guess it is part of the first "doing" point (4th bullet under Working on right now > Citations). I will bide my time. :) Thanks again for the help today and an awesome tool in general. [18:10:11] Triangulus: Always. :-) [18:12:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Not getting any result for media search in Betalabs - 10https://bugzilla.wikimedia.org/64253#c2 (10Alex Monk) Hmm... Reminds me of bug 63989 [18:19:43] 3VisualEditor / 3Editing Tools: VisualEditor: The default size is not getting applied on an image after clicking on "Apply Changes" - 10https://bugzilla.wikimedia.org/64303 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Go to this page:https://test2.wikipedia.org/w/index.php?ti... [18:20:28] 3VisualEditor / 3Editing Tools: VisualEditor: The default size is not getting applied on an image after clicking on "Apply Changes" - 10https://bugzilla.wikimedia.org/64303 (10ryasmeen ) a:3Moriel Schottlender [18:21:04] (03PS2) 10Esanders: Update jquery.uls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127870 [18:21:06] (03PS4) 10Esanders: Dialog-ise ULS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127861 [18:22:33] edsanders: 601a5256b800e5315fa0d1e7a37b74fe183b080f [18:22:43] (03CR) 10Catrope: [C: 032] Check cascade protection and show notice if relevant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/128965 (owner: 10Alex Monk) [18:24:11] (03Merged) 10jenkins-bot: Check cascade protection and show notice if relevant [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/128965 (owner: 10Alex Monk) [18:24:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: Protection edit notice should also show when under cascaded protection from another page - 10https://bugzilla.wikimedia.org/53893#c4 (10Gerrit Notification Bot) Change 128965 merged by jenkins-bot: Check cascade protection and show notice if relevant htt... [18:24:36] (03PS3) 10Esanders: Update jquery.uls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127870 [18:24:38] (03PS5) 10Esanders: Dialog-ise ULS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127861 [18:25:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: Protection edit notice should also show when under cascaded protection from another page - 10https://bugzilla.wikimedia.org/53893 (10James Forrester) 5PAT>3RES/FIX a:3Alex Monk [18:29:28] (03CR) 10Cmcmahon: [C: 032] [Browser tests] Move "I can click the X on the save box" to shared_steps.rb [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127850 (owner: 10Catrope) [18:31:10] (03Merged) 10jenkins-bot: [Browser tests] Move "I can click the X on the save box" to shared_steps.rb [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127850 (owner: 10Catrope) [18:32:41] (03PS4) 10Jforrester: Update jquery.uls from 601a5256b8 To 1932de9e347d [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127870 (owner: 10Esanders) [18:32:58] (03CR) 10Jforrester: [C: 032] Update jquery.uls from 601a5256b8 To 1932de9e347d [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127870 (owner: 10Esanders) [18:34:46] (03Merged) 10jenkins-bot: Update jquery.uls from 601a5256b8 To 1932de9e347d [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127870 (owner: 10Esanders) [18:39:44] (03PS19) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [18:41:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:43:41] 3VisualEditor / 3Editing Tools: VisualEditor: The default size is not getting applied on an image after clicking on "Apply Changes" - 10https://bugzilla.wikimedia.org/64303#c1 (10Moriel Schottlender) Yes, it turns the image to 600x600 because it's the image's original dimensions, which are considered "defaul... [18:44:01] oh the confusion of defaultiness in images [18:45:56] ryasmeen, if you change the image to "thumb" and click "default" it will become the wiki-default size. I just tested, it works well. This is more of a weirdness of intended behavior due to wikitext than a bug. :\ [18:47:10] (03PS20) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [18:48:38] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:51:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Citation dialog does not focus correct field when adding a new parameter - 10https://bugzilla.wikimedia.org/64098 (10Roan Kattouw) a:3Trevor Parscal [18:52:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Only most recently added parameter gets trash can icon in citation dialog - 10https://bugzilla.wikimedia.org/64199 (10Roan Kattouw) a:3Trevor Parscal [18:57:04] (03PS1) 10Trevor Parscal: Scope frame CSS to not affect child frames [oojs/ui] - 10https://gerrit.wikimedia.org/r/129232 [18:57:06] (03CR) 10jenkins-bot: [V: 04-1] Scope frame CSS to not affect child frames [oojs/ui] - 10https://gerrit.wikimedia.org/r/129232 (owner: 10Trevor Parscal) [18:57:10] (03PS1) 10Trevor Parscal: Add text config option to OO.ui.Element [oojs/ui] - 10https://gerrit.wikimedia.org/r/129233 [18:58:11] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267#c1 (10Roan Kattouw) This looks like a bug in ve.init.mw.Target :( [19:09:53] RoanKattouw, Krinkle, etc.: BTW https://github.com/valhallasw/pywikibugs/blob/master/pywikibugs.py is where to change the config of what bugs get spammed here. [19:13:24] (03PS6) 10Jforrester: Dialog-ise ULS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127861 (owner: 10Esanders) [19:27:48] (03PS1) 10Jforrester: Update VE core submodule to master (6daeb19) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129242 [19:33:24] (03PS1) 10Catrope: Unbreak badtoken recovery on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129243 [19:33:41] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267 (10Gerrit Notification Bot) 5NEW>3PAT [19:33:41] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267#c2 (10Gerrit Notification Bot) Change 129243 had a related patch set upl... [19:34:42] TrevorParscal: Could you review https://gerrit.wikimedia.org/r/#/c/129243/? [19:37:24] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=52345#c5 - DifferenceEngine has a PST option? [19:38:29] That surprises me too [19:38:31] But only slightly [19:38:38] Both diffing and PST are horrible pieces of code [19:38:45] * James_F grins. [19:38:57] So the fact that two horrible pieces of code chose to have some sort of horrible semi-commitment to each other isn't that weird [19:39:31] I looked into how action=parse deals with pstonly, seems we could change diffWikitext to do ContentHandler::makeContent( $wikitext, $title )->preSaveTransform( $title, $this->getUser(), ( new WikiPage( $title ) )->makeParserOptions( $this->getContext() ) )->serialize( 'text/x-wiki' ) [19:40:12] (but I'd prefer not to if there's a better way) [19:40:54] I don't know [19:40:58] How does EditPage do this? [19:41:14] Not that EditPage is a hallmark of wonderfulness, but at least it works (sort of) [19:41:28] s/works/exhibits the behaviour we want to emulate/ [19:43:44] it runs $newContent->preSaveTransform( $this->mTitle, $wgUser, $popts ) too [19:46:01] OK [19:46:08] So it's doing the thing you were trying to avoid? [19:46:34] Well... I don't know if I'd avoid it, I just wasn't 100% sure it was the right way to do it [19:46:44] Right [19:51:06] (03PS1) 10Alex Monk: Apply PST when generating diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129251 [19:51:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: API does not apply PST (pre-save transform) when generating its diff - 10https://bugzilla.wikimedia.org/52345 (10Gerrit Notification Bot) 5ASS>3PAT [19:51:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: API does not apply PST (pre-save transform) when generating its diff - 10https://bugzilla.wikimedia.org/52345#c6 (10Gerrit Notification Bot) Change 129251 had a related patch set uploaded by Alex Monk: Apply PST when generating diff https://gerrit.wikime... [19:53:45] Krenair: You're really churning through the MediaWiki integration bugs. :-) [19:54:12] :) [19:57:41] (03CR) 10Trevor Parscal: [C: 032] Unbreak badtoken recovery on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129243 (owner: 10Catrope) [19:58:17] Krenair: Hah this also fixes the trailing newline in every diff [19:58:25] I swear we used to PST this at some point [19:58:29] I think I've fixed this bug before [19:59:24] (03Merged) 10jenkins-bot: Unbreak badtoken recovery on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129243 (owner: 10Catrope) [19:59:41] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267#c3 (10Gerrit Notification Bot) Change 129243 merged by jenkins-bot: Unbr... [20:00:04] (03CR) 10Catrope: [C: 032] Apply PST when generating diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129251 (owner: 10Alex Monk) [20:00:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267 (10James Forrester) 5PAT>3RES/FIX p:5Unprio>3High a:3Roan Katto... [20:00:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices - 10https://bugzilla.wikimedia.org/52280 (10James Forrester) a:3Alex Monk [20:00:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow users to set/edit {{DISPLAYTITLE:xxx}} in the page metadata panel - 10https://bugzilla.wikimedia.org/56868 (10James Forrester) a:3Alex Monk [20:00:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switch to use MediaWiki's built-in messages for post-edit notifications (and add to them so we cover all three cases) - 10https://bugzilla.wikimedia.org/52871 (10James Forrester) a:3Alex Monk [20:01:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Print/Export tools are enabled while editing - 10https://bugzilla.wikimedia.org/57940 (10James Forrester) a:3Alex Monk [20:01:02] 3VisualEditor / 3MediaWiki integration: VisualEditor: API does not apply PST (pre-save transform) when generating its diff - 10https://bugzilla.wikimedia.org/52345 (10James Forrester) a:3Alex Monk [20:02:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: API does not apply PST (pre-save transform) when generating its diff - 10https://bugzilla.wikimedia.org/52345 (10James Forrester) 5PAT>3RES/FIX [20:03:09] (03Merged) 10jenkins-bot: Apply PST when generating diff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129251 (owner: 10Alex Monk) [20:03:26] 3VisualEditor / 3MediaWiki integration: VisualEditor: API does not apply PST (pre-save transform) when generating its diff - 10https://bugzilla.wikimedia.org/52345#c7 (10Gerrit Notification Bot) Change 129251 merged by jenkins-bot: Apply PST when generating diff https://gerrit.wikimedia.org/r/129251 [20:07:57] (03CR) 10Catrope: [C: 032] Add debug bars to surface widgets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129080 (owner: 10Esanders) [20:08:05] (03CR) 10Catrope: [C: 032] Prevent SurfaceWidgets from focussing themselves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129081 (owner: 10Esanders) [20:09:21] (03Merged) 10jenkins-bot: Add debug bars to surface widgets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129080 (owner: 10Esanders) [20:09:39] (03Merged) 10jenkins-bot: Prevent SurfaceWidgets from focussing themselves [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129081 (owner: 10Esanders) [20:09:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c14 (10Gerrit Notification Bot) Change 129081 merged by jenkins-bot: Prevent SurfaceWidgets from focussing th... [20:12:37] (03CR) 10Catrope: [C: 032] Merge b/strong and i/em annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129036 (owner: 10Esanders) [20:13:51] (03Merged) 10jenkins-bot: Merge b/strong and i/em annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129036 (owner: 10Esanders) [20:14:03] MatmaRex, made https://github.com/valhallasw/pywikibugs/pull/8 [20:14:08] er, that was for #wikimedia-devs. oh well [20:14:17] -dev* even [20:18:54] Krenair: :-) [20:21:26] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909 (10James Forrester) 5PAT>3RES/FIX [20:21:50] James_F, have you seen Timo's comment on https://gerrit.wikimedia.org/r/#/c/120962/ ? [20:21:57] (03PS4) 10Jdlrobson: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 [20:22:33] Krenair: Yeah; he needs to explain when on Earth his perfect solution is going to happen, or withdraw. [20:22:44] Is this the oojs IE8 thing? [20:22:50] Multimedia is getting antsy about that [20:23:25] no, Cite extension stuff [20:23:38] RoanKattouw: No, Timo's suddenly decided after a year of discussion that we shouldn't be helping fix the mess that is {{reflist}}. [20:28:01] (03CR) 10Cmcmahon: [C: 032] [Browser tests] Fix typo in file name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127851 (owner: 10Catrope) [20:28:30] Oh the attributes? [20:29:25] (03Merged) 10jenkins-bot: [Browser tests] Fix typo in file name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/127851 (owner: 10Catrope) [20:29:26] yeah [20:32:39] RoanKattouw: Yes. [20:34:02] (03CR) 10Cmcmahon: [C: 032] [Browser tests] Do not display link to Sauce Labs when using local browser [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/128470 (owner: 10Zfilipin) [20:35:31] (03Merged) 10jenkins-bot: [Browser tests] Do not display link to Sauce Labs when using local browser [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/128470 (owner: 10Zfilipin) [20:59:46] (03PS21) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [21:01:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [21:01:37] Ah, jenkins-bot. [21:17:15] Who here has used VE with ConfirmEdit? [21:19:05] (03PS1) 10Cmcmahon: [browser test] Save dialog takes longer than 5s [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129305 [21:19:44] Krenair: Log out, go to enwiki Special:Random?veaction=edit, try to add an external link, observe. :-) [21:19:50] Krenair: Roan's the expert though. [21:23:46] uh, in the process I broke something else. [21:24:48] That sounds ominous. :-) [21:25:29] I made some changes to the random article and got strange characters :/ [21:29:34] Move the cursor to the end of a line before the start of a new section header, delete, enter, enter, up, delete, type a random character. [21:30:16] Backwards delete or forwards delete? [21:30:42] Um. The delete next to 'Home' and 'End' [21:30:51] not backspace [21:30:51] Forwards, then. :-) [21:31:09] Whee, snowmen. [21:31:21] I blame edsanders. [21:31:41] observed on http://en.wikipedia.org/wiki/Hippeastrum_calyptratum, depending on what random character you try (I hit 'f'), stuff breaks in a difficult to explain but quite obvious [21:31:49] especially if you do it twice to the same document [21:32:18] So the first thing that happens is that the cursor ends up outside of the document. [21:32:22] Which is Bad™. [21:32:39] Everything breaking after this is non-deterministic, but definitely also Bad™. [21:34:36] * Krenair goes back to poking confirmedit [21:37:21] James_F, also I tried saving, logged out and adding an external link, and it actually went through [21:37:51] Krenair: Hmmmm. That… should have been blocked [21:38:00] Unless we changed the config for enwiki/ [21:38:28] The issue I get after adding ConfirmEdit to my wiki is "Error: Unknown error" when saving >_> [21:38:40] {"visualeditoredit":{"result":"error","edit":{"captcha":{"type":"simple","mime":"text/plain","id":"586723432","question":"24+8"},"result":"Failure"}}} [21:39:14] Hmm. [21:39:26] That kind of CAPTCHA isn't supported yet. [21:39:37] You'd need to add it to the save dialog's logic. [21:39:40] meh. thought it would be something like that [21:39:51] Should I do that at some point? [21:40:19] do we have a bug open about this somewhere? [21:42:46] well it appears to support fancycaptcha looking at the code, but "FancyCaptcha requires running a preliminary setup script in Python;" -.- [21:54:07] Krenair: :-D [21:55:10] James_F, so.... should I, do we? [21:56:19] Krenair: It's worth adding support, feel free to make a bug (I don't have a list of CAPTCHA methods to support). [21:59:58] 3VisualEditor / 3MediaWiki integration: Add support for more types of ConfirmEdit captcha - 10https://bugzilla.wikimedia.org/64328 (10Alex Monk) 3NEW p:3Unprio s:3normal a:3None The issue I get after adding ConfirmEdit to my wiki is "Error: Unknown error" when saving >_> {"visuale... [22:00:57] 3VisualEditor / 3MediaWiki integration: Add support for more types of ConfirmEdit captcha - 10https://bugzilla.wikimedia.org/64328 (10Alex Monk) 5NEW>3ASS a:3Alex Monk [22:26:40] (03PS1) 10Alex Monk: Add support for SimpleCaptcha [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129315 [22:26:56] 3VisualEditor / 3MediaWiki integration: Add support for more types of ConfirmEdit captcha - 10https://bugzilla.wikimedia.org/64328#c1 (10Gerrit Notification Bot) Change 129315 had a related patch set uploaded by Alex Monk: Add support for SimpleCaptcha https://gerrit.wikimedia.org/r/129315 [22:28:09] (03CR) 10jenkins-bot: [V: 04-1] Add support for SimpleCaptcha [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129315 (owner: 10Alex Monk) [22:31:01] (03PS2) 10Alex Monk: Add support for SimpleCaptcha [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129315 [22:43:28] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the background layout of the icons is not appearing for cite options/references/math/hiero when they are added inside Media Settings - 10https://bugzilla.wikimedia.org/64332 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Created attachment 151... [22:43:57] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the background layout of the icon is not appearing for cite options/references/math/hie ro when they are added inside Media Settings - 10https://bugzilla.wikimedia.org/64332 (10ryasmeen ) [22:58:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add support for more types of ConfirmEdit captcha - 10https://bugzilla.wikimedia.org/64328 (10James Forrester) p:5Unprio>3High [22:58:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add support for more types of ConfirmEdit captcha - 10https://bugzilla.wikimedia.org/64328 (10James Forrester) s:5normal>3enhanc [23:04:05] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (6daeb19) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129242 (owner: 10Jforrester) [23:04:54] (03CR) 10Catrope: [C: 032] Hide some tools when VE is open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129059 (owner: 10Alex Monk) [23:05:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (6daeb19) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129242 (owner: 10Jforrester) [23:06:53] (03Merged) 10jenkins-bot: Hide some tools when VE is open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129059 (owner: 10Alex Monk) [23:07:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: Print/Export tools are enabled while editing - 10https://bugzilla.wikimedia.org/57940#c2 (10Gerrit Notification Bot) Change 129059 merged by jenkins-bot: Hide some tools when VE is open https://gerrit.wikimedia.org/r/129059 [23:07:41] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, the background layout of the icon is not appearing for cite options/references/math/hie ro when they are added inside Media Settings - 10https://bugzilla.wikimedia.org/64332 (10Krinkle) [23:09:12] RoanKattouw: I think this is the only one we need to backport : https://bugzilla.wikimedia.org/show_bug.cgi?id=63909 [23:15:26] (03PS1) 10Catrope: Prevent SurfaceWidgets from focussing themselves [VisualEditor/VisualEditor] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129323 [23:15:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c15 (10Gerrit Notification Bot) Change 129323 had a related patch set uploaded by Catrope: Prevent SurfaceWid... [23:17:58] RoanKattouw: And this is the one for mobile backport: https://bugzilla.wikimedia.org/show_bug.cgi?id=64267 [23:18:02] Thanks [23:23:58] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334 (10ryasmeen ) 3NE... [23:24:27] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334#c1 (10ryasmeen ) C... [23:25:04] (03CR) 10Catrope: [C: 032 V: 032] Prevent SurfaceWidgets from focussing themselves [VisualEditor/VisualEditor] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129323 (owner: 10Catrope) [23:25:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c16 (10Gerrit Notification Bot) Change 129323 merged by Catrope: Prevent SurfaceWidgets from focussing themse... [23:25:15] (03PS1) 10Catrope: Unbreak badtoken recovery on mobile [extensions/VisualEditor] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129326 [23:25:26] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267#c4 (10Gerrit Notification Bot) Change 129326 had a related patch set upl... [23:25:40] (03CR) 10Catrope: [C: 032 V: 032] Unbreak badtoken recovery on mobile [extensions/VisualEditor] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129326 (owner: 10Catrope) [23:25:42] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334#c2 (10ryasmeen ) C... [23:25:56] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267#c5 (10Gerrit Notification Bot) Change 129326 merged by Catrope: Unbreak... [23:26:39] (03PS1) 10Catrope: Update submodule for cherry-pick of I45537ba813 [extensions/VisualEditor] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129327 [23:27:42] (03CR) 10Catrope: [C: 032 V: 032] Update submodule for cherry-pick of I45537ba813 [extensions/VisualEditor] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/129327 (owner: 10Catrope) [23:34:41] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267 (10James Forrester) 5PAT>3RES/FIX [23:35:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909 (10James Forrester) 5PAT>3RES/FIX [23:38:58] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334 (10James Forrester... [23:39:11] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334 (10James Forrester) [23:46:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Print/Export tools are enabled while editing - 10https://bugzilla.wikimedia.org/57940 (10James Forrester) 5PAT>3RES/FIX [23:56:12] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, the background layout of the icon is not appearing for cite options/references/math/hiero when they are added inside Media Settings - 10https://bugzilla.wikimedia.org/64332 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal a:3Trevor Parscal