[00:04:14] (03PS1) 10Jforrester: Create MWLiveExtensionInspector base class [extensions/VisualEditor] (REL1_23) - 10https://gerrit.wikimedia.org/r/129622 [00:04:33] (03CR) 10Jforrester: [C: 032] Create MWLiveExtensionInspector base class [extensions/VisualEditor] (REL1_23) - 10https://gerrit.wikimedia.org/r/129622 (owner: 10Jforrester) [00:04:42] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a formula/hieroglyphics insert while selecting an image tries to modify the caption, dies - 10https://bugzilla.wikimedia.org/58045#c4 (10Gerrit Notification Bot) Change 129622 had a related patch set uploaded by Jforrester: Create MWLiveExtensionInspecto... [00:04:42] 3VisualEditor / 3Editing Tools: VisualEditor: Inserting a formula into a block slug throws "Uncaught TypeError: Cannot call method 'getOuterRange' of null" - 10https://bugzilla.wikimedia.org/58286#c9 (10Gerrit Notification Bot) Change 129622 had a related patch set uploaded by Jforrester: Create MWLiveExtens... [00:06:10] (03Merged) 10jenkins-bot: Create MWLiveExtensionInspector base class [extensions/VisualEditor] (REL1_23) - 10https://gerrit.wikimedia.org/r/129622 (owner: 10Jforrester) [00:06:26] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a formula/hieroglyphics insert while selecting an image tries to modify the caption, dies - 10https://bugzilla.wikimedia.org/58045#c5 (10Gerrit Notification Bot) Change 129622 merged by jenkins-bot: Create MWLiveExtensionInspector base class https://ger... [00:06:27] 3VisualEditor / 3Editing Tools: VisualEditor: Inserting a formula into a block slug throws "Uncaught TypeError: Cannot call method 'getOuterRange' of null" - 10https://bugzilla.wikimedia.org/58286#c10 (10Gerrit Notification Bot) Change 129622 merged by jenkins-bot: Create MWLiveExtensionInspector base class... [00:06:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Math inspector is not appearing in Betalabs and throwing Typeerror:Cannot call method 'getModel' of undefined - 10https://bugzilla.wikimedia.org/63785#c8 (10Gerrit Notification Bot) Change 129623 had a related patch set uploaded by Jforrester:... [00:08:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Math inspector is not appearing in Betalabs and throwing Typeerror:Cannot call method 'getModel' of undefined - 10https://bugzilla.wikimedia.org/63785#c9 (10Gerrit Notification Bot) Change 129623 merged by jenkins-bot: Update VE implementation... [00:11:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Cannot add reflist in a page in Betalabs - 10https://bugzilla.wikimedia.org/64012#c5 (10ryasmeen ) Verified the fix in production in Chrome and FF [00:15:31] (03PS1) 10Esanders: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 [00:16:48] (03CR) 10jenkins-bot: [V: 04-1] Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [00:18:41] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Save page button does not become enabled upon adding any text/changing format/adding reference in CE for Betalabs - 10https://bugzilla.wikimedia.org/64042 (10James Forrester) 5RES/?>3VER [00:18:56] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] Cannot add reflist in a page in Betalabs - 10https://bugzilla.wikimedia.org/64012 (10James Forrester) 5RES/?>3VER [00:18:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909 (10James Forrester) 5RES/?>3VER [00:18:58] 3VisualEditor / 3Mobile: VisualEditor: [Regression pre-wmf1] Uncaught TypeError: Cannot read property 'nextSibling' of undefined is appearing while trying to edit the next line after a saved edit in Mobile VE - 10https://bugzilla.wikimedia.org/64032 (10James Forrester) 5RES/?>3VER [00:19:00] 3VisualEditor / 3Editing Tools: VisualEditor: Adding a reflist while selecting an image does not add anything new in the page but the "Save Page" button becomes active - 10https://bugzilla.wikimedia.org/61885 (10James Forrester) 5RES/?>3VER [00:21:11] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Math inspector is not appearing in Betalabs and throwing Typeerror:Cannot call method 'getModel' of undefined - 10https://bugzilla.wikimedia.org/63785 (10James Forrester) 5RES/?>3VER [00:21:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Math inspector is not appearing in Betalabs and throwing Typeerror:Cannot call method 'getModel' of undefined - 10https://bugzilla.wikimedia.org/63785 (10James Forrester) 5PAT>3RES/FIX [00:21:26] 3VisualEditor / 3Editing Tools: VisualEditor: Inserting a formula into a block slug throws "Uncaught TypeError: Cannot call method 'getOuterRange' of null" - 10https://bugzilla.wikimedia.org/58286 (10James Forrester) 5PAT>3RES/FIX [00:21:41] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a formula/hieroglyphics insert while selecting an image tries to modify the caption, dies - 10https://bugzilla.wikimedia.org/58045 (10James Forrester) 5PAT>3RES/FIX [00:31:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The textbox/icons/delete button inside transclusion dialog box is completely distorted on Betalabs - 10https://bugzilla.wikimedia.org/64013#c6 (10ryasmeen ) 5RES/?>3VER Verified the fix on production [00:37:42] 3VisualEditor / 3Editing Tools: VisualEditor: Selecting Advanced settings from the Page Options menu does not take to the Advanced Settings tab - 10https://bugzilla.wikimedia.org/63984#c5 (10ryasmeen ) 5RES/?>3VER Verified the fix on production [00:39:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Adding a reference adds an empty one; editing a reference inserts a new one - 10https://bugzilla.wikimedia.org/63828#c6 (10ryasmeen ) Verified the fix on productionhttps://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/sandbox&veact... [00:39:57] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Adding a reference adds an empty one; editing a reference inserts a new one - 10https://bugzilla.wikimedia.org/63828 (10ryasmeen ) 5RES/?>3VER [06:02:43] (03Abandoned) 10Legoktm: [WIP] Run a hook so extensions can add templatedata for parser functions [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/78644 (owner: 10Legoktm) [06:02:56] 3MediaWiki extensions / 3TemplateData: TemplateData: Implement hook for extensions to document parser functions - 10https://bugzilla.wikimedia.org/52607#c5 (10Gerrit Notification Bot) Change 78644 abandoned by Legoktm: [WIP] Run a hook so extensions can add templatedata for parser functions Reason: Not plan... [06:03:26] 3MediaWiki extensions / 3TemplateData: TemplateData: Implement hook for extensions to document parser functions - 10https://bugzilla.wikimedia.org/52607 (10Kunal Mehta (Legoktm)) 5PAT>3NEW [10:02:19] Hello! I am working at a company and we are trying to setup VisualEditor with Parsoid, we got or current wiki ad-connected. We have follwed the guides on the mediawiki site. Do anyone have suggestions or followup questions? [10:21:34] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129594 (owner: 10Jforrester) [10:22:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (owner: 10Jforrester) [10:25:44] Nocebo, did you get VisualEditor to work, or are you stuck? [10:30:19] mooeypoo: No VisualEditor don't seem to be starting. [10:30:50] mooeypoo: I have the line require_once("$IP/extensions/VisualEditor/VisualEditor.php"); in LocalSettings.php [10:30:57] Are you getting any console errors? [10:30:58] With the enable lines et.c. [10:31:14] Or any server errors? [10:32:27] Dosen't say anything on the website. [10:32:43] The options is not even availeble [10:33:01] You don't have the 'edit' and 'edit source' tabs at all? [10:33:37] I just have the edit source tab not the edit tab [10:33:42] hm. [10:34:09] The Parsoid server is up and running nicely, can be accessed et.c. [10:34:52] yeah it sounds like VE's not even attempting to load. [10:35:06] Exactly, no clue why though. Restarted the httpd service several times. [10:35:24] Can you try to have ?veaction=edit on the URL ? [10:35:41] On whatever page [10:36:02] $wgVisualEditorParsoidURL or which option? [10:36:08] Ahh okai [10:36:18] something like this: http://localhost/w/index.php/Main_Page?veaction=edit [10:37:01] Still just edit source ;/ [10:37:08] did you go through the submodule init? [10:37:55] Yepp [10:38:12] hmmm [10:38:24] You got the code through git or by snapshot download or such ? [10:39:11] Firstly i downloaded it as snapshot but after i have extracted it i deleted it and got it by git. [10:39:36] Did the submodule init et.c. [10:39:40] ok, so it's git now. And you ran 'git submodule update --init' ? [10:39:41] hm [10:40:30] do you have the 'enabled for everyone' preference in your LocalSettings ? [10:40:59] I got this one yeah $wgDefaultUserOptions['visualeditor-enable'] = 1; [10:41:20] hmm. I was thinking of trying to enable it, but you already have it. [10:41:35] What version of MW are you running [10:41:53] 1.22~~ [10:41:58] Latest from the website [10:42:10] Yeah. [10:42:11] I set it up yesterday [10:42:18] Interesting, and weird. [10:42:31] Want the code in priv? [10:43:10] I'm trying to see what could cause this, and i'm starting to draw blanks. I think you might have more luck with RoanKattouw or Krinkle [10:43:24] Thanks for the help though! [10:43:37] both of them aren't here right now, though. RoanKattouw will be around in a couple of hours, PST work hours [10:43:46] Ahh :D [10:44:09] I'm the weirdo east-coaster that woke up way too early ;) the team's mostly in the west coast. [10:44:49] If you come back around 10:30am PST, I'm pretty confident Roan or Krinkle could help you out. [10:44:59] I will try later on then :) [10:49:35] mooeypoo: Is it possible to mail them? [10:53:42] You could start a bug [10:54:09] https://bugzilla.wikimedia.org/enter_bug.cgi?product=VisualEditor [10:55:07] Cheers thanks! [10:55:50] np :) [11:23:29] 3VisualEditor: VisualEditor won't start - With correct config - 10https://bugzilla.wikimedia.org/64428 (10Petter Viippola) 3UNC p:3Unprio s:3major a:3None I've done these steps and VisualEditor still dosen't work. There seems to be a problem with loading VisualEditor. I can only edit source, the comman... [16:24:29] 3VisualEditor / 3Editing Tools: VisualEditor: Inserting templates into new or pre-existing references in Firefox causes dead-end dialog: can't add, can't exit, can't save - 10https://bugzilla.wikimedia.org/64434 (10WhatamIdoing) 3NEW p:3Unprio s:3critic a:3None Steps to Reproduce: 1. Open any page... [16:28:50] James_F, did you see https://bugzilla.wikimedia.org/show_bug.cgi?id=64434 that I just filed? [16:28:55] It is Very Very Bad. [16:30:01] whatami: It's not that bad; you need to click to focus in Firefox. [16:30:18] whatami: We should make sure the toolbar is disabled when you're not focussed, though, I agree. [16:30:32] Anything that causes people to lose work is very bad. [16:30:49] We certainly should disable that, and ASAP. [16:31:13] We /do/ disable the toolbar when the cursor isn't in position. [16:31:23] It's just that there's clearly a bug here in that it's not working. [16:32:17] It's a bug that could cause, what, 25% of our users to lose work? [16:33:46] I'd say the number of our users who open a blank reference or image caption and immediately try to insert an item without clicking in the editor to be significantly lower than 1%. [16:33:53] It's a JS error, as I thought [16:33:57] range is null [16:34:38] (03PS22) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [16:36:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [16:37:16] (03PS23) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [16:38:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [16:38:50] Yo [16:39:03] From -multimedia [16:39:04] 2014-04-25 - 09:37:35 <+marktraceur> gi11es: Maybe we can start it off with a wikitech-l thread? [16:39:07] 2014-04-25 - 09:38:20 <+gi11es> sure, it'd be good if the oojs/ooui guys can tell us their take on why it's different/better than well known alternatives [16:39:33] We're getting to a point where we want to sit down and have a long hard think about what oojs and oojsui mean to us [16:39:54] "us" could be parsed here as "MediaWiki", "Wikimedia", "WMF", "Multimedia", "Multimedia and VE" etc. [16:40:05] But at least one answer should be reached [16:40:58] Does Gilles actually have a list well-known alternatives? We'd be fascinated to read it. As far as we're aware our approach is distinct. [16:41:44] Also, have you seen the recent thread on engineering@ about this? [16:54:36] RoanKattouw, ok, I'm officially in need of help. Would you have time to help me figure out what the hell I'm doing wrong in deleting/re-adding nodes in the image model? Everything I try to fix just creates other problems [16:54:44] Sure [16:54:46] I no longer have rangy problems, but now I have Transaction problems [16:54:48] aaaaaa [16:55:01] And I fixed that, but then the image is *only* deleted, not added. [16:55:06] repeat the aaaaaa. [16:55:06] Well I didn't write rangy but I did write the transaction system ;) [16:55:20] Is this code in Gerrit so I can try it for myself? [16:55:22] I am pretty sure htis is an error in the model, not in either rangy OR transaction [16:55:30] aye, I just updated it with the latest of my attempts [16:55:30] (BTW I just discovered focus-related bugs in Firefox and they're also aaaaa) [16:55:32] OK [16:55:43] oy, browser problems. Lovely! [16:55:58] oh btw, there was someone here earlier with issues installing/running VE [16:56:04] Yeah I saw [16:56:09] They filed a bug [16:56:12] I tried to troubleshoot but he seemed to be doing everything right, I was a bit stumped [16:56:14] yeah I asked hi to [16:56:15] him [16:56:18] But it's hard to figure out what their problem is without more information / access [16:56:28] I suspect the localhost:8000 setting may have been wrong [16:56:39] aye, I asked him to come back at PST business hours, but he wanted to email the team, so I suggested starting a bug [16:57:30] I thought it might be, but (a) he said parsoid is working independently, and (b) wouldn't that make the [edit] tab appear but *fail* ? as in, seeing some actual error? [16:57:34] VE isn't even loading for him [16:58:40] Oh that suggests a different error entirely [16:58:46] It wasn't clear which one was failing [16:59:03] OK so I've fetched your code, how do I reproduce the bug? [16:59:56] mooeypoo: ? [17:00:07] so, if you edit existing images WITHOUT changing their type, things work. Try to take an inline image like [[File:VisualEditor-logo.svg]] [17:00:12] and make it a thumbnail [17:00:25] that should transform it into a block node from inline node [17:00:28] and things go boom [17:02:13] What. The. Actual. Fuck [17:02:21] range.isCollapsed() --> not a functin [17:02:26] Because you know what range is? [17:02:28] 220! [17:02:40] wait, what? [17:02:43] Yes the number 220 doesn't have an isCollapsed() function [17:02:51] OK so let's see how range=220 got there [17:03:00] it's supposed to be an actual range, though [17:03:06] or.. maybe not. [17:03:20] I put OuterRange().start in there [17:05:50] RoanKattouw, ok, so here's a repeat of the previous problem i had.. take off the '.start' part -- now the node is just GONE. [17:05:51] no adding. [17:06:00] Well the removal now works [17:06:08] As opposed to crashing [17:06:19] So now you're running code that wasn't previously reachable [17:09:21] aye. There were so many weird errors, I may have debugged my way into worse errors. [17:09:32] I can reproduce that behavior [17:09:33] ... as just happened with the .start issue [17:09:50] Interesting discovery #1: there is no insertion transaction in the history at all, the removal transaction is the only thing there [17:10:52] oh, foo. This is a regression post-rebase. Great. [17:11:14] RoanKattouw, look at insertImageNode() in MWImageModel [17:11:21] line #216 [17:11:47] so, I'm doing this with 'getFragment' which we discussed , I believe, about how it's a Not Very Good Idea [17:12:10] Yes [17:12:21] but when I tried to do this directly with transaction things went poo too, so damnit. [17:12:27] That's the old way of doing it [17:12:44] You're supposed to pass a fragment now I think; MWReferenceModel / MWTemplateModel have examples [17:12:46] But that aside [17:13:01] Oh, hah [17:13:05] but what fragment do I pass if I deleted the fragment? [17:13:07] I repeat my objection: 231 is not a ve.Range [17:13:24] A fragment referring to an empty range [17:13:37] Which is what your fragment will be after deleting its contents [17:15:45] mooeypoo: So the quick fix for your problem is to change .getFragment( insertLocation || to .getFragment( new ve.Range( insertLocation ) || [17:16:07] mooeypoo: It should worry you that you have an expression like insertLocation || something.getRange() because insertLocation is a number and something.getRange() is a ve.Range [17:16:36] I thought maybe of doing ve.dm.Transaction.newFromInsertion(...) with the contentToInsert in there, but I just tried and that failed too. [17:17:16] RoanKattouw, I just changed the getFragment to (new ve.Range ... ) and it *still* doesn't work. [17:17:19] the image is just gone. [17:18:16] OH [17:18:18] I found another bug [17:18:27] Look at MWImageModel line 218 [17:18:30] Look very closely [17:18:34] At the character at the END of that line [17:18:40] And ask yourself why it's not a syntax error [17:18:41] The frustrating thing is that the image *used* to change, with a couple of bugs, and now it regressed to hating me. [17:18:59] .... holy crap [17:19:05] how is that NOT a syntax error! [17:19:31] is it assuming I'm defining getUpdatedAttributes().contentToInsert as attribute? [17:19:36] in a separate line... [17:20:12] Yes [17:20:16] ... ha [17:20:18] jshint and jscs should have complained [17:20:19] (03CR) 10Krinkle: Add a wiki-file-name type for file names (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (owner: 10Jforrester) [17:20:20] I'm going to cry now. [17:20:23] Let me see if they catch this [17:20:30] I ran grunt multiple times. [17:21:02] RoanKattouw, ... now things work [17:21:20] Hah yeah grunt didn't catch it [17:21:26] Neither jshint nor jscs did [17:21:33] I guess it is valid [17:21:40] var foo = this.getBar().baz = [...]; [17:21:40] pff. [17:21:48] yes, but 2 lines after? [17:21:56] Yeah the line breaks are stupid [17:22:00] grunt's crying out when I have a spare line anywhere else [17:22:01] That's a missing rule in jscs probably [17:22:12] eh, well, it seems to work now, except for caption [17:22:14] so .. progress. [17:22:22] Sweet [17:22:49] And also a demonstration of why it is bad to over-debug, [17:23:41] I don't know if I hsould find it extremely sad or extremely funny that my own debugging attempts created more problems, but anyways -- caption is having problems [17:23:50] so, ok, here's an interesting multi-level bug [17:24:28] part of it is behavior we'll need to figure out how to UI correctly, but I'm ignoring that for the moment: Take a basic image, transform it into a thumbnail. Then, click on that new thumbnail, and add a new caption. [17:24:40] What you'll see is no caption, but if you *save* the page, look at diff, you see there *is* a caption [17:24:47] .... which is extremely confusing. [17:24:53] (03CR) 10Jforrester: Add a wiki-file-name type for file names (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (owner: 10Jforrester) [17:25:07] I don't get if I am doing the adding correctly or not. Is this a CE representation issue? [17:26:16] Krinkle: ^^^ var Foo = Bar.\n\nBaz = 4; should surely trip a jscs error? Sequential new lines inside a definition? [17:29:31] RoanKattouw, if a block image had no caption before and we're adding a caption to it -- is that the 'onSplice' ? [17:29:56] 'cause I think CE is missing a routine to update the caption node itself in case it wasn't updated before, despite the fact updateCaption() is supposed to do that [17:30:03] but it's not called when the caption is actually updated [17:30:13] James_F: Yeah it should but it doesn;t [17:31:35] mooeypoo: Hmm yeah probably something related to onSplice, but the way captions are handled is weird in all sorts of ways [17:31:38] I'll investigate in a bit [17:32:36] Krinkle|detached: When you get back, I need your help to understand enough of the focusin-in-iframes hack to make it work for focusout as well. Needed for fixing a nasty Firefox issue [17:33:35] I am trying to add it to the onSplice and other errors are loading regarding the resource attribute. This is maddening, MWInlineImage also has a resource node, this shouldn't fire. er. [17:48:52] (03PS24) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [17:48:56] RoanKattouw, for consistency's sake, this is the updated version of the code with the fixes. The problem now is the caption where there was none. (so, a basic image -> thumb and then added a caption after the fact)) [17:49:23] also, is anyone else getting .docs/eg-iframe.html diff? [17:50:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [17:51:19] Krinkle|detached: Never mind, I figured it out [17:51:42] * mooeypoo will bbiab [18:07:22] (03PS1) 10Catrope: Followup 32fef8b5ee247: actually fix event aggregation, unbreak toolgroup disabling [oojs/ui] - 10https://gerrit.wikimedia.org/r/129717 [18:08:21] Krinkle|detached, remind me why we got rid of isMixedIn? [18:09:54] (03PS1) 10Esanders: Comment onDOMEvent hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129719 [18:15:05] (03PS1) 10Esanders: Prevent focussing of the pasteTarget with tabIndex=-1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129724 [18:31:58] 3VisualEditor / 3Editing Tools: VisualEditor: "Use an Existing Reference" option remains disabled for a reference inside Media Settings while there is a reference available to re-use in the page - 10https://bugzilla.wikimedia.org/60919 (10ryasmeen ) 5NEW>3ASS p:5Unprio>3High a:3Ed Sanders [18:36:26] (03PS5) 10Jdlrobson: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 [18:36:28] (03CR) 10jenkins-bot: [V: 04-1] Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [18:47:39] TrevorP|Away: https://gerrit.wikimedia.org/r/129717 [18:51:12] 3VisualEditor / 3Editing Tools: VisualEditor:Editor got unresponsive after a reference gets placed in a wrong position - 10https://bugzilla.wikimedia.org/56982#c4 (10ryasmeen ) I cannot reproduce this bug anymore This got fixed couple of weeks ago. [18:51:27] 3VisualEditor / 3Editing Tools: VisualEditor:Editor got unresponsive after a reference gets placed in a wrong position - 10https://bugzilla.wikimedia.org/56982 (10ryasmeen ) 5NEW>3RES/FIX [19:29:49] (03CR) 10Esanders: [C: 032] Followup 32fef8b5ee247: actually fix event aggregation, unbreak toolgroup disabling [oojs/ui] - 10https://gerrit.wikimedia.org/r/129717 (owner: 10Catrope) [19:30:19] (03Merged) 10jenkins-bot: Followup 32fef8b5ee247: actually fix event aggregation, unbreak toolgroup disabling [oojs/ui] - 10https://gerrit.wikimedia.org/r/129717 (owner: 10Catrope) [19:31:11] (03PS1) 10Catrope: Make onDOMEvent() wrap focusout in addition to focusin [oojs/ui] - 10https://gerrit.wikimedia.org/r/129733 [20:01:37] sigh. ConfirmEdit [20:02:09] Krenair: The extension everyone loves to loathe? [20:02:16] Install Asirra, you get that captcha on the edit source page. Okay. [20:02:38] I'm getting a simple captcha from the API. Oh well. [20:02:47] Helpful. [20:03:27] Oh, that's not the bad bit [20:03:55] CAPTCHAs on API calls isn't the worst of it? Oh dear. [20:04:02] When you submit the result of this simple captcha, you get warnings: {main:{*:Unrecognized parameters: 'wpCaptchaId', 'wpCaptchaWord'}} [20:04:13] * James_F laughs. [20:04:15] Oh dear. [20:04:32] This is fine if you specify the normal captcha in the wiki config, but not Asirra [20:09:54] (03PS1) 10Esanders: Move toolbar updateState code into separate method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129806 [20:12:07] MatmaRex, TrevorParscal: You should talk about https://gerrit.wikimedia.org/r/#/c/129563/ [20:15:47] (03PS1) 10Jforrester: Pull in Parsoid's new styling module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 [20:16:11] 3VisualEditor / 3MediaWiki integration: VisualEditor: Pull in Parsoid's new styling module so we don't need to duplicate locally - 10https://bugzilla.wikimedia.org/63983#c2 (10Gerrit Notification Bot) Change 129810 had a related patch set uploaded by Jforrester: Pull in Parsoid's new styling module https://... [20:17:50] hm [20:17:51] (03CR) 10jenkins-bot: [V: 04-1] Pull in Parsoid's new styling module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 (owner: 10Jforrester) [20:17:55] random edit with VE caused this to be added: [20:17:58] 3VisualEditor / 3ContentEditable: VisualEditor:Editor got unresponsive after a reference gets placed in a wrong position - 10https://bugzilla.wikimedia.org/56982 (10James Forrester) p:5Unprio>3High a:3Roan Kattouw [20:18:02] " [20:18:04] " [20:18:07] in two placs [20:18:09] places* [20:18:21] That… seems odd. [20:18:26] Was that string already on the page? [20:18:41] 'Cos Parsoid HTML doesn't go through Tidy, and isn't XHTML. [20:18:45] James_F: well, i'm lurking here if you need me. [20:18:51] oh god tidy [20:18:54] kill it with fire [20:18:59] Indeed. [20:19:10] it's 2014 and we're still running tidy on pages [20:19:13] madness, i tell you [20:19:48] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/129563/ [20:20:01] MatmaRex: When we switch MW's parser for Parsoid HTML we'll kill Tidy. [20:20:14] meh. [20:20:25] So… soon. :-) [20:25:50] MatmaRex: Happier with that temporary hack? [20:26:23] MatmaRex: The idea when you're happy with this is we'll immediately back-port to wmf1, wmf2 and REL1_23 probably. [20:27:22] James_F: well, it looks like it won't break caching now :) [20:27:53] looks like it's related to the math elements I have on my page [20:29:53] (03PS1) 10Esanders: [BREAKING CHANGE] Wrap updateState params in context object [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129815 [20:30:01] yep, that error comes up when I edit a page with a math elment on and goes away if I edit a page with only random text on [20:30:24] MatmaRex: Thoughts on the approach? [20:30:26] (03CR) 10Catrope: "This needs the Jenkins jobs to be updated to also install the Parsoid extension, otherwise the qunit job will fail because of a missing RL" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 (owner: 10Jforrester) [20:31:06] James_F: well, you can't possibly make our skins' HTML structure any worse than it already is, so whatever i guess [20:31:22] ±0 :) [20:32:45] Krenair: Might that be related to MathJax? [20:33:02] There's some code, which AIUI includes MathJax, that loads only on pages that have

tags
[20:34:26] MatmaRex: Want to +2? :-)
[20:34:43] might be
[20:37:30] (03CR) 10Catrope: Support QuestyCaptcha and (kind of) MathCaptcha (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129570 (owner: 10Alex Monk)
[20:38:18] James_F|Away: eh
[20:38:32] (03CR) 10Catrope: [C: 04-1] Use .mw-content for content styling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (owner: 10Trevor Parscal)
[20:38:41] RoanKattouw, based on https://www.mediawiki.org/wiki/Extension:ConfirmEdit#QuestyCaptcha I'd say it's really HTML
[20:38:45] OK
[20:38:52] Going to lunch but will +2 when I get back
[20:39:27] James_F|Away: i'm pretty sure that you are among the few PMs who won't get shouted at for exercising their +2 powers :P
[20:41:38] Is tables on the roadmap?
[20:42:59] https://www.mediawiki.org/wiki/VisualEditor/Roadmap
[20:44:01] (03CR) 10Alex Monk: Support QuestyCaptcha and (kind of) MathCaptcha (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129570 (owner: 10Alex Monk)
[20:49:35] Krenair: thanks, perfect document, imperfect answer
[20:53:16] (03PS6) 10Jdlrobson: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 
[20:54:56] Krenair, our output should actually be XHTML5
[20:55:10] tidy does not support XHTML5 though
[20:57:35] after rebasing why do i now get Uncaught Error: Unknown action: dialog ?
[21:00:24] ahh window actions now
[21:03:16] MatmaRex: Sure, but +2'ing code I've made a substantive change to is icky.
[21:03:39] RobertLabrie__: Yes, but it's not close.
[21:03:54] RobertLabrie__: Is there a particular part of table editing you're looking for?
[21:05:30] * marktraceur  sees scrollback late.
[21:05:37] (03PS25) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 
[21:05:51] I will read the wikitech thread and see if we can't come up with a list of requirements
[21:07:10] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo)
[21:07:12] RoanKattouw_away, inserting new image results in visiting "ve.dm.MWImageNode.prototype.getFilename" twice.. first time it gets a proper answer from getAttribute('resource') and second time it dies because getAttribute('resource') is empty, so the new image isn't inserted. I just finished revamping (again) the new image attributes, so I'm at a loss.
[21:08:54] (03PS3) 10Jdlrobson: [THOU SHALT NOT MERGE THEE] BetaWelcome tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125242 (owner: 10Trevor Parscal)
[21:10:43] Er, engineering.
[21:11:59] RoanKattouw_away: The engineering@ thread looks like it reads to the effect of "Wow those are great questions, but we aren't asking or answering them currently because other stuff is happening"
[21:12:19] Which is fine but important to know
[21:16:43] (03PS2) 10Jforrester: Use .mw-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (owner: 10Trevor Parscal)
[21:31:14] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab while keeping the math inspector open throws TypeError: Cannot read property 'start' of null - 10https://bugzilla.wikimedia.org/64451 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Created attachment 15210   --> https://bugzilla.wikimedia.org...
[21:32:13] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab while keeping the math inspector open throws TypeError: Cannot read property 'start' of null - 10https://bugzilla.wikimedia.org/64451 (10ryasmeen ) a:3Ed Sanders
[21:32:35] Why is this.panel in MWSaveDialog a StackLayout not a PanelLayout
[21:33:14] Krenair: Because it should be called this.panels
[21:33:22] TrevorParscal is refactoring this I tihnk
[21:33:30] okay
[21:33:42] In swapPanel, I would like to determine what panel we're swapping from
[21:34:00] (I want to limit where we call clearAllMessages to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=62766 )
[21:34:30] so that it doesn't trigger when swapping between review and save
[21:37:03] TrevorParscal: ----^^ ?
[21:37:58] I wonder if it should perhaps be called only as we open/close the dialog instead of swap panels...
[21:38:30] ok, so we need to actually start using ActionDialog for the save dialog, which uses setItem() to swap pages, which will be able to be listened to
[21:39:00] and with that you can track the current item by storing it at the end of the event handler
[21:39:13] and then comparing it to the item argument that's passed through the event
[21:39:16] I guess I should merge ActionDialog first
[21:39:30] there are some other issues with converting save dialog to action dialog
[21:39:56] 3VisualEditor / 3MediaWiki integration: VisualEditor: The Save dialog box prompts to fill out a new captcha if a user goes to review changes section and switches back after filling out the captcha field for the first time - 10https://bugzilla.wikimedia.org/62766 (10James Forrester)
[21:40:01] such as, ActionDialog provides a promise based solution to the primary action being executed (applyChanges) and closing the dialog
[21:40:25] but, the save dialog currently just emits an event when the save button is clicked, which we bind to in the integration and then close the dialog manually when it's done
[21:40:30] this is a big mess
[21:42:41]

| [23:09:33] that sounds just a bit off. [23:09:43] You should be inserting it at

| [23:09:48] oh [23:09:56] ha. Hm. [23:10:03] (Apologies if "good madam" sounds weird but I can't exactly say "good sir" to you like I do to Trevor) [23:10:25] No apologies necessary [23:10:49] Though I can't vouch to how good madamy I actually am. [23:11:26] RoanKattouw: "Madam" is implicitly "good". :_) [23:11:37] RoanKattouw, would things be easier if I added the empty mwImageCaption document to the contentToInsert (conditional of course on being mwBlockImage) and then changing it if needed? [23:11:45] parsoid ignores empty

anyways [23:12:16] also, I'm aware the .getText() !== '' is bad, but the getLength() <=4 didn't work at all, I was going to investigate further after I get things to work right. [23:13:01] mooeypoo: Yes [23:13:14] * mooeypoo nods [23:13:16] Empty caption is the way to go [23:13:23] trying that now. [23:13:30] Especially since you'll instantly have something to do newFromDocumentReplace() into [23:14:07] k, I'm running into the same 'resource' problem [23:14:23] (03PS1) 10Esanders: Delete extensions nodes which have been made empty [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129846 [23:14:37] wait, stop, i'm silly [23:14:39] ok, redoing that [23:15:42] Okay, so now the image appears, but without the caption. [23:15:49] I now have a problem with my replacement. [23:16:20] but I know why. The 'getMediaNode' references a nonexisting node. [23:16:34] I need to figure out how to set the media node to the newly inserted one [23:17:11] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab while keeping the math inspector open throws TypeError: Cannot read property 'start' of null - 10https://bugzilla.wikimedia.org/64451 (10James Forrester) 5NEW>3ASS p:5Unprio>3High [23:18:24] Hm. [23:21:18] (03PS27) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [23:22:12] RoanKattouw, take a look at the MWImageModel line #254 -- I'm trying to get the caption node of the media node, but the media node reference is gone. How can I get the offset of the node I *just* added? [23:22:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [23:24:18] Well, you just inserted it, didn't you? [23:24:29] So presumably you are able to remember at which offset you inserted it? [23:25:13] 3VisualEditor / 3Editing Tools: VisualEditor: When "__FORCETOC__" is set, inside VE instead of "Hide" the link to hide the TOC appears as "" - 10https://bugzilla.wikimedia.org/64464 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Created attachment 15215 --> https://bugzilla.wikimedia.org/a... [23:25:38] OK, so yeah this.getMediaNode() presumably doesn't work because it refers to a detached node? [23:25:52] a detached mwInlineImageNode even, so it has no caption? [23:27:31] mooeypoo: ---^^ ? [23:28:48] yep [23:28:57] (03PS1) 10Esanders: Clear the focusedNode when the document is blurred [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129851 [23:28:59] (03PS1) 10Catrope: Export showtoc and hidetoc messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129852 [23:29:05] I need to figure out how I take the offset to *change* the caption from the *newly created* block node [23:29:11] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab while keeping the math inspector open throws TypeError: Cannot read property 'start' of null - 10https://bugzilla.wikimedia.org/64451#c1 (10Ed Sanders) Pressing tab actually blurs the surface, but blurring the surface doesn't clear the focusedNode hi... [23:31:02] RoanKattouw, the code that's there works for changing the caption of an existing, non-destroyed block node. But I am stuck with what to do with the offset of a new block node. [23:31:13] Oh OK [23:31:21] So, you presumably computed the offset to insert at somehow [23:31:26] right [23:31:30] by the fragment [23:31:31] Krinkle: Hey; welcome back. :-) [23:31:33] That offset plus 2 is the offset inside of the caption [23:31:34] but I don't have a fragment no moa' [23:31:45] Krinkle: A clutch of TD commits for you to review. :-) [23:31:45] Krinkle: Review ambush: https://gerrit.wikimedia.org/r/129733 [23:32:01] oh [23:32:30] There is no way to get it other than by doing math on your insertion offset, we unfortunately don't give you a way to get a reference to the node you just inserted [23:32:40] hmm. [23:33:06] So I have another idea, RoanKattouw, but it confuses newFromInsertion and newFromDocumentInsertion [23:33:12] in the case of the caption, I have a document [23:33:22] in the case of the new node, I insert it as a model with the attributes, etc [23:33:42] is there a way to transform the *document* to a form I can just insert directly when I add the node? [23:33:58] I mean, there's no need for me to create an empty caption and then change it ifI know that there's content to add anyways [23:34:13] Unfortunately there is not [23:34:15] but I get the caption as a document already, so it's mismatching my form of adding. [23:34:20] ah. meh. [23:34:22] The way it's set up now you need to do them as separate transactions [23:34:41] We manage to do this for internalListItems though [23:34:52] I *could* translate the block node to a document fairly easily, but then the adding part is more difficult because it won't trust the fragment but will require ranges [23:36:40] (03PS2) 10Jforrester: Obey documented behavior and allow deprecated: true [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129844 (owner: 10Trevor Parscal) [23:36:56] 3MediaWiki extensions / 3TemplateData: TemplateData: Make description for Param#deprecated optional - 10https://bugzilla.wikimedia.org/53412#c1 (10Gerrit Notification Bot) Change 129844 had a related patch set uploaded by Jforrester: Obey documented behavior and allow deprecated: true https://gerrit.wikimed... [23:36:58] ok, "insertLocation" inserted content just before th eimage. "insertLocation + 2" inserted just after. [23:37:04] and insertLocation + 1 WORKS LIKE A CHARM [23:37:09] Hold on [23:37:17] Houston, we have captions. [23:37:25] Surely it's +2 not +1? Or did you not combine the insertion of the node and the caption yet? [23:37:56] no, +2 gets the caption to be outside (and after) the image block [23:37:57] No you did [23:38:02] Wait but [23:38:10] want me to send the code to review? it works now. [23:38:30] Surely you inserted , then you're doing a documentReplacement inside the caption? [23:38:35] Yes [23:38:42] So how is it not +2 [23:38:55] newFromDocumentInsertion actually [23:39:01] Rigth [23:39:44] That part I took from the old dialog. [23:39:48] (03PS3) 10Krinkle: Obey specified behaviour and allow Param#deprecated to be boolean true [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129844 (owner: 10Trevor Parscal) [23:42:22] mooeypoo: Yeah please do put your code in Gerrit [23:42:31] So I can see why it works with +1 rather than +2 [23:42:35] (03CR) 10Krinkle: "Need to be careful that this is actually supported in the callers. I recall us making an assumption about, if this value is truehty, that " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129844 (owner: 10Trevor Parscal) [23:42:47] (03PS28) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [23:42:49] (03CR) 10Catrope: [C: 032] Comment onDOMEvent hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129719 (owner: 10Esanders) [23:42:53] There ^^ [23:42:58] Seems to work now. [23:42:59] (03PS4) 10Krinkle: Obey specified behaviour and allow Param#deprecated to be boolean true [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129844 (owner: 10Trevor Parscal) [23:43:28] mooeypoo: new ve.Range( insertLocation ) || surfaceModel.getSelection().clone() [23:43:34] Is problematic for two reasons [23:43:42] 1) new ve.Range(foo) will never be null [23:43:49] 2) surfaceModel.getSelection() is allowed to be null now [23:43:52] but also, James_F / RoanKattouw / TrevorParscal -- UI question. When you take an inline default aligned image and make it a thumbnail, it is now practically aligned left (before 'default' for inline is opposite for default alignment for block) -- should I change it for the user because it's default, or should I assume the user wants to leave it where it is and add "LEFT" explicitly... ? [23:43:53] (03PS1) 10Trevor Parscal: Add info icon and alert indicator [oojs/ui] - 10https://gerrit.wikimedia.org/r/129854 [23:44:11] (03Merged) 10jenkins-bot: Comment onDOMEvent hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129719 (owner: 10Esanders) [23:44:15] RoanKattouw, there's no need for the surfacemo [23:44:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [23:44:22] Yeah exactly [23:44:22] err surfaceModel.getSelection() now [23:44:24] Hmm [23:44:31] I read the code and I have no clue why +1 works [23:44:33] I took it from the reference dialog, I believe. It's redundant here. [23:44:36] I swear it would need to be +2 [23:44:51] * RoanKattouw steps through it [23:46:10] (03CR) 10Krinkle: [C: 032] Obey specified behaviour and allow Param#deprecated to be boolean true [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129844 (owner: 10Trevor Parscal) [23:46:30] (03Merged) 10jenkins-bot: Obey specified behaviour and allow Param#deprecated to be boolean true [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129844 (owner: 10Trevor Parscal) [23:46:41] 3MediaWiki extensions / 3TemplateData: TemplateData: Make description for Param#deprecated optional - 10https://bugzilla.wikimedia.org/53412#c2 (10Gerrit Notification Bot) Change 129844 merged by jenkins-bot: Obey specified behaviour and allow Param#deprecated to be boolean true https://gerrit.wikimedia.org... [23:47:26] mooeypoo: The reason I can't figure out why it works is because it doesn't work [23:47:36]