[00:00:07] (03CR) 10Esanders: [C: 032] Export showtoc and hidetoc messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129852 (owner: 10Catrope) [00:01:16] (03CR) 10Catrope: [C: 032] Move toolbar updateState code into separate method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129806 (owner: 10Esanders) [00:01:50] (03Merged) 10jenkins-bot: Export showtoc and hidetoc messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129852 (owner: 10Catrope) [00:01:56] 3VisualEditor / 3Editing Tools: VisualEditor: When "__FORCETOC__" is set, inside VE instead of "Hide" the link to hide the TOC appears as "" - 10https://bugzilla.wikimedia.org/64464#c1 (10Gerrit Notification Bot) Change 129852 merged by jenkins-bot: Export showtoc and hidetoc messages https://gerri... [00:02:21] (03Merged) 10jenkins-bot: Move toolbar updateState code into separate method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129806 (owner: 10Esanders) [00:03:13] 3VisualEditor / 3Editing Tools: VisualEditor: When "__FORCETOC__" is set, inside VE instead of "Hide" the link to hide the TOC appears as "" - 10https://bugzilla.wikimedia.org/64464 (10James Forrester) 5PAT>3RES/FIX p:5Unprio>3Normal s:5normal>3minor a:3Roan Kattouw [00:03:42] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab while keeping the math inspector open throws TypeError: Cannot read property 'start' of null - 10https://bugzilla.wikimedia.org/64451 (10James Forrester) 5ASS>3RES/FIX [00:05:11] 3VisualEditor / 3Editing Tools: VisualEditor: In the transclusion dialog's panel for a parameter, use "Param#deprecated" from TemplateData - 10https://bugzilla.wikimedia.org/53612 (10James Forrester) [00:05:48] (03CR) 10Catrope: [C: 04-1] [BREAKING CHANGE] Simplify updateState params (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129815 (owner: 10Esanders) [00:05:58] 3MediaWiki extensions / 3TemplateData: TemplateData: Make description for Param#deprecated optional - 10https://bugzilla.wikimedia.org/53412 (10James Forrester) 5PAT>3RES/FIX a:3Trevor Parscal [00:06:29] (03CR) 10Catrope: [C: 032] [BREAKING CHANGE] Simplify updateState params (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129815 (owner: 10Esanders) [00:07:18] (03CR) 10Catrope: [C: 032] Prevent focussing of the pasteTarget with tabIndex=-1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129724 (owner: 10Esanders) [00:07:29] (03CR) 10Esanders: "There's an optical illusion at work that makes the dot on the 'i' look like it isn't centred because it hangs over the right hand side of " [oojs/ui] - 10https://gerrit.wikimedia.org/r/129854 (owner: 10Trevor Parscal) [00:07:36] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Simplify updateState params [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129815 (owner: 10Esanders) [00:07:54] (03PS2) 10Catrope: Check for focus change on global mousedown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129859 (owner: 10Esanders) [00:08:26] (03Merged) 10jenkins-bot: Prevent focussing of the pasteTarget with tabIndex=-1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129724 (owner: 10Esanders) [00:08:54] (03CR) 10Catrope: [C: 032] "We might end up having to do this only while the document is blurred, because I'm afraid calling rangy on every mousedown might be too slo" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129859 (owner: 10Esanders) [00:09:07] (03CR) 10Catrope: [C: 032] Only focus the surface on inspector close if range is not null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129860 (owner: 10Esanders) [00:09:15] (03PS2) 10Catrope: Only focus the surface on inspector close if range is not null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129860 (owner: 10Esanders) [00:09:20] (03PS2) 10Trevor Parscal: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 [00:09:42] (03CR) 10Catrope: [C: 032] Only focus the surface on inspector close if range is not null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129860 (owner: 10Esanders) [00:09:54] (03CR) 10Jforrester: [C: 04-2] "This method is used in I3b968ad14a." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129857 (owner: 10Krinkle) [00:10:03] (03Merged) 10jenkins-bot: Check for focus change on global mousedown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129859 (owner: 10Esanders) [00:14:13] (03Merged) 10jenkins-bot: Only focus the surface on inspector close if range is not null [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129860 (owner: 10Esanders) [00:14:15] (03CR) 10Krinkle: "It's unused in master. That's a change still pending review. Both changes depend on the same parent commit from master. These changes conf" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129857 (owner: 10Krinkle) [00:15:16] (03CR) 10Catrope: [C: 032] Delete extensions nodes which have been made empty [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129846 (owner: 10Esanders) [00:15:30] (03CR) 10Jforrester: "I -2'ed rather than immediately abandon so that Roan would be prompted to look at your concerns." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129857 (owner: 10Krinkle) [00:15:44] (03PS3) 10Catrope: [BREAKING CHANGE] Show matched string in LanguageSearchWidget results [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129584 (owner: 10Esanders) [00:16:11] 3VisualEditor: VisualEditor won't start - With correct config - 10https://bugzilla.wikimedia.org/64428#c1 (10James Forrester) Does VisualEditor show up on Special:Version? If no, are there entries in your PHP error logs on the server? If yes, are there errors in your JS console on your client when you open a... [00:16:44] (03Merged) 10jenkins-bot: Delete extensions nodes which have been made empty [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129846 (owner: 10Esanders) [00:16:46] (03CR) 10Krinkle: "The deprecation description message method seems rather confusing this way. It repeats the logic again and creates a strange responsibilit" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (owner: 10Trevor Parscal) [00:19:38] (03PS3) 10Trevor Parscal: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 [00:22:11] 3VisualEditor / 3ContentEditable: VisualEditor: Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399 (10James Forrester) 5NEW>3ASS p:5Unprio>3High [00:25:48] (03CR) 10Krinkle: Make onDOMEvent() wrap focusout in addition to focusin (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/129733 (owner: 10Catrope) [00:26:08] (03CR) 10Esanders: "Unless you've got a JS whack-a-mole game in the same document surely that's not much of a problem?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129859 (owner: 10Esanders) [00:27:10] (03PS2) 10Krinkle: Element: Make onDOMEvent fix focusout in addition to focusin [oojs/ui] - 10https://gerrit.wikimedia.org/r/129733 (owner: 10Catrope) [00:27:44] (03CR) 10Krinkle: [C: 032] Element: Make onDOMEvent fix focusout in addition to focusin [oojs/ui] - 10https://gerrit.wikimedia.org/r/129733 (owner: 10Catrope) [00:28:13] (03Merged) 10jenkins-bot: Element: Make onDOMEvent fix focusout in addition to focusin [oojs/ui] - 10https://gerrit.wikimedia.org/r/129733 (owner: 10Catrope) [00:50:33] (03PS1) 10Krinkle: build: Update jscs config and phase out deprecated jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/129869 [00:50:49] (03CR) 10Krinkle: "Similar to Iebd3993017c in oojs/core" [oojs/ui] - 10https://gerrit.wikimedia.org/r/129869 (owner: 10Krinkle) [13:21:21] (03PS1) 10Krinkle: InputWidget: DOM property is 'readOnly', not 'readonly' [oojs/ui] - 10https://gerrit.wikimedia.org/r/129886 [14:01:14] 3VisualEditor / 3Editing Tools: Toolbar: - 10https://bugzilla.wikimedia.org/64479 (10Rezonansowy) 3UNC p:3Unprio s:3normal a:3None Created attachment 15219 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15219&action=edit Proposed apperance For consistency, we can merge the 'Save' and 'Cancel... [14:01:41] 3VisualEditor / 3Editing Tools: Toolbar: Merge 'Save' and 'Cancel' buttons to a one group - 10https://bugzilla.wikimedia.org/64479 (10Rezonansowy) [14:01:56] 3VisualEditor / 3Editing Tools: Toolbar: Merge 'Save' and 'Cancel' buttons to a one group - 10https://bugzilla.wikimedia.org/64479 (10Rezonansowy) s:5normal>3enhanc [18:00:56] 3VisualEditor / 3Editing Tools: 'Insert' menu opens behind page content - 10https://bugzilla.wikimedia.org/64388#c2 (10Bryce Glover) Yes; I have several modifications installed as modifications both to my local copy of Safari and to my Wikipedia account (I was experiencing this bug on the English WP.) In Sa... [18:56:56] 3VisualEditor / 3Editing Tools: 'Insert' menu opens behind page content - 10https://bugzilla.wikimedia.org/64388#c3 (10Bryce Glover) I've just found out that this bug also occurs for another menu (the 'Formatting' one — that's what the menu with an icon that looks like an underlined capital 'A' is called, ri... [18:57:26] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388 (10Bryce Glover) [21:13:26] 3MediaWiki extensions / 3TemplateData: TemplateData: Implement hook for extensions to document parser functions - 10https://bugzilla.wikimedia.org/52607 (10James Forrester) 5NEW>3ASS