[11:16:08] 3VisualEditor / 3Editing Tools: VisualEditor: Call the "transclusion" dialog a "template" dialog (in the toolbar and elsewhere), even though it lets you add non-template transclusions - 10https://bugzilla.wikimedia.org/55434#c5 (10Helder) Created attachment 15228 --> https://bugzilla.wikimedia.org/attachme... [11:16:38] 3VisualEditor / 3Editing Tools: VisualEditor: Call the "transclusion" dialog a "template" dialog (in the toolbar and elsewhere), even though it lets you add non-template transclusions - 10https://bugzilla.wikimedia.org/55434 (10Helder) 5RES/FIX>3REO [14:10:22] (03PS1) 10Alex Monk: Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) [14:10:42] (03CR) 10jenkins-bot: [V: 04-1] Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [14:13:31] (03PS2) 10Alex Monk: Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) [14:16:58] (03CR) 10Alex Monk: "Not quite sure about my use of the Language functions for this, could you take a quick look for me please Siebrand? Thanks." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [15:09:15] (03PS1) 10Alex Monk: Don't change section edit links on foreign file description pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130082 (https://bugzilla.wikimedia.org/54259) [15:22:39] (03PS2) 10Jforrester: Pull in Parsoid's new styling module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 (https://bugzilla.wikimedia.org/63983) [15:42:24] (03PS1) 10Alex Monk: Fix tab selection on monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130085 (https://bugzilla.wikimedia.org/49407) [15:52:20] James_F: Key ingredient to have "functional" dependencies in RL presented itself to me today. Implementation immenent [15:52:52] Krinkle: Yay. [15:53:04] Krinkle: That'll make Multimedia happy, hopefully. :-) [16:20:22] (03PS1) 10Jforrester: Explain for -wiki- types that the should not include namespace [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130090 [16:25:05] (03PS3) 10Jforrester: Add a wiki-file-name type for file names [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) [16:25:21] (03CR) 10Jforrester: Add a wiki-file-name type for file names (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) (owner: 10Jforrester) [16:44:06] James_F, I should probably figure out what I plan to do today before the meeting [16:44:15] Krenair: :-) [16:44:42] unless you have a list of stuff for me [17:38:11] Krenair: For bug 52980 – maybe turn it into a button where if you hold down you get a menu? [17:38:21] s/it/the "save" button/ [17:38:45] Krenair: That'd need some new functionality in OOjs UI, though – TrevorP|Away and Krinkle will probably have some thoughts. [17:39:43] http://getbootstrap.com/components/#btn-dropdowns [17:39:51] something like that? [17:40:22] A split button one, yeah. [17:40:35] yeah, split, so there is still a short path the the primary actin [17:40:39] action [17:40:45] That could also be where "cancel" and "switch to wikitext" could go. [17:40:46] * James_F nods. [17:41:07] Hm... not sure we should tuck away cancel [17:41:39] though I'd welcome a different place for it in general, I like the idea of not having cancel next to save up on the right [17:41:53] Well, "Read" is a cancel button. [17:42:07] Yeah, I thought of that too [17:42:10] Every link outside of the toolbar and surface is a cancel button. [17:42:35] And officially cancel should be red (as a destructive change), which… looks really ugly. [17:42:42] Hiding it avoids this issue. :-) [17:43:13] And anything that narrows the width needed for the toolbar is good. :-) [17:44:29] Yeah [17:44:44] Maybe a Windows XP style [x] on the top right [17:44:59] and clippy asking whether you're sure and want to loose unsaved changes [17:45:18] … maybe not. :-) [17:45:49] Krinkle: BTW was https://gerrit.wikimedia.org/r/#/c/130090/ what you were looking for? [17:49:20] Krenair: Did you fix https://bugzilla.wikimedia.org/show_bug.cgi?id=57861 but under a different bug#? [17:49:55] It's a GlobalBlocking bug which I put a patch in Gerrit for [17:50:16] Oh, yes, that was https://bugzilla.wikimedia.org/show_bug.cgi?id=53009 [17:50:28] https://gerrit.wikimedia.org/r/#/c/127835/ [17:52:34] (03CR) 10Krinkle: Explain for -wiki- types that the should not include namespace (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130090 (owner: 10Jforrester) [17:52:50] Thanks to the magic of https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/VisualEditor,dashboards/default that's now in Roan's list. ;-) [17:53:04] Well, it would be if we merged a few more things. [17:54:11] Krinkle: Is the text OK for wiki-user-name, but we shouldn't say anything for wiki-page-name (and so there's no way to specify a Template without Template:… unless we add a new type)? [17:54:17] Yes [17:54:22] OK, will fix. [17:54:42] James_F: Maybe you thought wiki-page-name is like main namespace? [17:54:55] I did. [17:54:59] Well, no. [17:55:02] That's not what it is for currently. That's an interesting to have though maybe. But might not be needed at this point. [17:55:13] I thought you wanted it to be a title (rather than NS'ed title) name. [17:55:25] Or whatever MW's official term for the difference is. [17:55:37] I changed the commit to mention that bug and moved the bug to the GlobalBlocking part of BZ [17:55:59] James_F: Right, and the parameter would use it for whatever namespace is relevant. Hm.. seems tricky to implement for consumers, they couldn't implement validation or autocompletion without knowing the intended namespace. [17:56:02] (03PS2) 10Jforrester: Explain for wiki-user-name type that it should not include namespace [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130090 [17:56:12] Krinkle: Fair. [17:56:19] user and file are separate and can be done so because they are detached from page names and have their own autocomplete and listing API [17:56:26] * James_F nods. [17:56:29] e.g. for usernames and files and categories, you wouldn't use prefixsearch. [17:56:34] Or shouldnt anyway. [17:56:44] (03CR) 10Jforrester: Explain for wiki-user-name type that it should not include namespace (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130090 (owner: 10Jforrester) [17:56:55] it woudl probably get like 70% still, but it'd be semantically wrong. [17:57:00] Is there one for templates? [17:57:03] Nope [17:57:09] Hmm. Should we add one? [17:57:26] Don't think so, that's page-name. Transclusion can also happen from any namespace as far as mediawiki is concerned. [17:57:31] (We're using OpenSearch for all three other than images right now, I think?) [17:57:39] Eh. True. [17:57:40] We're not using anything for any right now [17:57:44] * James_F grumbles about MediaWiki. [17:57:51] We have yet to have actual input fields for template dialog [17:57:55] afaik [17:58:04] Trevor's next thing to work on. [17:58:06] Are all the VE guys in town again? [17:58:23] BladeBronson: Again? No. edsanders's just leaving tomorrow, then we'll be back to just the usual four of us. [17:58:30] BladeBronson: We've all left over the last 8 days. Ed is the last one, leaving tomorrow. [17:58:34] (03PS4) 10Jforrester: Add a wiki-file-name type for file names [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) [17:58:47] * Krenair was never there in the first place [17:58:51] Next time get me for a bike ride or something, punks. [17:59:00] BladeBronson: yeah, that'd be nice. [17:59:04] Krenair: Well, not since January. :-) [17:59:06] BladeBronson: At least we had lunch at Chaat. [17:59:13] Come and have lunch today [17:59:14] yeah but I wasn't working on VE then [17:59:22] Krinkle: "At least we'll always have Paris" much? :-) [17:59:28] Krenair: True. :-( [17:59:36] Krenair: We'll fix this at some point. [17:59:39] Can't make lunch today. VE team here is having Dapper Day and I'm sure we're going to get some posh lunch. [17:59:54] Tomorrow? [18:00:07] Krinkle: Your input on https://gerrit.wikimedia.org/r/#/c/129594/ is higher priority, BTW. [18:00:15] (03CR) 10Krinkle: [C: 032] Explain for wiki-user-name type that it should not include namespace [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130090 (owner: 10Jforrester) [18:00:23] James_F: yeah [18:00:40] still twiddling my thumbs over that one [18:00:47] Krinkle: I'm not totally comfortable about the implicit mutual exclusion state in the data model, but we can fix it later. [18:00:52] Krinkle: I'd noticed. :-D [18:01:00] I recall there being something when Trevor and I talked it over with the MoarTemplateData pad in front of us. couple months ago [18:01:09] don't remember what it was, maybe this was it. [18:01:21] I think it was. [18:02:55] James_F: Yeah, though they're not intended as mutually exclusive. Right now there's no reason a required or suggested parameter can't be deprecated. The UI would afaik present that independently. Some of them supersede the other, but should be fine. E.g. deprecated parameters will probably be sorted last in the bucket of available parameters to add. And suggested ones would be already in the s [18:02:55] idebar ready to activate and if removed, sort on top in the bucket. And required is always there and not removable. [18:03:01] edsanders: Tomorrow, done. [18:03:11] They don't occupy the same logical space, but some do supersede the other. [18:03:22] so yeah, mutually exclusive is the term. [18:03:39] And I'd like to make it impossible to deprecate things that are required or suggested. [18:04:05] Krinkle: The code says they're mutually exclusive, however. [18:04:10] James_F: What code? [18:04:15] Krinkle: TD's code. [18:04:19] where? [18:04:24] The bit I changed. [18:04:39] that's only the html rendering of it. [18:04:45] Means close to "nothing" [18:04:56] Sure, but it's a bad code smell. [18:05:31] If they're mutually exclusive, the parser would make it illegal, like how it is illegal (and therefor blocked) to save suggested: with non-boolean value, or how it is illegal to have a parameter set that contains unknown keys [18:05:43] right now those prevent edit from saved [18:05:43] * James_F nods. [18:06:16] The spec says nothing about it, and the html class is purely for the style. Neither spec, parser or says it. [18:06:21] But we can change that. [18:06:57] Sure. [18:07:01] I made them boolean to make consuming and scaling easier. Though I think that concern isn't valid anymore. [18:07:04] Let's merge it now and fix it later? [18:07:16] E.g. in early adopters, it was easy to support required. Just add if d.required. [18:07:23] 'Cos it's blocking (along with other things) release of the citation tool. [18:07:53] Whereas if you have 'status' as a property, consumers that are incompotent and don't deal with unknown future values well, stuff breaks. Whereas new properties are just silently there for existing consumers, harmless [18:09:08] (03CR) 10Krinkle: "Can you add a little bit about this property in the spec? Required doesn't have it (though it should), but that one is pretty straight for" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129594 (owner: 10Jforrester) [18:09:14] (03CR) 10Krinkle: "Other than that, good to go." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129594 (owner: 10Jforrester) [18:09:21] (03CR) 10Krinkle: "Oh, was there a bug ref?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129594 (owner: 10Jforrester) [18:29:53] Krinkle: Once I started writing documentation for TD it's hard to stop. :-) [18:43:11] (03CR) 10Catrope: [C: 04-1] Fix tab selection on monobook (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130085 (https://bugzilla.wikimedia.org/49407) (owner: 10Alex Monk) [18:44:32] (03CR) 10Catrope: [C: 032] Pull in Parsoid's new styling module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 (https://bugzilla.wikimedia.org/63983) (owner: 10Jforrester) [18:45:02] (03PS29) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [18:45:07] RoanKattouw, ^^ IT WORKS. [18:45:10] \o/ [18:45:19] \o/ [18:45:22] Awesome! [18:45:43] (03Merged) 10jenkins-bot: Explain for wiki-user-name type that it should not include namespace [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130090 (owner: 10Jforrester) [18:45:49] (03PS4) 10Jforrester: Add 'suggested' status type for parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129594 [18:46:06] Krinkle: Written a bunch of documentation there, but eventually stopped myself. Thoughts? [18:46:37] (03CR) 10Catrope: [C: 04-1] Don't change section edit links on foreign file description pages (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130082 (https://bugzilla.wikimedia.org/54259) (owner: 10Alex Monk) [18:46:52] RoanKattouw, the only problem now is that there's no real way of making a block image into an inline image :D [18:47:00] How so? [18:47:21] because we don't have an explicit "default position" and we don't have valign yet [18:47:33] so, to make basic image inline, you need to make it basic without alignment at all [18:47:38] same with frameless [18:48:20] but there's no "default" -- we took default alignment off, because it was confusing, so we only use left/center/right and 'none' with the checkbox. All of those would produce a block rather than an inline image [18:48:54] So, we should either add default alignment, or add "vertical alignment" and if the user selects it, we override the "regular" alignment [18:49:20] (03PS2) 10Catrope: Don't change section edit links on foreign file description pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130082 (https://bugzilla.wikimedia.org/54259) (owner: 10Alex Monk) [18:49:33] but since this is a UI issue, I left it for us to discuss. The model should be good to go *pending testing*. I need someone to test this more to make sure I didn't miss any behavior issues. [18:49:37] (03CR) 10Catrope: [C: 032] Don't change section edit links on foreign file description pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130082 (https://bugzilla.wikimedia.org/54259) (owner: 10Alex Monk) [18:49:59] TrevorParscal, James_F, ^^ for you as well [18:50:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:50:52] alex, this looks really scary (like the rest of init) [18:51:14] talk me through the other possible scenarios where we should avoid transforming section edit linkes [18:51:24] ( Krenair ---^^ ) [18:51:25] and, doesn't theedit tab still appear in this case? [18:53:08] (03Merged) 10jenkins-bot: Don't change section edit links on foreign file description pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130082 (https://bugzilla.wikimedia.org/54259) (owner: 10Alex Monk) [18:54:00] Krinkle: https://gerrit.wikimedia.org/r/#/c/129594/ doesn't have a bug, sorry; there's 50747 in VE for warnings for required parameters, but no explicit bug (just mentions) elsewhere. [18:55:12] James_F: Hm.. a bit lengthy indeed. Fine line between specification and documentation. This is mostly spec. But will suffice for sure. [18:55:31] (03CR) 10Krinkle: [C: 032] Add 'suggested' status type for parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129594 (owner: 10Jforrester) [18:55:32] Krinkle: Yeah. We should probably move it on-wiki. [18:55:45] Well, the spec belongs in the repo (versioning etc.) [18:56:11] OK, we should move it into a more expansive set of documentation, mastered somewhere that makes you happy. :-) [18:56:17] (03Merged) 10jenkins-bot: Add 'suggested' status type for parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129594 (owner: 10Jforrester) [18:56:22] Yay. [18:56:44] (03PS5) 10Jforrester: Add a wiki-file-name type for file names [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) [18:58:39] Hi TrevorParscal [18:59:02] I was surprised that monobook handles selection of tabs differently [18:59:10] though perhaps I shouldn't be [18:59:29] Roan, please look at this so we can chat about it: https://gerrit.wikimedia.org/r/#/c/129563/ [18:59:46] uh, this is the wrong bug, haha [18:59:48] one moment [19:00:06] Krenair: I'm just reacting to seeing you select an ID which I don't know how common/stable/unique it is [19:00:21] Krenair: https://gerrit.wikimedia.org/r/#/c/130082/2/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js,unified [19:00:40] TrevorParscal, okay, basically core MW has different tabs on foreign file description pages [19:00:49] (03PS3) 10Catrope: Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [19:01:14] right, so how do we detect this when deciding what to do with generating a VE edit tab? [19:01:15] (03CR) 10Catrope: [C: 032] Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [19:01:47] why not link the behavior of remapping section edit links to showing a VE edit tab, no tab no link modification [19:04:13] (03CR) 10jenkins-bot: [V: 04-1] Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [19:10:50] (03PS1) 10Jforrester: Use TemplateData's `suggested` status for parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130124 [19:11:41] (03PS4) 10Catrope: Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [19:11:59] (03CR) 10Catrope: [C: 032] Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [19:12:28] (03CR) 10Trevor Parscal: [C: 032] Use TemplateData's `suggested` status for parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130124 (owner: 10Jforrester) [19:15:08] (03Merged) 10jenkins-bot: Add dynamically generated list of namespaces to visualeditor-enable preference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130075 (https://bugzilla.wikimedia.org/51411) (owner: 10Alex Monk) [19:15:54] (03Merged) 10jenkins-bot: Use TemplateData's `suggested` status for parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130124 (owner: 10Jforrester) [19:16:19] James_F, TrevorParscal, the image model is ready for testing. I'm not comfortable taking the 'wip' off it 'till someone other than me plays with it a bit. [19:16:24] (03CR) 10Trevor Parscal: Use ActionDialog and NodeDialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [19:16:51] (03PS6) 10Trevor Parscal: Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 [19:17:04] (03CR) 10jenkins-bot: [V: 04-1] Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [19:17:10] mooeypoo: awesome! [19:17:22] by the way, whatever became of that mouse? [19:17:37] Are you guys like friends now? Did he/she/heshe leave? [19:17:54] (03PS3) 10Catrope: Pull in Parsoid's new styling module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 (https://bugzilla.wikimedia.org/63983) (owner: 10Jforrester) [19:18:37] TrevorParscal, ugh, turns out a lot of my messages didn't go through earlier [19:18:47] right, so how do we detect this when deciding what to do with generating a VE edit tab? [19:18:52] TrevorParscal, that is exactly what this check is [19:18:54] It looks for the foreign file tab [19:18:58] The foreign file repo stuff is what's used to get commons files on other wikis almost as if they are local. [19:19:01] Next to the Read tab you get 'View on Wikimedia Commons', this tab has id=ca-view-foreign [19:19:27] (03CR) 10Esanders: "[BREAKING CHANGE]!!!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129334 (owner: 10Trevor Parscal) [19:19:55] TrevorParscal, I've been chasing it for a few weeks and then, after the 10th round of angry-super-duper-cleaning-of-the-apartment, after tossing tons of suspected-mouse-eaten-stuff, I never saw it again. [19:21:04] Three possibilities: it may have run off to a hidden hole, or it may have died somewhere and I will know it when it starts to smell, or it may have been inside something I tossed out with the garbage. [19:21:32] Since all my 10 billion traps still exist and are still empty, I suspect there is no hole. So.. either #2 or #3. [19:22:33] And thinking about unknowingly tossing it out makes me uncomfortable. So I am torn between hoping for #2 or hoping for #3 [19:23:30] mooeypoo, it also might have been frightened by the cleaning and run away to pester one of your neighbors. [19:23:31] (03CR) 10Esanders: "apparently not breaking" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129334 (owner: 10Trevor Parscal) [19:23:40] whatami: Sounds likely. :-) [19:23:46] whatami, yes, but that would imply a hole. [19:24:06] Or a door. [19:24:16] You think it snuck out through the front door? [19:24:26] I've heard that it happens. [19:24:29] ... You know what? That mouse is smart. That might be... [19:24:41] though THAT raises the possibility of mice sneaking back *in *through the door. [19:26:26] (03PS30) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [19:26:37] ok, minor documentation changes I hope jenkins will stop crying about. [19:27:04] mooeypoo: Hope? :-D [19:27:29] James_F, I hope there's nothing *else* jenkins will cry about? [19:27:45] * mooeypoo tries to bribe jenkins [19:27:53] mooeypoo: `grunt test` is your friend. [19:28:01] it passed grunt tests. [19:28:12] jenkins was complaining on things grunt didn't catch. [19:28:22] Hmm. [19:28:31] nonexisting links and a mistaken {[type]} [19:28:57] is grunt supposed to do that? [19:29:21] Oh, jsduck? No, that's ruby-based. [19:29:35] * James_F has jsduck locally though so I can (but don't ;-)) catch those. [19:30:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [19:31:09] oh, jenkins. [19:31:33] meh [19:31:47] tests. [19:34:33] haha [19:34:58] RoanKattouw, remember I casually asked if anything's going to break if I changed MWInlineImage 'type' to 'inline' so it's consistent? [19:35:13] The answer is 'tests will'. :D [19:35:16] apparently. [19:35:17] haha [19:35:27] Testing: We've Heard Of It [19:35:34] (03PS1) 10Cmcmahon: [browser test] use ?veaction=edit to avoid login where feasible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130144 [19:36:14] Though the second failure I am a bit confused about. [19:36:59] "ve.dm.Converter: getDomFromModel" fails on images too, but it seems to expect "html" attributes that I didn't touch. Hm. [19:38:28] (03PS2) 10Cmcmahon: [browser test] use ?veaction=edit to avoid login where feasible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130144 [19:38:43] Krinkle: How hard would doing some of the OOjs (not OOjs UI) polyfills for ES3 be? [19:39:08] (03CR) 10Catrope: [C: 04-1] "Citation dialog not ported at all" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [19:39:26] mooeypoo: Let me look at that in a second [19:39:30] James_F: The popular es5 shim should suffice. Except maybe Object.create, but there's a separate shim for that. [19:39:45] RoanKattouw, I'm trying to figure out how to fix the first test too. I think I got it. But the second is odd. [19:39:47] However that needs the function-dependency feature in RL since we wouldn't want to load that everywhere. [19:39:55] Krinkle: Yeah, indeed. [19:40:02] the shim isn't the issue, I mentioned that on the bug already I think. [19:40:09] Krinkle: You said tantalisingly this morning that I should expect movement on that "imminently". :-) [19:40:09] some bug or some wiki page [19:40:11] don't recall [19:40:13] Krinkle: Yeah. [19:40:18] Yeah, I'm writing it [19:40:23] in between fighting fires [19:40:31] Krinkle: I'm just trying to get my head around how far off OOjs on ES3 is something we can offer. [19:40:34] * James_F nods. [19:40:47] Krinkle: Feel free to leave some of the fire-fighting to others. :-) [19:41:08] jsduck upgrade [19:41:17] (03CR) 10Catrope: Use ActionDialog and NodeDialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [19:41:19] oy, I see why the test fails, and... this is actually a bit more complicated to fix [19:41:45] Krinkle: hashar not dealing? [19:41:47] Needs testing in labs, but literally *every* *single* time I've took on anything in labs, things don't work as expected, thing thing doesn't do that, that thing doesn't do this, missing documentation here, broken module there... [19:41:53] James_F: He doesn't know jsduck [19:41:59] http://integration-slave1002.wmflabs.org/krinkle-jsduck [19:43:18] Krinkle: Is that meant to time out? [19:47:25] (03PS31) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [19:48:00] come on, Jenkins. [19:50:02] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (32fef8b5ee) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130146 [19:50:12] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [19:50:29] mooeypoo: I'm glad you were able to solve your mouse problem [19:50:47] I imagine it was a dramatic experience [19:51:00] perhaps even tramatic [19:51:04] TrevorParscal, at some point I just resigned to the fact I live in a cartoon. [19:51:06] (03CR) 10Catrope: [C: 032] Pull in Parsoid's new styling module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 (https://bugzilla.wikimedia.org/63983) (owner: 10Jforrester) [19:51:41] TrevorParscal, that was right after *I* stepped into one of the sticky traps, and realized it caught *me* and not the damn mouse. [19:51:55] (03PS11) 10Jforrester: Add ActionDialog and NodeDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129334 (owner: 10Trevor Parscal) [19:52:05] (03CR) 10Jforrester: Add ActionDialog and NodeDialog (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129334 (owner: 10Trevor Parscal) [19:52:15] (03CR) 10Catrope: [C: 032] InputWidget: DOM property is 'readOnly', not 'readonly' [oojs/ui] - 10https://gerrit.wikimedia.org/r/129886 (owner: 10Krinkle) [19:53:03] (03Merged) 10jenkins-bot: Pull in Parsoid's new styling module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129810 (https://bugzilla.wikimedia.org/63983) (owner: 10Jforrester) [19:53:07] (03Merged) 10jenkins-bot: InputWidget: DOM property is 'readOnly', not 'readonly' [oojs/ui] - 10https://gerrit.wikimedia.org/r/129886 (owner: 10Krinkle) [19:53:28] (03CR) 10Catrope: [C: 032] Add ActionDialog and NodeDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129334 (owner: 10Trevor Parscal) [19:53:40] mooeypoo: In in a movie theater later this year... "From the people who worked security at Pixar during the production of Finding Nemo - In the city, you must fight to survive - she took a stand and faught for her territory, he scurried around and pooped here and there - she was an ex-military bad @$$, he was an adrenaline junkie mouse with a dream to see Cats play on Broadway - th [19:53:40] is summer, this mouse will finally have to decide whether to die in battle or quietly run away and probably not come back for a while - Moriel Schottlender, Antonio Banderas - Mouse Trap" [19:54:08] (03CR) 10Catrope: [C: 032] build: Update jscs config and phase out deprecated jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/129869 (owner: 10Krinkle) [19:54:31] (03Abandoned) 10Jforrester: Update OOjs UI to v0.1.0-pre (32fef8b5ee) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130146 (owner: 10Jforrester) [19:54:35] I'd totally be willing to live happily with it if it was portrayed by Antonio Banderas. [19:55:11] well, he only did the voice acting, it's a cartoon... [19:55:21] but they modeled the mouse after him a bit [19:55:24] if that helps [19:55:34] (03Merged) 10jenkins-bot: Add ActionDialog and NodeDialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129334 (owner: 10Trevor Parscal) [19:55:36] (03Merged) 10jenkins-bot: build: Update jscs config and phase out deprecated jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/129869 (owner: 10Krinkle) [19:55:52] I'll take that. [19:56:38] (03PS4) 10Jforrester: Update OOjs UI to v0.1.0-pre (b91660e612) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129494 [19:56:40] Not sure if the mouse will, but he lost his vote when he ate through my *sealed* box of Bananitas. [19:56:51] TrevorParscal: I can haz CR? https://gerrit.wikimedia.org/r/#/c/129830/ [19:57:02] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/129494/ and https://gerrit.wikimedia.org/r/#/c/129621/ [19:57:57] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (b91660e612) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129494 (owner: 10Jforrester) [19:59:51] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (b91660e612) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129494 (owner: 10Jforrester) [20:00:54] (03PS1) 10Jforrester: Update VE core submodule to master (b7e791a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130150 [20:08:24] TrevorParscal, how worried should I be with rebase-of-death of the dialog? [20:09:02] It should mainly affect the initialize method, no? [20:13:57] mooeypoo: It's pretty simple, and TrevorParscal can do it for you. :-) [20:14:10] mooeypoo: Unfortunately right now he's at lunch, despite what his IRC says. [20:15:00] (03CR) 10Krinkle: Add a wiki-file-name type for file names (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) (owner: 10Jforrester) [20:15:03] (03CR) 10Krinkle: [C: 04-1] Add a wiki-file-name type for file names [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) (owner: 10Jforrester) [20:15:18] James_F, oh, ok, I was worried after what he said in the hangout [20:15:20] rebase of doom [20:15:56] James_F, also we need to have a chat about image behavior now that the model allows for inline/block switches [20:16:06] especially so we can actually let our users switch from one to the other :D [20:16:33] mooeypoo: Ha. :-) [20:16:37] mooeypoo: Yeah, true. [20:16:50] The main issue is block->inline [20:17:17] inline->block is easy.. just make the image a thumb or something.. but the inline one is tricky because of the evilness of wikitext. [20:18:43] The problem is that you don't know what to do with attributes that aren't valid any more? [20:18:47] Or something else? [20:18:50] James_F, trying to find the right combination of buttons in the media editor to make an image inline makes me feel like i'm in an Indiana Jones movie and the ceiling is about to close in. [20:18:58] (What to do == what the user will expect it to do.) [20:19:01] Ha. [20:19:29] well, there are a couple of problems. First, inline images have no left/right/center/none position -- and we don't have a way to remove them (unmarking the checkbox is removing *float* which is marking the image with "none") [20:20:00] So.. we should add 'valign' stuff, and then we need to figure out how we make it so the user tells us clearly if they want the valign *OR* the align options [20:21:07] Second problem is a bit more abstract, I think.. We should probably tell the user which field is going to "count" and which isn't. So, if we're in inline image, caption is moot.. but since we keep changing the image attributes we can't just disable the caption.. that's confusing.. [20:21:24] maybe have some indication that it won't be applied if it's inline or something. [20:21:36] anyways, we should consider a workable UX [20:22:03] (03CR) 10Jforrester: Add a wiki-file-name type for file names (032 comments) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) (owner: 10Jforrester) [20:22:11] (03PS6) 10Jforrester: Add a wiki-file-name type for file names [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) [20:23:17] mooeypoo: So I guess we'd want to grey out the position (left/right/centre/none) section, yes? [20:23:52] mooeypoo: I don't think alignment (valign) is a high priority; it'll confuse people far more than it will help. [20:24:23] sure, but until we have it, there's no way to make inline images [20:24:31] From blocks, I mean. [20:24:36] and.. well.. in general in VE. [20:24:41] … there isn't? [20:24:51] well... inserting an image is inserting a block [20:25:08] and the model can't change the block to inline because of the annoying attribute issue *and* the missing valign [20:25:09] User controls to change a setting aren't the same thing as transactional ability to alter it. [20:25:11] so.. no? [20:25:18] nono there's the ability [20:25:20] Or just dump the attribute, and have a default? [20:25:20] and the will [20:25:29] sure, that's an option too [20:25:29] I understand that you have the will. :-) [20:25:44] Adding 'default' to position will help too, I guess. [20:26:05] But we moved away from it I thought, with the automatic left/right pick from direction [20:26:12] but I can cancel that and add a default option. [20:26:12] Alignment is probably used < 100 times across all the WMF wikis, and I bet ~ half of them are demonstration documentation pages. [20:26:24] hah [20:26:35] so most are using default? [20:26:38] It's amazingly rare that people would use it. [20:26:39] Yeah. [20:27:05] hm. Well, we allow for default on the technical side we just don't let the user actually choose default [20:27:07] but we can.. [20:27:28] Just set to default for alignment always, unless there's an actual value set? [20:27:56] hm. [20:28:04] Okay, so [20:28:16] what happens if I take an actually left-aligned image and I want to switch it to inline? [20:28:23] I think we should give the users the "default" button [20:30:17] hm, actually your point may have exposed a bug in my code. I *am* checking if the image is either not aligned or has default alignment .. mm. that should've worked. [20:31:55] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing Return at the end of the document throws Error: Offset could not be translated to a DOM element and offset: 675 - 10https://bugzilla.wikimedia.org/64567#c1 (10ryasmeen ) After the above steps if you click on "Save Page" dialog box and close it. Then agai... [20:35:51] (03PS6) 10Jforrester: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) [20:36:06] (03CR) 10Jforrester: [C: 031] mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [20:36:20] (03PS7) 10Jforrester: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) [20:38:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: Pull in Parsoid's new styling module so we don't need to duplicate locally - 10https://bugzilla.wikimedia.org/63983 (10James Forrester) 5PAT>3RES/FIX [20:43:09] 3VisualEditor / 3Editing Tools: VisualEditor: Edited formulae display as raw LaTeX inside VisualEditor if user has MathJax switched on - 10https://bugzilla.wikimedia.org/60728#c1 (10Richard Morris) The title change seems to have repurposed this bug. The original title VisualEditor: Math formulas don't displ... [20:57:14] (03PS5) 10Krinkle: StackLayout: Don't fire set event for null, and add unset event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [20:58:06] James_F, I found the error of my ways. Users can create inline images now \o/ [20:58:15] mooeypoo: Woohoo. :-) [20:58:28] James_F, NOW the problem is that if they do, they lose the old caption. So if they make an inline image and then want to make it a block again, the caption's empty. [20:58:29] (03CR) 10Krinkle: [C: 031] mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [20:58:36] Do you want me to save the caption for the session? [20:58:52] It will be lost on save because parsoid won't recognize it.. but maybe just for the session? [20:59:02] mooeypoo: No, just dump it. [20:59:10] Wait, are you sure Parsoid will dump it? [20:59:10] oki doki [20:59:20] Parsoid, as far as I understand, looks for
[20:59:24] 'Cos [[File:Foo.jpg|Bar]] is a caption, but used as alt text. [20:59:35] and there is no figcaption in an inline inline image. [20:59:42] Indeed. [20:59:49] OK, works for me. [21:00:11] BTW, am working on moving MWBlockImageNode.css and ViewPageTarget-shared.css to Parsoid. [21:00:18] Maybe there's a way to add the caption to some preservable data for parsoid, not sure. gwicke might know..? [21:00:25] So far it's looking promising, but I'm confused as to why some is shared and some isn't. [21:00:46] James_F, there seem to be some errors that I can't manage to figure out that ed reported on the change [21:00:53] * James_F nods. [21:01:09] I can't manage to understand why it breaks for him, but I didn't have a lot of time to debug it properly with the model work [21:01:28] but the separation in general should be basic presentation vs template design [21:01:42] parsoid should probably have both [21:02:09] Sure. [21:02:21] Will root out and destroy all CSS, then. :-) [21:03:40] James_F, https://gerrit.wikimedia.org/r/#/c/115533/ [21:03:56] the separation in the css files should be logical, unless I missed something. [21:05:04] What's the reasoning for the stuff in MWBlockImageNode.css? [21:05:15] Isn't it all MW-specific "shared" CSS? [21:05:32] (Should it either all be in MWBlockImageNode.css or all in ViewPageTarget-shared.css?) [21:06:14] I guess the .magnify div? [21:12:15] James_F, As I understood it, the MWBlockImageNode should be about basic non-template-dependent styling, and the ViewPageTagrget-shared.css is for template-specific [21:13:12] mooeypoo: … why? [21:13:34] That's what I was told by Trevor? [21:13:50] I asked what should go where, and he explained that the base stuff is for MWBlockImageNode.css [21:14:20] and the template-specific is in the ViewPageTarget.. css. It makes sense, though. That way we can change template design without touching the basics [21:15:43] meh, something went poopoo with the size widget initialization. [21:24:42] 3VisualEditor: Table with mismatch tags behaves as if the table-closing wikitext is missing - 10https://bugzilla.wikimedia.org/64571 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Open https://en.wikipedia.org/wiki/List_of_30_Rock_characters or another page conta... [21:28:30] (03PS7) 10Jforrester: Remove media item styling moved to Parsoid in I4c0d7c98 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [21:28:55] (03CR) 10jenkins-bot: [V: 04-1] Remove media item styling moved to Parsoid in I4c0d7c98 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [21:29:51] (03PS8) 10Jforrester: Remove media item styling moved to Parsoid in I4c0d7c98 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [21:32:29] James_F, why was the attributeChange event removed from MWBlockImageNode? or is that just a result of rebasing? [21:35:25] 3VisualEditor / 3Editing Tools: VisualEditor: Inspectors break up or appear in the wrong place after coming back from another window - 10https://bugzilla.wikimedia.org/56801#c12 (10James Forrester) 5ASS>3RES/WOR This appears to now be fixed FWICS; closing as such. [21:35:43] mooeypoo: Just a rebase? [21:35:55] mooeypoo: I didn't touch the *.js files. [21:36:21] mooeypoo: My changes: https://gerrit.wikimedia.org/r/#/c/115533/6..7/modules/ve-mw/ce/styles/ve.ce.MWBlockImageNode.css https://gerrit.wikimedia.org/r/#/c/115533/6..7/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-shared.css [21:36:27] mooeypoo: They probably don't work. ;-) [21:41:16] I just incidentally saw that line disappear between ps6 and 7, I assume it's just a rebase not presenting it anymore [21:41:32] somewhere in my model i'm invalidating custom size of the media widget [21:41:43] gah [21:45:43] 3VisualEditor / 3Editing Tools: VisualEditor: Math formula does not display correctly if preferences are set to both TeX and MathJax - 10https://bugzilla.wikimedia.org/64572 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Enable VisualEditor formulae editing at Special:Prefe... [21:47:55] 3VisualEditor / 3Editing Tools: VisualEditor: Math formula does not display correctly if preferences are set to both TeX and MathJax - 10https://bugzilla.wikimedia.org/64572#c1 (10WhatamIdoing) See https://en.wikipedia.org/w/index.php?oldid=606239634#Problem_with_MathJax_and_visual_editor. for an analysis o... [22:16:10] 3VisualEditor / 3MediaWiki integration: VisualEditor: If a link that doesn't have a pipe is changed, the link target remains - 10https://bugzilla.wikimedia.org/57506 (10WhatamIdoing) [22:16:10] 3VisualEditor / 3Editing Tools: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - 10https://bugzilla.wikimedia.org/54947 (10WhatamIdoing) [22:19:49] (03CR) 10Alex Monk: Fix tab selection on monobook (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130085 (https://bugzilla.wikimedia.org/49407) (owner: 10Alex Monk) [22:28:10] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10WhatamIdoing) [22:28:24] 3VisualEditor / 3Mobile: VisualEditor: Mobile Google Chrome text cursor hides link object icon - 10https://bugzilla.wikimedia.org/51270 (10WhatamIdoing) [22:28:25] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should have bottom margin to avoid UX ambiguity - 10https://bugzilla.wikimedia.org/52436 (10WhatamIdoing) [22:28:25] 3VisualEditor / 3Editing Tools: VisualEditor: A link can span whitespace but won't be displayed so cannot be edited or noticed - 10https://bugzilla.wikimedia.org/37835 (10WhatamIdoing) [22:28:27] 3VisualEditor / 3Editing Tools: VisualEditor: No way to identify destination, rather than link text, of links - 10https://bugzilla.wikimedia.org/49928 (10WhatamIdoing) [22:28:28] 3VisualEditor / 3ContentEditable: VisualEditor: Caption of a thumb image starting with a link means link inspector icon appears in slug, confusingly - 10https://bugzilla.wikimedia.org/49680 (10WhatamIdoing) [22:28:30] 3VisualEditor / 3Editing Tools: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - 10https://bugzilla.wikimedia.org/54947 (10WhatamIdoing) [22:28:31] 3VisualEditor / 3Data Model: VisualEditor: Editing a link in a reference leaves both the old and new link in DM, but not in CE surface - 10https://bugzilla.wikimedia.org/52127 (10WhatamIdoing) [22:28:33] 3VisualEditor / 3Editing Tools: VisualEditor: Link tooltip is not updated if link inspector is not explicitly closed - 10https://bugzilla.wikimedia.org/54984 (10WhatamIdoing) [22:28:39] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector does not show suggestions dropdown on open if link target is the same as the target of the most recently inspected link - 10https://bugzilla.wikimedia.org/55839 (10WhatamIdoing) [22:28:39] 3VisualEditor / 3ContentEditable: Link dialog doesn't find pages in the same content namespace - 10https://bugzilla.wikimedia.org/55390 (10WhatamIdoing) [22:28:40] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector suggestions sometimes aren't displayed - 10https://bugzilla.wikimedia.org/55465 (10WhatamIdoing) [22:28:42] 3VisualEditor / 3Editing Tools: VisualEditor: Wrong link rendered in edit mode when you click link in drop-down - 10https://bugzilla.wikimedia.org/55724 (10WhatamIdoing) [22:28:43] 3VisualEditor / 3ContentEditable: VisualEditor:The cursor position for newly inserted link should be at the end of the link that is being created - 10https://bugzilla.wikimedia.org/56429 (10WhatamIdoing) [22:28:54] 3VisualEditor / 3ContentEditable: VisualEditor: The link inspector and the language selector opens up outside the editor while selecting a text outside the editor - 10https://bugzilla.wikimedia.org/56747 (10WhatamIdoing) [22:28:56] 3VisualEditor / 3ContentEditable: VisualEditor: wiki markup for link shows up if a template is selected with another text and applied link onto them together - 10https://bugzilla.wikimedia.org/56749 (10WhatamIdoing) [22:28:56] 3VisualEditor / 3Editing Tools: VisualEditor: link inspector appears next to page title, pointing to what is an uneditable area of the page - 10https://bugzilla.wikimedia.org/58528 (10WhatamIdoing) [22:29:11] 3VisualEditor / 3Editing Tools: VisualEditor: Apply styles for redirects/disambiguation links in suggestions in link inspector - 10https://bugzilla.wikimedia.org/61072 (10WhatamIdoing) [22:29:11] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector is appearing broken or towards the end of the page while applying link by selecting a whole link - 10https://bugzilla.wikimedia.org/61069 (10WhatamIdoing) [22:29:24] 3VisualEditor / 3ContentEditable: On clicking a link, show 2 sliders (left/right of the current link) to handle what is In what is Out - 10https://bugzilla.wikimedia.org/63603 (10WhatamIdoing) [22:42:36] (03PS7) 10Trevor Parscal: Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 [22:43:40] (03CR) 10jenkins-bot: [V: 04-1] Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [22:50:08] (03PS8) 10Trevor Parscal: Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 [22:51:41] Guys, what is Apex and Agora? They're stylesheets in oojs-ui. [22:51:57] Are they mapping to certain experimental MW skins? [22:55:28] ish [22:55:50] effectively, apex = desktop, agora = mobile [22:56:08] okay, then i guess we're doing it right [22:56:17] if you are working on stuff, use apex, ignore Agora [22:56:26] pfft, why would I be working? [22:56:33] don't even bother adding styles for new widgets in Agora [22:56:47] Nah, I'm not, just noticing selector paths that I need to mirror in our overriding styles. [22:58:09] I'm speaking generally, ultimately your crew of outsourced engineers will need to heed this advice while you relax and get buzzed on craft beer, listening to bootleg live recordings of obscure early metal bands [23:00:55] 3VisualEditor / 3ContentEditable: VisualEditor: Provide a way (other than selection) to extend link (and other) annotations to more of the content - 10https://bugzilla.wikimedia.org/63603#c1 (10James Forrester) 5UNC>3ASS p:5Unprio>3Lowest s:5normal>3enhanc These feels very confusing as a use para... [23:01:05] TrevorParscal: You forgot to mention that he'd be sitting the seat that literally has his name on it at the bar down the street from his house [23:01:09] *sitting in the seat [23:01:28] (03PS2) 10Trevor Parscal: Add info icon and alert indicator [oojs/ui] - 10https://gerrit.wikimedia.org/r/129854 [23:06:40] (03CR) 10Jforrester: [C: 032] Add info icon and alert indicator [oojs/ui] - 10https://gerrit.wikimedia.org/r/129854 (owner: 10Trevor Parscal) [23:07:06] (03Merged) 10jenkins-bot: Add info icon and alert indicator [oojs/ui] - 10https://gerrit.wikimedia.org/r/129854 (owner: 10Trevor Parscal) [23:09:55] 3VisualEditor / 3ContentEditable: VisualEditor: The link inspector and the language selector opens up outside the editor while selecting a text outside the editor - 10https://bugzilla.wikimedia.org/56747#c3 (10James Forrester) 5ASS>3RES/FIX a:3Ed Sanders Fixed by Ed's null selection change. [23:11:54] 3VisualEditor / 3Editing Tools: VisualEditor: Link input widget sometimes picks wrong link target - 10https://bugzilla.wikimedia.org/62492 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3major [23:13:54] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector icon remains enabled in the toolbar even after closing the link inspector - 10https://bugzilla.wikimedia.org/62941#c1 (10James Forrester) 5NEW>3RES/INV This isn't a bug; the "active" state is intentional. [23:14:34] (03PS1) 10Trevor Parscal: Improve info and alert icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/130243 [23:14:42] (03PS1) 10Esanders: Add a 'ready' event to the window open sequence [oojs/ui] - 10https://gerrit.wikimedia.org/r/130244 [23:15:09] (03CR) 10Trevor Parscal: [C: 032] Add a 'ready' event to the window open sequence [oojs/ui] - 10https://gerrit.wikimedia.org/r/130244 (owner: 10Esanders) [23:15:35] (03Merged) 10jenkins-bot: Add a 'ready' event to the window open sequence [oojs/ui] - 10https://gerrit.wikimedia.org/r/130244 (owner: 10Esanders) [23:25:10] 3VisualEditor / 3Editing Tools: VisualEditor: The link suggestor should suggest links from the current namespace ahead of named links - 10https://bugzilla.wikimedia.org/55390 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low s:5normal>3enhanc [23:34:24] (03PS1) 10Esanders: Remove useless overrides in HieroInpsector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130250 [23:35:54] (03PS1) 10Esanders: Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 [23:38:54] (03CR) 10Esanders: [C: 04-1] "hold off for now" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [23:41:56] (03PS1) 10Esanders: Defer window 'ready' event to let rendering happen [oojs/ui] - 10https://gerrit.wikimedia.org/r/130254 [23:44:31] (03CR) 10jenkins-bot: [V: 04-1] Defer window 'ready' event to let rendering happen [oojs/ui] - 10https://gerrit.wikimedia.org/r/130254 (owner: 10Esanders) [23:45:06] (03PS2) 10Esanders: Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 [23:45:17] (03CR) 10Esanders: "Ready for review" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [23:47:48] RoanKattouw: http://www.mirror.co.uk/tv/tv-news/friday-night-dinner-made-woman-121129 [23:57:56] 3VisualEditor / 3Mobile: VE mobile - Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None When I select text and add a link, text should remain selected after I leave link dialogue, so I know where I ju...