[00:02:04] (03CR) 10Jforrester: [C: 032] Remove useless overrides in HieroInpsector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130250 (owner: 10Esanders) [00:04:01] (03Merged) 10jenkins-bot: Remove useless overrides in HieroInpsector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130250 (owner: 10Esanders) [00:04:39] 3VisualEditor / 3Mobile: VE mobile - Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [00:16:23] (03PS9) 10Trevor Parscal: Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 [00:22:52] (03PS1) 10Esanders: Always fix up selection on after ce.Surface#focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130262 (https://bugzilla.wikimedia.org/64399) [00:25:26] (03CR) 10Esanders: [C: 032] Improve info and alert icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/130243 (owner: 10Trevor Parscal) [00:25:47] (03PS2) 10Esanders: Always fix up selection after ce.Surface#focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130262 (https://bugzilla.wikimedia.org/64399) [00:26:11] (03Merged) 10jenkins-bot: Improve info and alert icons/indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/130243 (owner: 10Trevor Parscal) [00:26:48] (03PS2) 10Esanders: Defer window 'ready' event to let rendering happen [oojs/ui] - 10https://gerrit.wikimedia.org/r/130254 [00:29:14] (03CR) 10Catrope: [C: 032] Always fix up selection after ce.Surface#focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130262 (https://bugzilla.wikimedia.org/64399) (owner: 10Esanders) [00:30:57] (03Merged) 10jenkins-bot: Always fix up selection after ce.Surface#focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130262 (https://bugzilla.wikimedia.org/64399) (owner: 10Esanders) [00:31:23] (03PS3) 10Esanders: Defer window 'ready' event to let rendering happen [oojs/ui] - 10https://gerrit.wikimedia.org/r/130254 [00:35:51] (03CR) 10Catrope: [C: 04-2] "Blocked until such time as the Parsoid change is actually merged" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [00:36:35] (03PS1) 10Esanders: Use window 'ready' event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130268 [00:38:28] (03PS1) 10Esanders: Remove surface blur hack now that windows take focus properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130269 [01:08:24] 3VisualEditor / 3Editing Tools: VisualEditor: link inspector appears next to page title, pointing to what is an uneditable area of the page - 10https://bugzilla.wikimedia.org/58528#c1 (10This, that and the other) 5NEW>3RES/FIX Seems to work correctly now. [02:47:24] 3VisualEditor / 3Mobile: VE mobile - Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10Andre Klapper) [05:14:56] 3VisualEditor: VisualEditor: Have redirected links in green at the edit mode - 10https://bugzilla.wikimedia.org/64584 (10reza1615) 3NEW p:3Unprio s:3normal a:3None In VisualEditor When we are at the edit mode it doesn't show redirected internal links in green. It can be as an option in top tool box or... [06:17:24] 3VisualEditor / 3Editing Tools: VisualEditor: Math formula does not display correctly if preferences are set to both TeX and MathJax - 10https://bugzilla.wikimedia.org/64572#c2 (10Richard Morris) The CSS problem is caused by this rule .ve-ce-protectedNode, .ve-ce-protectedNode * { position: relative !imp... [08:28:09] 3VisualEditor / 3ContentEditable: VisualEditor: Protected node css with * selector breaks some template layouts - 10https://bugzilla.wikimedia.org/52499 (10Derk-Jan Hartman) [11:09:19] Something recent seems to have broken my vagrant provisioned VE install :(. wmf/1.24wmf2 branch works but master doesn't as of yesterday ish. I'll try to pin down which commit it was later today. When clicking edit the progress bar just goes indefinitely and VE never loads. [11:53:41] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page content is smaller and has squished line height since MediaWiki typography change - 10https://bugzilla.wikimedia.org/64599 (10Krinkle) 3NEW p:3Unprio s:3normal a:3Krinkle Created attachment 15237 --> https://bugzilla.wikimedia.org/attachmen... [11:54:39] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599 (10Krinkle) 5NEW>3ASS p:5Unprio>3Normal [12:00:49] (03PS5) 10Krinkle: mw.ViewPageTarget: Use .mw-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [12:02:39] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599 (10Krinkle) [12:19:54] 3VisualEditor / 3Editing Tools: VisualEditor: Allow users to set/edit __DISAMBIG__ status in the page meta-data panel - 10https://bugzilla.wikimedia.org/61073#c2 (10Alex Monk) I guess we could query action=paraminfo&querymodules=querypage and look for "DisambiguationPages" in data.paraminfo.querymodules[0].p... [12:44:26] (03PS1) 10Alex Monk: Allow users to set whether a page is for Disambiguation or not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) [12:44:57] Krinkle, ^ not 100% sure about the entry I added in ResourceLoaderGetConfigVars there... [12:45:37] IIRC, simply shoving stuff in that list is discouraged [12:48:10] 3VisualEditor / 3Editing Tools: VisualEditor: Allow users to set/edit __DISAMBIG__ status in the page meta-data panel - 10https://bugzilla.wikimedia.org/61073 (10Alex Monk) a:3Alex Monk [12:51:04] Krenair: yeah, that goes out in the startup module globally [12:51:23] Aside from whether you'd use this property, this is the correct way [12:51:24] to do that [12:51:45] Conceptually, it feels like this belongs in the Disambig extension as a ve plugin, like we do with Math and Cite (or will) [12:51:58] though I don't think settings dialog lends itself for extending at the moment [12:52:28] yeah, the settings dialog doesn't quite work well for that at the moment [12:57:10] 3VisualEditor / 3MediaWiki integration: VisualEditor: Allow users to set/edit {{DISPLAYTITLE:xxx}} in the page metadata panel - 10https://bugzilla.wikimedia.org/56868 (10Alex Monk) [12:57:10] 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated on save if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341 (10Alex Monk) [13:01:27] 3VisualEditor / 3Initialisation: VisualEditor: Inserting Media fails when caret is not positioned after initialization - 10https://bugzilla.wikimedia.org/64601 (10Rainer Rillke @commons.wikimedia) 3NEW p:3Unprio s:3normal a:3None Original bug title: VisualEditor: Inserting Media fails when caret is n... [13:05:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: Override of doesn't respect DISPLAYTITLE - 10https://bugzilla.wikimedia.org/49667#c2 (10Alex Monk) I think this is about VE changing the <title> to "Editing IPod", which doesn't respect displaytitle? If so, this is consistent with core's behaviour... [14:27:03] <grrrit-wm> (03CR) 10Cmcmahon: [C: 032] [browser test] use ?veaction=edit to avoid login where feasible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130144 (owner: 10Cmcmahon) [14:28:41] <grrrit-wm> (03Merged) 10jenkins-bot: [browser test] use ?veaction=edit to avoid login where feasible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130144 (owner: 10Cmcmahon) [14:30:10] <wikibugs> 3VisualEditor: VisualEditor won't start - With correct config - 10https://bugzilla.wikimedia.org/64428#c4 (10Petter Viippola) We are getting some other strange errors if we try with chrome on a testclient. server:parsoidserver-http-curl-error: couldn't connect to host. Does this mean we have the wrong configu... [15:15:24] <wikibugs> 3OOjs: "Module oojs has failed dependencies" on Camino - 10https://bugzilla.wikimedia.org/64562#c1 (10Brion Vibber) Camino is deprecated and should not be used anymore, according to Camino's website: http://caminobrowser.org/ "After a decade-long run, Camino is no longer being developed, and we encourage all... [15:46:09] <wikibugs> 3OOjs: OOjs: The definition of .super breaks on IE8 and below - 10https://bugzilla.wikimedia.org/63303#c8 (10Krinkle) If .super were the only issue, then that could work. However that isn't the case. For one, there are a few more properties that aren't allowed in old browsers. And two, it isn't so much the p... [15:46:54] <wikibugs> 3OOjs: OOjs: Support ES3 engines (parser tree) - 10https://bugzilla.wikimedia.org/63303 (10Krinkle) [15:46:54] <wikibugs> 3OOjs: OOjs: Support ES3 engines (parser tree) - 10https://bugzilla.wikimedia.org/63303 (10Krinkle) [15:58:24] <wikibugs> 3VisualEditor / 3Mobile: VisualEditor: Safari on iPad converts numbers that resemble phone numbers to href=tel: links - 10https://bugzilla.wikimedia.org/53315#c11 (10James Forrester) p:5Normal>3Low (In reply to Elitre from comment #10) > So, James, is this what we are going to do, adding this line? Thank... [17:10:55] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Parameter descriptions in the new template dialog are too low contrast - 10https://bugzilla.wikimedia.org/62397 (10Elitre) [17:16:51] <grrrit-wm> (03CR) 10Krinkle: [C: 032] Add a wiki-file-name type for file names [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) (owner: 10Jforrester) [17:17:16] <grrrit-wm> (03Merged) 10jenkins-bot: Add a wiki-file-name type for file names [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/129591 (https://bugzilla.wikimedia.org/52652) (owner: 10Jforrester) [17:21:30] <James_F> Krinkle: Thanks! :-) [17:22:11] <wikibugs> 3MediaWiki extensions / 3TemplateData: TemplateData: Add type support for an extant file (on local or remote repo) - 10https://bugzilla.wikimedia.org/52652 (10James Forrester) 5PAT>3RES/FIX [17:26:54] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Add an edit notice for users of slower computers advising them to use source mode - 10https://bugzilla.wikimedia.org/50518#c1 (10Alex Monk) So we already have the beta welcome dialog, I think we should add something like "Users of slow computers should co... [17:31:09] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Add an edit notice for users of slower computers advising them to use source mode - 10https://bugzilla.wikimedia.org/50518#c2 (10James Forrester) The plan is to get rid of the beta welcome dialog relatively soon (in the next few months), however… [17:44:24] <Krenair> TrevorParscal, so the bug I was talking about earlier is https://bugzilla.wikimedia.org/show_bug.cgi?id=50955 [17:45:59] <Krenair> I have made a generic confirmation dialog that we could quite easily use to replace confirm(), but I'm not sure if it should go in mediawiki/extensions/VisualEditor, VisualEditor/VisualEditor or oojs/ui [17:46:54] <James_F> Krenair: For now put it in MW-VE? We can always upstream it if we find it's needed elsewhere. [17:47:36] <James_F> Krinkle: Are you going to +2 https://gerrit.wikimedia.org/r/#/c/129563/ ? [17:48:07] <Krenair> wasn't sure if it's a case of "this is quite generic so we should put it upstream" or "leave it where it is until something else wants it, then upstream" [17:49:58] * James_F nods. [17:50:24] <James_F> We veer more to the latter than the former in the team, but it can absorb an awful lot of time. [17:52:49] <grrrit-wm> (03PS1) 10Alex Monk: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) [17:54:37] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:54:39] <Krenair> I'm particularly unsure about ve.ui.ConfirmationDialog.prototype.confirm and I suspect the result will be a "WTF is this?" CR, but let's see [17:54:46] * James_F grins. [17:55:33] <grrrit-wm> (03PS2) 10Alex Monk: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) [17:57:30] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:57:41] <grrrit-wm> (03CR) 10Alex Monk: [C: 04-1] Swap from using native confirm() to using an OOUI dialog when cancelling (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:58:05] <Krenair> What just happened with Jenkins? [18:00:01] <James_F> Oh. [18:00:05] <James_F> New jsduck version. [18:00:10] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 032] Remove surface blur hack now that windows take focus properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130269 (owner: 10Esanders) [18:00:25] * James_F fixed that. [18:00:28] * James_F hunts for the fix. [18:00:30] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 032] Use window 'ready' event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130268 (owner: 10Esanders) [18:01:01] <edsanders> InezK, BladeBronson so lunch today? [18:01:13] <BladeBronson> Yessir. Where do you want to meet? [18:01:22] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 032] Defer window 'ready' event to let rendering happen [oojs/ui] - 10https://gerrit.wikimedia.org/r/130254 (owner: 10Esanders) [18:01:27] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Remove surface blur hack now that windows take focus properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130269 (owner: 10Esanders) [18:01:39] <grrrit-wm> (03Merged) 10jenkins-bot: Defer window 'ready' event to let rendering happen [oojs/ui] - 10https://gerrit.wikimedia.org/r/130254 (owner: 10Esanders) [18:01:54] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use window 'ready' event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130268 (owner: 10Esanders) [18:02:04] <edsanders> we can head up to Wikia towers before 1 [18:02:27] <BladeBronson> We have an engineering meeting at 1:30. Can you do it a bit earlier? [18:02:33] <edsanders> sure [18:02:50] <BladeBronson> So just come over anytime you're ready. [18:03:13] <James_F> Krinkle: ^^^ [18:04:44] <Krinkle> fixing [18:04:50] <James_F> Krinkle: Thanks, you're awesome. [18:05:18] <grrrit-wm> (03CR) 10Trevor Parscal: [BREAKING CHANGE] Show matched string in LanguageSearchWidget results (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129584 (owner: 10Esanders) [18:05:28] <grrrit-wm> (03CR) 10Trevor Parscal: [C: 04-1] [BREAKING CHANGE] Show matched string in LanguageSearchWidget results [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129584 (owner: 10Esanders) [18:07:18] <InezK> edsanders: Absolutely! I have a meeting running till ~11:50.. anytime after that is fine. [18:07:36] <edsanders> cool [18:08:21] <edsanders> you guys can show me your personal executive offices which you have now, right? [18:08:42] <grrrit-wm> (03PS1) 10Krinkle: docs: Remove "--meta-tags" option from jsduck config.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 [18:09:54] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] docs: Remove "--meta-tags" option from jsduck config.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 (owner: 10Krinkle) [18:11:57] <grrrit-wm> (03PS2) 10Krinkle: docs: Remove JSDuck 4 options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 [18:15:10] <grrrit-wm> (03CR) 10Jforrester: [C: 032] docs: Remove JSDuck 4 options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 (owner: 10Krinkle) [18:16:17] <grrrit-wm> (03PS3) 10Krinkle: docs: Remove JSDuck 4 options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 [18:16:36] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Good catch. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 (owner: 10Krinkle) [18:16:49] <James_F> Krinkle: Whoops. [18:16:56] <grrrit-wm> (03PS1) 10Trevor Parscal: Add focus method to SearchWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/130402 [18:17:01] <grrrit-wm> (03PS4) 10Krinkle: docs: Remove JSDuck 4 options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 [18:17:30] <Krinkle> Wait, this doesn't make sense [18:17:35] <Krinkle> the names are messed up [18:17:44] <grrrit-wm> (03CR) 10Esanders: [C: 032] Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [18:17:50] <James_F> Krinkle: ? [18:18:15] <grrrit-wm> (03PS5) 10Krinkle: docs: Remove JSDuck 4 options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 [18:18:18] <Krinkle> The file lies [18:18:27] <Krinkle> "This is for jsduck 4" [18:18:30] <Krinkle> that's 5 [18:18:30] <James_F> Ooooh. [18:18:33] <Krinkle> the other is for 4 [18:18:34] <James_F> This is why it didn't work? [18:18:42] <Krinkle> Maybe [18:18:42] <James_F> My fault, I assume. [18:19:12] <grrrit-wm> (03CR) 10Jforrester: [C: 032] docs: Remove JSDuck 4 options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 (owner: 10Krinkle) [18:19:16] <grrrit-wm> (03CR) 10Esanders: [C: 032] "TODO: see if any other widgets need these" [oojs/ui] - 10https://gerrit.wikimedia.org/r/130402 (owner: 10Trevor Parscal) [18:19:53] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [18:20:29] <grrrit-wm> (03PS1) 10Trevor Parscal: Use SearchWidget focus method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130404 [18:20:33] <grrrit-wm> (03Merged) 10jenkins-bot: Add focus method to SearchWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/130402 (owner: 10Trevor Parscal) [18:21:01] <grrrit-wm> (03PS1) 10Krinkle: docs: Remove JSDuck 4 support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130406 [18:21:38] <grrrit-wm> (03Merged) 10jenkins-bot: docs: Remove JSDuck 4 options [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130400 (owner: 10Krinkle) [18:21:46] <grrrit-wm> (03CR) 10Jforrester: [C: 032] docs: Remove JSDuck 4 support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130406 (owner: 10Krinkle) [18:21:55] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use SearchWidget focus method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130404 (owner: 10Trevor Parscal) [18:24:10] <grrrit-wm> (03Merged) 10jenkins-bot: docs: Remove JSDuck 4 support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130406 (owner: 10Krinkle) [18:26:11] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Per Trevor." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130268 (owner: 10Esanders) [18:26:17] <Krinkle> RoanKattouw_away: James_F: Today on national news on the primary broadcasting network, "Be careful with Internet Explorer, maybe don't use it and use another browser" [18:26:24] <Krinkle> Laughed my ass off. [18:26:25] <Krinkle> Amazing [18:26:45] <Krinkle> Someone somewhere must've done a lot of lobbying to get that non-news item to propagate [18:27:14] <Krinkle> 8pm daily news. Third item. [18:27:53] <grrrit-wm> (03Merged) 10jenkins-bot: Use window 'ready' event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130268 (owner: 10Esanders) [18:30:02] <James_F> Krinkle: It's the first critical security bug with IE6–8 since MS stopped releasing security updates for them. [18:30:19] <James_F> Krinkle: And MS confirmed that, just as they've been saying for years, they're not going to fix it. [18:30:26] <James_F> Krinkle: So it's "news". [18:39:25] <grrrit-wm> (03PS1) 10Trevor Parscal: Cleanup widget focus/select/clear methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 [18:39:45] <grrrit-wm> (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Cleanup widget focus/select/clear methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 [18:40:32] <edsanders> Practice your en_GB_LONDON_COCKEY for August TrevorParscal http://www.buzzfeed.com/elliewoodward/most-danny-dyer-tweets-of-all-time [18:40:37] <grrrit-wm> (03PS2) 10Trevor Parscal: Use SearchWidget focus method [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130404 [18:40:54] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Per Trevor." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130269 (owner: 10Esanders) [18:41:01] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [18:41:19] <grrrit-wm> (03CR) 10Esanders: [C: 031] Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [18:41:21] <grrrit-wm> (03PS1) 10Trevor Parscal: Cleanup focus/select/clear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 [18:41:42] <grrrit-wm> (03PS3) 10Trevor Parscal: Cleanup use of focus/clear/select [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130404 [18:42:18] <grrrit-wm> (03PS10) 10Jforrester: Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [18:43:54] <Krinkle> Hm.. Unfortunate title casing [18:43:55] <Krinkle> Wikisource:WSexport [18:44:02] <Krinkle> Clearly, that's W Sexport [18:44:10] <Krinkle> Or it'd be WS Export [18:44:18] <grrrit-wm> (03Merged) 10jenkins-bot: Remove surface blur hack now that windows take focus properly [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130269 (owner: 10Esanders) [18:44:26] <grrrit-wm> (03PS4) 10Esanders: [BREAKING CHANGE] Show matched string in LangaugeSearchWidget results [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129584 [18:45:03] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Cleanup focus/select/clear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [18:47:02] <grrrit-wm> (03PS3) 10Alex Monk: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) [18:48:02] <James_F> Krinkle|detached: Oh dear. [18:50:59] <BladeBronson> The Pen is Mightier [18:52:08] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [18:58:58] <grrrit-wm> (03PS1) 10Trevor Parscal: Use promises instead of callback in OO.ui.OptionWidget flash method [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 [19:03:55] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: Phantoms are appearing at wrong place while selecting an image after making it fullsize - 10https://bugzilla.wikimedia.org/62284#c4 (10ryasmeen ) This also happens when I change the image position from Left to Center [19:11:11] <InezK> edsanders: hungryyyyy! :) [19:11:16] <grrrit-wm> (03PS3) 10Esanders: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 [19:11:17] <grrrit-wm> (03PS2) 10Esanders: Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 [19:12:31] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [19:12:33] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [19:13:26] <grrrit-wm> (03CR) 10Inez: "It's a lunchtime now!" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [19:13:52] <James_F> InezK: Coming. :-) [19:14:14] <edsanders> okok [19:35:32] <Krinkle> James_F|Away: what up? [19:38:59] <grrrit-wm> (03CR) 10Krinkle: "Noted weird behaviour, not new in this commit." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 (owner: 10Trevor Parscal) [19:39:55] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Page save time at 75th percentile up 70% from February - 10https://bugzilla.wikimedia.org/64171#c6 (10Ori Livneh) (In reply to Gabriel Wicke from comment #5) > Note that the request timings are readily available in the VE extension. The > internal Parsoid... [19:41:34] <grrrit-wm> (03CR) 10Krinkle: [C: 04-1] "This is a breaking change in the interface. Should be noted as such. It's not just about what we use (consuming code), but also what is pr" [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 (owner: 10Trevor Parscal) [19:51:50] <James_F> Krinkle: ? [19:58:10] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334 (10James Forrester... [20:08:02] <Krinkle> James_F: James_F: [2014-04-29 18:46:45 +00:00] Krinkle|detached: Oh dear. [20:08:39] <James_F> Krinkle: Oh, I was responding to your finding of Wikisource:WSexport. [20:08:50] <Krinkle> ah, ok [20:09:59] <James_F> Krinkle: You agree with TheDJ on https://gerrit.wikimedia.org/r/#/c/129563/ (s/mw-content/mw-body-content/g) [20:10:03] <James_F> ? [20:10:37] <Krinkle> Yep [20:10:44] <Krinkle> I proposed that name, wanted a +1 from thedj [20:10:46] <Krinkle> which I have now [20:11:00] <Krinkle> I actually have a commit that does mw-body-content and wrote it before I found Trevor's commit [20:11:04] <Krinkle> but never pushed [20:11:42] <James_F> If you push your new PS I can +1/2? [20:11:53] <James_F> Or I can do the new name and you +2? [20:12:25] <James_F> (I really want this out the door today if possible.) [20:20:37] <Krinkle> James_F: I'm adapting the ve commit now but it's not looking as it should be [20:20:53] <Krinkle> text is twice as large as it should be [20:20:57] <James_F> Oh dear. [20:29:52] <Krinkle> James_F: Is Trevor reachable? [20:30:17] <Krinkle> I find that removing a certain rule fixes it, but I'm not quite sure whether this is some obscure reason for it [20:35:43] <James_F> Krinkle: He's out to lunch still. [20:36:12] <Krinkle> Can you reproduce the behaviour that the left edge of the page content jiggles a bit to the right when activating the editor? [20:36:23] <Krinkle> The left margin is bigger in edit mode than in read mode [20:36:28] <Krinkle> Right? [20:36:34] <James_F> Hmm. Maybe my calculation was wrong? [20:37:13] <mooeypoo> heya guys [20:37:28] <James_F> Krinkle: https://gerrit.wikimedia.org/r/#/c/129567/1..4/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-vector.css might be wrong? [20:37:44] <James_F> Krinkle: As in it wasn't meant to be @content-line-height / @content-font-size in the first place and it just happened to work? [20:37:47] <James_F> Hey mooeypoo. [20:37:52] <James_F> You had fun? [20:38:01] <mooeypoo> it was lovely [20:38:10] <mooeypoo> I have lots of forms, too, to top everything off. [20:38:17] <mooeypoo> And that's always lovely. [20:38:25] * James_F grins. [20:38:28] <James_F> More forms! [20:38:28] <James_F> Yay. [20:38:30] <Krinkle> James_F: yeah, I don't think it relates to line height and font-size [20:38:38] <Krinkle> it seems redundant though [20:38:39] <mooeypoo> :D [20:38:41] <Krinkle> it's a pointless game [20:38:44] <James_F> Trevor claimed it did and I believed him. [20:38:59] <Krinkle> Why add padding on surface and then undo that padding with negative margin on the documentNode [20:39:19] <James_F> I pinged him to come back. [20:39:26] <Krinkle> In Vector, we have #content which has padding (so that the text isnt' against the blue border) [20:39:42] <Krinkle> #bodyContent in Vector has no margin or padding, it jsut flows in naturally, so that's what it does in read mode [20:39:52] * James_F nods. [20:40:11] <Krinkle> then in VE edit mode, we add extra padding for no reason, and to counter act that padding, we have negative padding (margin) on the inner child so it goes back to where it should be [20:40:18] <Krinkle> I'm just removing both and will let Trevor review [20:40:25] <James_F> OK. [20:41:25] <James_F> Krinkle: OK for me to +2 https://gerrit.wikimedia.org/r/#/c/129563/ then? [20:42:37] <grrrit-wm> (03PS6) 10Krinkle: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [20:43:24] <Krinkle> James_F: already done. Got thedj and edokter +1, and Trevor's original commit intend. Good enough. [20:43:39] <James_F> Krinkle: Excellent. [20:43:45] <Krinkle> we'll need to bump our mw dependency [20:43:51] <James_F> Amongst other things. [20:43:53] <Krinkle> wfUseMw thingy [20:44:00] <James_F> Yeah, it's in VisualEditor.php. [20:44:02] * James_F will fix. [20:44:20] <Krinkle> will you add to I66c56c577bad06 ? [20:44:28] <Krinkle> eh, not that one [20:44:34] <Krinkle> I5818dce626545c4cbc8bd [20:44:36] <James_F> I5818dce62 [20:44:40] <James_F> Yes, doing so now. [20:46:08] <grrrit-wm> (03PS7) 10Jforrester: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [20:47:06] <James_F> Eurgh, the core change doesn't nicely cherry-pick to wmf1. [20:47:12] <James_F> Let's just do it for wmf2 then. [20:51:47] <TrevorParscal> Krinkle: so, I think you missed something here: https://gerrit.wikimedia.org/r/#/c/129567/ [20:52:04] <Krinkle> TrevorParscal: I'm counting on it [20:52:05] <TrevorParscal> with your modification, you can no longer click to the left of the text to place the cursor [20:52:07] <Krinkle> TrevorParscal: Tell me [20:52:27] <Krinkle> Right [20:52:42] <Krinkle> You can't click into parent padding [20:52:51] <TrevorParscal> the margin/padding trick was deliberately designed to increase the clickable area around the ve-ce-documentNode that could be clicked to place the cursor [20:53:00] <Krinkle> Yeah, makes perfect sense. [20:53:10] <Krinkle> Could use documenting though :) [20:53:24] <TrevorParscal> yeah, so I realize now that it was undocumented and that's my fault because it's a unique trick and I understand why it looked like a double negative [20:53:40] <Krinkle> TrevorParscal: It wasn't workign properly though, the values were off [20:53:58] <Krinkle> causing it to not just create more invisible click space, but actually nudge it over by a few tenth ems [20:54:04] <TrevorParscal> right, so it needs to be fixed then, but we should try and retain the clickable area expansion feature [20:54:15] <Krinkle> yeah, for sure [20:54:35] <Krinkle> TrevorParscal: Does it need to be on both sides? [20:54:40] <Krinkle> or just sidebar side [20:55:24] <TrevorParscal> Well, since we support mixed RTL/LTR it needs to be both I think [20:55:35] <Krinkle> that's taken care of by flipping [20:55:46] <Krinkle> the "gap" is only on the sidebar side to put cursor on start of the line [20:55:51] <TrevorParscal> no no, I'm saying you can have RTL content in an LTR UI [20:56:05] <Krinkle> Right [20:56:07] <TrevorParscal> there's also a gap between the content and the right edge [20:56:13] <Krinkle> yeah [20:56:14] <James_F> Yay complexity. [20:56:22] <James_F> This sounds like it should be documented, right? [20:56:25] * James_F coughs. [20:58:53] <James_F> TrevorParscal: Could you quickly document this so Krinkle can merge it and we can deploy this afternoon? [20:59:04] <Krinkle> James_F: No, I'm doing that. [20:59:09] <James_F> OK, that works. [20:59:13] <Krinkle> also fixing the values [20:59:14] <TrevorParscal> thanks Krinkle [20:59:17] <Krinkle> since I alreayd did that ealier today [20:59:24] <James_F> Krinkle: You're wonderful as always. [20:59:30] <Krinkle> but abandonded it lcoally since Trevor alreayd had a patch [20:59:54] <James_F> Krinkle: BTW, https://gerrit.wikimedia.org/r/#/c/129563/ (the change in MW-core) really should be REL1_23 back-ported. :-( [21:00:20] <James_F> Krinkle: It's LTS; we /really/ don't want to have to deal with the broken MW skin styling for another two years in a special branch of VE… [21:01:04] <grrrit-wm> (03PS8) 10Krinkle: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [21:01:30] <James_F> Krinkle: Bah, you over-wrote my wfUseMw change. [21:01:36] <Krinkle> right [21:02:10] <Krinkle> Gerrit requires force-pushing / amending by design, no way to tell. [21:02:20] * James_F nods. [21:02:48] <grrrit-wm> (03PS9) 10Krinkle: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [21:03:21] <grrrit-wm> (03PS10) 10Krinkle: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [21:03:34] <James_F> Thanks Timo. [21:03:54] <grrrit-wm> (03CR) 10Jforrester: [C: 031] mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [21:04:07] <grrrit-wm> (03PS11) 10Krinkle: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [21:04:25] <grrrit-wm> (03CR) 10Krinkle: "Sync commit message with actual commit." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [21:04:32] <Krinkle> TrevorParscal: sanity check? [21:04:36] <grrrit-wm> (03PS1) 10Trevor Parscal: Allow citation tools to be shown "instead of" reference tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130486 [21:04:49] <Krinkle> (patch set 11) [21:05:27] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Allow citation tools to be shown "instead of" reference tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130486 (owner: 10Trevor Parscal) [21:06:16] <grrrit-wm> (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (7705a94df5) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130487 [21:07:46] <James_F> TrevorParscal: https://gerrit.wikimedia.org/r/130488 and https://gerrit.wikimedia.org/r/130487 would be nice pull-throughs. [21:07:46] <Krinkle> James_F: Hm.. did we get rid of the opening animation of the toolbar? Or did it never exist? [21:07:56] <Krinkle> When you close the editor, the toolbar slides up smoothly [21:08:08] <Krinkle> but when you open it, it just barges in out of nothing [21:08:21] <grrrit-wm> (03Merged) 10jenkins-bot: Allow citation tools to be shown "instead of" reference tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130486 (owner: 10Trevor Parscal) [21:08:21] <Krinkle> flickring a bit in the process [21:09:13] <grrrit-wm> (03PS4) 10Esanders: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 [21:11:35] <Krinkle> nice domain name [21:11:36] <Krinkle> new.wikipedia.org [21:11:46] <Krinkle> nostalgia.wikipedia.org [21:11:52] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [21:12:08] <Krinkle> no old.wiki or ol.wiki though [21:12:26] <Krinkle> we have en2.wikipedia.org though :P [21:13:22] <spagewmf> James_F: FYI in ?debug=1 mode ext.parsoid.styles results in a 404, gerrit 130489. [21:13:41] <grrrit-wm> (03CR) 10Krinkle: "21:11:16 Notice: Undefined index: visualeditor-enable-language in /srv/ssd/jenkins-slave/workspace/mwext-VisualEditor-qunit/extensions/Vis" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [21:17:40] <grrrit-wm> (03PS1) 10Krinkle: Fix PHP Notice: Undefined index visualeditor-enable-language [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130496 [21:18:32] <grrrit-wm> (03PS2) 10Krinkle: Fix PHP Notice: Undefined index visualeditor-enable-language [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130496 [21:40:41] <wikibugs> 3VisualEditor / 3Editing Tools: Math inspection trigger region in too small. - 10https://bugzilla.wikimedia.org/64625 (10Richard Morris) 3NEW p:3Unprio s:3normal a:3None Created attachment 15244 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15244&action=edit The region you need to move the m... [21:47:55] <wikibugs> 3VisualEditor / 3Editing Tools: Math in block mode is alienated as inline - 10https://bugzilla.wikimedia.org/50791 (10Derk-Jan Hartman) [21:47:56] <wikibugs> 3VisualEditor / 3Editing Tools: Math inspection trigger region in too small. - 10https://bugzilla.wikimedia.org/64625 (10Derk-Jan Hartman) [22:08:42] <Eloquence> James_F, have you seen https://bugzilla.wikimedia.org/show_bug.cgi?id=64434 [22:08:59] <James_F> Eloquence: Yeah. :-( [22:09:13] <James_F> Eloquence: It's caused by Firefox not letting us focus the cursor. [22:09:20] <James_F> (I think that report is a dupe.) [22:09:58] <Eloquence> ok - obviously pretty urgent issue :( [22:13:00] <James_F> Eloquence: Yes. [22:15:14] <grrrit-wm> (03PS4) 10Trevor Parscal: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) [22:15:28] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [22:16:47] <James_F> TrevorParscal: Does ^^^ fix 64098 ("Citation dialog does not focus correct field when adding a new parameter") too? [22:23:53] <grrrit-wm> (03CR) 10Jforrester: [C: 032] mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [22:23:59] <grrrit-wm> (03PS1) 10Jforrester: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130507 (https://bugzilla.wikimedia.org/64599) [22:25:53] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130507 (https://bugzilla.wikimedia.org/64599) (owner: 10Jforrester) [22:25:56] <grrrit-wm> (03Merged) 10jenkins-bot: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129567 (https://bugzilla.wikimedia.org/64599) (owner: 10Trevor Parscal) [22:30:54] <James_F> Krinkle: Do you think it's OK to V+2 this cherry-pick? https://gerrit.wikimedia.org/r/#/c/130507/ Or should we just backport the fix too? [22:31:58] <grrrit-wm> (03PS1) 10Krinkle: docs: Remove JSDuck 4 support [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130509 [22:32:04] <grrrit-wm> (03CR) 10Krinkle: [C: 032] docs: Remove JSDuck 4 support [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130509 (owner: 10Krinkle) [22:32:08] <James_F> Krinkle: :-D [22:32:16] <James_F> That answers that. [22:33:43] <grrrit-wm> (03Merged) 10jenkins-bot: docs: Remove JSDuck 4 support [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130509 (owner: 10Krinkle) [22:33:54] <grrrit-wm> (03PS2) 10Krinkle: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130507 (https://bugzilla.wikimedia.org/64599) (owner: 10Jforrester) [22:34:14] <Krinkle> James_F: Do we have a window? [22:37:06] <TrevorParscal> Krinkle: hey, sorry - what's up? [22:37:30] <TrevorParscal> James_F: I believe that it does, but I wasn't specifically testing for that [22:37:35] <Krinkle> TrevorParscal: wanted your eyes on https://gerrit.wikimedia.org/r/#/c/129567/ before we merge [22:37:42] <James_F> Krinkle: Yes, in SWAT. [22:38:31] <James_F> TrevorParscal: Will check. [22:39:01] <TrevorParscal> Krinkle: yeah, looks good [22:40:25] <wikibugs> 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599 (10James Forrester) 5PAT>3RES/FIX [22:43:28] <Krinkle> James_F: So we assign it to SWAT, and someone else does it? Or do you want me to? [22:43:42] <Krinkle> Do they also do the submodule update, or should we merge to wmf branch in VE extension now? [22:50:47] <grrrit-wm> (03PS1) 10Trevor Parscal: Improve alert and required indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/130517 [23:03:10] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Page save time at 75th percentile up 70% from February - 10https://bugzilla.wikimedia.org/64171#c7 (10Gabriel Wicke) As I have said earlier, the most important metric should be request timings to the Parsoid API which includes the cache layers. Parsoid it... [23:03:20] <James_F> Krinkle: Someone from the SWAT team does it – looks like ori today. [23:04:39] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Improve alert and required indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/130517 (owner: 10Trevor Parscal) [23:05:05] <James_F> Krinkle: They can do the submodule update, but if you fix it for Erik he'll be happy. [23:05:06] <grrrit-wm> (03Merged) 10jenkins-bot: Improve alert and required indicators [oojs/ui] - 10https://gerrit.wikimedia.org/r/130517 (owner: 10Trevor Parscal) [23:15:32] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599 (10James Forrester) p:5Normal>3High s:5normal>3major [23:24:21] <grrrit-wm> (03CR) 10Ori.livneh: [C: 032] mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130507 (https://bugzilla.wikimedia.org/64599) (owner: 10Jforrester) [23:26:04] <grrrit-wm> (03Merged) 10jenkins-bot: mw.ViewPageTarget: Use .mw-body-content for content styling [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130507 (https://bugzilla.wikimedia.org/64599) (owner: 10Jforrester) [23:34:00] <grrrit-wm> (03PS1) 10Trevor Parscal: Convert $status into a Message object before calling methods on it [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130524 [23:37:25] <grrrit-wm> (03CR) 10Jforrester: [C: 032] "Whoops. *blushes*" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130524 (owner: 10Trevor Parscal) [23:38:37] <grrrit-wm> (03Merged) 10jenkins-bot: Convert $status into a Message object before calling methods on it [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/130524 (owner: 10Trevor Parscal) [23:43:38] <James_F> Krinkle: Argh. Sizing now seems all wrong. [23:44:59] <Krinkle> James_F: I'm getting TypeError: Cannot read property 'getMessage' of undefined [23:45:01] <Krinkle> mediawiki.org [23:45:05] <Krinkle> ext.visualEditor.core failure [23:45:16] <Krinkle> editor won't even load after clicking Edit [23:45:21] <Krinkle> race condition [23:45:32] <Krinkle> Font looks good though for me [23:45:35] <James_F> Krinkle: Refresh and it works. [23:45:41] <James_F> Krinkle: E.g. https://www.mediawiki.org/wiki/VisualEditor?veaction=edit – open an inspector, or even worse on Beta Labs. [23:46:05] <Krinkle> yeah, that's bad [23:46:25] <Krinkle> context menu is shrinkwrapped, and suggestions are tiny [23:46:33] <Krinkle> thats relative ems [23:46:50] <James_F> rems not bems or whateveR? [23:48:45] <Krinkle> James_F: The fix for that is to move .mw-body-content from ui-surface to ce-surface (we have div#content > .ve-ui-surface > .ve-ce-surface > .-documentNode [23:49:04] * James_F nods. [23:49:08] <Krinkle> and .ve-ui-surface-overlay is sibling of .ve-ce-surface (both children of .ve-ui-surface) [23:49:27] <Krinkle> I guess we want to maintain control of our overlays and not be a child of mw-body-content [23:49:36] <Krinkle> e.g. not affected by size changes [23:49:42] <James_F> Right. [23:50:05] <Krinkle> but that only works if we remove font-size from ce-surface, which is in ve core [23:50:16] <James_F> Or over-ride? [23:50:22] <Krinkle> can't [23:50:33] <Krinkle> there is no way to override it to undo it [23:50:36] <James_F> Why does VE-core set a font size? [23:50:43] <Krinkle> needs a value, and the value we want is magic-default() [23:50:46] <James_F> Can't you set it to inherit !important? [23:50:47] <Krinkle> Indeed. [23:50:55] <Krinkle> I'm removing it from ve-core [23:50:58] <James_F> OK. :-) [23:51:02] <Krinkle> we should be fluid I suppose [23:51:07] <James_F> Yeah. [23:52:23] <Krinkle> although it is tricky. We'll probably want a fixed font-size somewhere in VE so that inspectors etc. don't also become fleuid [23:52:32] <Krinkle> we want a reset, but only for toolbar/overlays [23:52:44] <Krinkle> right now ve-core does it higher up that covers both [23:52:51] <James_F> Could we make every integration responsible for setting it? [23:52:51] <Krinkle> and as a result content as well [23:55:11] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599#c5 (10James Forrester) 5RES/FIX>3REO Still some mess here.