[00:04:22] (03PS1) 10Krinkle: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130531 [00:04:52] James_F: To clarify, right now in VE/VE-MW/ME master master master, font-size is perfect in the surface in edit mode [00:05:13] but when I make the fix in ve-mw for our overlays, that will then break the content font-size [00:05:28] Krinkle: Yes, and in iframes everything's great too. [00:05:28] which is mitigated in ve-core with https://gerrit.wikimedia.org/r/130531 [00:05:30] Krinkle: Yup. [00:06:28] Hm.. needs submodule update [00:07:04] with a change in the same commit to ensure atomicity [00:08:32] Error: Unknown dependency: ext.parsoid.styles [00:08:38] Right, need latest master of that too now [00:08:59] If this makes it into production enwiki without breakage.. [00:09:13] that'll be a miracle. So many thigns that can go wrong [00:09:15] Yeah… [00:09:18] * James_F sighs. [00:09:38] It'd have been nice if helpful people hadn't broken Vector with the TR changes three weeks ago. :-( [00:10:49] (But we should have caught it and fixed it earlier, I guess.) [00:12:26] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (70f1886a35) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130487 [00:12:51] Krinkle: Also, there's a huge amount of VE-core pull-throughs to do, including some labelled "breaking". [00:15:03] (03PS2) 10Jforrester: Update VE core submodule to master (c5b5c82) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130150 [00:15:10] Krinkle: ^^^ specifically. [00:15:44] Oh. "Marked as breaking change for the API change to updateState but shouldn't break MW.". [00:15:47] Don't mind me. :-) [00:16:45] James_F: mwcore has the same oojs ui? [00:16:57] short of that, I'd +2 [00:17:03] Krinkle: https://gerrit.wikimedia.org/r/130487 and https://gerrit.wikimedia.org/r/130534 [00:17:20] Krinkle: I meant https://gerrit.wikimedia.org/r/130150 as the VE-core -> VE-MW pull through, though. [00:17:33] (Note the shared change IDs.) [00:17:35] James_F: Im referring to the oojs ui update in the sync-repos commit you just pushed [00:17:39] Yes. [00:17:42] the one already merged [00:18:20] oojs ui update already merged, the ve submodule update pending [00:18:25] core has the same version already, yes/no [00:18:27] Yeah. [00:18:38] and it wansn't pulled through in ve yet, yikes [00:18:45] 8c6814e05abc6e06b3d7a34de78f30e355b9b87b [00:19:11] Krinkle: That's normal; we make sure VE-core and MW-core share the version of OOjs UI, but VE-MW doesn't use VE-core's OOjs UI so it doesn't matter. [00:19:58] either way, tests run for both. so it's pretty good actually [00:20:05] * James_F nods. [00:20:17] we run standalone tests now via grunt, so we have to be compat with the bundled version [00:20:26] and then ve-mw runs all tests again [00:20:32] (03CR) 10Krinkle: [C: 032] Update OOjs UI to v0.1.0-pre (70f1886a35) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130487 (owner: 10Jforrester) [00:21:37] Yeah. [00:21:42] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (70f1886a35) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130487 (owner: 10Jforrester) [00:22:20] James_F: Hm.. on saving, the entire dialog becomes a transitoning progres bar? [00:22:25] (mwSaveDialog) [00:22:30] Krinkle: Yes, this changed two weeks ago. [00:22:32] the background [00:22:39] Krinkle: I think it's a bit too strong. [00:22:44] Krinkle: We're discussing alternatives. :-) [00:22:57] it looks like someone forgot a background reset and it was supposed to be a small bar somewhere [00:22:59] OK [00:23:04] No, it's intentional. [00:23:13] But yeah, a bit jarring the first you see it. [00:23:22] (03CR) 10Krinkle: [C: 032] Update VE core submodule to master (c5b5c82) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130150 (owner: 10Jforrester) [00:24:29] (03PS2) 10Krinkle: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130531 [00:24:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (c5b5c82) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130150 (owner: 10Jforrester) [00:25:24] (03CR) 10Jforrester: [C: 032] ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130531 (owner: 10Krinkle) [00:26:33] (03Merged) 10jenkins-bot: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130531 (owner: 10Krinkle) [00:27:34] (03PS11) 10Jforrester: Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [00:28:27] (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [00:28:58] (03CR) 10Jforrester: [C: 032] Fix PHP Notice: Undefined index visualeditor-enable-language [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130496 (owner: 10Krinkle) [00:30:07] (03Merged) 10jenkins-bot: Use ActionDialog and NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129340 (owner: 10Trevor Parscal) [00:31:15] (03Merged) 10jenkins-bot: Fix PHP Notice: Undefined index visualeditor-enable-language [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130496 (owner: 10Krinkle) [00:36:25] (03PS5) 10Jforrester: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [00:36:37] (03CR) 10jenkins-bot: [V: 04-1] Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [00:36:41] (03CR) 10Jforrester: "PS5 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [00:40:18] (03PS6) 10Jforrester: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [00:40:30] (03CR) 10Jforrester: "PS6 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [00:41:33] (03CR) 10jenkins-bot: [V: 04-1] Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [00:42:01] (03PS1) 10Krinkle: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) [00:42:50] (03PS1) 10Jforrester: Update VE core submodule to 330a69e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130542 [00:43:13] (03PS1) 10GWicke: WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 [00:43:27] (03CR) 10jenkins-bot: [V: 04-1] WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [00:43:38] James_F|Away, ext.parsoid.styles - where can I find it? a new extension? [00:43:43] (03CR) 10Jforrester: "No-op pull-through to clear way for next one." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130542 (owner: 10Jforrester) [00:45:42] (03CR) 10Jforrester: [C: 032] Update VE core submodule to 330a69e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130542 (owner: 10Jforrester) [00:45:54] (03PS2) 10Krinkle: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) [00:46:14] eww.. [00:46:19] (03PS2) 10GWicke: WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 [00:47:19] (03Merged) 10jenkins-bot: Update VE core submodule to 330a69e [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130542 (owner: 10Jforrester) [00:47:44] (03PS3) 10Krinkle: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) [00:47:47] jgonera, it's in extensions/Parsoid [00:48:04] gwicke, ok, found it, thanks [00:48:07] James_F|Away: [00:48:39] jgonera, would be awesome to get input from your side on that [00:49:06] on the extension? [00:49:34] jgonera, on the CSS [00:49:48] we are just starting to generalize the Parsoid-specific CSS [00:50:00] (03PS7) 10Jforrester: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [00:50:34] gwicke, I think I need some intro for that but my brain is too fried today [00:51:16] (03PS1) 10Jforrester: Update /.docs/eg-iframe.html for ActionDialog/NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130546 [00:51:48] jgonera, now worries ;) [00:52:10] it's just a single CSS rule so far, but more will follow for figures etc [00:53:52] (03CR) 10Krinkle: [C: 032] Update /.docs/eg-iframe.html for ActionDialog/NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130546 (owner: 10Jforrester) [00:55:21] (03Merged) 10jenkins-bot: Update /.docs/eg-iframe.html for ActionDialog/NodeDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130546 (owner: 10Jforrester) [00:57:01] jdlrobson, where are you? [01:09:21] (03CR) 10GWicke: [C: 031] WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [01:11:53] Dialogs used to have a reference to the main document surface, from which you could get the globalOverlay. How can that be done now in dialogs with the surfaceFragment? [01:15:14] (03PS7) 10JGonera: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [01:15:23] (03PS8) 10JGonera: Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [01:24:59] (03CR) 10JGonera: [C: 031] Skin dialogs in Agora [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [01:30:45] BladeBronson: Checking.. [01:32:27] BladeBronson: I think we changed the relationship. [01:32:32] Dialogs used to require a WindowSet [01:32:40] but it wasn't doing anything with it [01:33:02] it was still required to register the class and manage it through the windowset, so we removed it at some point [01:35:26] BladeBronson: I think you'll have to go through another object you have, not the dialog object. [01:35:36] The way it is now, a dialog isn't supposed to be able to get outside of itself. [01:37:34] Makes sense, but I need it. :) Our Insert Media dialog has a preview feature to see a really big version of an image. It renders in the globalOverlay and occupies the entire screen. [01:39:03] Now that we're doing a sync with the latest core, we're stuck on trying to inject the preview in the right place. [01:49:37] Well, I've got to get going. I'll look again in the morning. [03:43:00] 3VisualEditor / 3MediaWiki integration: "Edit source" tab for wikitext no longer highlighted when active - 10https://bugzilla.wikimedia.org/64646 (10Erik Moeller) 3NEW p:3Unprio s:3major a:3None In Vector/1.24wmf2, the "Edit source" tab is not highlighted when editing a page in source mode (no tab is... [03:43:01] 3VisualEditor / 3MediaWiki integration: "Edit source" tab for wikitext no longer highlighted when active - 10https://bugzilla.wikimedia.org/64645 (10Erik Moeller) 3NEW p:3Unprio s:3major a:3None In Vector/1.24wmf2, the "Edit source" tab is not highlighted when editing a page in source mode (no tab is... [04:25:16] Hiya [04:25:33] I have a few questions about running visualeditor locally. [12:53:53] (03CR) 10Krinkle: "Causes bug 64646." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/123503 (https://bugzilla.wikimedia.org/50225) (owner: 10Alex Monk) [12:53:59] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: "Edit source" tab for wikitext no longer selected on action=edit - 10https://bugzilla.wikimedia.org/64646#c1 (10Krinkle) 5NEW>3ASS p:5Unprio>3Normal a:3Krinkle Caused by Ib2e6237483338c8072d5f7919c6459bf7418946a, which overides the... [13:02:03] (03PS1) 10Krinkle: Preserve pre-existing css classes on edit tab link. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130594 (https://bugzilla.wikimedia.org/64646) [13:02:18] (03PS2) 10Krinkle: Preserve pre-existing css classes on edit tab link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130594 (https://bugzilla.wikimedia.org/64646) [13:03:43] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: "Edit source" tab for wikitext no longer selected on action=edit - 10https://bugzilla.wikimedia.org/64646#c3 (10Krinkle) (For the record, yes, confirmed this is broken in production and on latest master). [13:17:30] 3VisualEditor / 3MediaWiki integration: [Regression] VisualEditor: "Edit source" tab for wikitext no longer selected on action=edit - 10https://bugzilla.wikimedia.org/64646#c4 (10Krinkle) *** Bug 64645 has been marked as a duplicate of this bug. *** [13:17:30] 3VisualEditor / 3MediaWiki integration: "Edit source" tab for wikitext no longer highlighted when active - 10https://bugzilla.wikimedia.org/64645#c1 (10Krinkle) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 64646 *** [14:11:02] 3VisualEditor / 3Editing Tools: links interface does not highlight/remove default linked text - 10https://bugzilla.wikimedia.org/64655 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15249 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15249&action=edit first word in pag... [14:50:43] (03CR) 10GWicke: WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [15:35:12] Krinkle, looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=64646 now [15:35:46] Can't replicate it when I set $wgVisualEditorTabPosition to anything (even null), but I can replicate it when I comment that settings line out [15:37:41] which is weird because it should only be broken if you set $wgVisualEditorTabPosition to 'before' [15:40:51] ok so it defaults to before, meh [15:41:14] Krenair: It's broken regardless of tab position for me [15:41:24] mw core master and VE master [15:41:40] open action=edit, #ca-edit has .collapsible, but not .selected [15:41:51] and if you comment those lines out, it has .selected [15:42:04] (the ['class'] = "collapsible"; line) [15:42:47] Default settings (maybe you have too many local settings, try going back to default) [15:43:09] default is 'before' [15:43:21] yeah [16:06:25] (03PS6) 10Krinkle: StackLayout: Don't fire set event for null, and add unset event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [16:08:19] (03CR) 10Alex Monk: [C: 032] Preserve pre-existing css classes on edit tab link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130594 (https://bugzilla.wikimedia.org/64646) (owner: 10Krinkle) [16:16:59] (03PS7) 10Krinkle: StackLayout: Don't fire "set" event for null, add new "unset" event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [16:31:30] (03Merged) 10jenkins-bot: Preserve pre-existing css classes on edit tab link [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130594 (https://bugzilla.wikimedia.org/64646) (owner: 10Krinkle) [16:32:58] (03PS1) 10Jforrester: Preserve pre-existing css classes on edit tab link [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130622 (https://bugzilla.wikimedia.org/64646) [16:32:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf22] "Edit source" tab for wikitext no longer selected on action=edit - 10https://bugzilla.wikimedia.org/64646 (10James Forrester) 5PAT>3RES/FIX [16:33:12] (03CR) 10jenkins-bot: [V: 04-1] StackLayout: Don't fire "set" event for null, add new "unset" event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [16:33:31] (03PS8) 10Krinkle: StackLayout: Don't fire "set" event with null, use new "unset" event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [16:34:28] (03PS3) 10Krinkle: core: Avoid IE8 bug fatal error when parsing "super" property [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [16:34:32] (03CR) 10jenkins-bot: [V: 04-1] StackLayout: Don't fire "set" event with null, use new "unset" event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [16:37:25] Krinkle: Stuff to fix in OOjs UI's jsduck config? [16:38:42] James_F: Yep [16:38:45] Working on it [16:38:49] We should read from src, not dist [16:38:56] Ha, yeah, that might help. :-) [16:39:12] tricky though, because we need to exclude intro.js (which produces a parse error) [16:39:19] and it doesn't take wildcards or exclusions [16:39:31] We could move intro.js and outro.js out of src and into build [16:39:50] It's not actually code, except for "use strict;", and that could be moved elsewhere. [16:40:14] It's been bothering me how much we have to exclude those two files. [16:45:49] (03PS1) 10Krinkle: Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130623 [16:46:28] (03CR) 10jenkins-bot: [V: 04-1] Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130623 (owner: 10Krinkle) [16:48:40] Need to change the jsduck config too. :-) [16:48:55] (03PS1) 10Krinkle: Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130625 [16:49:13] James_F: You know me better than that to make mixing changes like that [16:49:16] (03CR) 10Krinkle: [C: 04-1] Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130625 (owner: 10Krinkle) [16:49:21] (03CR) 10jenkins-bot: [V: 04-1] Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130625 (owner: 10Krinkle) [16:49:29] Krinkle: That's just cheating. ;-) [16:50:05] (03Abandoned) 10Krinkle: Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130625 (owner: 10Krinkle) [16:50:14] (03PS2) 10Krinkle: Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130623 [16:50:28] Ah, right, because jenkins is failing [16:50:32] yeah, will have to I guess. [16:50:42] (03CR) 10jenkins-bot: [V: 04-1] Move intro.js and outro.js out of src/ into build/ [oojs/ui] - 10https://gerrit.wikimedia.org/r/130623 (owner: 10Krinkle) [16:50:52] Or I could C+2 V+2 this one for now? [16:50:59] Pick one. [16:51:02] Or… [16:51:33] You could write the horrible hack to run jsduck on src/ and exclude {in|out}tro.js, then that rename, then the simplification. [16:51:37] But that seems insane. [16:52:03] There is no excluding [16:52:16] Right, hardcoding it all [16:52:18] no thanks [16:52:25] Eww. [16:54:56] (03PS3) 10Krinkle: Rename intro.js and outro.js to have .txt extensions [oojs/ui] - 10https://gerrit.wikimedia.org/r/130623 [16:55:21] (03CR) 10Jforrester: "> 21:11:16 Notice: Undefined index: visualeditor-enable-language in /srv/ssd/jenkins-slave/workspace/mwext-VisualEditor-qunit/extensions/V" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [16:56:36] (03CR) 10Jforrester: [C: 032] Rename intro.js and outro.js to have .txt extensions [oojs/ui] - 10https://gerrit.wikimedia.org/r/130623 (owner: 10Krinkle) [16:57:02] (03Merged) 10jenkins-bot: Rename intro.js and outro.js to have .txt extensions [oojs/ui] - 10https://gerrit.wikimedia.org/r/130623 (owner: 10Krinkle) [16:57:16] (03PS9) 10Jforrester: StackLayout: Don't fire "set" event with null, use new "unset" event [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [16:58:00] (03CR) 10Krinkle: "(yay jsduck #1)" [oojs/core] - 10https://gerrit.wikimedia.org/r/124360 (https://bugzilla.wikimedia.org/63303) (owner: 10Jforrester) [16:58:14] Krinkle: :-D [16:58:46] James_F, can you remind me of the link to schedule appointments with trevor and roan? Can't find the email [17:29:49] Krinkle: so, I'm looking at this set/unset event thing [17:30:31] If we were to continue down that path, we would need to have select/unselect, highlight/unhighlight, press/unpress events for SelectWidget as well, no? [17:30:56] this pattern of using null is established in other places, so we should probably seek to at least eventually keep them in sync [17:32:20] there are other inconsistencies, like how we don't override addItems in booklet layout, but instead use addPages (the only place we wrap a parent method with a different name) which I would like to cleanup as well [17:33:15] and I also don't know what the hell we are going to do about one day needing to support multi-selection in SelectWidget since the interfaces are all singular/mutually-exclusive when it comes to selection [17:34:09] TrevorParscal: Have it take null, a single reference or an array? [17:34:28] TrevorParscal: And an "alsoSelect()" method? :-) [17:34:54] the methods are all selectItem not setSelection [17:35:15] OK, selectItemWithoutDeselectingOthers [17:35:16] anyway, my point is, I want to avoid abandoning the null pattern some places and leaving it other places [17:35:29] and I actually don't think the null pattern is causing a lot of issues [17:35:54] binding to two separate events is surely more complicated than checking if something is null here and there [17:36:09] and null is the absence of an object, that's what it's meant to be [17:37:15] typeof null [17:37:21] "object" [17:37:42] Krinkle: you aren't really here are you? [17:37:50] I'm here now [17:37:59] ok, read backlog [17:38:01] plz [17:39:11] TrevorParscal: Having events take null/single/array makes for terrible event listeners. [17:39:25] i'm not suggesting the array thing [17:39:32] don't get all distracted by James_F [17:39:33] Whether we need pairs everywhere I dont know, but I'd say it makes a lot of sense [17:39:44] even just null/item is hard to justify imho [17:39:53] I honestly haven't run into it until this one [17:40:00] I have. [17:40:18] Looks like a hazard, a null exception waiting to happen in a listener somewhere that isn't accounting for it [17:40:31] it doesn't make sense because you are not binding to each item individually, you are binding to a list of items which has a state of which item is "current", and as that active property changes [17:40:32] like, if you're a listener and need only an item, not null. What do you do if you get null? [17:40:34] return early? [17:40:51] It sounds like listeners can't/shouldn't know well how to deal with that. It's a different kind of event. [17:40:52] *"current" property changes, you should be able to synchronize to it with a single listener [17:41:35] They're not property change events though. At least I don't think of them that way. We tend to have more fleshed out and pre-processed events, which I like. [17:41:38] splitting events only goes so far, I mean should we have mousedown or mousebutton1down, mousebutton2down, mousebutton3down, etc. [17:42:13] Inside the event handler, yes you need to determine which button, but since that's easy to do, it's more sensible in many cases to use a single event [17:43:02] Yes, but that's different because there are plenty of cases where you might not care as a listener how it got there [17:43:16] I mean, in general we don't look at the mouse button, we just handle the event like any other. [17:43:23] Except in case of contextmenu [17:43:37] that's a different event, eventhough it is a click event, it does not result in an onclick [17:43:52] because there's a semantic difference, eventhough it is technically a click (depending on your input device) [17:44:21] Krinkle: besides, look at the actual handlers - they aren't always checking if it's not null, sometimes they are checking if it's equivalent to something specific [17:44:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add an edit notice for users of slower computers advising them to use source mode - 10https://bugzilla.wikimedia.org/50518#c3 (10Alex Monk) Timo thinks we can measure performance and display an edit notice if it's slow. [17:44:30] Imagine if all right click evnets triggered onclick. That'd be a night mare, people would forget all the time to check. [17:44:37] in the case of splitting the events, you would double the code needed [17:44:50] I'm not suggesting we go bonkers in either direction. [17:45:26] I'm suggesting we not go bonkers in either direction. [17:45:40] I'm just saying that this is an event that tells you that a property (currentItem) has changed, that's what it actually does and is [17:46:01] splitting the event based on what it's changed to (null or an object) is going to make things messy [17:46:11] messier than checking for null on occasion [17:46:16] RoanKattouw: I'll file a bug or two apropos of using ?veaction=edit for anon that we can discuss on Friday at your convenience. I think one issue at least will be amusing. :-) [17:46:28] so, I'm not sold on this set/unset [17:46:50] we don't have select/unselect, we have select ( range ) and select ( null ) [17:47:04] in DM and in SelectWidget [17:47:50] in other words, what you are touching is just one place this pattern is used intentionally - so if you really believe that the pattern is flawed, then surely we wouldn't only fix it one place [17:48:25] and if the other places need their own patterns (assuming splitting events isn't a one-size-fits all solution) then what would those be? [17:49:03] TrevorParscal: I think there's still plenty of cases (including all the ones you mentioned) where having these events separate will provide more benefit than cost. [17:49:08] for one, prevItem is an interesting one [17:49:18] Anyway, I'll refactor the change to deal only with the bugs and leave 'set' as is [17:49:31] look at the actual handlers Timo, I'm telling you, in vemw, niether of them even check for null [17:49:45] because there were plenty of other issues with that class that I wanted to actually address, the set/unset was just something I came up with along the way and took over the subject of hte change [17:49:55] it has the effect of adding new handlers to maintain the same behavior as before, it doesn't reduce or simplify anything in practice [17:50:25] you need to look at the actual handlers man, this is a solution looking for a problem [17:51:30] see ve.ui.MWMediaEditDialog.prototype.onBookletLayoutSet and ve.ui.MWTransclusionDialog.prototype.onBookletLayoutSet [17:51:31] 3VisualEditor / 3Editing Tools: VisualEditor:Reference list dialog box is appearing much larger in size like previous design in Betalabs - 10https://bugzilla.wikimedia.org/64670 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Created attachment 15252 --> https://bugzilla.wikimedia.org/attachment.cg... [17:52:11] the only 2 handlers outside of OOUI, and both of them prove my point, you would have to double the code with no increase in clarity [17:52:13] 3VisualEditor / 3Editing Tools: VisualEditor:Reference list dialog box is appearing much larger in size like previous design in Betalabs - 10https://bugzilla.wikimedia.org/64670#c1 (10ryasmeen ) Created attachment 15253 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15253&action=edit Reference list... [17:53:00] OO.ui.BookletLayout.prototype.onStackLayoutSet is the only case in which we check for the page to be non-null before proceeding [17:53:14] (03PS10) 10Krinkle: StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [17:53:23] and it's hardly obtrusive, its litterally 2 simple lines, the latter of which containing only "}" [17:53:45] Krinkle: maybe you could focus on the other issues on the class and we could talk about this change later [17:53:48] TrevorParscal: I'm ignoring the callers, I don't even know how this class is used. Sure, you're right. [17:54:04] TrevorParscal: I said that 5 minutes ago. [17:54:05] Done [17:55:26] (03CR) 10Trevor Parscal: "Well intentioned, but I'm suspicious about changing this pattern given the existing consumers of this event would need to become more comp" [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [17:55:33] (03CR) 10Trevor Parscal: [C: 04-1] StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [17:55:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Reference list dialog is no longer "small" size, but default "large" - 10https://bugzilla.wikimedia.org/64670 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3minor [17:56:01] Krinkle: I am not trying to beat you into submission, I'm trying to debate, sorry if I'm being too aggressive [17:56:49] (03CR) 10Krinkle: "I assume that -1 was for PS9, not PS10" [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [17:57:13] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool adds stray line break at the end of the template - 10https://bugzilla.wikimedia.org/63128 (10James Forrester) [17:57:18] (03CR) 10Trevor Parscal: "Right, sorry about that." [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [17:57:28] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool matching should also match templates with whitespace before the first parameter - 10https://bugzilla.wikimedia.org/63129 (10James Forrester) [17:58:26] TrevorParscal: I think the main confusion stems from the semantic intend of the event [17:58:40] TrevorParscal: 'change' events can go to null-like values, that makes sense [17:58:47] 'change' events also often have a previous value exposed [17:58:58] 3VisualEditor / 3ContentEditable: VisualEditor: Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399 (10James Forrester) 5PAT>3RES/FIX [17:59:03] but 'new', or 'add', 'attach' kind of events, you wouldn't want to mix that [17:59:10] with remove /detach [17:59:28] 3VisualEditor / 3Editing Tools: VisualEditor: Inserting templates into new or pre-existing references in Firefox causes dead-end dialog: can't add, can't exit, can't save - 10https://bugzilla.wikimedia.org/64434 (10James Forrester) [17:59:40] and in case of the toolbar tracker, for example, it made it quite simple [17:59:50] the 'position' event emited coordinates, which we map to the tracker [18:00:06] there was no null case, instead you have a separate listener for 'close' where you have that handling [18:00:33] it doesn't increase code complexity, it change sit from 1 handler with two separate cases in if/else to two handlers without a conditional [18:01:03] anyway, we no longer have that [18:06:02] i think the pattern of using null is either a good idea or a bad idea based on the way callers handle the event, and there's no hard and fast rule here, but in OOUI, select/highlgiht/press/set are mutually exclusive "current" states, which perhaps could be named better to reflect that but nonetheless are common in that they are emitted when one or none of their items are made exclu [18:06:02] sively active [18:07:38] (03CR) 10Catrope: [C: 032] Fix tab selection on monobook (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130085 (https://bugzilla.wikimedia.org/49407) (owner: 10Alex Monk) [18:07:45] 3VisualEditor / 3Editing Tools: VisualEditor: "Null" appearing instead of "Transclusion" in the template insert dialog box in Betalabs - 10https://bugzilla.wikimedia.org/64671 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Created attachment 15254 --> https://bugzilla.wikimedia.org/attachment.cgi?i... [18:09:01] 3VisualEditor / 3MediaWiki integration: VisualEditor: Clean up Monobook-specific mess in ViewPageTarget init code - 10https://bugzilla.wikimedia.org/64672 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Alex Monk In particular, see comments on https://gerrit.wikimedia.org/r/#/c/130085/ [18:09:04] TrevorParscal: https://bugzilla.wikimedia.org/64671 sounds concerning [18:10:12] TrevorParscal: Also, please review https://gerrit.wikimedia.org/r/#/c/129830/ , it's been sitting around for like a week [18:10:34] It's a temporary change until the save dialog is ported to ActionDialog properly [18:10:53] (03Merged) 10jenkins-bot: Fix tab selection on monobook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130085 (https://bugzilla.wikimedia.org/49407) (owner: 10Alex Monk) [18:12:52] (03CR) 10Catrope: [C: 04-1] Cleanup focus/select/clear (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [18:13:14] (03CR) 10Catrope: [C: 04-1] "This change doesn't describe what it's doing at all. What is being cleaned up any why?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 (owner: 10Trevor Parscal) [18:13:37] (03CR) 10Catrope: [C: 032] Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [18:13:46] (03CR) 10jenkins-bot: [V: 04-1] Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [18:15:49] (03PS3) 10Catrope: Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [18:16:06] thanks RoanKattouw [18:16:06] (03CR) 10Catrope: [C: 032] Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [18:16:09] TrevorParscal, oojs select widgets don't have 'initializeSelection' anymore, right? [18:16:49] mooeypoo: no, but you can call select without them hiding anymore [18:17:10] and you should bind to "choose" instead of "select" to get the user's actual choice [18:17:23] ah [18:17:27] how can I select without firing the choose event? [18:17:28] 3VisualEditor / 3Technical Debt: VisualEditor: Clean up Monobook-specific mess in ViewPageTarget init code - 10https://bugzilla.wikimedia.org/64672 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3enhanc [18:17:35] (03Merged) 10jenkins-bot: Use window 'ready' event to focus surfaces [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130251 (owner: 10Esanders) [18:17:39] (03CR) 10Trevor Parscal: [C: 032] Call clearAllMessages in setup instead of swapPanel on the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129830 (https://bugzilla.wikimedia.org/62766) (owner: 10Alex Monk) [18:17:47] Thanks TrevorParscal [18:17:51] mooeypoo: selectItem( item ) [18:18:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: Font weight is removed from "article" tab in Monobook - 10https://bugzilla.wikimedia.org/49407 (10James Forrester) 5PAT>3RES/FIX [18:18:24] OK I'm going to take a shower then come into the office [18:18:27] TrevorParscal, ok, so 'choose' fires only on actual click of the item? What if I want to 'simulate' a user choice (and fire the event) ? [18:18:30] mooeypoo: basically the initialze selection thing was horrible and we cleaned it up by introducing "choose" separate from "select" [18:18:50] I should be in at a reasonable time for lunch-related purposes [18:18:52] chooseItem( item ) [18:19:05] that makes sense, but now I am having problems with some of the selects, it's likely because I didn't adjust for that. [18:19:08] oh, hmmm. [18:19:15] (03Merged) 10jenkins-bot: Call clearAllMessages in setup instead of swapPanel on the save dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129830 (https://bugzilla.wikimedia.org/62766) (owner: 10Alex Monk) [18:19:34] James_F , ryasmeen: Can we do the pre-deployment review a bit later? According to the calendar ryasmeen has a QR meeting anyway [18:19:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Null" appearing instead of "Transclusion" in the template insert dialog box - 10https://bugzilla.wikimedia.org/64671 (10James Forrester) 5NEW>3ASS p:5Unprio>3High [18:20:02] RoanKattouw: I'm skipping because I'm in the Platform QR meeting. [18:20:34] OK [18:21:09] RoanKattouw: in php, you can't just pass a classname around in a variable, you have to pass the string? is that right? [18:21:27] TrevorParscal: That's correct [18:21:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: The Save dialog box prompts to fill out a new captcha if a user goes to review changes section and switches back after filling out the captcha field for the first time - 10https://bugzilla.wikimedia.org/62766 (10James Forrester) 5PAT>3RES/FIX a:3Alex... [18:21:38] like $class = MyClass; doesn't work, you have to use $className = 'MyClass'; [18:21:40] If I'm right about https://bugzilla.wikimedia.org/show_bug.cgi?id=49667 (that it is consistent with core), I think the bug should be moved to core and for VE to not change anything until the core patch is merged, if necessary [18:21:51] TrevorParscal: Exactly. But then new $className() does work [18:21:59] with $className being a string [18:22:00] so freaking evil [18:22:04] Yup [18:22:05] Welcome to PHP [18:22:06] I forgot how horrid this is [18:22:12] Welcome back you mean? [18:22:16] Yeah :) [18:22:29] ugh, I feel like I've been able to sleep at night because I've blocked out this horror [18:23:06] Do you need the equivalent of Claritin for PHP? :P [18:25:36] I need my Roany McRoanerson to come and console me [18:28:29] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434 (10James Forrester) p:5Unprio>3High s:5critic>3major [18:28:30] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434 (10James Forrester) 5NEW>3ASS [18:28:58] TrevorParscal: lol! Roany McRoanerson will arrive around noon [18:29:03] Consolation will be offered in the form of lunch [18:29:30] shall we meet somewhere? [18:29:37] I guess you have plenty of time to get here first [18:29:40] Yeah [18:29:57] And I don't want to lug my stuff around [18:29:59] So I'll just come in [18:54:46] 3VisualEditor / 3Editing Tools: VisualEditor: "Use existing reference" in not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677 (10ryasmeen ) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page 2.Add few references 3.Now Go to Insert>Reference>Use an Existing Re... [18:55:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Use existing reference" in not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3major [18:56:07] (03CR) 10Krinkle: "fixme/cleanup" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130085 (https://bugzilla.wikimedia.org/49407) (owner: 10Alex Monk) [18:56:34] (03PS1) 10Krinkle: mw.ViewPageTarget: Simplify tab transform/restore logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130656 [18:56:55] (03CR) 10Krinkle: Fix tab selection on monobook (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130085 (https://bugzilla.wikimedia.org/49407) (owner: 10Alex Monk) [18:59:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Use existing reference" in not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677#c1 (10ryasmeen ) Also, if you have added a reference list on that session before attempting to add an existing reference,the "Save Page" button be... [19:02:17] (03PS2) 10Krinkle: mw.ViewPageTarget: Simplify tab transform/restore logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130656 [19:05:42] (03PS3) 10Krinkle: mw.ViewPageTarget: Simplify tab transform/restore logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130656 [19:05:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c18 (10ryasmeen ) 5VER>3REO I am again getting this issue in Chrome in Betalabs. [19:11:14] aaaaaa. [19:11:59] mooeypoo: Having fun? [19:12:15] ok, I'm in need of fresh eyes on this. [19:12:18] Anyone? :\ [19:12:45] I have a feeling this is a mix of switching 'select' to 'choose' *and* two models listening to the event [19:14:16] TrevorParscal: ^^^ [19:14:28] TrevorParscal, any chance you'll have a few minutes? [19:14:32] oh. hah :) [19:15:23] also, we should update MediaSizeWidget to use 'choose' instead of 'select', but the weird thing is that it *works* even without the change [19:15:25] so I'm confused. [19:52:19] (03PS1) 10Alex Monk: Add class name to protected pages, to allow for specific CSS styling of edit area [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130665 (https://bugzilla.wikimedia.org/50783) [19:53:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Use existing reference" is not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677 (10ryasmeen ) [20:18:56] https://code.google.com/p/chromium/issues/detail?id=62435 [20:19:23] TrevorParscal: James_F: Can you gaze over https://gerrit.wikimedia.org/r/#/c/130541/ [20:19:43] Because we didn't fix regression https://bugzilla.wikimedia.org/show_bug.cgi?id=64599 yesterday [20:19:47] in some ways we made it worse [20:19:54] better get it out before wider deployment of that wmf branch [20:20:05] (e.g. inspectors are fucked) [20:21:56] Krinkle: Yeah, Roan's reviewing that straight after he finishes lunch. [20:21:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599#c7 (10Krinkle) Yeah, we fixed the page content font-size and line-height, but now those changes incorrectly apply to our ove... [20:22:10] James_F: OK [20:22:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599#c8 (10Krinkle) (In reply to Krinkle from comment #7) > Yeah, we fixed the page content font-size and line-height, but now th... [20:22:49] (03PS4) 10Krinkle: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) [20:22:53] (03PS5) 10Krinkle: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) [20:23:31] James_F: Hm.. any thoughts on the fact that ve bugs go to both mediawiki-visualeditor and wikimedia-dev? [20:24:12] Krinkle: I suggested that they should only go here, but was told "no", so I now /ignore wikibugs for messages with "VisualEditor:" in them. [20:24:33] Krinkle: This way I don't get double-pinged for most bugs, but do for non-VE ones. [20:26:05] James_F: Hm.. and how do you do that kind if ignore? [20:26:07] LimeChat? [20:26:34] Krinkle: Yeah; just typing in "/ignore" in a LimeChat window and you get a UI to set such things. [20:26:45] O_O [20:26:51] Fun, huh? :-) [20:26:52] /ignore has a UI! [20:27:00] In LimeChat, yeah. [20:27:08] yay for disoverability [20:27:10] :-D [20:27:27] Oh, it's just in serever properties, not a dedicated hidden window [20:27:28] better [20:27:59] Quite advanced [20:28:00] nice [20:28:33] Krinkle: You're welcome. :-P [20:28:59] 3VisualEditor / 3ContentEditable: VisualEditor: Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399#c5 (10ryasmeen ) Verified the fix in Betalabs with Firefox 27.0.1 [20:30:00] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434#c1 (10James Forrester) 5ASS>3RES/FIX a:3Ed Sanders Fixed in the Firefox-selection change E... [20:31:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c19 (10ryasmeen ) 5REO>3RES/FIX Now , it does not look broken .Hence, marking it as Fixed. [20:40:40] James_F: I think I'm joining the club in favour of keeping it all (also) in #wikimedia-dev [20:40:47] Just got double pinged by a mobile bug [20:40:53] which I'd rather get in -dev [20:41:01] but people on mobile probably not [20:41:04] so makes sense [20:41:13] and of course people not in -mobile or -visualeditor [20:43:46] RoanKattouw_away: ping me when you're back. want your input on how the API for specifying functions in ResourceLoader registry (server-side) for conditional dependencies should look. Thinking XmlJsCode will come in at some point, not sure if we want to keep that internal or not though. Let's talk. [20:44:34] Krinkle: Could we talk about that on Friday maybe? Today is a busy day with deployment stuff [20:45:00] should only take a minute, woudl allow me to start writing implemtnation. [20:45:54] OK [20:46:55] (03PS2) 10Trevor Parscal: Cleanup focus/select/clear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 [20:47:18] (03CR) 10jenkins-bot: [V: 04-1] Cleanup focus/select/clear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [20:47:20] (03PS3) 10Trevor Parscal: Cleanup focus/select/clear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 [20:47:43] (03CR) 10jenkins-bot: [V: 04-1] Cleanup focus/select/clear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [20:48:20] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=64334 is that dropdown bug [20:49:39] RoanKattouw: Also something missing from the list: https://gerrit.wikimedia.org/r/#/c/130479/ [20:52:03] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Cleanup widget focus/select/clear methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 [20:52:32] (03CR) 10Alex Monk: [C: 032] mw.ViewPageTarget: Simplify tab transform/restore logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130656 (owner: 10Krinkle) [20:53:18] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Cleanup widget focus/select/clear methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 [20:53:37] (03PS5) 10Trevor Parscal: [BREAKING CHANGE] Cleanup widget focus/select/clear methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 [20:55:15] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Simplify tab transform/restore logic [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130656 (owner: 10Krinkle) [20:55:50] (03CR) 10Jforrester: "Fixed bug 64672." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130656 (owner: 10Krinkle) [20:56:29] 3VisualEditor / 3Technical Debt: VisualEditor: Clean up Monobook-specific mess in ViewPageTarget init code - 10https://bugzilla.wikimedia.org/64672#c1 (10James Forrester) 5ASS>3RES/FIX a:5Alex Monk>3Krinkle Fixed in gerrit 130717. [20:57:35] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Return promise instead of taking callback argument [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 [20:58:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf1] The first letter of the reference text disappears after typing in the reference dialog box - 10https://bugzilla.wikimedia.org/63909#c19 (10ryasmeen) 5REO>3RES/FIX Now , it does not look broken .Hence, marking it as Fixed. [20:59:39] (03PS2) 10Catrope: Add class name to protected pages, to allow for specific CSS styling of edit area [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130665 (https://bugzilla.wikimedia.org/50783) (owner: 10Alex Monk) [20:59:53] (03CR) 10Catrope: [C: 032] Add class name to protected pages, to allow for specific CSS styling of edit area [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130665 (https://bugzilla.wikimedia.org/50783) (owner: 10Alex Monk) [21:01:40] (03Merged) 10jenkins-bot: Add class name to protected pages, to allow for specific CSS styling of edit area [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130665 (https://bugzilla.wikimedia.org/50783) (owner: 10Alex Monk) [21:04:30] Krinkle: Sooooo https://gerrit.wikimedia.org/r/#/c/130541 [21:04:35] Krinkle: It kind of doesn't work [21:04:45] ? [21:04:52] you did update submodule, right [21:05:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add class name to protected pages, to allow for specific CSS styling of edit area - 10https://bugzilla.wikimedia.org/50783 (10James Forrester) 5PAT>3RES/FIX a:3Alex Monk [21:05:39] RoanKattouw: Did you confirm that current master has correct line-height and font-size and that current master has broken inspector (e..g link inspector suggestions) [21:05:40] elaborate :) [21:05:41] Yes [21:05:47] Current master has broken inspectors [21:05:54] With your change, I get the exact same broken inspector [21:06:18] And broken context menu. [21:06:33] RoanKattouw: Do you have latest mwcore? [21:06:38] It broke again? [21:06:46] (03PS1) 10Trevor Parscal: Make inserting existing references work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130734 [21:06:47] Krenair: It was never fixed. :-( [21:06:54] Let me check that I have the lastest core [21:07:12] (03PS2) 10Trevor Parscal: Make inserting existing references work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130734 [21:07:32] Yup still broken with latest core [21:08:00] "Uncaught TypeError: Object # has no method 'clearFlags'" when opening the meta dialog [21:08:14] RoanKattouw: No [21:08:19] RoanKattouw: The change got corrupted [21:08:25] RoanKattouw: Read the commit message "move down that class" [21:08:27] Krenair: Update MW core [21:08:29] there is no change to ve.init.mw.ViewPageTarget.js [21:08:33] aah OK [21:08:35] somehow got lost [21:08:49] ve.init.mw.Target.js * [21:08:57] Krinkle: Probably you and me tripping over each other; sorry. [21:09:21] restoring.. and verifing [21:09:34] yeah, fixes [21:09:42] (03PS6) 10Krinkle: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) [21:09:56] (03PS7) 10Krinkle: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) [21:11:18] (03PS3) 10Jforrester: Make inserting existing references work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130734 (https://bugzilla.wikimedia.org/64677) (owner: 10Trevor Parscal) [21:11:45] I love it when pull requests to whatwg/dom get merged [21:11:46] https://github.com/whatwg/dom/pull/11 [21:11:49] Feels so... right. [21:12:02] It's rare, but feels oh so good. [21:12:34] It's a straight line from there to dom.whatwg.org to browser implemetnation, and after that to w3 draft and recommendation [21:12:36] As evidenced by the URL [21:12:40] Like, 11? Really? [21:12:45] :) [21:12:55] No open pull requests. [21:12:58] most people discuss on mailing list and the core contributors commit for you [21:13:04] That's a good sign. ;-) [21:13:33] it's mostly text changes, rarely code, people tend to not attribute that via commits but via manual attribution . Anyhow, good stuff [21:14:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Use existing reference" is not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677 (10James Forrester) a:3Trevor Parscal [21:14:50] edsanders: You're alive! [21:15:06] or someone stole my laptop [21:15:19] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) (owner: 10Krinkle) [21:15:21] edsanders: I'm going to go with the former. [21:16:50] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130541 (https://bugzilla.wikimedia.org/64599) (owner: 10Krinkle) [21:20:24] edsanders: Feel free to review and merge https://gerrit.wikimedia.org/r/#/c/129856/ if you're up to it. [21:20:49] (03PS1) 10Catrope: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130738 [21:20:50] TrevorParscal: This is why we need visual diffing: https://en.wikipedia.org/w/index.php?title=Sheldon_Cohen&oldid=prev&diff=560448517 [21:20:51] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130738 (owner: 10Catrope) [21:21:26] (03Abandoned) 10Catrope: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130738 (owner: 10Catrope) [21:22:29] (03Restored) 10Catrope: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130738 (owner: 10Catrope) [21:22:36] (03CR) 10Catrope: [C: 032 V: 032] ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130738 (owner: 10Catrope) [21:22:37] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130738 (owner: 10Catrope) [21:24:01] (03Abandoned) 10Catrope: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130738 (owner: 10Catrope) [21:24:35] (03PS1) 10Catrope: ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130739 [21:24:49] 'refs/wmf/1.24wmf2', RoanKattouw going yolo? [21:25:13] Yeah I'm having a bad day [21:25:33] (03CR) 10Catrope: [C: 032 V: 032] ve.ce.Surface: Remove font-size: 1em; [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130739 (owner: 10Catrope) [21:25:51] no worries, I'm surprised you're on your feet today. I havent' seen you sick, but seen others. Respect :) [21:26:14] I'm not really "sick" as much as hay fever-ish [21:29:38] (03PS1) 10Catrope: mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130745 (https://bugzilla.wikimedia.org/64599) [21:29:44] (03PS1) 10Trevor Parscal: Add getLookupMenu method to LookupInpuWidget mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/130746 [21:30:54] (03CR) 10Catrope: [C: 032] Make inserting existing references work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130734 (https://bugzilla.wikimedia.org/64677) (owner: 10Trevor Parscal) [21:32:26] (03CR) 10Catrope: [C: 032] Support QuestyCaptcha and (kind of) MathCaptcha (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129570 (https://bugzilla.wikimedia.org/64328) (owner: 10Alex Monk) [21:33:24] (03Merged) 10jenkins-bot: Make inserting existing references work again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130734 (https://bugzilla.wikimedia.org/64677) (owner: 10Trevor Parscal) [21:34:06] (03Merged) 10jenkins-bot: Support QuestyCaptcha and (kind of) MathCaptcha [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129570 (https://bugzilla.wikimedia.org/64328) (owner: 10Alex Monk) [21:34:57] (03PS1) 10Trevor Parscal: Bring the transclusion title back to life [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130749 [21:34:58] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add support for more types of ConfirmEdit captcha - 10https://bugzilla.wikimedia.org/64328#c6 (10James Forrester) 5PAT>3ASS QuestyCaptcha and MathCaptcha both done too. Is Fancy sufficiently supported that we can close this? [21:35:06] (03CR) 10Krinkle: [C: 031] [BREAKING CHANGE] Return promise instead of taking callback argument [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 (owner: 10Trevor Parscal) [21:35:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Use existing reference" is not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677 (10James Forrester) 5PAT>3RES/FIX [21:36:32] (03PS2) 10Trevor Parscal: Bring the transclusion title back to life [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130749 [21:36:50] (03PS3) 10Trevor Parscal: [BREAKING CHANGE] Return promise instead of taking callback argument [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 [21:41:21] (03PS3) 10Jforrester: Bring the transclusion title back to life [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130749 (https://bugzilla.wikimedia.org/64671) (owner: 10Trevor Parscal) [21:52:29] 3VisualEditor / 3MediaWiki integration: VisualEditor: The Save dialog box prompts to fill out a new captcha if a user goes to review changes section and switches back after filling out the captcha field for the first time - 10https://bugzilla.wikimedia.org/62766#c3 (10ryasmeen) Verified the fix in Betalabs [21:57:42] TrevorParscal, can we merge https://gerrit.wikimedia.org/r/#/c/125269/ and reiterate on it if necessary? [21:58:36] we are deploying today, so yeah but tomorrow [21:58:43] I will give it a final look and merge it tomorrow morning [21:58:43] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Use existing reference" is not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677#c4 (10ryasmeen) Verified the fix in Betalabs [21:58:46] ok [22:02:44] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab while keeping the math inspector open throws TypeError: Cannot read property 'start' of null - 10https://bugzilla.wikimedia.org/64451#c3 (10ryasmeen) Verified the fix on Betalabs [22:02:57] (03CR) 10Krinkle: [C: 032] [BREAKING CHANGE] Return promise instead of taking callback argument [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 (owner: 10Trevor Parscal) [22:03:24] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Return promise instead of taking callback argument [oojs/ui] - 10https://gerrit.wikimedia.org/r/130424 (owner: 10Trevor Parscal) [22:04:55] (03PS9) 10Krinkle: Add Agora theme dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [22:05:12] (03PS10) 10Krinkle: Add Agora theme dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [22:08:44] 3VisualEditor / 3Editing Tools: VisualEditor: When "__FORCETOC__" is set, inside VE instead of "Hide" the link to hide the TOC appears as "" - 10https://bugzilla.wikimedia.org/64464#c2 (10ryasmeen) Verified the fix in Betalabs [22:12:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page save time at 75th percentile up 70% from February - 10https://bugzilla.wikimedia.org/64171#c9 (10ssastry) I think the instrumentation in the WIP patch above should shed some light by breaking the save-pipeline time into parsoid-serialization time + e... [22:13:57] (03CR) 10Subramanya Sastry: [C: 031] "Added my comments and thoughts on the bug report." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [22:21:14] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434#c2 (10ryasmeen) Verified the fix in Betalabs [22:26:10] (03CR) 10Catrope: [C: 032] Bring the transclusion title back to life [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130749 (https://bugzilla.wikimedia.org/64671) (owner: 10Trevor Parscal) [22:28:02] (03Merged) 10jenkins-bot: Bring the transclusion title back to life [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130749 (https://bugzilla.wikimedia.org/64671) (owner: 10Trevor Parscal) [22:32:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Null" appearing instead of "Transclusion" in the template insert dialog box - 10https://bugzilla.wikimedia.org/64671 (10James Forrester) 5PAT>3RES/FIX a:3Trevor Parscal [22:32:54] (03PS1) 10Jforrester: Revert "Localisation updates from https://translatewiki.net." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130758 [22:38:07] (03PS2) 10Jforrester: Re-introduce 'visualeditor-dialog-transclusion-title' translations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130758 [22:39:03] (03CR) 10Jforrester: [C: 032] Re-introduce 'visualeditor-dialog-transclusion-title' translations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130758 (owner: 10Jforrester) [22:41:24] (03Merged) 10jenkins-bot: Re-introduce 'visualeditor-dialog-transclusion-title' translations [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130758 (owner: 10Jforrester) [22:46:14] RoanKattouw: AFAICT the only things left for tomorrow are https://gerrit.wikimedia.org/r/#/c/129856/ and trying to backport the 0,0 Firefox stuff. [22:46:23] RoanKattouw: Unless I've missed something? [22:48:25] Sounds right [22:52:58] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a formula/hieroglyphics insert while selecting an image tries to modify the caption, dies - 10https://bugzilla.wikimedia.org/58045#c6 (10ryasmeen) Verified the fix in test2 [22:55:28] 3VisualEditor / 3Editing Tools: links interface does not highlight/remove default linked text - 10https://bugzilla.wikimedia.org/64655#c1 (10James Forrester) I can't reproduce this in Chrome or Firefox on Beta Labs now – possibly a temporary/cached deployment bug? [22:56:58] 3VisualEditor / 3Editing Tools: VisualEditor: In Firefox, the context menu's background sometimes does not appear for items inside a media caption (but the icons appear still) - 10https://bugzilla.wikimedia.org/64332 (10James Forrester) s:5normal>3minor [22:57:44] (03PS2) 10Jforrester: Add getLookupMenu method to LookupInputWidget mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/130746 (owner: 10Trevor Parscal) [22:59:43] 3VisualEditor / 3Editing Tools: VisualEditor: Inserting a formula into a block slug throws "Uncaught TypeError: Cannot call method 'getOuterRange' of null" - 10https://bugzilla.wikimedia.org/58286#c11 (10ryasmeen) Verified the fix in test2 [23:01:14] 3VisualEditor / 3Editing Tools: VisualEditor: Math inspector does not check type of node it's inspecting - 10https://bugzilla.wikimedia.org/56645#c8 (10ryasmeen) Verified the fix on test2 [23:02:50] RoanKattouw: Once that's done, Gabriel wants your input to https://gerrit.wikimedia.org/r/#/c/130543/ [23:04:52] (03CR) 10Catrope: [C: 032] mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130745 (https://bugzilla.wikimedia.org/64599) (owner: 10Catrope) [23:04:57] (03CR) 10Catrope: [V: 032] mw.ViewPageTarget: Move .mw-body-content down to .ve-ce-surface [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130745 (https://bugzilla.wikimedia.org/64599) (owner: 10Catrope) [23:05:31] (03CR) 10Catrope: [C: 032 V: 032] Preserve pre-existing css classes on edit tab link [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130622 (https://bugzilla.wikimedia.org/64646) (owner: 10Jforrester) [23:06:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf22] "Edit source" tab for wikitext no longer selected on action=edit - 10https://bugzilla.wikimedia.org/64646 (10James Forrester) 5PAT>3RES/FIX [23:06:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599 (10James Forrester) 5PAT>3RES/FIX [23:14:29] (03CR) 10Catrope: [C: 04-1] WIP Bug 64171: Log Parsoid request timings to eventlogging (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [23:18:07] (03PS1) 10Trevor Parscal: Auto-choose selected item when adding a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130767 [23:23:04] TrevorParscal: Thanks man [23:24:06] (03PS8) 10Catrope: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [23:26:48] (03PS1) 10Catrope: [WIP] Style external link suggestions with the right color [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130769 [23:28:42] (03PS1) 10Catrope: [WIP] MWFormatTool.css [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 [23:28:54] (03PS9) 10Catrope: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [23:30:04] (03CR) 10Catrope: [C: 032] Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [23:30:23] (03PS2) 10Catrope: Auto-choose selected item when adding a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130767 (owner: 10Trevor Parscal) [23:30:55] (03CR) 10Catrope: [C: 032] Add getLookupMenu method to LookupInputWidget mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/130746 (owner: 10Trevor Parscal) [23:31:55] (03Merged) 10jenkins-bot: Add getLookupMenu method to LookupInputWidget mixin [oojs/ui] - 10https://gerrit.wikimedia.org/r/130746 (owner: 10Trevor Parscal) [23:32:46] (03Merged) 10jenkins-bot: Restyle parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129856 (https://bugzilla.wikimedia.org/53612) (owner: 10Trevor Parscal) [23:33:41] (03PS1) 10Catrope: Update OOjs UI to v0.1.0-pre (bdbb9cfa55) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130773 [23:37:12] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.1.0-pre (bdbb9cfa55) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130773 (owner: 10Catrope) [23:38:27] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (bdbb9cfa55) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130773 (owner: 10Catrope) [23:38:30] 3VisualEditor / 3Mobile: VisualEditor Mobile: App is redirecting to Google while trying to save a page in mobile - 10https://bugzilla.wikimedia.org/64686 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3Juliusz Gonera Created attachment 15259 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15259&actio... [23:39:29] 3VisualEditor / 3Mobile: VisualEditor Mobile: App is redirecting to Google while trying to save a page in mobile - 10https://bugzilla.wikimedia.org/64686#c1 (10ryasmeen) Created attachment 15260 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15260&action=edit for Firefox [23:40:40] (03PS1) 10Catrope: Update VE core submodule to master (e1a7f67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130778 [23:40:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Citation dialog does not focus correct field when adding a new parameter - 10https://bugzilla.wikimedia.org/64098 (10James Forrester) 5ASS>3RES/FIX [23:40:58] 3VisualEditor / 3Editing Tools: VisualEditor: In the transclusion dialog's panel for a parameter, use "Param#deprecated" from TemplateData - 10https://bugzilla.wikimedia.org/53612 (10James Forrester) 5PAT>3RES/FIX [23:41:08] (03PS5) 10Catrope: [BREAKING CHANGE] Show matched string in LanguageSearchWidget results [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129584 (owner: 10Esanders) [23:41:44] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (e1a7f67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130778 (owner: 10Catrope) [23:44:17] (03PS2) 10Jforrester: Style the FormatTool to be more like Vector's new look [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 (https://bugzilla.wikimedia.org/63540) (owner: 10Catrope) [23:45:22] (03Merged) 10jenkins-bot: Update VE core submodule to master (e1a7f67) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130778 (owner: 10Catrope) [23:52:02] (03PS2) 10Jforrester: Style external links and their suggestions with the right color [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130769 (https://bugzilla.wikimedia.org/38726) (owner: 10Catrope) [23:52:13] 3VisualEditor: External link with embedded comment is not shown correctly - 10https://bugzilla.wikimedia.org/62450#c1 (10James Forrester) 5NEW>3RES/WOR This appears to now work. [23:54:00] (03PS9) 10Jforrester: Remove media item styling moved to MW-core in I400336c12d. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115533 (owner: 10Mooeypoo) [23:55:04] James_F: I can't find an example of where hhvm tests are taking 7 minutes, help a brother out? [23:55:14] eg: https://gerrit.wikimedia.org/r/#/c/130774/ no hhvm test I can see [23:55:33] grrrit-wm: They only run for changes that touch PHP. [23:55:35] Erm. [23:55:52] greg-g: They only run for changes that touch PHP. Hashar and Krinkle like speed. :-) [23:55:59] sensible [23:56:11] greg-g: https://gerrit.wikimedia.org/r/#/c/119941/ for instance. [23:56:47] greg-g: The tests runs in parallel, so hhvm becomes the delay for all of them. [23:57:17] aha! [23:57:19] ty [23:58:32] greg-g: Not a huge complaint, just a minor grumble about so much server time being spent checking hhvm compatibility. [23:58:58] yep [23:59:39] They do run in parallel, but right now hhvm ironically runs slower than php, so it outlives the other concurrent jobs [23:59:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=64687