[00:00:14] thus noticably slowing it down, but it's not slowing the other jobs down, it just slows itself down, and gerrit doesn't get a vote until all jobs are finished. [00:00:30] * greg-g nods [00:04:28] 3VisualEditor / 3Mobile: VisualEditor Mobile: Mobile VE is redirecting to Google while trying to save a page - 10https://bugzilla.wikimedia.org/64686 (10ryasmeen) [00:07:10] greg-g: Thanks! [00:07:19] np [00:10:14] (03CR) 10Catrope: [C: 032] Auto-choose selected item when adding a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130767 (owner: 10Trevor Parscal) [00:11:24] (03PS3) 10Catrope: Auto-choose selected item when adding a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130767 (https://bugzilla.wikimedia.org/64334) (owner: 10Trevor Parscal) [00:12:00] (03CR) 10Catrope: [C: 032] Auto-choose selected item when adding a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130767 (https://bugzilla.wikimedia.org/64334) (owner: 10Trevor Parscal) [00:13:57] (03Merged) 10jenkins-bot: Auto-choose selected item when adding a template [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130767 (https://bugzilla.wikimedia.org/64334) (owner: 10Trevor Parscal) [00:22:44] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334 (10James Forrester... [00:23:37] (03PS3) 10Catrope: Style the FormatTool to be more like Vector's new look [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 (https://bugzilla.wikimedia.org/63540) [00:24:44] (03CR) 10Catrope: [C: 032] Style external links and their suggestions with the right color [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130769 (https://bugzilla.wikimedia.org/38726) (owner: 10Catrope) [00:26:43] (03Merged) 10jenkins-bot: Style external links and their suggestions with the right color [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130769 (https://bugzilla.wikimedia.org/38726) (owner: 10Catrope) [00:30:31] (03PS4) 10Jforrester: Style the FormatTool to be more like Vector's new look [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 (https://bugzilla.wikimedia.org/63540) (owner: 10Catrope) [00:30:40] (03CR) 10jenkins-bot: [V: 04-1] Style the FormatTool to be more like Vector's new look [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 (https://bugzilla.wikimedia.org/63540) (owner: 10Catrope) [00:31:14] 3VisualEditor / 3ContentEditable: VisualEditor: Links should follow the local CSS rules as if they were rendered in the view mode (e.g. external links shown with the external icon) - 10https://bugzilla.wikimedia.org/38726 (10James Forrester) 5PAT>3RES/FIX a:3James Forrester [00:40:56] (03PS5) 10Jforrester: Style the FormatTool to be more like Vector's new look [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 (https://bugzilla.wikimedia.org/63540) (owner: 10Catrope) [00:43:13] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf2] "Undo" button remains disabled through out the edit session in Betalabs - 10https://bugzilla.wikimedia.org/64194#c4 (10ryasmeen) Verified the fix on test2 [01:03:28] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644#c3 (10ryasmeen) 5RES/FIX>3REO This is not fixed in Betalabs or Test 2.I can still reproduce this one on both the environments. [01:05:58] 3VisualEditor / 3ContentEditable: VisualEditor: The bullet point does not show up in CE when it contains an image with a block slug - 10https://bugzilla.wikimedia.org/64117#c5 (10ryasmeen) Verified the fix on test2 [01:06:10] (03PS1) 10Catrope: Make reference list dialog small again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130796 (https://bugzilla.wikimedia.org/64670) [01:07:02] James_F|Away: ---^^ [01:26:46] (03PS1) 10Catrope: Move toolbar updateState code into separate method [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130802 [01:26:59] (03Abandoned) 10Catrope: Move toolbar updateState code into separate method [VisualEditor/VisualEditor] (refs/wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130802 (owner: 10Catrope) [01:27:11] (03PS1) 10Catrope: Move toolbar updateState code into separate method [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130803 [01:27:13] (03PS1) 10Catrope: Always fix up selection after ce.Surface#focus [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130804 (https://bugzilla.wikimedia.org/64399) [01:28:22] (03CR) 10jenkins-bot: [V: 04-1] Always fix up selection after ce.Surface#focus [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130804 (https://bugzilla.wikimedia.org/64399) (owner: 10Catrope) [01:28:25] (03CR) 10jenkins-bot: [V: 04-1] Move toolbar updateState code into separate method [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130803 (owner: 10Catrope) [01:29:54] (03CR) 10Catrope: [C: 032 V: 032] Always fix up selection after ce.Surface#focus [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130804 (https://bugzilla.wikimedia.org/64399) (owner: 10Catrope) [01:30:11] (03CR) 10Catrope: [C: 032 V: 032] Move toolbar updateState code into separate method [VisualEditor/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130803 (owner: 10Catrope) [01:31:43] (03PS1) 10Catrope: Update VE core for cherry-picked Firefox focus fixes [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130805 [01:32:11] James_F|Away: https://gerrit.wikimedia.org/r/130805 awaits you, oh glorious one [01:32:22] James_F|Away: Probably don't +2 it, but add it to SWAT? [01:43:11] (03CR) 10Jforrester: [C: 032] Make reference list dialog small again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130796 (https://bugzilla.wikimedia.org/64670) (owner: 10Catrope) [01:45:58] 3VisualEditor / 3Mobile: VisualEditor Mobile: Mobile VE is redirecting to Google while trying to save a page - 10https://bugzilla.wikimedia.org/64686#c2 (10Jon) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 60848 *** [01:45:59] (03Merged) 10jenkins-bot: Make reference list dialog small again [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130796 (https://bugzilla.wikimedia.org/64670) (owner: 10Catrope) [01:47:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Reference list dialog is no longer "small" size, but default "large" - 10https://bugzilla.wikimedia.org/64670 (10James Forrester) 5PAT>3RES/FIX a:3Roan Kattouw [02:15:58] 3VisualEditor / 3ContentEditable: VisualEditor: Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399 (10James Forrester) 5PAT>3RES/FIX [09:59:46] (03PS5) 10Esanders: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 [09:59:48] (03PS3) 10Esanders: Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 [10:01:06] (03CR) 10jenkins-bot: [V: 04-1] Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [10:01:12] (03CR) 10jenkins-bot: [V: 04-1] Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [11:05:00] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644#c4 (10Ed Sanders) Works for me. [11:05:40] (03PS1) 10Esanders: Use correct fragment in windows [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130820 [12:36:07] (03PS1) 10Esanders: Remove '*' selector for protected nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130823 (https://bugzilla.wikimedia.org/52499) [12:38:36] (03PS2) 10Esanders: Remove '*' selector for protected nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130823 (https://bugzilla.wikimedia.org/52499) [14:34:35] * hexmode waits for people to pop into reality [15:08:59] (03CR) 10Manybubbles: [C: 032] Update VE core for cherry-picked Firefox focus fixes [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130805 (owner: 10Catrope) [15:10:36] (03Merged) 10jenkins-bot: Update VE core for cherry-picked Firefox focus fixes [extensions/VisualEditor] (wmf/1.24wmf2) - 10https://gerrit.wikimedia.org/r/130805 (owner: 10Catrope) [15:47:43] (03CR) 10Krinkle: [C: 032] Remove '*' selector for protected nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130823 (https://bugzilla.wikimedia.org/52499) (owner: 10Esanders) [15:48:14] 3VisualEditor / 3ContentEditable: VisualEditor: Protected node css with * selector breaks some template layouts - 10https://bugzilla.wikimedia.org/52499#c2 (10Krinkle) Created attachment 15263 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15263&action=edit Screenshot of problem and patched version [15:48:48] (03Merged) 10jenkins-bot: Remove '*' selector for protected nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130823 (https://bugzilla.wikimedia.org/52499) (owner: 10Esanders) [15:50:52] (03CR) 10Krinkle: "Can you briefly describe (if/how) this can be reproduced as a bug (and this to verify what it fixes)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130820 (owner: 10Esanders) [16:03:43] (03Abandoned) 10Krinkle: dm.MWTemplateSpecModel: Remove broken deprecation description method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129857 (owner: 10Krinkle) [16:06:46] (03PS4) 10Krinkle: Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [16:06:55] (03PS6) 10Krinkle: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [16:07:00] (03PS7) 10Krinkle: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [16:07:15] (03CR) 10Krinkle: "Related MW core patch has been merged." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [16:07:28] (03CR) 10Krinkle: "Relevant VE core patch will need to be pulled through submodule update." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [16:08:08] (03CR) 10jenkins-bot: [V: 04-1] Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [16:08:40] (03CR) 10jenkins-bot: [V: 04-1] Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [16:15:02] 3VisualEditor: pulling in parsoid's new styling module breaks VE vagrant provisioned installation - 10https://bugzilla.wikimedia.org/64705 (10marielle.volz) 3UNC p:3Unprio s:3normal a:3None On clicking "edit", the visual editor progress bar continues indefinitely and visual editor never opens. The inst... [16:16:42] I'm assuming that it's local settings issue but figured I'd file a bug report anyway. [16:17:09] if it is maybe the vagrant provisioning code needs to be updated? we'll see. [16:27:24] mvolz: what is a local settings issue? Looks like part of the conversation is missing [16:32:52] (03CR) 10Esanders: "Failing because parent commit has dependency on core. Good to review." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [16:33:43] mvolz: I think that bug in the Vagrant image was fixed last night. [16:33:49] mvolz: Hunting for the commit now. [16:37:11] mvolz: gerrit 130556 – if you update the vagrant image does it now work? [16:42:05] whoops should have checked that! [16:42:33] mvolz: Sorry for the disruption. :-( [16:43:31] 3VisualEditor / 3ContentEditable: VisualEditor: Protected node css with * selector breaks some template layouts - 10https://bugzilla.wikimedia.org/52499 (10James Forrester) 5PAT>3RES/FIX a:3Ed Sanders [16:54:34] herm. now I'm getting ruby errors from vagrant. :/ but hey it's not a VE problem anymore! :) [16:54:46] * James_F grins. [17:00:55] (03PS1) 10Krinkle: test: Update qunitjs to v1.14.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/130860 [17:00:57] (03PS1) 10Krinkle: build: Use .txt extension for intro.js and outro.js [oojs/core] - 10https://gerrit.wikimedia.org/r/130861 [17:00:59] (03PS1) 10Krinkle: package.json: Update devDependencies (update jshint and jscs config) [oojs/core] - 10https://gerrit.wikimedia.org/r/130862 [17:01:01] (03PS1) 10Krinkle: jscs: Enable validateIndentation [oojs/core] - 10https://gerrit.wikimedia.org/r/130863 [17:03:00] 3VisualEditor / 3Editing Tools: VisualEditor: Copy wikiEditor's search-and-replace tool - 10https://bugzilla.wikimedia.org/48368#c8 (10Eran Roz) We have a first working draft for replace tool for VE: https://en.wikipedia.org/wiki/User:%D7%A2%D7%A8%D7%9F/veReplace.js It works and replace the specified text,... [17:22:10] (03PS2) 10Jforrester: jscs: Enable validateIndentation [oojs/core] - 10https://gerrit.wikimedia.org/r/130863 (owner: 10Krinkle) [17:22:33] (03CR) 10Jforrester: [C: 032] build: Use .txt extension for intro.js and outro.js [oojs/core] - 10https://gerrit.wikimedia.org/r/130861 (owner: 10Krinkle) [17:23:05] (03CR) 10Jforrester: [C: 032] test: Update qunitjs to v1.14.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/130860 (owner: 10Krinkle) [17:23:25] (03Merged) 10jenkins-bot: test: Update qunitjs to v1.14.0 [oojs/core] - 10https://gerrit.wikimedia.org/r/130860 (owner: 10Krinkle) [17:23:27] (03Merged) 10jenkins-bot: build: Use .txt extension for intro.js and outro.js [oojs/core] - 10https://gerrit.wikimedia.org/r/130861 (owner: 10Krinkle) [17:37:22] James_F|Away: Oh, right, wonky. [17:37:26] I can't seem to get Parsoid working... [17:37:35] Thx for saving that bit of oojs' decency [17:38:33] I'm using port 8142 instead of port 8000 which I guess is the reason - haven't worked this out but how I do tell MediaWiki this is where to look for Parsoid? [17:39:21] jdlrobson: Look for the setting in VisualEditor.php [17:39:28] Override in local settings [17:41:38] jdlrobson: How did you change Parsoid port though, with env.PORT? [17:42:06] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/VisualEditor.php#L1217-L1226 [17:42:07] https://github.com/wikimedia/mediawiki-services-parsoid/blob/master/api/localsettings.js.example#L19 [17:42:22] (03CR) 10Catrope: [C: 032] Use correct fragment in windows [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130820 (owner: 10Esanders) [17:43:16] Well my port 8000 is used so I have to change it [17:43:41] I followed instructions at https://www.mediawiki.org/wiki/Parsoid/Setup INTERFACE and PORT are terrible names btw ;-) [17:43:58] indeed [17:44:14] still not working for me though even with $wgVisualEditorParsoidURL = 'http://localhost:8142; [17:44:50] oh wait now it is [17:44:54] must have been caching problem [17:44:59] (03Merged) 10jenkins-bot: Use correct fragment in windows [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130820 (owner: 10Esanders) [17:46:04] jdlrobson, they are kind of standard env variable names [17:46:28] gwicke: is there a way to set them in a more generic fashion in my .profile ? [17:46:54] they are normally set in our deb, but we can't publish that yet as ops has not set up a repo yet [17:47:06] i don't want to add them each time and I don't want to add them in .profile :) [17:47:12] normally the config is in /etc/default/parsoid [17:47:52] there's hope that ops will find the time to do this in the next weeks [17:48:20] I could point you to a temporary repo though [17:49:01] gwicke: Would it be possible to expose an option in api/localSettings.js? [17:49:05] (for port) [17:49:24] That would allow a one-stop 1) localsettings, 2) npm start [17:49:57] Especially when multiple services are involved, PORT only works if you can set it on the same bash line, because if it's persistent, it;ll be misused by the wrong things [17:50:28] that's all only a problem if you aren't using a proper package [17:50:50] normally the init script or systemd handle this stuff for you [17:51:10] package? local development :) [17:51:35] ;) [17:51:48] you can always create a trivial shell wrapper or alias for that [17:52:05] Yes, or have it in localSettings so that you only need npm start. [17:52:16] Would you oppose adding that? I can submit a patch. [17:52:31] so would the env var still take precedence? [17:52:46] whatever you prefer [17:52:50] I wouldn't be using it [17:53:11] I'd say ENV is probably the override [17:53:40] I'm not sure -- let me get back to you [18:11:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Reference list dialog is no longer "small" size, but default "large" - 10https://bugzilla.wikimedia.org/64670#c4 (10ryasmeen) Verified the fix in Betalabs [18:30:12] (03CR) 10Siebrand: Bring the transclusion title back to life (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130749 (https://bugzilla.wikimedia.org/64671) (owner: 10Trevor Parscal) [18:32:45] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c4 (10Bryce Glover) Has this been fixed yet, or did everybody forget about me? [18:59:17] 3VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709 (10Jon) 3NEW p:3Unprio s:3normal a:3None Running JavaScript profiling on both desktop and mobile the majority of time is spent in jQuery.extend.css - the majority of which seems t... [19:14:00] 3VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c1 (10Jon) The majority of time is spent in looking up the float property but importNode is also a relatively big performance hog here [19:17:24] (03CR) 10Trevor Parscal: [C: 032] Add Agora theme dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [19:18:00] (03Merged) 10jenkins-bot: Add Agora theme dialogs [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [19:20:07] (03CR) 10Trevor Parscal: [C: 032] jscs: Enable validateIndentation [oojs/core] - 10https://gerrit.wikimedia.org/r/130863 (owner: 10Krinkle) [19:28:24] (03CR) 10Trevor Parscal: [C: 032] package.json: Update devDependencies (update jshint and jscs config) [oojs/core] - 10https://gerrit.wikimedia.org/r/130862 (owner: 10Krinkle) [19:28:48] (03Merged) 10jenkins-bot: package.json: Update devDependencies (update jshint and jscs config) [oojs/core] - 10https://gerrit.wikimedia.org/r/130862 (owner: 10Krinkle) [19:28:50] (03Merged) 10jenkins-bot: jscs: Enable validateIndentation [oojs/core] - 10https://gerrit.wikimedia.org/r/130863 (owner: 10Krinkle) [19:31:54] (03CR) 10Trevor Parscal: [C: 032] Style the FormatTool to be more like Vector's new look [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 (https://bugzilla.wikimedia.org/63540) (owner: 10Catrope) [19:32:13] TrevorParscal: On a roll today. :_0 [19:32:29] you get to high five the new ED? [19:33:04] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (301887f487) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130876 [19:33:34] TrevorParscal: Not quite. Just ask a really tough question on behalf of a colleague as my way of introduction. [19:33:43] (03Merged) 10jenkins-bot: Style the FormatTool to be more like Vector's new look [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130771 (https://bugzilla.wikimedia.org/63540) (owner: 10Catrope) [19:34:09] TrevorParscal: Can you verify that 130876 for VE-core (the Agora styling) doesn't break anything for VE? [19:34:18] I did [19:34:40] The split doesn't break anything? Wow. [19:34:54] it doesn't always break things [19:35:00] So the CSS/ClippableElement/i18n bug I mentioned earlier is https://bugzilla.wikimedia.org/show_bug.cgi?id=61149 [19:35:04] I was hoping to simply make some CSS so it can expand out to the left rather than squash to the side of the screen with a scrollbar [19:35:06] just sometimes but not always never [19:35:06] but, seems it's not so simple [19:35:11] TrevorParscal: :-) [19:35:41] Krenair: You mean the menu? [19:35:46] Krenair: nothing with ClippableElement is every simple [19:35:51] Krenair: Maybe make the item wrap instead? [19:35:53] browsers don't want you to succeed [19:36:48] TrevorParscal: Could you +2 https://gerrit.wikimedia.org/r/130879 and https://gerrit.wikimedia.org/r/130876 pull-throughs then? :-) [19:37:14] (03CR) 10Trevor Parscal: [C: 032] Update OOjs UI to v0.1.0-pre (301887f487) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130876 (owner: 10Jforrester) [19:37:27] yeah, the menu where you (mostly) select different parts of the meta dialog [19:37:34] TrevorParscal: Ta. :-) [19:37:41] * James_F nods. [19:37:41] or Switch to source, etc. [19:37:54] (03CR) 10Trevor Parscal: [C: 032] Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [19:38:01] If we do the save-button-with-menu-in-it that we talked about, I think we'd move Switch to Source there too. [19:38:06] (03CR) 10Trevor Parscal: [C: 032] [BREAKING CHANGE] Show matched string in LanguageSearchWidget results [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129584 (owner: 10Esanders) [19:38:35] So then the menu would entirely be settings things, and we might revisit it. [19:38:43] (03CR) 10Trevor Parscal: [C: 032] Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [19:39:45] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (301887f487) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130876 (owner: 10Jforrester) [19:39:47] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Show matched string in LanguageSearchWidget results [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/129584 (owner: 10Esanders) [19:39:49] (03CR) 10jenkins-bot: [V: 04-1] Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [19:39:57] (03CR) 10Trevor Parscal: [C: 04-1] "Still not sold on unset event" [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [19:41:27] (03CR) 10jenkins-bot: [V: 04-1] Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [19:41:29] (03CR) 10jenkins-bot: [V: 04-1] Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [19:41:51] (03PS1) 10Jforrester: Update VE core submodule to master (ca76a5b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130880 [19:42:37] (03CR) 10Trevor Parscal: "Happy with retaining set(item|null) event, but the use of a closure is abnormal and probably not necessary given you are passing the layou" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [19:42:56] (03CR) 10Trevor Parscal: [C: 032] Update VE core submodule to master (ca76a5b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130880 (owner: 10Jforrester) [19:44:15] 3VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709 (10Nemo) [19:45:00] (03Merged) 10jenkins-bot: Update VE core submodule to master (ca76a5b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130880 (owner: 10Jforrester) [19:45:00] 3VisualEditor: VisualEditor: Performance issues (tracker) - 10https://bugzilla.wikimedia.org/49685 (10James Forrester) [19:45:02] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototy pe.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709 (10James Forrester) 5NEW>3ASS p:5Unprio>3High a:3Trevor Parscal [19:45:20] TrevorParscal: Could you look at https://bugzilla.wikimedia.org/show_bug.cgi?id=64709 (phantoms being slow, news at 11) if you have a momemt? [19:50:28] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Cleanup widget focus/select/clear methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 (owner: 10Trevor Parscal) [19:50:56] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Cleanup widget focus/select/clear methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/130417 (owner: 10Trevor Parscal) [19:54:11] (03PS4) 10Jforrester: Update OOjs UI to v0.1.0-pre (e6edd86d37) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130404 (owner: 10Trevor Parscal) [20:05:08] James_F: ugh... phantoms are slow... It's a giant hack! of course they are :( [20:05:13] Need to use SVG overlay [20:05:27] but I would need to have a block of time to dedicate to that [20:05:32] TrevorParscal: Yeah; there's a bug asking for that that Krinkle|detached cookie-licked a long time ago. [20:05:56] TrevorParscal: If you need the time to focus, you need the time. Performance is important. :-) [20:07:29] yes, we need to schedule it [20:07:47] like, I have this idea, but I need to schedule a good time to do it [20:09:31] Is now good? [20:10:15] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c2 (10Trevor Parscal) There may be ways to improve this in the short term, but what we really need to do is experiment with using an SVG overlay. [20:12:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: Update styling of the MW format paragraph menu to match changes to Vector - 10https://bugzilla.wikimedia.org/63540 (10James Forrester) 5PAT>3RES/FIX a:3James Forrester [20:14:45] 3VisualEditor / 3Editing Tools: VisualEditor: Copy wikiEditor's search-and-replace tool - 10https://bugzilla.wikimedia.org/48368#c9 (10James Forrester) (In reply to Eran Roz from comment #8) > We have a first working draft for replace tool for VE: > https://en.wikipedia.org/wiki/User:%D7%A2%D7%A8%D7%9F/veRep... [20:14:47] 3VisualEditor: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - 10https://bugzilla.wikimedia.org/64712 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Intention: Edit an existing citation. Steps to... [20:17:16] 3VisualEditor / 3Editing Tools: VisualEditor: Copy wikiEditor's search-and-replace tool - 10https://bugzilla.wikimedia.org/48368 (10James Forrester) a:3Eran Roz [20:18:45] 3VisualEditor / 3ContentEditable: VisualEditor: Draw shields using SVG polygons and getClientRect(s) for inline/block items - 10https://bugzilla.wikimedia.org/51202 (10James Forrester) [20:18:45] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709 (10James Forrester) [20:19:00] 3VisualEditor / 3ContentEditable: VisualEditor: Draw shields using SVG polygons and getClientRect(s) for inline/block items - 10https://bugzilla.wikimedia.org/51202 (10James Forrester) [20:19:00] 3VisualEditor: VisualEditor: Performance issues (tracker) - 10https://bugzilla.wikimedia.org/49685 (10James Forrester) [20:20:46] Krinkle: Heya. [20:22:44] TrevorParscal: Do you think it's something Ed could take on? [20:25:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switch to use MediaWiki's built-in messages for post-edit notifications (and add to them so we cover all three cases) - 10https://bugzilla.wikimedia.org/52871#c3 (10James Forrester) 5PAT>3ASS Now just needs VE to use the same function. [20:29:53] James_F, looked into making that text wrap... I found I could set the white-space property on the tool title [20:30:09] found word-break: break-word;, this only makes things look worse [20:30:25] Krenair: My favourite bit of CSS. [20:33:17] James_F, I'm thinking someone else should do this... CSS like this isn't really my thing and there's not much MediaWiki involvement in this bug [20:34:10] * James_F nods. [20:34:17] Sure, sling it back into the pool. [20:34:30] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c3 (10Juliusz Gonera) The question is, why is this more of a problem with mobile skin than with Vector? [20:35:45] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - 10https://bugzilla.wikimedia.org/64712 (10James Forrester) 5NEW>3ASS p:5Unprio>3High [20:38:30] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c4 (10Jon) We have a lot more DOM nodes in mobile - 2 times the number of DOM nodes in an article. In desktop they replace the page rather than create a... [20:41:47] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool should not add empty citation templates - 10https://bugzilla.wikimedia.org/64715 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Citation > Cite web 2. Don't add any information. Just click "Apply changes". Resul... [20:44:45] 3VisualEditor / 3MediaWiki integration: VisualEditor: Resize text in Option menu or put it on two lines if too long - 10https://bugzilla.wikimedia.org/61149#c3 (10Alex Monk) I spent a while looking into this. I gave up but here is what I found anyway First of all I tried to make it expand outwards instead o... [20:49:15] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c5 (10Jon) So I tried removing #content element - no visible difference. Killing our stylesheets - visible difference (drops 1.59%). This must be linke... [20:52:45] (03PS1) 10Alex Monk: Switch to use MediaWiki's built-in messages for post-edit notifications [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130968 (https://bugzilla.wikimedia.org/52871) [20:55:45] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c6 (10Jon) Specifically it is a style or styles in one of these modules: http://localhost.alpha/w/load.php?debug=false&lang=en&modules=mediawiki.ui.butt... [21:03:17] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644#c5 (10ryasmeen) Not for me still though,I am giving the steps again : 1.Open the editor 2.Open the math inspector 3.Put the cursor inside... [21:08:10] James_F, had to fiddle around with the required libraries so the FancyCaptcha setup script would work. But it certainly seems to work fine with VE (in reply to https://bugzilla.wikimedia.org/show_bug.cgi?id=64328#c6 ) [21:08:32] 3VisualEditor / 3Editing Tools: VsualEditor: Changing a citation i the citation tool creates a second citation (one copy of old version, one copy of new version) - 10https://bugzilla.wikimedia.org/64717 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Intention: Fix the URL in a citation Steps to... [21:10:08] Krenair: So happy to mark as FIXED? [21:10:15] Krenair: (Yay.) [21:10:23] I did look into the other types of ConfirmEdit captchas (Asirra and ReCaptcha), I think those had complex external libraries we'd need to put into VE somehow. [21:11:03] James_F, yep [21:12:15] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool opens if you click the icon, but if you double-click the ref or press the return key, the Reference dialog opens instead - 10https://bugzilla.wikimedia.org/64712#c1 (10WhatamIdoing) Once you're inside the Reference dialog, if you double-click the c... [21:15:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add support for more types of ConfirmEdit captcha - 10https://bugzilla.wikimedia.org/64328#c7 (10James Forrester) 5ASS>3RES/FIX From Alex: Yes. [21:33:18] 3VisualEditor: VisualEditor: You shouldn't be able to set bold or other text attributes for ref tags - 10https://bugzilla.wikimedia.org/64718 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Steps to Reproduce: 1. Select a ref tag. 2. Click on bold in the character formatting menu. Actual Result... [21:33:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: Override of doesn't respect DISPLAYTITLE - 10https://bugzilla.wikimedia.org/49667#c3 (10Alex Monk) If I'm right that it's consistent with core, this bug should be moved there. [21:38:00] <wikibugs> 3VisualEditor: VisualEditor: You shouldn't be able to set bold or other text attributes for ref tags - 10https://bugzilla.wikimedia.org/64718#c1 (10WhatamIdoing) It's not just refs: templates, hieroglyphics, galleries, math equation... Not images, though. http://en.wikipedia.beta.wmflabs.org/w/index.php?tit... [21:46:15] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c7 (10Jon) I went deeper down the rabbit hole... Removing all button styling drops this by 23.76% to 16.4% It drops to 8.6% with removal of 'skins.min... [22:03:32] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: The textbox for Alternative text overlaps with the border of the Media Settings dialog in Firefox - 10https://bugzilla.wikimedia.org/64723 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15270 --> https://bugzilla.wikimedia.org/attachme... [22:16:40] <grrrit-wm> (03CR) 10Krinkle: StackLayout: Clean up inconsistent event firing and documentation (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 (owner: 10Krinkle) [22:22:30] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Changing a citation i the citation tool creates a second citation (one copy of old version, one copy of new version) - 10https://bugzilla.wikimedia.org/64717 (10Andre Klapper) [22:35:25] <grrrit-wm> (03CR) 10Jforrester: [C: 032] Switch to use MediaWiki's built-in messages for post-edit notifications [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130968 (https://bugzilla.wikimedia.org/52871) (owner: 10Alex Monk) [22:37:13] <grrrit-wm> (03Merged) 10jenkins-bot: Switch to use MediaWiki's built-in messages for post-edit notifications [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130968 (https://bugzilla.wikimedia.org/52871) (owner: 10Alex Monk) [22:55:28] <TrevorParscal> James_F|Away: which bug was needing CSS love, you were talking to Krenair about it earlier... [22:55:53] <Krenair> https://bugzilla.wikimedia.org/show_bug.cgi?id=61149 [23:05:16] <jgonera> TrevorParscal, are you guys in the office tomorrow? [23:18:48] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor:Headings are getting overlapped by the image and the preformatted text is appearing on the image - 10https://bugzilla.wikimedia.org/64725 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15271 --> https://bugzilla.wikimedia.org/attachment... [23:23:50] <TrevorParscal> Krenair: thanks, I'm working on it now [23:35:54] <TrevorParscal> So... trying to solve bug 61149, and i've got to a point where ClippableElement is fighting itself http://cl.ly/2g3F3k2w2B1m [23:37:16] <wikibugs> 3VisualEditor / 3MediaWiki integration: VisualEditor: Switch to use MediaWiki's built-in messages for post-edit notifications (and add to them so we cover all three cases) - 10https://bugzilla.wikimedia.org/52871 (10Alex Monk) 5PAT>3RES/FIX [23:45:46] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf2] "Undo" button remains disabled through out the edit session in Betalabs - 10https://bugzilla.wikimedia.org/64194#c5 (10ryasmeen) 5RES/?>3VER Verified the fix on https://en.wikipedia.org/wiki/User:RYasmeen_%28WMF%29/sandbox?veaction=edit [23:47:16] <wikibugs> 3VisualEditor / 3ContentEditable: VisualEditor: The bullet point does not show up in CE when it contains an image with a block slug - 10https://bugzilla.wikimedia.org/64117#c6 (10ryasmeen) 5RES/?>3VER Verified the fix in production. [23:49:46] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Math inspector does not check type of node it's inspecting - 10https://bugzilla.wikimedia.org/56645#c9 (10ryasmeen) 5RES/?>3VER Verified the fix on production [23:51:00] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Inserting a formula into a block slug throws "Uncaught TypeError: Cannot call method 'getOuterRange' of null" - 10https://bugzilla.wikimedia.org/58286#c12 (10ryasmeen) 5RES/?>3VER Verified the fix in production [23:53:34] <jgonera> TrevorParscal, are you guys in the office tomorrow? copy [23:54:17] <wikibugs> 3VisualEditor / 3Editing Tools: VisualEditor: Creating a formula/hieroglyphics insert while selecting an image tries to modify the caption, dies - 10https://bugzilla.wikimedia.org/58045#c7 (10ryasmeen) 5RES/?>3VER Verified the fix in production [23:59:46] <TrevorParscal> jgonera: I am