[00:14:53] TrevorParscal, question (if it's too complicated then tomorrow): I imported Cite_* templates and created the json page but VE doesn't show any parameters for any of the templates in the citation dialog. any idea why that might be? [00:16:05] do you have TemplateData installed? [00:18:46] TrevorParscal, is it part of vagrant? [00:19:27] TrevorParscal, doesn't seem like it [00:19:30] hm [00:21:31] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267#c6 (10ryasmeen) Verified the fix in test2 [00:24:27] TemplateData is an extension that reads the tags the community writes for templates to describe parameters [00:24:45] if you don't have the extension, you won't get any info about the template [00:25:01] it's accessed through an API call when you open a template dialog [00:25:15] TrevorParscal, is this extension only for VE? we're wondering with ori if it should be included in VE vagrant role [00:25:15] the data is loaded into ve.dm.MWTemplateSpecModel [00:25:31] it's not VE specific, but we are the only people I know of using it [00:25:34] it's maintained by Timo [00:25:45] it should be included, yes [00:25:53] if it's not, that's an oversight [00:26:07] there's also a Parsoid extension that is needed to style Parsoid content properly [00:26:15] that was very recently added [00:26:48] and nobody updated the VE role with it? [00:26:58] or the parsoid role [00:27:02] well, I'll check [00:27:03] thanks [00:32:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] While trying to open Hiero/Math/Gallery inspector TypeError:Cannot read property 'forcedLtr' of undefined appears in the console - 10https://bugzilla.wikimedia.org/64072#c9 (10ryasmeen) 5RES/?>3VER Verified the fix in production [00:33:00] jgonera: I don't know who is managing those, but someone needs to be laughed and and/or buy other people lunch [00:33:09] (that's how we do it on the VE team) [00:36:16] 3VisualEditor / 3Mobile: VisualEditor: [Regression wmf1] Uncaught Error: ve.dm.Document.getNodeFromOffset(): offset 339 is out of bounds is appearing in Mobile VE after reopening a page for the second time and hitting return twice - 10https://bugzilla.wikimedia.org/64034#c5 (10ryasmeen) 5RES/?>3VER verif... [00:40:49] jgonera, TrevorParscal: IIRC vagrant is fixed; we are also moving that module into core so hopefully by next week the Parsoid extension won't be necessary any more to use VE [00:41:04] ok, cool [00:41:09] gwicke, thank, yes, the extension is part of parsoid role [00:41:22] TrevorParscal, ori added TemplateData to VE role [00:41:31] cool - is it working now? [06:57:00] 3VisualEditor: VisualEditor: quotation marks added via special characters tool don't work as expected - 10https://bugzilla.wikimedia.org/63227#c1 (10Juan de Vojníkov) I confirm this at cs.wp. For the Czech „“ its common, to select a word click on spacial character button and insert quotatin marks arround. [07:01:15] 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool breaks in Firefox - 10https://bugzilla.wikimedia.org/50822#c6 (10Matthew Flaschen) I have issues with this locally as well (Iceweasel/Firefox 24.4.0 with VE 3b3a66763ade397b857e35efe8990ac217e5d54c , in debug mo... [11:01:12] (03PS11) 10Krinkle: StackLayout: Clean up inconsistent event firing and documentation [oojs/ui] - 10https://gerrit.wikimedia.org/r/127408 [11:44:15] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c5 (10Andre Klapper) (In reply to Bryce Glover from comment #4) > Has this been fixed yet If it was fixed, the status of this ticket was RESOLVED FIXED. As long as only o... [12:58:54] (03CR) 10Esanders: "Needs core pullthrough" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [13:06:06] (03PS8) 10Esanders: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 [13:06:08] (03PS5) 10Esanders: Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 [13:22:38] (03CR) 10Esanders: [C: 032] "per Trevor" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [13:22:49] (03CR) 10Esanders: [C: 032] "per Trevor" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [13:24:20] (03Merged) 10jenkins-bot: Add LanguageResultWidget files [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129588 (owner: 10Esanders) [13:24:40] (03Merged) 10jenkins-bot: Use new mediawiki.language.names module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129625 (owner: 10Esanders) [15:24:05] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644#c6 (10Ed Sanders) Working fine locally and on beta labs with a blank page. Chrome && FF [15:34:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] Changing a citation in the citation tool inserts a new citation, doesn't replace the old one - 10https://bugzilla.wikimedia.org/64717 (10James Forrester) 5NEW>3ASS p:5Unprio>3Highes s:5normal>3major a:3Ed Sanders [15:35:19] Hey. [15:35:23] edsanders: ^^^ That bug is nasty and presumably trivial? [15:46:26] apparently [15:50:07] (03PS1) 10Esanders: Fix typo: this.transclusionNode -> this.selectedNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131065 (https://bugzilla.wikimedia.org/64717) [15:51:05] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c6 (10James Forrester) Sorry for the brief delay. I am unable to reproduce this for default-setup users on the English Wikipedia in Safari 7.0.3, in default Vector or Mono... [15:51:15] Hah. Nice fix. [16:13:05] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644#c7 (10James Forrester) 5REO>3ASS Indeed; but not on a non-blank page. Minimum test: * Open VE on new (blank) page * Enter "a", 3VisualEditor / 3Editing Tools: VisualEditor: Math Inspector icon and Link inspector icon appears together on a Math formula which has link applied on it - 10https://bugzilla.wikimedia.org/60850#c1 (10James Forrester) 5NEW>3RES/INV This is expected behaviour. [16:25:08] So I have https://bugzilla.wikimedia.org/show_bug.cgi?id=50518 and https://bugzilla.wikimedia.org/show_bug.cgi?id=61500 left on my list [16:26:04] For the second one: Meh, docs for that are a good idea but it's boring [16:27:02] For the first one: I guess we should measure the time it takes to do some expensive process, then display a notice if it took long enough [16:28:58] Krenair: For 61500 my thinking was that you had the freshest eyes to how VE integrates, and also quite a bit of experience of actually tweaking skins compared to e.g. Ed. [16:29:21] Krenair: For 50518 did Krinkle give you any pointers? [16:29:24] Tweaking skins? Ehh... I guess [16:29:36] I did do that stuff with tabs [16:29:55] James_F, I think he did, but I didn't note down what he said [16:30:16] * James_F nods. [16:30:19] Ha. [16:30:26] should really have talked on IRC instead [16:34:49] (03PS1) 10Krinkle: ve.init.mw.ViewPageTarget: Actually animate the toolbar during setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131071 [16:34:54] Hm. It may have been a bad idea to start upgrading Ubuntu on my laptop this close to a hangout [16:36:28] Krenair: :-) [16:36:35] Krenair: The siren call of 14.04? [16:37:25] yeah, 14.04 [16:44:50] 3VisualEditor / 3Data Model: VisualEditor: Link inspector dirties links, causes dirty diffs for links with underscores - 10https://bugzilla.wikimedia.org/62229 (10Ed Sanders) [16:45:06] (03PS2) 10Krinkle: ve.init.mw.ViewPageTarget: Actually animate the toolbar during setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131071 (https://bugzilla.wikimedia.org/64751) [16:45:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: Transition between read mode and edit mode should have minimal visual shifts - 10https://bugzilla.wikimedia.org/64751 (10Krinkle) p:5Unprio>3Normal a:3Krinkle [16:45:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: Transition between read mode and edit mode should have minimal visual shifts - 10https://bugzilla.wikimedia.org/64751 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Issues right now: * Different set of elements (e.g. #contentSub is shown in read mo... [16:46:18] (03PS1) 10Krinkle: ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) [16:47:56] (03CR) 10Jforrester: ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) (owner: 10Krinkle) [16:48:14] edsanders: Any chance you could work on the ToC position stuff? [16:49:02] (03CR) 10Krinkle: ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) (owner: 10Krinkle) [16:51:15] (03PS1) 10Krinkle: [WIP] Demo refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131078 [16:52:06] (03PS2) 10Krinkle: ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) [16:53:42] James_F: Check out https://gerrit.wikimedia.org/r/131078, switch to "Read" mode, open "Simple", then switch to 'edit'. I got scroll preserve working despite the toolbar and surface wrapper being there. Looks entirely spotless on my machine, no visual difference. [16:54:04] Only problem though, because it is forced to scroll down, you no longer see the menu after that. [16:54:21] it just dissapears [16:58:36] (03CR) 10Alex Monk: [C: 04-1] "Looks like this just needs a rebase now" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [17:15:38] (03CR) 10Krinkle: "Sounds like a good reason to stop storing this in message store, and instead abstract it out, and maybe populate it from mw.msg in MW inte" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118621 (owner: 10Trevor Parscal) [17:16:05] (03CR) 10Krinkle: "(no longer rebases cleanly)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/114899 (owner: 10Trevor Parscal) [17:17:48] (03PS2) 10Krinkle: Allow users to set whether a page is for Disambiguation or not [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [17:20:08] Krinkle: so, are you still using DocBlockr? [17:20:37] and if so, how are you configuring it? [17:21:29] yeah, I was going to disable it becuase of all its bugs [17:21:42] but then earlier today I pressed Return in an // inline comment , and it didn't insert // [17:21:46] that totally killed me after 3 times [17:21:48] so I re-enabled it [17:22:59] do you have any special config for it? [17:25:18] edsanders, I can't actually reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=64717 [17:28:06] TrevorParscal, I noticed that if I make a link in the reference dialog (or edit an existing one) then the box is far too wide [17:28:56] (03CR) 10Jforrester: [C: 032] ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) (owner: 10Krinkle) [17:29:17] edsanders, oh wait, citations not references. my bad [17:29:39] Krenair: that was a bug we solved like last week [17:29:49] had to do with styles not using child selector when they should have [17:30:47] was the fix merged? [17:31:01] yeah, pretty sure [17:31:07] hm [17:31:10] I thought I just updated everything [17:31:27] you have to update mediawiki too [17:31:35] cause OOUI is pulled from MW not VE [17:32:27] hm, nope, mediawiki is up-to-date [17:32:59] gah, what. somehow VE master was out of date. When I pulled earlier I must've been on some other branch [17:34:00] TrevorParscal, well MW and VE are up-to-date and I still see the issue [17:35:40] Krenair: Hard refresh to be sure? [17:36:48] still get the issue [17:37:01] going to have dinner now [17:37:44] TrevorParscal: Please review https://gerrit.wikimedia.org/r/#/c/131065/1 [17:40:05] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267#c7 (10ryasmeen) Verified the fix in production [17:41:01] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e6edd86d37) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130404 (owner: 10Trevor Parscal) [17:41:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: "Uncaught TypeError: Object # has no method 'saveDocument' " appears while trying to save a page which was idle for a while - 10https://bugzilla.wikimedia.org/64267 (10ryasmeen) 5RES/?>3VER [17:44:12] Krinkle: What does $wgTemplateDataUseGUI do? [17:44:28] kaldari: Experimental JS interface to edit JSON in a jQuery UI dialog [17:44:36] not ready for production at the moment [17:44:46] ah, that'll be cool [17:53:49] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e6edd86d37) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/130404 (owner: 10Trevor Parscal) [17:54:19] (03CR) 10jenkins-bot: [V: 04-1] ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) (owner: 10Krinkle) [17:56:35] (03CR) 10Catrope: [C: 032] ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) (owner: 10Krinkle) [18:01:06] (03CR) 10Catrope: [C: 032] Fix typo: this.transclusionNode -> this.selectedNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131065 (https://bugzilla.wikimedia.org/64717) (owner: 10Esanders) [18:01:19] (03PS1) 10Jforrester: Fix typo: this.transclusionNode -> this.selectedNode [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131091 (https://bugzilla.wikimedia.org/64717) [18:02:53] James_F: So I tried to look into that change that Roan just merged earlier [18:03:01] But couldn't actually find the citation dialog [18:03:17] Krinkle: In https://gerrit.wikimedia.org/r/131078 it's not quite right, but it's lovely to see,. [18:03:38] (03Merged) 10jenkins-bot: ve.init.mw.ViewPageTarget: Hide #contentSub in addition to #toc when muted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131074 (https://bugzilla.wikimedia.org/64751) (owner: 10Krinkle) [18:04:32] Krenair: It only activates if you set a MediaWiki: message. [18:04:42] Krenair: See en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit [18:05:27] Ah, that'll be why. okay [18:05:35] Is that documented anywhere? [18:05:56] Not yet. [18:06:04] Something for me to do this week. [18:08:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: Transition between read mode and edit mode should have minimal visual shifts - 10https://bugzilla.wikimedia.org/64751 (10James Forrester) [18:13:03] (03Merged) 10jenkins-bot: Fix typo: this.transclusionNode -> this.selectedNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131065 (https://bugzilla.wikimedia.org/64717) (owner: 10Esanders) [18:13:45] (03PS1) 10Cmcmahon: [browser test] demo for Roan of ?veaction=edit issue for FF [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131096 [18:14:02] (03CR) 10Cmcmahon: [C: 04-2] [browser test] demo for Roan of ?veaction=edit issue for FF [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131096 (owner: 10Cmcmahon) [18:20:27] RoanKattouw: Want to quick up-down vote on https://gerrit.wikimedia.org/r/#/c/114984/ ? [18:22:40] James_F: +1ed [18:26:07] 3OOjs UI: Auto-disabled tool group still responds to clicks - 10https://bugzilla.wikimedia.org/64759 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3None * Go to the tools demo * Click "auto-disabling list" * Click "click to disable this tool" * "auto-disabling list" now appears greyed out * Click "auto-d... [18:26:57] RoanKattouw, did you order full size SIMs? [18:27:15] Yes [18:27:29] Freakishly, my mom and her partner both have smartphones that take full size SIMs [18:27:42] weird [18:27:49] also each packets contains two SIMs [18:27:54] I was incredulous myself but she sent me pictures and model numbers and crap and it checks out perfectly for at least one of their phones [18:27:56] Ahm, wat? [18:27:58] Why 2 [18:27:59] (different numbers) [18:28:02] so you have 4 [18:28:05] So now I have 4? [18:28:07] * edsanders shrugs [18:28:07] wtf [18:28:11] I ordered one, twice [18:28:15] Whatever [18:28:37] 3VisualEditor: VisualEditor: Sometimes pasting text into a page results in only part of the text appearing. - 10https://bugzilla.wikimedia.org/64760 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Intention: Paste some text into a page. Steps to Reproduce: 1. Discover some blanking in an article; c... [18:31:37] 3VisualEditor / 3Editing Tools: VisualEditor: All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15277 --> https://bugzilla.wikimedia.org/attachment.cgi?id=... [18:32:53] (03PS3) 10GWicke: WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 [18:33:43] (03CR) 10GWicke: WIP Bug 64171: Log Parsoid request timings to eventlogging (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [18:34:10] 3VisualEditor / 3Editing Tools: VisualEditor: Math inspector is not working in Betalabs - 10https://bugzilla.wikimedia.org/64763 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with VE 2.Insert a math function with math inspector Observed Result: Nothing gets added [18:36:50] 3VisualEditor: VisualEditor: Sometimes pasting text into a page results in only part of the text appearing. - 10https://bugzilla.wikimedia.org/64760#c1 (10WhatamIdoing) Created attachment 15278 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15278&action=edit The text that was supposed to be pasted her... [18:38:20] 3VisualEditor: VisualEditor: Sometimes pasting text into a page results in only part of the text appearing. - 10https://bugzilla.wikimedia.org/64760#c2 (10WhatamIdoing) Created attachment 15279 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15279&action=edit This paste should have read, "Men are rarel... [18:38:50] 3VisualEditor: VisualEditor: Sometimes pasting text into a page results in only part of the text appearing. - 10https://bugzilla.wikimedia.org/64760#c3 (10WhatamIdoing) Created attachment 15280 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15280&action=edit This paste is the same as the previous one... [18:40:29] (03CR) 10jenkins-bot: [V: 04-1] WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [18:43:02] This week in how not to design a UI... http://i.imgur.com/bPr8Kdp.png [18:43:10] Where is the Save button? [18:43:37] (zoomed out, normally you'd only see a third or so of that) [18:44:01] Krinkle: The toolbar doesn't hover? [18:44:06] Nope [18:44:10] It's all the way on the top right [18:44:15] Krinkle: Oh. Dear. [18:44:41] http://i.imgur.com/8FeSPdj.png [18:44:52] I've always been confused by the ".. and keep editing" variant [18:44:58] Interesting, but... never found myself use it [18:45:05] I guess its when you want to make small incremental changes [18:51:50] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c7 (10Bryce Glover) (In reply to Andre Klapper from comment #5) > (In reply to Bryce Glover from comment #4) > > Has this been fixed yet > > If it was fixed, the status of... [18:52:50] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c8 (10Bryce Glover) (In reply to James Forrester from comment #6) > Would it be possible for you to visit > https://en.wikipedia.org/wiki/Foobar?&veaction=edit whilst logge... [18:52:59] Krinkle: dude, MSWord ripoff? c'mon! [18:59:16] (03PS1) 10Trevor Parscal: Fix regression in frame style scoping [oojs/ui] - 10https://gerrit.wikimedia.org/r/131112 [18:59:58] (03PS2) 10Catrope: Fix regression in frame style scoping [oojs/ui] - 10https://gerrit.wikimedia.org/r/131112 (https://bugzilla.wikimedia.org/64761) (owner: 10Trevor Parscal) [19:00:14] TrevorParscal: https://bugzilla.wikimedia.org/show_bug.cgi?id=64759 [19:00:27] (03CR) 10Catrope: [C: 032] Fix regression in frame style scoping [oojs/ui] - 10https://gerrit.wikimedia.org/r/131112 (https://bugzilla.wikimedia.org/64761) (owner: 10Trevor Parscal) [19:00:35] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c9 (10Bryce Glover) (In reply to James Forrester from comment #6) > Would it be possible for you to visit > https://en.wikipedia.org/wiki/Foobar?&veaction=edit whilst logge... [19:01:01] (03Merged) 10jenkins-bot: Fix regression in frame style scoping [oojs/ui] - 10https://gerrit.wikimedia.org/r/131112 (https://bugzilla.wikimedia.org/64761) (owner: 10Trevor Parscal) [19:01:08] (03CR) 10Jforrester: "Caused bug 64761." [oojs/ui] - 10https://gerrit.wikimedia.org/r/125269 (owner: 10Jdlrobson) [19:02:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761 (10James Forrester) p:5Unprio>3High s:5normal>3major a:3Trevor Parscal [19:03:05] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c10 (10James Forrester) (In reply to Bryce Glover from comment #9) > (In reply to James Forrester from comment #6) > > Would it be possible for you to visit > > https://en.... [19:04:13] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (9a6c625f5f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131114 [19:04:49] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c11 (10Bryce Glover) (In reply to James Forrester from comment #10) > (In reply to Bryce Glover from comment #9) > > (In reply to James Forrester from comment #6) > > > Wou... [19:05:48] (03PS4) 10GWicke: WIP Bug 64171: Log Parsoid request timings to eventlogging [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 [19:06:58] (03PS1) 10Cmcmahon: [browser test] CE locator is simpler than it was [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131116 [19:07:40] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131116 (owner: 10Cmcmahon) [19:07:58] (03Abandoned) 10Cmcmahon: [browser test] demo for Roan of ?veaction=edit issue for FF [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131096 (owner: 10Cmcmahon) [19:08:35] https://gerrit.wikimedia.org/r/131114 is the pull-through for the OOjs UI iframe regression; https://gerrit.wikimedia.org/r/131115 is the one for MW-core, blocked on the existing one for the set/clear change. [19:09:20] 3VisualEditor / 3Editing Tools: Menus appear behind page content being edited with VisualEditor - 10https://bugzilla.wikimedia.org/64388#c12 (10Bryce Glover) (In reply to Bryce Glover from comment #11) > (In reply to James Forrester from comment #10) > > (In reply to Bryce Glover from comment #9) > > > (In r... [19:13:27] (03Merged) 10jenkins-bot: [browser test] CE locator is simpler than it was [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131116 (owner: 10Cmcmahon) [19:26:35] (03PS1) 10Trevor Parscal: Use .isDisabled() instead of .disabled to support inheriting [oojs/ui] - 10https://gerrit.wikimedia.org/r/131120 [19:27:04] (03PS2) 10Trevor Parscal: Use .isDisabled() instead of .disabled to support inheriting [oojs/ui] - 10https://gerrit.wikimedia.org/r/131120 (https://bugzilla.wikimedia.org/64759) [19:32:50] 3OOjs UI: OOjs UI: Auto-disabled tool group still responds to clicks - 10https://bugzilla.wikimedia.org/64759 (10James Forrester) [19:32:51] 3OOjs UI: Auto-disabled tool group still responds to clicks - 10https://bugzilla.wikimedia.org/64759 (10James Forrester) p:5Unprio>3High a:3Trevor Parscal [19:33:40] (03PS1) 10Cmcmahon: [browser test] further adventures of avoiding login to edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131121 [19:34:50] 3OOjs UI: OOjs UI: Auto-disabled tool group still responds to clicks - 10https://bugzilla.wikimedia.org/64759#c2 (10Rainer Rillke @commons.wikimedia) Is this a duplicate of Bug 64601 ? [19:34:50] 3VisualEditor / 3Initialisation: VisualEditor: Inserting Media fails when caret is not positioned after initialization - 10https://bugzilla.wikimedia.org/64601 (10Rainer Rillke @commons.wikimedia) [19:38:24] (03PS2) 10Cmcmahon: [browser test] further adventures of avoiding login to edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131121 [19:43:14] (03CR) 10Esanders: [C: 032] "leg disabled?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/131120 (https://bugzilla.wikimedia.org/64759) (owner: 10Trevor Parscal) [19:43:26] (03PS3) 10Cmcmahon: [browser test] further adventures of avoiding login to edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131121 [19:43:43] (03Merged) 10jenkins-bot: Use .isDisabled() instead of .disabled to support inheriting [oojs/ui] - 10https://gerrit.wikimedia.org/r/131120 (https://bugzilla.wikimedia.org/64759) (owner: 10Trevor Parscal) [19:43:55] edsanders: I want Thal to do a code test [19:44:51] we are looking at some jr engineers, and Roan and I are quite convinced that, aside from one of them which looks promising, she is above par already [19:45:02] would she be willing to do a task? [19:45:29] But, you would have to try not to help her too much [19:45:38] I want to see where she really is [19:51:34] TrevorParscal: can you review a 1-line fix for mwcore wmf regression for me? [19:51:39] https://gerrit.wikimedia.org/r/#/c/131124/ [19:54:38] 3MediaWiki extensions / 3TemplateData: TemplateData: TemplateDataGenerator uses old types - 10https://bugzilla.wikimedia.org/60693 (10James Forrester) a:3Ltrlg [19:57:38] James_F, I started writing some notes about what VE expects of skins in https://docs.google.com/a/wikimedia.org/document/d/1awG4IKujTFd72RJzr_4DVInKDO1BqRxRHbTnCHvYLr4/edit [19:58:38] starting with the IDs it expects to be present and then a note relating to https://gerrit.wikimedia.org/r/#/c/130085/ and https://gerrit.wikimedia.org/r/#/c/130656/ [19:59:19] Looking for feedback. Never having made a skin myself I'm not 100% sure about what we need to make clear here. [20:00:00] Krenair: oooh, shiny [20:00:31] Eh. I'm just not confident that this is what's wanted yet [20:02:16] MatmaRex, thoughts? suggestions? [20:04:26] Krenair: the last three points can probably be put more succintly as "Use SkinTemplate methods for generating navigation menus of your skin" (which methods exactly, and how, may or may not be documented somewhere :/ ) [20:04:50] so i suppose, make the three sub-bulletpoints of that? :) [20:06:12] (the methods would be probably getSidebar() and definitely makeListItem()) [20:08:03] MatmaRex, ehh... I'm trying to show what VE expects to end up looking at [20:09:14] (03PS1) 10JGonera: Enable references on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131205 [20:09:14] Krenair: Nice start. [20:11:37] (Obviously, when I started a google doc I expected to end up writing more. :/) [20:17:13] (03CR) 10Cmcmahon: [C: 032] [browser test] further adventures of avoiding login to edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131121 (owner: 10Cmcmahon) [20:17:41] it looks like link inspector is kind of broken on master, the input is blank when LI opens and removing the link doesn't seem to work (tried both desktop and mobile) [20:19:04] (03Merged) 10jenkins-bot: [browser test] further adventures of avoiding login to edit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131121 (owner: 10Cmcmahon) [20:35:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: Document what is needed in terms of support for custom MediaWiki skins - 10https://bugzilla.wikimedia.org/61500#c2 (10Alex Monk) a:3Alex Monk I started writing some notes about what VE expects of skins in https://docs.google.com/a/wikimedia.org/document... [20:40:47] Krinkle, so I seem to recall you had some ideas about detecting slowness for https://bugzilla.wikimedia.org/show_bug.cgi?id=50518 [20:41:12] Krenair: right [20:41:44] Krinkle, okay, can you remember what they were? [20:41:47] Krenair: basically, use timestamp comparison (mw.now() / ve.now()) between different operations [20:41:52] yeah [20:42:36] when a certain amount of time has passed (potentially taking the document complexity in account as well, avoid measuring network by accident), set a boolean flag, which in getEditnotices() will make it include/exclude that notice accordingly [20:43:19] I'm wondering what operation we should measure and what timing shows a reasonable speed [20:44:32] Calculate the first 100 digits of Pi? :-) [21:25:35] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434#c3 (10James Forrester) *** Bug 64601 has been marked as a duplicate of this bug. *** [21:25:35] 3VisualEditor / 3Initialisation: VisualEditor: Inserting Media fails when caret is not positioned after initialization - 10https://bugzilla.wikimedia.org/64601#c1 (10James Forrester) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 64434 *** [21:25:50] 3OOjs UI: OOjs UI: Auto-disabled tool group still responds to clicks - 10https://bugzilla.wikimedia.org/64759#c4 (10James Forrester) 5PAT>3RES/FIX (In reply to Rainer Rillke @commons.wikimedia from comment #2) > Is this a duplicate of Bug 64601 ? No; bug 64434. [21:29:05] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434#c4 (10Rainer Rillke @commons.wikimedia) Where is the gerrit change? [21:43:50] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434#c5 (10Roan Kattouw) (In reply to Rainer Rillke @commons.wikimedia from comment #4) > Where is th... [21:48:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Reference list dialog is no longer "small" size, but default "large" - 10https://bugzilla.wikimedia.org/64670#c5 (10ryasmeen) Verified the fix in test2 [21:50:21] 3VisualEditor / 3ContentEditable: VisualEditor: Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399#c8 (10ryasmeen) Verified the fix in test2 [21:53:54] Krinkle, did you see my last message? [21:59:06] 3VisualEditor / 3ContentEditable: VisualEditor: Typing fast in reference dialog box shifts the first character of the text to the next line in Firefox - 10https://bugzilla.wikimedia.org/64399#c9 (10ryasmeen) 5RES/?>3VER Verified the fix in production [22:03:06] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334#c5 (10ryasmeen) 5... [22:09:08] Krenair: one or more of the actions in the setup of the surface (parsing of html into data DOM, conversion to linenar data model, building of CE etc.) [22:30:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Citation dialog does not focus correct field when adding a new parameter - 10https://bugzilla.wikimedia.org/64098#c2 (10ryasmeen) Verified the fix on Betalabs [22:31:01] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (9a6c625f5f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131114 (owner: 10Jforrester) [22:32:31] (03PS4) 10Trevor Parscal: Cleanup focus/select/clear [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 [22:32:33] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (9a6c625f5f) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131114 (owner: 10Jforrester) [22:32:37] 3VisualEditor / 3Editing Tools: Keyboard shortcut to change heading is labelled incorrectly on Mac - 10https://bugzilla.wikimedia.org/64771 (10Trevor (Wikia)) 3NEW p:3Unprio s:3normal a:3None Noticed on our Wikia integration, and saw that it was incorrect here: https://www.mediawiki.org/wiki/VisualEd... [22:45:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599#c12 (10ryasmeen) Verified the fix on Betalabs and test2 [22:46:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Null" appearing instead of "Transclusion" in the template insert dialog box - 10https://bugzilla.wikimedia.org/64671#c3 (10ryasmeen) Verified the fix in Betalabs and Test2 [22:47:26] (03PS1) 10Catrope: Update VE core submodule to master (a1e9df1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131233 [22:47:34] TrevorParscal: https://gerrit.wikimedia.org/r/131233 [22:50:38] (03PS5) 10Catrope: Update VE core submodule to master (a1e9df1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [22:50:52] (03Abandoned) 10Catrope: Update VE core submodule to master (a1e9df1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131233 (owner: 10Catrope) [22:51:07] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (a1e9df1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [22:52:40] (03Merged) 10jenkins-bot: Update VE core submodule to master (a1e9df1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130421 (owner: 10Trevor Parscal) [22:53:06] 3VisualEditor / 3Editing Tools: VisualEditor: When "__FORCETOC__" is set, inside VE instead of "Hide" the link to hide the TOC appears as "" - 10https://bugzilla.wikimedia.org/64464#c3 (10ryasmeen) Verified the fix in test2 [22:53:20] 3VisualEditor / 3ContentEditable: VisualEditor: ve.ce.ProtectedNode.prototype.onProtectedSetup is a performance hog - 10https://bugzilla.wikimedia.org/64709#c8 (10Roan Kattouw) https://gerrit.wikimedia.org/r/130823 (for bug 52499) should make this perform a bit better as well, by 1) reducing the number of el... [23:11:50] 3VisualEditor: VisualEditor: Performance issues (tracker) - 10https://bugzilla.wikimedia.org/49685 (10James Forrester) [23:11:52] 3VisualEditor / 3Editing Tools: VisualEditor: On load, async pre-load all the TemplateData for the page to make editing templates speedier - 10https://bugzilla.wikimedia.org/64772 (10James Forrester) 3ASS p:3Unprio s:3enhanc a:3None Right now there's a noticeable delay; we can speed up user experienc... [23:12:50] 3VisualEditor / 3Editing Tools: VisualEditor: On load, async pre-load all the TemplateData for the page to make editing templates speedier - 10https://bugzilla.wikimedia.org/64772 (10James Forrester) p:5Unprio>3High [23:21:51] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression] Content has too small font-size and squished line-height in MediaWiki Vector - 10https://bugzilla.wikimedia.org/64599#c13 (10ryasmeen) 5RES/?>3VER Verified the fix on production [23:35:52] 3OOjs UI: Dialog emits "closing" event 250ms after close() is invoked - 10https://bugzilla.wikimedia.org/64775 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None That's because the event is emitted by the parent method (Window#close), which is called with a delay of 250ms. Talked to Trevor, reporting... [23:37:05] 3OOjs UI: OOjs UI: Dialog emits "closing" event 250ms after close() is invoked - 10https://bugzilla.wikimedia.org/64775 (10James Forrester) p:5Unprio>3Normal [23:37:05] 3OOjs UI: OOjs UI: Dialog emits "closing" event 250ms after close() is invoked - 10https://bugzilla.wikimedia.org/64775 (10James Forrester) 5NEW>3ASS [23:45:05] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761#c3 (10ryasmeen) 5PAT>3RES/FIX Verified the fix on Betalabs [23:56:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=64771 [23:57:33] I suspect this is to do with mw.util.tooltipAccessKeyPrefix and thus a MW core bug [23:57:34] er [23:58:07] which is apparently deprecated and just uses a jquery module instead