[02:47:20] 3VisualEditor / 3MediaWiki integration: VisualEditor: When section edit is initiated with an actual page load, VE does not navigate to the section - 10https://bugzilla.wikimedia.org/52566#c1 (10Matthew Flaschen) This is just a special case. The general issue is that VE does not navigate to the section when... [02:52:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: When section edit is initiated with an actual page load, VE does not navigate to the section - 10https://bugzilla.wikimedia.org/52566 (10Matthew Flaschen) a:3Matthew Flaschen [03:03:39] (03PS1) 10Mattflaschen: Generate PHP VE edit section with correct parameter, vesection [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131415 (https://bugzilla.wikimedia.org/52566) [03:04:44] (03PS2) 10Mattflaschen: Generate PHP VE edit section with correct parameter, vesection [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131415 (https://bugzilla.wikimedia.org/52566) [08:35:20] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page save time at 75th percentile up 70% from February - 10https://bugzilla.wikimedia.org/64171#c10 (10Gabriel Wicke) It's also worth keeping in mind that most of the user-perceived save time on large articles & typical DSL connections is currently the ne... [08:37:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page save time at 75th percentile up 70% from February - 10https://bugzilla.wikimedia.org/64171#c11 (10Gabriel Wicke) Created attachment 15292 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15292&action=edit Save request from VE for [[en:San Franc... [10:20:51] 3VisualEditor / 3Language: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - 10https://bugzilla.wikimedia.org/33126 (10Amir E. Aharoni) [10:20:53] 3VisualEditor / 3Language: Ctrl-Arrow moves the caret too far in RTL wikis - 10https://bugzilla.wikimedia.org/64872 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Ctrl-Arrow is supposed to move the caret one word in the direction of the arrow. In RTL wikis it moves too far. It looks like to go... [10:23:50] 3VisualEditor / 3Language: Ctrl-Arrow moves the caret too far in RTL wikis - 10https://bugzilla.wikimedia.org/64872#c1 (10Amir E. Aharoni) On a Mac it's Alt-Arrow a.k.a. Option-Arrow. [13:22:27] (03PS1) 10Krinkle: generateDocs.sh: Simplify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131461 [13:22:34] (03PS2) 10Krinkle: generateDocs.sh: Simplify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131461 [13:45:14] RoanKattouw: ping [16:15:58] (03CR) 10Jforrester: [C: 032] generateDocs.sh: Simplify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131461 (owner: 10Krinkle) [16:17:18] (03Merged) 10jenkins-bot: generateDocs.sh: Simplify [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131461 (owner: 10Krinkle) [16:19:35] 3VisualEditor: can't use save form checkboxes in opera - 10https://bugzilla.wikimedia.org/63615 (10Andre Klapper) [16:24:28] (03PS1) 10Jforrester: Point language Beta Feature links to the right messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131490 [16:27:50] 3VisualEditor: can't use save form checkboxes in opera - 10https://bugzilla.wikimedia.org/63615#c1 (10James Forrester) 5UNC>3RES/WOR It seems to work OK for me now – can you confirm? [16:58:23] 3VisualEditor / 3Editing Tools: VisualEditor: Provide an omnibar for quick keyboard access to tools - 10https://bugzilla.wikimedia.org/64905 (10James Forrester) 3ASS p:3Unprio s:3enhanc a:3None From MediaWiki.org: > I would like to have an omnibar in VE. This is a single text field where > a user ca... [16:58:51] 3VisualEditor / 3Editing Tools: VisualEditor: Provide an omnibar for quick keyboard access to tools - 10https://bugzilla.wikimedia.org/64905 (10James Forrester) p:5Unprio>3Low [17:28:36] 3OOjs UI: OOjs UI: [Regression pre-wmf4] footless dialogs broken - 10https://bugzilla.wikimedia.org/64808#c1 (10Juliusz Gonera) Where can such a dialog be found? [17:30:21] 3OOjs UI: OOjs UI: [Regression pre-wmf4] footless dialogs broken - 10https://bugzilla.wikimedia.org/64808#c2 (10James Forrester) (In reply to Juliusz Gonera from comment #1) > Where can such a dialog be found? Media Insert is the most obvious one. [17:34:22] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/131490/ [17:44:21] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of div wrapping in template rendering - 10https://bugzilla.wikimedia.org/64780 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3enhanc [17:48:30] (03CR) 10Catrope: [C: 032] Point language Beta Feature links to the right messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131490 (owner: 10Jforrester) [17:48:53] (03PS1) 10Jforrester: Point language Beta Feature links to the right messages [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131506 [17:49:52] Krinkle: pong? [17:50:00] Sorry, I don't generally respond to pings very quickly at 5am :) [17:52:14] (03Merged) 10jenkins-bot: Point language Beta Feature links to the right messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131490 (owner: 10Jforrester) [17:53:36] RoanKattouw: yeah, no worries. You appeared to be online. Forgot what it was. [17:54:17] Krinkle: Probably jQuery-related? [17:54:26] Nah, I remember what it was [17:54:45] RoanKattouw: We were going to chat about the API for resourceloader dependency functions. [17:54:56] Oh right [17:55:38] RoanKattouw: Ping me in #wikimedia-dev when you have a few minutes. Doesn't have to take ong. [17:55:39] long [17:57:06] (03CR) 10Catrope: [C: 032] Generate PHP VE edit section with correct parameter, vesection [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131415 (https://bugzilla.wikimedia.org/52566) (owner: 10Mattflaschen) [17:58:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: When section edit is initiated with an actual page load, VE does not navigate to the section - 10https://bugzilla.wikimedia.org/52566#c3 (10James Forrester) 5PAT>3RES/FIX Thanks, Matt! [17:58:58] (03Merged) 10jenkins-bot: Generate PHP VE edit section with correct parameter, vesection [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131415 (https://bugzilla.wikimedia.org/52566) (owner: 10Mattflaschen) [17:59:08] RoanKattouw, any chance you have a couple of minutes? [17:59:25] Sure [17:59:36] I'm also having a parallel conversation so I might be a bit slow, but go for it [17:59:56] I can tell you exactly what *doesn't* happen. I am even fairly positive about why, though all my attempts to fix it have produced Bigger Bugs. [18:00:19] It comes down to The Amazing Scalable[tm]. [18:01:38] ok, so when you work with the new MWImageModel, and load the dialog -- the media size widget doesn't get properly updated with the default size. It works perfectly if you click any of the buttons -- so, if you change type once and then back to what it was = works perfect. If you change from custom to default (size) and back = perfect. [18:01:43] it just doesn't *initialize* properly [18:01:48] It's driving me crazy. [18:02:27] The placeholders aren't loading -- and those come from changing default properties in the scalable. The defaults *are* changing when you change the type -- so the event works properly -- it just doesn't seem to be called properly on initialization. [18:03:23] MWImageModel listens to the defaultSizeChange of the scalable and so does the MediaSizeWidget -- but the point was to let the size widget deal with everything independently. [18:05:02] RoanKattouw, I am fairly positive I criss-crossed events there; in all my tests, the "onScalableDefaultSizeChange" for the MediaSizeWidget is not even *called* on initialization, which is driving me mad -- because the source of this event is the default size change of the scalable -- and the scalable *does* emit it. [18:05:21] I am at a loss. [18:05:58] OK I'll have to sit down and watch this fail in a debugger and stuff [18:06:05] Which I don't have time to do right this second [18:06:10] But I can do that after lunch probably [18:06:19] * mooeypoo nods [18:06:45] I'm continuing to test. I also think it MIGHT be related (but not completely due to) the change from "selectItem" to "chooseItem" in the select widget [18:07:28] *but* all the events fire when the user changes the select widgets even though I still have listeners for 'select' rather than 'choose'.. so it can't just be that. [18:21:07] 3VisualEditor / 3Editing Tools: VisualEditor: There is an extra space appearing in media search result dialog in betalabs - 10https://bugzilla.wikimedia.org/64911 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15298 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15298&action... [18:35:30] Krinkle, looking back at the logs from friday, you suggested measuring something like parsing of html into data DOM, conversion to linear data model, building of CE etc. [18:36:00] while somehow avoiding it being effected by document length/complexity [18:36:25] but those operations will all take different times depending on document length/complexity :/ [18:39:03] Krenair: Yes, but avoiding I mean, taking into account [18:39:39] e.g. not `timespend > maxtime`, but something like `timespent/doc-size > maxratio` [18:39:52] RoanKattouw might have some math ideas that are more useful [18:39:58] I'm a dumb nut when it comes to that [18:40:33] 3VisualEditor / 3Editing Tools: VisualEditor: There is an extra space appearing in media search result dialog in betalabs - 10https://bugzilla.wikimedia.org/64911 (10ryasmeen) a:3Juliusz Gonera [18:40:42] However, we should probably do some research and see how slow the 'too slow' browsers really are. [18:41:18] We might be able to measure it with a very simple operation at a small scale (e.g. create an iframe and attach it, just a random unused iframe), that that one operation is measurable enough, we can do it that way. [18:41:23] Hm. This is getting increasingly out of the 'MediaWiki integration' part [18:41:40] The function calls are all in viewpagetarget in setupSurface [18:41:51] though ideally this would probably be in ve-core, seems a useful statistis [18:43:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] There is an extra space appearing in media search result dialog in betalabs - 10https://bugzilla.wikimedia.org/64911 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3minor [18:43:20] 3OOjs UI: OOjs UI: [Regression pre-wmf4] footless dialogs broken - 10https://bugzilla.wikimedia.org/64808 (10James Forrester) [18:49:19] (03PS1) 10JGonera: Remove unnecessary space in footless dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/131516 (https://bugzilla.wikimedia.org/64808) [18:50:00] James_F, ryasmeen_ fix for the footless dialog bug: https://gerrit.wikimedia.org/r/131516 [18:50:53] (03PS2) 10JGonera: Remove unnecessary space in footless dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/131516 (https://bugzilla.wikimedia.org/64808) [18:51:09] jgonera: Thanks! :-) [18:52:27] (03CR) 10Trevor Parscal: [C: 032] Remove unnecessary space in footless dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/131516 (https://bugzilla.wikimedia.org/64808) (owner: 10JGonera) [18:52:55] (03Merged) 10jenkins-bot: Remove unnecessary space in footless dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/131516 (https://bugzilla.wikimedia.org/64808) (owner: 10JGonera) [19:03:02] Oh, I like the new Sublime Text 3 sidebar that was released earlier today. [19:03:06] There was a minor update today [19:03:07] :) [19:03:10] very clean [19:11:31] (03PS1) 10Cmcmahon: [browser test] WIP: refactor bullets test to use API etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 [19:13:35] 3VisualEditor / 3Editing Tools: VisualEditor: On load, async pre-load all the TemplateData for the page to make editing templates speedier - 10https://bugzilla.wikimedia.org/64772#c1 (10Roan Kattouw) Also pre-load the templates configured for the cite tools. [19:26:21] 3VisualEditor / 3Editing Tools: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - 10https://bugzilla.wikimedia.org/62681#c1 (10ryasmeen) Created attachment 15299 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15299&action=edit Screens... [19:27:16] (03PS1) 10Jforrester: Label parameters as 'fields'; in the 'add' button, call it 'more information' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131530 [19:38:38] (03CR) 10Catrope: [C: 032] Label parameters as 'fields'; in the 'add' button, call it 'more information' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131530 (owner: 10Jforrester) [19:40:58] (03Merged) 10jenkins-bot: Label parameters as 'fields'; in the 'add' button, call it 'more information' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131530 (owner: 10Jforrester) [20:08:02] James_F, TrevorParscal I'd appreciate if someone could have a look at https://gerrit.wikimedia.org/r/#/c/131205/ it's really small and would unblock us on some stories we have planned for this iteration [20:08:39] (03CR) 10Catrope: [C: 032] Enable references on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131205 (owner: 10JGonera) [20:10:34] (03Merged) 10jenkins-bot: Enable references on mobile [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131205 (owner: 10JGonera) [20:23:52] 3VisualEditor / 3Editing Tools: VisualEditor: Adding citations inside hieroglyphics blocks results in hieroglyphics block never closing - 10https://bugzilla.wikimedia.org/64915 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Intention: Add a citation inside (not after) a hieroglyphics block. Step... [20:28:05] 3VisualEditor / 3Editing Tools: VisualEditor: Adding citations inside hieroglyphics, gallery, or mathematics blocks results in the inspector never closing - 10https://bugzilla.wikimedia.org/64915 (10WhatamIdoing) [20:29:58] (03PS1) 10Jforrester: Follow-up I54d2cf7f05: More s/parameter/field/g [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131588 [20:30:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: Add an edit notice for users of slower computers advising them to use source mode - 10https://bugzilla.wikimedia.org/50518#c4 (10Alex Monk) We discussed how to do this in #mediawiki-visualeditor a bit. Some quotes: when a certain amount of time... [20:31:56] RoanKattouw: https://gerrit.wikimedia.org/r/131588 would be good to merge now to help TWN a bit. [20:33:35] (03CR) 10Catrope: [C: 032] Follow-up I54d2cf7f05: More s/parameter/field/g [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131588 (owner: 10Jforrester) [20:35:27] (03Merged) 10jenkins-bot: Follow-up I54d2cf7f05: More s/parameter/field/g [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131588 (owner: 10Jforrester) [20:38:38] is TemplateData required for visual editor to expand templates correctly? [20:38:44] (03Abandoned) 10Jforrester: WIP: Record intention in ve.dm.Transaction object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84440 (owner: 10Cscott) [20:38:49] (03Abandoned) 10Jforrester: Add ve.dm.Transaction.newNoOp() constructor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84439 (owner: 10Cscott) [20:38:56] (03Abandoned) 10Jforrester: Add ve.dm.Transaction.copy() method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84441 (owner: 10Cscott) [20:39:03] (03Abandoned) 10Jforrester: WIP: Implement ve.dm.Transaction.transpose() w/ intentions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84442 (owner: 10Cscott) [20:39:21] i tested an example template like {{{1}}} and this wasn't expanded in VE [20:39:39] (03Abandoned) 10Jforrester: WIP: Basic metadata support for ve.dm.Transaction.transpose [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/83851 (owner: 10Cscott) [20:39:47] (03Abandoned) 10Jforrester: WIP: Implement ve.dm.Transaction.transpose for simple insertion/removal [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/81579 (owner: 10Cscott) [20:40:56] joelmo: Hey. What do you mean by "expand"? [20:42:05] 3VisualEditor / 3Language: VisualEditor: Ctrl-Arrow moves the caret too far in RTL wikis - 10https://bugzilla.wikimedia.org/64872 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3major [20:42:41] James_F: evaluate with the parameter i put in [20:43:35] joelmo: So you have a template like {{bold echo}} for which {{bold echo|foo}} outputs Foo, right? [20:44:02] joelmo: But in VisualEditor inside the template dialog it just shows the template as "1": "Foo"? [20:44:30] yes, it does this correctly normally but when i open up VE this evaluates to {{{1}}} in bold text [20:44:48] So it shows you {{{1}}} rather than the parameter? [20:44:55] yes [20:44:58] Very odd. [20:45:12] i can click on the puzzle icon and this will show the parameter i put in [20:45:18] yes so it seems weird [20:45:21] That sounds like a bug in the wikitext; VisualEditor doesn't understand wikitext so can't insert "{{{"s. [20:45:31] Is this on a public wiki? [20:46:09] this is on a wiki I set up self, is not far behind master on VE, parsoid, core, updated all yesterday [20:46:17] Right. [20:46:55] but wikitext, thats cores part? [20:47:01] The page appears correctly in read? [20:47:07] yes [20:47:31] tested purging the cache also, didnt help [20:47:31] Hmm. Very odd. [20:48:00] Possibly it's a Parsoid bug (the template in read mode is interpreted by MediaWiki; the template in VisualEditor is done by Parsoid). [20:48:15] Could you file a bug in Bugzilla with a little more details so we can fix it? [20:49:05] alright, yes i don't know. details like which sha i am on in the repos etc? [20:49:36] (03PS1) 10Esanders: Fix command help for CTRL+1-6 on mac [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131596 (https://bugzilla.wikimedia.org/64771) [20:49:40] That could help [20:51:36] James_F: do I file this under the parsoid project? [20:52:01] joelmo: Yes, but if it's a VE issue we'll fix it here instead. :-) [20:52:22] (03CR) 10Jforrester: [C: 032] Fix command help for CTRL+1-6 on mac [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131596 (https://bugzilla.wikimedia.org/64771) (owner: 10Esanders) [20:52:40] James_F: alright :) [20:53:28] James_F: any idea why our browser tests would now fail on timed out after 5 seconds, waiting for {:css=>"div.ve-ce-documentNode"} to become present (Watir::Wait::TimeoutError) [20:53:34] should we be looking for a different element now?' [20:53:36] (03Merged) 10jenkins-bot: Fix command help for CTRL+1-6 on mac [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131596 (https://bugzilla.wikimedia.org/64771) (owner: 10Esanders) [20:53:50] 3VisualEditor / 3Editing Tools: VisualEditor: Keyboard shortcut dialog lists heading change incorrectly labelled on Mac - 10https://bugzilla.wikimedia.org/64771 (10James Forrester) 5PAT>3RES/FIX [20:53:57] jdlrobson: Does it happen every time? [20:54:04] James_F: looks like it [20:54:17] jdlrobson: The VE browser tests die on that statement about 1 in 5 times regularly. [20:54:23] Hmm. Don't think it changed. [20:54:25] VE tests have been failing since 30th April on Chrome [20:54:36] James_F: any ideas why? [20:54:46] They're browser tests. [20:54:47] (why it fails 1/5 times) [20:55:15] Oh, apparently it's "normal" that the connexion from SauceLabs to CloudBees times out every now and then. [20:55:56] This is why we're keen to move to WMF-hosted Jenkins to debug. [20:56:03] (Great, huh? :-() [20:59:57] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131604 [21:00:37] RoanKattouw: https://gerrit.wikimedia.org/r/131605 and https://gerrit.wikimedia.org/r/131604 plz. :-) [21:03:15] James_F: Hold on, more OOJS UI stuff coming [21:04:46] (03PS1) 10Catrope: Make autoFocus default to true. [oojs/ui] - 10https://gerrit.wikimedia.org/r/131608 (https://bugzilla.wikimedia.org/64334) [21:05:21] (03PS2) 10Trevor Parscal: Make autoFocus default to true [oojs/ui] - 10https://gerrit.wikimedia.org/r/131608 (https://bugzilla.wikimedia.org/64334) (owner: 10Catrope) [21:05:37] (03CR) 10Trevor Parscal: [C: 032] Make autoFocus default to true [oojs/ui] - 10https://gerrit.wikimedia.org/r/131608 (https://bugzilla.wikimedia.org/64334) (owner: 10Catrope) [21:07:19] * mooeypoo waves at RoanKattouw  [21:07:24] (03Merged) 10jenkins-bot: Make autoFocus default to true [oojs/ui] - 10https://gerrit.wikimedia.org/r/131608 (https://bugzilla.wikimedia.org/64334) (owner: 10Catrope) [21:08:21] 3VisualEditor / 3Mobile: VisualEditor: Mobile Google Chrome text cursor hides link object icon - 10https://bugzilla.wikimedia.org/51270#c3 (10James Forrester) 5ASS>3RES/INV p:5Low>3High s:5minor>3normal The mobile version of VisualEditor doesn't do text over-lays to avoid issues like this bug. Cl... [21:08:23] 3VisualEditor / 3Data Model: VisualEditor: CTRL+A in Firefox creates a selection starting at 0 and ending after the document node - 10https://bugzilla.wikimedia.org/64917 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None Selections at non-content offsets are bad, e.g. pressing delete will throw an exce... [21:08:27] RoanKattouw, https://bugzilla.wikimedia.org/show_bug.cgi?id=64917 [21:08:36] 3VisualEditor / 3Mobile: VisualEditor: Selection popup arrow is overlapped by selection controls on iPad - 10https://bugzilla.wikimedia.org/37874#c4 (10James Forrester) 5ASS>3RES/INV The mobile version of VisualEditor doesn't do text over-lays to avoid issues like this bug. Closing as INVALID now that wo... [21:08:55] (03PS2) 10Cmcmahon: [browser test] WIP: refactor bullets test to use API etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 [21:09:09] mooeypoo: Sorry got distracted by various things [21:09:13] Will look at your thing soon [21:11:36] (03PS2) 10Catrope: Update OOjs UI to v0.1.0-pre (7d2507b267) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131604 (owner: 10Jforrester) [21:11:37] 3VisualEditor / 3Editing Tools: VisualEditor: Category editor should also suggest categories which 'exist' but are without a description page - 10https://bugzilla.wikimedia.org/49044 (10James Forrester) a:3Alex Monk [21:11:55] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (7d2507b267) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131604 (owner: 10Jforrester) [21:12:06] 3VisualEditor / 3ContentEditable: VisualEditor: Links to new pages inside templates are coloured red in the content but not a dialog iframe - 10https://bugzilla.wikimedia.org/48984#c1 (10James Forrester) 5ASS>3RES/FIX Now fixed as of last month. [21:12:35] (03PS1) 10Jforrester: Update VE core submodule to master (cc6e87c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131610 [21:13:24] RoanKattouw, thanks! I just know you guys will be away for a while [21:13:34] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (cc6e87c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131610 (owner: 10Jforrester) [21:14:17] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (7d2507b267) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131604 (owner: 10Jforrester) [21:14:29] (03PS3) 10Cmcmahon: [browser test] refactor bullets test to use API etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 [21:16:37] 3VisualEditor / 3Data Model: VisualEditor: CTRL+A in Firefox creates a selection starting at 0 and ending after the document node - 10https://bugzilla.wikimedia.org/64917 (10James Forrester) 5NEW>3ASS p:5Unprio>3High a:3Ed Sanders [21:17:27] (03Merged) 10jenkins-bot: Update VE core submodule to master (cc6e87c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131610 (owner: 10Jforrester) [21:18:05] 3OOjs UI: OOjs UI: [Regression pre-wmf4] footless dialogs broken - 10https://bugzilla.wikimedia.org/64808 (10James Forrester) 5PAT>3RES/FIX [21:18:06] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] There is an extra space appearing in media search result dialog in betalabs - 10https://bugzilla.wikimedia.org/64911 (10James Forrester) 5PAT>3RES/FIX [21:18:35] (03PS1) 10Catrope: Stop explicitly setting autoFocus to true now that it defaults to true. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131611 [21:19:05] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs are quite big, maybe they could be smaller - 10https://bugzilla.wikimedia.org/49549#c6 (10James Forrester) 5ASS>3RES/FIX We changed the sizes of dialogs a few months ago. [21:19:22] 3VisualEditor / 3Editing Tools: VisualEditor: Dialogs are quite big, maybe they could be smaller - 10https://bugzilla.wikimedia.org/49549 (10James Forrester) a:3Trevor Parscal [21:22:20] 3VisualEditor / 3Editing Tools: VisualEditor: Transclusion dialogs panes should include a link to the template's definition page (for further documentation) - 10https://bugzilla.wikimedia.org/49772#c5 (10James Forrester) 5ASS>3RES/WOR This was done two months ago for templates which lack documentation; I... [21:22:55] mooeypoo: vertalignmentFieldset never being defined doesn't help very much [21:24:05] 3VisualEditor / 3MediaWiki integration: VisualEditor: Saving or closing the editing pane does not restore the default view of the article - 10https://bugzilla.wikimedia.org/49964#c2 (10James Forrester) 5ASS>3RES/FIX I believe all of the changes for this has been merged and fixed some months ago; please c... [21:28:21] (03CR) 10Jforrester: [C: 032] Stop explicitly setting autoFocus to true now that it defaults to true. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131611 (owner: 10Catrope) [21:29:22] RoanKattouw, bah, I removed it in my local change. [21:30:05] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334 (10James Forrester... [21:30:06] (03Merged) 10jenkins-bot: Stop explicitly setting autoFocus to true now that it defaults to true. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131611 (owner: 10Catrope) [21:30:18] RoanKattouw, but this bug happened before the vertical alignment attempt anyways. it'll be added on later. [21:31:54] Yeah I'm just commenting things out to get it to run [21:42:43] (03PS4) 10Cmcmahon: [browser test] refactor bullets test to use API etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 [21:44:56] (03PS5) 10Cmcmahon: [browser test] refactor bullets test to use API etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 [21:47:27] mooeypoo: Confirmed bug: when opening image dialog for the first time, dimensions fields are empty [21:48:04] yes [21:48:23] RoanKattouw, but now click the type button -- change to something and then back to the previous type without closing the dialog [21:48:33] Works for some types but not others [21:48:44] Depends on whether that type has different default size rules apparently [21:48:54] It seems to respond to the event, though. [21:49:02] it just doesn't call it properly on initialization [21:49:08] If I start with Basic, I can switch to Frame and back and nothing happens [21:49:09] RoanKattouw, yes, because the event that it listens to is changing defaults [21:49:18] But Frameless does change it [21:49:19] OK [21:49:34] and changing defaults only happens between basic/frameless <--> thumb/frame [21:49:47] so that's when the scalable changes default values and FIRES the event. [21:50:06] the media size widget listens to that -- and it seems like it listens properly because if you change the type it *does* change the values [21:50:32] it just doesn't get that change when on initialization -- even though the scalable accepts the properties of the image [21:51:12] Right [21:51:16] Let me see what's going on there [21:52:03] mooeypoo: Justify to me how updateDefaultDimensions() is ever called on initializatoin [21:52:22] It *should* be called. [21:52:27] My gut says it should also be called in setScalable(), not just in response to an event [21:53:38] well, the scalable is set up and then updateType() is called which is updating the default dimensions [21:53:51] which should trigger the default change of the scalable... [21:53:56] Adding a call to this.updateDefaultDimensions() to MediaSizeWidget#setScalable seems to fix it for me [21:54:33] er. hm. [21:56:33] omg! you're right [21:56:38] \o/ thank you! [21:57:31] ... oh, I see what happened there. The event could've been triggered before the scalable was attached to the size widget [22:00:39] (03CR) 10Jforrester: [C: 031] "Looks sane. Happy to +2 if needed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 (owner: 10Cmcmahon) [22:03:09] (03PS1) 10Mooeypoo: Updating scalable default in MediaSizeWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131617 [22:03:19] RoanKattouw, ^^ [22:03:34] Much obliged. [22:04:06] I knew it would turn out ot be something idiotically small. I was waiting to see why the media size widget doesn't respond to the event -- in reality, the event got fired BEFORE the scalable object was attached. Bah. [22:04:15] s/got/was [22:11:51] (03CR) 10Mooeypoo: [WIP] Image model and the media edit dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [22:19:10] (03CR) 10Cmcmahon: [C: 032] [browser test] Save dialog takes longer than 5s [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129305 (owner: 10Cmcmahon) [22:19:22] (03CR) 10jenkins-bot: [V: 04-1] [browser test] Save dialog takes longer than 5s [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129305 (owner: 10Cmcmahon) [22:24:50] RoanKattouw, or anyone around here ... I just updated my local install of mw/core and ve extension. i also updated LocalSettings.php as well. but, now on my localhost (laptop) wiki, my ve-edit tab does nothing ... web-console does not show any errors. any ideas why might be going on or how I might debug this? [22:25:09] s/why/what/ [22:26:21] subbu: Do you have the Parsoid PHP extension installed? [22:26:26] yes [22:26:28] subbu: It's now a dependency of VE… [22:26:42] subbu: Is it the latest version with the RL module being created? [22:26:50] i installed it and added it to LocalSettings.php [22:27:02] subbu: If ext.parsoid.styling (or whatever it's called) doesn't exist VE will just silently fail. [22:27:08] let me check what i have. [22:29:05] James_F, i have parsoid ext. code as of may 1 (f08ab7e2); VE ext code 0bcab80d (may 5th); and core code d54472bc (may 5th) [22:30:17] Hmm. That should work. [22:30:23] 3VisualEditor / 3Editing Tools: VisualEditor: The Media dialog doesn't seem to apply any padding beneath the alt text input box, so it can almost overlap with the border of the dialog in Firefox (but not Chrome?) - 10https://bugzilla.wikimedia.org/64723 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low [22:30:24] Do you have anything in your server-side logs? [22:31:20] (03CR) 10Cmcmahon: [C: 032] [browser test] refactor bullets test to use API etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 (owner: 10Cmcmahon) [22:31:47] RoanKattouw, were you working on ve.ce.getOffset? [22:32:52] (03Merged) 10jenkins-bot: [browser test] refactor bullets test to use API etc. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131520 (owner: 10Cmcmahon) [22:32:52] James_F, nothing. [22:33:15] subbu: I'm out of ideas, then. :-( [22:33:36] ok .. i'll poke around later tonight or tomorrow .. if not, i could maybe do a clean install later. [22:33:39] thanks anyway. [22:34:56] edsanders: Not reently [22:34:58] +c [22:35:12] Other than the rewrite with David [22:35:18] which I haven't touched in a while [22:35:30] it's pending? [22:37:12] (03PS3) 10Krinkle: ve.init.mw.ViewPageTarget: Actually animate the toolbar during setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131071 (https://bugzilla.wikimedia.org/64751) [22:38:25] (03Abandoned) 10Cmcmahon: [browser test] Save dialog takes longer than 5s [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/129305 (owner: 10Cmcmahon) [22:45:26] Yeah it's pending [22:45:30] I try to work on it when I have time [22:45:35] Which doesn't happen as often as I'd like [22:53:17] Will it fix https://bugzilla.wikimedia.org/show_bug.cgi?id=64917 ? [22:56:32] edsanders: Code is https://gerrit.wikimedia.org/r/#/c/121563/ currently. [22:56:55] edsanders: Code review on that greatly appreciated. [23:01:23] edsanders: Maaaaybe [23:03:15] James_F, I missed this important detail: "git submodule update --init" ... I guess i hadn't updated my local version for a while. works now. [23:09:21] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] There is an extra space appearing in media search result dialog in betalabs - 10https://bugzilla.wikimedia.org/64911#c3 (10ryasmeen) 5RES/FIX>3REO This is still happening for me, when I always have scroll bar showing on MAC OS [23:11:35] haha yeah that'll do it [23:12:30] :) [23:13:09] i skipped past the code install intrs. since I already had code (or so I thought :)) and just updated LocalSettings.php config. [23:23:23] (03CR) 10Ori.livneh: [C: 032] Fix typo: this.transclusionNode -> this.selectedNode [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131091 (https://bugzilla.wikimedia.org/64717) (owner: 10Jforrester) [23:25:34] (03CR) 10Ori.livneh: [C: 032] Point language Beta Feature links to the right messages [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131506 (owner: 10Jforrester) [23:27:17] (03Merged) 10jenkins-bot: Fix typo: this.transclusionNode -> this.selectedNode [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131091 (https://bugzilla.wikimedia.org/64717) (owner: 10Jforrester) [23:28:32] (03Merged) 10jenkins-bot: Point language Beta Feature links to the right messages [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/131506 (owner: 10Jforrester) [23:28:36] 3VisualEditor / 3Editing Tools: VisualEditor: The Media dialog doesn't seem to apply any padding beneath the alt text input box, so it can almost overlap with the border of the dialog in Firefox (but not Chrome?) - 10https://bugzilla.wikimedia.org/64723#c1 (10Roan Kattouw) The PageLayout has 1.5em of padding... [23:29:50] 3VisualEditor / 3Editing Tools: VisualEditor: The Media dialog doesn't seem to apply any padding beneath the alt text input box, so it can almost overlap with the border of the dialog in Firefox (but not Chrome?) - 10https://bugzilla.wikimedia.org/64723#c2 (10Roan Kattouw) The PageLayout has 1.5em of padding... [23:45:50] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool adds stray line break at the end of the template - 10https://bugzilla.wikimedia.org/63128#c2 (10Roan Kattouw) Do you have a link to an example diff? I'm trying to reproduce this locally but I can't, in neither Chrome nor Firefox. [23:53:21] 3VisualEditor / 3Editing Tools: VisualEditor: Adding citations inside hieroglyphics, gallery, or mathematics blocks results in the inspector never closing - 10https://bugzilla.wikimedia.org/64915#c1 (10ryasmeen) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 56644 *** [23:53:35] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644#c8 (10ryasmeen) *** Bug 64915 has been marked as a duplicate of this bug. ***