[00:06:25] Hello :) [00:06:44] Could someone run Special:JavaScriptTest/qunit?filter=ve.ce.ContentBranchNode on fairly recent version of code? [00:09:18] (03PS1) 10Krinkle: [WIP] mw.ViewPageTarget: Get rid of FOUC on edit section brackets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131913 [00:26:50] (03PS2) 10Krinkle: mw.ViewPageTarget: Get rid of FOUC on edit section brackets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131913 [00:27:13] InezK: done [00:27:28] Do you get test failing, for missing class generatedContent? [00:27:28] 1. ve.ce.ContentBranchNode: getRenderedContents (0, 22, 22)Rerun100 ms [00:27:34] 2. ve.ce.ContentBranchNode: getRenderedContents (0, 1, 1)Rerun5 ms [00:27:38] Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36 [00:27:45] No failures [00:27:53] latest mw and ve [00:28:30] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Get rid of FOUC on edit section brackets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131913 (owner: 10Krinkle) [00:29:11] so, this is not a generated content: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/ce/nodes/ve.ce.MWEntityNode.js [00:29:57] (03PS3) 10Krinkle: mw.ViewPageTarget: Get rid of FOUC on edit section brackets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131913 [00:30:19] InezK: https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.ce.MWEntityNode [00:30:34] See Hierarchy [00:37:39] (03PS4) 10Krinkle: mw.ViewPageTarget: Get rid of FOUC on edit section brackets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131913 [00:38:13] (03CR) 10Krinkle: "reduce number of css selectors." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131913 (owner: 10Krinkle) [00:40:31] (03PS5) 10Krinkle: mw.ViewPageTarget: Get rid of FOUC on edit section brackets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/131913 [08:12:17] 3VisualEditor / 3ContentEditable: VisualEditor: Support magic pasting of HTML that contains a reference to a wiki image - 10https://bugzilla.wikimedia.org/64935#c3 (10Tisza Gergő) We tried to avoid using the description where a caption is available; the description is often less relevant and too verbose. Als... [09:39:38] (03CR) 10Krinkle: "I don't see any inline height style set after the animation is done. The only thing left is style="display: block;"." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131711 (owner: 10Esanders) [11:34:40] 3VisualEditor: VisualEditor: Beta warning should say that you can switch to wikitext without unsaved changes being lost - 10https://bugzilla.wikimedia.org/57699#c4 (10Elitre) The switch option appears to be currently working for IPs as well. [11:34:54] 3VisualEditor: VisualEditor: Beta warning should say that you can switch to wikitext without unsaved changes being lost - 10https://bugzilla.wikimedia.org/57699 (10Elitre) [11:34:55] 3VisualEditor: VisualEditor: Wikitext warning needs to be updated to refer to switching to wikitext editor without losing unsaved changes - 10https://bugzilla.wikimedia.org/57700 (10Elitre) [11:44:07] (03Abandoned) 10Esanders: Unset fixed height from slideDown in SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131711 (owner: 10Esanders) [12:25:59] (03PS1) 10Esanders: Directionality fixes in SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131960 [13:32:22] [13ve-dirtydiffbot] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/inez/ve-dirtydiffbot/commit/09221cdee1e679a8ac3d72e765504eeb5be13392 [13:32:22] 13ve-dirtydiffbot/06master 1409221cd 15Timo Tijhof: test: Fix to account for changes in visualeditor... [13:33:39] [travis-ci] inez/ve-dirtydiffbot#18 (master - 09221cd : Timo Tijhof): The build was broken. [13:33:39] [travis-ci] Change view : https://github.com/inez/ve-dirtydiffbot/compare/6088f1e47f92...09221cdee1e6 [13:33:39] [travis-ci] Build details : http://travis-ci.org/inez/ve-dirtydiffbot/builds/24625062 [13:38:35] [13ve-dirtydiffbot] 15Krinkle pushed 1 new commit to 06master: 02https://github.com/inez/ve-dirtydiffbot/commit/6397aa5594083cbb46e4d2976ec519af77bae111 [13:38:35] 13ve-dirtydiffbot/06master 146397aa5 15Timo Tijhof: Fix jshint warning [13:40:03] [travis-ci] inez/ve-dirtydiffbot#19 (master - 6397aa5 : Timo Tijhof): The build was fixed. [13:40:03] [travis-ci] Change view : https://github.com/inez/ve-dirtydiffbot/compare/09221cdee1e6...6397aa559408 [13:40:03] [travis-ci] Build details : http://travis-ci.org/inez/ve-dirtydiffbot/builds/24625552 [15:32:01] Heya. [15:36:59] Hi [16:20:22] (03Abandoned) 10Jforrester: [THOU SHALT NOT MERGE THEE] BetaWelcome tool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125242 (owner: 10Trevor Parscal) [16:23:24] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext warning needs to be updated to refer to switching to wikitext editor without losing unsaved changes - 10https://bugzilla.wikimedia.org/57700 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low s:5normal>3trivia [16:23:39] 3VisualEditor / 3MediaWiki integration: VisualEditor: Beta warning should say that you can switch to wikitext without unsaved changes being lost - 10https://bugzilla.wikimedia.org/57699 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low s:5normal>3enhanc [16:24:21] James_F: Thanks for filling in the gaps in the jq migrate mail [16:24:37] Krinkle: I think it's good to go. Send it? [16:24:45] Krinkle: Really really want that sent before the Hackathon. :-) [16:24:47] reading it over now [16:24:51] Good. [16:25:05] 'The instrumentation will and logging remain' -> 'The instrumentation and logging will remain' [16:25:08] :) [16:25:22] I don't think the instrumentation has a will for after we kill it. [16:25:34] Bah. :-P [16:30:53] http://www.mail-archive.com/wikitech-l@lists.wikimedia.org/msg75735.html [16:30:53] http://lists.wikimedia.org/pipermail/wikitech-l/2014-May/076340.html [16:31:06] Indeed. [16:52:54] 3VisualEditor / 3ContentEditable: VisualEditor: Support magic pasting of HTML that contains a reference to a wiki image - 10https://bugzilla.wikimedia.org/64935#c4 (10James Forrester) (In reply to Tisza Gergő from comment #3) > We tried to avoid using the description where a caption is available; the > descr... [16:56:34] (03PS32) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 [16:57:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [18:21:56] (03PS1) 10Krinkle: ve.ui.MWMediaResultWidget: Use .on() instead of .error() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132013 [18:30:03] (03CR) 10Esanders: ve.ui.MWMediaResultWidget: Use .on() instead of .error() (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132013 (owner: 10Krinkle) [18:32:39] edsanders: When looking this up in jquery source, I was disappointed to see how the .on(object) is implemented. Made me subconsciously avoid it. [18:32:53] (various typeof checks, then a for loop calling itself) [18:33:00] Oh well, details. I'll do it. [18:34:13] (03PS1) 10Cmcmahon: [browser test] Links test to use API for target page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132015 [18:35:37] (03PS2) 10Krinkle: ve.ui.MWMediaResultWidget: Use .on() instead of .error() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132013 [19:02:26] 3VisualEditor / 3Editing Tools: VisualEditor: Switching to edit source mode from VE is taking longer than usual - 10https://bugzilla.wikimedia.org/65012 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None As of May 6th, I am experiencing a lag in switching from VE to Edit source mode, after clicking on Ok... [19:08:56] 3VisualEditor: VisualEditor: Firefox displays new lists incorrectly, if you've just pasted the text onto the page - 10https://bugzilla.wikimedia.org/65014 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Type a few paragraphs of plain text in another document (e.g., an e-mail m... [19:42:05] (03CR) 10Cmcmahon: [C: 032] [browser test] Links test to use API for target page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132015 (owner: 10Cmcmahon) [19:43:39] (03Merged) 10jenkins-bot: [browser test] Links test to use API for target page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132015 (owner: 10Cmcmahon) [19:50:54] 3VisualEditor: VisualEditor: Firefox displays new lists incorrectly, if you've just pasted the text onto the page - 10https://bugzilla.wikimedia.org/65014#c1 (10WhatamIdoing) Created attachment 15315 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15315&action=edit Photo collage showing before-and-afte... [20:27:42] (03PS1) 10Cmcmahon: [browser test] Refactor Headings test to use the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132104 [20:41:03] (03CR) 10Esanders: [C: 032] ve.ui.MWMediaResultWidget: Use .on() instead of .error() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132013 (owner: 10Krinkle) [20:42:34] (03Merged) 10jenkins-bot: ve.ui.MWMediaResultWidget: Use .on() instead of .error() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132013 (owner: 10Krinkle) [20:44:06] (03CR) 10Cmcmahon: [C: 032] [browser test] Refactor Headings test to use the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132104 (owner: 10Cmcmahon) [20:45:36] (03Merged) 10jenkins-bot: [browser test] Refactor Headings test to use the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132104 (owner: 10Cmcmahon) [20:47:57] 3VisualEditor: VisualEditor: Pasting plain text from external sources inserts spurious new lines between paragraphs in Safari - 10https://bugzilla.wikimedia.org/65021 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Intention: Paste some plain text. Steps to Reproduce: 1. Type a few paragraphs of plai... [20:58:19] edsanders, around? [20:58:31] hi [20:59:37] I didn't get that issue with the confirmation dialog resolved yesterday [20:59:52] I still don't fully understand initialize vs. setup vs. open [21:01:12] and what I'd need to change about the current code (https://gist.github.com/Krenair/9f23ae9062804423d912 and https://gist.github.com/Krenair/adbe126eae978c6e5cef ) to make it ... well, work instead of throwing fatal errors etc. [21:18:26] 3VisualEditor: VisualEditor: If you insert a gallery into a list, the list formatting remains visible but is removed in wikitext - 10https://bugzilla.wikimedia.org/65022 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Intention: Add an image gallery at the top of a section. Steps to Reproduce: 1. O... [21:19:48] so initialise happens after the iframe is ready [21:20:19] setup/teardown happen each time it is opened [21:20:26] and are triggered by open/close [21:20:57] if you check the code in as WIP then I can work with it [21:23:08] also the dialog element needs to be attached to the global overlay [21:24:30] the dialogs windowset it attached to the global overlay so if you use that windowset you're ok [21:26:37] (03PS1) 10Alex Monk: Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [21:27:06] (03CR) 10jenkins-bot: [V: 04-1] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:27:08] (03CR) 10Alex Monk: [C: 04-1] "WIP. I can't -2 stuff here." [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:28:35] (03PS4) 10Alex Monk: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) [21:28:47] (03CR) 10jenkins-bot: [V: 04-1] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:29:18] (03CR) 10Alex Monk: [C: 04-1] "Relies on I292fb34d which doesn't work yet" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:29:25] edsanders, ^ [21:36:07] (03PS1) 10Cmcmahon: [browser test] Indent outdent test now uses the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132115 [22:08:39] 3VisualEditor: VisualEditor: If you insert a gallery into a list, the list formatting remains visible but is removed in wikitext - 10https://bugzilla.wikimedia.org/65022#c1 (10WhatamIdoing) This sort of happens if you insert a references list, which gives you this: * List item but not for im... [22:08:49] (03CR) 10Cmcmahon: [C: 032] [browser test] Indent outdent test now uses the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132115 (owner: 10Cmcmahon) [22:10:17] (03Merged) 10jenkins-bot: [browser test] Indent outdent test now uses the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132115 (owner: 10Cmcmahon) [22:15:22] edsanders, did you see the changes I uploaded? [23:02:21] so initialise happens after the iframe is ready [23:02:21] setup/teardown happen each time it is opened [23:02:21] and are triggered by open/close [23:02:21] if you check the code in as WIP then I can work with it [23:02:21] also the dialog element needs to be attached to the global overlay [23:02:23] the dialogs windowset it attached to the global overlay so if you use that windowset you're ok [23:02:32] Krenair, ^ this should get things working [23:04:18] (03CR) 10Esanders: [C: 04-1] Swap from using native confirm() to using an OOUI dialog when cancelling (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [23:05:11] edsanders, try removing the initialize call and see what happens when you press the button [23:05:23] because it isn't attached [23:05:49] (03CR) 10Esanders: [C: 04-1] Add confirmation dialog (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [23:06:39] (03CR) 10Esanders: Swap from using native confirm() to using an OOUI dialog when cancelling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [23:06:46] (03CR) 10Esanders: Add confirmation dialog (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [23:07:12] the iframe has to be attached to the dom [23:07:46] we have a windowset called dialogs [23:07:55] which is attached to a div called $globalOverlay [23:09:39] windowSet#getWindow calls addWindow, which attaches the window element to the winowset element [23:10:04] getWindow requires your dialog to be registered with it's factory [23:10:29] this.dialogs = new ve.ui.WindowSet( ve.ui.windowFactory, { '$': this.$ } ); (from ve.ui.Surface.js) [23:10:35] which you can see is ve.ui.windowFactory [23:11:05] hence the ve.ui.windowFactory.register call at the end of every dialog definition [23:11:19] if you register the confirmdialog with ve.ui.windowFactory [23:11:35] then you can just call surface.dialogs.getWindow('dialog').open() [23:16:19] I thought I was able to instantiate the dialog object without dealing with windowset etc.? [23:47:30] solved it [23:47:43] in probably the wrong way but I really don't have the time or patience for this right now [23:59:12] (03PS2) 10Alex Monk: [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [23:59:40] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)