[00:00:27] <grrrit-wm>	 (03PS5) 10Alex Monk: [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) 
[00:00:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[00:02:09] <grrrit-wm>	 (03PS3) 10Alex Monk: [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) 
[00:06:30] <grrrit-wm>	 (03PS6) 10Alex Monk: [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) 
[00:09:20] <grrrit-wm>	 (03PS7) 10Alex Monk: [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) 
[05:22:53] <grrrit-wm>	 (03PS33) 10Mooeypoo: [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 
[05:24:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo)
[05:42:07] <grrrit-wm>	 (03PS34) 10Mooeypoo: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 
[06:25:56] <grrrit-wm>	 (03PS1) 10Mooeypoo: Add MobileSurface to .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132142 
[07:11:09] <wikibugs>	 3VisualEditor / 3ContentEditable: VisualEditor: Using browser native interactive spell-check tool adds the missing letters to the DM, but at the top of the page in Chrome - 10https://bugzilla.wikimedia.org/63395#c3 (10Guillaume Paumier) Just a note that this is still happening: https://www.mediawiki.org/w/in...
[08:20:15] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[08:21:19] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[10:01:26] <twkozlowski>	 liangent: hola
[10:28:09] <wikibugs>	 3OOjs: OOjs: Support ES3 engines (parser tree) - 10https://bugzilla.wikimedia.org/63303#c9 (10Gilles Dubuc) That plan looks good to me. Since this bug is still marked as low priority, I imagine that you guys won't get around to it for at least a few months.  Since we're starting to work on UploadWizard and usi...
[11:29:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Add MobileSurface to .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132142 (owner: 10Mooeypoo)
[11:31:07] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add MobileSurface to .docs/eg-iframe.html [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132142 (owner: 10Mooeypoo)
[12:58:09] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Cache references in handleDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131687 (owner: 10Esanders)
[12:59:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: Cache references in handleDelete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131687 (owner: 10Esanders)
[16:51:47] <grrrit-wm>	 (03PS1) 10Mooeypoo: Cache image scalable promises by filename [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132207 
[16:53:32] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Cache image scalable promises by filename [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132207 (owner: 10Mooeypoo)
[16:53:39] <mooeypoo>	 oh foo, jenkins.
[16:54:30] <grrrit-wm>	 (03CR) 10Alex Monk: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester)
[16:55:29] <grrrit-wm>	 (03PS2) 10Mooeypoo: Cache image scalable promises by filename [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132207 
[17:50:43] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: Its possible to input a fraction value (with decimal point) in image size which results into showing wrong size in the review changes section - 10https://bugzilla.wikimedia.org/62756#c2 (10Moriel Schottlender) This doesn't happen anymore with the new MediaSizeWid...
[17:51:55] <mooeypoo>	 ryasmeen, can you verify this is fixed? I couldn't replicate https://bugzilla.wikimedia.org/show_bug.cgi?id=62293 
[18:13:26] <ryasmeen>	 mooeypoo: I still can 
[18:14:18] <mooeypoo>	 what the..
[18:14:24] <ryasmeen>	 Are you not getting the error message "Size values are invalid" when you switch to custom from default tab?
[18:15:41] <mooeypoo>	 ah, got it
[18:15:45] <mooeypoo>	 ok. Hm.
[18:16:02] <mooeypoo>	 I'll take care of it when I get back. That was weird, I didn't see it before.
[18:16:03] <mooeypoo>	 thanks!
[18:16:12] * unimoo  runs to class

[18:17:19] <ryasmeen>	 also the default size is appearing as 220x245 px where as the full size of the image is 71x79 px (smaller than the default size)
[18:19:28] <wikibugs>	 3VisualEditor / 3Editing Tools: VisualEditor: When an image has a full size which is smaller than the default size, it does not set the default size to the value of full size - 10https://bugzilla.wikimedia.org/62293#c11 (10ryasmeen) This is still happening:  Getting the error message "Size values are invalid...
[18:19:49] <grrrit-wm>	 (03CR) 10Esanders: [WIP] Add confirmation dialog (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[18:45:47] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[18:46:00] <wikibugs>	 3VisualEditor / 3Editing Tools: inconsistent behavior with page text in Media inspector - 10https://bugzilla.wikimedia.org/65038 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 15318   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15318&action=edit page title in media sea...
[18:46:27] <wikibugs>	 3VisualEditor / 3Editing Tools: inconsistent behavior with page text in Media inspector - 10https://bugzilla.wikimedia.org/65038#c1 (10Chris McMahon) Created attachment 15319   --> https://bugzilla.wikimedia.org/attachment.cgi?id=15319&action=edit sometimes selected text is in Media inspector search box
[18:57:43] <wikibugs>	 3VisualEditor / 3Editing Tools: inconsistent behavior with page text in Media inspector - 10https://bugzilla.wikimedia.org/65038 (10Chris McMahon)
[18:57:43] <wikibugs>	 3VisualEditor / 3Editing Tools: links interface does not highlight/remove default linked text - 10https://bugzilla.wikimedia.org/64655 (10Chris McMahon)
[19:29:04] <grrrit-wm>	 (03PS1) 10Cmcmahon: [browser test] Media has its own test page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132223 
[19:30:07] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] [browser test] Media has its own test page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132223 (owner: 10Cmcmahon)
[19:31:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: [browser test] Media has its own test page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132223 (owner: 10Cmcmahon)
[19:46:32] <grrrit-wm>	 (03PS1) 10Cmcmahon: [browser test] Don't select link text in test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132227 
[19:47:57] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] [browser test] Don't select link text in test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132227 (owner: 10Cmcmahon)
[19:49:29] <grrrit-wm>	 (03Merged) 10jenkins-bot: [browser test] Don't select link text in test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132227 (owner: 10Cmcmahon)
[20:11:25] <grrrit-wm>	 (03PS1) 10Cmcmahon: [browser test] References test has own page now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132230 
[20:15:34] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] [browser test] References test has own page now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132230 (owner: 10Cmcmahon)
[20:18:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: [browser test] References test has own page now [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132230 (owner: 10Cmcmahon)
[20:51:13] <kaldari>	 anyone know how to get the Cite functionality in VisualEditor working locally?
[20:51:25] <kaldari>	 TrevorParscal: ^ ?
[20:54:08] <kaldari>	 RoanKattouw: ^
[20:54:15] <kaldari>	 I have TemplateData set up and working
[20:58:55] <kaldari>	 looks like I have to add some definition at MediaWiki:Visualeditor-cite-tool-definition.json
[21:02:32] <Krenair>	 kaldari, 
[21:02:33] <Krenair>	 2014-05-02 18:02:53	<Krenair>	James_F: So I tried to look into that change that Roan just merged earlier
[21:02:33] <Krenair>	 2014-05-02 18:03:01	<Krenair>	But couldn't actually find the citation dialog
[21:02:50] <Krenair>	 2014-05-02 18:04:32	<James_F>	Krenair: It only activates if you set a MediaWiki: message.
[21:02:50] <Krenair>	 2014-05-02 18:04:42	<James_F>	Krenair: See en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit
[21:03:06] <kaldari>	 yep: http://core.local/index.php/MediaWiki:Visualeditor-cite-tool-definition.json
[21:03:10] <kaldari>	 just found it
[21:03:21] <kaldari>	 not documented anywhere of course ;)
[21:03:22] <Krenair>	 2014-05-02 18:05:27	<Krenair>	Ah, that'll be why. okay
[21:03:23] <Krenair>	 2014-05-02 18:05:35	<Krenair>	Is that documented anywhere?
[21:03:23] <Krenair>	 2014-05-02 18:05:56	<James_F>	Not yet.
[21:03:23] <Krenair>	 2014-05-02 18:06:04	<James_F>	Something for me to do this week.
[21:03:47] <kaldari>	 lol
[21:52:45] <Krenair>	 Is there something special I have to do to add a message to OOUI?
[21:53:35] <Krenair>	 I gave it an entry in the language json files and core.js
[21:54:03] <Krenair>	 then added the key to VisualEditor.hooks.php's oojs-ui module
[21:54:57] <Krenair>	 Yet the message functions do not think it exists
[21:57:09] <Krenair>	 ugh, relies on changing the oojs-ui module in MW core. of course.
[21:57:43] <grrrit-wm>	 (03PS1) 10Kaldari: Moving citation tool code into its own function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132312 
[22:01:36] <grrrit-wm>	 (03PS4) 10Alex Monk: [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) 
[22:04:01] <grrrit-wm>	 (03PS8) 10Alex Monk: [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) 
[22:04:59] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-1] "Ed's comment still applies" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[22:06:24] <grrrit-wm>	 (03CR) 10Alex Monk: [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[22:23:15] <wikibugs>	 3MediaWiki extensions / 3TemplateData: Example in api.php doesn't return anything! - 10https://bugzilla.wikimedia.org/65046 (10Mark Holmquist) 3NEW p:3Unprio s:3normal a:3None OK, so maybe this depends on the wiki, but I expect it to work on wikis where Template:Stub and Template:Example exist; on en...
[22:23:27] <wikibugs>	 3MediaWiki extensions / 3TemplateData: Example in api.php doesn't return anything! - 10https://bugzilla.wikimedia.org/65046 (10Mark Holmquist) p:5Unprio>3Low s:5normal>3enhanc
[22:27:18] <grrrit-wm>	 (03PS1) 10Alex Monk: Register OOUI confirmation dialog with windowFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) 
[22:27:49] <grrrit-wm>	 (03CR) 10Alex Monk: [C: 04-2] "Upstream dependency pending review" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[22:29:54] <grrrit-wm>	 (03PS9) 10Alex Monk: [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) 
[22:31:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Register OOUI confirmation dialog with windowFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk)
[22:31:49] <grrrit-wm>	 (03PS10) 10Alex Monk: [WIP] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) 
[22:33:12] <Krenair>	 wtf is that jenkins-bot -1?
[23:15:57] <Guest5716>	 hey
[23:16:11] <InezK>	 hey!
[23:16:25] <InezK>	 are you guys aware of problems with ve.init.mw.TargetEvents because of not matching names of events?
[23:42:45] <Krinkle>	 >> setTimeout(function () { console.log('Timo'); }, 2000);
[23:42:46] <ecmabot-wm>	 Krinkle: (number) 3737844653; Console: 'Timo'