[04:49:57] 3VisualEditor / 3MediaWiki integration: VisualEditor: Wikitext diff is not regenerated if VE content is the same but the page has subsequently changed - 10https://bugzilla.wikimedia.org/55393#c2 (10John Mark Vandenberg) At bug 55392 comment 3 James says that in core mediawiki functionality "you can't edit co... [07:42:49] (03PS8) 10Jforrester: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) [07:42:57] (03CR) 10Jforrester: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [07:43:02] (03CR) 10jenkins-bot: [V: 04-1] mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [07:44:19] (03PS9) 10Jforrester: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) [07:44:29] (03CR) 10Jforrester: "PS9 is a rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [07:46:46] (03PS10) 10Jforrester: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) [09:51:53] (03PS1) 10Jforrester: ve.ui.MWTitleInputWidget: Fix documentation (@cfg not @param) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132630 [10:12:36] (03PS1) 10Esanders: Add HTML conversion button to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132635 [12:02:26] (03PS2) 10Jforrester: ve.ui.MWTitleInputWidget: Fix documentation (@cfg not @param) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132630 [12:02:43] (03CR) 10Catrope: "PS2: rebase off of unnecessary dependency" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132630 (owner: 10Jforrester) [12:02:49] (03CR) 10Catrope: [C: 032] ve.ui.MWTitleInputWidget: Fix documentation (@cfg not @param) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132630 (owner: 10Jforrester) [12:03:10] RoanKattouw: Bah, it was an attempt to get you to merge the dependency too. :-P [12:04:37] (03CR) 10Krinkle: [C: 032] mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [12:04:45] Ha. [12:04:45] (03Merged) 10jenkins-bot: ve.ui.MWTitleInputWidget: Fix documentation (@cfg not @param) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132630 (owner: 10Jforrester) [12:04:53] Well, that fixes that one then. ;-) [12:05:12] 3VisualEditor / 3MediaWiki integration: VisualEditor: Use a hidden preference rather than cookie for logged-in users to remember hidebetawelcome - 10https://bugzilla.wikimedia.org/55551 (10James Forrester) 5PAT>3RES/FIX [12:05:20] Krinkle: Thank you. [12:06:25] (03Merged) 10jenkins-bot: mw.ViewPageTarget: Hide the welcome dialog via a preference if possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/125914 (https://bugzilla.wikimedia.org/55551) (owner: 10Jforrester) [12:10:47] (03CR) 10Krinkle: [C: 04-1] "wikitext has no boolean values, I'd like the specification to be clearer about what consumers are expected to do. I'd propose: Represent f" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:12:42] 3MediaWiki extensions / 3TemplateData: TemplateData: Add parameter type for url boolean - 10https://bugzilla.wikimedia.org/55331 (10Krinkle) [12:14:57] 3MediaWiki extensions / 3TemplateData: TemplateData: Add parameter type for boolean - 10https://bugzilla.wikimedia.org/55331 (10James Forrester) [12:17:37] (03CR) 10Jforrester: "I think using NULL as false is an epically bad idea. Maybe '0' as false and '1' as true?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:19:39] (03PS2) 10Krinkle: Add HTML conversion button to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132635 (owner: 10Esanders) [12:21:10] (03CR) 10Krinkle: "It wouldn't be null but empty string, wikitext only has strings. And the empty string (or rather, 0 or more whitespace characters) is the " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:22:25] (03CR) 10Jforrester: "Except it's a complete violation of database theory." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:23:21] (03CR) 10Krinkle: "'0' can work, too. But will require template authors to complicate their template as they probably previously used any non-empty value, an" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:24:56] (03CR) 10Jforrester: "Or:" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:26:15] (03CR) 10Krinkle: "'true' is just an arbitrary combination of characters, no more arbitrary than (empty string), "0" or "stroopwafel". Someone specified how " [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:29:06] (03CR) 10Krinkle: "I think I understand why you're thinking about null, you seem to have forgotten (just like last year when I won this bet), that passing an" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:29:44] (03CR) 10Krinkle: "I think you thought that {{..|foo=}} calls for the default and therefore is like null, but it is in fact very much an empty string." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:32:02] (03CR) 10Krinkle: "Let's use 0 / 1." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [12:33:37] (03CR) 10Krinkle: "Exposed the DOM root node itself to the console as well. Not sure if that's useful, feel free to undo." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132635 (owner: 10Esanders) [12:33:45] (03CR) 10Krinkle: [C: 031] Add HTML conversion button to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132635 (owner: 10Esanders) [12:50:09] Krinkle, documenting LESS with jsduck http://docs.sencha.com/extjs/4.2.2/#!/api/Global_CSS [13:06:27] Yep, I know. /** @var (which is why we don't have /** comments in src/, it trips jsduck) [13:08:39] I didn't know it supports mixins though [13:08:56] that's nice. It supports them fully (as in, it parses the @mixin functioname($param) line, like it does for javascript [14:50:26] (03CR) 10Helder.wiki: "Template authors use" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [15:11:29] (03CR) 10Catrope: [C: 032] Add HTML conversion button to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132635 (owner: 10Esanders) [15:13:11] (03Merged) 10jenkins-bot: Add HTML conversion button to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132635 (owner: 10Esanders) [15:14:48] (03CR) 10Catrope: "Trevor, do you think it's reasonable for the theming of the template dialog to be loaded instead of, rather than in addition to, the base " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132355 (owner: 10JGonera) [17:53:30] 3VisualEditor / 3MediaWiki integration: Loading TemplateData no longer works on non-English Wikipedias - 10https://bugzilla.wikimedia.org/65148 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3critic a:3None [[pl:Template:Cytuj stronę]] (cite web) definitely has TemplateData documentation, but it doesn't app... [17:53:36] James_F: ^ :( [17:53:51] i wanted to enable new citation tool on pl.wp, instead discovered this [17:54:53] MatmaRex: Try now? [17:55:31] MatmaRex: TemplateData are pageproperties, so you need to null-edit the template if you edit the /doc because the transclusion only applies on edit (inc. null edit), not action=purge. [17:55:37] still the same [17:55:43] i didn't edit anything [17:55:55] and the docs used to be there [17:56:03] MatmaRex: https://pl.wikipedia.org/w/api.php?action=templatedata&titles=Template:Cytuj_stron%C4%99 [17:56:08] it's using the page name with an underscore [17:56:13] or at least displaying one in the interface [17:58:15] MatmaRex: Does the API not return the new TemplateData for you? [17:58:33] James_F: it does return it. but VE doesn't seem to be reading this [17:58:38] James_F: i assume you can't reproduce the bug? [17:59:56] oh hmm, now it's there [17:59:59] MatmaRex: The TD comes through to me fine; but I don't know what the changes are, so… [18:00:13] MatmaRex: Caching is your friend. Wait, no, enemy. Wait, no, friend. … :-) [18:00:33] fairies. i blame fairies. [18:00:42] 3VisualEditor / 3MediaWiki integration: Loading TemplateData no longer works on non-English Wikipedias - 10https://bugzilla.wikimedia.org/65148#c1 (10James Forrester) 5NEW>3RES/INV Caching issue. [18:00:50] MatmaRex: :-) [18:01:12] 3VisualEditor / 3MediaWiki integration: Loading TemplateData no longer works on non-English Wikipedias - 10https://bugzilla.wikimedia.org/65148#c2 (10Bartosz Dziewoński) It fixed itself. I blame fairies. [18:01:23] the fact that the template is displayed with an underscore is still a bug! [18:01:41] It doesn't display with an underscore unless you enter an underscore. [18:01:50] Template:Foo_bar will show if you enter "Foo_bar". [18:01:59] If you enter "Foo bar" it will show as such. [18:03:03] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTemplatePage: Display template name in text form, not dbkey form [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132723 [18:03:08] James_F: ^ [18:03:12] not true [18:03:29] Hmm. Odd. [18:04:08] mw.Title methods have very silly names. [18:04:18] Clearly. :-) [18:16:26] (03CR) 10Catrope: [C: 032] ve.ui.MWTemplatePage: Display template name in text form, not dbkey form [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132723 (owner: 10Bartosz Dziewoński) [18:17:56] (03Merged) 10jenkins-bot: ve.ui.MWTemplatePage: Display template name in text form, not dbkey form [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132723 (owner: 10Bartosz Dziewoński) [18:27:20] (03PS1) 10Catrope: Make citation tools' compatibility check case-insensitive [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132725 [18:27:25] MatmaRex: ---^^ [18:28:05] RoanKattouw: .toLowerCase(), heh [18:28:13] What else :) [18:28:33] hm well, you could probably use mw.Title [18:28:40] assuming we care [18:28:45] Hmm yeah [18:28:48] I probably should, right? [18:28:51] Because what about Cite_news [18:29:16] (03CR) 10Catrope: [C: 04-1] "Per MatmaRex, needs to use mw.Title to deal with Cite_news" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132725 (owner: 10Catrope) [18:29:47] also, it would probably be cool to allow for more aliases than just one [18:30:06] Yeah [18:30:08] (both in the citation tool and in MWTransclusionDialog [18:30:09] ) [18:30:11] Yup [18:30:18] I should break out this function, too [18:30:21] Because it's duplicated in two places [18:30:57] RoanKattouw: three [18:30:58] at least [18:30:59] ve.dm.MWTransclusionNode.prototype.isSingleTemplate [18:32:02] RoanKattouw: James_F: btw, i just enabled this at pl.wp too. [18:34:03] MatmaRex: Yeah I just discovered that [18:34:07] It's *already* been factored out [18:34:12] The factored-out version just isn't being used [18:34:15] :D [18:55:04] (03PS2) 10Catrope: Make citation tools' compatibility check use normalized titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132725 [18:55:49] MatmaRex: OK there it is --^^ . That picks up on {{cite_web}} too [18:59:55] lotsa changes :o [19:01:05] Yeah it was a mess [19:10:20] (03PS3) 10Catrope: Make citation tools' compatibility check use normalized titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132725 [19:10:53] (03CR) 10Jforrester: [C: 031] Make citation tools' compatibility check use normalized titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132725 (owner: 10Catrope) [19:12:02] (03CR) 10Bartosz Dziewoński: [C: 032] Make citation tools' compatibility check use normalized titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132725 (owner: 10Catrope) [19:13:33] (03Merged) 10jenkins-bot: Make citation tools' compatibility check use normalized titles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132725 (owner: 10Catrope) [19:32:07] (03PS4) 10Jforrester: Add 'boolean' type support [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) [19:45:52] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/132469 (https://bugzilla.wikimedia.org/55331) (owner: 10Jforrester) [20:00:09] (03PS1) 10Jforrester: Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132736 [20:00:25] (03PS2) 10Catrope: Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132736 (owner: 10Jforrester) [20:02:29] (03PS3) 10Jforrester: Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132736 [20:02:42] (03PS4) 10Jforrester: Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132736 [20:03:08] (03CR) 10Catrope: [C: 032] Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132736 (owner: 10Jforrester) [20:05:20] (03Merged) 10jenkins-bot: Follow-up Ica9e5a9284: Actually make visualeditor-hidebetawelcome work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132736 (owner: 10Jforrester) [20:36:43] 3VisualEditor / 3MediaWiki integration: VisualEditor: Document what is needed in terms of support for custom MediaWiki skins - 10https://bugzilla.wikimedia.org/61500#c3 (10s7eph4n) I have a skin ([[Skin::Cameleon]]) that's based on Dantmman's excellent tutorial ([[Manual:Skinning/Tutorial]]). All I really di... [22:06:14] 3VisualEditor / 3Editing Tools: VisualEditor: If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again - 10https://bugzilla.wikimedia.org/65166 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Create a page that c... [22:24:17] (03PS1) 10Bartosz Dziewoński: Make the "Cite" label on the toolbar translateable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132748 [22:24:38] (03CR) 10Bartosz Dziewoński: "Not tested, hope it works." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132748 (owner: 10Bartosz Dziewoński) [22:45:29] Krinkle: feel like looking? very tiny, very annoying :) to me right now ^ [23:04:02] (03CR) 10Krinkle: "No "en" entry?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132748 (owner: 10Bartosz Dziewoński) [23:04:04] MatmaRex: [23:04:35] kasdbfdsflkbsadkjadf [23:05:29] (03PS2) 10Bartosz Dziewoński: Make the "Cite" label on the toolbar translateable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132748 [23:05:37] i even had the file open, i just forgot to type this in, eh [23:06:07] i need more sugar. [23:08:39] (03PS3) 10Krinkle: mw.Target: Make the "Cite" label in the toolbar translatable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132748 (owner: 10Bartosz Dziewoński) [23:08:46] (03CR) 10Krinkle: [C: 031] "Untested. LGTM." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132748 (owner: 10Bartosz Dziewoński) [23:09:30] Krinkle: would it be possible to get this and the previous patch too maybe deployed on monday? [23:10:29] previous patch = https://gerrit.wikimedia.org/r/132725 [23:34:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132748 (owner: 10Bartosz Dziewoński)