[00:01:44] 3VisualEditor / 3Editing Tools: VisualEditor: Why does it say "newspaper" instead of "news"? - 10https://bugzilla.wikimedia.org/65207 (10WhatamIdoing) 3NEW p:3Unprio s:3trivia a:3None https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-cite-tool-definition.json says: { "name": "news", "icon": "... [14:55:56] (03CR) 10Manybubbles: [C: 032] "MatmaRex says " they totally work " and they look sane so merging to deployment branch." [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/132770 (owner: 10Jforrester) [14:56:35] (03CR) 10Manybubbles: [C: 032] "MatmaRex says " they totally work " and they look sane so merging to deployment branch." [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/132773 (owner: 10Jforrester) [14:56:54] (03CR) 10Manybubbles: [C: 032] "MatmaRex says " they totally work " and they look sane so merging to deployment branch." [extensions/VisualEditor] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/132769 (owner: 10Jforrester) [14:57:04] (03CR) 10Manybubbles: [C: 032] "MatmaRex says " they totally work " and they look sane so merging to deployment branch." [extensions/VisualEditor] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/132772 (owner: 10Jforrester) [14:57:44] (03Merged) 10jenkins-bot: Follow-up Id401d973: mw.Target: Make the "Cite" label in the toolbar translatable [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/132770 (owner: 10Jforrester) [14:58:58] (03Merged) 10jenkins-bot: Make citation tools' compatibility check use normalized titles [extensions/VisualEditor] (wmf/1.24wmf3) - 10https://gerrit.wikimedia.org/r/132773 (owner: 10Jforrester) [14:59:18] (03Merged) 10jenkins-bot: Follow-up Id401d973: mw.Target: Make the "Cite" label in the toolbar translatable [extensions/VisualEditor] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/132769 (owner: 10Jforrester) [14:59:20] (03Merged) 10jenkins-bot: Make citation tools' compatibility check use normalized titles [extensions/VisualEditor] (wmf/1.24wmf4) - 10https://gerrit.wikimedia.org/r/132772 (owner: 10Jforrester) [15:02:45] 3VisualEditor: VisualEditor: Automatically place cursor in edit summary field - 10https://bugzilla.wikimedia.org/65222 (10Elitre) 3NEW p:3Unprio s:3normal a:3None TeamGale doesn't recall that in order to fill the edit summary field you need to click on that first - if she doesn't, the text she's typing... [15:28:32] (03PS2) 10Bartosz Dziewoński: Move shortcut keys help from "Page options" dropdown to "Help" popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132911 [15:37:42] 3VisualEditor: VisualEditor: Automatically place cursor in edit summary field - 10https://bugzilla.wikimedia.org/65222 (10WhatamIdoing) [15:37:43] 3VisualEditor: VisualEditor: Edit summary typed into the article instead of the Save dialog in Firefox - 10https://bugzilla.wikimedia.org/64521 (10WhatamIdoing) [16:31:48] James_F, hey. Will there be a hangout today? [16:37:40] (03CR) 10Jforrester: [C: 04-1] "Displaying keyboard characters in the document/UI display font is really fugly and much less clear than a monospaced font, and this effect" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [16:46:02] (03CR) 10Bartosz Dziewoński: "Plain monospaced that this currently uses is awful. There are a couple of places we could steal the styling from, like GitHub's shortcut k" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [16:49:38] hi all [16:50:08] hi rmoen, and bye rmoen :( (but thanks for your work!) [16:50:20] James_F: you around? [16:50:26] Hey, yes. [16:50:37] Krenair: Yeah, but it may be just a couple of us. [16:53:41] TrevorParscal, can you justify this: [16:53:42] if ( !this.isDisabled() && e.which === OO.ui.Keys.SPACE ) { [16:53:42] if ( this.isHyperlink ) { [16:53:42] this.onClick(); [16:53:42] return true; [16:53:42] } [16:53:43] } [16:53:54] (ButtonWidget [16:54:00] (ButtonWidget#onKeyPress) [16:54:14] 1. why only on isHyperLink? [16:54:29] 2. why only on space, not enter? [16:57:33] Hi James_F, I was just wondering if this diff https://en.wikipedia.org/w/index.php?title=Anaconda,_Montana&diff=prev&oldid=608235426 could be related to broken cruft-injecting plugins or it's something totally unrelated I need to report. [16:57:45] * James_F looks. [16:57:49] Eww. [16:58:08] Yeah, that really definitely looks like a cruft-injecting plugin. :-( [16:58:11] Very nasty. [16:58:18] the user did manage to revert him/herself later, which is still good :) [16:58:33] Ha. Indeed. [16:58:49] I don't think I recall seeing it before, so I'll file this as new - and you'll eventually merge if needed. thank you! [17:02:27] 3VisualEditor / 3Editing Tools: VisualEditor: If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again - 10https://bugzilla.wikimedia.org/65166#c1 (10Moriel Schottlender) This image is rendered as an inline image and the dialog, at the moment, w... [17:05:59] (03CR) 10Esanders: [WIP] Add confirmation dialog (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:08:27] 3VisualEditor / 3Editing Tools: VisualEditor: If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again - 10https://bugzilla.wikimedia.org/65166#c2 (10Liangent) (In reply to Moriel Schottlender from comment #1) > This image is rendered as an inli... [17:11:41] James_F, I just realized the source of sherry's bug, and it's related to double-clicking (might actually be an indication of a bigger bug) [17:11:59] Kk. [17:12:13] 3VisualEditor / 3Editing Tools: VisualEditor: If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again - 10https://bugzilla.wikimedia.org/65166#c3 (10Moriel Schottlender) Okay I just realized a huge bug: The image dialog popup/button doesn't app... [17:12:19] Eww. [17:12:30] Double-clicking is an issue in a couple of areas right now. [17:12:35] yeah... not good. The image dialog shouldn't appear (and the context/icon doesn't) but the double-click opens it [17:12:41] E.g. double-clicking a citation reference opens the reference dialog, not the citation dialog. [17:12:43] and then it spectacularly fails [17:12:46] oh [17:12:49] Yeah. [17:12:51] Hmm. [17:13:30] well, the good news is that this is supposed to be fixed by the new model, but for the moment this is a pretty annoying bug for people who work on inline images. Hm. [17:13:36] Yeah. :-( [17:13:44] Let's just get the model merged? :-) [17:13:50] I'm all for that [17:14:06] but not before Wednesday, no? ... it should be thoroughly tested [17:14:33] Like me this week. ha. waa. [17:14:53] * James_F grins. [17:15:10] Not you this week. But edsanders's working on it, apparently, at least. :-) [17:15:46] okay, cool. edsanders, be aware of that bug too, then (double-clickage gone mad) https://bugzilla.wikimedia.org/show_bug.cgi?id=65166 [17:16:00] what am I working on? [17:17:45] edsanders: Reviewing image bugs and especially https://gerrit.wikimedia.org/r/#/c/120808/ according to you. [17:18:30] (03CR) 10Jforrester: [C: 04-1] "I think this should be moved into the Disambiguation extension (which may require some plumbing work on the VE end)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [17:22:28] 3VisualEditor / 3MediaWiki integration: VisualEditor: Broken browser plugins cause cruft to be injected into the page (tracker) - 10https://bugzilla.wikimedia.org/52327 (10Elitre) [17:22:30] 3VisualEditor: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Google Maps?) - 10https://bugzilla.wikimedia.org/65227 (10Elitre) 3NEW p:3Unprio s:3normal a:3None See link provided above. [17:24:52] I <3 this wikibugs bot. [17:25:59] 3VisualEditor: false "wiki is read-only mode" message in beta labs - 10https://bugzilla.wikimedia.org/65228 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Seen in automated tests in beta labs 11 May and 12 May (and occasionally earlier). Browser encounters a modal dialog saying "Error loading dat... [17:26:09] Elitre: Yeah, it's very helpful. [17:26:57] 3VisualEditor: false "wiki is read-only mode" message in beta labs - 10https://bugzilla.wikimedia.org/65228#c1 (10Chris McMahon) Created attachment 15357 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15357&action=edit read-only status modal dialog in VE [17:26:57] James_F: why is the Cite label broken? [17:27:09] Elitre: In enwiki? Refresh. [17:27:16] Elitre: Also, see forthcoming bug. [17:28:11] * Elitre likes "Cite" better now :) [17:30:13] 3VisualEditor: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Google Maps?) - 10https://bugzilla.wikimedia.org/65227#c1 (10Richard Morris) Not quite sure it was a plugin, it could have been user error, cut and pasting the wrong thing. The user did correct them self in the next edit. [17:34:51] (03PS6) 10Alex Monk: [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [17:35:59] edsanders, I am so much happier with that change now. Thank you [17:36:10] Don't like the typeof check much, but eh [17:41:43] 3VisualEditor: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Google Maps?) - 10https://bugzilla.wikimedia.org/65227#c2 (10Elitre) Yeah, it could be. James had confirmed my theory and that's why I filed it anyway. But I noticed the revert and was really glad about it. Success, righ... [17:45:13] 3VisualEditor / 3Data Model: VisualEditor: (Possibly) Yet Another Broken Browser Plugin injecting mess into edits (Google Maps?) - 10https://bugzilla.wikimedia.org/65227#c3 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low (In reply to Richard Morris from comment #1) > Not quite sure it was a plugin, it c... [17:51:28] (03PS1) 10Umherirrender: Adjust message 'visualeditor-dialog-beta-welcome-content' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132962 [17:55:59] (03CR) 10Jforrester: [C: 04-1] "This isn't actually correct as written; the switch-to-edit-source mode is only triggered manually by choosing the option, and clicking "ed" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132962 (owner: 10Umherirrender) [18:02:42] 3VisualEditor / 3ContentEditable: VisualEditor: Edit summary typed into the article instead of the Save dialog in Firefox - 10https://bugzilla.wikimedia.org/64521 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5minor>3major [18:02:59] 3VisualEditor / 3ContentEditable: VisualEditor: Automatically place cursor in edit summary field - 10https://bugzilla.wikimedia.org/65222 (10James Forrester) 5NEW>3ASS p:5Unprio>3High s:5normal>3minor a:3Ed Sanders [18:08:16] James_F: I'm sure the read-only was not VE itself, but I do wonder if you've ever seen that msg. in VE or know what might cause it. [18:09:15] chrismcmahon: It happens locally when I lock the DB manually, and I've seen it when wikis are under high load in production due to the auto-lock. [18:09:31] chrismcmahon: I believe it happens only in extremes, when master is lagging with load. [18:10:30] James_F: thanks, that's helpful, I've never seen that. I can't imagine what would cause that kind of load in beta labs at that hour though. [18:10:45] (03Abandoned) 10Umherirrender: Adjust message 'visualeditor-dialog-beta-welcome-content' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132962 (owner: 10Umherirrender) [18:10:48] chrismcmahon: Labs itself might have ground to a halt, maybe? [18:18:44] Krenair, it's pretty standard if you're doing overloading in JS. $.append will have a bunch of typeof checks internally. [18:19:02] yeah, I know. I still don't like it :P [18:19:07] 3VisualEditor / 3Editing Tools: VisualEditor: If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again - 10https://bugzilla.wikimedia.org/65166#c4 (10WhatamIdoing) Not exactly: I selected it and pressed the Return key. It has the same effect. [18:21:35] oooh, i just realized the reason why VE "transclusions" can have multiple parts – to support "wrapping" start/end template calls [18:21:44] and these just work [18:21:44] damn, that's neat [18:23:54] hm, is it just me, or is the "notices" thing (exclamation mark in a triangle) disappearing from VE toolbar if you open a page for editing, close VE, then open it again (on the same page)? [18:27:20] (03CR) 10Esanders: [C: 04-1] [WIP] Add confirmation dialog (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [18:54:51] MatmaRex, probably, file a bug [19:00:54] 3VisualEditor: References as part of a file description are misnumbered - 10https://bugzilla.wikimedia.org/65235 (10Martijn Hoekstra) 3NEW p:3Unprio s:3normal a:3None In https://en.wikipedia.org/w/index.php?title=Female_promiscuity&oldid=607751101 references [74], [75] and [76] show up as 1, 2 and 3 in... [19:02:50] filing bugs is boring [19:03:09] 3VisualEditor / 3MediaWiki integration: The "notices" thing (exclamation mark in a triangle) disappears from VE toolbar if you open a page for editing, close VE, then open it again (on the same page) - 10https://bugzilla.wikimedia.org/65236 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None The... [19:18:30] (03PS1) 10Esanders: Button accessibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/132979 [19:19:33] (03CR) 10Esanders: "I'm assuming onclick being inside isHyperLink is just a bug, and not including 'enter' was an oversight. Native buttons fire clicks for bo" [oojs/ui] - 10https://gerrit.wikimedia.org/r/132979 (owner: 10Esanders) [19:29:45] (03PS1) 10Esanders: Remove @abstract from classes which can be instantiated [oojs/ui] - 10https://gerrit.wikimedia.org/r/132980 [20:06:54] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15359 --> https://bugzilla.wikimedia.org/attachment.cgi?id=153... [20:21:55] (03PS2) 10Jforrester: Button accessibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/132979 (https://bugzilla.wikimedia.org/62337) (owner: 10Esanders) [20:25:22] 3VisualEditor / 3Editing Tools: VisualEditor: The Media dialog doesn't seem to apply any padding beneath the alt text input box, so it can almost overlap with the border of the dialog in Firefox (but not Chrome?) - 10https://bugzilla.wikimedia.org/64723#c3 (10ryasmeen) The same issue appears to be in the Ref... [20:31:38] 3VisualEditor / 3Editing Tools: VisualEditor: Scroll bar appears to be a bit wider on hovering over it in Firefox - 10https://bugzilla.wikimedia.org/65240 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15362 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15362&action=edit sc... [20:48:01] (03CR) 10Esanders: "Please avoid editing my patches, it clutters my local branch list." [oojs/ui] - 10https://gerrit.wikimedia.org/r/132979 (https://bugzilla.wikimedia.org/62337) (owner: 10Esanders) [20:49:08] 3OOjs UI: OOjs UI: Buttons and button-like things should be keyboard-accessible - 10https://bugzilla.wikimedia.org/62337 (10Ed Sanders) a:5Trevor Parscal>3Ed Sanders [20:53:22] 3VisualEditor / 3Editing Tools: VisualEditor: Dialog panes don't seem to apply any padding to the bottom of their content in Firefox (but not Chrome), so the contents of the pane can almost overlap with the border of the dialog - 10https://bugzilla.wikimedia.org/64723 (10James Forrester) p:5Low>3Normal [20:58:36] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page notices alert not shown the second time you edit a page in the same JS session (but not in Chrome/Firefox?) - 10https://bugzilla.wikimedia.org/65236#c1 (10James Forrester) 5NEW>3ASS p:5Unprio>3Normal s:5normal>3minor What browser does thi... [21:05:07] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239#c1 (10ryasmeen) The following steps ensure reproducing the issue for all images: 1.Insert a new image in a page and save the page 2.Reop... [21:14:11] anybody around? [21:15:19] how do i execute a script inside a ooui iframe? i have $.getScript('http://example.com/foo.js').done(…), i want this, but executing the script with the context of the iframe (e.g. the document, window, etc. pointing to the ones "inside") [21:15:40] this.$.getScript doesn't seem to work at all [21:15:57] $.getScript.call( this.$, 'http://example.com/foo.js' ) doesn't seem to work as i expect it to [21:16:48] (this is because i have a hairy jquery plugin which sets events on document, which obviously causes all sorts of funniness with the iframes) [21:18:59] i don't really want to reimplement getScript myself, eh [21:25:19] inside the dialog class, this.$ will refer to the jquery of the iframe document [21:25:47] i know [21:26:06] (it will actually refer to a bastard jQuery-like function) [21:26:38] but eh, looking at jquery code, it seem like the document to append to script to is hardcoded to be the parent one [21:26:46] so i guess i'm reimplementing it after all [21:33:00] (03CR) 10Esanders: "FIXME: This has completely broken dialogs on Desktop. It helps to test CSS changes before swinging your +2 hammer." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/131243 (owner: 10JGonera) [21:39:38] goddam useless jquery [21:49:10] ugh, and the way ooui does this.$ is also incredibly annoying [21:55:20] is there a reason this.$ is created in this ass-backwards way (OO.ui.Element.getJQuery) instead of actually just executing jquery.js again in the context of the iframe? performance or laziness, i guess? [22:02:52] ugh [22:09:36] (03PS1) 10Vikassy: [browser test] Testing use of existing reference in Reference User Interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133027 [22:11:22] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239#c2 (10ryasmeen) For Chrome the error appearing is a bit different:Uncaught TypeError: Cannot read property 'width' of undefined [22:13:35] alright, let's just load another jquery inside the iframe. what's the worst that could happen, right? [22:52:09] 3VisualEditor: VisualEditor: Using "page down" (PgDn) key to scroll down moves the wrong number of lines if the toolbar is on multiple lines - 10https://bugzilla.wikimedia.org/65241 (10WhatamIdoing) 3NEW p:3Unprio s:3minor a:3None Steps to Reproduce: 1. Open a long page in VisualEditor. Press Ctrl-+... [23:03:32] (03PS3) 10Alex Monk: Allow extensions to add extra meta item checkboxes to the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) [23:06:00] Could someone take a look at that? ^ There has got to be something wrong with the way I just set ve.ui.MWSettingsPage.extraMetaCheckboxes... [23:09:22] (03CR) 10Cmcmahon: [C: 032] [browser test] Testing use of existing reference in Reference User Interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133027 (owner: 10Vikassy) [23:10:52] (03Merged) 10jenkins-bot: [browser test] Testing use of existing reference in Reference User Interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133027 (owner: 10Vikassy) [23:13:51] (03CR) 10Alex Monk: Allow extensions to add extra meta item checkboxes to the page settings dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [23:51:38] (03PS7) 10Alex Monk: [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [23:54:20] (03PS8) 10Alex Monk: [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [23:56:07] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any page on production after an edit with mobile VE - 10https://bugzilla.wikimedia.org/65109#c1 (10ryasmeen) In chrome,the error that appears in the console while saving a page is: Uncaught TypeError: Cannot read property 'replace' of undefined Ho...