[00:08:32] huh, i just looked up something javascript-related on stackoverflow, and it was answered by Krinkle. :D [00:13:48] James_F|Away: RoanKattouw_away: so, remember when i threatened to implement a custom "editor" for {{coord}} inside of VE? well, i just did, and it sorta kinda works. http://pastebin.com/eQcjKTWm [00:14:53] you get 5 points for each bad practice and outright error you notice. i think you can get at least 30 points on this baby. :> [00:24:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: Page notices alert not shown the second time you edit a page in the same JS session (but not in Chrome/Firefox?) - 10https://bugzilla.wikimedia.org/65236#c2 (10Bartosz Dziewoński) I tested on Opera Next 22 and Opera 12 with the same effect. Maybe this is... [02:22:36] 3VisualEditor: VisualEditor: Using "page down" (PgDn) key to scroll down moves the wrong number of lines if the toolbar is on multiple lines - 10https://bugzilla.wikimedia.org/65241#c1 (10Dan Kindsvater) Please see https://en.wikipedia.org/wiki/File:Screenshot1_of_Lamb_article_in_VE,_monobook,_Firefox.png (Wi... [06:16:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: Browser greylist notice alert not shown the second time you edit a page in the same JS session - 10https://bugzilla.wikimedia.org/65236#c3 (10James Forrester) p:5Normal>3Low Aha, yes, when the only warning is the browser warning I also get this. Howev... [06:41:44] (03PS1) 10Mooeypoo: If no media is found display a message in media insert dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133050 (https://bugzilla.wikimedia.org/52463) [06:44:47] James_F, I am pretty sure that's not a good title for the bug fix, but my brain is in post-exam melted state, so I couldn't think of a better phrasing. [06:45:14] It started out as "Show 'no images found' message if no images were found." so.. I guess I marginally improved on it. [06:45:16] unimoo: No worries. Get some sleep! [06:45:49] unimoo: It's 02:45 there, already. Oy. [06:45:52] Aye, going now [06:46:29] nightnight [08:13:08] (03CR) 10Vikassy: "Updated it in https://gerrit.wikimedia.org/r/#/c/133027/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 (owner: 10Vikassy) [08:13:38] (03Abandoned) 10Vikassy: [browser test] Testing use of existing reference in Reference User Interface. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/121586 (owner: 10Vikassy) [08:21:54] 3VisualEditor: Where/what have I edited - 10https://bugzilla.wikimedia.org/65247 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None This led to a discussion on VE and diff views and the opinion that many of us were switching back to wikicode to get to the diff. This is a representation of the fact t... [09:00:38] 3VisualEditor / 3ContentEditable: Clearing float from a template like {{-}} doesn't work. - 10https://bugzilla.wikimedia.org/65249 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None In the linked article, the content is not cleared after floats of the tables when using the template {{-}} which tra... [09:03:20] (03CR) 10Esanders: [C: 04-1] "few more minor issues" (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [09:15:37] 3VisualEditor / 3ContentEditable: Clearing float from a template like {{-}} doesn't work. - 10https://bugzilla.wikimedia.org/65249 (10Derk-Jan Hartman) [09:15:38] 3VisualEditor: VisualEditor: Adjacent floating tables are offset by vertical space because of intervening - 10https://bugzilla.wikimedia.org/57372 (10Derk-Jan Hartman) [11:27:26] (03PS1) 10Esanders: Fix desktop dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133060 [11:32:39] 3OOjs UI: OOjs UI: Move transition timings in skin specific file - 10https://bugzilla.wikimedia.org/65254 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3None We have cases of setTimeout( fireAfterTransion, 250 ), however the timings are skin specific, so we should move these constants into a config js file... [11:52:51] 3OOjs UI: OOjs UI: Move transition timings in theme specific files - 10https://bugzilla.wikimedia.org/65254 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low s:5normal>3enhanc [11:53:54] edsanders: Hmm… the mobile CSS is getting loaded for desktop context? [11:54:36] well if you look at the file manifests... [11:54:46] edsanders: 'Cos they weren't when I tested. [11:55:04] And they clearly shouldn't ever be loaded for desktop users ever. [11:55:32] did you test SA? [11:55:40] SA loads the wrong CSS? [11:55:45] No, I tested actual MW. [11:56:30] where's the MW change that goes with it [11:56:40] yes, this change which you +2'd https://gerrit.wikimedia.org/r/#/c/131243/2/demos/ve/index.html [11:57:14] Oh, hmm, I thought the '' section was magically not loaded on desktop SA. [11:57:21] But we didn't actually do that work yet. :-) [11:57:29] Both those lines should be killed with fire. [11:58:38] magic? it's HTML [11:59:13] With JS loading the demo and presumably unloading stuff being possible. [11:59:53] unloading stuff? [11:59:53] 3VisualEditor / 3Initialisation: Do not be fooled by "Request desktop site" option in mobile browsers - 10https://bugzilla.wikimedia.org/65255 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Such an option exists in Chrome and Firefox on Android, and maybe in some other browsers too. I believe what th... [12:00:36] all we can do is modify the grunt script to never bring it in in the first place [12:01:39] Wasn't Krinkle working on a mobile SA demo? Or you? [12:01:41] * James_F forgets. [12:01:58] There is a post-it for it, I havent' started on that yet. [12:02:20] But yes, modifying the grunt script to not load the mobile items for desktop would be a good start. [12:02:30] Indeed, 'visualEditor.mobile' shouldn't be in there. [12:02:51] 3VisualEditor / 3Initialisation: Do not be fooled by "Request desktop site" option in mobile browsers - 10https://bugzilla.wikimedia.org/65255#c1 (10James Forrester) Do you mean "make jquery.client detect for Firefox mobile"? If so, that's a very different bug to how you've written this one. :-) [12:03:14] * James_F will work on the mobile demo, maybe. [12:03:22] If edsanders isn't going to in the next 5 minutes. :-) [12:03:51] am working on removing mobile from the desktop demo at least [12:03:55] but sure [12:04:08] * James_F will wait 5 minutes then. [12:04:23] I guess we can just remove visualEditor.mobile from modules.json in lib/ve. That's not used anywhere yet. [12:04:29] Yeah. [12:04:34] Eventually the build-loader should use dependencies instead of just dumping it all in [12:04:39] * James_F nods. [12:05:37] 3VisualEditor / 3Initialisation: Do not be fooled by "Request desktop site" option in mobile browsers - 10https://bugzilla.wikimedia.org/65255#c2 (10Liangent) (In reply to James Forrester from comment #1) > Do you mean "make jquery.client detect for Firefox mobile"? If so, that's a > very different bug to ho... [12:09:21] 3VisualEditor / 3Initialisation: Do not be fooled by "Request desktop site" option in mobile browsers - 10https://bugzilla.wikimedia.org/65255#c3 (10James Forrester) (In reply to Liangent from comment #2) > (In reply to James Forrester from comment #1) > > Do you mean "make jquery.client detect for Firefox m... [12:11:54] Krinkle: What's the exclusion control for Gruntfile.js? Will [ modules, !'visualEditor.mobile' ] work? [12:12:13] No, that's for file expansion only [12:12:15] file patterns [12:12:20] Helpful. [12:12:38] !'visualEditor.mobile' === false [12:12:47] That would never make it to grunt [12:13:03] '!visualEditor.mobile' even. [12:13:05] So I'd need to write a multi-pass version of Grunt? [12:13:08] But I see what you mean, '!visualeditor.mobile' was plausible. yeah, I know what you meant. [12:13:43] Well, no, I'd add dependencies to modules.json and buildloader. And in Gruntfile.js specify which top module to load (probably only one on each .html file) [12:14:17] instead of 'all' and in the order that json happens to specify it in. [12:14:22] * James_F nods. [12:14:36] which I didn't think is the current case, but unfortunately it is. Sorry about that. [12:14:55] the reason jquery is loaded first is because json parser isn't crap. [12:15:16] Lovely. [12:15:25] TypeError: Cannot read property 'getMessage' of undefined [12:15:26] hm.. [12:15:33] So we'd need to build the dependency tree first, then build the file? [12:15:47] Krenair: Refresh. Cached code issue that happens some times. [12:15:51] 3VisualEditor / 3Initialisation: Do not be fooled by "Request desktop site" option in mobile browsers - 10https://bugzilla.wikimedia.org/65255#c4 (10Liangent) By having Firefox hit my own webserver, I caught UA below. Not sure whether it can be different from the one returned by navigator.userAgent. "Reques... [12:16:08] James_F, yeah I already tried that [12:16:45] Krenair: This in prod or locally? [12:17:01] local [12:19:29] MW core and VE are up to date, I have done a git submodule update... [12:19:38] Hmm. Odd. [12:19:46] Does it happen in debug=true mode? [12:20:05] yes [12:21:11] James_F, never mind, seems to be caused by some other local changes I had [12:21:19] Ah, OK. :-) [12:22:37] Depending on ext.visualEditor.core should make ve.msg etc. work when your module gets loaded right? [12:26:54] James_F: where's the list of whitelisted browsers? [12:27:49] liangent: ve.init.mw.ViewPageTarget.js line 163. [12:30:55] James_F: Well, a tree of some sorts. But a more naive exhaustion filter would work too. Grunt passes buildloader: demo.html, modules.json and [ modulea, moduleb]. And buildloader, instead of "for-in allModules: { output scripts/styles }" it would "for sortDependencies(modules) { output module scripts/styles }" where sortDependencies() does finds and dedupes dependencies [12:31:25] Krinkle: Yeah, writing now. [12:31:27] cool [12:31:44] getMessage is a problem. It is a missing dependency by design, sort of. [12:32:11] ve.msg is defined by ve.core, but depends on ve.platform.getMessage which is defined much later by Platform. [12:32:29] so the rule is, you can't depend on platform from core, so instead, one must never call ve.msg until platform is initialised. [12:33:19] For what I was doing I can just use mw.msg instead (MW extension interacting with VE) [12:33:34] That's a problem that needs solving, but most likely requires much more rigorous separation that we can't prioritise at the moment ( https://bugzilla.wikimedia.org/show_bug.cgi?id=50707 ) [12:33:50] Just thought it was strange that it wasn't working with ve.msg. [12:36:43] (03PS1) 10Esanders: [BREAKING CHANGE] Add desktop/mobile tasks for core build [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133065 [12:37:13] James_F: I checked a few more lines in that file and it seems that configuration just affects whether a warning is shown after VE is loaded [12:37:23] liangent: Indeed. [12:37:32] and what I was talking about is whether the "edit" tab is shown [12:37:44] liangent: Oh. That sounds like a blacklist failure, then. [12:38:24] liangent: That's set in wgVisualEditorBrowserBlacklist (see VisualEditor.php line 1269). [12:43:29] Krinkle, actually I think my module depending on ext.visualEditor.mwmeta seems to trigger this error... [12:43:43] But from ve.ce.AlienNode.js:47 [12:43:45] which is weird... [12:43:54] mwmeta probably calls ve.msg in the global scope [12:44:09] make sure the module depending on mwmeta does have a dependency on platform so that it is initialised by then [12:44:28] because ve.msg == ve.init.platform.getMessage [12:45:09] ve.init.mw.Platform.js, ext.visualEditor.mediawiki (either directly or indirectly) [12:45:47] Looks like ext.visualEditor.mwcore is the issue [12:45:52] it depends on ve.core but not ve.mediawiki [12:46:16] seems to work, thanks Krinkle [12:51:25] 3VisualEditor / 3Initialisation: Do not be fooled by "Request desktop site" option in mobile browsers - 10https://bugzilla.wikimedia.org/65255#c5 (10Liangent) It seems there're two places where UA matters, summarized below: Browser | Option | profile().name | profile().version | Tab shown | Warning shown --... [12:51:33] Krinkle, could you take a look at https://gerrit.wikimedia.org/r/#/c/130328/3/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js if you have a sec? [12:58:12] James_F: I moved that bug to MediaWiki / JavaScript. is it the right place for jquery.client ? [13:01:35] (03CR) 10Krinkle: Allow extensions to add extra meta item checkboxes to the page settings dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [13:03:17] Krinkle, mw.hook perhaps? [13:03:31] Krenair: Only if the dialog supports late additions. [13:03:42] mw.hook by design allows interacting with the last fired item at any time [13:03:54] hm. nope [13:04:28] lets zoom out [13:04:35] what would an extension add to this> [13:06:42] The case I'm dealing with is adding a really simple checkbox. But an extension might want to add different types of settings for a parser function they provide or maybe other things [13:10:14] Krenair: Such as? [13:10:23] How do they read the value? [13:10:31] EditPage request parameter? [13:14:00] Well with the disambiguation extension for example it doesn't need to read the value back immediately [13:15:18] liangent: Yeah, though jquery.client is still embedded within VE I think right now. [13:17:51] James_F: btw from VE's view, do chrome/firefox's desktop and mobile version differ a lot? [13:17:59] eg. supported technologies [13:28:06] liangent: I don't know, I've never used the mobile versions of either. [13:28:19] liangent: If they differ we may need to detect them independently. [13:33:05] Krenair: For the longer term, maybe it's something that can be done as part of Parsoid and specification language in general. [13:33:14] e.g. I imagine there'd be a meta tag for it in the DM [13:33:37] presumably, rght now it is only added when the value is true, and it doesn't have a link to what it means [13:34:28] but it could be included always, and with that link, and we could use that perhaps to build it in a more generic fashion. That should cover all cases where there is a a simple key/value pair (boolean or string value) that indicates something about the page in general. [13:40:41] James_F|Away: so they may differ between mac and pc as well... [13:52:28] (03PS9) 10Alex Monk: [WIP] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [13:55:37] (03PS1) 10Esanders: Use new desktop context in buildloader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133072 [13:56:29] (03CR) 10jenkins-bot: [V: 04-1] Use new desktop context in buildloader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133072 (owner: 10Esanders) [14:02:46] Is Rummana on IRC? [14:30:05] (03CR) 10Krinkle: [C: 031] "Ah, yeah, that's a lot easier than dependencies. Let's go with this?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133065 (owner: 10Esanders) [14:30:14] James_F|Away: ^ [14:30:34] Krenair: Yes, I think so. Though not always. [14:35:21] 3VisualEditor / 3MediaWiki integration: VisualEditor: 500 server error from api.php and "Unknown Error" appears on the Save dialog box if only a newline is added to the document after a gallery - 10https://bugzilla.wikimedia.org/64566#c2 (10Alex Monk) Am I missing something or has this been fixed? http://en.... [14:55:00] Gah. [14:55:04] Krinkle: This is not a good time to tell me, as I was just able to reconnect to bitch about dependencies. [14:55:33] :-( [14:55:35] Ed came up with it on his own, I told you as soon as I saw his patch. [14:55:45] Sorry :) [14:55:47] Yeah, an hour after he said he wasn't working on it. [14:56:10] well, I guess it was an itch he had to scratch [14:56:29] Anyway, standalone has a broken inheritance tree. [14:56:47] SA needs to be loaded before core but after base to work. [14:56:59] But SA-desktop needs to load SA and core. [14:57:00] So… [14:58:35] * James_F tweaks. [15:01:31] (03PS1) 10Jforrester: build: Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 [15:01:51] Krenair: Yes, but not at 08:00 SFO time. :-) [15:01:56] Krinkle: ^^^ [15:03:35] (03CR) 10Jforrester: [C: 04-1] "Dependencies done in I9e888c87." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133065 (owner: 10Esanders) [15:21:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: 500 server error from api.php and "Unknown Error" appears on the Save dialog box if only a newline is added to the document after a gallery - 10https://bugzilla.wikimedia.org/64566#c3 (10James Forrester) 5ASS>3RES/FIX LGTM. Maybe this was fixed by the... [15:31:36] James_F, should https://bugzilla.wikimedia.org/show_bug.cgi?id=52493 be reported upstream..? [15:37:37] Krenair: Eh. Probably. [15:51:28] (03CR) 10Esanders: [C: 04-1] build: Add dependency expression (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [15:58:14] am working on removing mobile from the desktop demo at least [15:58:42] "James_F will work on the mobile demo, maybe. If edsanders isn't going to in the next 5 minutes" [15:59:19] so I said I was working on the build script after you said you were working on a mobile demo [15:59:32] then you worked on the build script [15:59:54] edsanders: I waited five minutes, you did nothing, and failed to say anything to colleagues. I gave up waiting. [16:00:29] you expected me to write the code in 5 minutes? [16:01:02] "am working on" means... "am working on" [16:02:39] (03PS2) 10Jforrester: build: Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 [16:04:29] (03CR) 10Jforrester: build: Add dependency expression (036 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [16:04:50] edsanders: It was a trivial change, so… yes. [16:05:26] edsanders: I did the much more interesting long-term fix, rather than just deleting "mobile" from modules.json. :-) [16:06:24] well if you want to waste my time that's up to you, but don't complain when I haven't got any code to show at the end of the day [16:07:26] (03CR) 10Esanders: build: Add dependency expression (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [16:10:32] edsanders: I was going to say much the same to you. [16:11:37] except I told you what I was working on [16:19:04] James_F, shall I do that then? (open a bug against firefox)? [16:19:15] Krenair: That'd be great, thanks. [16:19:27] (03CR) 10Jforrester: build: Add dependency expression (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [16:19:58] (03PS3) 10Jforrester: build: Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 [16:30:39] James_F, do we have any test sites with VE enabled by default for logged out users? [16:42:53] I've been trying to come up with some minimal HTML that replicates the issue but can't figure out how we're doing the underline in the first place [16:59:30] Krenair: Test sites? There's test2.wikipedia.org for that, yeah. There's also frwiki, itwiki, etc. which have it on by default. [17:10:27] Krenair: http://i.imgur.com/6lG5NiU.png [17:10:29] from the skins.common stuff, generic a:hover [17:10:33] inherited by "vectorMenu li a", to "vectorMenu a span", to "#ca-ve-edit li a span span" [17:16:05] (03CR) 10Esanders: build: Add dependency expression (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [17:17:35] (03Abandoned) 10Esanders: [BREAKING CHANGE] Add desktop/mobile tasks for core build [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133065 (owner: 10Esanders) [17:25:38] Krinkle, strange, chrome doesn't show that for me... [17:26:22] (03CR) 10Krinkle: "Naming bikeshed." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [17:28:11] Krenair: Be sure to enable :hover [17:28:37] active/focus/hover (and, especially, :visited) are not accessible by javascript and thus dev tools. [17:28:43] you have to tell it to look at it that way [17:28:59] also makes it a lot easier to debug since otherwise you'd have to keep the cursor there [17:30:59] so, has anybody looked at the custom {{coord}} dialog proof-of-concept i posted here yesterday? [17:31:41] http://pastebin.com/eQcjKTWm [17:31:50] can be tested on e.g. https://en.wikipedia.org/wiki/Sandfly_Bay [17:32:07] http://en.wikipedia.org/wiki/Sandfly_Bay , actually. must be http because i'm referring to external libraries. :( [17:33:03] Krinkle, ah I see... [17:33:07] Thanks. [17:34:41] 3VisualEditor / 3Editing Tools: VisualEditor: "The page has been restored" appearing on top of the page instead of "your edit was saved" after switching to edit source mode and saving the page from there - 10https://bugzilla.wikimedia.org/65269 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created at... [17:42:50] James_F, you want to update https://gerrit.wikimedia.org/r/#/c/133072/1 (and mark your core change as breaking) ? [18:11:28] TrevorParscal: The bug Sherry reported about IE, isn't actually IE related at all. [18:11:37] what was it? [18:11:53] TrevorParscal: Open https://en.wikipedia.org/wiki/Wikipedia:X, observe that VE is disabled in this namespace, so only Edit source, and no Edit beta. [18:12:10] Shrink window as narrow as possible (so that "View history" goes into the dropdown menu) [18:12:16] Then resize to full width again [18:12:17] tadaa [18:12:22] inline styles [18:12:28] collapsibleTabs, display block [18:12:39] vector, coe [18:12:40] core [18:13:24] Reported as https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Internet_Explorer_is_blacklisted.2C_but_there_exists_a_way_for_it_to_show_up_on_IE though reproducible in any browser. [18:13:52] at least the server is smart enough to double check, so the editor won't actually load. [18:17:25] TrevorParscal: So, will probably fix Vector to look at display state before hand, and fix VE to .remove() the button instead of hiding it (if hiding it is because of environment restrictions that aren't gong to change during the view session) [18:18:13] TrevorParscal: btw, WikiEditor had a slight button change. http://i.imgur.com/mBZm28W.png (upper row is the old, png, the lower row is the new, svg). The "B" button specifially looks odd as it is the only one that has 3D depth. [18:19:23] 3VisualEditor / 3Editing Tools: Raster icons missing from VE toolbar - 10https://bugzilla.wikimedia.org/65271 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3normal a:3None Created attachment 15372 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15372&action=edit Toolbar with missing tool icons – und... [18:19:36] Whoa! that looks terrible [18:20:04] it's probably using some strange and buggy SVG filter [18:20:55] https://gerrit.wikimedia.org/r/#/c/97454/ [18:21:04] TrevorParscal: ^ yeah, I don't think it was done on purpose [18:21:15] I think it's just the regular outline and the black filling is only partial or something [18:27:29] (03PS1) 10Bartosz Dziewoński: ve.init.mw.Target: Do not load SVG icons on Opera 12 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133099 [18:28:07] 3VisualEditor / 3Editing Tools: Raster icons missing from VE toolbar - 10https://bugzilla.wikimedia.org/65271#c1 (10Bartosz Dziewoński) Created attachment 15373 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15373&action=edit Correctly rendered SVG toolbar (The Opera 12 fix I mentioned is Ieafeb9075... [18:28:18] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This is blocked by bug 65271." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133099 (owner: 10Bartosz Dziewoński) [18:31:12] you still care about helping me fix up Opera 12 a little bit? :) [18:32:51] TrevorParscal, are you around? I have this change pending for the media insert dialog, but I am thinking maybe we should incorporate some of it in the SearchWidget itself.. I assume "no results found" is something that could be useful when it's more generalized? https://gerrit.wikimedia.org/r/#/c/133050/ [18:42:31] mooeypoo: yes, i do think a no-results feature would be nice to add [18:43:06] in some cases we would want to just show a separate panel, in most cases we would probably want to show a no results found grayed out message [18:43:20] i will take a look at the patch in a bit, i'm wrangling something atm [18:44:26] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239 (10ryasmeen) a:3Moriel Schottlender [18:44:51] MatmaRex, so Opera took the Chrome rendering engine and broke it. Helpful [18:45:10] just render the missing PNGs using Inkscape or ImageMagick [18:45:11] edsanders: um no, that's Opera 12 [18:45:19] which had its own engine [18:47:00] * edsanders reads up on Opera version numbers [18:47:52] mooeypoo: Can you please look into this bug:https://bugzilla.wikimedia.org/show_bug.cgi?id=65239 [18:48:11] edsanders: sorry, i got disconnected, please repeat if you talked to me [18:48:34] this is a regression that I am getting as of yesterday [18:48:37] anyway, Opera 15+ is just Chrome with a different UI, Opera 12 and older was a separate thing [18:48:40] so Opera on Window/OSX (v21) is using Gecko? [18:49:12] I'd like to see the statistics as it might not be worth supporting [18:50:49] Opera 21 is using Blink and it has no issues i'm aware of, in fact i wonder why it's not whitelisted [18:51:13] MatmaRex, seems reasonable [18:51:27] submit a patch [18:51:49] Opera 12 and older, which only dinosaurs like me use these days, had a separate engine called Presto [18:52:39] which is probably somewhere around the level of IE9-IE10 when it comes to features, speed and bugginess [18:52:48] edsanders: a patch for what? i submitted one [18:52:51] Give that it's an old version of a 1% browser we probably aren't going to officially support it [18:52:58] Opera 21 whitelist? [18:53:13] but feel free to fix up the png issue [18:53:26] ah [18:53:36] i would fix up if i could find out what's causing it [18:53:43] it seems like oojsui is bundled with only SVG icons [18:53:58] so the PNG ones are just not there [18:54:15] no idea why you guys are doing that, and it seems like oojs has some fancy packing scripts and whatnot [18:54:22] packaging* [18:55:39] (03CR) 10Esanders: "The tooltips on the tools use full caps, so if we change this, those should be changed too for consistency." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [18:57:35] (03PS1) 10Bartosz Dziewoński: Whitelist Opera 15+ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133110 [18:57:53] edsanders: the tooltips on tools were changed. unless you mean some other tooltips than i do. [18:58:42] ryasmeen, I just changed the caption of the image in that bug 3 times without the error... I have an idea of why that bug may happen - can you try it again? [18:59:51] (03CR) 10Esanders: "I'm not sure the HTML5 spec is particularly relevent when making design decisions, but Google docs use monospaced camel case: http://1.bp." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [19:01:32] MatmaRex, ok [19:10:58] [17:59:30] Krenair: Test sites? There's test2.wikipedia.org for that, yeah. There's also frwiki, itwiki, etc. which have it on by default. [19:11:50] need one that uses the beta editappendix thing [19:12:21] mooeypoo: ypu need to save you edit first, then try to edit it for the second time [19:12:52] yeah it happened once and now i can't reproduce it again [19:13:16] Try another image [19:15:13] Yeah I just tried 3 in a row. This is weird. [19:16:41] did you save you edit on the caption for each time? [19:17:06] got it! [19:17:11] By "Save", I mean saving the page [19:17:14] yeah [19:17:17] I got it now. [19:17:46] ok [19:19:26] trying to reproduce on master now [19:22:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: the {{phpi}} template in mediawiki.org is not showing any content while editing in VE - 10https://bugzilla.wikimedia.org/57966#c1 (10Alex Monk) Works for me. [19:25:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: the {{phpi}} template in mediawiki.org is not showing any content while editing in VE - 10https://bugzilla.wikimedia.org/57966#c2 (10Amir E. Aharoni) 5NEW>3RES/WOR (In reply to Alex Monk from comment #1) > Works for me. For me too. Probably got fixed... [19:33:22] 3VisualEditor / 3Editing Tools: Raster icons missing from VE toolbar - 10https://bugzilla.wikimedia.org/65271#c2 (10James Forrester) 5NEW>3RES/WON We do not intend to load raster icons in VisualEditor. [19:34:14] Krenair: Ah; no, no edit^beta by default sites, sorry. [19:34:25] okay [19:34:34] will look back at that in a moment, PM [19:38:04] (03Abandoned) 10Jforrester: ve.init.mw.Target: Do not load SVG icons on Opera 12 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133099 (owner: 10Bartosz Dziewoński) [19:45:50] meh. [19:52:00] (03CR) 10Jforrester: "I agree with Ed; let's keep the monospacing the the spacing." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [19:52:21] James_F: how about you remove all of the unused code and unused icons, then? because that just felt pretty annoying right now [19:52:39] MatmaRex: What? [19:52:58] MatmaRex: OOUI isn't purely for VE; we've included the PNGs for other potential users. [19:53:07] i mean the ones in VE itself [19:53:15] at a glance, every SVG icons has a PNG version [19:53:17] MatmaRex: The icons, however, are absolutely not going to be added to the payload for VE. [19:53:17] icon* [19:53:26] and there are separate modules for loading the raster versions [19:53:31] MatmaRex: Many VE icons become OOUI icons over time, so we kept the habit. [19:53:39] so i assumed that they are actually intended to be used, eh [19:53:50] Sorry. [19:55:07] (03PS1) 10Mooeypoo: Make sure originalDimensions are available before use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133123 (https://bugzilla.wikimedia.org/65239) [19:55:37] ryasmeen, that *should* fix this bug, at least until the image model is merged. [19:55:39] on a side note, VE itself seems to work better on Opera 12 than it used to :) [19:55:55] when the toolbar icons are not missing, that is. :> [19:58:59] MatmaRex: Is that due to fixes in Opera 12 do you think, or fixes by us? [19:59:06] James_F: which browsers does OOjs UI target, actually? [19:59:12] thanks mooeypoo :) [19:59:23] (03PS4) 10Jforrester: build: Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 [19:59:28] (03CR) 10Jforrester: build: Add dependency expression (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [19:59:34] James_F: either magic pixies or fixes by you, Opera 12 is only receiving security updates (and not many of these are necessary either) [19:59:46] MatmaRex: "Modern"; IE9+ and equivalent. [19:59:56] MatmaRex: We're working on ES3 support, though, [20:00:56] i'm asking because using .whatever::before { content: url(a.svg) } doesn't seem to have the sorts of issues background-images do. :P [20:01:58] James_F: the only actual pain point of VE on Opera 12 for me right now is that dialogs sometimes take a few seconds to open, no idea why. i've been meaning to investigate this some time when i'd been feeling masochistic [20:04:17] MatmaRex: Really? ISTR we use background-images explicitly for wider compatibility. [20:04:26] MatmaRex: Hmm. Slow-loading dialogs just in Opera, or more widely? [20:05:32] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Use existing reference" is not functioning at all in Betalabs - 10https://bugzilla.wikimedia.org/64677#c6 (10ryasmeen) 5RES/?>3VER Verified the fix on production [20:05:35] just Opera 12. i'd guess some iframe weirdness, meh [20:05:49] MatmaRex: Fun. [20:06:37] 3VisualEditor / 3Editing Tools: VisualEditor: Pressing tab while keeping the math inspector open throws TypeError: Cannot read property 'start' of null - 10https://bugzilla.wikimedia.org/64451#c5 (10ryasmeen) 5RES/?>3VER Verified the fix in production [20:09:07] 3VisualEditor / 3Editing Tools: VisualEditor: When "__FORCETOC__" is set, inside VE instead of "Hide" the link to hide the TOC appears as "" - 10https://bugzilla.wikimedia.org/64464#c4 (10ryasmeen) 5RES/?>3VER Verified the fix in production [20:09:38] (03CR) 10Catrope: [C: 032] Make sure originalDimensions are available before use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133123 (https://bugzilla.wikimedia.org/65239) (owner: 10Mooeypoo) [20:10:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] "Null" appearing instead of "Transclusion" in the template insert dialog box - 10https://bugzilla.wikimedia.org/64671#c4 (10ryasmeen) 5RES/?>3VER Verified the fix in production [20:11:10] (03Merged) 10jenkins-bot: Make sure originalDimensions are available before use [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133123 (https://bugzilla.wikimedia.org/65239) (owner: 10Mooeypoo) [20:12:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Citation dialog does not focus correct field when adding a new parameter - 10https://bugzilla.wikimedia.org/64098#c3 (10ryasmeen) 5RES/?>3VER Verified the fix on production [20:12:41] (03CR) 10GWicke: "@Ori: Could you perhaps add the schema for this so that we can get started with the data collection?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130543 (owner: 10GWicke) [20:14:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] Reference list dialog is no longer "small" size, but default "large" - 10https://bugzilla.wikimedia.org/64670#c6 (10ryasmeen) 5RES/?>3VER Verified the fix in production [20:15:53] 3VisualEditor / 3Editing Tools: VisualEditor: 0,0 initial selection in Firefox when opening a new or pre-existing references means inserting template causes fatal JS error - 10https://bugzilla.wikimedia.org/64434#c7 (10ryasmeen) 5RES/?>3VER Verified the fix in production [20:17:37] 3VisualEditor / 3Editing Tools: VisualEditor: Its possible to input a fraction value (with decimal point) in image size which results into showing wrong size in the review changes section - 10https://bugzilla.wikimedia.org/62756#c3 (10ryasmeen) 5RES/?>3VER Verified the fix in production [20:18:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: [Regression wmf22] "Edit source" tab for wikitext no longer selected on action=edit - 10https://bugzilla.wikimedia.org/64646 (10ryasmeen) 5RES/?>3VER [20:19:37] 3VisualEditor / 3ContentEditable: VisualEditor: Links should follow the local CSS rules as if they were rendered in the view mode (e.g. external links shown with the external icon) - 10https://bugzilla.wikimedia.org/38726#c5 (10ryasmeen) 5RES/?>3VER Verified the fix in production [20:29:36] (03CR) 10Bartosz Dziewoński: "Alright. Ed, the tooltips should be changed in this patch as well." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [20:33:31] 3VisualEditor / 3MediaWiki integration: Description of tags "VisualEditor: Check" and "VisualEditor: Switched" are hard to translate - 10https://bugzilla.wikimedia.org/62694#c1 (10Alex Monk) Aren't the docs supposed to clear up issues like this? Are they insufficient? [20:33:31] (03PS3) 10Bartosz Dziewoński: Use more standard format for displaying keyboard shortcuts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 [20:33:51] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=58335 -> isn't this CE, not MW integration? [20:40:36] James_F, I think https://bugzilla.wikimedia.org/show_bug.cgi?id=58488 should be marked as assigned.. [20:41:25] (03CR) 10Krinkle: [C: 032] "Hm.. looks like OO.ui.BarToolGroup, OO.ui.ListToolGroup, and OO.ui.MenuToolGroup are unused across OOjs UI, VisualEditor and mediawiki-ex" [oojs/ui] - 10https://gerrit.wikimedia.org/r/132980 (owner: 10Esanders) [20:42:01] (03Merged) 10jenkins-bot: Remove @abstract from classes which can be instantiated [oojs/ui] - 10https://gerrit.wikimedia.org/r/132980 (owner: 10Esanders) [20:49:07] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239 (10ryasmeen) 5PAT>3RES/FIX [20:49:22] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239#c5 (10ryasmeen) Verified the fix in Betalabs [20:50:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] TypeError: originalDimensions is undefined appears while saving the edit on an image - 10https://bugzilla.wikimedia.org/65239 (10ryasmeen) [20:51:06] 3VisualEditor / 3MediaWiki integration: Description of tags "VisualEditor: Check" and "VisualEditor: Switched" are hard to translate - 10https://bugzilla.wikimedia.org/62694#c2 (10James Forrester) 5NEW>3RES/WON (In reply to Helder from comment #0) > In its current form I'm always wondering "check what?"... [20:51:28] Krenair: I think 58335 is related to another bug in CE or Parsoid but I can't see which one right now. [20:54:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: If the user is section editing but has edited outside of that one section (??), don't insert the name of that section into the edit summary as if they were section-editing - 10https://bugzilla.wikimedia.org/58488 (10James Forrester) 5NEW>3ASS p:5Unpr... [20:54:07] 3VisualEditor / 3MediaWiki integration: VisualEditor: If the user only has edited in one section (??), insert the name of that section into the edit summary as if they were section-editing - 10https://bugzilla.wikimedia.org/51903 (10James Forrester) [20:54:18] Krenair: Done. :-) [20:55:52] 3VisualEditor / 3MediaWiki integration: Template inside
  • creates an extra bullet with inline slug - 10https://bugzilla.wikimedia.org/58335#c1 (10Alex Monk) Krenair: I think 58335 is related to another bug in CE or Parsoid but I can't see which one right now. [20:56:21] 3VisualEditor / 3MediaWiki integration: VisualEditor: "The page has been restored" appearing on top of the page instead of "your edit was saved" after switching to edit source mode and saving the page from there - 10https://bugzilla.wikimedia.org/65269 (10James Forrester) 5NEW>3ASS p:5Unprio>3Low s:... [20:56:27] So I was looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=52493 earlier [20:56:44] Went to report upstream but I should probably have an easy test URL or example HTML [20:58:14] * James_F nods. [20:58:20] Can you make up a JSfiddle? [20:59:03] I couldn't quite come up with some HTML to replicate the issue [20:59:20] might save a page and reduce it as much as possible [20:59:44] * James_F nods. [21:03:25] (03PS5) 10Jforrester: build: [BREAKING CHANGE] Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 [21:03:32] (03CR) 10Jforrester: build: [BREAKING CHANGE] Add dependency expression (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:05:43] (03PS6) 10Krinkle: build: [BREAKING CHANGE] Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:05:55] (03CR) 10Krinkle: "spacey wacy" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:06:18] Krinkle: Ha. :-) [21:06:56] (03CR) 10Krinkle: [C: 032] build: [BREAKING CHANGE] Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:07:02] Woo. [21:08:15] James_F: cancelled [21:08:32] Oh? [21:08:55] demo load order changed [21:09:04] Krinkle: Yes; in a breaking way? [21:09:05] in a non-uncontroversial way [21:09:06] ve.js:396: Uncaught TypeError: Cannot read property 'getMessage' of undefined [21:09:14] ve.ce.AlienNode.js:47: Uncaught TypeError: Cannot read property 'getSystemPlatform' of undefined [21:09:14] Oh, bah. Didn't see that. [21:09:24] oojs.js:822: Uncaught Error: No class registered by that name: alienInline [21:09:31] This is because our dependency order is completely broken. [21:09:33] and the demo editor stays empty [21:09:35] Yeah [21:09:41] the previous order worked though [21:09:42] * James_F sighs. [21:09:53] Worked until you actually loaded the right modules. [21:10:11] (03CR) 10Krinkle: "Breaks demo, order changed too much. Errors:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:11:01] I guess we could make ve.SA not depend on VE… but it'd seem a bit bonkers. [21:11:33] (03CR) 10Krinkle: "and docs demo as well: TypeError: Cannot read property 'Target' of undefined" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:12:56] The dependency order is pretty much as it is specified in modules.json [21:13:08] The file order? [21:13:16] There shouldn't be dependencies on something lower in the file, and anything lower in the file has a dependency on the higher ones [21:13:27] A subset of that, of course [21:13:41] visualEditor.standalone depends on base, that's correct. [21:13:59] visualEditor.core depends on base, that's also correct, except that it also depends on platform [21:14:05] (whichever platform is being used) [21:14:13] Which platform? [21:14:20] sa or mw respectively [21:14:32] That's how we do it in mediawiki VisualEditor.php as well [21:14:46] Oh, I see, the dependency needs to be expressed in VE/VE and then over-ridden? [21:15:10] Hm.. not sure [21:15:15] No, I'm wrong [21:15:23] in VisualEditor.php we do not have ve.core depend on ve.mw [21:15:29] ve.mw depends on ve.core, not ve.base [21:15:38] so ve.sa should also depend on ve.core, not ve.base [21:15:43] Exactly. [21:15:44] I think [21:15:48] Except if you do that everything breaks. [21:15:52] Because? [21:15:52] I've been through this a lot. [21:16:25] Can't remember. [21:16:34] well, clearly it's not working now either. There ought to be a way to specify the dependencies, we're not dealing with a race condition because the fixed order as it was worked. We just need to find a way to specify it. [21:17:23] checking the dependencies you added in modules.json now, we mus've missed something [21:17:30] Also, SA really shouldn't come through in the docs, surely? [21:18:27] Of course. What other target would it be? [21:18:36] No target. [21:18:42] We demo the toolbar. [21:18:46] The SA isn't the purpose of the VE documentation, surely? [21:18:51] Eh. [21:18:52] And we can add @demo for any other class as well [21:19:23] Pretty much all VE classes need a Target in order to demonstrate their methods. [21:19:33] Because everything uses global ve.init.platform [21:19:35] We should have @demo in the .sa.* classes? [21:19:45] We do. [21:19:56] Not ve.init.sa.js [21:20:13] Not ve.init.sa.Platform.js [21:20:15] https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.init.sa.Target [21:20:52] Indeed, "@demo" doesn't appear in any VE file, apparently. [21:21:11] Yes, because we haven't written them yet, except for Target. [21:21:26] That's besides the point. [21:21:38] Oh, it's a pointer to a demo rather than a note that the file is a demo? [21:22:21] docs-iframe is essentially just like demo, except that it doesn't auto-instantiate, instead the sample code does that so that it can demonstrate how different classes are used (e.g. toolbar, button, dropdown, etc.) [21:22:30] so it's the bootstrap file that the code runs inside of. [21:22:32] like demo.js [21:22:57] Hmm. OK. [21:23:41] so yeah, I think the proiblem is that ve.core depends on ve.sa [21:24:06] unlike ve.mw, which has ve.core load first, in standalone ve.core needs the target to exist first [21:24:17] this is because in ve.mw we don't call VE stuff until after document ready [21:24:23] Yeah. [21:24:39] Should we fix by just making core depend on SA for now? [21:25:00] but in reality, ve.core depends on target in mw as well. ve.core makes calls to ve.msg and ve.init.platform stuff in varous places, so platform needs to be loaded between base and core. It's the non-optional glue layer between the two. [21:25:03] Yep [21:25:20] * James_F nods. [21:25:25] OK, fixing. [21:25:48] That part is actually by design (ve core calling global singleton ve.init.platform is not by design, but it depending on a platform instance is by design I think) [21:26:17] (03PS7) 10Jforrester: build: [BREAKING CHANGE] Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 [21:26:54] makes it harder to load though, we should find a way to defer that so that e.g. wordpress can load lib/all.ve.js and then src/ve.wordpress.js and be done with it. [21:27:13] like deferMsg maybe [21:27:40] (03PS8) 10Jforrester: build: [BREAKING CHANGE] Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 [21:30:36] (03CR) 10Krinkle: [C: 032] build: [BREAKING CHANGE] Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:31:47] (03Merged) 10jenkins-bot: build: [BREAKING CHANGE] Add dependency expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133078 (owner: 10Jforrester) [21:35:47] (03PS1) 10Jforrester: Update VE core submodule to master (c782d4c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133174 [21:35:51] Krinkle: ^^^ [21:36:42] (03CR) 10Jforrester: "Is this still necessary?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133060 (owner: 10Esanders) [21:40:30] James_F, http://jsfiddle.net/3duMd/ [21:42:10] Krenair: Nice minimum case. :-) [21:43:02] If you move the text-decoration:underline; out of the hover and replace the text-decoration:none; with it, the underline works fine [21:43:04] so only breaks on hover [21:43:11] Yeah. [21:43:16] and only in firefox [21:45:21] James_F, I think that's good to go to bugzilla.mozilla.org then [21:45:31] +1 :-) [21:46:07] 3VisualEditor / 3Editing Tools: VisualEditor: In FireFox, the dropdown box for search results in Template dialog/ Redirect page/Categories gets sticked to the dialog if you click on Add/navigate to other tab in page settings keeping the dropbox open - 10https://bugzilla.wikimedia.org/64334#c9 (10ryasmeen) Ve... [21:47:33] (03CR) 10Krinkle: [C: 031] "Seems like a good habit to not clash these either way. In theory this would allow one to instantiate desktop/mobile mediawiki/non-mediawik" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133060 (owner: 10Esanders) [21:53:36] James_F, https://bugzilla.mozilla.org/show_bug.cgi?id=1009874 [21:53:54] Krenair: Nice. First browser bug you've reported? [21:54:06] 3VisualEditor / 3MediaWiki integration: VisualEditor: The 'beta' element in the edit tab has an overline instead of underline in Firefox - 10https://bugzilla.wikimedia.org/52493#c3 (10Alex Monk) Filed as https://bugzilla.mozilla.org/show_bug.cgi?id=1009874 [21:54:09] Nah, I've reported a couple in Chrome before [21:54:36] I think one of those was due to some undefined behaviour in the HTML spec or something [21:56:32] James_F, http://code.google.com/p/chromium/issues/detail?id=342189 became https://www.w3.org/Bugs/Public/show_bug.cgi?id=25112 [21:56:42] And I also reported http://code.google.com/p/chromium/issues/detail?id=127967 [23:17:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box - 10https://bugzilla.wikimedia.org/64761#c4 (10ryasmeen) Verified the fix in test2 [23:49:34] (03PS1) 10Trevor Parscal: [WIP] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [23:50:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [23:50:18] (03PS2) 10Trevor Parscal: [WIP] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [23:50:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [23:50:58] (03PS3) 10Trevor Parscal: [WIP] [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [23:51:06] (03PS4) 10Trevor Parscal: [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 [23:51:29] 3VisualEditor: VisualEditor: Using "page down" (PgDn) key to scroll down moves the wrong number of lines if the toolbar is on multiple lines - 10https://bugzilla.wikimedia.org/65241#c2 (10Dan Kindsvater) One more thing ... I just hit Ctrl-+ a second time (my eyes are tired) and ... holy crap, the menu bar tak... [23:52:34] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Window refactor, introduction of Processes [oojs/ui] - 10https://gerrit.wikimedia.org/r/133193 (owner: 10Trevor Parscal) [23:53:33] (03PS1) 10Trevor Parscal: OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 [23:53:36] (03CR) 10jenkins-bot: [V: 04-1] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [23:53:56] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 [23:53:58] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] OOjs UI to v0.1.0-pre (5f49c04e02) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133194 (owner: 10Trevor Parscal) [23:57:42] (03PS1) 10Trevor Parscal: Update VE Core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 [23:58:19] (03PS2) 10Trevor Parscal: [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 [23:59:54] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Update VE Core (Processes) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133196 (owner: 10Trevor Parscal)