[00:17:30] (03PS1) 10Kaldari: Changing formatting of Cite drop-down for mobile/tablet interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133197 [01:08:59] 3VisualEditor / 3MediaWiki integration: VisualEditor: Diff styling in save dialog is broken - 10https://bugzilla.wikimedia.org/60497#c1 (10Alex Monk) So I think we just need to apply line-height: 1.6px to the body of the frame like MW core does for #bodyContent, .mw-body-content (but I don't think we should... [01:32:57] TrevorParscal, how hard would it be to write a "dark" template for oojs-ui ? [01:56:15] 3VisualEditor / 3MediaWiki integration: Description of tags "VisualEditor: Check" and "VisualEditor: Switched" are hard to translate - 10https://bugzilla.wikimedia.org/62694#c3 (10Helder) =/ [03:03:43] Keegan, are you online? [03:04:31] quiddity, are you around? Or anyone who might know what's going on? [03:04:35] I can't get pages to open at en.wp. I mean, I can't even read them. [03:05:40] Hi [03:05:41] I've got an error about "too many redirects occurred trying to open" VPT, or my watchlist, or pretty much anything else. [03:05:45] I'm here [03:06:04] I've tried two computers and three browsers so far. [03:06:06] I'm online just fine.. [03:06:08] Hm [03:06:54] * Keegan loads a user talk page fine [03:07:04] You should wander over to #wikimedia-tech [03:07:44] It's back now. [03:07:56] Maybe it was just one of those five-minute glitches. [03:08:09] Someone might have briefly broken a piece of of script [03:08:11] Yeah [03:08:18] Are you logged in? [03:08:19] I see there are similar complaints at VPT. [03:08:31] Wait, you said watchlist, so yes [03:08:39] Odd. [03:09:12] Yes, I'm logged in on this computer. [03:09:23] But not on the other one. [03:09:48] Well, the good news is that it's fixed [03:09:51] And VE didn't do it [03:09:56] Yes. :-) [03:10:16] Thanks for responding. [03:10:22] I appreciate it. [03:10:47] Sure [10:13:17] (03Abandoned) 10Esanders: Use new desktop context in buildloader [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133072 (owner: 10Esanders) [13:22:46] (03CR) 10Esanders: "FIXME: The message key used in the code is completely wrong!" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132768 (owner: 10Jforrester) [13:25:30] (03CR) 10Esanders: "Also, ve.msg()!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132768 (owner: 10Jforrester) [13:27:55] (03PS1) 10Esanders: Use message function and correct message key [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133232 [13:29:10] (03PS2) 10Esanders: Use message function and correct message key [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133232 [13:29:40] (03CR) 10Esanders: "Id6febe80a8" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132768 (owner: 10Jforrester) [13:31:31] (03CR) 10Jforrester: [C: 032] Use message function and correct message key [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133232 (owner: 10Esanders) [13:32:50] (03Merged) 10jenkins-bot: Use message function and correct message key [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133232 (owner: 10Esanders) [13:54:29] (03PS1) 10Esanders: Create phantom/shield nodes with methods not templates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133236 [13:54:31] (03PS1) 10Esanders: Load dependencies in correct order [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133237 [13:54:33] (03PS1) 10Esanders: Separate demo into mobile demo and desktop demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 [13:54:35] (03PS1) 10Esanders: Add test files to dependency tree [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133239 [14:26:46] Krinkle, hey, around? [15:05:19] (03CR) 10Alex Monk: Allow extensions to add extra meta item checkboxes to the page settings dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130328 (https://bugzilla.wikimedia.org/61073) (owner: 10Alex Monk) [15:10:05] (03PS10) 10Alex Monk: Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [15:10:21] (03PS13) 10Alex Monk: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) [15:36:56] Uh? [15:36:58] ve.ce.AlienNode.static.$phantomTemplate = ve.ce.AlienNode.static.$phantomTemplate.clone() [15:37:10] How did that ever work [15:37:10] it defines itself in teh global scope? [15:37:13] Doesn't seem to be defined anywhere else by that name [15:37:21] Ah, inheritance [15:37:25] (03PS1) 10Cmcmahon: [browser test] Don't rely on existing page for anon edit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133255 [15:37:35] bit weird that it references the subclass first [15:42:34] yeah that was confusing [15:43:00] edsanders: btw, lowercase inheritDoc [15:43:36] good to merge, we should follow that pattern more widely [15:43:53] no global ve.msg and $() ideally [15:44:04] in static properties assigned from global scope initialisation [15:45:21] (03PS2) 10Esanders: Load dependencies in correct order [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133237 [15:45:23] (03PS2) 10Esanders: Create phantom/shield nodes with methods not templates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133236 [15:45:25] (03PS2) 10Esanders: Add test files to dependency tree [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133239 [15:45:27] (03PS2) 10Esanders: Separate demo into mobile demo and desktop demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 [15:46:02] (03PS1) 10Esanders: inheritdoc lowercase [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133258 [15:46:43] (03PS1) 10Esanders: inheritdoc lowercase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133259 [15:47:00] ^^ [15:47:01] kaity|away, [15:47:05] Krinkle [15:47:08] (tab fail) [15:47:25] yeah, I found that 1 match. Was about to fix [15:47:38] (03CR) 10Krinkle: [C: 032] inheritdoc lowercase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133259 (owner: 10Esanders) [15:47:39] thx [15:49:40] and in core [15:51:37] (03Merged) 10jenkins-bot: inheritdoc lowercase [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133259 (owner: 10Esanders) [16:06:30] (03CR) 10Krinkle: [C: 032] Create phantom/shield nodes with methods not templates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133236 (owner: 10Esanders) [16:07:43] (03Merged) 10jenkins-bot: Create phantom/shield nodes with methods not templates [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133236 (owner: 10Esanders) [16:08:31] (03CR) 10Esanders: "one last thing..." (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [16:09:23] edsanders: Hm.. those two for loops seem redundant. [16:09:32] I konw you mentioned indexOf the other day and that didn't work [16:09:35] but i think it could [16:09:42] earlier in the first loop over load.length [16:09:48] (03PS11) 10Alex Monk: Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) [16:09:53] don't push if indexOf [16:09:56] Right? [16:10:35] (03PS1) 10Krinkle: build: Simplify building of module dependency list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133263 [16:10:48] (03CR) 10Krinkle: [C: 032] Load dependencies in correct order [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133237 (owner: 10Esanders) [16:11:05] roundtrips with current html output so I think it works [16:12:07] (03Merged) 10jenkins-bot: Load dependencies in correct order [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133237 (owner: 10Esanders) [16:23:34] Krinkle, I suggested that originally (https://gerrit.wikimedia.org/r/#/c/133263/1/build/tasks/buildloader.js) but James claimed it messed up the build order [16:24:22] might be ok now I made it a proper recursive function [16:24:26] passing through tree [16:32:29] Yeah, it wouldn't have worked in the original version [16:33:07] I was assuming it was recursive already because the function that this is all copied from in mediawiki.js for mw.loader sortDependencies is recursive too [16:33:29] https://github.com/wikimedia/mediawiki-core/blob/master/resources/src/mediawiki/mediawiki.js#L834-L874 [16:43:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: Unable to paste text in the feedback popup - 10https://bugzilla.wikimedia.org/53587#c1 (10Alex Monk) Is this still a bug? It seems fine to me... [16:48:39] (03PS1) 10Krinkle: build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 [16:50:15] (03PS1) 10Krinkle: build: Remove jscs rule for "disallowRightStickedOperators" [oojs/core] - 10https://gerrit.wikimedia.org/r/133271 [16:50:44] (03PS2) 10Krinkle: build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 [16:51:20] edsanders: you had a space after the function name in 'demoMenu'. The new jscs version catches that now. [16:51:49] was already in oojs/core, but not in ve yet [16:52:37] (03PS3) 10Krinkle: build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 [16:52:40] 3VisualEditor: VisualEditor: Edit menu appears in Internet Explorer (IE11) - 10https://bugzilla.wikimedia.org/65292 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Steps to Reproduce: 1. Open a Wikipedia article in the article namespace. 2. Resize the window to a very small size so that the butt... [16:54:16] (03PS4) 10Krinkle: build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 [16:56:14] (03PS2) 10Krinkle: build: Update jscs and jshint config [oojs/core] - 10https://gerrit.wikimedia.org/r/133271 [16:57:41] (03PS5) 10Krinkle: build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 [16:57:46] (03CR) 10Krinkle: [C: 031] build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 (owner: 10Krinkle) [16:58:04] (03CR) 10Krinkle: [C: 031] build: Update jscs and jshint config [oojs/core] - 10https://gerrit.wikimedia.org/r/133271 (owner: 10Krinkle) [17:07:38] (03CR) 10Esanders: [C: 032] Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:08:07] (03Merged) 10jenkins-bot: Add confirmation dialog [oojs/ui] - 10https://gerrit.wikimedia.org/r/132113 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:09:11] (03CR) 10Alex Monk: Register OOUI confirmation dialog with windowFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:22:13] (03PS2) 10Alex Monk: Register OOUI confirmation dialog with windowFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) [17:23:40] TrevorP|Away: Krinkle RoanKattouw do either of you have any idea if https://trello.com/c/TXRBDuld/4-8-add-references-through-visual-editor got done? [17:23:51] jgonera marked it as needing code review but i have no idea where the patch is [17:24:05] (03CR) 10jenkins-bot: [V: 04-1] Register OOUI confirmation dialog with windowFactory [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [17:29:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any page on production after an edit with mobile VE - 10https://bugzilla.wikimedia.org/65109 (10ryasmeen) a:5Jon>3Ryan Kaldari [17:33:13] 3VisualEditor / 3MediaWiki integration: VisualEditor: When editor is unavailable, edit menu item can re-appear - 10https://bugzilla.wikimedia.org/65292#c1 (10Krinkle) p:5Unprio>3Normal a:3Krinkle Rephrasing bug title as bug is broader in scope. The window resize bug is actually caused by a logic error... [17:33:41] jdlrobson: There's been lots of progress in that area. We have a simplified mode of the template editor (enabled by default), and much richer use of template data. [17:34:06] So when editing a citation, the dialog looks like that screenshot there [17:34:21] we choose this route as it was easier to implement that way and benefits all templates instead of just citations. [17:34:37] There is still some work left to be done with allowing simple creation of new citations (eg. not having to know the name of the template) [17:34:49] I don't know the progress on that, could be done, might be WIP. [17:34:52] TrevorP|Away: James_F|Away: ^ [17:38:28] Krinkle: mm i'll ask maryana if it looks done to her [17:38:35] thank you for your reply [17:44:08] (03PS1) 10Trevor Parscal: Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 [17:46:05] Krinkle: looks like we might need review on https://gerrit.wikimedia.org/r/#/c/132355/ [17:57:07] (03CR) 10Cmcmahon: [C: 032] [browser test] Don't rely on existing page for anon edit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133255 (owner: 10Cmcmahon) [17:58:49] (03Merged) 10jenkins-bot: [browser test] Don't rely on existing page for anon edit test [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133255 (owner: 10Cmcmahon) [18:05:23] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cannot save any page on production after an edit with mobile VE - 10https://bugzilla.wikimedia.org/65109#c2 (10Jon) It works on beta labs so I would suspect that this is an issue that got caught and will be fixed in next deployment... unless beta labs and enwiki... [18:09:53] (03CR) 10Esanders: "requires an ooui pull through" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [18:10:41] James_F, can you pull through ooui to ve & core ^^ [18:10:54] edsanders: Sure. [18:17:35] (03CR) 10Esanders: [C: 032] build: Update jscs and jshint config [oojs/core] - 10https://gerrit.wikimedia.org/r/133271 (owner: 10Krinkle) [18:18:46] (03Merged) 10jenkins-bot: build: Update jscs and jshint config [oojs/core] - 10https://gerrit.wikimedia.org/r/133271 (owner: 10Krinkle) [18:19:48] (03CR) 10Esanders: [C: 032] build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 (owner: 10Krinkle) [18:19:58] (03CR) 10Catrope: [C: 032] inheritdoc lowercase [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133258 (owner: 10Esanders) [18:20:03] (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (14909a5566) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [18:20:22] edsanders / RoanKattouw: ^^^ and https://gerrit.wikimedia.org/r/132316 [18:20:37] * RoanKattouw punts [18:20:55] edsanders: BTW you are amazing and wonderful (re mobile-demo branch) [18:21:02] Hear hear. [18:21:56] there a tons of things in mobile that broken and may never be used by MobileFrontend that we should probably support [18:22:02] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (14909a5566) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [18:22:06] (03CR) 10Catrope: [C: 032] Fix desktop dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133060 (owner: 10Esanders) [18:22:42] (03PS4) 10Catrope: Use more standard format for displaying keyboard shortcuts [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [18:23:19] (03Merged) 10jenkins-bot: build: Upgrade jscs and jshint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133270 (owner: 10Krinkle) [18:23:21] (03CR) 10jenkins-bot: [V: 04-1] inheritdoc lowercase [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133258 (owner: 10Esanders) [18:23:40] Great [18:23:40] RoanKattouw: Would it matter much whether ORD-SFO-ORD is a separate booking or not? Since they'd both be 2-way flights. [18:23:44] (03Merged) 10jenkins-bot: Fix desktop dialogs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133060 (owner: 10Esanders) [18:23:44] Jenkins is broken again [18:23:50] Krinkle: https://integration.wikimedia.org/ci/job/VisualEditor-npm/1391/console [18:23:58] Krinkle: simple creation of citations... [18:24:12] well, how would we know if it's a citation template? [18:24:13] Full disk? [18:24:16] (03CR) 10Jforrester: [C: 04-1] "I still agree with Ed re. spacing/monospace. Case change to Title Case is OK." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132909 (owner: 10Bartosz Dziewoński) [18:24:21] And wtf is ELIFECYCLE? :P [18:24:31] RoanKattouw: probably [18:24:32] checking [18:25:06] I mean, yes, we could be more liberal about citation dialog, allow it to be used with any ref with only a template in it, rather than requiring the template to match a known list [18:25:13] Krinkle: One booking would probably be cheaper. AMS-ORD-SFO v.v. with a 2-hour stop in ORD tends to be about the same price (slightly more) than AMS-ORD v.v., and it's usually possible to make that 2-hour layover an N-day layover at no or little additional cost [18:25:24] is that what we have a request for? [18:25:56] Krinkle: You can price it out using the "multiple destinations" feature on united.com for instance (as well as on some flight search sites) [18:26:17] TrevorParscal: Let's discuss this with Maryana next Monday when we're all in the same room at the same time? [18:26:26] TrevorParscal: I worry about crossed wires and accidental work. [18:27:00] yup [18:27:03] makes sense to me [18:27:11] Kk. [18:28:38] (03PS2) 10Trevor Parscal: [WIP] Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 [18:28:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 (owner: 10Trevor Parscal) [18:29:23] (03PS4) 10Alex Monk: Update OOjs UI to v0.1.0-pre (14909a5566) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) [18:29:35] James_F, ryasmeen: https://gist.github.com/catrope/2f183fccb187014568eb is our list of changes this week [18:30:45] RoanKattouw: Cool. [18:30:54] Not very many interesting changes going out this week, mostly bug fixes and cleanup [18:31:04] (03PS3) 10Esanders: Add test files to dependency tree [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133239 [18:31:06] (03PS3) 10Esanders: Separate demo into mobile demo and desktop demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 [18:31:27] The most interesting ones are "fab7aac mw.ViewPageTarget: Hide the welcome dialog via a preference if possible" (with followup) and "a097202 Create phantom/shield nodes with methods not templates" [18:31:44] Ooh, didn't see a097202 before. [18:31:53] It's recent [18:32:23] More stuff may still land, there's a bunch of stuff in the queue, but Jenkins is broken right now so nothing can be merged [18:34:39] * James_F nods. [18:34:48] RoanKattouw: Are you joining the Hangout? [18:34:58] Oh for the pre-deployment review? [18:35:01] I suppose I could [18:35:24] Done [18:45:09] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/132979/ [18:45:52] (03CR) 10Trevor Parscal: [C: 032] Button accessibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/132979 (https://bugzilla.wikimedia.org/62337) (owner: 10Esanders) [18:46:22] (03Merged) 10jenkins-bot: Button accessibility [oojs/ui] - 10https://gerrit.wikimedia.org/r/132979 (https://bugzilla.wikimedia.org/62337) (owner: 10Esanders) [18:46:27] TrevorParscal, what do you think about focusing the 'Ok' button when a OO.ui.ConfirmDialog opens? [18:46:59] mixed [18:47:15] i like the idea of enter/esc being able to be used immediately [18:47:37] we could do it invisibly too [18:47:39] we should look at OS dialogs and figure out what is the most common situation [18:47:50] I looked at mine [18:47:56] and you have a coloured focus state [18:47:57] edsanders: or we could have a non-hideous focused state [18:48:03] (03CR) 10Catrope: [C: 032] Changing formatting of Cite drop-down for mobile/tablet interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133197 (owner: 10Kaldari) [18:48:16] (which you can change with left/right instead of tab/shift-tab) [18:48:33] yes - non-outline focus could be nice [18:49:54] (03Merged) 10jenkins-bot: Changing formatting of Cite drop-down for mobile/tablet interface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133197 (owner: 10Kaldari) [18:50:04] I notice that on OSX/Chrome, confirm, alert and prompt all click OK on enter, which is interesting in prompt because it's focused on the input [18:50:28] and in OSX the buttons aren't focusable using the keyboard unless you turn on accessibility stuff [18:51:07] osx uses a color animation to show "this is what will happen if you click enter" [18:51:31] TrevorParscal: Could you look at https://gerrit.wikimedia.org/r/#/c/132355/ and answer the question I pose in the comments? [18:53:47] (03CR) 10Trevor Parscal: [C: 04-1] "If you are going to load them mutually exclusively, then they should both be in theme folders, if it's base and extension then one can be " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132355 (owner: 10JGonera) [18:54:25] Krinkle: Could you review the outstanding changes in TemplateData? [18:56:03] Krinkle: Heads up: James wants to enable TemplateData GUI on mediawiki.org soon, he's gonna write a config change tomorrow, if you have thoughts talk to James [19:01:26] 3VisualEditor / 3Editing Tools: VisualEditor: If a reference is defined in a template, and re-used outside of it, and you delete the template, then the reference contents get lost - 10https://bugzilla.wikimedia.org/65301 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None Steps to Reproduce: 1. Start... [19:01:32] TrevorParscal, you mean enter clicks the button you have focused right? [19:02:35] in OSX you can't use tabbing to select which button to press unless you enable accessibility stuff, that's what I'm saying [19:02:38] 3VisualEditor / 3Editing Tools: VisualEditor: If a reference is defined in a template, and re-used outside of it, and you delete the template, then the reference contents get lost - 10https://bugzilla.wikimedia.org/65301 (10WhatamIdoing) [19:02:39] so, it's not going to be useful as an example here [19:02:39] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to edit references defined within a template - 10https://bugzilla.wikimedia.org/50896 (10WhatamIdoing) [19:04:02] RoanKattouw, Krinkle: Too late. "4c6ea596 (James D. Forrester 2014-02-07 14:24:24 -0800 10887) 'mediawikiwiki' => true, " [19:04:27] RoanKattouw, Krinkle: Also, ha, apparently even I can't remember what we've got switched on where. ;-( [19:05:05] Krinkle, grunt watch is broken in oojs/ui for me [19:06:31] (03PS1) 10Esanders: ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 [19:07:14] (03PS2) 10Esanders: ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 [19:07:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cite options are appearing in the toolbar for Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/65302 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1.Open a page with mobile VE Observed Result: The Cite option is appearing in... [19:08:10] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cite options are appearing in the toolbar for Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/65302 (10ryasmeen) a:3Roan Kattouw [19:15:05] (03PS3) 10Trevor Parscal: Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 [19:15:51] (03CR) 10Alex Monk: [C: 031] ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 (owner: 10Esanders) [19:21:25] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cite options are appearing in the toolbar for Mobile VE in Betalabs - 10https://bugzilla.wikimedia.org/65302#c1 (10ryasmeen) Created attachment 15383 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15383&action=edit Screenshot [19:23:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: When editor is unavailable, edit menu item can re-appear - 10https://bugzilla.wikimedia.org/65292 (10James Forrester) 5NEW>3ASS [19:23:52] 3VisualEditor / 3MediaWiki integration: VisualEditor: When editor is unavailable, edit menu item can re-appear - 10https://bugzilla.wikimedia.org/65292 (10James Forrester) s:5normal>3minor [19:24:38] 3VisualEditor / 3Editing Tools: VisualEditor: Citation tool matching should also match templates with whitespace before the first parameter - 10https://bugzilla.wikimedia.org/63129#c1 (10Roan Kattouw) 5ASS>3RES/FIX I fixed this in https://gerrit.wikimedia.org/r/#/c/132725/ without realizing it. [19:27:37] (03PS4) 10Trevor Parscal: Ignore SelectWidget mouseup events that started outside the widget [oojs/ui] - 10https://gerrit.wikimedia.org/r/133284 [19:27:39] (03CR) 10Jforrester: "Lovely work. Minor suggestion on splitting the new module." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133239 (owner: 10Esanders) [19:29:08] 3VisualEditor / 3Editing Tools: VisualEditor: Dialog panes don't seem to apply any padding to the bottom of their content in Firefox (but not Chrome), so the contents of the pane can almost overlap with the border of the dialog - 10https://bugzilla.wikimedia.org/64723#c4 (10Roan Kattouw) (In reply to Roan Ka... [19:38:08] 3VisualEditor / 3Editing Tools: VisualEditor: Switching to source mode should show a spinner - 10https://bugzilla.wikimedia.org/65012#c1 (10Roan Kattouw) This is only in beta labs, probably because beta labs is just slow. We should have a spinner and a blocking overlay, though. Right now you can even interac... [19:39:24] (03CR) 10Catrope: [C: 04-1] If no media is found display a message in media insert dialog (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133050 (https://bugzilla.wikimedia.org/52463) (owner: 10Mooeypoo) [19:42:08] edsanders: broken how? [19:44:55] 3VisualEditor / 3MediaWiki integration: Is it possible to set up VisualEditor on other skins instead of Vector skin? - 10https://bugzilla.wikimedia.org/65304 (10Sean Chen) 3UNC p:3Unprio s:3major a:3None hi, we are using MediaWiki for our intranet on Government of Ontario and we are amazed by the ne... [19:46:28] it goes crazy then crashes [19:52:27] (03PS3) 10Esanders: ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 [19:52:52] 3VisualEditor / 3MediaWiki integration: Is it possible to set up VisualEditor on other skins instead of Vector skin? - 10https://bugzilla.wikimedia.org/65304#c1 (10Roan Kattouw) You can try setting $wgVisualEditorSupportedSkins[] = 'nameofyourskin'; in your configuration. If your skin is a derivative of one... [19:55:13] TrevorP|Away, right, but you can in other OSes [19:55:39] TrevorP|Away, I think arrow keys are going to be more intuitive, but seems more hacky [19:55:40] 3VisualEditor / 3Mobile: VisualEditor Mobile: The Link inspector icon remains highlighted in the toolbar for mobile VE even if no new link has been added - 10https://bugzilla.wikimedia.org/65305 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15384 --> https://bugzilla.wikimedia.or... [19:56:04] My tab key just got stuck and I was flicking through tabs. I think I added some to the work list. oops. [19:56:59] fixed it I think [19:58:57] (03CR) 10Esanders: [C: 032] build: Simplify building of module dependency list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133263 (owner: 10Krinkle) [20:00:04] (03Merged) 10jenkins-bot: build: Simplify building of module dependency list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133263 (owner: 10Krinkle) [20:02:08] 3VisualEditor / 3MediaWiki integration: Is it possible to set up VisualEditor on other skins instead of Vector skin? - 10https://bugzilla.wikimedia.org/65304#c2 (10Alex Monk) Kind of relevant to this are my (WIP) notes on what VE expects of a skin, which you can find at bug 61500. [20:03:53] 3VisualEditor / 3MediaWiki integration: Is it possible to set up VisualEditor on other skins instead of Vector skin? - 10https://bugzilla.wikimedia.org/65304#c3 (10Alex Monk) 5UNC>3RES/INV Also because this is for support, not an actual software issue, I have set it to resolved invalid. [20:34:11] (03CR) 10Krinkle: [C: 04-1] Separate demo into mobile demo and desktop demo (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 (owner: 10Esanders) [20:36:09] (03CR) 10Krinkle: Separate demo into mobile demo and desktop demo (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133238 (owner: 10Esanders) [20:37:26] 3VisualEditor / 3Editing Tools: VisualEditor: The "Review your changes" button remains active and clickable on the Save dialog while the loading bar is in progress for saving the page - 10https://bugzilla.wikimedia.org/65310 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15385 -->... [20:39:23] edsanders: also, you have to consider that arrow keys are going to be more likely to be bound to the focused widget (should there be one) and ideally we would have predictable and consistent behavior with dialogs that do and do not have widgets in the content [20:53:07] (03PS1) 10Krinkle: build: Update jscs and jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133357 [20:54:30] (03PS2) 10Catrope: build: Update jscs and jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133357 (owner: 10Krinkle) [20:54:42] (03PS3) 10Krinkle: build: Update jscs and jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133357 [20:55:56] (03CR) 10Catrope: [C: 032] build: Update jscs and jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133357 (owner: 10Krinkle) [20:56:26] (03Merged) 10jenkins-bot: build: Update jscs and jshint config [oojs/ui] - 10https://gerrit.wikimedia.org/r/133357 (owner: 10Krinkle) [20:59:11] 3VisualEditor / 3Editing Tools: VisualEditor: Make full size button remains disabled for a specific image in Betalabs - 10https://bugzilla.wikimedia.org/65314 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15386 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15386&action=edi... [20:59:11] (03CR) 10Catrope: [C: 032] ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 (owner: 10Esanders) [20:59:13] (03CR) 10jenkins-bot: [V: 04-1] ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 (owner: 10Esanders) [20:59:16] (03PS1) 10Trevor Parscal: Auto-hide menus by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/133360 [20:59:37] (03PS2) 10Trevor Parscal: Auto-hide menus by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/133360 [21:01:10] (03CR) 10Catrope: [C: 04-1] "OK except for typo in comment" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/133360 (owner: 10Trevor Parscal) [21:02:04] (03PS4) 10Catrope: ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 (owner: 10Esanders) [21:02:16] (03CR) 10Catrope: [C: 032] ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 (owner: 10Esanders) [21:02:51] (03Merged) 10jenkins-bot: ConfirmationDialog clean up [oojs/ui] - 10https://gerrit.wikimedia.org/r/133297 (owner: 10Esanders) [21:03:00] (03PS3) 10Catrope: Auto-hide menus by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/133360 (owner: 10Trevor Parscal) [21:03:09] (03CR) 10Catrope: [C: 032] Auto-hide menus by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/133360 (owner: 10Trevor Parscal) [21:03:44] (03Merged) 10jenkins-bot: Auto-hide menus by default [oojs/ui] - 10https://gerrit.wikimedia.org/r/133360 (owner: 10Trevor Parscal) [21:06:48] (03PS5) 10Catrope: Update OOjs UI to v0.1.0-pre (80f1797a5c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:07:37] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (80f1797a5c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:07:56] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (80f1797a5c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:14:09] (03PS6) 10Catrope: Update OOjs UI to v0.1.0-pre (80f1797a5c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:24:02] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (80f1797a5c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:24:57] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (80f1797a5c) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132318 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:26:16] (03PS1) 10Alex Monk: Only send useful oldid while switching to wikitext editor if it's specifically requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133363 (https://bugzilla.wikimedia.org/65269) [21:31:24] (03CR) 10Catrope: [C: 032] Only send useful oldid while switching to wikitext editor if it's specifically requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133363 (https://bugzilla.wikimedia.org/65269) (owner: 10Alex Monk) [21:33:42] (03Merged) 10jenkins-bot: Only send useful oldid while switching to wikitext editor if it's specifically requested [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133363 (https://bugzilla.wikimedia.org/65269) (owner: 10Alex Monk) [21:33:57] (03PS14) 10Catrope: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [21:35:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: "The page has been restored" appearing on top of the page instead of "your edit was saved" after switching to edit source mode and saving the page from there - 10https://bugzilla.wikimedia.org/65269#c3 (10Alex Monk) 5PAT>3RES/FIX Should be fixed now. [21:40:40] 3VisualEditor / 3Editing Tools: VisualEditor: The Advanced Settings opens up as a default tab for an image if that was the tab user opened for the last edited image - 10https://bugzilla.wikimedia.org/65318 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15388 --> https://bugzilla.w... [21:42:24] 3VisualEditor / 3Editing Tools: VisualEditor: The Advanced Settings opens up as a default tab for an image if that was the tab user opened for the last edited image - 10https://bugzilla.wikimedia.org/65318#c1 (10Roan Kattouw) a:3Trevor Parscal This sounds like a problem with BookletLayout. Trevor? [21:43:08] 3VisualEditor / 3MediaWiki integration: VisualEditor: "The page has been restored" appearing on top of the page instead of "your edit was saved" after switching to edit source mode and saving the page from there - 10https://bugzilla.wikimedia.org/65269#c4 (10ryasmeen) Verified the fix on Betalabs [21:59:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: VE should hide PageTriage bar on edit if it's visible on the page - 10https://bugzilla.wikimedia.org/56731#c1 (10Alex Monk) (In reply to Chris McMahon from comment #0) > PageTriage UI should not appear on User pages Was a bug logged against PageTriage fo... [22:05:10] (03PS1) 10Catrope: Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 [22:06:10] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 (owner: 10Catrope) [22:06:58] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 (owner: 10Catrope) [22:08:28] (03PS2) 10Catrope: Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 [22:09:13] Krinkle: wtf?!?! https://integration.wikimedia.org/ci/job/mwext-VisualEditor-npm/2552/console [22:09:43] Not a new error either, it's not caused by that change apparently [22:10:25] No, it's caused by the VE core changes [22:10:32] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 (owner: 10Catrope) [22:10:39] RoanKattouw: Yeah, buildloader task changed [22:10:44] f02286b build: [BREAKING CHANGE] Add dependency expression [22:10:44] Right [22:10:46] That one [22:10:51] target -> targetFile [22:10:58] https://gerrit.wikimedia.org/r/#/c/127835/ - not strictly VE, but I discovered it in a VE bug so.. [22:11:12] Yup [22:11:15] I see [22:11:15] https://gerrit.wikimedia.org/r/#/c/123875/ - VE, but not in our repos so it doesn't show on the dashboard etc. [22:11:46] Yay now I have a different error message [22:11:49] This one is hilarious [22:11:50] Warning: Unable to write "undefined" file (Error code: undefined). Use --force to continue. [22:15:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: VE should hide PageTriage bar on edit if it's visible on the page - 10https://bugzilla.wikimedia.org/56731#c2 (10Chris McMahon) I don't believe I logged a bug against PageTriage at the time. [22:20:31] (03PS1) 10Alex Monk: Hide PageTriage curation toolbar while VE is open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133379 (https://bugzilla.wikimedia.org/56731) [22:26:42] Krinkle: Halp? [22:27:07] RoanKattouw: Pass --stack to 'grunt test' as a first step [22:27:08] Krinkle: nm got it [22:27:10] Stupid submodule [22:28:12] (03PS3) 10Catrope: Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 [22:28:46] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 (owner: 10Catrope) [22:30:51] (03Merged) 10jenkins-bot: Update VE core submodule to master (19be0c1) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133377 (owner: 10Catrope) [22:31:22] 3VisualEditor / 3MediaWiki integration: VisualEditor: If a link that doesn't have a pipe is changed, the link target remains - 10https://bugzilla.wikimedia.org/57506#c2 (10Alex Monk) (In reply to Amir E. Aharoni from comment #0) > Consider that you have an internal wiki link that doesn't use a pipe, for > ex... [22:31:25] James_F, ^ [22:32:53] 3VisualEditor / 3Editing Tools: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - 10https://bugzilla.wikimedia.org/54947#c2 (10James Forrester) *** Bug 57506 has been marked as a duplicate of this bug. *** [22:32:54] Krenair: If you're going to keep looking at un-triaged bugs you're going to have a bad time. :-) [22:32:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: If a link that doesn't have a pipe is changed, the link target remains - 10https://bugzilla.wikimedia.org/57506#c3 (10James Forrester) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 54947 *** [22:34:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: "The page has been restored" appearing on top of the page instead of "your edit was saved" after switching to edit source mode and saving the page from there - 10https://bugzilla.wikimedia.org/65269 (10James Forrester) a:3Alex Monk [22:35:54] 3VisualEditor / 3Editing Tools: VisualEditor: Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314#c1 (10ryasmeen) Found the steps to reproduce: 1.Insert any image 2.Go to Media Settings>Advanced Settings 3.Select Custom tab and change the values 4.Apply... [22:36:09] 3VisualEditor / 3Editing Tools: VisualEditor: Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314 (10ryasmeen) a:3Moriel Schottlender [22:37:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314 (10ryasmeen) [22:49:37] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314#c2 (10Roan Kattouw) It seems likely that this is due to cache pollution of the promise cache introduced in https://gerrit.wikimedia.org... [22:54:37] (03PS1) 10Catrope: Revert "Cache image scalable promises by filename" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133384 [22:54:49] (03PS2) 10Catrope: Revert "Cache image scalable promises by filename" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133384 (https://bugzilla.wikimedia.org/65314) [22:54:58] (03CR) 10Catrope: [C: 032] Revert "Cache image scalable promises by filename" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133384 (https://bugzilla.wikimedia.org/65314) (owner: 10Catrope) [22:55:21] :-( [22:56:24] (03CR) 10Catrope: "This caused bug 65314. When the scalable promise is retrieved a second time, the .then() handler isn't run, but the code in that handler i" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132207 (owner: 10Mooeypoo) [22:56:40] (03Merged) 10jenkins-bot: Revert "Cache image scalable promises by filename" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133384 (https://bugzilla.wikimedia.org/65314) (owner: 10Catrope) [22:56:53] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Make full size button remains disabled for any image in Betalabs - 10https://bugzilla.wikimedia.org/65314 (10Roan Kattouw) 5PAT>3RES/FIX [22:57:23] James_F: Yeah, cache pollution problems [22:57:26] James_F: Also, sleeeep [22:57:33] RoanKattouw: Yes, dear. :-P [22:58:13] RoanKattouw: I'd point out that I'm in the exact same timezone (and conurbation!) as Krenair and edsanders, the same timezone as divec, and the same proper timezone as Krinkle. [22:58:18] But yes, off now. [22:58:21] * James_F waves. [22:59:15] Pff, I'm not in London :p [22:59:28] TrevorParscal, I was thinking of this as special functionality for the confirm dialog [22:59:40] or at least special functionality for when the footer is focused [22:59:48] The difference is, none of those people will wake up at 6am :P [23:00:37] (03PS15) 10Catrope: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [23:00:47] (03CR) 10Catrope: [C: 032] Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [23:01:42] (03CR) 10Catrope: [C: 032] "Grumble... ideally this would be done using a hook that PageTriage registers for." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133379 (https://bugzilla.wikimedia.org/56731) (owner: 10Alex Monk) [23:02:35] RoanKattouw, we could still do that [23:02:41] (03Merged) 10jenkins-bot: Swap from using native confirm() to using an OOUI dialog when cancelling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/130394 (https://bugzilla.wikimedia.org/50955) (owner: 10Alex Monk) [23:02:45] you didn't have to approve it [23:02:55] It's a Wednesday :) [23:02:55] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create hooks for extensions to show/hide things when VE activates/deactivates - 10https://bugzilla.wikimedia.org/65320 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Alex Monk A more generic way of doing https://gerrit.wikimedia.org/r/133379 [23:03:00] Today I just want things to be fixed [23:03:11] (03CR) 10Catrope: "Tech debt bug 65320 filed for this" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133379 (https://bugzilla.wikimedia.org/56731) (owner: 10Alex Monk) [23:04:15] (03Merged) 10jenkins-bot: Hide PageTriage curation toolbar while VE is open [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133379 (https://bugzilla.wikimedia.org/56731) (owner: 10Alex Monk) [23:06:09] 3VisualEditor / 3MediaWiki integration: VisualEditor: VE should hide PageTriage bar on edit if it's visible on the page - 10https://bugzilla.wikimedia.org/56731 (10Alex Monk) 5PAT>3RES/FIX a:3Alex Monk [23:06:18] (03PS2) 10Catrope: If no media is found display a message in media insert dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133050 (https://bugzilla.wikimedia.org/52463) (owner: 10Mooeypoo) [23:06:24] 3VisualEditor / 3Technical Debt: VisualEditor: Use $.when() rather than sourceCount in MediaSearchWidget - 10https://bugzilla.wikimedia.org/65321 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Moriel Schottlender See inline comment on https://gerrit.wikimedia.org/r/#/c/133050/1/modules/ve-mw/ui/widgets... [23:08:22] (03PS3) 10Catrope: If no media is found display a message in media insert dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133050 (https://bugzilla.wikimedia.org/52463) (owner: 10Mooeypoo) [23:08:34] (03CR) 10Catrope: [C: 032] If no media is found display a message in media insert dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133050 (https://bugzilla.wikimedia.org/52463) (owner: 10Mooeypoo) [23:09:22] 3VisualEditor / 3Editing Tools: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - 10https://bugzilla.wikimedia.org/52463 (10Roan Kattouw) 5PAT>3RES/FIX [23:09:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create hooks for extensions to show/hide things when VE activates/deactivates - 10https://bugzilla.wikimedia.org/65320 (10Alex Monk) 5NEW>3ASS [23:10:24] (03Merged) 10jenkins-bot: If no media is found display a message in media insert dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133050 (https://bugzilla.wikimedia.org/52463) (owner: 10Mooeypoo) [23:14:40] 3VisualEditor / 3Editing Tools: VisualEditor: Font is too small in dialogs in standalone VE - 10https://bugzilla.wikimedia.org/65322 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Trevor Parscal Compare the keyboard shortcut help dialog (Ctrl+/) in the standalone demo vs the MW integration. The one in... [23:15:43] (03CR) 10Catrope: [C: 032] Move shortcut keys help from "Page options" dropdown to "Help" popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132911 (owner: 10Bartosz Dziewoński) [23:16:49] (03Merged) 10jenkins-bot: Move shortcut keys help from "Page options" dropdown to "Help" popup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/132911 (owner: 10Bartosz Dziewoński) [23:16:51] (03PS1) 10Catrope: Remove MWCommandHelpDialogTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133391 [23:26:51] (03CR) 10Catrope: "Note that this changes the appearance of the Apply Changes button in the current skins by adding the check icon before the text. This may " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/132353 (owner: 10JGonera) [23:27:25] (03Abandoned) 10Catrope: Update VE core submodule to master (c782d4c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133174 (owner: 10Jforrester) [23:27:33] (03PS1) 10Alex Monk: Fire hook when VE activates/deactivates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133394 (https://bugzilla.wikimedia.org/65320) [23:28:01] (03CR) 10Catrope: [C: 032] Fire hook when VE activates/deactivates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133394 (https://bugzilla.wikimedia.org/65320) (owner: 10Alex Monk) [23:28:23] (03CR) 10Catrope: [C: 032] inheritdoc lowercase [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133258 (owner: 10Esanders) [23:29:25] (03Merged) 10jenkins-bot: inheritdoc lowercase [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/133258 (owner: 10Esanders) [23:29:35] (03Merged) 10jenkins-bot: Fire hook when VE activates/deactivates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/133394 (https://bugzilla.wikimedia.org/65320) (owner: 10Alex Monk) [23:35:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Create hooks for extensions to show/hide things when VE activates/deactivates - 10https://bugzilla.wikimedia.org/65320 (10Alex Monk) 5PAT>3RES/FIX [23:40:37] (03PS37) 10Catrope: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [23:40:49] (03CR) 10jenkins-bot: [V: 04-1] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [23:40:51] (03PS38) 10Catrope: Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [23:41:02] (03CR) 10jenkins-bot: [V: 04-1] Image model and the media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/120808 (owner: 10Mooeypoo) [23:49:15] RoanKattouw: The obvious first bug report is that File: pages don't show the image in the edit view :) [23:49:38] lol